From ksakata at openjdk.java.net Tue Apr 13 03:19:20 2021 From: ksakata at openjdk.java.net (Koichi Sakata) Date: Tue, 13 Apr 2021 03:19:20 GMT Subject: RFR: 7902855: make/build.sh fails when OpenJDK is specified for --jdk option Message-ID: When we specify not Oracle JDK but OpenJDK for --jdk option, make/build.sh fails. $ ~/jdk8u282-b08/bin/java -version openjdk version "1.8.0_282" OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_282-b08) OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.282-b08, mixed mode) $ bash make/build.sh --jdk ~/jdk8u282-b08 [build.sh][ERROR] JDK 8 or newer is required to build jtreg This is caused by a difference in the output of `java -version` command between OpenJDK and Oracle JDK. $ ~/jdk1.8.0_281/bin/java -version java version "1.8.0_281" Java(TM) SE Runtime Environment (build 1.8.0_281-b09) Java HotSpot(TM) Server VM (build 25.281-b09, mixed mode) $ bash make/build.sh --jdk ~/jdk1.8.0_281 [build.sh][INFO] JAVA_HOME: /home/jyukutyo/jdk1.8.0_281 ... cd /home/jyukutyo/jtreg/build/images; /usr/bin/zip -rq /home/jyukutyo/jtreg/build/images/jtreg.zip jtreg So this pull request enables to build jtreg with OpenJDK based distributions. ------------- Commit messages: - Enable to build with OpenJDK based distributions Changes: https://git.openjdk.java.net/jtreg/pull/7/files Webrev: https://webrevs.openjdk.java.net/?repo=jtreg&pr=7&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-7902855 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jtreg/pull/7.diff Fetch: git fetch https://git.openjdk.java.net/jtreg pull/7/head:pull/7 PR: https://git.openjdk.java.net/jtreg/pull/7 From stuefe at openjdk.java.net Fri Apr 30 08:36:56 2021 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Fri, 30 Apr 2021 08:36:56 GMT Subject: RFR: 7902821: Jtreg plugin fails to compile with latest Intellij (2020.3) In-Reply-To: References: Message-ID: On Tue, 26 Jan 2021 15:46:58 GMT, Maurizio Cimadamore wrote: > Remove @Override which caused compilation failure in latest Intellij. I am not a CODETOOLS reviewer, so I cannot officially approve this. But this fixes my compile error with IntelliJ 2020.3. Thanks for fixing this. ------------- Marked as reviewed by stuefe (no project role). PR: https://git.openjdk.java.net/jtreg/pull/2 From stuefe at openjdk.java.net Fri Apr 30 09:07:15 2021 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Fri, 30 Apr 2021 09:07:15 GMT Subject: RFR: 7902912: Update IntelliJ Plugin build Readme Message-ID: Hi, may I have reviews for this small documentation fix please? I am not a CODETOOLS committer so I may need someone to sponsor this fix. Since I just built the intellij plugin in 2020.3, I stumbled about a couple of ambiguous infos which are not immediately clear to outsiders. -> some UI features changed in Intellij -> Clarified the meaning of JTREG_HOME -> One thing I was not sure about was the required SDK level to build the plugin. The documentation says "Any JDK 8 is fine" which I took as "JDK8 is required" - proceeded to download JDK 8 but then I was unable to choose this JDK as a SDK for the IDEA JDK. It was, however, happy with a JDK 15 I gave it, and proceeded to build the plugin without any issues. Therefore I changed the sentence to "Any JDK 8++ is a fine choice". ------------- Commit messages: - start Changes: https://git.openjdk.java.net/jtreg/pull/8/files Webrev: https://webrevs.openjdk.java.net/?repo=jtreg&pr=8&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-7902912 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jtreg/pull/8.diff Fetch: git fetch https://git.openjdk.java.net/jtreg pull/8/head:pull/8 PR: https://git.openjdk.java.net/jtreg/pull/8 From mcimadamore at openjdk.java.net Fri Apr 30 13:31:59 2021 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Fri, 30 Apr 2021 13:31:59 GMT Subject: RFR: 7902912: Update IntelliJ Plugin build Readme In-Reply-To: References: Message-ID: On Fri, 30 Apr 2021 08:58:00 GMT, Thomas Stuefe wrote: > Hi, may I have reviews for this small documentation fix please? I am not a CODETOOLS committer so I may need someone to sponsor this fix. > > Since I just built the intellij plugin in 2020.3, I stumbled about a couple of ambiguous infos which are not immediately clear to outsiders. > > -> some UI features changed in Intellij > -> Clarified the meaning of JTREG_HOME > -> One thing I was not sure about was the required SDK level to build the plugin. The documentation says "Any JDK 8 is fine" which I took as "JDK8 is required" - proceeded to download JDK 8 but then I was unable to choose this JDK as a SDK for the IDEA JDK. It was, however, happy with a JDK 15 I gave it, and proceeded to build the plugin without any issues. Therefore I changed the sentence to "Any JDK 8++ is a fine choice". Looks great - thanks! I've added a small suggestion. plugins/idea/README.md line 40: > 38: * When the IDE project for the plugin is first opened, IntelliJ will complain about the lack of a path variable called `JTREG_HOME`. Please follow the IDE instructions, and set this path variable to point to the root of your jtreg build output or your jtreg installation (`JTREG_HOME/libs/javatest.jar` must exist). The setting can also be found in under `Settings -> Appearance and Behavior -> Path Variables`. This step is required as the project depends on some of the jtreg libraries. > 39: > 40: * You need to create an Intellij SDK and name it `IDEA JDK` for the project to work correctly. To create a new SDK, click on `File -> Project Structure`. When the dialog opens, click on the `SDKs` entry in the left pane, and add a new SDK (by clicking on the *plus* icon). The SDK we want to create is an 'IntelliJ Platform Plugin SDK'. Once the new SDK type has been selected, you will have to tell IntelliJ what's the SDK path - you will see that IntelliJ will already point to the folder containing your IntelliJ installation - that is a fine choice. Rename it to `IDEA JDK`. Secondly, you will have to tell IntelliJ which JDK to use together with the plugin SDK. Any JDK 8++ is a fine choice here. Suggestion: * You need to create an Intellij SDK and name it `IDEA JDK` for the project to work correctly. To create a new SDK, click on `File -> Project Structure`. When the dialog opens, click on the `SDKs` entry in the left pane, and add a new SDK (by clicking on the *plus* icon). The SDK we want to create is an 'IntelliJ Platform Plugin SDK'. Once the new SDK type has been selected, you will have to tell IntelliJ what's the SDK path - you will see that IntelliJ will already point to the folder containing your IntelliJ installation - that is a fine choice. Rename it to `IDEA JDK`. Secondly, you will have to tell IntelliJ which JDK to use together with the plugin SDK. Any JDK 8 (or greater) is a fine choice here. ------------- Marked as reviewed by mcimadamore (Committer). PR: https://git.openjdk.java.net/jtreg/pull/8 From mcimadamore at openjdk.java.net Fri Apr 30 13:37:41 2021 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Fri, 30 Apr 2021 13:37:41 GMT Subject: git: openjdk/jtreg: 7902821: Jtreg plugin fails to compile with latest Intellij (2020.3) Message-ID: <50235cc9-9622-4fc9-b684-45c398e5ebf8@openjdk.org> Changeset: fd0dfd6a Author: Maurizio Cimadamore Date: 2021-04-30 13:37:24 +0000 URL: https://git.openjdk.java.net/jtreg/commit/fd0dfd6a50a7a9911d42b607771bc423ec9b0c3e 7902821: Jtreg plugin fails to compile with latest Intellij (2020.3) Reviewed-by: stuefe ! plugins/idea/resources/META-INF/plugin.xml ! plugins/idea/src/com/oracle/plugin/jtreg/configuration/JTRegConfigurationRunnableState.java From mcimadamore at openjdk.java.net Fri Apr 30 13:40:07 2021 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Fri, 30 Apr 2021 13:40:07 GMT Subject: RFR: 7902821: Jtreg plugin fails to compile with latest Intellij (2020.3) [v2] In-Reply-To: References: Message-ID: <95y_KJMselesQ_B57V9Ll2ZBUId2Kvcbbb3W-2IPpfA=.bed7d0ba-1781-4523-b002-5c667b0b7a01@github.com> > Remove @Override which caused compilation failure in latest Intellij. Maurizio Cimadamore has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge branch 'master' into jtregfix_2021_v11 - Remove @Override which caused compilation failure in latest Intellij ------------- Changes: https://git.openjdk.java.net/jtreg/pull/2/files Webrev: https://webrevs.openjdk.java.net/?repo=jtreg&pr=2&range=01 Stats: 2 lines in 2 files changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jtreg/pull/2.diff Fetch: git fetch https://git.openjdk.java.net/jtreg pull/2/head:pull/2 PR: https://git.openjdk.java.net/jtreg/pull/2 From mcimadamore at openjdk.java.net Fri Apr 30 13:40:08 2021 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Fri, 30 Apr 2021 13:40:08 GMT Subject: Integrated: 7902821: Jtreg plugin fails to compile with latest Intellij (2020.3) In-Reply-To: References: Message-ID: On Tue, 26 Jan 2021 15:46:58 GMT, Maurizio Cimadamore wrote: > Remove @Override which caused compilation failure in latest Intellij. This pull request has now been integrated. Changeset: fd0dfd6a Author: Maurizio Cimadamore URL: https://git.openjdk.java.net/jtreg/commit/fd0dfd6a50a7a9911d42b607771bc423ec9b0c3e Stats: 2 lines in 2 files changed: 0 ins; 1 del; 1 mod 7902821: Jtreg plugin fails to compile with latest Intellij (2020.3) Reviewed-by: stuefe ------------- PR: https://git.openjdk.java.net/jtreg/pull/2 From stuefe at openjdk.java.net Fri Apr 30 13:42:20 2021 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Fri, 30 Apr 2021 13:42:20 GMT Subject: RFR: 7902912: Update IntelliJ Plugin build Readme [v2] In-Reply-To: References: Message-ID: <61aQdSN0YVdD-FDTSBx3f5R5m_bW_6TAmP62QreEmNo=.735fb46c-3895-42d5-9d00-506d7e6da6c5@github.com> > Hi, may I have reviews for this small documentation fix please? I am not a CODETOOLS committer so I may need someone to sponsor this fix. > > Since I just built the intellij plugin in 2020.3, I stumbled about a couple of ambiguous infos which are not immediately clear to outsiders. > > -> some UI features changed in Intellij > -> Clarified the meaning of JTREG_HOME > -> One thing I was not sure about was the required SDK level to build the plugin. The documentation says "Any JDK 8 is fine" which I took as "JDK8 is required" - proceeded to download JDK 8 but then I was unable to choose this JDK as a SDK for the IDEA JDK. It was, however, happy with a JDK 15 I gave it, and proceeded to build the plugin without any issues. Therefore I changed the sentence to "Any JDK 8++ is a fine choice". Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision: Update plugins/idea/README.md Co-authored-by: Maurizio Cimadamore <54672762+mcimadamore at users.noreply.github.com> ------------- Changes: - all: https://git.openjdk.java.net/jtreg/pull/8/files - new: https://git.openjdk.java.net/jtreg/pull/8/files/eda907c8..494ed425 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=8&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=8&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jtreg/pull/8.diff Fetch: git fetch https://git.openjdk.java.net/jtreg pull/8/head:pull/8 PR: https://git.openjdk.java.net/jtreg/pull/8 From stuefe at openjdk.java.net Fri Apr 30 13:42:20 2021 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Fri, 30 Apr 2021 13:42:20 GMT Subject: RFR: 7902912: Update IntelliJ Plugin build Readme In-Reply-To: References: Message-ID: On Fri, 30 Apr 2021 08:58:00 GMT, Thomas Stuefe wrote: > Hi, may I have reviews for this small documentation fix please? I am not a CODETOOLS committer so I may need someone to sponsor this fix. > > Since I just built the intellij plugin in 2020.3, I stumbled about a couple of ambiguous infos which are not immediately clear to outsiders. > > -> some UI features changed in Intellij > -> Clarified the meaning of JTREG_HOME > -> One thing I was not sure about was the required SDK level to build the plugin. The documentation says "Any JDK 8 is fine" which I took as "JDK8 is required" - proceeded to download JDK 8 but then I was unable to choose this JDK as a SDK for the IDEA JDK. It was, however, happy with a JDK 15 I gave it, and proceeded to build the plugin without any issues. Therefore I changed the sentence to "Any JDK 8++ is a fine choice". Thanks, Maurizio! I took your suggestion. Feel free to sponsor this change, as I said, I am not a committer for codetools. ------------- PR: https://git.openjdk.java.net/jtreg/pull/8 From mcimadamore at openjdk.java.net Fri Apr 30 13:48:00 2021 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Fri, 30 Apr 2021 13:48:00 GMT Subject: RFR: 7902912: Update IntelliJ Plugin build Readme [v2] In-Reply-To: <61aQdSN0YVdD-FDTSBx3f5R5m_bW_6TAmP62QreEmNo=.735fb46c-3895-42d5-9d00-506d7e6da6c5@github.com> References: <61aQdSN0YVdD-FDTSBx3f5R5m_bW_6TAmP62QreEmNo=.735fb46c-3895-42d5-9d00-506d7e6da6c5@github.com> Message-ID: On Fri, 30 Apr 2021 13:42:20 GMT, Thomas Stuefe wrote: >> Hi, may I have reviews for this small documentation fix please? I am not a CODETOOLS committer so I may need someone to sponsor this fix. >> >> Since I just built the intellij plugin in 2020.3, I stumbled about a couple of ambiguous infos which are not immediately clear to outsiders. >> >> -> some UI features changed in Intellij >> -> Clarified the meaning of JTREG_HOME >> -> One thing I was not sure about was the required SDK level to build the plugin. The documentation says "Any JDK 8 is fine" which I took as "JDK8 is required" - proceeded to download JDK 8 but then I was unable to choose this JDK as a SDK for the IDEA JDK. It was, however, happy with a JDK 15 I gave it, and proceeded to build the plugin without any issues. Therefore I changed the sentence to "Any JDK 8++ is a fine choice". > > Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision: > > Update plugins/idea/README.md > > Co-authored-by: Maurizio Cimadamore <54672762+mcimadamore at users.noreply.github.com> you have to `/integrate` I think then I can sponsor ------------- PR: https://git.openjdk.java.net/jtreg/pull/8 From stuefe at openjdk.java.net Fri Apr 30 13:57:57 2021 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Fri, 30 Apr 2021 13:57:57 GMT Subject: RFR: 7902912: Update IntelliJ Plugin build Readme [v2] In-Reply-To: <61aQdSN0YVdD-FDTSBx3f5R5m_bW_6TAmP62QreEmNo=.735fb46c-3895-42d5-9d00-506d7e6da6c5@github.com> References: <61aQdSN0YVdD-FDTSBx3f5R5m_bW_6TAmP62QreEmNo=.735fb46c-3895-42d5-9d00-506d7e6da6c5@github.com> Message-ID: On Fri, 30 Apr 2021 13:42:20 GMT, Thomas Stuefe wrote: >> Hi, may I have reviews for this small documentation fix please? I am not a CODETOOLS committer so I may need someone to sponsor this fix. >> >> Since I just built the intellij plugin in 2020.3, I stumbled about a couple of ambiguous infos which are not immediately clear to outsiders. >> >> -> some UI features changed in Intellij >> -> Clarified the meaning of JTREG_HOME >> -> One thing I was not sure about was the required SDK level to build the plugin. The documentation says "Any JDK 8 is fine" which I took as "JDK8 is required" - proceeded to download JDK 8 but then I was unable to choose this JDK as a SDK for the IDEA JDK. It was, however, happy with a JDK 15 I gave it, and proceeded to build the plugin without any issues. Therefore I changed the sentence to "Any JDK 8++ is a fine choice". > > Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision: > > Update plugins/idea/README.md > > Co-authored-by: Maurizio Cimadamore <54672762+mcimadamore at users.noreply.github.com> Ah, you are right... This got so much easier with Skara. ------------- PR: https://git.openjdk.java.net/jtreg/pull/8 From stuefe at openjdk.java.net Fri Apr 30 14:34:58 2021 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Fri, 30 Apr 2021 14:34:58 GMT Subject: Integrated: 7902912: Update IntelliJ Plugin build Readme In-Reply-To: References: Message-ID: On Fri, 30 Apr 2021 08:58:00 GMT, Thomas Stuefe wrote: > Hi, may I have reviews for this small documentation fix please? I am not a CODETOOLS committer so I may need someone to sponsor this fix. > > Since I just built the intellij plugin in 2020.3, I stumbled about a couple of ambiguous infos which are not immediately clear to outsiders. > > -> some UI features changed in Intellij > -> Clarified the meaning of JTREG_HOME > -> One thing I was not sure about was the required SDK level to build the plugin. The documentation says "Any JDK 8 is fine" which I took as "JDK8 is required" - proceeded to download JDK 8 but then I was unable to choose this JDK as a SDK for the IDEA JDK. It was, however, happy with a JDK 15 I gave it, and proceeded to build the plugin without any issues. Therefore I changed the sentence to "Any JDK 8++ is a fine choice". This pull request has now been integrated. Changeset: 1a41b1d0 Author: Thomas Stuefe Committer: Maurizio Cimadamore URL: https://git.openjdk.java.net/jtreg/commit/1a41b1d0a3032f37d90ff10d14f0fa45564180cb Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 7902912: Update IntelliJ Plugin build Readme Reviewed-by: mcimadamore ------------- PR: https://git.openjdk.java.net/jtreg/pull/8