From mcimadamore at openjdk.java.net Tue Aug 3 11:52:50 2021 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Tue, 3 Aug 2021 11:52:50 GMT Subject: RFR: 7903005: jtreg plugin does not work with intellij 2021.2 Message-ID: This patch adds support for 2021.2. I've bumped the dependency on the gradle IntelliJ plugin. I've also tweked the way in which the supported IDE versions are set, by tweaking the `patchXML` task to set the correct `since` build. Turns out, the previously generated plugin.xml had a IJ version hardcoded in it, due to bad gradle configuration. ------------- Commit messages: - Merge branch 'master' into 2021_2_support - Add support for 2021.2 - Add logic for discovering all jars in the jtreg lib folder Changes: https://git.openjdk.java.net/jtreg/pull/19/files Webrev: https://webrevs.openjdk.java.net/?repo=jtreg&pr=19&range=00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903005 Stats: 8 lines in 2 files changed: 2 ins; 1 del; 5 mod Patch: https://git.openjdk.java.net/jtreg/pull/19.diff Fetch: git fetch https://git.openjdk.java.net/jtreg pull/19/head:pull/19 PR: https://git.openjdk.java.net/jtreg/pull/19 From stuefe at openjdk.java.net Wed Aug 4 06:12:51 2021 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Wed, 4 Aug 2021 06:12:51 GMT Subject: RFR: CODETOOLS-7903006: Upgrade jtreg plugin to IntelliJ 2021.2 Message-ID: Hi, could we update target platform version to 21.2? There were no issues with the build, plugin works fine (IntelliJ 2021.2 on Ubuntu x64). Thanks, Thomas ------------- Commit messages: - start Changes: https://git.openjdk.java.net/jtreg/pull/20/files Webrev: https://webrevs.openjdk.java.net/?repo=jtreg&pr=20&range=00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903006 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jtreg/pull/20.diff Fetch: git fetch https://git.openjdk.java.net/jtreg pull/20/head:pull/20 PR: https://git.openjdk.java.net/jtreg/pull/20 From jjg at openjdk.java.net Wed Aug 4 15:46:44 2021 From: jjg at openjdk.java.net (Jonathan Gibbons) Date: Wed, 4 Aug 2021 15:46:44 GMT Subject: RFR: 7903005: jtreg plugin does not work with intellij 2021.2 In-Reply-To: References: Message-ID: On Tue, 3 Aug 2021 11:47:29 GMT, Maurizio Cimadamore wrote: > This patch adds support for 2021.2. > I've bumped the dependency on the gradle IntelliJ plugin. > I've also tweked the way in which the supported IDE versions are set, by tweaking the `patchXML` task to set the correct `since` build. > Turns out, the previously generated plugin.xml had a IJ version hardcoded in it, due to bad gradle configuration. I can't comment on the specific details, but the charges look "reasonable". ------------- Marked as reviewed by jjg (Lead). PR: https://git.openjdk.java.net/jtreg/pull/19 From mcimadamore at openjdk.java.net Wed Aug 4 16:39:43 2021 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Wed, 4 Aug 2021 16:39:43 GMT Subject: Integrated: 7903005: jtreg plugin does not work with intellij 2021.2 In-Reply-To: References: Message-ID: On Tue, 3 Aug 2021 11:47:29 GMT, Maurizio Cimadamore wrote: > This patch adds support for 2021.2. > I've bumped the dependency on the gradle IntelliJ plugin. > I've also tweked the way in which the supported IDE versions are set, by tweaking the `patchXML` task to set the correct `since` build. > Turns out, the previously generated plugin.xml had a IJ version hardcoded in it, due to bad gradle configuration. This pull request has now been integrated. Changeset: e0bc9652 Author: Maurizio Cimadamore URL: https://git.openjdk.java.net/jtreg/commit/e0bc9652255881f12e770434f1e4ac85190c3166 Stats: 8 lines in 2 files changed: 2 ins; 1 del; 5 mod 7903005: jtreg plugin does not work with intellij 2021.2 Reviewed-by: jjg ------------- PR: https://git.openjdk.java.net/jtreg/pull/19 From jonathan.gibbons at oracle.com Sat Aug 7 02:14:26 2021 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Sat, 7 Aug 2021 02:14:26 GMT Subject: git: openjdk/jtreg: 3 new changesets Message-ID: Changeset: 1aabb70c Author: Jonathan Gibbons Date: 2021-07-13 09:40:42 +0000 URL: https://git.openjdk.java.net/jtreg/commit/1aabb70ce3e0170ca1ed456b6a841b23b4ab0c25 CODETOOLS-7902995: Update/Improve jcheck settings for jtreg repo ! .jcheck/conf Changeset: 05340ce6 Author: Jonathan Gibbons Date: 2021-07-13 09:46:33 +0000 URL: https://git.openjdk.java.net/jtreg/commit/05340ce66984f93d1780fe9e95f89baf7bb02b48 add final newline ! .jcheck/conf Changeset: 3ead1aa4 Author: Jonathan Gibbons Date: 2021-08-04 14:40:25 +0000 URL: https://git.openjdk.java.net/jtreg/commit/3ead1aa49e7140969261b71f23fd16d229e4d6a5 Merge remote-tracking branch 'upstream/master' into 7902995.jcheck From duke at openjdk.java.net Sat Aug 7 04:16:31 2021 From: duke at openjdk.java.net (duke) Date: Sat, 7 Aug 2021 04:16:31 GMT Subject: git: openjdk/jtreg: 2 new changesets Message-ID: <1930804e-e20f-4489-92f8-4cfb85d19f74@openjdk.java.net> Changeset: 2182a7fb Author: Jonathan Gibbons Date: 2021-08-06 20:59:29 +0000 URL: https://git.openjdk.java.net/jtreg/commit/2182a7fbb5d5680212384e690b0debec469cb660 CODETOOLS-7903009: Set streams when RegressionSecurityManager not used ! src/share/classes/com/sun/javatest/regtest/agent/ActionHelper.java Changeset: e194fbff Author: Jonathan Gibbons <61436102+jonathan-gibbons at users.noreply.github.com> Committer: GitHub Date: 2021-08-06 21:15:53 +0000 URL: https://git.openjdk.java.net/jtreg/commit/e194fbffefcdb967772e052980bb0df654b9bf06 Merge pull request #22 from jonathan-gibbons/7903009.setStreams CODETOOLS-7903009: Set streams when RegressionSecurityManager not used From duke at openjdk.java.net Sat Aug 7 15:58:31 2021 From: duke at openjdk.java.net (duke) Date: Sat, 7 Aug 2021 15:58:31 GMT Subject: git: openjdk/jtreg: 7902942: Elapsed time of MainAction is including serialization wait time (#11) Message-ID: Changeset: 1360423a Author: Stefan Karlsson Committer: GitHub Date: 2021-08-07 17:57:55 +0000 URL: https://git.openjdk.java.net/jtreg/commit/1360423a1cbea21bf02a138c4f5489696d469c02 7902942: Elapsed time of MainAction is including serialization wait time (#11) * 7902822: Elapsed time of MainAction is including serialization wait time * Also move endAction into the lock scope ! src/share/classes/com/sun/javatest/regtest/exec/MainAction.java From jjg at openjdk.java.net Sat Aug 7 16:01:38 2021 From: jjg at openjdk.java.net (Jonathan Gibbons) Date: Sat, 7 Aug 2021 16:01:38 GMT Subject: Withdrawn: 7902942: Elapsed time of MainAction is including serialization wait time In-Reply-To: <_gRvk3jBkeeCMf3o85MrTgHmhbf4LO8E7AJPn4Pjt8w=.aab0a64a-ac5f-43ea-a4ac-a71fb648e1bb@github.com> References: <_gRvk3jBkeeCMf3o85MrTgHmhbf4LO8E7AJPn4Pjt8w=.aab0a64a-ac5f-43ea-a4ac-a71fb648e1bb@github.com> Message-ID: <5c__esxtS0cUREtOknNyM8wqC82dzjmTmyEMhz8mHu0=.00654450-8897-46a9-8777-317f6bc35f7c@github.com> On Mon, 24 May 2021 07:10:55 GMT, Stefan Karlsson wrote: > If you run othervm tests with a concurrency > 1, then the reported test times get inflated. You can see this by running: > make -C ../build/fastdebug test TEST=test/hotspot/jtreg/vmTestbase/vm/gc/compact JTREG="VERBOSE=all" > > and looking at the elapsed time for the main action: > > $ grep -r "othervm specified" -A1 jtreg_open_test_hotspot_jtreg_vmTestbase_vm_gc_compact/jtreg.log | grep elapsed > elapsed time (seconds): 121.194 > elapsed time (seconds): 240.631 > elapsed time (seconds): 359.092 > elapsed time (seconds): 478.718 > elapsed time (seconds): 597.433 > elapsed time (seconds): 716.628 > elapsed time (seconds): 836.638 > elapsed time (seconds): 955.156 > elapsed time (seconds): 1074.476 > elapsed time (seconds): 1193.712 > elapsed time (seconds): 1314.116 > elapsed time (seconds): 1433.632 > elapsed time (seconds): 1553.563 > elapsed time (seconds): 1672.996 > elapsed time (seconds): 1792.846 > elapsed time (seconds): 1913.112 > elapsed time (seconds): 1926.819 > elapsed time (seconds): 1926.809 > elapsed time (seconds): 1926.921 > elapsed time (seconds): 1927.093 > elapsed time (seconds): 1927.192 > elapsed time (seconds): 1927.07 > elapsed time (seconds): 1926.896 > elapsed time (seconds): 1927.31 > elapsed time (seconds): 1927.244 > elapsed time (seconds): 1927.33 > elapsed time (seconds): 1927.221 > elapsed time (seconds): 1927.42 > elapsed time (seconds): 1927.158 > elapsed time (seconds): 1927.315 > elapsed time (seconds): 1927.316 > elapsed time (seconds): 1927.311 > elapsed time (seconds): 1927.532 > elapsed time (seconds): 1927.379 > > Each test is supposed to be run for 120 seconds, but the reported time ramps up in ~120s increments until it reaches the number that matches the "jtreg concurrency" number, which in my run is 16. > > I think this happens because we start "concurrent" tests. Each test starts by taking a timestamp, then looks if we need "exclusiveAccess" and if we do, then a lock is taken before the othervm test process is forked. This serializes the tests and inflates the times. > > The proposed fix moves the start of the action to after the lock has been acquired, and end of the action before releasing the lock. > > The patch has only been tested by running the following: > > make -C ../build/fastdebug test TEST=test/hotspot/jtreg/vmTestbase/vm/gc/compact JTREG="TIMEOUT_FACTOR=0.1" > > and manually verifying that the elapsed time stops increasing. Any guidance on how to further test this would be appreciated. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jtreg/pull/11 From jjg at openjdk.java.net Mon Aug 9 20:48:18 2021 From: jjg at openjdk.java.net (Jonathan Gibbons) Date: Mon, 9 Aug 2021 20:48:18 GMT Subject: RFR: CODETOOLS-7902995: Update/Improve jcheck settings for jtreg repo [v2] In-Reply-To: References: Message-ID: > Update to improve jcheck settings for the jtreg repo. > > Based on the equivalent file for the JDK repo. > > Here, for reference, are the diffs: > 2,3c2,4 > < project=jdk > < jbs=JDK > --- > > project=code-tools > > comments=lax > > jbs=CODETOOLS > 6c7 > < error=author,committer,reviewers,merge,issues,executable,symlink,message,hg-tag,whitespace,problemlists > --- > > error=author,committer,reviewers,merge,issues,executable,symlink,message,whitespace > 9c10 > < tags=(?:jdk-(?:[1-9]([0-9]*)(?:.(?:0|[1-9][0-9]*)){0,4})(?:+(?:(?:[0-9]+))|(?:-ga)))|(?:jdk[4-9](?:u\d{1,3})?-(?:(?:b\d{2,3})|(?:ga)))|(?:hs\d\d(?:.\d{1,2})?-b\d\d) > --- > > tags=jtreg(?:4.1-b[0-9]{2}|5.[01]-b[0-9]{2}|6|-[6789](?:.[0-9]+)?+[0-9]+) > 17c18 > < files=.*.cpp|.*.hpp|.*.c|.*.h|.*.java|.*.cc|.*.hh|.*.m|.*.mm|.*.gmk|.*.m4|.*.ac|Makefile > --- > > files=.*.java|.*.m|.*.mm|.*.gmk|.*.m4|.*.ac|Makefile > 24d24 > < reviewers=1 > 31,34c31 > < pattern=^([124-8][0-9]{6}): (\S.*)$ > < > < [checks "problemlists"] > < dirs=test/jdk|test/langtools|test/lib-test|test/hotspot/jtreg|test/jaxp > --- > > pattern=^(79[0-9]{5}): (\S.*)$ > \ No newline at end of file Jonathan Gibbons has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.java.net/jtreg/pull/18/files - new: https://git.openjdk.java.net/jtreg/pull/18/files/05340ce6..05340ce6 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=18&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=18&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jtreg/pull/18.diff Fetch: git fetch https://git.openjdk.java.net/jtreg pull/18/head:pull/18 PR: https://git.openjdk.java.net/jtreg/pull/18 From jjg at openjdk.java.net Mon Aug 9 21:50:59 2021 From: jjg at openjdk.java.net (Jonathan Gibbons) Date: Mon, 9 Aug 2021 21:50:59 GMT Subject: RFR: CODETOOLS-7903010: Delete obsolete build-all.sh and README-v5 files Message-ID: <1RQ8fXCmSovke-dTKmr8BEumupjk62gy23MfEp5Z4Lc=.d775332f-710f-49ae-b562-742a5cd23a75@github.com> Two files related to the previous iteration of the build system are deleted. ------------- Commit messages: - CODETOOLS-7903010: Delete obsolete build-all.sh and README-v5 files Changes: https://git.openjdk.java.net/jtreg/pull/23/files Webrev: https://webrevs.openjdk.java.net/?repo=jtreg&pr=23&range=00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903010 Stats: 513 lines in 2 files changed: 0 ins; 513 del; 0 mod Patch: https://git.openjdk.java.net/jtreg/pull/23.diff Fetch: git fetch https://git.openjdk.java.net/jtreg pull/23/head:pull/23 PR: https://git.openjdk.java.net/jtreg/pull/23 From iris at openjdk.java.net Mon Aug 9 23:10:40 2021 From: iris at openjdk.java.net (Iris Clark) Date: Mon, 9 Aug 2021 23:10:40 GMT Subject: RFR: CODETOOLS-7903010: Delete obsolete build-all.sh and README-v5 files In-Reply-To: <1RQ8fXCmSovke-dTKmr8BEumupjk62gy23MfEp5Z4Lc=.d775332f-710f-49ae-b562-742a5cd23a75@github.com> References: <1RQ8fXCmSovke-dTKmr8BEumupjk62gy23MfEp5Z4Lc=.d775332f-710f-49ae-b562-742a5cd23a75@github.com> Message-ID: On Mon, 9 Aug 2021 21:46:19 GMT, Jonathan Gibbons wrote: > Two files related to the previous iteration of the build system are deleted. Marked as reviewed by iris (Reviewer). ------------- PR: https://git.openjdk.java.net/jtreg/pull/23 From mcimadamore at openjdk.java.net Tue Aug 10 09:11:49 2021 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Tue, 10 Aug 2021 09:11:49 GMT Subject: RFR: 7903011: Small tweaks to jtreg plugin documentation Message-ID: I fixed a couple of hiccups in the toplevel and plugin-level README (the issues are described in JBS). The updated version of the document can be seen by visiting this branch: https://github.com/mcimadamore/jtreg/tree/fix_readme ------------- Commit messages: - Update README.md - Fix link syntax - Update toplevel readme Changes: https://git.openjdk.java.net/jtreg/pull/24/files Webrev: https://webrevs.openjdk.java.net/?repo=jtreg&pr=24&range=00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903011 Stats: 4 lines in 2 files changed: 0 ins; 1 del; 3 mod Patch: https://git.openjdk.java.net/jtreg/pull/24.diff Fetch: git fetch https://git.openjdk.java.net/jtreg pull/24/head:pull/24 PR: https://git.openjdk.java.net/jtreg/pull/24 From jjg at openjdk.java.net Wed Aug 11 15:45:35 2021 From: jjg at openjdk.java.net (Jonathan Gibbons) Date: Wed, 11 Aug 2021 15:45:35 GMT Subject: Integrated: CODETOOLS-7903010: Delete obsolete build-all.sh and README-v5 files In-Reply-To: <1RQ8fXCmSovke-dTKmr8BEumupjk62gy23MfEp5Z4Lc=.d775332f-710f-49ae-b562-742a5cd23a75@github.com> References: <1RQ8fXCmSovke-dTKmr8BEumupjk62gy23MfEp5Z4Lc=.d775332f-710f-49ae-b562-742a5cd23a75@github.com> Message-ID: On Mon, 9 Aug 2021 21:46:19 GMT, Jonathan Gibbons wrote: > Two files related to the previous iteration of the build system are deleted. This pull request has now been integrated. Changeset: 94b228b0 Author: Jonathan Gibbons URL: https://git.openjdk.java.net/jtreg/commit/94b228b0d4b5c536668cd1988e2e8fe54bcd4fb7 Stats: 513 lines in 2 files changed: 0 ins; 513 del; 0 mod 7903010: Delete obsolete build-all.sh and README-v5 files Reviewed-by: iris ------------- PR: https://git.openjdk.java.net/jtreg/pull/23 From jjg at openjdk.java.net Wed Aug 11 15:58:45 2021 From: jjg at openjdk.java.net (Jonathan Gibbons) Date: Wed, 11 Aug 2021 15:58:45 GMT Subject: RFR: CODETOOLS-7903013: Update README reference to plugin/README Message-ID: <3k8E3VTUYUxF7DfijhH1haeq2Ptx5gxDDoECWom-OpA=.6bef3898-02a0-4e92-8a9b-aaa60863c901@github.com> Please update a minor tweak to the main jtreg README, to update a reference to the plugin README to be a link. ------------- Commit messages: - CODETOOLS-7903013: Update README reference to plugin/README Changes: https://git.openjdk.java.net/jtreg/pull/25/files Webrev: https://webrevs.openjdk.java.net/?repo=jtreg&pr=25&range=00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903013 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jtreg/pull/25.diff Fetch: git fetch https://git.openjdk.java.net/jtreg pull/25/head:pull/25 PR: https://git.openjdk.java.net/jtreg/pull/25 From jjg at openjdk.java.net Wed Aug 11 16:40:37 2021 From: jjg at openjdk.java.net (Jonathan Gibbons) Date: Wed, 11 Aug 2021 16:40:37 GMT Subject: Integrated: CODETOOLS-7903013: Update README reference to plugin/README In-Reply-To: <3k8E3VTUYUxF7DfijhH1haeq2Ptx5gxDDoECWom-OpA=.6bef3898-02a0-4e92-8a9b-aaa60863c901@github.com> References: <3k8E3VTUYUxF7DfijhH1haeq2Ptx5gxDDoECWom-OpA=.6bef3898-02a0-4e92-8a9b-aaa60863c901@github.com> Message-ID: <4BPA0r97tEMkNMK6AJcjz6xKTeyuWMPV9mP-O_kjDtY=.ebc4fbd7-b888-4f45-8f49-82d9d80bf2f3@github.com> On Wed, 11 Aug 2021 15:54:39 GMT, Jonathan Gibbons wrote: > Please update a minor tweak to the main jtreg README, to update a reference to the plugin README to be a link. This pull request has now been integrated. Changeset: 4d06ab31 Author: Jonathan Gibbons URL: https://git.openjdk.java.net/jtreg/commit/4d06ab3158fc61a34c3b897fa68bab14dca7a438 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 7903013: Update README reference to plugin/README ------------- PR: https://git.openjdk.java.net/jtreg/pull/25 From stuefe at openjdk.java.net Thu Aug 12 10:24:33 2021 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Thu, 12 Aug 2021 10:24:33 GMT Subject: RFR: CODETOOLS-7903006: Upgrade jtreg plugin to IntelliJ 2021.2 In-Reply-To: References: Message-ID: On Wed, 4 Aug 2021 06:07:55 GMT, Thomas Stuefe wrote: > Hi, > > could we update target platform version to 21.2? > > There were no issues with the build, plugin works fine (IntelliJ 2021.2 on Ubuntu x64). > > Thanks, Thomas gentle ping ------------- PR: https://git.openjdk.java.net/jtreg/pull/20 From mcimadamore at openjdk.java.net Tue Aug 24 10:50:35 2021 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Tue, 24 Aug 2021 10:50:35 GMT Subject: RFR: CODETOOLS-7903006: Upgrade jtreg plugin to IntelliJ 2021.2 In-Reply-To: References: Message-ID: On Wed, 4 Aug 2021 06:07:55 GMT, Thomas Stuefe wrote: > Hi, > > could we update target platform version to 21.2? > > There were no issues with the build, plugin works fine (IntelliJ 2021.2 on Ubuntu x64). > > Thanks, Thomas Isn't this a dup of https://git.openjdk.java.net/jtreg/pull/19 ? ------------- PR: https://git.openjdk.java.net/jtreg/pull/20 From stuefe at openjdk.java.net Tue Aug 24 11:11:37 2021 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Tue, 24 Aug 2021 11:11:37 GMT Subject: Withdrawn: CODETOOLS-7903006: Upgrade jtreg plugin to IntelliJ 2021.2 In-Reply-To: References: Message-ID: On Wed, 4 Aug 2021 06:07:55 GMT, Thomas Stuefe wrote: > Hi, > > could we update target platform version to 21.2? > > There were no issues with the build, plugin works fine (IntelliJ 2021.2 on Ubuntu x64). > > Thanks, Thomas This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jtreg/pull/20 From stuefe at openjdk.java.net Tue Aug 24 11:11:37 2021 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Tue, 24 Aug 2021 11:11:37 GMT Subject: RFR: CODETOOLS-7903006: Upgrade jtreg plugin to IntelliJ 2021.2 In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 10:48:12 GMT, Maurizio Cimadamore wrote: > Isn't this a dup of https://git.openjdk.java.net/jtreg/pull/19 ? I could have sworn I checked the mailing list before opening the PR. Ah well. I'll close this one then, ------------- PR: https://git.openjdk.java.net/jtreg/pull/20