Fwd: RFR: 7901073: jtreg makefiles should chmod a-w instead of chmod -w

[Jonathan Gibbons]

Done,

FWIW, the patch did not apply cleanly, with one minor rejection.  I 
fixed it and pushed.

-- Jon

On 10/27/2014 07:03 PM, Martin Buchholz wrote:
> Thanks!
>
> On Mon, Oct 27, 2014 at 7:02 PM, Jonathan Gibbons 
> <jonathan.gibbons at oracle.com <mailto:jonathan.gibbons at oracle.com>> wrote:
>
>     Hi Martin,
>
>     Approved; I assume you'd like me to push for you, so will do.
>
>     -- Jon
>
>
>     On 10/27/2014 06:37 PM, Martin Buchholz wrote:
>>     [oops + jtreg-use]
>>
>>     ---------- Forwarded message ----------
>>     From: *Martin Buchholz* <martinrb at google.com
>>     <mailto:martinrb at google.com>>
>>     Date: Mon, Oct 27, 2014 at 6:36 PM
>>     Subject: RFR: 7901073: jtreg makefiles should chmod a-w instead
>>     of chmod -w
>>     To: Jonathan Gibbons <jonathan.gibbons at oracle.com
>>     <mailto:jonathan.gibbons at oracle.com>>
>>
>>
>>     Hi Jonathan,
>>
>>     I'd like you to do a code review.
>>
>>     # HG changeset patch
>>     # User martin
>>     # Date 1414460013 25200
>>     #      Mon Oct 27 18:33:33 2014 -0700
>>     # Node ID dbe3c2c342327350ca3f3f078614ef5882b32c98
>>     # Parent  880984c8c5a0869dd991cdbd087d6fee57279dcf
>>     7901073: jtreg makefiles should chmod a-w instead of chmod -w
>>     Summary: s/chmod -w/chmod a-w/g
>>     Reviewed-By: jjg
>>
>>     diff --git a/make/Rules.gmk b/make/Rules.gmk
>>     --- a/make/Rules.gmk
>>     +++ b/make/Rules.gmk
>>     @@ -71,13 +71,13 @@
>>     $(MKDIR) -p $(@D)
>>     $(RM) $@
>>     $(CP) $(@:$(JTREG_IMAGEDOCDIR)/%=$(SRCDOCDIR)/%) $@
>>     -chmod -w $@
>>     +chmod a-w $@
>>      $(JTREG_IMAGEDOCDIR)/%: $(SRCDOCDIR)/%
>>     $(MKDIR) -p $(@D)
>>     $(RM) $@
>>     $(CP) $(@:$(JTREG_IMAGEDOCDIR)/%=$(SRCDOCDIR)/%) $@
>>     -chmod -w $@
>>     +chmod a-w $@
>>      #---------------------------------------------------------------------
>>     @@ -112,7 +112,7 @@
>>        `sh pkgsToFiles.sh $(CLASSDIR) $($(@F:%.jar=PKGS.JAR.%))` \
>>        $(patsubst $(CLASSDIR)/%,-C $(CLASSDIR) %,$(sort
>>     $(FILES.JAR.$(@F:%.jar=%)))) \
>>        $(JAR_EXTRAS)
>>     -$(CHMOD) -w $@
>>     +$(CHMOD) a-w $@
>>      #----------------------------------------------------------------------
>>      #
>>     diff --git a/make/jtdiff.gmk b/make/jtdiff.gmk
>>     --- a/make/jtdiff.gmk
>>     +++ b/make/jtdiff.gmk
>>     @@ -64,7 +64,7 @@
>>     $(MKDIR) -p $(@D)
>>     $(RM) $@
>>     $(CP) $<  $@
>>     -$(CHMOD) +x,-w $@
>>     +$(CHMOD) a+x,a-w $@
>>      TARGETS.ZIP.jtreg += \
>>     $(JTREG_IMAGEDIR)/bin/jtdiff
>>     @@ -84,7 +84,7 @@
>>      echo '#' ; \
>>     ) > $(BUILDDIR)/jtdiff.warning.sed
>>     $(SED) -f $(BUILDDIR)/jtdiff.warning.sed $< > $@
>>     -$(CHMOD) +x,-w $@
>>     +$(CHMOD) a+x,a-w $@
>>      TARGETS.ZIP.jtreg += \
>>     $(JTREG_IMAGEDIR)/linux/bin/jtdiff \
>>     diff --git a/make/jtreg.gmk b/make/jtreg.gmk
>>     --- a/make/jtreg.gmk
>>     +++ b/make/jtreg.gmk
>>     @@ -368,7 +368,7 @@
>>     $(MKDIR) -p $(@D)
>>     $(RM) $@
>>     $(CP) $<  $@
>>     -$(CHMOD) +x,-w $@
>>     +$(CHMOD) a+x,a-w $@
>>      TARGETS.ZIP.jtreg += \
>>     $(JTREG_IMAGEDIR)/bin/jtreg
>>     @@ -388,7 +388,7 @@
>>      echo '#' ; \
>>     ) > $(BUILDDIR)/jtreg.warning.sed
>>     $(SED) -f $(BUILDDIR)/jtreg.warning.sed $< > $@
>>     -$(CHMOD) +x,-w $@
>>     +$(CHMOD) a+x,a-w $@
>>      TARGETS.ZIP.jtreg += \
>>     $(JTREG_IMAGEDIR)/linux/bin/jtreg \
>>
>>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/jtreg-use/attachments/20141028/67cf3964/attachment-0001.html>