<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Looks good Frank<div class=""><br class=""></div><div class="">Best</div><div class="">Lance<br class=""><div><blockquote type="cite" class=""><div class="">On Nov 23, 2016, at 9:29 PM, Frank Yuan <<a href="mailto:frank.yuan@oracle.com" class="">frank.yuan@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Hi Jon<br class=""><br class=""><br class=""><br class="">Thank you for your advice!<br class=""><br class=""><br class=""><br class="">Please check the update <a href="http://cr.openjdk.java.net/~fyuan/8170192/webrev.01/" class="">http://cr.openjdk.java.net/~fyuan/8170192/webrev.01/</a> , which contains jcommander.jar and removes the extra<br class="">blank lines following Christoph's suggestion.<br class=""><br class=""><br class=""><br class="">Frank<br class=""><br class=""><br class=""><br class="">From: Jonathan Gibbons [<a href="mailto:jonathan.gibbons@oracle.com" class="">mailto:jonathan.gibbons@oracle.com</a>] <br class="">Sent: Thursday, November 24, 2016 4:26 AM<br class="">Subject: Re: RFR JDK-8170192 [JAXP] [TESTBUG] test/javax/xml/jaxp/libs/jaxp/library/JAXPPolicyManager.java should grant permissions<br class="">to jtreg, javatest, and testng jars<br class=""><br class=""><br class=""><br class="">Frank,<br class=""><br class="">More recent builds of testng.jar, such as the builds available on Maven, have separated out the jcommander component so that two<br class="">jar files are required: testng.jar and jcommander.jar.<br class=""><br class="">You should consider taking jcommander.jar into account. This will be more important/noticeable to folk outside Oracle who build<br class="">their own copy of jtreg to use.<br class=""><br class="">-- Jon<br class=""><br class="">On 11/22/2016 08:41 PM, Frank Yuan wrote:<br class=""><br class="">Hi All<br class=""><br class=""><br class=""><br class="">Would you like to review <a href="http://cr.openjdk.java.net/~fyuan/8170192/webrev.00/" class="">http://cr.openjdk.java.net/~fyuan/8170192/webrev.00/</a><br class=""><<a href="http://cr.openjdk.java.net/%7Efyuan/8170192/webrev.00/" class="">http://cr.openjdk.java.net/%7Efyuan/8170192/webrev.00/</a>> ?<br class=""><br class="">Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8170192" class="">https://bugs.openjdk.java.net/browse/JDK-8170192</a><br class=""><br class=""><br class=""><br class="">This patch is fully same as Daniel provided except a few lines of additional cleaning, thanks to Daniel for providing the patch!<br class=""><br class=""><br class=""><br class="">Thanks<br class=""><br class="">Frank<br class=""><br class=""><br class=""><br class=""><br class=""><br class=""></div></div></blockquote></div><br class=""><div class="">
<div class=""><span class="Apple-style-span" style="border-collapse: separate; border-spacing: 0px; "><span class="Apple-style-span" style="color: rgb(102, 102, 102); font-family: Verdana, Arial, Helvetica, sans-serif; font-size: small; "><a href="http://oracle.com/us/design/oracle-email-sig-198324.gif" class=""><span><img height="26" width="114" apple-inline="yes" id="8F72163C-167B-4B91-BB6F-349420DF4BD8" apple-width="yes" apple-height="yes" src="cid:E1C4E2F0-ECD0-4C9D-ADB4-B16CA7BCB7FC@home" class=""></span></a><div style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; " class=""><a href="http://oracle.com/us/design/oracle-email-sig-198324.gif" class=""><span class="Apple-style-span" style="border-collapse: separate; border-spacing: 0px; "><span class="Apple-style-span" style="color: rgb(102, 102, 102); font-family: Verdana, Arial, Helvetica, sans-serif; font-size: small; "></span></span></a><a href="http://oracle.com/us/design/oracle-email-sig-198324.gif" class=""><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; border-spacing: 0px; -webkit-text-decorations-in-effect: none; "><span class="Apple-style-span" style="color: rgb(102, 102, 102); font-family: Verdana, Arial, Helvetica, sans-serif; font-size: small; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; border-spacing: 0px; -webkit-text-decorations-in-effect: none; "></span></span></span></a><a href="http://oracle.com/us/design/oracle-email-sig-198324.gif" class=""><br class=""></a><span style="color: rgb(102, 102, 102); font-family: Verdana, Arial, Helvetica, sans-serif; font-size: small; " class="">Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037</span><br style="color: rgb(102, 102, 102); font-family: Verdana, Arial, Helvetica, sans-serif; font-size: small; " class=""><font color="#FF0000" style="font-family: Verdana, Arial, Helvetica, sans-serif; font-size: small; " class="">Oracle</font><span style="color: rgb(102, 102, 102); font-family: Verdana, Arial, Helvetica, sans-serif; font-size: small; " class=""> Java Engineering </span><br style="color: rgb(102, 102, 102); font-family: Verdana, Arial, Helvetica, sans-serif; font-size: small; " class=""><span style="color: rgb(102, 102, 102); font-family: Verdana, Arial, Helvetica, sans-serif; font-size: small; " class="">1 Network Drive </span><br style="color: rgb(102, 102, 102); font-family: Verdana, Arial, Helvetica, sans-serif; font-size: small; " class=""><span style="color: rgb(102, 102, 102); font-family: Verdana, Arial, Helvetica, sans-serif; font-size: small; " class="">Burlington, MA 01803</span><br style="color: rgb(102, 102, 102); font-family: Verdana, Arial, Helvetica, sans-serif; font-size: small; " class=""><a href="mailto:Lance.Andersen@oracle.com" style="font-family: Verdana, Arial, Helvetica, sans-serif; font-size: small; " class="">Lance.Andersen@oracle.com</a></div><div style="color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; " class=""><br class=""></div><br class="Apple-interchange-newline">
</span></span></div>
</div><br class=""></div></body></html>