RFR 8164518: JShell: Add failover case of explicitly listening to "localhost"

Jan Lahoda jan.lahoda at oracle.com
Mon Aug 22 17:46:18 UTC 2016


Ok, seems OK to me.

Jan

On 22.8.2016 19:08, Robert Field wrote:
>
> On 08/22/16 07:50, Jan Lahoda wrote:
>> I wonder if the behavior of JDIInitiator should be changed to always
>> consider useLocalhost == true? Is there a case for useLocalHost ==
>> false, that cannot be automatically detected?
>
> Ah!  Please see updated fix:
>
> http://mail.openjdk.java.net/pipermail/kulla-dev/2016-August/001566.html
>
> The parameter is not so weird in that ;-)
>
> It is important to still provide access to the loop-back address name
> determined by JDI, so I don't want to hard-wire "localhost" always.
>
> Thanks,
> Robert
>
>>
>> Jan
>>
>> On 20.8.2016 07:26, Robert Field wrote:
>>> Please review...
>>>
>>> Bug:
>>>      https://bugs.openjdk.java.net/browse/JDK-8164518
>>>
>>> Webrev:
>>>      http://cr.openjdk.java.net/~rfield/8164518v0.webrev/
>>>
>>> Specdiff:
>>> http://cr.openjdk.java.net/~rfield/8164518v0.specdiff/jdk/jshell/execution/JDIDefaultExecutionControl.html
>>>
>>>
>>> http://cr.openjdk.java.net/~rfield/8164518v0.specdiff/jdk/jshell/execution/JDIInitiator.html
>>>
>>>
>>>
>>> API:
>>> http://cr.openjdk.java.net/~rfield/8164518v0.jshellAPI/jdk/jshell/execution/package-summary.html
>>>
>>>
>>>
>>> Thanks,
>>> Robert
>>>
>


More information about the kulla-dev mailing list