Persistent test failure on Windows
Kumar Srinivasan
kumar.x.srinivasan at oracle.com
Wed Jan 13 15:12:34 UTC 2016
I don't think this is fixed, continues to fail.
Kumar
> On 13.1.2016 02:09, Robert Field wrote:
>> It might also be that the channel shutdown at the wrong time. Which
>
> Yes, that could be also an issue.
>
>> also might be addressed by the patch you mention.
>>
>> I reviewed and liked that patch, but at that time I was not an official
>> reviewer. Now I am, and so I bless that patch.
>
> Thanks!
>
>>
>> Will you be able to test the patch's impact on this Windows issue?
>
> I did, and it seems to fix the ToolReloadTest problem. I've pushed the
> patch.
>
> Thanks,
> Jan
>
>>
>> Thanks,
>> Robert
>>
>> On 01/12/16 14:57, Jan Lahoda wrote:
>>> I suspect this may be a problem with line endings. I'll check
>>> tomorrow. There is a patch that strives to resolve (at least some of)
>>> the line endings problems here:
>>> http://mail.openjdk.java.net/pipermail/kulla-dev/2015-December/001163.html
>>>
>>>
>>>
>>> Further comments on that would be welcome.
>>>
>>> Thanks,
>>> Jan
>>>
>>> On 12.1.2016 23:50, Robert Field wrote:
>>>> Thanks Jon,
>>>>
>>>> I don't have a Windows machine to test on.
>>>>
>>>> The test that it is failing on is evaluating "System.exit(1)" which
>>>> crashes the remote machine. Does anyone have a Windows machine who can
>>>> test behavior?
>>>>
>>>> Jon, should I just disable this test for now?
>>>>
>>>> Thanks,
>>>> Robert
>>>>
>>>>
>>>> On 01/12/16 13:55, Jonathan Gibbons wrote:
>>>>>
>>>>> The test jdk/jshell/ToolReloadTest is persistently failing on
>>>>> Windows, according to one of our build and test systems.
>>>>> Could someone from the kulla team please investigate and fix.
>>>>>
>>>>> The relevant part of the .jtr file is as follows:
>>>>>
>>>>> [TestNG] Running:
>>>>> jdk/jshell/ToolReloadTest.java
>>>>>
>>>>> test ToolReloadTest.testReloadClasspath(): success
>>>>> test ToolReloadTest.testReloadCrashRestore(): failure
>>>>> java.lang.AssertionError: Kind: command.
>>>>> expected [| State engine terminated.
>>>>> | Restore definitions with: /reload restore
>>>>> ] but found []
>>>>> at org.testng.Assert.fail(Assert.java:94)
>>>>> at org.testng.Assert.failNotEquals(Assert.java:494)
>>>>> at org.testng.Assert.assertEquals(Assert.java:123)
>>>>> at org.testng.Assert.assertEquals(Assert.java:176)
>>>>> at ReplToolTesting.assertOutput(ReplToolTesting.java:460)
>>>>> at ReplToolTesting.assertCommand(ReplToolTesting.java:418)
>>>>> at ReplToolTesting.assertCommand(ReplToolTesting.java:397)
>>>>> at
>>>>> ToolReloadTest.lambda$testReloadCrashRestore$52(ToolReloadTest.java:167)
>>>>>
>>>>>
>>>>> at
>>>>> ReplToolTesting$PromptedCommandOutputStream.write(ReplToolTesting.java:704)
>>>>>
>>>>>
>>>>>
>>>>> at
>>>>> ReplToolTesting$PromptedCommandOutputStream.write(ReplToolTesting.java:720)
>>>>>
>>>>>
>>>>>
>>>>> at java.io.PrintStream.write(PrintStream.java:480)
>>>>> at sun.nio.cs.StreamEncoder.writeBytes(StreamEncoder.java:233)
>>>>> at
>>>>> sun.nio.cs.StreamEncoder.implFlushBuffer(StreamEncoder.java:312)
>>>>> at sun.nio.cs.StreamEncoder.implFlush(StreamEncoder.java:316)
>>>>> at sun.nio.cs.StreamEncoder.flush(StreamEncoder.java:153)
>>>>> at java.io.OutputStreamWriter.flush(OutputStreamWriter.java:252)
>>>>> at
>>>>> jdk.internal.jline.console.ConsoleReader.readLine(ConsoleReader.java:2336)
>>>>>
>>>>>
>>>>>
>>>>> at
>>>>> jdk.internal.jline.console.ConsoleReader.readLine(ConsoleReader.java:2277)
>>>>>
>>>>>
>>>>>
>>>>> at
>>>>> jdk.internal.jshell.tool.ConsoleIOContext.readLine(ConsoleIOContext.java:153)
>>>>>
>>>>>
>>>>>
>>>>> at jdk.internal.jshell.tool.JShellTool.run(JShellTool.java:472)
>>>>> at jdk.internal.jshell.tool.JShellTool.start(JShellTool.java:287)
>>>>> at jdk.internal.jshell.tool.JShellTool.start(JShellTool.java:260)
>>>>> at ReplToolTesting.testRaw(ReplToolTesting.java:240)
>>>>> at ReplToolTesting.test(ReplToolTesting.java:203)
>>>>> at ReplToolTesting.test(ReplToolTesting.java:191)
>>>>> at ReplToolTesting.test(ReplToolTesting.java:187)
>>>>> at ReplToolTesting.test(ReplToolTesting.java:183)
>>>>> at ToolReloadTest.testReloadCrashRestore(ToolReloadTest.java:162)
>>>>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>>>>> at
>>>>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>>>>>
>>>>>
>>>>>
>>>>> at
>>>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>>>>>
>>>>>
>>>>>
>>>>> at java.lang.reflect.Method.invoke(Method.java:520)
>>>>> at
>>>>> org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:84)
>>>>>
>>>>>
>>>>>
>>>>> at org.testng.internal.Invoker.invokeMethod(Invoker.java:714)
>>>>> at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901)
>>>>> at
>>>>> org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231)
>>>>> at
>>>>> org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
>>>>>
>>>>>
>>>>>
>>>>> at
>>>>> org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
>>>>> at org.testng.TestRunner.privateRun(TestRunner.java:767)
>>>>> at org.testng.TestRunner.run(TestRunner.java:617)
>>>>> at org.testng.SuiteRunner.runTest(SuiteRunner.java:334)
>>>>> at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:329)
>>>>> at org.testng.SuiteRunner.privateRun(SuiteRunner.java:291)
>>>>> at org.testng.SuiteRunner.run(SuiteRunner.java:240)
>>>>> at
>>>>> org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
>>>>> at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
>>>>> at org.testng.TestNG.runSuitesSequentially(TestNG.java:1224)
>>>>> at org.testng.TestNG.runSuitesLocally(TestNG.java:1149)
>>>>> at org.testng.TestNG.run(TestNG.java:1057)
>>>>> at
>>>>> com.sun.javatest.regtest.TestNGAction$TestNGRunner.main(TestNGAction.java:220)
>>>>>
>>>>>
>>>>>
>>>>> at sun.reflect.GeneratedMethodAccessor17.invoke(Unknown Source)
>>>>> at
>>>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>>>>>
>>>>>
>>>>>
>>>>> at java.lang.reflect.Method.invoke(Method.java:520)
>>>>> at
>>>>> com.sun.javatest.regtest.agent.MainActionHelper$SameVMRunnable.run(MainActionHelper.java:226)
>>>>>
>>>>>
>>>>>
>>>>> at java.lang.Thread.run(Thread.java:804)
>>>>> test ToolReloadTest.testReloadDrop(): success
>>>>> test ToolReloadTest.testReloadExitRestore(): success
>>>>> test ToolReloadTest.testReloadIgnore(): success
>>>>> test ToolReloadTest.testReloadRepeat(): success
>>>>> test ToolReloadTest.testReloadResetRestore(): success
>>>>> test ToolReloadTest.testReloadSnippets(): success
>>>>>
>>>>> ===============================================
>>>>> jdk/jshell/ToolReloadTest.java
>>>>> Total tests run: 8, Failures: 1, Skips: 0
>>>>> ===============================================
>>>>>
>>>>> ----------System.err:(11/574)----------
>>>>> java.lang.Exception: failures: 1
>>>>> at
>>>>> com.sun.javatest.regtest.TestNGAction$TestNGRunner.main(TestNGAction.java:223)
>>>>>
>>>>>
>>>>>
>>>>> at sun.reflect.GeneratedMethodAccessor17.invoke(Unknown Source)
>>>>> at
>>>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>>>>>
>>>>>
>>>>>
>>>>> at java.lang.reflect.Method.invoke(Method.java:520)
>>>>> at
>>>>> com.sun.javatest.regtest.agent.MainActionHelper$SameVMRunnable.run(MainActionHelper.java:226)
>>>>>
>>>>>
>>>>>
>>>>> at java.lang.Thread.run(Thread.java:804)
>>>>>
>>>>>
>>>>
>>
More information about the kulla-dev
mailing list