RFR 8131027: JShell API/tool: suggest imports for a class

Jan Lahoda jan.lahoda at oracle.com
Fri Jan 22 11:40:09 UTC 2016


Hello,

I'd like to ask for a review of a patch that adds two new features:
a) add import: when there is an unresolvable identifier, press 
"<base-shortcut> i" (*), and a list of known FQNs should be printed, 
with an ability to easily import any of them.

b) create variable: when there is an expression, press "<base-shortcut> 
v", and a variable stub will be created, with the expression as the 
initializer.

The "<base-shortcut>" is either Alt-Enter or Alt-F1, depending on the 
platform. For Windows,

The patch is here:
http://cr.openjdk.java.net/~jlahoda/8131027/webrev.00/

For Windows, an additional patch to jdk.internal.le is needed (I'll send 
a separate review to core-libs for that):
http://cr.openjdk.java.net/~jlahoda/8147984/webrev.00/

Any comments are welcome!

Thanks,
    Jan


More information about the kulla-dev mailing list