From robert.field at oracle.com Tue Oct 16 23:29:57 2018 From: robert.field at oracle.com (Robert Field) Date: Tue, 16 Oct 2018 16:29:57 -0700 Subject: RFR 8210923: JShell: support for switch expressions In-Reply-To: <197310d4-eadf-2586-11d4-bbe8298ead04@oracle.com> References: <197310d4-eadf-2586-11d4-bbe8298ead04@oracle.com> Message-ID: <3b203684-a573-d410-eda4-9d0eea498a6b@oracle.com> Please review --- On 09/25/18 15:46, Robert Field wrote: > Please review: > > Bug: > > ??? https://bugs.openjdk.java.net/browse/JDK-8210923 > > Webrev: > > ??? http://cr.openjdk.java.net/~rfield/8210923v0.webrev/ > > Thanks, > Robert > > > From robert.field at oracle.com Wed Oct 17 02:52:05 2018 From: robert.field at oracle.com (Robert Field) Date: Tue, 16 Oct 2018 19:52:05 -0700 Subject: RFR 8210959: JShell fails and exits when statement throws an exception whose message contains a '%'. Message-ID: <487847d6-8d19-880f-4002-daaa095986b0@oracle.com> Please review --- Bug: ? ? https://bugs.openjdk.java.net/browse/JDK-8210959 Webrev: ??? http://cr.openjdk.java.net/~rfield/8210959v0.webrev/ Thanks, Robert From jan.lahoda at oracle.com Mon Oct 22 12:50:50 2018 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Mon, 22 Oct 2018 14:50:50 +0200 Subject: RFR 8210959: JShell fails and exits when statement throws an exception whose message contains a '%'. In-Reply-To: <487847d6-8d19-880f-4002-daaa095986b0@oracle.com> References: <487847d6-8d19-880f-4002-daaa095986b0@oracle.com> Message-ID: <5BCDC7AA.601@oracle.com> Looks OK to me. Jan On 17.10.2018 04:52, Robert Field wrote: > Please review --- > > Bug: > > https://bugs.openjdk.java.net/browse/JDK-8210959 > > Webrev: > > http://cr.openjdk.java.net/~rfield/8210959v0.webrev/ > > > Thanks, > Robert > > From jan.lahoda at oracle.com Mon Oct 22 12:52:58 2018 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Mon, 22 Oct 2018 14:52:58 +0200 Subject: RFR 8210923: JShell: support for switch expressions In-Reply-To: <3b203684-a573-d410-eda4-9d0eea498a6b@oracle.com> References: <197310d4-eadf-2586-11d4-bbe8298ead04@oracle.com> <3b203684-a573-d410-eda4-9d0eea498a6b@oracle.com> Message-ID: <5BCDC82A.9020603@oracle.com> Looks OK to me. Jan On 17.10.2018 01:29, Robert Field wrote: > Please review --- > > > On 09/25/18 15:46, Robert Field wrote: >> Please review: >> >> Bug: >> >> https://bugs.openjdk.java.net/browse/JDK-8210923 >> >> Webrev: >> >> http://cr.openjdk.java.net/~rfield/8210923v0.webrev/ >> >> Thanks, >> Robert >> >> >> > From robert.field at oracle.com Mon Oct 22 17:01:23 2018 From: robert.field at oracle.com (Robert Field) Date: Mon, 22 Oct 2018 10:01:23 -0700 Subject: JShell behavior question: Variable re-declaration without initializer Message-ID: The current behavior of JShell is that redeclaring a variable without initializer does not reset the value of the variable (even though the value of the declaration lies) -- jshell> int x = 44 x ==> 44 jshell> int x x ==> 0 jshell> x x ==> 44 *Is there any reason to preserve this semantics? * One significant effect would be that VAR_DECLARATION_SUBKIND becomes an executable -- Snippet.isExecutable() returns true. One major motivation for resetting it would be that sequences of re-evaluated code behave consistently. -Robert From robert.field at oracle.com Thu Oct 25 01:24:00 2018 From: robert.field at oracle.com (Robert Field) Date: Wed, 24 Oct 2018 18:24:00 -0700 Subject: RFR 8211694: JShell: Redeclared variable should be reset Message-ID: Please review --- Bug: ??? https://bugs.openjdk.java.net/browse/JDK-8211694 Webrev: ??? http://cr.openjdk.java.net/~rfield/8211694v0.webrev/ See query to kulla-dev: http://mail.openjdk.java.net/pipermail/kulla-dev/2018-October/002316.html Thanks, Robert From sundararajan.athijegannathan at oracle.com Thu Oct 25 02:41:36 2018 From: sundararajan.athijegannathan at oracle.com (Sundararajan Athijegannathan) Date: Thu, 25 Oct 2018 08:11:36 +0530 Subject: RFR 8211694: JShell: Redeclared variable should be reset In-Reply-To: References: Message-ID: <5BD12D60.5040503@oracle.com> Looks good -Sundar On 25/10/18, 6:54 AM, Robert Field wrote: > Please review --- > > Bug: > > https://bugs.openjdk.java.net/browse/JDK-8211694 > > Webrev: > > http://cr.openjdk.java.net/~rfield/8211694v0.webrev/ > > See query to kulla-dev: > > http://mail.openjdk.java.net/pipermail/kulla-dev/2018-October/002316.html > > Thanks, > Robert > > From robert.field at oracle.com Thu Oct 25 02:50:41 2018 From: robert.field at oracle.com (Robert Field) Date: Wed, 24 Oct 2018 19:50:41 -0700 Subject: RFR 8211694: JShell: Redeclared variable should be reset In-Reply-To: <5BD12D60.5040503@oracle.com> References: <5BD12D60.5040503@oracle.com> Message-ID: On 10/24/18 19:41, Sundararajan Athijegannathan wrote: > Looks good > > -Sundar Thanks Sundar > > On 25/10/18, 6:54 AM, Robert Field wrote: >> Please review --- >> >> Bug: >> >> ??? https://bugs.openjdk.java.net/browse/JDK-8211694 >> >> Webrev: >> >> ??? http://cr.openjdk.java.net/~rfield/8211694v0.webrev/ >> >> See query to kulla-dev: >> >> http://mail.openjdk.java.net/pipermail/kulla-dev/2018-October/002316.html >> >> >> Thanks, >> Robert >> >> From robert.field at oracle.com Thu Oct 25 23:34:58 2018 From: robert.field at oracle.com (Robert Field) Date: Thu, 25 Oct 2018 16:34:58 -0700 Subject: RFR 8210808: jshell tool: only considers the first snippet of the external editor Message-ID: Please review -- Bug: ??? https://bugs.openjdk.java.net/browse/JDK-8210808 Webrev: ??? http://cr.openjdk.java.net/~rfield/8210808v0.webrev/ Thanks, Robert From sundararajan.athijegannathan at oracle.com Fri Oct 26 10:13:06 2018 From: sundararajan.athijegannathan at oracle.com (Sundararajan Athijegannathan) Date: Fri, 26 Oct 2018 15:43:06 +0530 Subject: RFR 8210808: jshell tool: only considers the first snippet of the external editor In-Reply-To: References: Message-ID: <5BD2E8B2.50305@oracle.com> Looks good. -Sundar On 26/10/18, 5:04 AM, Robert Field wrote: > Please review -- > > Bug: > > https://bugs.openjdk.java.net/browse/JDK-8210808 > > Webrev: > > http://cr.openjdk.java.net/~rfield/8210808v0.webrev/ > > > Thanks, > Robert > > From jan.lahoda at oracle.com Fri Oct 26 10:22:32 2018 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Fri, 26 Oct 2018 12:22:32 +0200 Subject: RFR 8210808: jshell tool: only considers the first snippet of the external editor In-Reply-To: <5BD2E8B2.50305@oracle.com> References: <5BD2E8B2.50305@oracle.com> Message-ID: <5BD2EAE8.3070604@oracle.com> Looks OK to me too. Jan On 26.10.2018 12:13, Sundararajan Athijegannathan wrote: > Looks good. > > -Sundar > > On 26/10/18, 5:04 AM, Robert Field wrote: >> Please review -- >> >> Bug: >> >> https://bugs.openjdk.java.net/browse/JDK-8210808 >> >> Webrev: >> >> http://cr.openjdk.java.net/~rfield/8210808v0.webrev/ >> >> >> Thanks, >> Robert >> >>