[8] Review request for 8000806: Implement runtime lambda metafactory

[Christian Thalinger]

On Oct 25, 2012, at 9:17 AM, Robert Field <robert.field at oracle.com> wrote:

> Thanks Chris, two minor changes:  
> 
>     Brian noted that LambdaConversionException should be an Exception, not an Error -- because it is non-fatal.
>     Note this also matches the name and that the other throwable being propagated is a Exception not an Error.

I haven't noticed that it was extending Error.  But I agree that it should be an Exception.

> 
>     Since the review, the JDK internal ASM has been pushed to JDK, and has a different name than the one in lambda.
>     So, the imports needed to be adjusted.

Right.

> 
> A webrev of these changes:
> 
>     http://cr.openjdk.java.net/~rfield/8000806-delta-0-1/

I looked at the delta and it looks good.

-- Chris

> 
> New complete webrev:
> 
>     http://cr.openjdk.java.net/~rfield/8000806.1/
> 
> Please verify that this is OK.
> 
> Thanks,
> Robert
> 
> On 10/15/12 16:22, Christian Thalinger wrote:
>> Looks good to me.  -- Chris
>> 
>> On Oct 11, 2012, at 7:01 PM, Robert Field <robert.field at oracle.com> wrote:
>> 
>>> Please review the fix for CR: 
>>> 
>>>      http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000806 
>>> 
>>> Webrev: 
>>> 
>>>      http://cr.openjdk.java.net/~rfield/8000806/
>>> 
>>> Thank,
>>> Robert
>