RFR: 8004518 & 8010122 : Default methods on Map

Mike Duigou mike.duigou at oracle.com
Fri Apr 12 14:36:37 PDT 2013


On Apr 11 2013, at 15:15 , Ulf Zibis wrote:

> Am 11.04.2013 22:03, schrieb Mike Duigou:
>> Another revision incorporating primarily documentation feedback.
>> 
>> http://cr.openjdk.java.net/~mduigou/JDK-8010122/2/webrev/
> 
> There is still a yoda style in ConcurrentMap line 72, HashMap line 361

Fixed

> To be in line with old habits, please remove space after casts. See also: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6939278

I am not going to do this. 

> Collections:
> lines 1442... + 3900... , indentation for follow up line should be 8
> 
> Map:
> lines 599..600 bad indentation

Corrected.

> 
> Use consistent formatted code examples in javadoc. I like the style from lines 567 to 570, but e.g. from line 622 to 626:
> - 2 spaces before <pre>
> - indentation should be 4
> - line break before }</pre>

I had left these along in the previous round. Should be fixed now.

Mike


More information about the lambda-dev mailing list