RFR: 8001647: In-place methods on Collection/List

Alan Bateman Alan.Bateman at oracle.com
Fri Apr 19 04:15:24 PDT 2013

On 18/04/2013 19:49, Akhil Arora wrote:
> Looks like the stars are aligning on getting on this into TL... the
> refreshed webrev is -
> http://cr.openjdk.java.net/~akhil/8001647.8/webrev/
A minor comment on Collection.removeIf is "that satisifies the given 
predicate" might be better than "which matches the provided predicate". 
Also for completeness, you could say "RuntimeExceptions and Errors 
thrown by the predicate are propagated ...".

In List.replaceAll then @throws NullPointerException is listed twice, 
which is okay, but might be better to combine them. A typo in the second 
NPE description "if the an element".

In the implementation then the only thing that puzzled me is checking 
the modification count in legacy Vector, that seems unnecessary.

I see Mike has looked through the tests in detail. One additional 
comment is just location and trying to keep it consistent with the 
current organization if possible.


More information about the lambda-dev mailing list