Code review request

[Tim Peierls]

On Thu, Feb 21, 2013 at 2:17 PM, Brian Goetz <brian.goetz at oracle.com> wrote:

> At
>   http://cr.openjdk.java.net/~**briangoetz/jdk-8008670/webrev/<http://cr.openjdk.java.net/~briangoetz/jdk-8008670/webrev/>
>
> I've posted a webrev for about half the classes in java.util.stream. None
> of these are public classes, so there are no public API issues here, but
> plenty of internal API issues, naming issues (ooh, a bikeshed), and code
> quality issues.
>

Things I noticed before I ran out of steam:

In AbstractTask<P_IN, P_OUT, R, T> the use of multicharacter type
parameters is confusing, especially with an underscore. AbstractTask<S, T,
R, C>, <T, U, R, C>, or even <K, V, R, T> would be better.

BiBlock -> BiConsumer in Map.java comments.

--tim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/lambda-libs-spec-experts/attachments/20130223/cbb7a906/attachment.html