Re: Integrated: 8249659: [Lanai] Crash while running RenderPerfTest with metal pipeli…

[Alexey Ushakov]

Hi Jay,

Unfortunately we should not release MTLRenderPassDescriptor manually as it registered in some autorelease pool. So, when that pool is released we have a crash. But looks like the pool that is used for attaching  MTLRenderPassDescriptor has not proper life time. I’m going to refactor memory management (rough idea is to have autorelease pool for each RenderQueue flush action).

BTW, this week I’m on vacation (be back on Tuesday next week)

Best Regards,
Alexey 

> On Aug 12, 2020, at 4:50 PM, Jayathirth D v <JAYATHIRTH.D.V at ORACLE.COM> wrote:
> 
> Hi Alexey,
> 
> This change has caused performance regression in RenderPerfTest FlatBoxAA.
> JBS bug raised for the same : https://bugs.openjdk.java.net/browse/JDK-8251484 <https://bugs.openjdk.java.net/browse/JDK-8251484> 
> 
> Thanks,
> Jay
> 
>> On 06-Aug-2020, at 9:12 PM, Alexey Ushakov <avu at openjdk.java.net> wrote:
>> 
>> On Thu, 6 Aug 2020 15:34:25 GMT, Alexey Ushakov <avu at openjdk.org> wrote:
>> 
>>> …ne - wiredQuadAA
>>> 
>>> Removed release of autorelease object (MTLRenderPassDescriptor)
>> 
>> This pull request has now been integrated.
>> 
>> Changeset: 454407b5
>> Author:    Alexey Ushakov <avu at openjdk.org>
>> URL:       https://git.openjdk.java.net/lanai/commit/454407b5
>> Stats:     1 line in 1 file changed: 1 ins; 0 del; 0 mod
>> 
>> 8249659: [Lanai] Crash while running RenderPerfTest with metal pipeli…
>> 
>> -------------
>> 
>> PR: https://git.openjdk.java.net/lanai/pull/75
>