hg: lanai/lanai: 8234813: MTLRenderer_FillAAParallelogram is not implemented

Alexey Ushakov alexey.ushakov at jetbrains.com
Thu Jan 23 19:13:51 UTC 2020


> This is missing the inner curly braces. I guess you are compiling with disable-warnings-as-error. Also the last constant should be 1.0f (although that may or may not cause an error).

Thanks, Kevin! Looks like I’ve used disable-warnings-as-error indeed.

Best Regards,
Alexey

> On 23 Jan 2020, at 21:27, Kevin Rushforth <kevin.rushforth at oracle.com> wrote:
> 
> This is missing the inner curly braces. I guess you are compiling with disable-warnings-as-error. Also the last constant should be 1.0f (although that may or may not cause an error).
> 
> Here is the fix in MTLPaints.m, which I will push shortly, unless you are still around and plan to do it.
> 
>              if (isAA) {
> -                struct FrameUniforms uf = {1.0f, 1.0f, 1.0f, 1.0};
> +                struct FrameUniforms uf = { {1.0f, 1.0f, 1.0f, 1.0f} };
>                  [encoder setVertexBytes:&uf length:sizeof(uf) atIndex:FrameUniformBuffer];
>              } else {
> 
> I'll push it shortly unless you plan to do it.
> 
> -- Kevin
> 
> 
> On 1/23/2020 9:29 AM, Kevin Rushforth wrote:
>> It get past the earlier error and then I see this:
>> 
>> /Users/kcr/java/lanai/open/src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLPaints.m:302:50: error: excess elements in struct initializer [-Werror]
>>                 struct FrameUniforms uf = {1.0f, 1.0f, 1.0f, 1.0};
>>                                                  ^~~~
>> 1 error generated.
>> Awt2dLibraries.gmk:899: recipe for target '/Users/kcr/java/lanai/build/macosx-x64/support/native/java.desktop/libawt_lwawt/MTLPaints.o' failed
>> make[3]: *** [/Users/kcr/java/lanai/build/macosx-x64/support/native/java.desktop/libawt_lwawt/MTLPaints.o] Error 1
>> make[3]: *** Waiting for unfinished jobs....
>> make/Main.gmk:211: recipe for target 'java.desktop-libs' failed
>> make[2]: *** [java.desktop-libs] Error 2
>> 
>> -- Kevin
>> 
>> 
>> On 1/23/2020 9:14 AM, Alexey Ushakov wrote:
>>> Hi Jay,
>>> 
>>> I’ve added appropriate annotation.
>>> 
>>> Best Regards,
>>> Alexey
>>> 
>>>> On 23 Jan 2020, at 19:22, Jayathirth D v <JAYATHIRTH.D.V at ORACLE.COM> wrote:
>>>> 
>>>> Hi Alexey,
>>>> 
>>>> I am getting build error after this push :
>>>> 
>>>> * For target support_native_java.desktop_libawt_lwawt_MTLClip.o:
>>>> In file included from /Users/jdv/workspace/jdk/lanai_work/src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLClip.m:4:
>>>> In file included from /Users/jdv/workspace/jdk/lanai_work/src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLContext.h:41:
>>>> /Users/jdv/workspace/jdk/lanai_work/src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/EncoderManager.h:33:61: error: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Werror,-Wnullability-completeness]
>>>> - (id<MTLRenderCommandEncoder> _Nonnull)getAARenderEncoder:(id<MTLTexture>)dstTxt;
>>>>                                                             ^
>>>> /Users/jdv/workspace/jdk/lanai_work/src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/EncoderManager.h:33:74: note: insert '_Nullable' if the pointer may be null
>>>> - (id<MTLRenderCommandEncoder> _Nonnull)getAARenderEncoder:(id<MTLTexture>)dstTxt;
>>>> ^
>>>> _Nullable
>>>> /Users/jdv/workspace/jdk/lanai_work/src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/EncoderManager.h:33:74: note: insert '_Nonnull' if the pointer should never be null
>>>> - (id<MTLRenderCommandEncoder> _Nonnull)getAARenderEncoder:(id<MTLTexture>)dstTxt;
>>>> ^
>>>> _Nonnull
>>>> 1 error generated.
>>>> 
>>>> Thanks,
>>>> Jay
>>>> 
>>>>> On 23-Jan-2020, at 7:55 PM, alexey.ushakov at jetbrains.com wrote:
>>>>> 
>>>>> Changeset: f6f2dd18c0f6
>>>>> Author:    avu
>>>>> Date:      2020-01-23 17:24 +0300
>>>>> URL: https://hg.openjdk.java.net/lanai/lanai/rev/f6f2dd18c0f6
>>>>> 
>>>>> 8234813: MTLRenderer_FillAAParallelogram is not implemented
>>>>> 
>>>>> Use multisampling rendering for AA parallelogram rendering
>>>>> 
>>>>> ! src/demo/share/java2d/RenderPerfTest/src/renderperf/RenderPerfTest.java 
>>>>> ! src/java.desktop/macosx/native/libawt_lwawt/awt/shaders.metal
>>>>> ! src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/EncoderManager.h
>>>>> ! src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/EncoderManager.m
>>>>> ! src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLPaints.m
>>>>> ! src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLPipelineStatesStorage.h
>>>>> ! src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLPipelineStatesStorage.m
>>>>> ! src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLRenderer.m
>>>>> ! src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLTexturePool.h
>>>>> ! src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLTexurePool.m 
>>>>> ! src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLUtils.h
>>>>> 
>> 
> 



More information about the lanai-dev mailing list