[master] RFR: Fix loading Klass* in C1 on AArch64

Aleksey Shipilev shade at openjdk.java.net
Mon Jan 24 11:52:30 UTC 2022


On Tue, 18 Jan 2022 08:44:25 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> PR #20 was not quite correct on AArch64:
> - We cannot push/pop r0 in the code stub, because we must not mess with SP there, otherwise the argument passing does not work.
> - We should use far_call() and not far_jump(), so that the return comes back into the stub, and not to the continuation (or whereever LR points to).
> 
> Testing:
>  - [x] tier1
>  - [x] tier2
>  - [x] tier3

OK, after reading the discussion, I understand what is going on here. Approving, but flickering through the horror-awe-disgust-amuzement cycle real hard here. :)

-------------

Marked as reviewed by shade (Committer).

PR: https://git.openjdk.java.net/lilliput/pull/34


More information about the lilliput-dev mailing list