[master] RFR: Load narrowKlass from header, AArch64 assembler implementation [v2]
Andrew Haley
aph at openjdk.java.net
Thu Jan 27 14:46:13 UTC 2022
On Thu, 27 Jan 2022 12:08:10 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add asserts
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 596:
>
>> 594: // we have lock pointer bits in the upper 32bits. We can't get a false
>> 595: // negative.
>> 596: __ ldrw(r0, Address(r0, oopDesc::nklass_offset_in_bytes())); // get klass
>
> Something should assert that `oopDesc::nklass_offset_in_bytes()` does not break the alignment. Probably assert that `oopDesc::nklass_offset_in_bytes()` is a multiple of 4?
`ldrw()` will definitely complain if it isn't.
-------------
PR: https://git.openjdk.java.net/lilliput/pull/36
More information about the lilliput-dev
mailing list