RFR: Some more descriptive names, removed redundant asserts. Request for comments. [v2]
Coleen Phillimore
coleenp at openjdk.java.net
Wed Apr 6 00:39:28 UTC 2022
On Wed, 6 Apr 2022 00:36:44 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Also, there's an if statement already for chunk_available which the compiler shouldn't have trouble optimizing. Otherwise we should refactor freeze_fast.
>> Tested locally with make test TEST=jdk/jdk/internal/vm/Continuation since only names.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>
> Revert untemplatization
src/hotspot/share/runtime/continuation.cpp line 2074:
> 2072: assert(chunk != nullptr, "");
> 2073:
> 2074: // Comment needed: Why would the tail chunk be empty? Why do you get the parent?
Here, can you explain what's happening in this function?
-------------
PR: https://git.openjdk.java.net/loom/pull/139
More information about the loom-dev
mailing list