RFR: Some more descriptive names, removed redundant asserts. Request for comments. [v2]

Ron Pressler rpressler at openjdk.java.net
Wed Apr 6 01:02:54 UTC 2022


On Wed, 6 Apr 2022 00:33:06 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/runtime/continuation.cpp line 2074:
>> 
>>> 2072:   assert(chunk != nullptr, "");
>>> 2073: 
>>> 2074:   // Comment needed: Why would the tail chunk be empty? Why do you get the parent?
>> 
>> Here, can you explain what's happening in this function?
>
> Then we'll do more functions :)

We make room on the stack to thaw frames. As we'll either thaw the topmost non-empty chunk or one frame, we just need to make room for the topmost non-empty chunk.

-------------

PR: https://git.openjdk.java.net/loom/pull/139


More information about the loom-dev mailing list