RFR: Some more descriptive names, removed redundant asserts. Request for comments. [v3]

Ron Pressler rpressler at openjdk.java.net
Wed Apr 6 08:46:04 UTC 2022


On Wed, 6 Apr 2022 02:20:27 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Also, there's an if statement already for chunk_available which the compiler shouldn't have trouble optimizing.  Otherwise we should refactor freeze_fast.
>> Tested locally with make test TEST=jdk/jdk/internal/vm/Continuation since only names.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   More questions

src/hotspot/share/runtime/continuation.cpp line 1589:

> 1587: #endif
> 1588: 
> 1589:   // Why 'vsp' what is 'v' ?  isn't this the sp on the real stack?

To distinguish between stacks, John called the continuation stack a "horizontal stack", hence `h`, and the thread stack a "vertical stack`, hence `v`.

-------------

PR: https://git.openjdk.java.net/loom/pull/139


More information about the loom-dev mailing list