Integrated: Minor changes to `StructuredTaskScope`

[Paul Sandoz]

On Mon, 11 Apr 2022 20:52:21 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

> Some suggested minor changes to `StructuredTaskScope` source while reviewing the code.
> 
> Overall I like how this approach has boiled down to about as simple as it can get while supporting the constraints of structured concurrency (thanks in no small part to `ThreadFlock`).
> 
> I think it should be possible to simplify the subclass implementations if the values of `Future.State` were comparable as in `RUNNING` < `CANCELED` < `FAILED` < `SUCCESS`. Otherwise, introducing that internally could also simplify and avoid the task scopes holding on unnecessarily to futures that are not operated on after join. I was reluctant to make such a change here but could propose as a separate PR.
> 
> I was uncertain if the `ShutdownOnSuccess.result` methods and the various exception returning/operating methods on `ShutdownOnFailure` should be constrained to throw if called before `join` has completed. Otherwise, we should specify that if operated on before `join` has completed then the results are unspecified.
> (There might be a simple way for join to return something other than `this`, thereby avoiding this issue, with some additional complexity, but I suspect you have already thought of that and took the minimal route.)
> 
> I presume there is an implicit happens-before edge on `join` that we can make explicit and specify?

This pull request has now been integrated.

Changeset: 9a304f9d
Author:    Paul Sandoz <psandoz at openjdk.org>
URL:       https://git.openjdk.java.net/loom/commit/9a304f9d68b552e066a892b382e88a23e8618466
Stats:     66 lines in 1 file changed: 35 ins; 4 del; 27 mod

Minor changes to `StructuredTaskScope`

Reviewed-by: alanb

-------------

PR: https://git.openjdk.java.net/loom/pull/142