RFR: Alex review

Alan Bateman alanb at openjdk.java.net
Fri Apr 15 06:25:58 UTC 2022


On Fri, 15 Apr 2022 05:58:50 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> src/java.se/share/data/jdwp/jdwp.spec line 2155:
>> 
>>> 2153:                                      "or the thread is a virtual thread and the target "
>>> 2154:                                      "VM is unable to force its current frame to return, "
>>> 2155:                                      "or the implementation is "
>> 
>> It's okay to join the sentences but if you do then we need to re-format L2152 so that we don't have a line break after the comma at L2152.
>
> I don't understand. Aren't they all formatted into one long line, and line wrapping is controlled by how the browser formats the table cell?
> 
> https://docs.oracle.com/en/java/javase/17/docs/specs/jdwp/jdwp-protocol.html#JDWP_ThreadReference_ForceEarlyReturn

Yes, that's the generated spec. The comment was on the source file which can be cleaned up, or later if you want, it doesn't matter.

-------------

PR: https://git.openjdk.java.net/loom/pull/149


More information about the loom-dev mailing list