RFR: First refactoring (thaw_fast) [v2]

[Frederic Parain]

On Wed, 20 Apr 2022 17:55:08 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Frederic Parain has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixes to address Coleen's comments.
>
> src/hotspot/share/oops/stackChunkOop.inline.hpp line 201:
> 
>> 199:   assert(empty == is_empty(), "");
>> 200:   return frame_size + argsize;
>> 201: }
> 
> Yes, this belongs here.  It has some frame arithmetic but most is done by stackFrameStream, which is good.
> sp() is relative to the address of the stackChunkOop.
> Add a comment about what this returns.

Comment added

> src/hotspot/share/runtime/continuationFreezeThaw.cpp line 1629:
> 
>> 1627: }
>> 1628: 
>> 1629: class ReconstructedStack {
> 
> pls inherit from StackObj

Inheritance added.

> src/hotspot/share/runtime/continuationFreezeThaw.cpp line 1647:
> 
>> 1645:   intptr_t* bottom_sp() const { return ContinuationHelper::frame_align_pointer(_base - _argsize); }
>> 1646: 
>> 1647:   // several operations operate ont the totality of the stack being reconstructed,
> 
> typo

Fixed

-------------

PR: https://git.openjdk.java.net/loom/pull/158