From haosun at openjdk.java.net Tue Mar 1 04:11:51 2022 From: haosun at openjdk.java.net (Hao Sun) Date: Tue, 1 Mar 2022 04:11:51 GMT Subject: RFR: 8282468: Loom: Fix build failures for PPC64, S390, ARM32 and Zero Message-ID: Updates made in commits [1][2][3][4] are missing for PPC64, S390, ARM32 and Zero, leading to build failures. Even though we mainly focus on x64 and AArch64 platforms currently, I think it would be nice if the builds on other platforms are not broken. Hence, we apply the similar updates from [1][2][3][4] to PPC64, S390, ARM32 and Zero in this patch. Testing: Linux PPC64 cross-compilation Linux S390 cross-compilation Linux ARM32 cross-compilation Linux AArch64 Zero (Hotspot) compilation Linux x86_64 tier1_loom passes Linux AArch64 tier1_loom passes [1] https://github.com/openjdk/loom/commit/4f9b661 [2] https://github.com/openjdk/loom/commit/74b27d0 [3] https://github.com/openjdk/loom/commit/90fb1b9 [4] https://github.com/openjdk/loom/commit/d77311e ------------- Commit messages: - Loom: Fix build failures for PPC64, S390, ARM32 and Zero Changes: https://git.openjdk.java.net/loom/pull/92/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=92&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282468 Stats: 620 lines in 24 files changed: 223 ins; 226 del; 171 mod Patch: https://git.openjdk.java.net/loom/pull/92.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/92/head:pull/92 PR: https://git.openjdk.java.net/loom/pull/92 From haosun at openjdk.java.net Tue Mar 1 04:11:52 2022 From: haosun at openjdk.java.net (Hao Sun) Date: Tue, 1 Mar 2022 04:11:52 GMT Subject: RFR: 8282468: Loom: Fix build failures for PPC64, S390, ARM32 and Zero In-Reply-To: References: Message-ID: On Tue, 1 Mar 2022 03:55:52 GMT, Hao Sun wrote: > Updates made in commits [1][2][3][4] are missing for PPC64, S390, ARM32 > and Zero, leading to build failures. > > Even though we mainly focus on x64 and AArch64 platforms currently, I > think it would be nice if the builds on other platforms are not broken. > > Hence, we apply the similar updates from [1][2][3][4] to PPC64, S390, > ARM32 and Zero in this patch. > > Testing: > > Linux PPC64 cross-compilation > Linux S390 cross-compilation > Linux ARM32 cross-compilation > Linux AArch64 Zero (Hotspot) compilation > Linux x86_64 tier1_loom passes > Linux AArch64 tier1_loom passes > > [1] https://github.com/openjdk/loom/commit/4f9b661 > [2] https://github.com/openjdk/loom/commit/74b27d0 > [3] https://github.com/openjdk/loom/commit/90fb1b9 > [4] https://github.com/openjdk/loom/commit/d77311e GHA test results can be found in https://github.com/shqking/loom/actions/runs/1913619403 As noted there, `PPC64/S390/ARM32/Zero` builds passed as expected. ------------- PR: https://git.openjdk.java.net/loom/pull/92 From alanb at openjdk.java.net Tue Mar 1 08:16:28 2022 From: alanb at openjdk.java.net (Alan Bateman) Date: Tue, 1 Mar 2022 08:16:28 GMT Subject: RFR: 8282468: Loom: Fix build failures for PPC64, S390, ARM32 and Zero In-Reply-To: References: Message-ID: <02xVzS4Vxy57NmvchhBn18yaWw4AbYJ_CKkes_py9ys=.8b52db30-5db7-4095-ac4e-1d87137b2538@github.com> On Tue, 1 Mar 2022 03:55:52 GMT, Hao Sun wrote: > Updates made in commits [1][2][3][4] are missing for PPC64, S390, ARM32 > and Zero, leading to build failures. > > Even though we mainly focus on x64 and AArch64 platforms currently, I > think it would be nice if the builds on other platforms are not broken. > > Hence, we apply the similar updates from [1][2][3][4] to PPC64, S390, > ARM32 and Zero in this patch. > > Testing: > > Linux PPC64 cross-compilation > Linux S390 cross-compilation > Linux ARM32 cross-compilation > Linux AArch64 Zero (Hotspot) compilation > Linux x86_64 tier1_loom passes > Linux AArch64 tier1_loom passes > > [1] https://github.com/openjdk/loom/commit/4f9b661 > [2] https://github.com/openjdk/loom/commit/74b27d0 > [3] https://github.com/openjdk/loom/commit/90fb1b9 > [4] https://github.com/openjdk/loom/commit/d77311e Thanks for the update. It's good to keep these ports building, even with Unimplemented stubs. Ron, are you okay if we integrate this? ------------- PR: https://git.openjdk.java.net/loom/pull/92 From dlong at openjdk.java.net Tue Mar 1 04:45:59 2022 From: dlong at openjdk.java.net (Dean Long) Date: Tue, 1 Mar 2022 04:45:59 GMT Subject: RFR: 8281681: compiler/profiling/spectrapredefineclass_classloaders/Launcher.java crash when CodeCache is full Message-ID: I wasn't able to reproduce this, but from looking at the core dump, not trying to emit more instructions when the code cache is full should definitely help. ------------- Commit messages: - emit post_call_nop only after checking for CodeCache full Changes: https://git.openjdk.java.net/loom/pull/93/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=93&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281681 Stats: 6 lines in 1 file changed: 3 ins; 2 del; 1 mod Patch: https://git.openjdk.java.net/loom/pull/93.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/93/head:pull/93 PR: https://git.openjdk.java.net/loom/pull/93 From duke at openjdk.java.net Tue Mar 1 10:50:07 2022 From: duke at openjdk.java.net (duke) Date: Tue, 1 Mar 2022 10:50:07 GMT Subject: git: openjdk/loom: fibers: Cleanup Message-ID: <6e05cb4b-fe7d-4183-9310-4a54432486af@openjdk.java.net> Changeset: 0087a968 Author: Ron Pressler Date: 2022-03-01 10:48:36 +0000 URL: https://git.openjdk.java.net/loom/commit/0087a9686edce4efb6349700eae3e148e34674cd Cleanup ! src/hotspot/share/runtime/continuation.cpp ! src/hotspot/share/runtime/continuation.hpp ! src/hotspot/share/runtime/thread.cpp From duke at openjdk.java.net Tue Mar 1 15:56:21 2022 From: duke at openjdk.java.net (duke) Date: Tue, 1 Mar 2022 15:56:21 GMT Subject: git: openjdk/loom: fibers: Cleanup Message-ID: Changeset: 7ca11b84 Author: Ron Pressler Date: 2022-03-01 15:53:20 +0000 URL: https://git.openjdk.java.net/loom/commit/7ca11b8428af96c2ec881121df69d31c5f817d42 Cleanup ! src/hotspot/share/ci/ciEnv.cpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/code/nmethod.hpp ! src/hotspot/share/oops/instanceStackChunkKlass.hpp ! src/hotspot/share/runtime/continuation.cpp From alanb at openjdk.java.net Tue Mar 1 16:10:31 2022 From: alanb at openjdk.java.net (Alan Bateman) Date: Tue, 1 Mar 2022 16:10:31 GMT Subject: RFR: 8281681: compiler/profiling/spectrapredefineclass_classloaders/Launcher.java crash when CodeCache is full In-Reply-To: References: Message-ID: On Tue, 1 Mar 2022 04:39:37 GMT, Dean Long wrote: > I wasn't able to reproduce this, but from looking at the core dump, not trying to emit more instructions when the code cache is full should definitely help. Thanks for this. I've seen this issue several times, always aarch64 with the stack trace in bug report. I don't maintain this area but moving the post_call_nop to after checking "call" looks right to me. ------------- PR: https://git.openjdk.java.net/loom/pull/93 From duke at openjdk.java.net Tue Mar 1 18:09:40 2022 From: duke at openjdk.java.net (duke) Date: Tue, 1 Mar 2022 18:09:40 GMT Subject: git: openjdk/loom: fibers: 11 new changesets Message-ID: <859e777e-1aa8-473a-a76a-c1b7c0d0d7a6@openjdk.java.net> Changeset: 640a36c7 Author: Alan Bateman Date: 2022-03-01 08:41:29 +0000 URL: https://git.openjdk.java.net/loom/commit/640a36c7b3ed420f49d53f9a8519fe4b53f8d447 Add pid to thread dump ! src/java.base/share/classes/jdk/internal/vm/ThreadDumper.java ! test/jdk/com/sun/management/HotSpotDiagnosticMXBean/DumpThreads.java Changeset: 53cf42b8 Author: Alan Bateman Date: 2022-03-01 11:45:08 +0000 URL: https://git.openjdk.java.net/loom/commit/53cf42b8e5563fdf84f924b47010021be95abe6b Read blocking mode before receive ! src/java.base/share/classes/sun/nio/ch/DatagramChannelImpl.java Changeset: f4660cf1 Author: Alan Bateman Date: 2022-03-01 15:09:48 +0000 URL: https://git.openjdk.java.net/loom/commit/f4660cf19146648973dfcf25545edd3965840151 Improve blocker to avoid lambda expressions ! src/java.base/linux/classes/sun/nio/ch/EPollSelectorImpl.java ! src/java.base/macosx/classes/sun/nio/ch/KQueueSelectorImpl.java ! src/java.base/share/classes/java/io/FileInputStream.java ! src/java.base/share/classes/java/io/FileOutputStream.java ! src/java.base/share/classes/java/io/RandomAccessFile.java ! src/java.base/share/classes/java/lang/Object.java ! src/java.base/share/classes/java/net/InetAddress.java ! src/java.base/share/classes/java/nio/MappedMemoryUtils.java ! src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java ! src/java.base/share/classes/jdk/internal/misc/Blocker.java ! src/java.base/share/classes/jdk/internal/misc/CarrierThread.java ! src/java.base/share/classes/jdk/internal/module/SystemModulesMap.java ! src/java.base/share/classes/sun/nio/ch/FileChannelImpl.java ! src/java.base/share/classes/sun/nio/ch/SelectorImpl.java ! src/java.base/unix/classes/java/io/UnixFileSystem.java ! src/java.base/unix/classes/sun/nio/ch/PollSelectorImpl.java ! src/java.base/unix/classes/sun/nio/fs/UnixCopyFile.java ! src/java.base/unix/classes/sun/nio/fs/UnixNativeDispatcher.java ! src/java.base/windows/classes/java/io/WinNTFileSystem.java ! src/java.base/windows/classes/java/lang/ProcessImpl.java ! src/java.base/windows/classes/sun/nio/ch/WEPollSelectorImpl.java ! src/java.base/windows/classes/sun/nio/fs/WindowsNativeDispatcher.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/RandomAccessFileInstrumentor.java Changeset: 5b243d20 Author: Alan Bateman Date: 2022-03-01 15:15:52 +0000 URL: https://git.openjdk.java.net/loom/commit/5b243d2099a96b7cbbb6219eb7797e12b42584d4 Initial fix for JDK-8282452 to avoid confusing javadoc ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java Changeset: 09f121a3 Author: Alan Bateman Date: 2022-03-01 15:56:08 +0000 URL: https://git.openjdk.java.net/loom/commit/09f121a3c15b7c32d112f1b02d9e93c3a2384bc8 Exclude two more tests from wrapper runs ! test/hotspot/jtreg/ProblemList-vthread.txt Changeset: 681307d5 Author: Alan Bateman Date: 2022-03-01 16:24:02 +0000 URL: https://git.openjdk.java.net/loom/commit/681307d5d3459afd53da620cb5248e843a99939c Cleanup ! src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java ! src/java.base/share/classes/jdk/internal/access/SharedSecrets.java Changeset: c6a80f8f Author: Alan Bateman Date: 2022-03-01 16:57:18 +0000 URL: https://git.openjdk.java.net/loom/commit/c6a80f8fdf6652580741ff7187726dc5bdb5b6de Don't yield ! src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java ! src/java.base/share/classes/jdk/internal/misc/Blocker.java Changeset: 05740cbc Author: Alan Bateman Date: 2022-03-01 17:36:13 +0000 URL: https://git.openjdk.java.net/loom/commit/05740cbc943e6d2aa63d89927d783383f62376d6 Restore file ! src/java.base/share/classes/jdk/internal/module/SystemModulesMap.java Changeset: 00de4f9c Author: Alan Bateman Date: 2022-03-01 17:57:30 +0000 URL: https://git.openjdk.java.net/loom/commit/00de4f9ccbeae93fcb0bc6e039d16513ed2c6d65 Update mapInternal ! src/java.base/share/classes/sun/nio/ch/FileChannelImpl.java Changeset: eb45d81e Author: Alan Bateman Date: 2022-03-01 17:57:54 +0000 URL: https://git.openjdk.java.net/loom/commit/eb45d81e244f51e30c91b94cd1ae77e219a22468 vmTestbase/nsk/jvmti/scenarios/bcinstr/BI04/bi04t002/TestDescription.java failing ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/bcinstr/BI04/bi04t002/newclass02/java.base/java/lang/Object.java Changeset: 2aff24b5 Author: Alan Bateman Date: 2022-03-01 18:02:18 +0000 URL: https://git.openjdk.java.net/loom/commit/2aff24b57ad250c7ac46aa33522c36067e020340 Exclude vmTestbase/vm/gc/compact/Compact_NonbranchyTree/TestDescription.java with wrapper ! test/hotspot/jtreg/ProblemList-vthread.txt From alanb at openjdk.java.net Tue Mar 1 18:18:29 2022 From: alanb at openjdk.java.net (Alan Bateman) Date: Tue, 1 Mar 2022 18:18:29 GMT Subject: RFR: 8282468: Loom: Fix build failures for PPC64, S390, ARM32 and Zero In-Reply-To: References: Message-ID: On Tue, 1 Mar 2022 03:55:52 GMT, Hao Sun wrote: > Updates made in commits [1][2][3][4] are missing for PPC64, S390, ARM32 > and Zero, leading to build failures. > > Even though we mainly focus on x64 and AArch64 platforms currently, I > think it would be nice if the builds on other platforms are not broken. > > Hence, we apply the similar updates from [1][2][3][4] to PPC64, S390, > ARM32 and Zero in this patch. > > Testing: > > Linux PPC64 cross-compilation > Linux S390 cross-compilation > Linux ARM32 cross-compilation > Linux AArch64 Zero (Hotspot) compilation > Linux x86_64 tier1_loom passes > Linux AArch64 tier1_loom passes > > [1] https://github.com/openjdk/loom/commit/4f9b661 > [2] https://github.com/openjdk/loom/commit/74b27d0 > [3] https://github.com/openjdk/loom/commit/90fb1b9 > [4] https://github.com/openjdk/loom/commit/d77311e Marked as reviewed by alanb (Committer). ------------- PR: https://git.openjdk.java.net/loom/pull/92 From alanb at openjdk.java.net Tue Mar 1 18:18:30 2022 From: alanb at openjdk.java.net (Alan Bateman) Date: Tue, 1 Mar 2022 18:18:30 GMT Subject: RFR: 8281681: compiler/profiling/spectrapredefineclass_classloaders/Launcher.java crash when CodeCache is full In-Reply-To: References: Message-ID: On Tue, 1 Mar 2022 04:39:37 GMT, Dean Long wrote: > I wasn't able to reproduce this, but from looking at the core dump, not trying to emit more instructions when the code cache is full should definitely help. Marked as reviewed by alanb (Committer). ------------- PR: https://git.openjdk.java.net/loom/pull/93 From haosun at openjdk.java.net Tue Mar 1 22:52:14 2022 From: haosun at openjdk.java.net (Hao Sun) Date: Tue, 1 Mar 2022 22:52:14 GMT Subject: RFR: 8282468: Loom: Fix build failures for PPC64, S390, ARM32 and Zero In-Reply-To: References: Message-ID: On Tue, 1 Mar 2022 03:55:52 GMT, Hao Sun wrote: > Updates made in commits [1][2][3][4] are missing for PPC64, S390, ARM32 > and Zero, leading to build failures. > > Even though we mainly focus on x64 and AArch64 platforms currently, I > think it would be nice if the builds on other platforms are not broken. > > Hence, we apply the similar updates from [1][2][3][4] to PPC64, S390, > ARM32 and Zero in this patch. > > Testing: > > Linux PPC64 cross-compilation > Linux S390 cross-compilation > Linux ARM32 cross-compilation > Linux AArch64 Zero (Hotspot) compilation > Linux x86_64 tier1_loom passes > Linux AArch64 tier1_loom passes > > [1] https://github.com/openjdk/loom/commit/4f9b661 > [2] https://github.com/openjdk/loom/commit/74b27d0 > [3] https://github.com/openjdk/loom/commit/90fb1b9 > [4] https://github.com/openjdk/loom/commit/d77311e Thanks for your review! ------------- PR: https://git.openjdk.java.net/loom/pull/92 From haosun at openjdk.java.net Tue Mar 1 22:56:18 2022 From: haosun at openjdk.java.net (Hao Sun) Date: Tue, 1 Mar 2022 22:56:18 GMT Subject: RFR: 8282468: Loom: Fix build failures for PPC64, S390, ARM32 and Zero In-Reply-To: References: Message-ID: On Tue, 1 Mar 2022 03:55:52 GMT, Hao Sun wrote: > Updates made in commits [1][2][3][4] are missing for PPC64, S390, ARM32 > and Zero, leading to build failures. > > Even though we mainly focus on x64 and AArch64 platforms currently, I > think it would be nice if the builds on other platforms are not broken. > > Hence, we apply the similar updates from [1][2][3][4] to PPC64, S390, > ARM32 and Zero in this patch. > > Testing: > > Linux PPC64 cross-compilation > Linux S390 cross-compilation > Linux ARM32 cross-compilation > Linux AArch64 Zero (Hotspot) compilation > Linux x86_64 tier1_loom passes > Linux AArch64 tier1_loom passes > > [1] https://github.com/openjdk/loom/commit/4f9b661 > [2] https://github.com/openjdk/loom/commit/74b27d0 > [3] https://github.com/openjdk/loom/commit/90fb1b9 > [4] https://github.com/openjdk/loom/commit/d77311e Ah, sorry. It seems that one more approval is needed. ------------- PR: https://git.openjdk.java.net/loom/pull/92 From dlong at openjdk.java.net Tue Mar 1 23:44:12 2022 From: dlong at openjdk.java.net (Dean Long) Date: Tue, 1 Mar 2022 23:44:12 GMT Subject: RFR: 8281681: compiler/profiling/spectrapredefineclass_classloaders/Launcher.java crash when CodeCache is full In-Reply-To: References: Message-ID: <7dOsWYtpXG2zJMdQJOgSSO4tQDgFcj_kknE_4jOnu8w=.c656016f-a178-4da5-8d05-1eecb55349d3@github.com> On Tue, 1 Mar 2022 04:39:37 GMT, Dean Long wrote: > I wasn't able to reproduce this, but from looking at the core dump, not trying to emit more instructions when the code cache is full should definitely help. Thanks for the review, Alan. @rickard, could you review this too, please? ------------- PR: https://git.openjdk.java.net/loom/pull/93 From rbackman at openjdk.java.net Wed Mar 2 15:09:18 2022 From: rbackman at openjdk.java.net (Rickard =?UTF-8?B?QsOkY2ttYW4=?=) Date: Wed, 2 Mar 2022 15:09:18 GMT Subject: RFR: 8279653: compiler/codecache/stress/OverloadCompileQueueTest.java failing in loom repo In-Reply-To: <-XfP8uXG80s8fCx0EbgtLcZR68D9H1Jm-JgEfZ628ew=.69ece675-2524-423d-8196-4d9ee083b3fc@github.com> References: <-XfP8uXG80s8fCx0EbgtLcZR68D9H1Jm-JgEfZ628ew=.69ece675-2524-423d-8196-4d9ee083b3fc@github.com> Message-ID: On Mon, 28 Feb 2022 16:49:14 GMT, Coleen Phillimore wrote: > I fixed the test to disable compiling Thread.sleep() and all the methods it seems to call, and this makes the test pass. I don't know if there's a better way to disable compilation like this that would be less fragile (ie if Thread.sleep() calls something new in the future). See bug comments for details. @rickard do you know? Thanks! Marked as reviewed by rbackman (Committer). ------------- PR: https://git.openjdk.java.net/loom/pull/91 From coleenp at openjdk.java.net Wed Mar 2 15:09:18 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Wed, 2 Mar 2022 15:09:18 GMT Subject: RFR: 8279653: compiler/codecache/stress/OverloadCompileQueueTest.java failing in loom repo In-Reply-To: <-XfP8uXG80s8fCx0EbgtLcZR68D9H1Jm-JgEfZ628ew=.69ece675-2524-423d-8196-4d9ee083b3fc@github.com> References: <-XfP8uXG80s8fCx0EbgtLcZR68D9H1Jm-JgEfZ628ew=.69ece675-2524-423d-8196-4d9ee083b3fc@github.com> Message-ID: On Mon, 28 Feb 2022 16:49:14 GMT, Coleen Phillimore wrote: > I fixed the test to disable compiling Thread.sleep() and all the methods it seems to call, and this makes the test pass. I don't know if there's a better way to disable compilation like this that would be less fragile (ie if Thread.sleep() calls something new in the future). See bug comments for details. @rickard do you know? Thanks! Thanks Rickard. (I wonder if I hit the "Merge pull request" button, or integrate) ------------- PR: https://git.openjdk.java.net/loom/pull/91 From coleenp at openjdk.java.net Wed Mar 2 17:03:13 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Wed, 2 Mar 2022 17:03:13 GMT Subject: RFR: 8279653: compiler/codecache/stress/OverloadCompileQueueTest.java failing in loom repo [v2] In-Reply-To: <-XfP8uXG80s8fCx0EbgtLcZR68D9H1Jm-JgEfZ628ew=.69ece675-2524-423d-8196-4d9ee083b3fc@github.com> References: <-XfP8uXG80s8fCx0EbgtLcZR68D9H1Jm-JgEfZ628ew=.69ece675-2524-423d-8196-4d9ee083b3fc@github.com> Message-ID: > I fixed the test to disable compiling Thread.sleep() and all the methods it seems to call, and this makes the test pass. I don't know if there's a better way to disable compilation like this that would be less fragile (ie if Thread.sleep() calls something new in the future). See bug comments for details. @rickard do you know? Thanks! Coleen Phillimore has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.java.net/loom/pull/91/files - new: https://git.openjdk.java.net/loom/pull/91/files/25d428b2..25d428b2 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=loom&pr=91&range=01 - incr: https://webrevs.openjdk.java.net/?repo=loom&pr=91&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/loom/pull/91.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/91/head:pull/91 PR: https://git.openjdk.java.net/loom/pull/91 From duke at openjdk.java.net Wed Mar 2 17:03:14 2022 From: duke at openjdk.java.net (duke) Date: Wed, 2 Mar 2022 17:03:14 GMT Subject: git: openjdk/loom: fibers: 2 new changesets Message-ID: Changeset: 25d428b2 Author: Coleen Phillimore Date: 2022-02-28 16:10:22 +0000 URL: https://git.openjdk.java.net/loom/commit/25d428b23822b5efce18199a4cc8b4eaabccff69 8279653: compiler/codecache/stress/OverloadCompileQueueTest.java failing in loom repo ! test/hotspot/jtreg/ProblemList-Xcomp.txt ! test/hotspot/jtreg/compiler/codecache/stress/OverloadCompileQueueTest.java Changeset: cba3230b Author: Coleen Phillimore Committer: GitHub Date: 2022-03-02 12:02:04 +0000 URL: https://git.openjdk.java.net/loom/commit/cba3230be5dc40b1132ea4d7807c3fc050b0b17e Merge pull request #91 from coleenp/cc 8279653: compiler/codecache/stress/OverloadCompileQueueTest.java failing in loom repo From alanb at openjdk.java.net Wed Mar 2 17:03:14 2022 From: alanb at openjdk.java.net (Alan Bateman) Date: Wed, 2 Mar 2022 17:03:14 GMT Subject: RFR: 8279653: compiler/codecache/stress/OverloadCompileQueueTest.java failing in loom repo [v2] In-Reply-To: References: <-XfP8uXG80s8fCx0EbgtLcZR68D9H1Jm-JgEfZ628ew=.69ece675-2524-423d-8196-4d9ee083b3fc@github.com> Message-ID: <0SnOZ76IgpaIWvhGFL1_p0x-JPhUboMCz9f-OTOTGmU=.f7d9dbf3-5417-4005-bfda-865f4ee0c027@github.com> On Wed, 2 Mar 2022 16:59:50 GMT, Coleen Phillimore wrote: >> I fixed the test to disable compiling Thread.sleep() and all the methods it seems to call, and this makes the test pass. I don't know if there's a better way to disable compilation like this that would be less fragile (ie if Thread.sleep() calls something new in the future). See bug comments for details. @rickard do you know? Thanks! > > Coleen Phillimore has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. Marked as reviewed by alanb (Committer). ------------- PR: https://git.openjdk.java.net/loom/pull/91 From coleenp at openjdk.java.net Wed Mar 2 17:04:16 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Wed, 2 Mar 2022 17:04:16 GMT Subject: Withdrawn: 8279653: compiler/codecache/stress/OverloadCompileQueueTest.java failing in loom repo In-Reply-To: <-XfP8uXG80s8fCx0EbgtLcZR68D9H1Jm-JgEfZ628ew=.69ece675-2524-423d-8196-4d9ee083b3fc@github.com> References: <-XfP8uXG80s8fCx0EbgtLcZR68D9H1Jm-JgEfZ628ew=.69ece675-2524-423d-8196-4d9ee083b3fc@github.com> Message-ID: On Mon, 28 Feb 2022 16:49:14 GMT, Coleen Phillimore wrote: > I fixed the test to disable compiling Thread.sleep() and all the methods it seems to call, and this makes the test pass. I don't know if there's a better way to disable compilation like this that would be less fragile (ie if Thread.sleep() calls something new in the future). See bug comments for details. @rickard do you know? Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/loom/pull/91 From duke at openjdk.java.net Wed Mar 2 18:18:22 2022 From: duke at openjdk.java.net (duke) Date: Wed, 2 Mar 2022 18:18:22 GMT Subject: git: openjdk/loom: fibers: 3 new changesets Message-ID: <5d6a3357-3d0d-45a5-9347-e28e123faef2@openjdk.java.net> Changeset: f7d7aa65 Author: Alan Bateman Date: 2022-03-02 12:24:17 +0000 URL: https://git.openjdk.java.net/loom/commit/f7d7aa658f962f76b013fea2d5c271087a08cf7d Ensure JLA is initialized ! src/java.base/share/classes/jdk/internal/misc/Blocker.java Changeset: 3f482c30 Author: Alan Bateman Date: 2022-03-02 17:23:12 +0000 URL: https://git.openjdk.java.net/loom/commit/3f482c3071ffb2242532abe586b97be465013b25 Add method to test if preview is enabled ! make/data/hotspot-symbols/symbols-unix ! src/hotspot/share/include/jvm.h ! src/hotspot/share/prims/jvm.cpp ! src/java.base/share/classes/jdk/internal/misc/VM.java ! src/java.base/share/native/libjava/VM.c Changeset: 01e0387c Author: Alan Bateman Date: 2022-03-02 17:23:32 +0000 URL: https://git.openjdk.java.net/loom/commit/01e0387c432e76f5da58f76e95b89ba4c10eb86d Comment out need for Reviewers ! .jcheck/conf From duke at openjdk.java.net Wed Mar 2 19:08:14 2022 From: duke at openjdk.java.net (duke) Date: Wed, 2 Mar 2022 19:08:14 GMT Subject: git: openjdk/loom: fibers: Restore .jcheck/conf Message-ID: Changeset: 0ff1f68f Author: Alan Bateman Date: 2022-03-02 19:07:15 +0000 URL: https://git.openjdk.java.net/loom/commit/0ff1f68fa0484325de0f0259f7c3aca88bd3c7dd Restore .jcheck/conf ! .jcheck/conf From rpressler at openjdk.java.net Wed Mar 2 19:08:26 2022 From: rpressler at openjdk.java.net (Ron Pressler) Date: Wed, 2 Mar 2022 19:08:26 GMT Subject: RFR: 8281681: compiler/profiling/spectrapredefineclass_classloaders/Launcher.java crash when CodeCache is full In-Reply-To: References: Message-ID: On Tue, 1 Mar 2022 04:39:37 GMT, Dean Long wrote: > I wasn't able to reproduce this, but from looking at the core dump, not trying to emit more instructions when the code cache is full should definitely help. Marked as reviewed by rpressler (Lead). ------------- PR: https://git.openjdk.java.net/loom/pull/93 From dlong at openjdk.java.net Wed Mar 2 23:18:09 2022 From: dlong at openjdk.java.net (Dean Long) Date: Wed, 2 Mar 2022 23:18:09 GMT Subject: Integrated: 8281681: compiler/profiling/spectrapredefineclass_classloaders/Launcher.java crash when CodeCache is full In-Reply-To: References: Message-ID: On Tue, 1 Mar 2022 04:39:37 GMT, Dean Long wrote: > I wasn't able to reproduce this, but from looking at the core dump, not trying to emit more instructions when the code cache is full should definitely help. This pull request has now been integrated. Changeset: a28581a9 Author: Dean Long URL: https://git.openjdk.java.net/loom/commit/a28581a903362c1fce36821033cc8013a5ccc272 Stats: 6 lines in 1 file changed: 3 ins; 2 del; 1 mod 8281681: compiler/profiling/spectrapredefineclass_classloaders/Launcher.java crash when CodeCache is full Reviewed-by: alanb, rpressler ------------- PR: https://git.openjdk.java.net/loom/pull/93 From coleenp at openjdk.java.net Thu Mar 3 00:18:43 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Thu, 3 Mar 2022 00:18:43 GMT Subject: RFR: Fix unloading tests to not have extra full GCs. Message-ID: Added -XX:-MethodFlushing to turn off the sweeper, which prevents full GCs that make the test useless. ------------- Commit messages: - Fix unloading tests to not have extra full GCs. Changes: https://git.openjdk.java.net/loom/pull/94/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=94&range=00 Stats: 12 lines in 5 files changed: 4 ins; 4 del; 4 mod Patch: https://git.openjdk.java.net/loom/pull/94.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/94/head:pull/94 PR: https://git.openjdk.java.net/loom/pull/94 From alanb at openjdk.java.net Thu Mar 3 07:02:26 2022 From: alanb at openjdk.java.net (Alan Bateman) Date: Thu, 3 Mar 2022 07:02:26 GMT Subject: RFR: 8282468: Loom: Fix build failures for PPC64, S390, ARM32 and Zero In-Reply-To: References: Message-ID: On Tue, 1 Mar 2022 03:55:52 GMT, Hao Sun wrote: > Updates made in commits [1][2][3][4] are missing for PPC64, S390, ARM32 > and Zero, leading to build failures. > > Even though we mainly focus on x64 and AArch64 platforms currently, I > think it would be nice if the builds on other platforms are not broken. > > Hence, we apply the similar updates from [1][2][3][4] to PPC64, S390, > ARM32 and Zero in this patch. > > Testing: > > Linux PPC64 cross-compilation > Linux S390 cross-compilation > Linux ARM32 cross-compilation > Linux AArch64 Zero (Hotspot) compilation > Linux x86_64 tier1_loom passes > Linux AArch64 tier1_loom passes > > [1] https://github.com/openjdk/loom/commit/4f9b661 > [2] https://github.com/openjdk/loom/commit/74b27d0 > [3] https://github.com/openjdk/loom/commit/90fb1b9 > [4] https://github.com/openjdk/loom/commit/d77311e Marked as reviewed by alanb (Committer). We had an issue with the check conf and maybe that is why it stalled. I will try to review it again and see if that unsticks it. ------------- PR: https://git.openjdk.java.net/loom/pull/92 From rbackman at openjdk.java.net Thu Mar 3 07:11:24 2022 From: rbackman at openjdk.java.net (Rickard =?UTF-8?B?QsOkY2ttYW4=?=) Date: Thu, 3 Mar 2022 07:11:24 GMT Subject: RFR: 8281681: compiler/profiling/spectrapredefineclass_classloaders/Launcher.java crash when CodeCache is full In-Reply-To: References: Message-ID: <2gEp8YTEjvkoemBhYAWwSSq073Y2L7067xVK-qdi7XQ=.90bf3588-8ba7-444b-a214-c93d16dfd901@github.com> On Tue, 1 Mar 2022 04:39:37 GMT, Dean Long wrote: > I wasn't able to reproduce this, but from looking at the core dump, not trying to emit more instructions when the code cache is full should definitely help. Loks good. ------------- PR: https://git.openjdk.java.net/loom/pull/93 From alanb at openjdk.java.net Thu Mar 3 08:10:29 2022 From: alanb at openjdk.java.net (Alan Bateman) Date: Thu, 3 Mar 2022 08:10:29 GMT Subject: RFR: Fix unloading tests to not have extra full GCs. In-Reply-To: References: Message-ID: On Thu, 3 Mar 2022 00:12:57 GMT, Coleen Phillimore wrote: > Added -XX:-MethodFlushing to turn off the sweeper, which prevents full GCs that make the test useless. Marked as reviewed by alanb (Committer). ------------- PR: https://git.openjdk.java.net/loom/pull/94 From duke at openjdk.java.net Thu Mar 3 09:43:10 2022 From: duke at openjdk.java.net (duke) Date: Thu, 3 Mar 2022 09:43:10 GMT Subject: git: openjdk/loom: fibers: 2 new changesets Message-ID: <1d17073a-788a-404d-bffe-c71d35e63f08@openjdk.java.net> Changeset: 96de9738 Author: Ron Pressler Date: 2022-03-03 09:36:14 +0000 URL: https://git.openjdk.java.net/loom/commit/96de9738e94b21e0746298c322bb8ed74c1c8e91 Cleanup ! src/hotspot/cpu/aarch64/continuation_aarch64.inline.hpp ! src/hotspot/cpu/x86/continuation_x86.inline.hpp ! src/hotspot/share/oops/instanceStackChunkKlass.cpp ! src/hotspot/share/oops/instanceStackChunkKlass.inline.hpp ! src/hotspot/share/runtime/continuation.cpp Changeset: 138d3bdc Author: Ron Pressler Date: 2022-03-03 09:41:23 +0000 URL: https://git.openjdk.java.net/loom/commit/138d3bdc5ac57ac2c26106aac9629d26c1daa077 Fix thread dumps to show carriers only ! src/hotspot/share/runtime/continuation.cpp ! src/hotspot/share/runtime/continuation.hpp ! src/hotspot/share/runtime/frame.cpp ! src/hotspot/share/runtime/frame.hpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/vframe.cpp ! src/hotspot/share/runtime/vframe.hpp ! src/hotspot/share/services/threadService.cpp ! test/hotspot/jtreg/ProblemList-vthread.txt From alanb at openjdk.java.net Thu Mar 3 10:32:28 2022 From: alanb at openjdk.java.net (Alan Bateman) Date: Thu, 3 Mar 2022 10:32:28 GMT Subject: RFR: Cleanup for v1 [v3] In-Reply-To: <_7Z4QpjME80k6hWYMFOkFLhjdm712O5iuCbaBWIDG1o=.d9d15d94-c202-4d99-81ba-5b24fa16c412@github.com> References: <_7Z4QpjME80k6hWYMFOkFLhjdm712O5iuCbaBWIDG1o=.d9d15d94-c202-4d99-81ba-5b24fa16c412@github.com> Message-ID: On Mon, 4 Jan 2021 14:12:16 GMT, Andrew Haley wrote: >> This is the Big Diff that removes scope locals, Lifetimes, etc. I've left the virtual machine support in for now. I'm also going to create a separate branch with the simple virtual ThreadLocal support + Lifetimes, and we'll see what that looks like. > > Andrew Haley has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: > > - Remove Lifetimes and scope variables > - Remove Lifetimes and scope variables > - Remove Lifetimes and scope variables > - Remove Lifetimes and scope variables I guess we can close this. ------------- PR: https://git.openjdk.java.net/loom/pull/18 From aph at openjdk.java.net Thu Mar 3 11:00:21 2022 From: aph at openjdk.java.net (Andrew Haley) Date: Thu, 3 Mar 2022 11:00:21 GMT Subject: Withdrawn: Cleanup for v1 In-Reply-To: References: Message-ID: <8i_xwDl2kZ7HWty0vrhkaAroH5zgsMG5fYA56kazJtc=.35e7b98d-1259-45c0-b2ff-3e7f345afd69@github.com> On Tue, 13 Oct 2020 14:39:24 GMT, Andrew Haley wrote: > This is the Big Diff that removes scope locals, Lifetimes, etc. I've left the virtual machine support in for now. I'm also going to create a separate branch with the simple virtual ThreadLocal support + Lifetimes, and we'll see what that looks like. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/loom/pull/18 From duke at openjdk.java.net Thu Mar 3 12:19:36 2022 From: duke at openjdk.java.net (duke) Date: Thu, 3 Mar 2022 12:19:36 GMT Subject: git: openjdk/loom: fibers: Don't print osthread state when virtual thread is mounted Message-ID: Changeset: 6a12ea5d Author: Ron Pressler Date: 2022-03-03 11:38:02 +0000 URL: https://git.openjdk.java.net/loom/commit/6a12ea5db302e66490cfb79a5fe40e98ebef899b Don't print osthread state when virtual thread is mounted ! src/hotspot/share/runtime/thread.cpp From coleenp at openjdk.java.net Thu Mar 3 13:15:28 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Thu, 3 Mar 2022 13:15:28 GMT Subject: RFR: Fix unloading tests to not have extra full GCs. In-Reply-To: References: Message-ID: On Thu, 3 Mar 2022 00:12:57 GMT, Coleen Phillimore wrote: > Added -XX:-MethodFlushing to turn off the sweeper, which prevents full GCs that make the test useless. Thanks Alan. Let's see if ------------- PR: https://git.openjdk.java.net/loom/pull/94 From coleenp at openjdk.java.net Thu Mar 3 13:15:29 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Thu, 3 Mar 2022 13:15:29 GMT Subject: Integrated: Fix unloading tests to not have extra full GCs. In-Reply-To: References: Message-ID: <4yMTwno_d16EpdN2p52nVHFo2RtOQ1FDmDjL7ndIjt8=.9f6c86fd-8ef7-4c58-aa4d-e41215e0e51b@github.com> On Thu, 3 Mar 2022 00:12:57 GMT, Coleen Phillimore wrote: > Added -XX:-MethodFlushing to turn off the sweeper, which prevents full GCs that make the test useless. This pull request has now been integrated. Changeset: db0be8b7 Author: Coleen Phillimore URL: https://git.openjdk.java.net/loom/commit/db0be8b78e518fcdc0ba683ffe7ec429e823080d Stats: 12 lines in 5 files changed: 4 ins; 4 del; 4 mod Fix unloading tests to not have extra full GCs. Reviewed-by: alanb ------------- PR: https://git.openjdk.java.net/loom/pull/94 From coleenp at openjdk.java.net Thu Mar 3 13:22:31 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Thu, 3 Mar 2022 13:22:31 GMT Subject: RFR: Inject StackChunk fields. Message-ID: This injects StackChunk fields that aren't being used by Java into VM only. It also fixes most types to be C++. tested with loom-tier1 and 2. ------------- Commit messages: - Inject StackChunk fields. Changes: https://git.openjdk.java.net/loom/pull/95/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=95&range=00 Stats: 70 lines in 4 files changed: 21 ins; 21 del; 28 mod Patch: https://git.openjdk.java.net/loom/pull/95.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/95/head:pull/95 PR: https://git.openjdk.java.net/loom/pull/95 From coleenp at openjdk.java.net Thu Mar 3 13:32:19 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Thu, 3 Mar 2022 13:32:19 GMT Subject: RFR: Inject StackChunk fields. In-Reply-To: References: Message-ID: On Thu, 3 Mar 2022 13:16:36 GMT, Coleen Phillimore wrote: > This injects StackChunk fields that aren't being used by Java into VM only. It also fixes most types to be C++. > tested with loom-tier1 and 2. Thanks Ron. ------------- PR: https://git.openjdk.java.net/loom/pull/95 From coleenp at openjdk.java.net Thu Mar 3 13:32:20 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Thu, 3 Mar 2022 13:32:20 GMT Subject: Integrated: Inject StackChunk fields. In-Reply-To: References: Message-ID: On Thu, 3 Mar 2022 13:16:36 GMT, Coleen Phillimore wrote: > This injects StackChunk fields that aren't being used by Java into VM only. It also fixes most types to be C++. > tested with loom-tier1 and 2. This pull request has now been integrated. Changeset: c95cdb75 Author: Coleen Phillimore URL: https://git.openjdk.java.net/loom/commit/c95cdb75bbcdc7b18da2d84b40b7e524d4fe1909 Stats: 70 lines in 4 files changed: 21 ins; 21 del; 28 mod Inject StackChunk fields. Reviewed-by: rpressler ------------- PR: https://git.openjdk.java.net/loom/pull/95 From rpressler at openjdk.java.net Thu Mar 3 13:32:19 2022 From: rpressler at openjdk.java.net (Ron Pressler) Date: Thu, 3 Mar 2022 13:32:19 GMT Subject: RFR: Inject StackChunk fields. In-Reply-To: References: Message-ID: On Thu, 3 Mar 2022 13:16:36 GMT, Coleen Phillimore wrote: > This injects StackChunk fields that aren't being used by Java into VM only. It also fixes most types to be C++. > tested with loom-tier1 and 2. Marked as reviewed by rpressler (Lead). ------------- PR: https://git.openjdk.java.net/loom/pull/95 From duke at openjdk.java.net Thu Mar 3 14:30:16 2022 From: duke at openjdk.java.net (duke) Date: Thu, 3 Mar 2022 14:30:16 GMT Subject: git: openjdk/loom: fibers: Mark chunk flags read/write as atomic; cleanup Message-ID: <7c09aa5a-9db1-4d5d-9116-d518cbbda03c@openjdk.java.net> Changeset: 167db9ea Author: Ron Pressler Date: 2022-03-03 13:50:51 +0000 URL: https://git.openjdk.java.net/loom/commit/167db9ea0fd7a6cc63d92ce57e2a2a4437c68662 Mark chunk flags read/write as atomic; cleanup ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/javaClasses.inline.hpp ! src/hotspot/share/oops/stackChunkOop.inline.hpp From duke at openjdk.java.net Thu Mar 3 15:13:37 2022 From: duke at openjdk.java.net (duke) Date: Thu, 3 Mar 2022 15:13:37 GMT Subject: git: openjdk/loom: fibers: 4 new changesets Message-ID: <4d8a7108-7dd2-4bb9-bf2c-83b72ae740bd@openjdk.java.net> Changeset: ea157b13 Author: Alan Bateman Date: 2022-03-03 08:58:53 +0000 URL: https://git.openjdk.java.net/loom/commit/ea157b137b3a9f2e6443694afc486c4e25d01af0 Cleanup, reorder methods ! src/java.base/share/classes/jdk/internal/vm/ThreadDumper.java Changeset: bdedafba Author: Alan Bateman Date: 2022-03-03 09:26:25 +0000 URL: https://git.openjdk.java.net/loom/commit/bdedafba60f4ce7ebe182e2ba6400d46fdad893e Exclude jdk/jfr/event/oldobject/TestLargeRootSet.java ! test/jdk/ProblemList.txt Changeset: 536d52b4 Author: Alan Bateman Date: 2022-03-03 13:51:26 +0000 URL: https://git.openjdk.java.net/loom/commit/536d52b4b417a8a3af5bdbbe3949d53e94218e78 More vmTestbase/vm/gc/compacts not suitable for wrapper + src/java.base/share/classes/jdk/internal/misc/PreviewFeatures.java ! test/hotspot/jtreg/ProblemList-vthread.txt ! test/jdk/ProblemList.txt Changeset: 4f374e56 Author: Alan Bateman Date: 2022-03-03 14:05:14 +0000 URL: https://git.openjdk.java.net/loom/commit/4f374e56869f98e8a910eb5d9fb1a568e10fb405 Add checks that preview features are enabled, does nothing for now ! make/RunTests.gmk ! src/java.base/share/classes/java/lang/Thread.java ! src/java.base/share/classes/jdk/internal/misc/PreviewFeatures.java ! src/java.base/share/classes/jdk/internal/vm/Continuation.java ! src/java.base/windows/classes/sun/nio/fs/WindowsSecurity.java ! test/jdk/jdk/internal/vm/Continuation/Basic.java ! test/jdk/jdk/internal/vm/Continuation/Fuzz.java ! test/jdk/jdk/internal/vm/Continuation/HumongousStack.java ! test/jdk/jdk/internal/vm/Continuation/LiveFramesDriver.java ! test/jdk/jdk/internal/vm/Continuation/Preempt.java ! test/jdk/jdk/internal/vm/Continuation/PreemptLiveFramesDriver.java ! test/jdk/jdk/internal/vm/Continuation/Scoped.java From duke at openjdk.java.net Thu Mar 3 19:44:50 2022 From: duke at openjdk.java.net (duke) Date: Thu, 3 Mar 2022 19:44:50 GMT Subject: git: openjdk/loom: fibers: Fix gtest. Message-ID: <6ec75af9-2887-49c5-8787-5a8833331a34@openjdk.java.net> Changeset: 2a7e0f32 Author: Coleen Phillimore Date: 2022-03-03 19:43:48 +0000 URL: https://git.openjdk.java.net/loom/commit/2a7e0f32ccf86ced67205d7ec0b2641aa4579cb5 Fix gtest. ! test/hotspot/gtest/runtime/test_suspend.cpp ! test/hotspot/jtreg/ProblemList.txt From duke at openjdk.java.net Thu Mar 3 19:48:39 2022 From: duke at openjdk.java.net (duke) Date: Thu, 3 Mar 2022 19:48:39 GMT Subject: git: openjdk/loom: fibers: 3 new changesets Message-ID: <88bb08e6-3a15-41da-b076-93b4301c87a7@openjdk.java.net> Changeset: 4c7b6a83 Author: Alan Bateman Date: 2022-03-03 17:53:00 +0000 URL: https://git.openjdk.java.net/loom/commit/4c7b6a83af82f2094f6b6d0726dc9bc9736a684c Comment constructor ! src/java.base/share/classes/java/lang/ThreadLocal.java Changeset: 60b1efd0 Author: Alan Bateman Date: 2022-03-03 18:12:09 +0000 URL: https://git.openjdk.java.net/loom/commit/60b1efd04dba8fa926f4ed9439c20eb45e5e029c Drop using --enable-preview with wrapper for now ! make/RunTests.gmk Changeset: bddcffb8 Author: Alan Bateman Date: 2022-03-03 18:14:30 +0000 URL: https://git.openjdk.java.net/loom/commit/bddcffb8684a5ab9b90e4d1757109ab1d218b701 Update comment ! make/data/hotspot-symbols/symbols-unix From dlong at openjdk.java.net Thu Mar 3 21:42:34 2022 From: dlong at openjdk.java.net (Dean Long) Date: Thu, 3 Mar 2022 21:42:34 GMT Subject: RFR: 8281681: compiler/profiling/spectrapredefineclass_classloaders/Launcher.java crash when CodeCache is full In-Reply-To: References: Message-ID: On Tue, 1 Mar 2022 04:39:37 GMT, Dean Long wrote: > I wasn't able to reproduce this, but from looking at the core dump, not trying to emit more instructions when the code cache is full should definitely help. Thanks Ron and Rickard for the reviews. ------------- PR: https://git.openjdk.java.net/loom/pull/93 From duke at openjdk.java.net Thu Mar 3 22:39:56 2022 From: duke at openjdk.java.net (duke) Date: Thu, 3 Mar 2022 22:39:56 GMT Subject: git: openjdk/loom: fibers: Unproblem list test that doesn't fail for me locally. Message-ID: <2127bd28-ccfa-491c-8018-160692ffc0a3@openjdk.java.net> Changeset: a1a5be33 Author: Coleen Phillimore Date: 2022-03-03 22:38:57 +0000 URL: https://git.openjdk.java.net/loom/commit/a1a5be3347592b43eca3666af4679a826ef35272 Unproblem list test that doesn't fail for me locally. ! test/hotspot/jtreg/ProblemList.txt From duke at openjdk.java.net Fri Mar 4 12:02:11 2022 From: duke at openjdk.java.net (duke) Date: Fri, 4 Mar 2022 12:02:11 GMT Subject: git: openjdk/loom: fibers: 2 new changesets Message-ID: <54733fdd-f5fe-43f2-93e0-d2dd14c0a14d@openjdk.java.net> Changeset: b45d1cdc Author: Alan Bateman Date: 2022-03-04 11:53:26 +0000 URL: https://git.openjdk.java.net/loom/commit/b45d1cdcb1da1f21201a1ac7447ea89f409ca786 Update JDWP SetValues, PopFrame, and ForceEarlyReturn commands ! make/data/jdwp/jdwp.spec Changeset: 3dbfbf8a Author: Alan Bateman Date: 2022-03-04 11:59:20 +0000 URL: https://git.openjdk.java.net/loom/commit/3dbfbf8ab6a178808b44fc43ad631528009bbbdc Exclude jdk/jfr/event/runtime/TestThreadDumpEvent.java from wrapper run ! test/jdk/ProblemList-vthread.txt ! test/jdk/ProblemList.txt From duke at openjdk.java.net Fri Mar 4 14:54:48 2022 From: duke at openjdk.java.net (duke) Date: Fri, 4 Mar 2022 14:54:48 GMT Subject: git: openjdk/loom: fibers: JFR Loom refresh Message-ID: Changeset: 442ea0f0 Author: mgronlun Date: 2022-03-04 14:54:13 +0000 URL: https://git.openjdk.java.net/loom/commit/442ea0f055f66a796431460d11c06e94a6a379ac JFR Loom refresh ! make/data/hotspot-symbols/symbols-unix ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/javaClasses.inline.hpp ! src/hotspot/share/gc/shared/copyFailedInfo.hpp ! src/hotspot/share/include/jvm.h ! src/hotspot/share/jfr/jfr.cpp ! src/hotspot/share/jfr/jfr.hpp ! src/hotspot/share/jfr/jni/jfrJavaSupport.cpp ! src/hotspot/share/jfr/jni/jfrJavaSupport.hpp ! src/hotspot/share/jfr/leakprofiler/sampling/objectSampler.cpp ! src/hotspot/share/jfr/periodic/jfrPeriodic.cpp ! src/hotspot/share/jfr/periodic/jfrThreadCPULoadEvent.cpp ! src/hotspot/share/jfr/periodic/sampling/jfrThreadSampler.cpp ! src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointManager.cpp ! src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointManager.hpp ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrThreadGroup.cpp ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrType.cpp ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeManager.cpp ! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrOopTraceId.hpp ! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrOopTraceId.inline.hpp ! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceId.cpp ! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceId.hpp ! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceId.inline.hpp ! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdEpoch.hpp ! src/hotspot/share/jfr/recorder/jfrRecorder.cpp ! src/hotspot/share/jfr/recorder/jfrRecorder.hpp ! src/hotspot/share/jfr/recorder/stacktrace/jfrStackTrace.cpp ! src/hotspot/share/jfr/recorder/stacktrace/jfrStackTrace.hpp ! src/hotspot/share/jfr/support/jfrIntrinsics.cpp ! src/hotspot/share/jfr/support/jfrIntrinsics.hpp - src/hotspot/share/jfr/support/jfrJavaThread.cpp - src/hotspot/share/jfr/support/jfrJavaThread.hpp ! src/hotspot/share/jfr/support/jfrThreadExtension.hpp ! src/hotspot/share/jfr/support/jfrThreadId.hpp + src/hotspot/share/jfr/support/jfrThreadId.inline.hpp ! src/hotspot/share/jfr/support/jfrThreadLocal.cpp ! src/hotspot/share/jfr/support/jfrThreadLocal.hpp ! src/hotspot/share/jfr/support/jfrTraceIdExtension.hpp ! src/hotspot/share/jfr/writers/jfrJavaEventWriter.cpp ! src/hotspot/share/jfr/writers/jfrJavaEventWriter.hpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/opto/library_call.hpp ! src/hotspot/share/opto/runtime.cpp ! src/hotspot/share/prims/jni.cpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/runtime/java.cpp ! src/hotspot/share/runtime/objectMonitor.cpp ! src/hotspot/share/runtime/stubRoutines.cpp ! src/hotspot/share/runtime/stubRoutines.hpp + src/hotspot/share/runtime/threadIdentifiers.cpp + src/hotspot/share/runtime/threadIdentifiers.hpp ! src/hotspot/share/runtime/vmThread.cpp ! src/java.base/share/classes/java/lang/Thread.java ! src/java.base/share/native/libjava/Thread.c From duke at openjdk.java.net Fri Mar 4 16:09:30 2022 From: duke at openjdk.java.net (duke) Date: Fri, 4 Mar 2022 16:09:30 GMT Subject: git: openjdk/loom: fibers: restore final tid Message-ID: Changeset: 25e9dfa0 Author: mgronlun Date: 2022-03-04 17:06:45 +0000 URL: https://git.openjdk.java.net/loom/commit/25e9dfa0a02657f3656e0e0b25a13dc6a6012aee restore final tid ! src/hotspot/share/opto/library_call.cpp ! src/java.base/share/classes/java/lang/Thread.java From duke at openjdk.java.net Fri Mar 4 19:46:52 2022 From: duke at openjdk.java.net (duke) Date: Fri, 4 Mar 2022 19:46:52 GMT Subject: git: openjdk/loom: fibers: Fix suspend test again. Message-ID: Changeset: 98eefac5 Author: Coleen Phillimore Date: 2022-03-04 19:46:17 +0000 URL: https://git.openjdk.java.net/loom/commit/98eefac5ec68fbb702e31db553764eadd09d9689 Fix suspend test again. ! test/hotspot/gtest/runtime/test_suspend.cpp From duke at openjdk.java.net Sat Mar 5 04:55:44 2022 From: duke at openjdk.java.net (duke) Date: Sat, 5 Mar 2022 04:55:44 GMT Subject: git: openjdk/loom: fibers: fixed 8282579: [LOOM] JVMTI GetThreadState returns incorrect state for vthread waiting on a monitor Message-ID: <51e5f49d-b67f-4e31-a046-6a139f8fbb94@openjdk.java.net> Changeset: 326c5c36 Author: Serguei Spitsyn Date: 2022-03-05 04:55:24 +0000 URL: https://git.openjdk.java.net/loom/commit/326c5c36d44983ed5b4124bdbcf938b51c09074f fixed 8282579: [LOOM] JVMTI GetThreadState returns incorrect state for vthread waiting on a monitor ! src/hotspot/share/prims/jvmtiEnv.cpp ! src/hotspot/share/prims/jvmtiEnvBase.cpp ! src/hotspot/share/prims/jvmtiEnvBase.hpp ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/waitingThreads/waitingthreads002a.java From duke at openjdk.java.net Sat Mar 5 09:41:17 2022 From: duke at openjdk.java.net (duke) Date: Sat, 5 Mar 2022 09:41:17 GMT Subject: git: openjdk/loom: fibers: improve some JVMTI tests stability by handling WRONG_PHASE and THREAD_NOT_ALIVE err codes Message-ID: <1aac2625-072b-4ea7-b053-b29f39d363ff@openjdk.java.net> Changeset: 619af4fa Author: Serguei Spitsyn Date: 2022-03-05 09:40:25 +0000 URL: https://git.openjdk.java.net/loom/commit/619af4fae65dfb8f5e5a93ef0f4a394428e2edfb improve some JVMTI tests stability by handling WRONG_PHASE and THREAD_NOT_ALIVE err codes ! test/hotspot/jtreg/serviceability/jvmti/vthread/BreakpointInYieldTest/libBreakpointInYieldTest.cpp ! test/hotspot/jtreg/serviceability/jvmti/vthread/GetSetLocalTest/libGetSetLocalTest.cpp ! test/lib/jdk/test/lib/jvmti/jvmti_common.h From duke at openjdk.java.net Sat Mar 5 12:10:03 2022 From: duke at openjdk.java.net (duke) Date: Sat, 5 Mar 2022 12:10:03 GMT Subject: git: openjdk/loom: fibers: 2 new changesets Message-ID: Changeset: 913d2d48 Author: Alan Bateman Date: 2022-03-05 07:15:06 +0000 URL: https://git.openjdk.java.net/loom/commit/913d2d48ce32537176c143d26935963d04e5b0ce Cleanup ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/vmClassMacros.hpp ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/prims/jvmtiEnv.cpp ! src/java.base/share/classes/java/lang/Thread.java Changeset: fd5faf55 Author: Alan Bateman Date: 2022-03-05 10:57:06 +0000 URL: https://git.openjdk.java.net/loom/commit/fd5faf559bab1f5f24b74a92459e8dcab850d8ad More spec updates ! make/data/jdwp/jdwp.spec ! src/hotspot/share/prims/jvmti.xml ! src/hotspot/share/prims/jvmti.xsl ! src/jdk.jdi/share/classes/com/sun/jdi/StackFrame.java ! src/jdk.jdi/share/classes/com/sun/jdi/ThreadReference.java From duke at openjdk.java.net Sat Mar 5 13:47:41 2022 From: duke at openjdk.java.net (duke) Date: Sat, 5 Mar 2022 13:47:41 GMT Subject: git: openjdk/loom: fibers: 76 new changesets Message-ID: Changeset: 35076af1 Author: Pavel Rappo Date: 2022-02-23 16:17:23 +0000 URL: https://git.openjdk.java.net/loom/commit/35076af13acd1b9327d35ac67dc80c15bb1059c7 8281376: Consider polymorphic methods when looking for overrides Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/WorkArounds.java ! test/langtools/jdk/javadoc/doclet/testOverriddenMethods/TestOverrideMethods.java + test/langtools/jdk/javadoc/doclet/testOverriddenMethods/pkg8/C.java + test/langtools/jdk/javadoc/doclet/testOverriddenMethods/pkg8/GP.java + test/langtools/jdk/javadoc/doclet/testOverriddenMethods/pkg8/P.java Changeset: 99b8ed9d Author: Jonathan Gibbons Date: 2022-02-23 16:49:28 +0000 URL: https://git.openjdk.java.net/loom/commit/99b8ed9dbf88e21a42a8d2f6249bfab7176e7d42 8281217: Source file launch with security manager enabled fails Reviewed-by: sundar ! src/jdk.compiler/share/classes/com/sun/tools/javac/launcher/Main.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/launcher.properties ! test/langtools/tools/javac/launcher/SourceLauncherTest.java Changeset: a020b6ba Author: Lance Andersen Date: 2022-02-23 16:56:50 +0000 URL: https://git.openjdk.java.net/loom/commit/a020b6ba8f38fe85fb26972a51e4c1068408b1c1 8280409: JarFile::getInputStream can fail with NPE accessing ze.getName() Reviewed-by: mullan, alanb ! src/java.base/share/classes/java/util/jar/JarFile.java ! src/java.base/share/classes/java/util/zip/ZipFile.java + test/jdk/java/util/zip/ZipFile/GetInputStreamNPETest.java Changeset: 7dc7184c Author: Xue-Lei Andrew Fan Date: 2022-02-23 18:32:29 +0000 URL: https://git.openjdk.java.net/loom/commit/7dc7184c10fc8f7a02113056da979a9846a14cd4 8282309: Operation before upper case conversion Reviewed-by: valeriep, wetmore ! src/java.base/share/classes/sun/security/util/TlsChannelBinding.java Changeset: e540e0a8 Author: Michael McMahon Date: 2022-02-23 20:02:11 +0000 URL: https://git.openjdk.java.net/loom/commit/e540e0a81b923cce8b2f2689e01703509a4df1de 8282296: (se) Pipe.open() creates a Pipe implementation that uses Unix domain sockets (win) Reviewed-by: dfuchs, lancea, bpb ! src/java.base/windows/classes/sun/nio/ch/PipeImpl.java Changeset: f86f38a8 Author: Vladimir Ivanov Date: 2022-02-23 20:29:23 +0000 URL: https://git.openjdk.java.net/loom/commit/f86f38a8afd31c76039206f8f1f33371ad814396 8280901: MethodHandle::linkToNative stub is missing w/ -Xint Reviewed-by: shade, kvn ! src/hotspot/share/classfile/systemDictionary.cpp ! test/jdk/java/foreign/TestDowncall.java Changeset: 253cf785 Author: Chris Plummer Date: 2022-02-23 21:09:41 +0000 URL: https://git.openjdk.java.net/loom/commit/253cf7852f60ecf92e6d675ae2469e5f27425609 8282076: Merge some debug agent changes from the loom repo Reviewed-by: amenkov, lmesnik ! src/jdk.jdwp.agent/share/native/libjdwp/eventHandler.c ! src/jdk.jdwp.agent/share/native/libjdwp/stepControl.c ! src/jdk.jdwp.agent/share/native/libjdwp/threadControl.c Changeset: 43dc9ef6 Author: Manukumar V S Committer: Alexey Ivanov Date: 2022-02-23 21:13:23 +0000 URL: https://git.openjdk.java.net/loom/commit/43dc9ef619b823e033cb1e298bbc091eb5a50967 8281988: Create a regression test for JDK-4618767 Reviewed-by: aivanov + test/jdk/javax/swing/JList/4618767/JListSelectedElementTest.java Changeset: a6610031 Author: Chris Plummer Date: 2022-02-23 22:55:39 +0000 URL: https://git.openjdk.java.net/loom/commit/a6610031e2816156fa14876457e260282a88d478 8281614: serviceability/sa/ClhsdbFindPC.java fails with java.lang.RuntimeException: 'In code in NMethod for jdk/test/lib/apps/LingeredApp.steadyState' missing from stdout/stderr Reviewed-by: dcubed, dholmes ! test/hotspot/jtreg/serviceability/sa/ClhsdbFindPC.java Changeset: cd3e59ef Author: Albert Mingkun Yang Date: 2022-02-24 09:16:04 +0000 URL: https://git.openjdk.java.net/loom/commit/cd3e59ef88bcc040f9d671c8c15370efaae3ffd8 8282299: Remove unused PartialArrayScanTask default constructor Reviewed-by: tschatzl ! src/hotspot/share/gc/shared/taskqueue.hpp Changeset: 379fd859 Author: Prasanta Sadhukhan Date: 2022-02-24 09:52:17 +0000 URL: https://git.openjdk.java.net/loom/commit/379fd85932e4b82e9a8e85f8ed8e63202f3cb9bc 8277369: Strange behavior of JMenuBar with RIGHT_TO_LEFT orientation, arrow keys behaves opposite traversing through keyboard Reviewed-by: prr, naoto, serb ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicPopupMenuUI.java + test/jdk/javax/swing/JMenuBar/MenuBarRTLBug.java Changeset: 3cfffa4f Author: Andrey Turbanov Date: 2022-02-24 11:03:29 +0000 URL: https://git.openjdk.java.net/loom/commit/3cfffa4f8e5a0fff7f232130125c549f992b533b 8282188: Unused static field MathContext.DEFAULT_DIGITS Reviewed-by: darcy, bpb ! src/java.base/share/classes/java/math/MathContext.java Changeset: f4486a19 Author: Coleen Phillimore Date: 2022-02-24 12:59:15 +0000 URL: https://git.openjdk.java.net/loom/commit/f4486a190e38c57b7c10e6cff4622bd1b716a724 8262400: runtime/exceptionMsgs/AbstractMethodError/AbstractMethodErrorTest.java fails in test_ame5_compiled_vtable_stub with wrapper Reviewed-by: dholmes, lmesnik ! test/hotspot/jtreg/runtime/exceptionMsgs/AbstractMethodError/AbstractMethodErrorTest.java Changeset: 231e48fa Author: Johannes Bechberger Committer: Martin Doerr Date: 2022-02-24 14:32:22 +0000 URL: https://git.openjdk.java.net/loom/commit/231e48fa63aeb4e35c7c948f958695d62b7157ce 8282200: ShouldNotReachHere() reached by AsyncGetCallTrace after JDK-8280422 Reviewed-by: dholmes, mdoerr, kevinw ! src/hotspot/share/prims/forte.cpp ! src/hotspot/share/runtime/thread.hpp Changeset: 0796620b Author: Jonathan Gibbons Date: 2022-02-24 14:50:06 +0000 URL: https://git.openjdk.java.net/loom/commit/0796620b07c6287a130ab0a3a7279d69b5d7b8a1 8281944: JavaDoc throws java.lang.IllegalStateException: ERRONEOUS Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java ! test/langtools/jdk/javadoc/doclet/testSeeTag/TestSeeTag.java Changeset: abc0ce11 Author: Xue-Lei Andrew Fan Date: 2022-02-24 16:25:47 +0000 URL: https://git.openjdk.java.net/loom/commit/abc0ce11dfa0a751a12925763cb168d1d3b4f44a 8282316: Operation before String case conversion Reviewed-by: valeriep ! src/java.base/share/classes/sun/security/util/SignatureUtil.java Changeset: 6fab8a2d Author: Alan Hayward Committer: Andrew Dinn Date: 2022-02-24 16:38:56 +0000 URL: https://git.openjdk.java.net/loom/commit/6fab8a2d6a97dbd2ffceca275716d020cb9f1eea 8277204: Implement PAC-RET branch protection on Linux/AArch64 Reviewed-by: erikj, ihse, adinn, ngasson ! doc/building.md ! make/autoconf/flags-cflags.m4 ! make/autoconf/spec.gmk.in ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/assembler_aarch64.hpp ! src/hotspot/cpu/aarch64/c1_Runtime1_aarch64.cpp ! src/hotspot/cpu/aarch64/frame_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/g1/g1BarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/z/zBarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/globals_aarch64.hpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/pauth_aarch64.hpp ! src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp ! src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp ! src/hotspot/cpu/aarch64/vm_version_aarch64.cpp ! src/hotspot/cpu/aarch64/vm_version_aarch64.hpp ! src/hotspot/os_cpu/bsd_aarch64/pauth_bsd_aarch64.inline.hpp ! src/hotspot/os_cpu/linux_aarch64/pauth_linux_aarch64.inline.hpp ! src/hotspot/os_cpu/linux_aarch64/threadLS_linux_aarch64.S ! src/hotspot/os_cpu/linux_aarch64/vm_version_linux_aarch64.cpp ! src/hotspot/os_cpu/windows_aarch64/pauth_windows_aarch64.inline.hpp ! src/hotspot/share/gc/shared/barrierSetNMethod.cpp ! src/hotspot/share/jvmci/vmStructs_jvmci.cpp ! src/hotspot/share/opto/runtime.cpp ! src/hotspot/share/runtime/frame.cpp ! src/hotspot/share/runtime/sharedRuntime.cpp ! src/java.base/share/man/java.1 ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.aarch64/src/jdk/vm/ci/aarch64/AArch64.java ! test/hotspot/gtest/aarch64/aarch64-asmtest.py ! test/hotspot/gtest/aarch64/asmtest.out.h ! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/CodeInstallationTest.java ! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/TestHotSpotVMConfig.java ! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/aarch64/AArch64TestAssembler.java Changeset: 0b6862e8 Author: Albert Mingkun Yang Date: 2022-02-24 17:47:30 +0000 URL: https://git.openjdk.java.net/loom/commit/0b6862e803a03cf7f722f4f58b657712e74723fb 8282348: Remove unused CardTable::dirty_card_iterate Reviewed-by: kbarrett ! src/hotspot/share/gc/shared/cardTable.cpp ! src/hotspot/share/gc/shared/cardTable.hpp Changeset: 20e78f7a Author: Albert Mingkun Yang Date: 2022-02-24 17:48:20 +0000 URL: https://git.openjdk.java.net/loom/commit/20e78f7a8e2e589bc4fb7f0c928176048bd9172a 8282307: Parallel: Incorrect discovery mode in PCReferenceProcessor Reviewed-by: tschatzl, kbarrett ! src/hotspot/share/gc/parallel/psParallelCompact.cpp Changeset: 23995f82 Author: Daniel Jeli?ski Committer: Daniel Fuchs Date: 2022-02-24 18:18:52 +0000 URL: https://git.openjdk.java.net/loom/commit/23995f822e540d799eb4bbc969229422257fbb08 8281525: Enable Zc:strictStrings flag in Visual Studio build Reviewed-by: dholmes, ihse ! make/autoconf/flags-cflags.m4 ! src/hotspot/os/windows/os_windows.cpp ! src/java.security.jgss/windows/native/libsspi_bridge/sspi.cpp ! src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp ! src/jdk.jpackage/windows/native/libwixhelper/libwixhelper.cpp ! test/hotspot/gtest/runtime/test_os_windows.cpp Changeset: b6843a16 Author: Yi-Fan Tsai Committer: Paul Hohensee Date: 2022-02-24 19:42:16 +0000 URL: https://git.openjdk.java.net/loom/commit/b6843a162411b0fa32271592d8f3a6f241a54384 8005885: enhance PrintCodeCache to print more data Reviewed-by: xliu, phh ! src/hotspot/share/code/codeCache.cpp + test/hotspot/jtreg/compiler/codecache/CheckCodeCacheInfo.java Changeset: bf19fc65 Author: Roger Riggs Date: 2022-02-24 20:12:48 +0000 URL: https://git.openjdk.java.net/loom/commit/bf19fc65c71cba8cb4383d714fe8993acd01be0a 8280357: user.home = "?" when running with systemd DynamicUser=true Reviewed-by: naoto, alanb ! src/java.base/unix/native/libjava/java_props_md.c Changeset: cd36be42 Author: Kevin Walls Date: 2022-02-25 07:56:56 +0000 URL: https://git.openjdk.java.net/loom/commit/cd36be42c2eb3eacdb3625e87510eb15acac3230 8206187: javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java fails with Port already in use Reviewed-by: msheppar, amenkov ! test/jdk/javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java Changeset: 3efd6aa4 Author: Claes Redestad Date: 2022-02-25 08:55:46 +0000 URL: https://git.openjdk.java.net/loom/commit/3efd6aa4c9b6420520709281ab1ca46ba4242c87 8282347: AARCH64: Untaken branch in has_negatives stub Reviewed-by: aph, haosun, thartmann ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp Changeset: 9471f24c Author: KIRIYAMA Takuya Committer: Markus Gr?nlund Date: 2022-02-25 11:39:11 +0000 URL: https://git.openjdk.java.net/loom/commit/9471f24ca191832669a13e5a1ea73f7097a25927 8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device. Reviewed-by: mgronlun ! src/hotspot/share/jfr/jni/jfrJavaSupport.cpp ! src/hotspot/share/jfr/jni/jfrJavaSupport.hpp ! src/hotspot/share/jfr/writers/jfrStreamWriterHost.inline.hpp Changeset: b96b7437 Author: Thomas Stuefe Date: 2022-02-25 12:25:46 +0000 URL: https://git.openjdk.java.net/loom/commit/b96b743727a628c1b33cc9b3374f010c2ea30b78 8281015: Further simplify NMT backend Reviewed-by: zgu, mbaesken ! src/hotspot/share/runtime/os.cpp ! src/hotspot/share/services/mallocSiteTable.cpp ! src/hotspot/share/services/mallocSiteTable.hpp ! src/hotspot/share/services/mallocTracker.cpp ! src/hotspot/share/services/mallocTracker.hpp - src/hotspot/share/services/mallocTracker.inline.hpp ! src/hotspot/share/services/memTracker.cpp ! src/hotspot/share/services/memTracker.hpp ! src/hotspot/share/services/nmtCommon.hpp ! src/hotspot/share/utilities/debug.cpp Changeset: 735e86b0 Author: Matthias Baesken Date: 2022-02-25 12:26:44 +0000 URL: https://git.openjdk.java.net/loom/commit/735e86b0f71c97c2ba35c1cffd9b4492a8ca55bc 8282345: handle latest VS2022 in abstract_vm_version Reviewed-by: dholmes, mdoerr ! src/hotspot/share/runtime/abstract_vm_version.cpp Changeset: e96c599e Author: Erik Gahlin Date: 2022-02-25 12:56:09 +0000 URL: https://git.openjdk.java.net/loom/commit/e96c599ed2a30ea116803aac0e85ba701ad40e25 8271232: JFR: Scrub recording data Reviewed-by: mgronlun ! src/jdk.jfr/share/classes/jdk/jfr/consumer/RecordingFile.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/ChunkHeader.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/ChunkParser.java + src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/CompositeParser.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/ConstantLookup.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/ConstantMap.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/Dispatcher.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/EventParser.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/Parser.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/ParserFactory.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/ParserFilter.java + src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/Reference.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/StringParser.java + src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/filter/CheckPointEvent.java + src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/filter/CheckPointPool.java + src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/filter/ChunkWriter.java + src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/filter/Constants.java + src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/filter/PoolEntry.java + src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/filter/RecordingOutput.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/tool/Command.java + src/jdk.jfr/share/classes/jdk/jfr/internal/tool/Filters.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/tool/Main.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/tool/Metadata.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/tool/Print.java + src/jdk.jfr/share/classes/jdk/jfr/internal/tool/Scrub.java + test/jdk/jdk/jfr/api/consumer/TestRecordingFileSanitization.java + test/jdk/jdk/jfr/api/consumer/TestRecordingFileWrite.java + test/jdk/jdk/jfr/tool/TestScrub.java Changeset: 441e4850 Author: Erik Gahlin Date: 2022-02-25 18:36:11 +0000 URL: https://git.openjdk.java.net/loom/commit/441e48509c1ba88db942737715026404b4fe0767 8281739: JFR: Use message with Objects.requireNonNull Reviewed-by: mgronlun ! src/jdk.jfr/share/classes/jdk/jfr/AnnotationElement.java ! src/jdk.jfr/share/classes/jdk/jfr/Configuration.java ! src/jdk.jfr/share/classes/jdk/jfr/EventFactory.java ! src/jdk.jfr/share/classes/jdk/jfr/EventSettings.java ! src/jdk.jfr/share/classes/jdk/jfr/EventType.java ! src/jdk.jfr/share/classes/jdk/jfr/FlightRecorder.java ! src/jdk.jfr/share/classes/jdk/jfr/FlightRecorderPermission.java ! src/jdk.jfr/share/classes/jdk/jfr/Recording.java ! src/jdk.jfr/share/classes/jdk/jfr/ValueDescriptor.java ! src/jdk.jfr/share/classes/jdk/jfr/consumer/EventStream.java ! src/jdk.jfr/share/classes/jdk/jfr/consumer/RecordedObject.java ! src/jdk.jfr/share/classes/jdk/jfr/consumer/RecordingFile.java ! src/jdk.jfr/share/classes/jdk/jfr/consumer/RecordingStream.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/AbstractEventStream.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/EventFileStream.java ! src/jdk.management.jfr/share/classes/jdk/management/jfr/FlightRecorderMXBeanImpl.java Changeset: fb8bf818 Author: Alexander Matveev Date: 2022-02-25 20:49:59 +0000 URL: https://git.openjdk.java.net/loom/commit/fb8bf81842b55355f226ac9d8717646abd509721 8279995: jpackage --add-launcher option should allow overriding description Reviewed-by: asemenyuk ! src/jdk.jpackage/share/classes/jdk/jpackage/internal/AddLauncherArguments.java ! src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties ! src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources_ja.properties ! src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources_zh_CN.properties ! test/jdk/tools/jpackage/helpers/jdk/jpackage/test/AdditionalLauncher.java ! test/jdk/tools/jpackage/helpers/jdk/jpackage/test/WindowsHelper.java ! test/jdk/tools/jpackage/share/AddLauncherTest.java Changeset: c5c6058f Author: Ichiroh Takiguchi Date: 2022-02-26 03:33:29 +0000 URL: https://git.openjdk.java.net/loom/commit/c5c6058fd57d4b594012035eaf18a57257f4ad85 8282219: jdk/java/lang/ProcessBuilder/Basic.java fails on AIX Reviewed-by: rriggs ! test/jdk/java/lang/ProcessBuilder/Basic.java Changeset: cf6d2565 Author: Erik Gahlin Date: 2022-02-26 08:57:23 +0000 URL: https://git.openjdk.java.net/loom/commit/cf6d2565e93ac13fd03f01a0624530d6750d02c3 8282153: JFR: Check for recording waste Reviewed-by: mgronlun + test/jdk/jdk/jfr/jvm/TestWaste.java Changeset: afd4bcbc Author: Rajan Halade Date: 2022-02-26 17:10:08 +0000 URL: https://git.openjdk.java.net/loom/commit/afd4bcbc1d1b2a8a1c29005878c8e06c662a1f6e 8282398: EndingDotHostname.java test fails because SSL cert expired Reviewed-by: xuelei ! test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java ! test/jdk/javax/net/ssl/templates/SSLExampleCert.java Changeset: 630ad1ac Author: Daniel D. Daugherty Date: 2022-02-27 03:45:49 +0000 URL: https://git.openjdk.java.net/loom/commit/630ad1acb20abae8bde037b8d23dd2a14a70d732 8282428: ProblemList jdk/jfr/jvm/TestWaste.java Reviewed-by: mikael ! test/jdk/ProblemList.txt Changeset: 86723d48 Author: Aleksey Shipilev Date: 2022-02-28 07:35:19 +0000 URL: https://git.openjdk.java.net/loom/commit/86723d4892485651bcae735ed13545ea89b9bb22 8281507: Two javac tests have bad jtreg `@clean` tags Reviewed-by: darcy ! test/langtools/tools/javac/8074306/TestSyntheticNullChecks.java ! test/langtools/tools/javac/StringConcat/TestIndyStringConcat.java Changeset: efd3967b Author: John Tortugo Committer: Christian Hagedorn Date: 2022-02-28 10:01:24 +0000 URL: https://git.openjdk.java.net/loom/commit/efd3967b54fed7eaa3c3072267f766d73a3acadb 8267265: Use new IR Test Framework to create tests for C2 Ideal transformations Reviewed-by: chagedorn + test/hotspot/jtreg/compiler/c2/irTests/AddINodeIdealizationTests.java + test/hotspot/jtreg/compiler/c2/irTests/AddLNodeIdealizationTests.java + test/hotspot/jtreg/compiler/c2/irTests/DivINodeIdealizationTests.java + test/hotspot/jtreg/compiler/c2/irTests/DivLNodeIdealizationTests.java + test/hotspot/jtreg/compiler/c2/irTests/MulINodeIdealizationTests.java + test/hotspot/jtreg/compiler/c2/irTests/MulLNodeIdealizationTests.java + test/hotspot/jtreg/compiler/c2/irTests/SubINodeIdealizationTests.java + test/hotspot/jtreg/compiler/c2/irTests/SubLNodeIdealizationTests.java + test/hotspot/jtreg/compiler/c2/irTests/loopOpts/LoopIdealizationTests.java + test/hotspot/jtreg/compiler/c2/irTests/scalarReplacement/ScalarReplacementTests.java ! test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java Changeset: 06cadb36 Author: Emanuel Peter Committer: Tobias Hartmann Date: 2022-02-28 12:13:35 +0000 URL: https://git.openjdk.java.net/loom/commit/06cadb36e05a86a528c8f3bc64c1a42b47ca94a0 8230382: Clean up ConvI2L, CastII and CastLL::Ideal methods Reviewed-by: thartmann, roland ! src/hotspot/share/opto/castnode.cpp ! src/hotspot/share/opto/convertnode.cpp Changeset: c58f5c67 Author: Harold Seigel Date: 2022-02-28 13:18:45 +0000 URL: https://git.openjdk.java.net/loom/commit/c58f5c67d1720d310c720667f7bf7486740c21c1 8282360: Merge POSIX implementations of ThreadCritical Reviewed-by: stuefe, coleenp, dholmes - src/hotspot/os/bsd/threadCritical_bsd.cpp - src/hotspot/os/linux/threadCritical_linux.cpp = src/hotspot/os/posix/threadCritical_posix.cpp Changeset: 0ae3d1d5 Author: Naoto Sato Date: 2022-02-28 13:22:15 +0000 URL: https://git.openjdk.java.net/loom/commit/0ae3d1d59c44e966e13345b9197fcf067e63900e 8282131: java.time.ZoneId should be a sealed abstract class Reviewed-by: iris, rriggs, bpb, lancea, mchung, scolebourne ! src/java.base/share/classes/java/time/ZoneId.java Changeset: 4e7fb41d Author: Aleksey Shipilev Date: 2022-02-28 13:29:23 +0000 URL: https://git.openjdk.java.net/loom/commit/4e7fb41dafaf03baabe18ee1dabefed50d69e16d 8282172: CompileBroker::log_metaspace_failure is called from non-Java/compiler threads Reviewed-by: kvn, thartmann ! src/hotspot/share/compiler/compileBroker.cpp Changeset: 59b3ecc5 Author: Weijun Wang Date: 2022-02-28 17:00:47 +0000 URL: https://git.openjdk.java.net/loom/commit/59b3ecc591ef6407d6b3f5532ecf889bf61339f0 8277976: Break up SEQUENCE in X509Certificate::getSubjectAlternativeNames and X509Certificate::getIssuerAlternativeNames in otherName 6776681: Invalid encoding of an OtherName in X509Certificate.getAlternativeNames() Reviewed-by: mullan ! src/java.base/share/classes/java/security/cert/X509Certificate.java ! src/java.base/share/classes/sun/security/x509/OtherName.java ! src/java.base/share/classes/sun/security/x509/X509CertImpl.java + test/jdk/sun/security/x509/OtherName/Parse.java Changeset: c7cd1487 Author: Coleen Phillimore Date: 2022-02-28 20:31:41 +0000 URL: https://git.openjdk.java.net/loom/commit/c7cd1487fe00172be59e7571991f960c59b8c0eb 8282240: Add _name field to Method for NOT_PRODUCT only Reviewed-by: pchilanomate, hseigel ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/defaultMethods.cpp ! src/hotspot/share/oops/method.cpp ! src/hotspot/share/oops/method.hpp ! test/hotspot/gtest/oops/test_instanceKlass.cpp Changeset: d983d108 Author: Ioi Lam Date: 2022-02-28 20:33:18 +0000 URL: https://git.openjdk.java.net/loom/commit/d983d108c565654e717e2811d88aa94d982da2f5 8275731: CDS archived enums objects are recreated at runtime Reviewed-by: coleenp, ccheung + src/hotspot/share/cds/cdsHeapVerifier.cpp + src/hotspot/share/cds/cdsHeapVerifier.hpp ! src/hotspot/share/cds/dumpTimeClassInfo.cpp ! src/hotspot/share/cds/dumpTimeClassInfo.hpp ! src/hotspot/share/cds/heapShared.cpp ! src/hotspot/share/cds/heapShared.hpp ! src/hotspot/share/cds/runTimeClassInfo.cpp ! src/hotspot/share/cds/runTimeClassInfo.hpp ! src/hotspot/share/classfile/systemDictionaryShared.cpp ! src/hotspot/share/classfile/systemDictionaryShared.hpp ! src/hotspot/share/classfile/vmClassMacros.hpp ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/klass.hpp + test/hotspot/jtreg/runtime/cds/appcds/cacheObject/ArchivedEnumApp.java + test/hotspot/jtreg/runtime/cds/appcds/cacheObject/ArchivedEnumTest.java Changeset: 9d9618a3 Author: Joe Darcy Date: 2022-02-28 22:14:14 +0000 URL: https://git.openjdk.java.net/loom/commit/9d9618a3dd29cb9328a7275375e04eca2af20a93 8282462: Remove unnecessary use of @SuppressWarnings("preview") Reviewed-by: vromero ! src/java.compiler/share/classes/javax/lang/model/element/ElementKind.java ! src/java.compiler/share/classes/javax/lang/model/util/AbstractElementVisitor6.java ! src/java.compiler/share/classes/javax/lang/model/util/ElementFilter.java ! src/java.compiler/share/classes/javax/lang/model/util/ElementKindVisitor6.java Changeset: 1f89acd8 Author: Joe Darcy Date: 2022-02-28 23:28:21 +0000 URL: https://git.openjdk.java.net/loom/commit/1f89acd8498945e1d531b7845748bcee8194115b 8282464: Remove author tags from java.compiler Reviewed-by: jjg ! src/java.compiler/share/classes/javax/annotation/processing/AbstractProcessor.java ! src/java.compiler/share/classes/javax/annotation/processing/Completion.java ! src/java.compiler/share/classes/javax/annotation/processing/Completions.java ! src/java.compiler/share/classes/javax/annotation/processing/Filer.java ! src/java.compiler/share/classes/javax/annotation/processing/FilerException.java ! src/java.compiler/share/classes/javax/annotation/processing/Messager.java ! src/java.compiler/share/classes/javax/annotation/processing/ProcessingEnvironment.java ! src/java.compiler/share/classes/javax/annotation/processing/Processor.java ! src/java.compiler/share/classes/javax/annotation/processing/RoundEnvironment.java ! src/java.compiler/share/classes/javax/annotation/processing/SupportedAnnotationTypes.java ! src/java.compiler/share/classes/javax/annotation/processing/SupportedOptions.java ! src/java.compiler/share/classes/javax/annotation/processing/SupportedSourceVersion.java ! src/java.compiler/share/classes/javax/annotation/processing/package-info.java ! src/java.compiler/share/classes/javax/lang/model/SourceVersion.java ! src/java.compiler/share/classes/javax/lang/model/UnknownEntityException.java ! src/java.compiler/share/classes/javax/lang/model/element/AnnotationMirror.java ! src/java.compiler/share/classes/javax/lang/model/element/AnnotationValue.java ! src/java.compiler/share/classes/javax/lang/model/element/AnnotationValueVisitor.java ! src/java.compiler/share/classes/javax/lang/model/element/Element.java ! src/java.compiler/share/classes/javax/lang/model/element/ElementKind.java ! src/java.compiler/share/classes/javax/lang/model/element/ElementVisitor.java ! src/java.compiler/share/classes/javax/lang/model/element/ExecutableElement.java ! src/java.compiler/share/classes/javax/lang/model/element/Modifier.java ! src/java.compiler/share/classes/javax/lang/model/element/Name.java ! src/java.compiler/share/classes/javax/lang/model/element/NestingKind.java ! src/java.compiler/share/classes/javax/lang/model/element/PackageElement.java ! src/java.compiler/share/classes/javax/lang/model/element/Parameterizable.java ! src/java.compiler/share/classes/javax/lang/model/element/QualifiedNameable.java ! src/java.compiler/share/classes/javax/lang/model/element/TypeElement.java ! src/java.compiler/share/classes/javax/lang/model/element/TypeParameterElement.java ! src/java.compiler/share/classes/javax/lang/model/element/UnknownAnnotationValueException.java ! src/java.compiler/share/classes/javax/lang/model/element/UnknownDirectiveException.java ! src/java.compiler/share/classes/javax/lang/model/element/UnknownElementException.java ! src/java.compiler/share/classes/javax/lang/model/element/VariableElement.java ! src/java.compiler/share/classes/javax/lang/model/element/package-info.java ! src/java.compiler/share/classes/javax/lang/model/package-info.java ! src/java.compiler/share/classes/javax/lang/model/type/ArrayType.java ! src/java.compiler/share/classes/javax/lang/model/type/DeclaredType.java ! src/java.compiler/share/classes/javax/lang/model/type/ErrorType.java ! src/java.compiler/share/classes/javax/lang/model/type/ExecutableType.java ! src/java.compiler/share/classes/javax/lang/model/type/MirroredTypeException.java ! src/java.compiler/share/classes/javax/lang/model/type/MirroredTypesException.java ! src/java.compiler/share/classes/javax/lang/model/type/NoType.java ! src/java.compiler/share/classes/javax/lang/model/type/NullType.java ! src/java.compiler/share/classes/javax/lang/model/type/PrimitiveType.java ! src/java.compiler/share/classes/javax/lang/model/type/ReferenceType.java ! src/java.compiler/share/classes/javax/lang/model/type/TypeKind.java ! src/java.compiler/share/classes/javax/lang/model/type/TypeMirror.java ! src/java.compiler/share/classes/javax/lang/model/type/TypeVariable.java ! src/java.compiler/share/classes/javax/lang/model/type/TypeVisitor.java ! src/java.compiler/share/classes/javax/lang/model/type/UnknownTypeException.java ! src/java.compiler/share/classes/javax/lang/model/type/WildcardType.java ! src/java.compiler/share/classes/javax/lang/model/type/package-info.java ! src/java.compiler/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor6.java ! src/java.compiler/share/classes/javax/lang/model/util/AbstractElementVisitor6.java ! src/java.compiler/share/classes/javax/lang/model/util/AbstractTypeVisitor6.java ! src/java.compiler/share/classes/javax/lang/model/util/ElementFilter.java ! src/java.compiler/share/classes/javax/lang/model/util/ElementKindVisitor6.java ! src/java.compiler/share/classes/javax/lang/model/util/ElementScanner6.java ! src/java.compiler/share/classes/javax/lang/model/util/Elements.java ! src/java.compiler/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor6.java ! src/java.compiler/share/classes/javax/lang/model/util/SimpleElementVisitor6.java ! src/java.compiler/share/classes/javax/lang/model/util/SimpleTypeVisitor6.java ! src/java.compiler/share/classes/javax/lang/model/util/TypeKindVisitor6.java ! src/java.compiler/share/classes/javax/lang/model/util/Types.java ! src/java.compiler/share/classes/javax/lang/model/util/package-info.java ! src/java.compiler/share/classes/javax/tools/Diagnostic.java ! src/java.compiler/share/classes/javax/tools/DiagnosticCollector.java ! src/java.compiler/share/classes/javax/tools/DiagnosticListener.java ! src/java.compiler/share/classes/javax/tools/FileObject.java ! src/java.compiler/share/classes/javax/tools/ForwardingFileObject.java ! src/java.compiler/share/classes/javax/tools/ForwardingJavaFileManager.java ! src/java.compiler/share/classes/javax/tools/ForwardingJavaFileObject.java ! src/java.compiler/share/classes/javax/tools/JavaCompiler.java ! src/java.compiler/share/classes/javax/tools/JavaFileManager.java ! src/java.compiler/share/classes/javax/tools/JavaFileObject.java ! src/java.compiler/share/classes/javax/tools/OptionChecker.java ! src/java.compiler/share/classes/javax/tools/SimpleJavaFileObject.java ! src/java.compiler/share/classes/javax/tools/StandardJavaFileManager.java ! src/java.compiler/share/classes/javax/tools/StandardLocation.java ! src/java.compiler/share/classes/javax/tools/Tool.java ! src/java.compiler/share/classes/javax/tools/ToolProvider.java ! src/java.compiler/share/classes/javax/tools/package-info.java Changeset: 77432663 Author: David Holmes Date: 2022-03-01 01:17:50 +0000 URL: https://git.openjdk.java.net/loom/commit/77432663be12da7fc44bb0ae0b1c8bf08eb6c249 8281210: Add manpage changes for PAC-RET protection on Linux/AArch64 Reviewed-by: iklam ! src/java.base/share/man/java.1 Changeset: c1a28aa0 Author: Alan Hayward Committer: Ningsheng Jian Date: 2022-03-01 02:23:29 +0000 URL: https://git.openjdk.java.net/loom/commit/c1a28aa04ada6c13031eaa85746e6b1d5945d10d 8282392: [zero] Build broken on AArch64 Reviewed-by: aph, shade ! src/hotspot/share/gc/shared/barrierSetNMethod.cpp ! src/hotspot/share/opto/runtime.cpp ! src/hotspot/share/runtime/frame.cpp ! src/hotspot/share/runtime/sharedRuntime.cpp ! src/hotspot/share/utilities/macros.hpp Changeset: e4d9fc81 Author: Jaikiran Pai Date: 2022-03-01 03:49:18 +0000 URL: https://git.openjdk.java.net/loom/commit/e4d9fc811e0ef0eb9b097e06525a1183445d8d79 8282023: PropertiesStoreTest and StoreReproducibilityTest jtreg failures due to en_CA locale Reviewed-by: naoto, rriggs ! test/jdk/java/util/Properties/PropertiesStoreTest.java ! test/jdk/java/util/Properties/StoreReproducibilityTest.java Changeset: d3022f87 Author: Dean Long Date: 2022-03-01 08:25:31 +0000 URL: https://git.openjdk.java.net/loom/commit/d3022f87b598398d7130e984088ede6ffc9f48e1 8282467: add extra diagnostics for JDK-8268184 Reviewed-by: stuefe ! src/hotspot/share/opto/ifg.cpp Changeset: 22b93a31 Author: Albert Mingkun Yang Date: 2022-03-01 09:32:01 +0000 URL: https://git.openjdk.java.net/loom/commit/22b93a31c99403996b6272b7c8eb0b9918988862 8282094: [REDO] Parallel: Refactor PSCardTable::scavenge_contents_parallel Reviewed-by: iwalulya, tschatzl ! src/hotspot/share/gc/parallel/psCardTable.cpp ! src/hotspot/share/gc/parallel/psCardTable.hpp Changeset: d4d12ad1 Author: Claes Redestad Date: 2022-03-01 10:20:22 +0000 URL: https://git.openjdk.java.net/loom/commit/d4d12ad1d92ae6d353ce9e16b1b72e6416874cd6 8282047: Enhance StringDecode/Encode microbenchmarks Reviewed-by: bchristi ! test/micro/org/openjdk/bench/java/lang/StringDecode.java ! test/micro/org/openjdk/bench/java/lang/StringEncode.java Changeset: 369291b2 Author: Chris Hegarty Date: 2022-03-01 10:37:35 +0000 URL: https://git.openjdk.java.net/loom/commit/369291b265e13d625c5f465da9b1854c0d70c435 8282444: Module finder incorrectly assumes default file system path-separator character Reviewed-by: alanb ! src/java.base/share/classes/jdk/internal/module/ModulePath.java ! test/jdk/java/lang/module/customfs/ModulesInCustomFileSystem.java ! test/jdk/java/lang/module/customfs/m1/p/Main.java ! test/jdk/java/lang/module/customfs/m2/module-info.java = test/jdk/java/lang/module/customfs/m2/q/r/Hello.java Changeset: eff396f3 Author: Pavel Rappo Date: 2022-03-01 12:06:11 +0000 URL: https://git.openjdk.java.net/loom/commit/eff396f397d3c279f9a090adb6ad4e619f24253c 8280713: Related to comment inheritance jdk.javadoc cleanup and refactoring Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/BaseConfiguration.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/BaseOptions.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/WorkArounds.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/ClassBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/ThrowsTaglet.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/UncheckedDocletException.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/VisibleMemberTable.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/links/LinkFactory.java ! test/jdk/java/lang/annotation/UnitTest.java ! test/langtools/jdk/javadoc/doclet/testInterface/TestInterface.java ! test/langtools/jdk/javadoc/doclet/testOverriddenMethods/pkg3/I2.java ! test/langtools/jdk/javadoc/doclet/testOverriddenMethods/pkg3/I3.java ! test/langtools/jdk/javadoc/doclet/testOverriddenMethods/pkg3/I4.java ! test/langtools/jdk/javadoc/doclet/testOverriddenMethods/pkg5/Classes.java ! test/langtools/jdk/javadoc/doclet/testOverriddenMethods/pkg5/Interfaces.java ! test/langtools/jdk/javadoc/doclet/testOverriddenMethods/pkg6/Sub.java ! test/langtools/jdk/javadoc/doclet/testPrivateClasses/TestPrivateClasses.java + test/langtools/jdk/javadoc/doclet/testTagInheritence/TestTagInheritance.java - test/langtools/jdk/javadoc/doclet/testTagInheritence/TestTagInheritence.java = test/langtools/jdk/javadoc/doclet/testTagInheritence/pkg/TestTagInheritance.java = test/langtools/jdk/javadoc/doclet/testThrowsInheritance/C.java = test/langtools/jdk/javadoc/doclet/testThrowsInheritance/Foo.java = test/langtools/jdk/javadoc/doclet/testThrowsInheritance/I.java = test/langtools/jdk/javadoc/doclet/testThrowsInheritance/Iface.java = test/langtools/jdk/javadoc/doclet/testThrowsInheritance/TestThrowsTagInheritance.java = test/langtools/jdk/javadoc/doclet/testThrowsInheritance/pkg/Abstract.java = test/langtools/jdk/javadoc/doclet/testThrowsInheritance/pkg/Extender.java Changeset: 44d599aa Author: David Holmes Date: 2022-03-01 12:07:21 +0000 URL: https://git.openjdk.java.net/loom/commit/44d599aad3994816997a61d9e36265dcefa52965 8227369: pd_disjoint_words_atomic() needs to be atomic Reviewed-by: eosterlund, mikael, shade, kbarrett, mdoerr ! src/hotspot/cpu/ppc/copy_ppc.hpp ! src/hotspot/cpu/x86/copy_x86.hpp ! src/hotspot/cpu/zero/copy_zero.hpp ! src/hotspot/os_cpu/windows_aarch64/copy_windows_aarch64.hpp ! src/hotspot/share/utilities/copy.hpp Changeset: a95edee6 Author: Harold Seigel Date: 2022-03-01 13:21:57 +0000 URL: https://git.openjdk.java.net/loom/commit/a95edee634c6be52043b55d1a8f3df85a58f97c7 8281472: JVM options processing silently truncates large illegal options values Reviewed-by: dholmes, iklam ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/arguments.hpp + test/hotspot/gtest/runtime/test_largeOptions.cpp ! test/hotspot/jtreg/gc/arguments/TestParallelGCThreads.java ! test/hotspot/jtreg/testlibrary/ctw/src/sun/hotspot/tools/ctw/CtwRunner.java Changeset: fcce24c5 Author: Roland Westrelin Date: 2022-03-01 14:09:15 +0000 URL: https://git.openjdk.java.net/loom/commit/fcce24c5b3cd1dab755fd9b6779af71f4dd78773 8281811: assert(_base == Tuple) failed: Not a Tuple after JDK-8280799 Reviewed-by: kvn, thartmann ! src/hotspot/share/opto/loopnode.cpp ! src/hotspot/share/opto/loopnode.hpp + test/hotspot/jtreg/gc/shenandoah/compiler/TestBarrierAboveProj.java Changeset: 341c8bd7 Author: Ivan Walulya Date: 2022-03-01 14:14:47 +0000 URL: https://git.openjdk.java.net/loom/commit/341c8bd7f2744d1899e78da34e613817b43b44e5 8267834: Refactor G1CardSetAllocator and BufferNode::Allocator to use a common base class Reviewed-by: kbarrett, tschatzl ! src/hotspot/share/gc/g1/g1CardSetMemory.cpp ! src/hotspot/share/gc/g1/g1CardSetMemory.hpp ! src/hotspot/share/gc/g1/g1CardSetMemory.inline.hpp ! src/hotspot/share/gc/g1/g1SegmentedArray.hpp ! src/hotspot/share/gc/g1/g1SegmentedArray.inline.hpp + src/hotspot/share/gc/shared/freeListAllocator.cpp + src/hotspot/share/gc/shared/freeListAllocator.hpp ! src/hotspot/share/gc/shared/ptrQueue.cpp ! src/hotspot/share/gc/shared/ptrQueue.hpp ! test/hotspot/gtest/gc/shared/test_ptrQueueBufferAllocator.cpp Changeset: 2c5d266f Author: Roland Westrelin Date: 2022-03-01 14:43:05 +0000 URL: https://git.openjdk.java.net/loom/commit/2c5d266f9f20005bc2a6c30dcaa95b059ea59d74 8282045: When loop strip mining fails, safepoints are removed from loop anyway Reviewed-by: thartmann, chagedorn ! src/hotspot/share/opto/loopnode.cpp + test/hotspot/jtreg/compiler/c2/irTests/TestStripMiningDropsSafepoint.java ! test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java Changeset: 31b61f98 Author: Pavel Rappo Date: 2022-03-01 15:21:19 +0000 URL: https://git.openjdk.java.net/loom/commit/31b61f982c41b52ae99bd8ecf1977a6c0de515e2 8282311: Fix a typo in javax.lang.model.type.NullType Reviewed-by: jjg ! src/java.compiler/share/classes/javax/lang/model/type/NullType.java Changeset: 76398c84 Author: Coleen Phillimore Date: 2022-03-01 15:28:21 +0000 URL: https://git.openjdk.java.net/loom/commit/76398c84007862bdf07cea6be792eca50eec9edd 8279573: compiler/codecache/CodeCacheFullCountTest.java fails with "RuntimeException: the value of full_count is wrong." Reviewed-by: thartmann, eosterlund ! src/hotspot/share/code/codeCache.cpp ! src/hotspot/share/memory/heap.hpp ! test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java Changeset: b03d66c5 Author: Jan Lahoda Date: 2022-03-01 15:54:10 +0000 URL: https://git.openjdk.java.net/loom/commit/b03d66c5016f3821fbf0990e045b71b59ec9a759 8282452: Use of Preview API in preview methods should not trigger preview warning for the enclosing class Reviewed-by: jlaskey ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java ! test/langtools/jdk/javadoc/doclet/testPreview/TestPreview.java + test/langtools/jdk/javadoc/doclet/testPreview/api/preview/NoPreview.java Changeset: 8fec7b87 Author: Jorn Vernee Date: 2022-03-01 16:26:19 +0000 URL: https://git.openjdk.java.net/loom/commit/8fec7b87c1bc762f9c8ef41cd715d5aaab4c0324 8281548: Add escape analysis tracing flag Reviewed-by: kvn, thartmann, xliu ! src/hotspot/share/compiler/compilerDirectives.hpp ! src/hotspot/share/compiler/compilerOracle.hpp ! src/hotspot/share/opto/escape.cpp ! src/hotspot/share/opto/escape.hpp Changeset: 941e97c4 Author: Manukumar V S Committer: Alexey Ivanov Date: 2022-03-01 16:55:22 +0000 URL: https://git.openjdk.java.net/loom/commit/941e97c4eb186bc63386d17f458ba69f4bddd828 8281738: Create a regression test for checking the 'Space' key activation of focused Button Reviewed-by: aivanov + test/jdk/javax/swing/JButton/4659800/SpaceKeyActivatesButton.java Changeset: b86a8c00 Author: Alexey Ivanov Date: 2022-03-01 17:01:06 +0000 URL: https://git.openjdk.java.net/loom/commit/b86a8c004f4e67e7b6bf45ce7cf96bcd8520a881 8282150: Drop redundant
elements from tables in java.desktop HTML files Reviewed-by: jdv, dmarkov ! src/java.desktop/share/classes/java/awt/doc-files/Modality.html ! src/java.desktop/share/classes/javax/swing/plaf/synth/doc-files/componentProperties.html Changeset: eac80214 Author: Xue-Lei Andrew Fan Date: 2022-03-01 18:10:39 +0000 URL: https://git.openjdk.java.net/loom/commit/eac80214aea4f5c148e859b4b163fe42e89596cd 8282320: Remove case conversion for debugging log in SSLCipher Reviewed-by: weijun ! src/java.base/share/classes/sun/security/ssl/SSLCipher.java Changeset: 732d891f Author: Joe Darcy Date: 2022-03-01 18:48:43 +0000 URL: https://git.openjdk.java.net/loom/commit/732d891f9f8987edfc188c049eb19de6ba790c42 8282411: Add useful predicates to ElementKind Reviewed-by: prappo ! src/java.compiler/share/classes/javax/lang/model/element/ElementKind.java ! test/langtools/tools/javac/processing/model/element/TestElementKindPredicates.java Changeset: fc52a218 Author: Quan Anh Mai Committer: Paul Sandoz Date: 2022-03-02 00:46:35 +0000 URL: https://git.openjdk.java.net/loom/commit/fc52a2182a9debc04b2ac302801b3d61989f54ec 8282143: Objects.requireNonNull should be ForceInline Reviewed-by: psandoz ! src/java.base/share/classes/java/util/Objects.java Changeset: ed3496e6 Author: Christian Hagedorn Date: 2022-03-02 08:57:55 +0000 URL: https://git.openjdk.java.net/loom/commit/ed3496e6c030b6b0a3745bf8ef281075afa1cd27 8282480: IGV: Use description instead of enum name for phases Reviewed-by: redestad, thartmann ! src/hotspot/share/opto/compile.cpp Changeset: 12a822a2 Author: Albert Mingkun Yang Date: 2022-03-02 09:12:20 +0000 URL: https://git.openjdk.java.net/loom/commit/12a822a2875568f4ffd683e8ad9451ebee03ee7e 8282381: Parallel: Remove unnecessary PCReferenceProcessor Reviewed-by: kbarrett, tschatzl ! src/hotspot/share/gc/parallel/psParallelCompact.cpp Changeset: f12200cd Author: Alex Menkov Date: 2022-03-02 10:54:25 +0000 URL: https://git.openjdk.java.net/loom/commit/f12200cd11c2b689618cde1902db941ee23fbf80 8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError Reviewed-by: kevinw, cjplummer ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002.java ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/hs201t002.cpp ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/newclass/hs201t002a.java Changeset: d80f6971 Author: Andrey Turbanov Date: 2022-03-02 13:05:12 +0000 URL: https://git.openjdk.java.net/loom/commit/d80f69718233c484e3c1536ffb793116c1adc058 8282523: Fix 'hierachy' typo Reviewed-by: jiefu, kbarrett, dholmes ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/utilities/exceptions.hpp ! test/hotspot/jtreg/runtime/exceptionMsgs/AbstractMethodError/AbstractMethodErrorTest.java ! test/hotspot/jtreg/runtime/exceptionMsgs/IncompatibleClassChangeError/IncompatibleClassChangeErrorTest.java ! test/hotspot/jtreg/runtime/exceptionMsgs/methodPrinting/TestPrintingMethods.java Changeset: fc918a73 Author: Weijun Wang Date: 2022-03-02 14:07:26 +0000 URL: https://git.openjdk.java.net/loom/commit/fc918a73d0dcc28146e60f15e978209424a32576 8281234: The -protected option is not always checked in keytool and jarsigner Reviewed-by: hchao, mullan ! src/java.base/share/classes/sun/security/tools/keytool/Main.java ! src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java + test/jdk/sun/security/tools/jarsigner/AutoKeyStore.java ! test/lib/jdk/test/lib/SecurityTools.java Changeset: 234c17e8 Author: Calvin Cheung Date: 2022-03-02 16:17:21 +0000 URL: https://git.openjdk.java.net/loom/commit/234c17e8ff7b9b9713e9fded693381f985d34d2a 8274788: Support archived heap objects in ParallelGC Reviewed-by: iklam, ayang, tschatzl ! src/hotspot/share/cds/filemap.cpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp ! src/hotspot/share/gc/parallel/psOldGen.cpp ! src/hotspot/share/gc/parallel/psOldGen.hpp ! test/hotspot/jtreg/TEST.groups + test/hotspot/jtreg/runtime/cds/appcds/TestParallelGCWithCDS.java Changeset: ce18ff85 Author: Devin Smith Committer: Jim Laskey Date: 2022-03-02 16:41:13 +0000 URL: https://git.openjdk.java.net/loom/commit/ce18ff8527cc51805bf11c50c050ea64c3f9dec0 8282551: Properly initialize L32X64MixRandom state Reviewed-by: jlaskey ! src/jdk.random/share/classes/jdk/random/L32X64MixRandom.java Changeset: 39d8aea8 Author: Ron Pressler Date: 2022-03-05 13:07:50 +0000 URL: https://git.openjdk.java.net/loom/commit/39d8aea82ae9aa2930fa76d7835f84c45bd46653 Merge jdk-19+12 ! make/autoconf/spec.gmk.in ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/frame_aarch64.cpp ! src/hotspot/cpu/aarch64/frame_aarch64.inline.hpp ! src/hotspot/cpu/aarch64/gc/g1/g1BarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp ! src/hotspot/os/windows/os_windows.cpp ! src/hotspot/share/cds/heapShared.cpp ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/classfile/vmClassMacros.hpp ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/code/codeCache.cpp ! src/hotspot/share/compiler/compilerOracle.hpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/shared/barrierSetNMethod.cpp ! src/hotspot/share/jfr/jni/jfrJavaSupport.cpp ! src/hotspot/share/jfr/jni/jfrJavaSupport.hpp ! src/hotspot/share/jvmci/vmStructs_jvmci.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/klass.hpp ! src/hotspot/share/oops/method.cpp ! src/hotspot/share/oops/method.hpp ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/runtime.cpp ! src/hotspot/share/prims/forte.cpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/arguments.hpp ! src/hotspot/share/runtime/frame.cpp ! src/hotspot/share/runtime/sharedRuntime.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/utilities/debug.cpp ! src/hotspot/share/utilities/macros.hpp ! src/java.base/share/classes/java/util/jar/JarFile.java ! test/hotspot/jtreg/TEST.groups ! test/jdk/ProblemList.txt ! test/jdk/java/lang/ProcessBuilder/Basic.java ! make/autoconf/spec.gmk.in ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/frame_aarch64.cpp ! src/hotspot/cpu/aarch64/frame_aarch64.inline.hpp ! src/hotspot/cpu/aarch64/gc/g1/g1BarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp ! src/hotspot/os/windows/os_windows.cpp ! src/hotspot/share/cds/heapShared.cpp ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/classfile/vmClassMacros.hpp ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/code/codeCache.cpp ! src/hotspot/share/compiler/compilerOracle.hpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/shared/barrierSetNMethod.cpp ! src/hotspot/share/jfr/jni/jfrJavaSupport.cpp ! src/hotspot/share/jfr/jni/jfrJavaSupport.hpp ! src/hotspot/share/jvmci/vmStructs_jvmci.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/klass.hpp ! src/hotspot/share/oops/method.cpp ! src/hotspot/share/oops/method.hpp ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/runtime.cpp ! src/hotspot/share/prims/forte.cpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/arguments.hpp ! src/hotspot/share/runtime/frame.cpp ! src/hotspot/share/runtime/sharedRuntime.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/utilities/debug.cpp ! src/hotspot/share/utilities/macros.hpp ! src/java.base/share/classes/java/util/jar/JarFile.java ! test/hotspot/jtreg/TEST.groups ! test/jdk/ProblemList.txt ! test/jdk/java/lang/ProcessBuilder/Basic.java Changeset: 23abc48b Author: Ron Pressler Date: 2022-03-05 13:41:25 +0000 URL: https://git.openjdk.java.net/loom/commit/23abc48b27125db75186bb3d9c3a7a6334c287c2 Merge remote-tracking branch 'origin/fibers' into fibers ! src/hotspot/share/classfile/vmClassMacros.hpp ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/classfile/vmClassMacros.hpp ! src/hotspot/share/classfile/vmSymbols.hpp From duke at openjdk.java.net Sat Mar 5 13:52:04 2022 From: duke at openjdk.java.net (duke) Date: Sat, 5 Mar 2022 13:52:04 GMT Subject: git: openjdk/loom: master: 74 new changesets Message-ID: Changeset: 35076af1 Author: Pavel Rappo Date: 2022-02-23 16:17:23 +0000 URL: https://git.openjdk.java.net/loom/commit/35076af13acd1b9327d35ac67dc80c15bb1059c7 8281376: Consider polymorphic methods when looking for overrides Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/WorkArounds.java ! test/langtools/jdk/javadoc/doclet/testOverriddenMethods/TestOverrideMethods.java + test/langtools/jdk/javadoc/doclet/testOverriddenMethods/pkg8/C.java + test/langtools/jdk/javadoc/doclet/testOverriddenMethods/pkg8/GP.java + test/langtools/jdk/javadoc/doclet/testOverriddenMethods/pkg8/P.java Changeset: 99b8ed9d Author: Jonathan Gibbons Date: 2022-02-23 16:49:28 +0000 URL: https://git.openjdk.java.net/loom/commit/99b8ed9dbf88e21a42a8d2f6249bfab7176e7d42 8281217: Source file launch with security manager enabled fails Reviewed-by: sundar ! src/jdk.compiler/share/classes/com/sun/tools/javac/launcher/Main.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/launcher.properties ! test/langtools/tools/javac/launcher/SourceLauncherTest.java Changeset: a020b6ba Author: Lance Andersen Date: 2022-02-23 16:56:50 +0000 URL: https://git.openjdk.java.net/loom/commit/a020b6ba8f38fe85fb26972a51e4c1068408b1c1 8280409: JarFile::getInputStream can fail with NPE accessing ze.getName() Reviewed-by: mullan, alanb ! src/java.base/share/classes/java/util/jar/JarFile.java ! src/java.base/share/classes/java/util/zip/ZipFile.java + test/jdk/java/util/zip/ZipFile/GetInputStreamNPETest.java Changeset: 7dc7184c Author: Xue-Lei Andrew Fan Date: 2022-02-23 18:32:29 +0000 URL: https://git.openjdk.java.net/loom/commit/7dc7184c10fc8f7a02113056da979a9846a14cd4 8282309: Operation before upper case conversion Reviewed-by: valeriep, wetmore ! src/java.base/share/classes/sun/security/util/TlsChannelBinding.java Changeset: e540e0a8 Author: Michael McMahon Date: 2022-02-23 20:02:11 +0000 URL: https://git.openjdk.java.net/loom/commit/e540e0a81b923cce8b2f2689e01703509a4df1de 8282296: (se) Pipe.open() creates a Pipe implementation that uses Unix domain sockets (win) Reviewed-by: dfuchs, lancea, bpb ! src/java.base/windows/classes/sun/nio/ch/PipeImpl.java Changeset: f86f38a8 Author: Vladimir Ivanov Date: 2022-02-23 20:29:23 +0000 URL: https://git.openjdk.java.net/loom/commit/f86f38a8afd31c76039206f8f1f33371ad814396 8280901: MethodHandle::linkToNative stub is missing w/ -Xint Reviewed-by: shade, kvn ! src/hotspot/share/classfile/systemDictionary.cpp ! test/jdk/java/foreign/TestDowncall.java Changeset: 253cf785 Author: Chris Plummer Date: 2022-02-23 21:09:41 +0000 URL: https://git.openjdk.java.net/loom/commit/253cf7852f60ecf92e6d675ae2469e5f27425609 8282076: Merge some debug agent changes from the loom repo Reviewed-by: amenkov, lmesnik ! src/jdk.jdwp.agent/share/native/libjdwp/eventHandler.c ! src/jdk.jdwp.agent/share/native/libjdwp/stepControl.c ! src/jdk.jdwp.agent/share/native/libjdwp/threadControl.c Changeset: 43dc9ef6 Author: Manukumar V S Committer: Alexey Ivanov Date: 2022-02-23 21:13:23 +0000 URL: https://git.openjdk.java.net/loom/commit/43dc9ef619b823e033cb1e298bbc091eb5a50967 8281988: Create a regression test for JDK-4618767 Reviewed-by: aivanov + test/jdk/javax/swing/JList/4618767/JListSelectedElementTest.java Changeset: a6610031 Author: Chris Plummer Date: 2022-02-23 22:55:39 +0000 URL: https://git.openjdk.java.net/loom/commit/a6610031e2816156fa14876457e260282a88d478 8281614: serviceability/sa/ClhsdbFindPC.java fails with java.lang.RuntimeException: 'In code in NMethod for jdk/test/lib/apps/LingeredApp.steadyState' missing from stdout/stderr Reviewed-by: dcubed, dholmes ! test/hotspot/jtreg/serviceability/sa/ClhsdbFindPC.java Changeset: cd3e59ef Author: Albert Mingkun Yang Date: 2022-02-24 09:16:04 +0000 URL: https://git.openjdk.java.net/loom/commit/cd3e59ef88bcc040f9d671c8c15370efaae3ffd8 8282299: Remove unused PartialArrayScanTask default constructor Reviewed-by: tschatzl ! src/hotspot/share/gc/shared/taskqueue.hpp Changeset: 379fd859 Author: Prasanta Sadhukhan Date: 2022-02-24 09:52:17 +0000 URL: https://git.openjdk.java.net/loom/commit/379fd85932e4b82e9a8e85f8ed8e63202f3cb9bc 8277369: Strange behavior of JMenuBar with RIGHT_TO_LEFT orientation, arrow keys behaves opposite traversing through keyboard Reviewed-by: prr, naoto, serb ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicPopupMenuUI.java + test/jdk/javax/swing/JMenuBar/MenuBarRTLBug.java Changeset: 3cfffa4f Author: Andrey Turbanov Date: 2022-02-24 11:03:29 +0000 URL: https://git.openjdk.java.net/loom/commit/3cfffa4f8e5a0fff7f232130125c549f992b533b 8282188: Unused static field MathContext.DEFAULT_DIGITS Reviewed-by: darcy, bpb ! src/java.base/share/classes/java/math/MathContext.java Changeset: f4486a19 Author: Coleen Phillimore Date: 2022-02-24 12:59:15 +0000 URL: https://git.openjdk.java.net/loom/commit/f4486a190e38c57b7c10e6cff4622bd1b716a724 8262400: runtime/exceptionMsgs/AbstractMethodError/AbstractMethodErrorTest.java fails in test_ame5_compiled_vtable_stub with wrapper Reviewed-by: dholmes, lmesnik ! test/hotspot/jtreg/runtime/exceptionMsgs/AbstractMethodError/AbstractMethodErrorTest.java Changeset: 231e48fa Author: Johannes Bechberger Committer: Martin Doerr Date: 2022-02-24 14:32:22 +0000 URL: https://git.openjdk.java.net/loom/commit/231e48fa63aeb4e35c7c948f958695d62b7157ce 8282200: ShouldNotReachHere() reached by AsyncGetCallTrace after JDK-8280422 Reviewed-by: dholmes, mdoerr, kevinw ! src/hotspot/share/prims/forte.cpp ! src/hotspot/share/runtime/thread.hpp Changeset: 0796620b Author: Jonathan Gibbons Date: 2022-02-24 14:50:06 +0000 URL: https://git.openjdk.java.net/loom/commit/0796620b07c6287a130ab0a3a7279d69b5d7b8a1 8281944: JavaDoc throws java.lang.IllegalStateException: ERRONEOUS Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java ! test/langtools/jdk/javadoc/doclet/testSeeTag/TestSeeTag.java Changeset: abc0ce11 Author: Xue-Lei Andrew Fan Date: 2022-02-24 16:25:47 +0000 URL: https://git.openjdk.java.net/loom/commit/abc0ce11dfa0a751a12925763cb168d1d3b4f44a 8282316: Operation before String case conversion Reviewed-by: valeriep ! src/java.base/share/classes/sun/security/util/SignatureUtil.java Changeset: 6fab8a2d Author: Alan Hayward Committer: Andrew Dinn Date: 2022-02-24 16:38:56 +0000 URL: https://git.openjdk.java.net/loom/commit/6fab8a2d6a97dbd2ffceca275716d020cb9f1eea 8277204: Implement PAC-RET branch protection on Linux/AArch64 Reviewed-by: erikj, ihse, adinn, ngasson ! doc/building.md ! make/autoconf/flags-cflags.m4 ! make/autoconf/spec.gmk.in ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/assembler_aarch64.hpp ! src/hotspot/cpu/aarch64/c1_Runtime1_aarch64.cpp ! src/hotspot/cpu/aarch64/frame_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/g1/g1BarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/z/zBarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/globals_aarch64.hpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/pauth_aarch64.hpp ! src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp ! src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp ! src/hotspot/cpu/aarch64/vm_version_aarch64.cpp ! src/hotspot/cpu/aarch64/vm_version_aarch64.hpp ! src/hotspot/os_cpu/bsd_aarch64/pauth_bsd_aarch64.inline.hpp ! src/hotspot/os_cpu/linux_aarch64/pauth_linux_aarch64.inline.hpp ! src/hotspot/os_cpu/linux_aarch64/threadLS_linux_aarch64.S ! src/hotspot/os_cpu/linux_aarch64/vm_version_linux_aarch64.cpp ! src/hotspot/os_cpu/windows_aarch64/pauth_windows_aarch64.inline.hpp ! src/hotspot/share/gc/shared/barrierSetNMethod.cpp ! src/hotspot/share/jvmci/vmStructs_jvmci.cpp ! src/hotspot/share/opto/runtime.cpp ! src/hotspot/share/runtime/frame.cpp ! src/hotspot/share/runtime/sharedRuntime.cpp ! src/java.base/share/man/java.1 ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.aarch64/src/jdk/vm/ci/aarch64/AArch64.java ! test/hotspot/gtest/aarch64/aarch64-asmtest.py ! test/hotspot/gtest/aarch64/asmtest.out.h ! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/CodeInstallationTest.java ! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/TestHotSpotVMConfig.java ! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/aarch64/AArch64TestAssembler.java Changeset: 0b6862e8 Author: Albert Mingkun Yang Date: 2022-02-24 17:47:30 +0000 URL: https://git.openjdk.java.net/loom/commit/0b6862e803a03cf7f722f4f58b657712e74723fb 8282348: Remove unused CardTable::dirty_card_iterate Reviewed-by: kbarrett ! src/hotspot/share/gc/shared/cardTable.cpp ! src/hotspot/share/gc/shared/cardTable.hpp Changeset: 20e78f7a Author: Albert Mingkun Yang Date: 2022-02-24 17:48:20 +0000 URL: https://git.openjdk.java.net/loom/commit/20e78f7a8e2e589bc4fb7f0c928176048bd9172a 8282307: Parallel: Incorrect discovery mode in PCReferenceProcessor Reviewed-by: tschatzl, kbarrett ! src/hotspot/share/gc/parallel/psParallelCompact.cpp Changeset: 23995f82 Author: Daniel Jeli?ski Committer: Daniel Fuchs Date: 2022-02-24 18:18:52 +0000 URL: https://git.openjdk.java.net/loom/commit/23995f822e540d799eb4bbc969229422257fbb08 8281525: Enable Zc:strictStrings flag in Visual Studio build Reviewed-by: dholmes, ihse ! make/autoconf/flags-cflags.m4 ! src/hotspot/os/windows/os_windows.cpp ! src/java.security.jgss/windows/native/libsspi_bridge/sspi.cpp ! src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp ! src/jdk.jpackage/windows/native/libwixhelper/libwixhelper.cpp ! test/hotspot/gtest/runtime/test_os_windows.cpp Changeset: b6843a16 Author: Yi-Fan Tsai Committer: Paul Hohensee Date: 2022-02-24 19:42:16 +0000 URL: https://git.openjdk.java.net/loom/commit/b6843a162411b0fa32271592d8f3a6f241a54384 8005885: enhance PrintCodeCache to print more data Reviewed-by: xliu, phh ! src/hotspot/share/code/codeCache.cpp + test/hotspot/jtreg/compiler/codecache/CheckCodeCacheInfo.java Changeset: bf19fc65 Author: Roger Riggs Date: 2022-02-24 20:12:48 +0000 URL: https://git.openjdk.java.net/loom/commit/bf19fc65c71cba8cb4383d714fe8993acd01be0a 8280357: user.home = "?" when running with systemd DynamicUser=true Reviewed-by: naoto, alanb ! src/java.base/unix/native/libjava/java_props_md.c Changeset: cd36be42 Author: Kevin Walls Date: 2022-02-25 07:56:56 +0000 URL: https://git.openjdk.java.net/loom/commit/cd36be42c2eb3eacdb3625e87510eb15acac3230 8206187: javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java fails with Port already in use Reviewed-by: msheppar, amenkov ! test/jdk/javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java Changeset: 3efd6aa4 Author: Claes Redestad Date: 2022-02-25 08:55:46 +0000 URL: https://git.openjdk.java.net/loom/commit/3efd6aa4c9b6420520709281ab1ca46ba4242c87 8282347: AARCH64: Untaken branch in has_negatives stub Reviewed-by: aph, haosun, thartmann ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp Changeset: 9471f24c Author: KIRIYAMA Takuya Committer: Markus Gr?nlund Date: 2022-02-25 11:39:11 +0000 URL: https://git.openjdk.java.net/loom/commit/9471f24ca191832669a13e5a1ea73f7097a25927 8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device. Reviewed-by: mgronlun ! src/hotspot/share/jfr/jni/jfrJavaSupport.cpp ! src/hotspot/share/jfr/jni/jfrJavaSupport.hpp ! src/hotspot/share/jfr/writers/jfrStreamWriterHost.inline.hpp Changeset: b96b7437 Author: Thomas Stuefe Date: 2022-02-25 12:25:46 +0000 URL: https://git.openjdk.java.net/loom/commit/b96b743727a628c1b33cc9b3374f010c2ea30b78 8281015: Further simplify NMT backend Reviewed-by: zgu, mbaesken ! src/hotspot/share/runtime/os.cpp ! src/hotspot/share/services/mallocSiteTable.cpp ! src/hotspot/share/services/mallocSiteTable.hpp ! src/hotspot/share/services/mallocTracker.cpp ! src/hotspot/share/services/mallocTracker.hpp - src/hotspot/share/services/mallocTracker.inline.hpp ! src/hotspot/share/services/memTracker.cpp ! src/hotspot/share/services/memTracker.hpp ! src/hotspot/share/services/nmtCommon.hpp ! src/hotspot/share/utilities/debug.cpp Changeset: 735e86b0 Author: Matthias Baesken Date: 2022-02-25 12:26:44 +0000 URL: https://git.openjdk.java.net/loom/commit/735e86b0f71c97c2ba35c1cffd9b4492a8ca55bc 8282345: handle latest VS2022 in abstract_vm_version Reviewed-by: dholmes, mdoerr ! src/hotspot/share/runtime/abstract_vm_version.cpp Changeset: e96c599e Author: Erik Gahlin Date: 2022-02-25 12:56:09 +0000 URL: https://git.openjdk.java.net/loom/commit/e96c599ed2a30ea116803aac0e85ba701ad40e25 8271232: JFR: Scrub recording data Reviewed-by: mgronlun ! src/jdk.jfr/share/classes/jdk/jfr/consumer/RecordingFile.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/ChunkHeader.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/ChunkParser.java + src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/CompositeParser.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/ConstantLookup.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/ConstantMap.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/Dispatcher.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/EventParser.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/Parser.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/ParserFactory.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/ParserFilter.java + src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/Reference.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/StringParser.java + src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/filter/CheckPointEvent.java + src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/filter/CheckPointPool.java + src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/filter/ChunkWriter.java + src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/filter/Constants.java + src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/filter/PoolEntry.java + src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/filter/RecordingOutput.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/tool/Command.java + src/jdk.jfr/share/classes/jdk/jfr/internal/tool/Filters.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/tool/Main.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/tool/Metadata.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/tool/Print.java + src/jdk.jfr/share/classes/jdk/jfr/internal/tool/Scrub.java + test/jdk/jdk/jfr/api/consumer/TestRecordingFileSanitization.java + test/jdk/jdk/jfr/api/consumer/TestRecordingFileWrite.java + test/jdk/jdk/jfr/tool/TestScrub.java Changeset: 441e4850 Author: Erik Gahlin Date: 2022-02-25 18:36:11 +0000 URL: https://git.openjdk.java.net/loom/commit/441e48509c1ba88db942737715026404b4fe0767 8281739: JFR: Use message with Objects.requireNonNull Reviewed-by: mgronlun ! src/jdk.jfr/share/classes/jdk/jfr/AnnotationElement.java ! src/jdk.jfr/share/classes/jdk/jfr/Configuration.java ! src/jdk.jfr/share/classes/jdk/jfr/EventFactory.java ! src/jdk.jfr/share/classes/jdk/jfr/EventSettings.java ! src/jdk.jfr/share/classes/jdk/jfr/EventType.java ! src/jdk.jfr/share/classes/jdk/jfr/FlightRecorder.java ! src/jdk.jfr/share/classes/jdk/jfr/FlightRecorderPermission.java ! src/jdk.jfr/share/classes/jdk/jfr/Recording.java ! src/jdk.jfr/share/classes/jdk/jfr/ValueDescriptor.java ! src/jdk.jfr/share/classes/jdk/jfr/consumer/EventStream.java ! src/jdk.jfr/share/classes/jdk/jfr/consumer/RecordedObject.java ! src/jdk.jfr/share/classes/jdk/jfr/consumer/RecordingFile.java ! src/jdk.jfr/share/classes/jdk/jfr/consumer/RecordingStream.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/AbstractEventStream.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/EventFileStream.java ! src/jdk.management.jfr/share/classes/jdk/management/jfr/FlightRecorderMXBeanImpl.java Changeset: fb8bf818 Author: Alexander Matveev Date: 2022-02-25 20:49:59 +0000 URL: https://git.openjdk.java.net/loom/commit/fb8bf81842b55355f226ac9d8717646abd509721 8279995: jpackage --add-launcher option should allow overriding description Reviewed-by: asemenyuk ! src/jdk.jpackage/share/classes/jdk/jpackage/internal/AddLauncherArguments.java ! src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties ! src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources_ja.properties ! src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources_zh_CN.properties ! test/jdk/tools/jpackage/helpers/jdk/jpackage/test/AdditionalLauncher.java ! test/jdk/tools/jpackage/helpers/jdk/jpackage/test/WindowsHelper.java ! test/jdk/tools/jpackage/share/AddLauncherTest.java Changeset: c5c6058f Author: Ichiroh Takiguchi Date: 2022-02-26 03:33:29 +0000 URL: https://git.openjdk.java.net/loom/commit/c5c6058fd57d4b594012035eaf18a57257f4ad85 8282219: jdk/java/lang/ProcessBuilder/Basic.java fails on AIX Reviewed-by: rriggs ! test/jdk/java/lang/ProcessBuilder/Basic.java Changeset: cf6d2565 Author: Erik Gahlin Date: 2022-02-26 08:57:23 +0000 URL: https://git.openjdk.java.net/loom/commit/cf6d2565e93ac13fd03f01a0624530d6750d02c3 8282153: JFR: Check for recording waste Reviewed-by: mgronlun + test/jdk/jdk/jfr/jvm/TestWaste.java Changeset: afd4bcbc Author: Rajan Halade Date: 2022-02-26 17:10:08 +0000 URL: https://git.openjdk.java.net/loom/commit/afd4bcbc1d1b2a8a1c29005878c8e06c662a1f6e 8282398: EndingDotHostname.java test fails because SSL cert expired Reviewed-by: xuelei ! test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java ! test/jdk/javax/net/ssl/templates/SSLExampleCert.java Changeset: 630ad1ac Author: Daniel D. Daugherty Date: 2022-02-27 03:45:49 +0000 URL: https://git.openjdk.java.net/loom/commit/630ad1acb20abae8bde037b8d23dd2a14a70d732 8282428: ProblemList jdk/jfr/jvm/TestWaste.java Reviewed-by: mikael ! test/jdk/ProblemList.txt Changeset: 86723d48 Author: Aleksey Shipilev Date: 2022-02-28 07:35:19 +0000 URL: https://git.openjdk.java.net/loom/commit/86723d4892485651bcae735ed13545ea89b9bb22 8281507: Two javac tests have bad jtreg `@clean` tags Reviewed-by: darcy ! test/langtools/tools/javac/8074306/TestSyntheticNullChecks.java ! test/langtools/tools/javac/StringConcat/TestIndyStringConcat.java Changeset: efd3967b Author: John Tortugo Committer: Christian Hagedorn Date: 2022-02-28 10:01:24 +0000 URL: https://git.openjdk.java.net/loom/commit/efd3967b54fed7eaa3c3072267f766d73a3acadb 8267265: Use new IR Test Framework to create tests for C2 Ideal transformations Reviewed-by: chagedorn + test/hotspot/jtreg/compiler/c2/irTests/AddINodeIdealizationTests.java + test/hotspot/jtreg/compiler/c2/irTests/AddLNodeIdealizationTests.java + test/hotspot/jtreg/compiler/c2/irTests/DivINodeIdealizationTests.java + test/hotspot/jtreg/compiler/c2/irTests/DivLNodeIdealizationTests.java + test/hotspot/jtreg/compiler/c2/irTests/MulINodeIdealizationTests.java + test/hotspot/jtreg/compiler/c2/irTests/MulLNodeIdealizationTests.java + test/hotspot/jtreg/compiler/c2/irTests/SubINodeIdealizationTests.java + test/hotspot/jtreg/compiler/c2/irTests/SubLNodeIdealizationTests.java + test/hotspot/jtreg/compiler/c2/irTests/loopOpts/LoopIdealizationTests.java + test/hotspot/jtreg/compiler/c2/irTests/scalarReplacement/ScalarReplacementTests.java ! test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java Changeset: 06cadb36 Author: Emanuel Peter Committer: Tobias Hartmann Date: 2022-02-28 12:13:35 +0000 URL: https://git.openjdk.java.net/loom/commit/06cadb36e05a86a528c8f3bc64c1a42b47ca94a0 8230382: Clean up ConvI2L, CastII and CastLL::Ideal methods Reviewed-by: thartmann, roland ! src/hotspot/share/opto/castnode.cpp ! src/hotspot/share/opto/convertnode.cpp Changeset: c58f5c67 Author: Harold Seigel Date: 2022-02-28 13:18:45 +0000 URL: https://git.openjdk.java.net/loom/commit/c58f5c67d1720d310c720667f7bf7486740c21c1 8282360: Merge POSIX implementations of ThreadCritical Reviewed-by: stuefe, coleenp, dholmes - src/hotspot/os/bsd/threadCritical_bsd.cpp - src/hotspot/os/linux/threadCritical_linux.cpp = src/hotspot/os/posix/threadCritical_posix.cpp Changeset: 0ae3d1d5 Author: Naoto Sato Date: 2022-02-28 13:22:15 +0000 URL: https://git.openjdk.java.net/loom/commit/0ae3d1d59c44e966e13345b9197fcf067e63900e 8282131: java.time.ZoneId should be a sealed abstract class Reviewed-by: iris, rriggs, bpb, lancea, mchung, scolebourne ! src/java.base/share/classes/java/time/ZoneId.java Changeset: 4e7fb41d Author: Aleksey Shipilev Date: 2022-02-28 13:29:23 +0000 URL: https://git.openjdk.java.net/loom/commit/4e7fb41dafaf03baabe18ee1dabefed50d69e16d 8282172: CompileBroker::log_metaspace_failure is called from non-Java/compiler threads Reviewed-by: kvn, thartmann ! src/hotspot/share/compiler/compileBroker.cpp Changeset: 59b3ecc5 Author: Weijun Wang Date: 2022-02-28 17:00:47 +0000 URL: https://git.openjdk.java.net/loom/commit/59b3ecc591ef6407d6b3f5532ecf889bf61339f0 8277976: Break up SEQUENCE in X509Certificate::getSubjectAlternativeNames and X509Certificate::getIssuerAlternativeNames in otherName 6776681: Invalid encoding of an OtherName in X509Certificate.getAlternativeNames() Reviewed-by: mullan ! src/java.base/share/classes/java/security/cert/X509Certificate.java ! src/java.base/share/classes/sun/security/x509/OtherName.java ! src/java.base/share/classes/sun/security/x509/X509CertImpl.java + test/jdk/sun/security/x509/OtherName/Parse.java Changeset: c7cd1487 Author: Coleen Phillimore Date: 2022-02-28 20:31:41 +0000 URL: https://git.openjdk.java.net/loom/commit/c7cd1487fe00172be59e7571991f960c59b8c0eb 8282240: Add _name field to Method for NOT_PRODUCT only Reviewed-by: pchilanomate, hseigel ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/defaultMethods.cpp ! src/hotspot/share/oops/method.cpp ! src/hotspot/share/oops/method.hpp ! test/hotspot/gtest/oops/test_instanceKlass.cpp Changeset: d983d108 Author: Ioi Lam Date: 2022-02-28 20:33:18 +0000 URL: https://git.openjdk.java.net/loom/commit/d983d108c565654e717e2811d88aa94d982da2f5 8275731: CDS archived enums objects are recreated at runtime Reviewed-by: coleenp, ccheung + src/hotspot/share/cds/cdsHeapVerifier.cpp + src/hotspot/share/cds/cdsHeapVerifier.hpp ! src/hotspot/share/cds/dumpTimeClassInfo.cpp ! src/hotspot/share/cds/dumpTimeClassInfo.hpp ! src/hotspot/share/cds/heapShared.cpp ! src/hotspot/share/cds/heapShared.hpp ! src/hotspot/share/cds/runTimeClassInfo.cpp ! src/hotspot/share/cds/runTimeClassInfo.hpp ! src/hotspot/share/classfile/systemDictionaryShared.cpp ! src/hotspot/share/classfile/systemDictionaryShared.hpp ! src/hotspot/share/classfile/vmClassMacros.hpp ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/klass.hpp + test/hotspot/jtreg/runtime/cds/appcds/cacheObject/ArchivedEnumApp.java + test/hotspot/jtreg/runtime/cds/appcds/cacheObject/ArchivedEnumTest.java Changeset: 9d9618a3 Author: Joe Darcy Date: 2022-02-28 22:14:14 +0000 URL: https://git.openjdk.java.net/loom/commit/9d9618a3dd29cb9328a7275375e04eca2af20a93 8282462: Remove unnecessary use of @SuppressWarnings("preview") Reviewed-by: vromero ! src/java.compiler/share/classes/javax/lang/model/element/ElementKind.java ! src/java.compiler/share/classes/javax/lang/model/util/AbstractElementVisitor6.java ! src/java.compiler/share/classes/javax/lang/model/util/ElementFilter.java ! src/java.compiler/share/classes/javax/lang/model/util/ElementKindVisitor6.java Changeset: 1f89acd8 Author: Joe Darcy Date: 2022-02-28 23:28:21 +0000 URL: https://git.openjdk.java.net/loom/commit/1f89acd8498945e1d531b7845748bcee8194115b 8282464: Remove author tags from java.compiler Reviewed-by: jjg ! src/java.compiler/share/classes/javax/annotation/processing/AbstractProcessor.java ! src/java.compiler/share/classes/javax/annotation/processing/Completion.java ! src/java.compiler/share/classes/javax/annotation/processing/Completions.java ! src/java.compiler/share/classes/javax/annotation/processing/Filer.java ! src/java.compiler/share/classes/javax/annotation/processing/FilerException.java ! src/java.compiler/share/classes/javax/annotation/processing/Messager.java ! src/java.compiler/share/classes/javax/annotation/processing/ProcessingEnvironment.java ! src/java.compiler/share/classes/javax/annotation/processing/Processor.java ! src/java.compiler/share/classes/javax/annotation/processing/RoundEnvironment.java ! src/java.compiler/share/classes/javax/annotation/processing/SupportedAnnotationTypes.java ! src/java.compiler/share/classes/javax/annotation/processing/SupportedOptions.java ! src/java.compiler/share/classes/javax/annotation/processing/SupportedSourceVersion.java ! src/java.compiler/share/classes/javax/annotation/processing/package-info.java ! src/java.compiler/share/classes/javax/lang/model/SourceVersion.java ! src/java.compiler/share/classes/javax/lang/model/UnknownEntityException.java ! src/java.compiler/share/classes/javax/lang/model/element/AnnotationMirror.java ! src/java.compiler/share/classes/javax/lang/model/element/AnnotationValue.java ! src/java.compiler/share/classes/javax/lang/model/element/AnnotationValueVisitor.java ! src/java.compiler/share/classes/javax/lang/model/element/Element.java ! src/java.compiler/share/classes/javax/lang/model/element/ElementKind.java ! src/java.compiler/share/classes/javax/lang/model/element/ElementVisitor.java ! src/java.compiler/share/classes/javax/lang/model/element/ExecutableElement.java ! src/java.compiler/share/classes/javax/lang/model/element/Modifier.java ! src/java.compiler/share/classes/javax/lang/model/element/Name.java ! src/java.compiler/share/classes/javax/lang/model/element/NestingKind.java ! src/java.compiler/share/classes/javax/lang/model/element/PackageElement.java ! src/java.compiler/share/classes/javax/lang/model/element/Parameterizable.java ! src/java.compiler/share/classes/javax/lang/model/element/QualifiedNameable.java ! src/java.compiler/share/classes/javax/lang/model/element/TypeElement.java ! src/java.compiler/share/classes/javax/lang/model/element/TypeParameterElement.java ! src/java.compiler/share/classes/javax/lang/model/element/UnknownAnnotationValueException.java ! src/java.compiler/share/classes/javax/lang/model/element/UnknownDirectiveException.java ! src/java.compiler/share/classes/javax/lang/model/element/UnknownElementException.java ! src/java.compiler/share/classes/javax/lang/model/element/VariableElement.java ! src/java.compiler/share/classes/javax/lang/model/element/package-info.java ! src/java.compiler/share/classes/javax/lang/model/package-info.java ! src/java.compiler/share/classes/javax/lang/model/type/ArrayType.java ! src/java.compiler/share/classes/javax/lang/model/type/DeclaredType.java ! src/java.compiler/share/classes/javax/lang/model/type/ErrorType.java ! src/java.compiler/share/classes/javax/lang/model/type/ExecutableType.java ! src/java.compiler/share/classes/javax/lang/model/type/MirroredTypeException.java ! src/java.compiler/share/classes/javax/lang/model/type/MirroredTypesException.java ! src/java.compiler/share/classes/javax/lang/model/type/NoType.java ! src/java.compiler/share/classes/javax/lang/model/type/NullType.java ! src/java.compiler/share/classes/javax/lang/model/type/PrimitiveType.java ! src/java.compiler/share/classes/javax/lang/model/type/ReferenceType.java ! src/java.compiler/share/classes/javax/lang/model/type/TypeKind.java ! src/java.compiler/share/classes/javax/lang/model/type/TypeMirror.java ! src/java.compiler/share/classes/javax/lang/model/type/TypeVariable.java ! src/java.compiler/share/classes/javax/lang/model/type/TypeVisitor.java ! src/java.compiler/share/classes/javax/lang/model/type/UnknownTypeException.java ! src/java.compiler/share/classes/javax/lang/model/type/WildcardType.java ! src/java.compiler/share/classes/javax/lang/model/type/package-info.java ! src/java.compiler/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor6.java ! src/java.compiler/share/classes/javax/lang/model/util/AbstractElementVisitor6.java ! src/java.compiler/share/classes/javax/lang/model/util/AbstractTypeVisitor6.java ! src/java.compiler/share/classes/javax/lang/model/util/ElementFilter.java ! src/java.compiler/share/classes/javax/lang/model/util/ElementKindVisitor6.java ! src/java.compiler/share/classes/javax/lang/model/util/ElementScanner6.java ! src/java.compiler/share/classes/javax/lang/model/util/Elements.java ! src/java.compiler/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor6.java ! src/java.compiler/share/classes/javax/lang/model/util/SimpleElementVisitor6.java ! src/java.compiler/share/classes/javax/lang/model/util/SimpleTypeVisitor6.java ! src/java.compiler/share/classes/javax/lang/model/util/TypeKindVisitor6.java ! src/java.compiler/share/classes/javax/lang/model/util/Types.java ! src/java.compiler/share/classes/javax/lang/model/util/package-info.java ! src/java.compiler/share/classes/javax/tools/Diagnostic.java ! src/java.compiler/share/classes/javax/tools/DiagnosticCollector.java ! src/java.compiler/share/classes/javax/tools/DiagnosticListener.java ! src/java.compiler/share/classes/javax/tools/FileObject.java ! src/java.compiler/share/classes/javax/tools/ForwardingFileObject.java ! src/java.compiler/share/classes/javax/tools/ForwardingJavaFileManager.java ! src/java.compiler/share/classes/javax/tools/ForwardingJavaFileObject.java ! src/java.compiler/share/classes/javax/tools/JavaCompiler.java ! src/java.compiler/share/classes/javax/tools/JavaFileManager.java ! src/java.compiler/share/classes/javax/tools/JavaFileObject.java ! src/java.compiler/share/classes/javax/tools/OptionChecker.java ! src/java.compiler/share/classes/javax/tools/SimpleJavaFileObject.java ! src/java.compiler/share/classes/javax/tools/StandardJavaFileManager.java ! src/java.compiler/share/classes/javax/tools/StandardLocation.java ! src/java.compiler/share/classes/javax/tools/Tool.java ! src/java.compiler/share/classes/javax/tools/ToolProvider.java ! src/java.compiler/share/classes/javax/tools/package-info.java Changeset: 77432663 Author: David Holmes Date: 2022-03-01 01:17:50 +0000 URL: https://git.openjdk.java.net/loom/commit/77432663be12da7fc44bb0ae0b1c8bf08eb6c249 8281210: Add manpage changes for PAC-RET protection on Linux/AArch64 Reviewed-by: iklam ! src/java.base/share/man/java.1 Changeset: c1a28aa0 Author: Alan Hayward Committer: Ningsheng Jian Date: 2022-03-01 02:23:29 +0000 URL: https://git.openjdk.java.net/loom/commit/c1a28aa04ada6c13031eaa85746e6b1d5945d10d 8282392: [zero] Build broken on AArch64 Reviewed-by: aph, shade ! src/hotspot/share/gc/shared/barrierSetNMethod.cpp ! src/hotspot/share/opto/runtime.cpp ! src/hotspot/share/runtime/frame.cpp ! src/hotspot/share/runtime/sharedRuntime.cpp ! src/hotspot/share/utilities/macros.hpp Changeset: e4d9fc81 Author: Jaikiran Pai Date: 2022-03-01 03:49:18 +0000 URL: https://git.openjdk.java.net/loom/commit/e4d9fc811e0ef0eb9b097e06525a1183445d8d79 8282023: PropertiesStoreTest and StoreReproducibilityTest jtreg failures due to en_CA locale Reviewed-by: naoto, rriggs ! test/jdk/java/util/Properties/PropertiesStoreTest.java ! test/jdk/java/util/Properties/StoreReproducibilityTest.java Changeset: d3022f87 Author: Dean Long Date: 2022-03-01 08:25:31 +0000 URL: https://git.openjdk.java.net/loom/commit/d3022f87b598398d7130e984088ede6ffc9f48e1 8282467: add extra diagnostics for JDK-8268184 Reviewed-by: stuefe ! src/hotspot/share/opto/ifg.cpp Changeset: 22b93a31 Author: Albert Mingkun Yang Date: 2022-03-01 09:32:01 +0000 URL: https://git.openjdk.java.net/loom/commit/22b93a31c99403996b6272b7c8eb0b9918988862 8282094: [REDO] Parallel: Refactor PSCardTable::scavenge_contents_parallel Reviewed-by: iwalulya, tschatzl ! src/hotspot/share/gc/parallel/psCardTable.cpp ! src/hotspot/share/gc/parallel/psCardTable.hpp Changeset: d4d12ad1 Author: Claes Redestad Date: 2022-03-01 10:20:22 +0000 URL: https://git.openjdk.java.net/loom/commit/d4d12ad1d92ae6d353ce9e16b1b72e6416874cd6 8282047: Enhance StringDecode/Encode microbenchmarks Reviewed-by: bchristi ! test/micro/org/openjdk/bench/java/lang/StringDecode.java ! test/micro/org/openjdk/bench/java/lang/StringEncode.java Changeset: 369291b2 Author: Chris Hegarty Date: 2022-03-01 10:37:35 +0000 URL: https://git.openjdk.java.net/loom/commit/369291b265e13d625c5f465da9b1854c0d70c435 8282444: Module finder incorrectly assumes default file system path-separator character Reviewed-by: alanb ! src/java.base/share/classes/jdk/internal/module/ModulePath.java ! test/jdk/java/lang/module/customfs/ModulesInCustomFileSystem.java ! test/jdk/java/lang/module/customfs/m1/p/Main.java ! test/jdk/java/lang/module/customfs/m2/module-info.java = test/jdk/java/lang/module/customfs/m2/q/r/Hello.java Changeset: eff396f3 Author: Pavel Rappo Date: 2022-03-01 12:06:11 +0000 URL: https://git.openjdk.java.net/loom/commit/eff396f397d3c279f9a090adb6ad4e619f24253c 8280713: Related to comment inheritance jdk.javadoc cleanup and refactoring Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/BaseConfiguration.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/BaseOptions.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/WorkArounds.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/ClassBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/ThrowsTaglet.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/UncheckedDocletException.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/VisibleMemberTable.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/links/LinkFactory.java ! test/jdk/java/lang/annotation/UnitTest.java ! test/langtools/jdk/javadoc/doclet/testInterface/TestInterface.java ! test/langtools/jdk/javadoc/doclet/testOverriddenMethods/pkg3/I2.java ! test/langtools/jdk/javadoc/doclet/testOverriddenMethods/pkg3/I3.java ! test/langtools/jdk/javadoc/doclet/testOverriddenMethods/pkg3/I4.java ! test/langtools/jdk/javadoc/doclet/testOverriddenMethods/pkg5/Classes.java ! test/langtools/jdk/javadoc/doclet/testOverriddenMethods/pkg5/Interfaces.java ! test/langtools/jdk/javadoc/doclet/testOverriddenMethods/pkg6/Sub.java ! test/langtools/jdk/javadoc/doclet/testPrivateClasses/TestPrivateClasses.java + test/langtools/jdk/javadoc/doclet/testTagInheritence/TestTagInheritance.java - test/langtools/jdk/javadoc/doclet/testTagInheritence/TestTagInheritence.java = test/langtools/jdk/javadoc/doclet/testTagInheritence/pkg/TestTagInheritance.java = test/langtools/jdk/javadoc/doclet/testThrowsInheritance/C.java = test/langtools/jdk/javadoc/doclet/testThrowsInheritance/Foo.java = test/langtools/jdk/javadoc/doclet/testThrowsInheritance/I.java = test/langtools/jdk/javadoc/doclet/testThrowsInheritance/Iface.java = test/langtools/jdk/javadoc/doclet/testThrowsInheritance/TestThrowsTagInheritance.java = test/langtools/jdk/javadoc/doclet/testThrowsInheritance/pkg/Abstract.java = test/langtools/jdk/javadoc/doclet/testThrowsInheritance/pkg/Extender.java Changeset: 44d599aa Author: David Holmes Date: 2022-03-01 12:07:21 +0000 URL: https://git.openjdk.java.net/loom/commit/44d599aad3994816997a61d9e36265dcefa52965 8227369: pd_disjoint_words_atomic() needs to be atomic Reviewed-by: eosterlund, mikael, shade, kbarrett, mdoerr ! src/hotspot/cpu/ppc/copy_ppc.hpp ! src/hotspot/cpu/x86/copy_x86.hpp ! src/hotspot/cpu/zero/copy_zero.hpp ! src/hotspot/os_cpu/windows_aarch64/copy_windows_aarch64.hpp ! src/hotspot/share/utilities/copy.hpp Changeset: a95edee6 Author: Harold Seigel Date: 2022-03-01 13:21:57 +0000 URL: https://git.openjdk.java.net/loom/commit/a95edee634c6be52043b55d1a8f3df85a58f97c7 8281472: JVM options processing silently truncates large illegal options values Reviewed-by: dholmes, iklam ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/arguments.hpp + test/hotspot/gtest/runtime/test_largeOptions.cpp ! test/hotspot/jtreg/gc/arguments/TestParallelGCThreads.java ! test/hotspot/jtreg/testlibrary/ctw/src/sun/hotspot/tools/ctw/CtwRunner.java Changeset: fcce24c5 Author: Roland Westrelin Date: 2022-03-01 14:09:15 +0000 URL: https://git.openjdk.java.net/loom/commit/fcce24c5b3cd1dab755fd9b6779af71f4dd78773 8281811: assert(_base == Tuple) failed: Not a Tuple after JDK-8280799 Reviewed-by: kvn, thartmann ! src/hotspot/share/opto/loopnode.cpp ! src/hotspot/share/opto/loopnode.hpp + test/hotspot/jtreg/gc/shenandoah/compiler/TestBarrierAboveProj.java Changeset: 341c8bd7 Author: Ivan Walulya Date: 2022-03-01 14:14:47 +0000 URL: https://git.openjdk.java.net/loom/commit/341c8bd7f2744d1899e78da34e613817b43b44e5 8267834: Refactor G1CardSetAllocator and BufferNode::Allocator to use a common base class Reviewed-by: kbarrett, tschatzl ! src/hotspot/share/gc/g1/g1CardSetMemory.cpp ! src/hotspot/share/gc/g1/g1CardSetMemory.hpp ! src/hotspot/share/gc/g1/g1CardSetMemory.inline.hpp ! src/hotspot/share/gc/g1/g1SegmentedArray.hpp ! src/hotspot/share/gc/g1/g1SegmentedArray.inline.hpp + src/hotspot/share/gc/shared/freeListAllocator.cpp + src/hotspot/share/gc/shared/freeListAllocator.hpp ! src/hotspot/share/gc/shared/ptrQueue.cpp ! src/hotspot/share/gc/shared/ptrQueue.hpp ! test/hotspot/gtest/gc/shared/test_ptrQueueBufferAllocator.cpp Changeset: 2c5d266f Author: Roland Westrelin Date: 2022-03-01 14:43:05 +0000 URL: https://git.openjdk.java.net/loom/commit/2c5d266f9f20005bc2a6c30dcaa95b059ea59d74 8282045: When loop strip mining fails, safepoints are removed from loop anyway Reviewed-by: thartmann, chagedorn ! src/hotspot/share/opto/loopnode.cpp + test/hotspot/jtreg/compiler/c2/irTests/TestStripMiningDropsSafepoint.java ! test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java Changeset: 31b61f98 Author: Pavel Rappo Date: 2022-03-01 15:21:19 +0000 URL: https://git.openjdk.java.net/loom/commit/31b61f982c41b52ae99bd8ecf1977a6c0de515e2 8282311: Fix a typo in javax.lang.model.type.NullType Reviewed-by: jjg ! src/java.compiler/share/classes/javax/lang/model/type/NullType.java Changeset: 76398c84 Author: Coleen Phillimore Date: 2022-03-01 15:28:21 +0000 URL: https://git.openjdk.java.net/loom/commit/76398c84007862bdf07cea6be792eca50eec9edd 8279573: compiler/codecache/CodeCacheFullCountTest.java fails with "RuntimeException: the value of full_count is wrong." Reviewed-by: thartmann, eosterlund ! src/hotspot/share/code/codeCache.cpp ! src/hotspot/share/memory/heap.hpp ! test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java Changeset: b03d66c5 Author: Jan Lahoda Date: 2022-03-01 15:54:10 +0000 URL: https://git.openjdk.java.net/loom/commit/b03d66c5016f3821fbf0990e045b71b59ec9a759 8282452: Use of Preview API in preview methods should not trigger preview warning for the enclosing class Reviewed-by: jlaskey ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java ! test/langtools/jdk/javadoc/doclet/testPreview/TestPreview.java + test/langtools/jdk/javadoc/doclet/testPreview/api/preview/NoPreview.java Changeset: 8fec7b87 Author: Jorn Vernee Date: 2022-03-01 16:26:19 +0000 URL: https://git.openjdk.java.net/loom/commit/8fec7b87c1bc762f9c8ef41cd715d5aaab4c0324 8281548: Add escape analysis tracing flag Reviewed-by: kvn, thartmann, xliu ! src/hotspot/share/compiler/compilerDirectives.hpp ! src/hotspot/share/compiler/compilerOracle.hpp ! src/hotspot/share/opto/escape.cpp ! src/hotspot/share/opto/escape.hpp Changeset: 941e97c4 Author: Manukumar V S Committer: Alexey Ivanov Date: 2022-03-01 16:55:22 +0000 URL: https://git.openjdk.java.net/loom/commit/941e97c4eb186bc63386d17f458ba69f4bddd828 8281738: Create a regression test for checking the 'Space' key activation of focused Button Reviewed-by: aivanov + test/jdk/javax/swing/JButton/4659800/SpaceKeyActivatesButton.java Changeset: b86a8c00 Author: Alexey Ivanov Date: 2022-03-01 17:01:06 +0000 URL: https://git.openjdk.java.net/loom/commit/b86a8c004f4e67e7b6bf45ce7cf96bcd8520a881 8282150: Drop redundant
elements from tables in java.desktop HTML files Reviewed-by: jdv, dmarkov ! src/java.desktop/share/classes/java/awt/doc-files/Modality.html ! src/java.desktop/share/classes/javax/swing/plaf/synth/doc-files/componentProperties.html Changeset: eac80214 Author: Xue-Lei Andrew Fan Date: 2022-03-01 18:10:39 +0000 URL: https://git.openjdk.java.net/loom/commit/eac80214aea4f5c148e859b4b163fe42e89596cd 8282320: Remove case conversion for debugging log in SSLCipher Reviewed-by: weijun ! src/java.base/share/classes/sun/security/ssl/SSLCipher.java Changeset: 732d891f Author: Joe Darcy Date: 2022-03-01 18:48:43 +0000 URL: https://git.openjdk.java.net/loom/commit/732d891f9f8987edfc188c049eb19de6ba790c42 8282411: Add useful predicates to ElementKind Reviewed-by: prappo ! src/java.compiler/share/classes/javax/lang/model/element/ElementKind.java ! test/langtools/tools/javac/processing/model/element/TestElementKindPredicates.java Changeset: fc52a218 Author: Quan Anh Mai Committer: Paul Sandoz Date: 2022-03-02 00:46:35 +0000 URL: https://git.openjdk.java.net/loom/commit/fc52a2182a9debc04b2ac302801b3d61989f54ec 8282143: Objects.requireNonNull should be ForceInline Reviewed-by: psandoz ! src/java.base/share/classes/java/util/Objects.java Changeset: ed3496e6 Author: Christian Hagedorn Date: 2022-03-02 08:57:55 +0000 URL: https://git.openjdk.java.net/loom/commit/ed3496e6c030b6b0a3745bf8ef281075afa1cd27 8282480: IGV: Use description instead of enum name for phases Reviewed-by: redestad, thartmann ! src/hotspot/share/opto/compile.cpp Changeset: 12a822a2 Author: Albert Mingkun Yang Date: 2022-03-02 09:12:20 +0000 URL: https://git.openjdk.java.net/loom/commit/12a822a2875568f4ffd683e8ad9451ebee03ee7e 8282381: Parallel: Remove unnecessary PCReferenceProcessor Reviewed-by: kbarrett, tschatzl ! src/hotspot/share/gc/parallel/psParallelCompact.cpp Changeset: f12200cd Author: Alex Menkov Date: 2022-03-02 10:54:25 +0000 URL: https://git.openjdk.java.net/loom/commit/f12200cd11c2b689618cde1902db941ee23fbf80 8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError Reviewed-by: kevinw, cjplummer ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002.java ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/hs201t002.cpp ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/newclass/hs201t002a.java Changeset: d80f6971 Author: Andrey Turbanov Date: 2022-03-02 13:05:12 +0000 URL: https://git.openjdk.java.net/loom/commit/d80f69718233c484e3c1536ffb793116c1adc058 8282523: Fix 'hierachy' typo Reviewed-by: jiefu, kbarrett, dholmes ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/utilities/exceptions.hpp ! test/hotspot/jtreg/runtime/exceptionMsgs/AbstractMethodError/AbstractMethodErrorTest.java ! test/hotspot/jtreg/runtime/exceptionMsgs/IncompatibleClassChangeError/IncompatibleClassChangeErrorTest.java ! test/hotspot/jtreg/runtime/exceptionMsgs/methodPrinting/TestPrintingMethods.java Changeset: fc918a73 Author: Weijun Wang Date: 2022-03-02 14:07:26 +0000 URL: https://git.openjdk.java.net/loom/commit/fc918a73d0dcc28146e60f15e978209424a32576 8281234: The -protected option is not always checked in keytool and jarsigner Reviewed-by: hchao, mullan ! src/java.base/share/classes/sun/security/tools/keytool/Main.java ! src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java + test/jdk/sun/security/tools/jarsigner/AutoKeyStore.java ! test/lib/jdk/test/lib/SecurityTools.java Changeset: 234c17e8 Author: Calvin Cheung Date: 2022-03-02 16:17:21 +0000 URL: https://git.openjdk.java.net/loom/commit/234c17e8ff7b9b9713e9fded693381f985d34d2a 8274788: Support archived heap objects in ParallelGC Reviewed-by: iklam, ayang, tschatzl ! src/hotspot/share/cds/filemap.cpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp ! src/hotspot/share/gc/parallel/psOldGen.cpp ! src/hotspot/share/gc/parallel/psOldGen.hpp ! test/hotspot/jtreg/TEST.groups + test/hotspot/jtreg/runtime/cds/appcds/TestParallelGCWithCDS.java Changeset: ce18ff85 Author: Devin Smith Committer: Jim Laskey Date: 2022-03-02 16:41:13 +0000 URL: https://git.openjdk.java.net/loom/commit/ce18ff8527cc51805bf11c50c050ea64c3f9dec0 8282551: Properly initialize L32X64MixRandom state Reviewed-by: jlaskey ! src/jdk.random/share/classes/jdk/random/L32X64MixRandom.java From duke at openjdk.java.net Sat Mar 5 15:54:36 2022 From: duke at openjdk.java.net (duke) Date: Sat, 5 Mar 2022 15:54:36 GMT Subject: git: openjdk/loom: fibers: Remove word_copy stubs (hand-rolled x86 memcpy) Message-ID: <3fe99cb8-3089-400b-a4dd-70b8f2c0ee25@openjdk.java.net> Changeset: 88b1009a Author: Ron Pressler Date: 2022-03-05 15:52:46 +0000 URL: https://git.openjdk.java.net/loom/commit/88b1009ab8d86b78e2303760964c05bdcbe8a1eb Remove word_copy stubs (hand-rolled x86 memcpy) ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/share/oops/instanceStackChunkKlass.cpp ! src/hotspot/share/oops/instanceStackChunkKlass.hpp ! src/hotspot/share/oops/instanceStackChunkKlass.inline.hpp ! src/hotspot/share/runtime/continuation.cpp ! src/hotspot/share/runtime/continuation.hpp ! src/hotspot/share/runtime/init.cpp ! src/hotspot/share/runtime/stubRoutines.cpp ! src/hotspot/share/runtime/stubRoutines.hpp From duke at openjdk.java.net Sat Mar 5 15:57:47 2022 From: duke at openjdk.java.net (duke) Date: Sat, 5 Mar 2022 15:57:47 GMT Subject: git: openjdk/loom: fibers: - Message-ID: Changeset: 28aa2af9 Author: Ron Pressler Date: 2022-03-05 15:56:19 +0000 URL: https://git.openjdk.java.net/loom/commit/28aa2af997332d1e25dabf6561b708a57be0e605 - ! src/java.base/share/classes/jdk/internal/vm/StackChunk.java From alanb at openjdk.java.net Sat Mar 5 17:50:25 2022 From: alanb at openjdk.java.net (Alan Bateman) Date: Sat, 5 Mar 2022 17:50:25 GMT Subject: Withdrawn: In rare cases, the unlock() on join() might fail, causing an IllegalMonitorStateException In-Reply-To: References: Message-ID: On Thu, 25 Feb 2021 11:10:41 GMT, kabutz wrote: > Unlike synchronized/wait, the Condition.await() method does not necessarily reacquire the lock on exit, for example if the thread is stopped or if CTRL+C is caused in jshell. In that case we would enter the finally block without the lock held and unlocking would cause an IllegalMonitorStateException. > > For example, run the following code from jshell and then press CTRL+C: > > > Object monitor = new Object(); > for (int i = 0; i < 10_000; i++) { > Thread.startVirtualThread(() -> { > synchronized (monitor) { > try { > monitor.wait(); > } catch (InterruptedException ignore) {} > } > }); > } > Thread.startVirtualThread(() -> System.out.println("done")).join(); > > > Output is: > > > | Exception java.lang.IllegalMonitorStateException > | at ReentrantLock$Sync.tryRelease (ReentrantLock.java:175) > | at AbstractQueuedSynchronizer.release (AbstractQueuedSynchronizer.java:1007) > | at ReentrantLock.unlock (ReentrantLock.java:494) > | at VirtualThread.joinNanos (VirtualThread.java:635) > | at Thread.join (Thread.java:2281) > | at Thread.join (Thread.java:2366) > | at (#3:1) This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/loom/pull/32 From duke at openjdk.java.net Sat Mar 5 23:32:08 2022 From: duke at openjdk.java.net (duke) Date: Sat, 5 Mar 2022 23:32:08 GMT Subject: git: openjdk/loom: fibers: make test MethodExitTest more stable Message-ID: Changeset: 38f8c552 Author: Serguei Spitsyn Date: 2022-03-05 23:29:02 +0000 URL: https://git.openjdk.java.net/loom/commit/38f8c552cf69f2f0f51b5259dcb2ca6aad42eeb3 make test MethodExitTest more stable ! test/hotspot/jtreg/serviceability/jvmti/vthread/MethodExitTest/libMethodExitTest.cpp From duke at openjdk.java.net Sun Mar 6 06:34:27 2022 From: duke at openjdk.java.net (duke) Date: Sun, 6 Mar 2022 06:34:27 GMT Subject: git: openjdk/loom: fibers: add to JVMTI BreakpointInYieldTest defence against WRONG_PHASE Message-ID: Changeset: 53e93750 Author: Serguei Spitsyn Date: 2022-03-06 06:31:37 +0000 URL: https://git.openjdk.java.net/loom/commit/53e93750ff71487f4d7ff1f14344d2fb6f22468d add to JVMTI BreakpointInYieldTest defence against WRONG_PHASE ! test/hotspot/jtreg/serviceability/jvmti/vthread/BreakpointInYieldTest/libBreakpointInYieldTest.cpp From duke at openjdk.java.net Sun Mar 6 07:21:00 2022 From: duke at openjdk.java.net (duke) Date: Sun, 6 Mar 2022 07:21:00 GMT Subject: git: openjdk/loom: fibers: 4 new changesets Message-ID: <83eab1ba-4b06-41ce-9e50-f6da7656c6f2@openjdk.java.net> Changeset: 0603f199 Author: Alan Bateman Date: 2022-03-05 16:34:10 +0000 URL: https://git.openjdk.java.net/loom/commit/0603f1996fedb7dcb36392aa601ca931e080c87a Remove EndingDotHostname.java from exclude list ! test/jdk/ProblemList.txt Changeset: b172aae8 Author: Alan Bateman Date: 2022-03-05 17:40:38 +0000 URL: https://git.openjdk.java.net/loom/commit/b172aae800614ad32c70290279762a22894f2d11 Extract SL tests from ThreadFlockTest + test/jdk/jdk/internal/misc/ThreadFlock/ScopeLocalsTest.java ! test/jdk/jdk/internal/misc/ThreadFlock/ThreadFlockTest.java Changeset: c3924148 Author: Alan Bateman Date: 2022-03-05 18:06:45 +0000 URL: https://git.openjdk.java.net/loom/commit/c39241489f070ee14c39ca97764782048850918d Remove sleepMillis from list of expected methods ! test/hotspot/jtreg/vmTestbase/nsk/monitoring/share/ThreadController.java ! test/hotspot/jtreg/vmTestbase/nsk/monitoring/share/thread/SleepingThread.java ! test/hotspot/jtreg/vmTestbase/nsk/monitoring/stress/thread/strace001.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/strace/strace007.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/strace/strace008.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/strace/strace009.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/strace/strace010.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/strace/strace011.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/strace/strace012.java Changeset: fa10b6a6 Author: Alan Bateman Date: 2022-03-06 07:16:34 +0000 URL: https://git.openjdk.java.net/loom/commit/fa10b6a65ed343ba71cca0b8dea881720346e517 More appcsd tests using ProcessTools, can't run with wrapper ! test/hotspot/jtreg/ProblemList-vthread.txt From duke at openjdk.java.net Sun Mar 6 18:11:45 2022 From: duke at openjdk.java.net (duke) Date: Sun, 6 Mar 2022 18:11:45 GMT Subject: git: openjdk/loom: fibers: 2 new changesets Message-ID: <658c878d-da6d-4944-b95a-133d09c7c8b8@openjdk.java.net> Changeset: 535d5c18 Author: Alan Bateman Date: 2022-03-06 16:56:11 +0000 URL: https://git.openjdk.java.net/loom/commit/535d5c183d94968523c19762ece7d217b0928625 Fix corner case with timeed DS receive + SM ! src/java.base/share/classes/sun/nio/ch/DatagramChannelImpl.java Changeset: f9f4dcd9 Author: Alan Bateman Date: 2022-03-06 17:15:03 +0000 URL: https://git.openjdk.java.net/loom/commit/f9f4dcd99baae935586df07aa58db1e6335ed408 Move native method ! src/java.base/share/classes/jdk/internal/misc/PreviewFeatures.java ! src/java.base/share/classes/jdk/internal/misc/VM.java + src/java.base/share/native/libjava/PreviewFeatures.c ! src/java.base/share/native/libjava/VM.c From haosun at openjdk.java.net Mon Mar 7 03:35:15 2022 From: haosun at openjdk.java.net (Hao Sun) Date: Mon, 7 Mar 2022 03:35:15 GMT Subject: RFR: 8282468: Loom: Fix build failures for PPC64, S390, ARM32 and Zero In-Reply-To: References: Message-ID: <8SoWpWfSPEDLip0aYtca9zug6nMm7yzuj9TTw5zlYPw=.22926409-0a85-4754-af1b-73982d4d4111@github.com> On Tue, 1 Mar 2022 03:55:52 GMT, Hao Sun wrote: > Updates made in commits [1][2][3][4] are missing for PPC64, S390, ARM32 > and Zero, leading to build failures. > > Even though we mainly focus on x64 and AArch64 platforms currently, I > think it would be nice if the builds on other platforms are not broken. > > Hence, we apply the similar updates from [1][2][3][4] to PPC64, S390, > ARM32 and Zero in this patch. > > Testing: > > Linux PPC64 cross-compilation > Linux S390 cross-compilation > Linux ARM32 cross-compilation > Linux AArch64 Zero (Hotspot) compilation > Linux x86_64 tier1_loom passes > Linux AArch64 tier1_loom passes > > [1] https://github.com/openjdk/loom/commit/4f9b661 > [2] https://github.com/openjdk/loom/commit/74b27d0 > [3] https://github.com/openjdk/loom/commit/90fb1b9 > [4] https://github.com/openjdk/loom/commit/d77311e @pron Could you help to review this PR when you got a chance? Thanks in advance. ------------- PR: https://git.openjdk.java.net/loom/pull/92 From cjplummer at openjdk.java.net Mon Mar 7 03:56:42 2022 From: cjplummer at openjdk.java.net (Chris Plummer) Date: Mon, 7 Mar 2022 03:56:42 GMT Subject: RFR: Better jdb support for vthreads. Improved jdb vthread testing support. Message-ID: This PR contains a set of some what disparate but related set of changes to JDB, JDI, and nsk jdb tests and test support (Jdb.java). jdb: Made the ?kill? command support `ThreadReference.stop()` throwing `IllegalThreadStateException` for vthreads, because this is how `ThreadReference.stop()` is now spec?d. This change is in `Commands.java`. The rest of the changes are just cleanup. One of the changes in the `kill001` test is to test for this (see below) jdb: Use `PlatformThreadOnlyFilters` to prevent `ThreadStart/Death` event for vthreads. Instead detect vthreads when events are received on them. The goal here is to prevent jdb from getting a flood of `ThreadStart/Death` events, and getting bogged down with them. With the `PlatformThreadOnlyFilters` in place, this means jdb is not notified when a vthread dies, even one that it learned about later when an event came in on it. For these each of these ?learned? vthreads a separate `ThreadDeathRequest` is needed that uses the thread itself as a `ThreadFilter`. This way jdb can tell when these vthreads die. This part is handled in `EventHandler.java`. `VMConnection.java` is where `PlatformThreadOnlyFilters` are added. jdb: Add `-trackallvthreads` option. This prevents the use of the `PlatformThreadsOnlyFilters` described above, and instead relies on jdb getting the initial set of vthreads from the debug agent via `VM.allThreads()` (by turning on the `enumeratevthreads` option), and by getting a `ThreadStart/Death` event for every vthread created/destroyed after connecting. This is basially how jdb used to work by default before any changes in this PR. There are 3 tests that rely on this behaviour and need this flag. They are `kill001`, `threads002`, and `trace001` (see below). Many more would rely on it if they were converted to use vthreads as these tests were. The bulk of the changes for this support comes from having to pass `trackAllVthreads` through all sorts of constuctors/inits. I wish there were a better way, but I couldn?t find a place to store this value as a static so it is easy to access. If you see a better way, let me know. jdb: Track vthreads separately. jdb keeps track of every thread by creating a `ThreadInfo` for each and storing it in a `List` called `threads`. I decided to store vthreads in a separate list. The reason is the list is needed by the `threads` command. It doesn?t use the `threads` list, but instead walks the `ThreadGroup` hierarchy and prints out the threads within each `ThreadGroup`. This doesn?t capture vthreads since they are not returned by `ThreadGroupReference.threads()`, even for the `VirtualThreads` group. So after the `threads` command has done its usual `ThreadGroup` traversal, it now also dumps all the vthreads. This is pretty much all hidden in `ThreadIterator.next()`, which automically transitions to getting threads from the vthread list after traversing all the `ThreadGroups`. `nsk/share/jdb/Jdb.java`: Added support for `getThreadIdsByName()`: There are many jdb tests that use `Jdb.getThreadIds()` to get all threads in the `threads` output that are an instance of ``. The problem is that after converting a test to support a vthread mode for all debuggee threads, the name of the class in the output will always be `java.lang.VirtualThread` (or `java.lang.Thread` when not in vthread mode), and not the test specific class name, which is usually something like `MyThread`. Making `getThreadIds()` search for `java.lang.VirtualThreads` usually ends up including threads not wanted (ones that are not `MyThread`) such as the main test thread. So `getThreadIdsByName()` was added to allow searching by the thread name (actually just the prefix of the name) rather than its class. As an example, the `threads` command output used to contain a line such as: ` (nsk.jdb.kill.kill001.MyThread)693 Thread-0 waiting in a monitor` Now it contains: ` (java.lang.Thread)693 MyThread-0 waiting in a monitor` So instead of searching for ?(MyThread)? and grabbing the threadId that comes right after it, `getThreadIdsByName()` first finds all the lines of output that contain ?nsk.jdb.kill.kill001.MyThread?, and then for those lines only gets the threadID that is right after ?(java.lang.Thread)? or ?(java.lang.VirtualThread)?. jdb `kill001` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. Use new `getThreadIdsByName()` support instead of `getThreadIds()`. Allow/expect the `kill` command to fail with "Illegal thread state? when in vthread mode. jdb `threads002` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. I forget why I decided to convert this test. Seems it was useful for testing something I was working on for this PR, but I can?t recall. Maybe it was so I could clone it for the new `threads003` test below. jdb `trace001` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. This is a test I had converted long ago when I first experimented with the `getThreadIdsByName()` support, so I included it with this PR. jdb `threads003` test: This is a new thread test that tests jdb?s ability to learn about a thread when an event arrives on it. It creates 5 threads, two of which receive a breakpoint. It looks at the `threads` output and checks that only those two vthreads are present. I also used this test to help confirm that the `ThreadDeath` events are only received for these two vthreads. This was done manually by looking for the ?TDR removed? output generated by `EventHandler.threadDeathEvent()`. I didn?t put this into the test itself since that println is just for debugging and is now commented out. ------------- Commit messages: - Fix another jcheck error - Fix some jcheck errors - Uncomment some code that was temporarily commented out. - Better jdb support for vthreads. Improved jdb vthread testing support. Changes: https://git.openjdk.java.net/loom/pull/97/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=97&range=00 Stats: 489 lines in 17 files changed: 416 ins; 2 del; 71 mod Patch: https://git.openjdk.java.net/loom/pull/97.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/97/head:pull/97 PR: https://git.openjdk.java.net/loom/pull/97 From duke at openjdk.java.net Mon Mar 7 09:53:59 2022 From: duke at openjdk.java.net (duke) Date: Mon, 7 Mar 2022 09:53:59 GMT Subject: git: openjdk/loom: fibers: 2 new changesets Message-ID: Changeset: c4dc17b7 Author: Ron Pressler Date: 2022-03-07 09:51:35 +0000 URL: https://git.openjdk.java.net/loom/commit/c4dc17b7e36ae65f5ec2ff44052f3b3ae2439095 - ! src/hotspot/share/runtime/continuation.cpp Changeset: 1e59d937 Author: Ron Pressler Date: 2022-03-07 09:51:55 +0000 URL: https://git.openjdk.java.net/loom/commit/1e59d9378d07add5fdd3ebf4e1e5bba6061d581d Initialize chunk when retrying slow ! src/hotspot/share/runtime/continuation.cpp From rpressler at openjdk.java.net Mon Mar 7 11:57:28 2022 From: rpressler at openjdk.java.net (Ron Pressler) Date: Mon, 7 Mar 2022 11:57:28 GMT Subject: RFR: 8282468: Loom: Fix build failures for PPC64, S390, ARM32 and Zero In-Reply-To: References: Message-ID: On Tue, 1 Mar 2022 03:55:52 GMT, Hao Sun wrote: > Updates made in commits [1][2][3][4] are missing for PPC64, S390, ARM32 > and Zero, leading to build failures. > > Even though we mainly focus on x64 and AArch64 platforms currently, I > think it would be nice if the builds on other platforms are not broken. > > Hence, we apply the similar updates from [1][2][3][4] to PPC64, S390, > ARM32 and Zero in this patch. > > Testing: > > Linux PPC64 cross-compilation > Linux S390 cross-compilation > Linux ARM32 cross-compilation > Linux AArch64 Zero (Hotspot) compilation > Linux x86_64 tier1_loom passes > Linux AArch64 tier1_loom passes > > [1] https://github.com/openjdk/loom/commit/4f9b661 > [2] https://github.com/openjdk/loom/commit/74b27d0 > [3] https://github.com/openjdk/loom/commit/90fb1b9 > [4] https://github.com/openjdk/loom/commit/d77311e Marked as reviewed by rpressler (Lead). I don't have the cycles to review changes to ports other than x64 and aarch64, so I just approved all changes to non-shared files in these ports. ------------- PR: https://git.openjdk.java.net/loom/pull/92 From haosun at openjdk.java.net Mon Mar 7 12:49:23 2022 From: haosun at openjdk.java.net (Hao Sun) Date: Mon, 7 Mar 2022 12:49:23 GMT Subject: RFR: 8282468: Loom: Fix build failures for PPC64, S390, ARM32 and Zero In-Reply-To: References: Message-ID: On Tue, 1 Mar 2022 03:55:52 GMT, Hao Sun wrote: > Updates made in commits [1][2][3][4] are missing for PPC64, S390, ARM32 > and Zero, leading to build failures. > > Even though we mainly focus on x64 and AArch64 platforms currently, I > think it would be nice if the builds on other platforms are not broken. > > Hence, we apply the similar updates from [1][2][3][4] to PPC64, S390, > ARM32 and Zero in this patch. > > Testing: > > Linux PPC64 cross-compilation > Linux S390 cross-compilation > Linux ARM32 cross-compilation > Linux AArch64 Zero (Hotspot) compilation > Linux x86_64 tier1_loom passes > Linux AArch64 tier1_loom passes > > [1] https://github.com/openjdk/loom/commit/4f9b661 > [2] https://github.com/openjdk/loom/commit/74b27d0 > [3] https://github.com/openjdk/loom/commit/90fb1b9 > [4] https://github.com/openjdk/loom/commit/d77311e Thanks for your review. ------------- PR: https://git.openjdk.java.net/loom/pull/92 From haosun at openjdk.java.net Mon Mar 7 12:59:24 2022 From: haosun at openjdk.java.net (Hao Sun) Date: Mon, 7 Mar 2022 12:59:24 GMT Subject: Integrated: 8282468: Loom: Fix build failures for PPC64, S390, ARM32 and Zero In-Reply-To: References: Message-ID: On Tue, 1 Mar 2022 03:55:52 GMT, Hao Sun wrote: > Updates made in commits [1][2][3][4] are missing for PPC64, S390, ARM32 > and Zero, leading to build failures. > > Even though we mainly focus on x64 and AArch64 platforms currently, I > think it would be nice if the builds on other platforms are not broken. > > Hence, we apply the similar updates from [1][2][3][4] to PPC64, S390, > ARM32 and Zero in this patch. > > Testing: > > Linux PPC64 cross-compilation > Linux S390 cross-compilation > Linux ARM32 cross-compilation > Linux AArch64 Zero (Hotspot) compilation > Linux x86_64 tier1_loom passes > Linux AArch64 tier1_loom passes > > [1] https://github.com/openjdk/loom/commit/4f9b661 > [2] https://github.com/openjdk/loom/commit/74b27d0 > [3] https://github.com/openjdk/loom/commit/90fb1b9 > [4] https://github.com/openjdk/loom/commit/d77311e This pull request has now been integrated. Changeset: ba480847 Author: Hao Sun Committer: Alan Bateman URL: https://git.openjdk.java.net/loom/commit/ba480847b8679c534fc0d4039177d728e8352a25 Stats: 620 lines in 24 files changed: 223 ins; 226 del; 171 mod 8282468: Loom: Fix build failures for PPC64, S390, ARM32 and Zero Reviewed-by: alanb, rpressler ------------- PR: https://git.openjdk.java.net/loom/pull/92 From duke at openjdk.java.net Mon Mar 7 13:44:33 2022 From: duke at openjdk.java.net (duke) Date: Mon, 7 Mar 2022 13:44:33 GMT Subject: git: openjdk/loom: fibers: 8278149: compiler/codecache/CodeCacheFullCountTest.java failing in loom repo Message-ID: <1a11b00b-32d5-40e0-a9f6-8e17b73da25d@openjdk.java.net> Changeset: 89e70fc2 Author: Coleen Phillimore Date: 2022-03-07 13:43:29 +0000 URL: https://git.openjdk.java.net/loom/commit/89e70fc271d607bdb5f73d3b2bb578e35e61776a 8278149: compiler/codecache/CodeCacheFullCountTest.java failing in loom repo ! test/hotspot/jtreg/ProblemList.txt From duke at openjdk.java.net Mon Mar 7 15:23:47 2022 From: duke at openjdk.java.net (duke) Date: Mon, 7 Mar 2022 15:23:47 GMT Subject: git: openjdk/loom: fibers: 4 new changesets Message-ID: <324479cf-494f-46ba-a7d6-f40cf3887081@openjdk.java.net> Changeset: a9de5deb Author: Alan Bateman Date: 2022-03-07 07:30:57 +0000 URL: https://git.openjdk.java.net/loom/commit/a9de5deb5a2660935e068e02357ccd01eea817be Tests need to run with --enable-preview ! test/hotspot/jtreg/serviceability/jvmti/vthread/ContFramePopTest/ContFramePopTest.java ! test/hotspot/jtreg/serviceability/jvmti/vthread/ContStackDepthTest/ContStackDepthTest.java ! test/hotspot/jtreg/serviceability/jvmti/vthread/ContYieldBreakPointTest/ContYieldBreakPointTest.java ! test/hotspot/jtreg/serviceability/jvmti/vthread/ContinuationTest/ContinuationTest.java ! test/hotspot/jtreg/serviceability/jvmti/vthread/RedefineClasses/RedefineRunningMethods.java Changeset: e1aad698 Author: Alan Bateman Date: 2022-03-07 07:31:30 +0000 URL: https://git.openjdk.java.net/loom/commit/e1aad6985e894fb59a649726ff80ea740e812f1f Restore ssl/TransportContext.java until it can use preview APIs ! src/java.base/share/classes/sun/security/ssl/TransportContext.java Changeset: f78205e8 Author: Alan Bateman Date: 2022-03-07 07:46:28 +0000 URL: https://git.openjdk.java.net/loom/commit/f78205e83a14267c35e28155cd171de17c410696 Add --enable-preview to tests ! test/jdk/java/beans/XMLDecoder/8028054/TestConstructorFinder.java ! test/jdk/java/beans/XMLDecoder/8028054/TestMethodFinder.java Changeset: d0c9af43 Author: Alan Bateman Date: 2022-03-07 15:22:52 +0000 URL: https://git.openjdk.java.net/loom/commit/d0c9af43d530c43119f99ec1750fecb61ee80e92 Fix header ! src/hotspot/cpu/ppc/instanceStackChunkKlass_ppc.inline.hpp From alanb at openjdk.java.net Mon Mar 7 16:14:22 2022 From: alanb at openjdk.java.net (Alan Bateman) Date: Mon, 7 Mar 2022 16:14:22 GMT Subject: RFR: Better jdb support for vthreads. Improved jdb vthread testing support. In-Reply-To: References: Message-ID: On Mon, 7 Mar 2022 03:35:55 GMT, Chris Plummer wrote: > This PR contains a set of some what disparate but related set of changes to JDB, JDI, and nsk jdb tests and test support (Jdb.java). > > jdb: Made the ?kill? command support `ThreadReference.stop()` throwing `IllegalThreadStateException` for vthreads, because this is how `ThreadReference.stop()` is now spec?d. This change is in `Commands.java`. The rest of the changes are just cleanup. One of the changes in the `kill001` test is to test for this (see below) > > jdb: Use `PlatformThreadOnlyFilters` to prevent `ThreadStart/Death` event for vthreads. Instead detect vthreads when events are received on them. The goal here is to prevent jdb from getting a flood of `ThreadStart/Death` events, and getting bogged down with them. With the `PlatformThreadOnlyFilters` in place, this means jdb is not notified when a vthread dies, even one that it learned about later when an event came in on it. For these each of these ?learned? vthreads a separate `ThreadDeathRequest` is needed that uses the thread itself as a `ThreadFilter`. This way jdb can tell when these vthreads die. This part is handled in `EventHandler.java`. `VMConnection.java` is where `PlatformThreadOnlyFilters` are added. > > jdb: Add `-trackallvthreads` option. This prevents the use of the `PlatformThreadsOnlyFilters` described above, and instead relies on jdb getting the initial set of vthreads from the debug agent via `VM.allThreads()` (by turning on the `enumeratevthreads` option), and by getting a `ThreadStart/Death` event for every vthread created/destroyed after connecting. This is basially how jdb used to work by default before any changes in this PR. There are 3 tests that rely on this behaviour and need this flag. They are `kill001`, `threads002`, and `trace001` (see below). Many more would rely on it if they were converted to use vthreads as these tests were. The bulk of the changes for this support comes from having to pass `trackAllVthreads` through all sorts of constuctors/inits. I wish there were a better way, but I couldn?t find a place to store this value as a static so it is easy to access. If you see a better way, let me know. > > jdb: Track vthreads separately. jdb keeps track of every thread by creating a `ThreadInfo` for each and storing it in a `List` called `threads`. I decided to store vthreads in a separate list. The reason is the list is needed by the `threads` command. It doesn?t use the `threads` list, but instead walks the `ThreadGroup` hierarchy and prints out the threads within each `ThreadGroup`. This doesn?t capture vthreads since they are not returned by `ThreadGroupReference.threads()`, even for the `VirtualThreads` group. So after the `threads` command has done its usual `ThreadGroup` traversal, it now also dumps all the vthreads. This is pretty much all hidden in `ThreadIterator.next()`, which automically transitions to getting threads from the vthread list after traversing all the `ThreadGroups`. > > `nsk/share/jdb/Jdb.java`: Added support for `getThreadIdsByName()`: There are many jdb tests that use `Jdb.getThreadIds()` to get all threads in the `threads` output that are an instance of ``. The problem is that after converting a test to support a vthread mode for all debuggee threads, the name of the class in the output will always be `java.lang.VirtualThread` (or `java.lang.Thread` when not in vthread mode), and not the test specific class name, which is usually something like `MyThread`. Making `getThreadIds()` search for `java.lang.VirtualThreads` usually ends up including threads not wanted (ones that are not `MyThread`) such as the main test thread. So `getThreadIdsByName()` was added to allow searching by the thread name (actually just the prefix of the name) rather than its class. As an example, the `threads` command output used to contain a line such as: > > ` (nsk.jdb.kill.kill001.MyThread)693 Thread-0 waiting in a monitor` > > Now it contains: > > ` (java.lang.Thread)693 MyThread-0 waiting in a monitor` > > So instead of searching for ?(MyThread)? and grabbing the threadId that comes right after it, `getThreadIdsByName()` first finds all the lines of output that contain ?nsk.jdb.kill.kill001.MyThread?, and then for those lines only gets the threadID that is right after ?(java.lang.Thread)? or ?(java.lang.VirtualThread)?. > > jdb `kill001` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. Use new `getThreadIdsByName()` support instead of `getThreadIds()`. Allow/expect the `kill` command to fail with "Illegal thread state? when in vthread mode. > > jdb `threads002` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. I forget why I decided to convert this test. Seems it was useful for testing something I was working on for this PR, but I can?t recall. Maybe it was so I could clone it for the new `threads003` test below. > > jdb `trace001` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. This is a test I had converted long ago when I first experimented with the `getThreadIdsByName()` support, so I included it with this PR. > > jdb `threads003` test: This is a new thread test that tests jdb?s ability to learn about a thread when an event arrives on it. It creates 5 threads, two of which receive a breakpoint. It looks at the `threads` output and checks that only those two vthreads are present. I also used this test to help confirm that the `ThreadDeath` events are only received for these two vthreads. This was done manually by looking for the ?TDR removed? output generated by `EventHandler.threadDeathEvent()`. I didn?t put this into the test itself since that println is just for debugging and is now commented out. I skimmed through the change the jdb and they look okay. We'll just need to remember that there is a new option for jdb that will need to be tracked by the eventual CSR. src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/EventHandler.java line 125: > 123: tdr.addThreadFilter(eventThread); > 124: tdr.enable(); > 125: //System.out.println("TDR added: " + thread); Left over trace message. src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/EventHandler.java line 306: > 304: EventRequestManager erm = Env.vm().eventRequestManager(); > 305: erm.deleteEventRequest(event.request()); > 306: //System.out.println("TDR removed: " + thread); Another one src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTY.java line 77: > 75: private volatile boolean shuttingDown = false; > 76: > 77: private static boolean trackAllVthreads = false; Probably best to move it to the other static fields. Also not need to explicitly initialise it to false. For shuttingDown (not changed here) then you avoid volatile-write by not explicitly initializing it. src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTY.java line 977: > 975: } > 976: } > 977: } else if (token.equals("-trackallvthreads")) { So `jdb -tracevthreads`. We'll need to remember this change for the eventual CSR. ------------- PR: https://git.openjdk.java.net/loom/pull/97 From duke at openjdk.java.net Mon Mar 7 17:29:02 2022 From: duke at openjdk.java.net (duke) Date: Mon, 7 Mar 2022 17:29:02 GMT Subject: git: openjdk/loom: fibers: Restore rbp when handing exception in enterSpecial Message-ID: <46e2ba90-5a2f-4274-8d0f-9c9c4e56d92c@openjdk.java.net> Changeset: 0d3bdc75 Author: Ron Pressler Date: 2022-03-07 17:28:02 +0000 URL: https://git.openjdk.java.net/loom/commit/0d3bdc7518a38254fba0781d7685caece2f55eb5 Restore rbp when handing exception in enterSpecial ! src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp From cjplummer at openjdk.java.net Mon Mar 7 19:27:31 2022 From: cjplummer at openjdk.java.net (Chris Plummer) Date: Mon, 7 Mar 2022 19:27:31 GMT Subject: RFR: Better jdb support for vthreads. Improved jdb vthread testing support. In-Reply-To: References: Message-ID: On Mon, 7 Mar 2022 16:08:09 GMT, Alan Bateman wrote: >> This PR contains a set of some what disparate but related set of changes to JDB, JDI, and nsk jdb tests and test support (Jdb.java). >> >> jdb: Made the ?kill? command support `ThreadReference.stop()` throwing `IllegalThreadStateException` for vthreads, because this is how `ThreadReference.stop()` is now spec?d. This change is in `Commands.java`. The rest of the changes are just cleanup. One of the changes in the `kill001` test is to test for this (see below) >> >> jdb: Use `PlatformThreadOnlyFilters` to prevent `ThreadStart/Death` event for vthreads. Instead detect vthreads when events are received on them. The goal here is to prevent jdb from getting a flood of `ThreadStart/Death` events, and getting bogged down with them. With the `PlatformThreadOnlyFilters` in place, this means jdb is not notified when a vthread dies, even one that it learned about later when an event came in on it. For these each of these ?learned? vthreads a separate `ThreadDeathRequest` is needed that uses the thread itself as a `ThreadFilter`. This way jdb can tell when these vthreads die. This part is handled in `EventHandler.java`. `VMConnection.java` is where `PlatformThreadOnlyFilters` are added. >> >> jdb: Add `-trackallvthreads` option. This prevents the use of the `PlatformThreadsOnlyFilters` described above, and instead relies on jdb getting the initial set of vthreads from the debug agent via `VM.allThreads()` (by turning on the `enumeratevthreads` option), and by getting a `ThreadStart/Death` event for every vthread created/destroyed after connecting. This is basially how jdb used to work by default before any changes in this PR. There are 3 tests that rely on this behaviour and need this flag. They are `kill001`, `threads002`, and `trace001` (see below). Many more would rely on it if they were converted to use vthreads as these tests were. The bulk of the changes for this support comes from having to pass `trackAllVthreads` through all sorts of constuctors/inits. I wish there were a better way, but I couldn?t find a place to store this value as a static so it is easy to access. If you see a better way, let me know. >> >> jdb: Track vthreads separately. jdb keeps track of every thread by creating a `ThreadInfo` for each and storing it in a `List` called `threads`. I decided to store vthreads in a separate list. The reason is the list is needed by the `threads` command. It doesn?t use the `threads` list, but instead walks the `ThreadGroup` hierarchy and prints out the threads within each `ThreadGroup`. This doesn?t capture vthreads since they are not returned by `ThreadGroupReference.threads()`, even for the `VirtualThreads` group. So after the `threads` command has done its usual `ThreadGroup` traversal, it now also dumps all the vthreads. This is pretty much all hidden in `ThreadIterator.next()`, which automically transitions to getting threads from the vthread list after traversing all the `ThreadGroups`. >> >> `nsk/share/jdb/Jdb.java`: Added support for `getThreadIdsByName()`: There are many jdb tests that use `Jdb.getThreadIds()` to get all threads in the `threads` output that are an instance of ``. The problem is that after converting a test to support a vthread mode for all debuggee threads, the name of the class in the output will always be `java.lang.VirtualThread` (or `java.lang.Thread` when not in vthread mode), and not the test specific class name, which is usually something like `MyThread`. Making `getThreadIds()` search for `java.lang.VirtualThreads` usually ends up including threads not wanted (ones that are not `MyThread`) such as the main test thread. So `getThreadIdsByName()` was added to allow searching by the thread name (actually just the prefix of the name) rather than its class. As an example, the `threads` command output used to contain a line such as: >> >> ` (nsk.jdb.kill.kill001.MyThread)693 Thread-0 waiting in a monitor` >> >> Now it contains: >> >> ` (java.lang.Thread)693 MyThread-0 waiting in a monitor` >> >> So instead of searching for ?(MyThread)? and grabbing the threadId that comes right after it, `getThreadIdsByName()` first finds all the lines of output that contain ?nsk.jdb.kill.kill001.MyThread?, and then for those lines only gets the threadID that is right after ?(java.lang.Thread)? or ?(java.lang.VirtualThread)?. >> >> jdb `kill001` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. Use new `getThreadIdsByName()` support instead of `getThreadIds()`. Allow/expect the `kill` command to fail with "Illegal thread state? when in vthread mode. >> >> jdb `threads002` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. I forget why I decided to convert this test. Seems it was useful for testing something I was working on for this PR, but I can?t recall. Maybe it was so I could clone it for the new `threads003` test below. >> >> jdb `trace001` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. This is a test I had converted long ago when I first experimented with the `getThreadIdsByName()` support, so I included it with this PR. >> >> jdb `threads003` test: This is a new thread test that tests jdb?s ability to learn about a thread when an event arrives on it. It creates 5 threads, two of which receive a breakpoint. It looks at the `threads` output and checks that only those two vthreads are present. I also used this test to help confirm that the `ThreadDeath` events are only received for these two vthreads. This was done manually by looking for the ?TDR removed? output generated by `EventHandler.threadDeathEvent()`. I didn?t put this into the test itself since that println is just for debugging and is now commented out. > > src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/EventHandler.java line 306: > >> 304: EventRequestManager erm = Env.vm().eventRequestManager(); >> 305: erm.deleteEventRequest(event.request()); >> 306: //System.out.println("TDR removed: " + thread); > > Another one Yes, I plan on removing these. They were useful for making sure it was working properly. > src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTY.java line 77: > >> 75: private volatile boolean shuttingDown = false; >> 76: >> 77: private static boolean trackAllVthreads = false; > > Probably best to move it to the other static fields. Also not need to explicitly initialise it to false. For shuttingDown (not changed here) then you avoid volatile-write by not explicitly initializing it. Ok. > src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTY.java line 977: > >> 975: } >> 976: } >> 977: } else if (token.equals("-trackallvthreads")) { > > So `jdb -tracevthreads`. We'll need to remember this change for the eventual CSR. I think you meant `-trackallvthreads`. Do we have a CSR in place yet that I can add too? ------------- PR: https://git.openjdk.java.net/loom/pull/97 From alanb at openjdk.java.net Mon Mar 7 20:04:16 2022 From: alanb at openjdk.java.net (Alan Bateman) Date: Mon, 7 Mar 2022 20:04:16 GMT Subject: RFR: Better jdb support for vthreads. Improved jdb vthread testing support. In-Reply-To: References: Message-ID: On Mon, 7 Mar 2022 19:23:26 GMT, Chris Plummer wrote: > Do we have a CSR in place yet that I can add too? Not for the loom repo but we will include need to remember to include it in the eventual CSR when we bring the feature into main line. ------------- PR: https://git.openjdk.java.net/loom/pull/97 From sspitsyn at openjdk.java.net Tue Mar 8 03:53:24 2022 From: sspitsyn at openjdk.java.net (Serguei Spitsyn) Date: Tue, 8 Mar 2022 03:53:24 GMT Subject: RFR: Better jdb support for vthreads. Improved jdb vthread testing support. In-Reply-To: References: Message-ID: On Mon, 7 Mar 2022 03:35:55 GMT, Chris Plummer wrote: > This PR contains a set of some what disparate but related set of changes to JDB, JDI, and nsk jdb tests and test support (Jdb.java). > > jdb: Made the ?kill? command support `ThreadReference.stop()` throwing `IllegalThreadStateException` for vthreads, because this is how `ThreadReference.stop()` is now spec?d. This change is in `Commands.java`. The rest of the changes are just cleanup. One of the changes in the `kill001` test is to test for this (see below) > > jdb: Use `PlatformThreadOnlyFilters` to prevent `ThreadStart/Death` event for vthreads. Instead detect vthreads when events are received on them. The goal here is to prevent jdb from getting a flood of `ThreadStart/Death` events, and getting bogged down with them. With the `PlatformThreadOnlyFilters` in place, this means jdb is not notified when a vthread dies, even one that it learned about later when an event came in on it. For these each of these ?learned? vthreads a separate `ThreadDeathRequest` is needed that uses the thread itself as a `ThreadFilter`. This way jdb can tell when these vthreads die. This part is handled in `EventHandler.java`. `VMConnection.java` is where `PlatformThreadOnlyFilters` are added. > > jdb: Add `-trackallvthreads` option. This prevents the use of the `PlatformThreadsOnlyFilters` described above, and instead relies on jdb getting the initial set of vthreads from the debug agent via `VM.allThreads()` (by turning on the `enumeratevthreads` option), and by getting a `ThreadStart/Death` event for every vthread created/destroyed after connecting. This is basially how jdb used to work by default before any changes in this PR. There are 3 tests that rely on this behaviour and need this flag. They are `kill001`, `threads002`, and `trace001` (see below). Many more would rely on it if they were converted to use vthreads as these tests were. The bulk of the changes for this support comes from having to pass `trackAllVthreads` through all sorts of constuctors/inits. I wish there were a better way, but I couldn?t find a place to store this value as a static so it is easy to access. If you see a better way, let me know. > > jdb: Track vthreads separately. jdb keeps track of every thread by creating a `ThreadInfo` for each and storing it in a `List` called `threads`. I decided to store vthreads in a separate list. The reason is the list is needed by the `threads` command. It doesn?t use the `threads` list, but instead walks the `ThreadGroup` hierarchy and prints out the threads within each `ThreadGroup`. This doesn?t capture vthreads since they are not returned by `ThreadGroupReference.threads()`, even for the `VirtualThreads` group. So after the `threads` command has done its usual `ThreadGroup` traversal, it now also dumps all the vthreads. This is pretty much all hidden in `ThreadIterator.next()`, which automically transitions to getting threads from the vthread list after traversing all the `ThreadGroups`. > > `nsk/share/jdb/Jdb.java`: Added support for `getThreadIdsByName()`: There are many jdb tests that use `Jdb.getThreadIds()` to get all threads in the `threads` output that are an instance of ``. The problem is that after converting a test to support a vthread mode for all debuggee threads, the name of the class in the output will always be `java.lang.VirtualThread` (or `java.lang.Thread` when not in vthread mode), and not the test specific class name, which is usually something like `MyThread`. Making `getThreadIds()` search for `java.lang.VirtualThreads` usually ends up including threads not wanted (ones that are not `MyThread`) such as the main test thread. So `getThreadIdsByName()` was added to allow searching by the thread name (actually just the prefix of the name) rather than its class. As an example, the `threads` command output used to contain a line such as: > > ` (nsk.jdb.kill.kill001.MyThread)693 Thread-0 waiting in a monitor` > > Now it contains: > > ` (java.lang.Thread)693 MyThread-0 waiting in a monitor` > > So instead of searching for ?(MyThread)? and grabbing the threadId that comes right after it, `getThreadIdsByName()` first finds all the lines of output that contain ?nsk.jdb.kill.kill001.MyThread?, and then for those lines only gets the threadID that is right after ?(java.lang.Thread)? or ?(java.lang.VirtualThread)?. > > jdb `kill001` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. Use new `getThreadIdsByName()` support instead of `getThreadIds()`. Allow/expect the `kill` command to fail with "Illegal thread state? when in vthread mode. > > jdb `threads002` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. I forget why I decided to convert this test. Seems it was useful for testing something I was working on for this PR, but I can?t recall. Maybe it was so I could clone it for the new `threads003` test below. > > jdb `trace001` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. This is a test I had converted long ago when I first experimented with the `getThreadIdsByName()` support, so I included it with this PR. > > jdb `threads003` test: This is a new thread test that tests jdb?s ability to learn about a thread when an event arrives on it. It creates 5 threads, two of which receive a breakpoint. It looks at the `threads` output and checks that only those two vthreads are present. I also used this test to help confirm that the `ThreadDeath` events are only received for these two vthreads. This was done manually by looking for the ?TDR removed? output generated by `EventHandler.threadDeathEvent()`. I didn?t put this into the test itself since that println is just for debugging and is now commented out. src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/EventHandler.java line 114: > 112: if (eventThread != null) { > 113: // This is a vthread we haven't seen before, so add it to our list. > 114: assert eventThread.isVirtual(); It is not clear why a virtual thread is expected here. At least, some comment would be nice to have. ------------- PR: https://git.openjdk.java.net/loom/pull/97 From sspitsyn at openjdk.java.net Tue Mar 8 04:28:25 2022 From: sspitsyn at openjdk.java.net (Serguei Spitsyn) Date: Tue, 8 Mar 2022 04:28:25 GMT Subject: RFR: Better jdb support for vthreads. Improved jdb vthread testing support. In-Reply-To: References: Message-ID: On Tue, 8 Mar 2022 03:49:16 GMT, Serguei Spitsyn wrote: >> This PR contains a set of some what disparate but related set of changes to JDB, JDI, and nsk jdb tests and test support (Jdb.java). >> >> jdb: Made the ?kill? command support `ThreadReference.stop()` throwing `IllegalThreadStateException` for vthreads, because this is how `ThreadReference.stop()` is now spec?d. This change is in `Commands.java`. The rest of the changes are just cleanup. One of the changes in the `kill001` test is to test for this (see below) >> >> jdb: Use `PlatformThreadOnlyFilters` to prevent `ThreadStart/Death` event for vthreads. Instead detect vthreads when events are received on them. The goal here is to prevent jdb from getting a flood of `ThreadStart/Death` events, and getting bogged down with them. With the `PlatformThreadOnlyFilters` in place, this means jdb is not notified when a vthread dies, even one that it learned about later when an event came in on it. For these each of these ?learned? vthreads a separate `ThreadDeathRequest` is needed that uses the thread itself as a `ThreadFilter`. This way jdb can tell when these vthreads die. This part is handled in `EventHandler.java`. `VMConnection.java` is where `PlatformThreadOnlyFilters` are added. >> >> jdb: Add `-trackallvthreads` option. This prevents the use of the `PlatformThreadsOnlyFilters` described above, and instead relies on jdb getting the initial set of vthreads from the debug agent via `VM.allThreads()` (by turning on the `enumeratevthreads` option), and by getting a `ThreadStart/Death` event for every vthread created/destroyed after connecting. This is basially how jdb used to work by default before any changes in this PR. There are 3 tests that rely on this behaviour and need this flag. They are `kill001`, `threads002`, and `trace001` (see below). Many more would rely on it if they were converted to use vthreads as these tests were. The bulk of the changes for this support comes from having to pass `trackAllVthreads` through all sorts of constuctors/inits. I wish there were a better way, but I couldn?t find a place to store this value as a static so it is easy to access. If you see a better way, let me know. >> >> jdb: Track vthreads separately. jdb keeps track of every thread by creating a `ThreadInfo` for each and storing it in a `List` called `threads`. I decided to store vthreads in a separate list. The reason is the list is needed by the `threads` command. It doesn?t use the `threads` list, but instead walks the `ThreadGroup` hierarchy and prints out the threads within each `ThreadGroup`. This doesn?t capture vthreads since they are not returned by `ThreadGroupReference.threads()`, even for the `VirtualThreads` group. So after the `threads` command has done its usual `ThreadGroup` traversal, it now also dumps all the vthreads. This is pretty much all hidden in `ThreadIterator.next()`, which automically transitions to getting threads from the vthread list after traversing all the `ThreadGroups`. >> >> `nsk/share/jdb/Jdb.java`: Added support for `getThreadIdsByName()`: There are many jdb tests that use `Jdb.getThreadIds()` to get all threads in the `threads` output that are an instance of ``. The problem is that after converting a test to support a vthread mode for all debuggee threads, the name of the class in the output will always be `java.lang.VirtualThread` (or `java.lang.Thread` when not in vthread mode), and not the test specific class name, which is usually something like `MyThread`. Making `getThreadIds()` search for `java.lang.VirtualThreads` usually ends up including threads not wanted (ones that are not `MyThread`) such as the main test thread. So `getThreadIdsByName()` was added to allow searching by the thread name (actually just the prefix of the name) rather than its class. As an example, the `threads` command output used to contain a line such as: >> >> ` (nsk.jdb.kill.kill001.MyThread)693 Thread-0 waiting in a monitor` >> >> Now it contains: >> >> ` (java.lang.Thread)693 MyThread-0 waiting in a monitor` >> >> So instead of searching for ?(MyThread)? and grabbing the threadId that comes right after it, `getThreadIdsByName()` first finds all the lines of output that contain ?nsk.jdb.kill.kill001.MyThread?, and then for those lines only gets the threadID that is right after ?(java.lang.Thread)? or ?(java.lang.VirtualThread)?. >> >> jdb `kill001` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. Use new `getThreadIdsByName()` support instead of `getThreadIds()`. Allow/expect the `kill` command to fail with "Illegal thread state? when in vthread mode. >> >> jdb `threads002` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. I forget why I decided to convert this test. Seems it was useful for testing something I was working on for this PR, but I can?t recall. Maybe it was so I could clone it for the new `threads003` test below. >> >> jdb `trace001` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. This is a test I had converted long ago when I first experimented with the `getThreadIdsByName()` support, so I included it with this PR. >> >> jdb `threads003` test: This is a new thread test that tests jdb?s ability to learn about a thread when an event arrives on it. It creates 5 threads, two of which receive a breakpoint. It looks at the `threads` output and checks that only those two vthreads are present. I also used this test to help confirm that the `ThreadDeath` events are only received for these two vthreads. This was done manually by looking for the ?TDR removed? output generated by `EventHandler.threadDeathEvent()`. I didn?t put this into the test itself since that println is just for debugging and is now commented out. > > src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/EventHandler.java line 114: > >> 112: if (eventThread != null) { >> 113: // This is a vthread we haven't seen before, so add it to our list. >> 114: assert eventThread.isVirtual(); > > It is not clear why a virtual thread is expected here. > At least, some comment would be nice to have. I looked at the jdb changes. They look good to me. I've posed one comment though. ------------- PR: https://git.openjdk.java.net/loom/pull/97 From cjplummer at openjdk.java.net Tue Mar 8 04:42:29 2022 From: cjplummer at openjdk.java.net (Chris Plummer) Date: Tue, 8 Mar 2022 04:42:29 GMT Subject: RFR: Better jdb support for vthreads. Improved jdb vthread testing support. In-Reply-To: References: Message-ID: On Tue, 8 Mar 2022 04:25:05 GMT, Serguei Spitsyn wrote: >> src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/EventHandler.java line 114: >> >>> 112: if (eventThread != null) { >>> 113: // This is a vthread we haven't seen before, so add it to our list. >>> 114: assert eventThread.isVirtual(); >> >> It is not clear why a virtual thread is expected here. >> At least, some comment would be nice to have. > > I looked at the jdb changes. They look good to me. I've posed one comment though. Yeah, that got misplaced, probably when I shuffled around some code. I think it would be correct if it was moved below the `addThread()` call and was changed to: ` assert !(added && !eventThread.isVirtual());` which is probably more easily read as: ` assert !added || eventThread.isVirtual());` First I need to see if I can even get asserts enabled since that one should have been triggered. ------------- PR: https://git.openjdk.java.net/loom/pull/97 From cjplummer at openjdk.java.net Tue Mar 8 05:30:11 2022 From: cjplummer at openjdk.java.net (Chris Plummer) Date: Tue, 8 Mar 2022 05:30:11 GMT Subject: RFR: Better jdb support for vthreads. Improved jdb vthread testing support. In-Reply-To: References: Message-ID: On Tue, 8 Mar 2022 04:38:51 GMT, Chris Plummer wrote: >> I looked at the jdb changes. They look good to me. I've posed one comment though. > > Yeah, that got misplaced, probably when I shuffled around some code. I think it would be correct if it was moved below the `addThread()` call and was changed to: > > ` assert !(added && !eventThread.isVirtual());` > > which is probably more easily read as: > > ` assert !added || eventThread.isVirtual());` > > First I need to see if I can even get asserts enabled since that one should have been triggered. Actually that's not quite right either. It looks like it needs to be: if (added) { assert eventThread.isVirtual(); } If this thread was added, it must be an a virtual thread, because if it was not it would have been previously added by a ThreadStart event. ------------- PR: https://git.openjdk.java.net/loom/pull/97 From cjplummer at openjdk.java.net Tue Mar 8 06:13:18 2022 From: cjplummer at openjdk.java.net (Chris Plummer) Date: Tue, 8 Mar 2022 06:13:18 GMT Subject: RFR: Better jdb support for vthreads. Improved jdb vthread testing support. [v2] In-Reply-To: References: Message-ID: > This PR contains a set of some what disparate but related set of changes to JDB, JDI, and nsk jdb tests and test support (Jdb.java). > > jdb: Made the ?kill? command support `ThreadReference.stop()` throwing `IllegalThreadStateException` for vthreads, because this is how `ThreadReference.stop()` is now spec?d. This change is in `Commands.java`. The rest of the changes are just cleanup. One of the changes in the `kill001` test is to test for this (see below) > > jdb: Use `PlatformThreadOnlyFilters` to prevent `ThreadStart/Death` event for vthreads. Instead detect vthreads when events are received on them. The goal here is to prevent jdb from getting a flood of `ThreadStart/Death` events, and getting bogged down with them. With the `PlatformThreadOnlyFilters` in place, this means jdb is not notified when a vthread dies, even one that it learned about later when an event came in on it. For these each of these ?learned? vthreads a separate `ThreadDeathRequest` is needed that uses the thread itself as a `ThreadFilter`. This way jdb can tell when these vthreads die. This part is handled in `EventHandler.java`. `VMConnection.java` is where `PlatformThreadOnlyFilters` are added. > > jdb: Add `-trackallvthreads` option. This prevents the use of the `PlatformThreadsOnlyFilters` described above, and instead relies on jdb getting the initial set of vthreads from the debug agent via `VM.allThreads()` (by turning on the `enumeratevthreads` option), and by getting a `ThreadStart/Death` event for every vthread created/destroyed after connecting. This is basially how jdb used to work by default before any changes in this PR. There are 3 tests that rely on this behaviour and need this flag. They are `kill001`, `threads002`, and `trace001` (see below). Many more would rely on it if they were converted to use vthreads as these tests were. The bulk of the changes for this support comes from having to pass `trackAllVthreads` through all sorts of constuctors/inits. I wish there were a better way, but I couldn?t find a place to store this value as a static so it is easy to access. If you see a better way, let me know. > > jdb: Track vthreads separately. jdb keeps track of every thread by creating a `ThreadInfo` for each and storing it in a `List` called `threads`. I decided to store vthreads in a separate list. The reason is the list is needed by the `threads` command. It doesn?t use the `threads` list, but instead walks the `ThreadGroup` hierarchy and prints out the threads within each `ThreadGroup`. This doesn?t capture vthreads since they are not returned by `ThreadGroupReference.threads()`, even for the `VirtualThreads` group. So after the `threads` command has done its usual `ThreadGroup` traversal, it now also dumps all the vthreads. This is pretty much all hidden in `ThreadIterator.next()`, which automically transitions to getting threads from the vthread list after traversing all the `ThreadGroups`. > > `nsk/share/jdb/Jdb.java`: Added support for `getThreadIdsByName()`: There are many jdb tests that use `Jdb.getThreadIds()` to get all threads in the `threads` output that are an instance of ``. The problem is that after converting a test to support a vthread mode for all debuggee threads, the name of the class in the output will always be `java.lang.VirtualThread` (or `java.lang.Thread` when not in vthread mode), and not the test specific class name, which is usually something like `MyThread`. Making `getThreadIds()` search for `java.lang.VirtualThreads` usually ends up including threads not wanted (ones that are not `MyThread`) such as the main test thread. So `getThreadIdsByName()` was added to allow searching by the thread name (actually just the prefix of the name) rather than its class. As an example, the `threads` command output used to contain a line such as: > > ` (nsk.jdb.kill.kill001.MyThread)693 Thread-0 waiting in a monitor` > > Now it contains: > > ` (java.lang.Thread)693 MyThread-0 waiting in a monitor` > > So instead of searching for ?(MyThread)? and grabbing the threadId that comes right after it, `getThreadIdsByName()` first finds all the lines of output that contain ?nsk.jdb.kill.kill001.MyThread?, and then for those lines only gets the threadID that is right after ?(java.lang.Thread)? or ?(java.lang.VirtualThread)?. > > jdb `kill001` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. Use new `getThreadIdsByName()` support instead of `getThreadIds()`. Allow/expect the `kill` command to fail with "Illegal thread state? when in vthread mode. > > jdb `threads002` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. I forget why I decided to convert this test. Seems it was useful for testing something I was working on for this PR, but I can?t recall. Maybe it was so I could clone it for the new `threads003` test below. > > jdb `trace001` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. This is a test I had converted long ago when I first experimented with the `getThreadIdsByName()` support, so I included it with this PR. > > jdb `threads003` test: This is a new thread test that tests jdb?s ability to learn about a thread when an event arrives on it. It creates 5 threads, two of which receive a breakpoint. It looks at the `threads` output and checks that only those two vthreads are present. I also used this test to help confirm that the `ThreadDeath` events are only received for these two vthreads. This was done manually by looking for the ?TDR removed? output generated by `EventHandler.threadDeathEvent()`. I didn?t put this into the test itself since that println is just for debugging and is now commented out. Chris Plummer has updated the pull request incrementally with one additional commit since the last revision: Minor cleanup. Fix assert. ------------- Changes: - all: https://git.openjdk.java.net/loom/pull/97/files - new: https://git.openjdk.java.net/loom/pull/97/files/174483ea..f3f8acf9 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=loom&pr=97&range=01 - incr: https://webrevs.openjdk.java.net/?repo=loom&pr=97&range=00-01 Stats: 12 lines in 2 files changed: 6 ins; 5 del; 1 mod Patch: https://git.openjdk.java.net/loom/pull/97.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/97/head:pull/97 PR: https://git.openjdk.java.net/loom/pull/97 From cjplummer at openjdk.java.net Tue Mar 8 08:12:23 2022 From: cjplummer at openjdk.java.net (Chris Plummer) Date: Tue, 8 Mar 2022 08:12:23 GMT Subject: RFR: Better jdb support for vthreads. Improved jdb vthread testing support. [v3] In-Reply-To: References: Message-ID: > This PR contains a set of some what disparate but related set of changes to JDB, JDI, and nsk jdb tests and test support (Jdb.java). > > jdb: Made the ?kill? command support `ThreadReference.stop()` throwing `IllegalThreadStateException` for vthreads, because this is how `ThreadReference.stop()` is now spec?d. This change is in `Commands.java`. The rest of the changes are just cleanup. One of the changes in the `kill001` test is to test for this (see below) > > jdb: Use `PlatformThreadOnlyFilters` to prevent `ThreadStart/Death` event for vthreads. Instead detect vthreads when events are received on them. The goal here is to prevent jdb from getting a flood of `ThreadStart/Death` events, and getting bogged down with them. With the `PlatformThreadOnlyFilters` in place, this means jdb is not notified when a vthread dies, even one that it learned about later when an event came in on it. For these each of these ?learned? vthreads a separate `ThreadDeathRequest` is needed that uses the thread itself as a `ThreadFilter`. This way jdb can tell when these vthreads die. This part is handled in `EventHandler.java`. `VMConnection.java` is where `PlatformThreadOnlyFilters` are added. > > jdb: Add `-trackallvthreads` option. This prevents the use of the `PlatformThreadsOnlyFilters` described above, and instead relies on jdb getting the initial set of vthreads from the debug agent via `VM.allThreads()` (by turning on the `enumeratevthreads` option), and by getting a `ThreadStart/Death` event for every vthread created/destroyed after connecting. This is basially how jdb used to work by default before any changes in this PR. There are 3 tests that rely on this behaviour and need this flag. They are `kill001`, `threads002`, and `trace001` (see below). Many more would rely on it if they were converted to use vthreads as these tests were. The bulk of the changes for this support comes from having to pass `trackAllVthreads` through all sorts of constuctors/inits. I wish there were a better way, but I couldn?t find a place to store this value as a static so it is easy to access. If you see a better way, let me know. > > jdb: Track vthreads separately. jdb keeps track of every thread by creating a `ThreadInfo` for each and storing it in a `List` called `threads`. I decided to store vthreads in a separate list. The reason is the list is needed by the `threads` command. It doesn?t use the `threads` list, but instead walks the `ThreadGroup` hierarchy and prints out the threads within each `ThreadGroup`. This doesn?t capture vthreads since they are not returned by `ThreadGroupReference.threads()`, even for the `VirtualThreads` group. So after the `threads` command has done its usual `ThreadGroup` traversal, it now also dumps all the vthreads. This is pretty much all hidden in `ThreadIterator.next()`, which automically transitions to getting threads from the vthread list after traversing all the `ThreadGroups`. > > `nsk/share/jdb/Jdb.java`: Added support for `getThreadIdsByName()`: There are many jdb tests that use `Jdb.getThreadIds()` to get all threads in the `threads` output that are an instance of ``. The problem is that after converting a test to support a vthread mode for all debuggee threads, the name of the class in the output will always be `java.lang.VirtualThread` (or `java.lang.Thread` when not in vthread mode), and not the test specific class name, which is usually something like `MyThread`. Making `getThreadIds()` search for `java.lang.VirtualThreads` usually ends up including threads not wanted (ones that are not `MyThread`) such as the main test thread. So `getThreadIdsByName()` was added to allow searching by the thread name (actually just the prefix of the name) rather than its class. As an example, the `threads` command output used to contain a line such as: > > ` (nsk.jdb.kill.kill001.MyThread)693 Thread-0 waiting in a monitor` > > Now it contains: > > ` (java.lang.Thread)693 MyThread-0 waiting in a monitor` > > So instead of searching for ?(MyThread)? and grabbing the threadId that comes right after it, `getThreadIdsByName()` first finds all the lines of output that contain ?nsk.jdb.kill.kill001.MyThread?, and then for those lines only gets the threadID that is right after ?(java.lang.Thread)? or ?(java.lang.VirtualThread)?. > > jdb `kill001` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. Use new `getThreadIdsByName()` support instead of `getThreadIds()`. Allow/expect the `kill` command to fail with "Illegal thread state? when in vthread mode. > > jdb `threads002` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. I forget why I decided to convert this test. Seems it was useful for testing something I was working on for this PR, but I can?t recall. Maybe it was so I could clone it for the new `threads003` test below. > > jdb `trace001` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. This is a test I had converted long ago when I first experimented with the `getThreadIdsByName()` support, so I included it with this PR. > > jdb `threads003` test: This is a new thread test that tests jdb?s ability to learn about a thread when an event arrives on it. It creates 5 threads, two of which receive a breakpoint. It looks at the `threads` output and checks that only those two vthreads are present. I also used this test to help confirm that the `ThreadDeath` events are only received for these two vthreads. This was done manually by looking for the ?TDR removed? output generated by `EventHandler.threadDeathEvent()`. I didn?t put this into the test itself since that println is just for debugging and is now commented out. Chris Plummer has updated the pull request incrementally with one additional commit since the last revision: Minor comment changes. ------------- Changes: - all: https://git.openjdk.java.net/loom/pull/97/files - new: https://git.openjdk.java.net/loom/pull/97/files/f3f8acf9..d6d13846 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=loom&pr=97&range=02 - incr: https://webrevs.openjdk.java.net/?repo=loom&pr=97&range=01-02 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/loom/pull/97.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/97/head:pull/97 PR: https://git.openjdk.java.net/loom/pull/97 From sspitsyn at openjdk.java.net Tue Mar 8 08:12:25 2022 From: sspitsyn at openjdk.java.net (Serguei Spitsyn) Date: Tue, 8 Mar 2022 08:12:25 GMT Subject: RFR: Better jdb support for vthreads. Improved jdb vthread testing support. [v3] In-Reply-To: References: Message-ID: <5QFam8eNXRRgJrFuFV6OJ_TvBrXOLR7w1qgtEklTOYY=.5b7c77bf-7fb1-4bdc-a9f9-1f4a58663d3d@github.com> On Tue, 8 Mar 2022 05:26:53 GMT, Chris Plummer wrote: >> Yeah, that got misplaced, probably when I shuffled around some code. I think it would be correct if it was moved below the `addThread()` call and was changed to: >> >> ` assert !(added && !eventThread.isVirtual());` >> >> which is probably more easily read as: >> >> ` assert !added || eventThread.isVirtual());` >> >> First I need to see if I can even get asserts enabled since that one should have been triggered. > > Actually that's not quite right either. It looks like it needs to be: > > > if (added) { > assert eventThread.isVirtual(); > } > > If this thread was added, it must be an a virtual thread, because if it was not it would have been previously added by a ThreadStart event. It is better to add a comment explaining this. Otherwise, it is hard to understand why this conclusion was made. Also, why do you think this is not equal to your conditional assert above?: assert !added || eventThread.isVirtual()); ------------- PR: https://git.openjdk.java.net/loom/pull/97 From cjplummer at openjdk.java.net Tue Mar 8 08:52:36 2022 From: cjplummer at openjdk.java.net (Chris Plummer) Date: Tue, 8 Mar 2022 08:52:36 GMT Subject: RFR: Better jdb support for vthreads. Improved jdb vthread testing support. [v3] In-Reply-To: <5QFam8eNXRRgJrFuFV6OJ_TvBrXOLR7w1qgtEklTOYY=.5b7c77bf-7fb1-4bdc-a9f9-1f4a58663d3d@github.com> References: <5QFam8eNXRRgJrFuFV6OJ_TvBrXOLR7w1qgtEklTOYY=.5b7c77bf-7fb1-4bdc-a9f9-1f4a58663d3d@github.com> Message-ID: <-I5p0RnJORV0_O6ZLUcPaifD-PvJH-erd8aVeZvytqQ=.cae1c2cf-54b6-49ec-a52e-aa5c1266e6f0@github.com> On Tue, 8 Mar 2022 08:08:07 GMT, Serguei Spitsyn wrote: > It is better to add a comment explaining this. > Otherwise, it is hard to understand why this conclusion was made. I added some comments. > Also, why do you think this is not equal to your conditional assert above?: > assert !added || eventThread.isVirtual()); Actually that does work, but I think it is easier to read with the "if" statement. ------------- PR: https://git.openjdk.java.net/loom/pull/97 From duke at openjdk.java.net Tue Mar 8 09:33:50 2022 From: duke at openjdk.java.net (duke) Date: Tue, 8 Mar 2022 09:33:50 GMT Subject: git: openjdk/loom: fibers: Cleanup Message-ID: Changeset: 7f354248 Author: Ron Pressler Date: 2022-03-08 09:33:18 +0000 URL: https://git.openjdk.java.net/loom/commit/7f3542489fbe09a2737e72fa3973b019069ee340 Cleanup ! src/hotspot/share/oops/instanceStackChunkKlass.cpp ! src/hotspot/share/runtime/continuation.cpp ! src/hotspot/share/runtime/continuation.hpp From duke at openjdk.java.net Tue Mar 8 09:45:29 2022 From: duke at openjdk.java.net (duke) Date: Tue, 8 Mar 2022 09:45:29 GMT Subject: git: openjdk/loom: fibers: Remove ContinuationHelper::last_frame Message-ID: <0629162c-66d8-4781-b2ba-92783e4a3bca@openjdk.java.net> Changeset: 379bb490 Author: Ron Pressler Date: 2022-03-08 09:43:34 +0000 URL: https://git.openjdk.java.net/loom/commit/379bb490d4034bb6445e2a70f57eecfcc39f0d90 Remove ContinuationHelper::last_frame ! src/hotspot/cpu/aarch64/continuation_aarch64.inline.hpp ! src/hotspot/cpu/x86/continuation_x86.inline.hpp ! src/hotspot/share/runtime/continuation.cpp From duke at openjdk.java.net Tue Mar 8 09:47:09 2022 From: duke at openjdk.java.net (duke) Date: Tue, 8 Mar 2022 09:47:09 GMT Subject: git: openjdk/loom: fibers: Cleanup Message-ID: Changeset: 3b18efa6 Author: Ron Pressler Date: 2022-03-08 09:45:48 +0000 URL: https://git.openjdk.java.net/loom/commit/3b18efa64bcad2874e9ba3b28358f44e35cb287f Cleanup ! src/hotspot/share/runtime/continuation.cpp From duke at openjdk.java.net Tue Mar 8 11:49:16 2022 From: duke at openjdk.java.net (duke) Date: Tue, 8 Mar 2022 11:49:16 GMT Subject: git: openjdk/loom: fibers: 3 new changesets Message-ID: <112d0af5-7f49-438d-a47a-c19ed4d4af72@openjdk.java.net> Changeset: 59901983 Author: Alan Bateman Date: 2022-03-07 16:47:40 +0000 URL: https://git.openjdk.java.net/loom/commit/5990198333e48edfa587bd893085aefb028c64a9 Typo in comment ! src/java.base/share/classes/java/lang/Thread.java Changeset: 2b6bbc4e Author: Alan Bateman Date: 2022-03-07 19:57:31 +0000 URL: https://git.openjdk.java.net/loom/commit/2b6bbc4e24307a0856be097af0a3692422382cc1 Get TG for finalizer/RH threads once ! src/java.base/share/classes/java/lang/ref/Finalizer.java ! src/java.base/share/classes/java/lang/ref/Reference.java Changeset: 8f3556d9 Author: Alan Bateman Date: 2022-03-08 11:20:40 +0000 URL: https://git.openjdk.java.net/loom/commit/8f3556d9a6a2d0b12ee5f7adebb21b5c14780c7f Specify OPAQUE_FRAME/OpaqueFrameException when not supported on virtual thread ! make/data/jdwp/jdwp.spec ! src/hotspot/share/prims/jvmti.xml ! src/jdk.jdi/share/classes/com/sun/jdi/NativeMethodException.java + src/jdk.jdi/share/classes/com/sun/jdi/OpaqueFrameException.java ! src/jdk.jdi/share/classes/com/sun/jdi/StackFrame.java ! src/jdk.jdi/share/classes/com/sun/jdi/ThreadReference.java From duke at openjdk.java.net Tue Mar 8 11:55:57 2022 From: duke at openjdk.java.net (duke) Date: Tue, 8 Mar 2022 11:55:57 GMT Subject: git: openjdk/loom: fibers: 2 new changesets Message-ID: Changeset: 3cd62513 Author: Ron Pressler Date: 2022-03-08 11:51:44 +0000 URL: https://git.openjdk.java.net/loom/commit/3cd62513e08a119619308660c6513fdda6c16e6e Cleanup ! src/hotspot/share/runtime/continuation.cpp Changeset: fdd5867c Author: Ron Pressler Date: 2022-03-07 15:04:42 +0000 URL: https://git.openjdk.java.net/loom/commit/fdd5867c48c98c0c9dc4f5d1c42bde5baa26fd46 Improve frame::describe ! src/hotspot/cpu/aarch64/frame_aarch64.cpp ! src/hotspot/cpu/x86/frame_x86.cpp ! src/hotspot/share/oops/instanceStackChunkKlass.cpp ! src/hotspot/share/runtime/frame.cpp ! src/hotspot/share/runtime/frame.hpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/utilities/debug.cpp From duke at openjdk.java.net Tue Mar 8 14:45:08 2022 From: duke at openjdk.java.net (duke) Date: Tue, 8 Mar 2022 14:45:08 GMT Subject: git: openjdk/loom: fibers: Introduce FreezeBase and ThawBase classes Message-ID: <0dc55bec-ad06-4ef0-8a2c-f84386048b4c@openjdk.java.net> Changeset: 343cd6bf Author: Ron Pressler Date: 2022-03-08 14:44:26 +0000 URL: https://git.openjdk.java.net/loom/commit/343cd6bffcb9a569e3327772145bd1a0bb993267 Introduce FreezeBase and ThawBase classes ! src/hotspot/cpu/aarch64/continuation_aarch64.inline.hpp ! src/hotspot/cpu/x86/continuation_x86.inline.hpp ! src/hotspot/share/runtime/continuation.cpp From duke at openjdk.java.net Tue Mar 8 16:34:06 2022 From: duke at openjdk.java.net (duke) Date: Tue, 8 Mar 2022 16:34:06 GMT Subject: git: openjdk/loom: fibers: 2 new changesets Message-ID: Changeset: ea9e975d Author: Alan Bateman Date: 2022-03-08 14:42:04 +0000 URL: https://git.openjdk.java.net/loom/commit/ea9e975d5fb68489ebb34f77b6cb606205eacf14 Add initial mapping of error ! src/jdk.jdi/share/classes/com/sun/tools/jdi/JDWPException.java Changeset: f8c0948d Author: Alan Bateman Date: 2022-03-08 16:22:38 +0000 URL: https://git.openjdk.java.net/loom/commit/f8c0948db059139692dc7c9f7c46e4857f635bca Missing --enable-preview from tests ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetThreadInfo/thrinfo001/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineVirtual/StressRedefineVirtual.java From amenkov at openjdk.java.net Tue Mar 8 15:52:25 2022 From: amenkov at openjdk.java.net (Alex Menkov) Date: Tue, 8 Mar 2022 15:52:25 GMT Subject: RFR: Better jdb support for vthreads. Improved jdb vthread testing support. [v3] In-Reply-To: References: Message-ID: On Tue, 8 Mar 2022 08:12:23 GMT, Chris Plummer wrote: >> This PR contains a set of some what disparate but related set of changes to JDB, JDI, and nsk jdb tests and test support (Jdb.java). >> >> jdb: Made the ?kill? command support `ThreadReference.stop()` throwing `IllegalThreadStateException` for vthreads, because this is how `ThreadReference.stop()` is now spec?d. This change is in `Commands.java`. The rest of the changes are just cleanup. One of the changes in the `kill001` test is to test for this (see below) >> >> jdb: Use `PlatformThreadOnlyFilters` to prevent `ThreadStart/Death` event for vthreads. Instead detect vthreads when events are received on them. The goal here is to prevent jdb from getting a flood of `ThreadStart/Death` events, and getting bogged down with them. With the `PlatformThreadOnlyFilters` in place, this means jdb is not notified when a vthread dies, even one that it learned about later when an event came in on it. For these each of these ?learned? vthreads a separate `ThreadDeathRequest` is needed that uses the thread itself as a `ThreadFilter`. This way jdb can tell when these vthreads die. This part is handled in `EventHandler.java`. `VMConnection.java` is where `PlatformThreadOnlyFilters` are added. >> >> jdb: Add `-trackallvthreads` option. This prevents the use of the `PlatformThreadsOnlyFilters` described above, and instead relies on jdb getting the initial set of vthreads from the debug agent via `VM.allThreads()` (by turning on the `enumeratevthreads` option), and by getting a `ThreadStart/Death` event for every vthread created/destroyed after connecting. This is basially how jdb used to work by default before any changes in this PR. There are 3 tests that rely on this behaviour and need this flag. They are `kill001`, `threads002`, and `trace001` (see below). Many more would rely on it if they were converted to use vthreads as these tests were. The bulk of the changes for this support comes from having to pass `trackAllVthreads` through all sorts of constuctors/inits. I wish there were a better way, but I couldn?t find a place to store this value as a static so it is easy to access. If you see a better way, let me know. >> >> jdb: Track vthreads separately. jdb keeps track of every thread by creating a `ThreadInfo` for each and storing it in a `List` called `threads`. I decided to store vthreads in a separate list. The reason is the list is needed by the `threads` command. It doesn?t use the `threads` list, but instead walks the `ThreadGroup` hierarchy and prints out the threads within each `ThreadGroup`. This doesn?t capture vthreads since they are not returned by `ThreadGroupReference.threads()`, even for the `VirtualThreads` group. So after the `threads` command has done its usual `ThreadGroup` traversal, it now also dumps all the vthreads. This is pretty much all hidden in `ThreadIterator.next()`, which automically transitions to getting threads from the vthread list after traversing all the `ThreadGroups`. >> >> `nsk/share/jdb/Jdb.java`: Added support for `getThreadIdsByName()`: There are many jdb tests that use `Jdb.getThreadIds()` to get all threads in the `threads` output that are an instance of ``. The problem is that after converting a test to support a vthread mode for all debuggee threads, the name of the class in the output will always be `java.lang.VirtualThread` (or `java.lang.Thread` when not in vthread mode), and not the test specific class name, which is usually something like `MyThread`. Making `getThreadIds()` search for `java.lang.VirtualThreads` usually ends up including threads not wanted (ones that are not `MyThread`) such as the main test thread. So `getThreadIdsByName()` was added to allow searching by the thread name (actually just the prefix of the name) rather than its class. As an example, the `threads` command output used to contain a line such as: >> >> ` (nsk.jdb.kill.kill001.MyThread)693 Thread-0 waiting in a monitor` >> >> Now it contains: >> >> ` (java.lang.Thread)693 MyThread-0 waiting in a monitor` >> >> So instead of searching for ?(MyThread)? and grabbing the threadId that comes right after it, `getThreadIdsByName()` first finds all the lines of output that contain ?nsk.jdb.kill.kill001.MyThread?, and then for those lines only gets the threadID that is right after ?(java.lang.Thread)? or ?(java.lang.VirtualThread)?. >> >> jdb `kill001` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. Use new `getThreadIdsByName()` support instead of `getThreadIds()`. Allow/expect the `kill` command to fail with "Illegal thread state? when in vthread mode. >> >> jdb `threads002` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. I forget why I decided to convert this test. Seems it was useful for testing something I was working on for this PR, but I can?t recall. Maybe it was so I could clone it for the new `threads003` test below. >> >> jdb `trace001` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. This is a test I had converted long ago when I first experimented with the `getThreadIdsByName()` support, so I included it with this PR. >> >> jdb `threads003` test: This is a new thread test that tests jdb?s ability to learn about a thread when an event arrives on it. It creates 5 threads, two of which receive a breakpoint. It looks at the `threads` output and checks that only those two vthreads are present. I also used this test to help confirm that the `ThreadDeath` events are only received for these two vthreads. This was done manually by looking for the ?TDR removed? output generated by `EventHandler.threadDeathEvent()`. I didn?t put this into the test itself since that println is just for debugging and is now commented out. > > Chris Plummer has updated the pull request incrementally with one additional commit since the last revision: > > Minor comment changes. src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/EventHandler.java line 108: > 106: ThreadReference eventThread = null; > 107: if (event instanceof ClassPrepareEvent) { > 108: eventThread = ((ClassPrepareEvent)event).thread(); Suggestion: if (event instanceof ClassPrepareEvent evt) { eventThread = evt.thread(); The same for lines 109-110 test/hotspot/jtreg/vmTestbase/nsk/jdb/kill/kill001/kill001.java line 53: > 51: * nsk.jdb.kill.kill001.kill001 > 52: * -arch=${os.family}-${os.simpleArch} > 53: * -waittime=1 -verbose please add -verbose at separate line. And I suppose you changed waittime temporary and forgot to revert it. The same for other tests test/hotspot/jtreg/vmTestbase/nsk/jdb/kill/kill001/kill001.java line 133: > 131: // Continue each of the threads that received the "kill" exception. Not needed > 132: // for the vthread case since they are not actually killed. > 133: if (!vthreadMode) for (int i = 0; i < numThreads; i++) { if and for at the same line don't look good ------------- PR: https://git.openjdk.java.net/loom/pull/97 From cjplummer at openjdk.java.net Tue Mar 8 20:31:26 2022 From: cjplummer at openjdk.java.net (Chris Plummer) Date: Tue, 8 Mar 2022 20:31:26 GMT Subject: RFR: Better jdb support for vthreads. Improved jdb vthread testing support. [v3] In-Reply-To: References: Message-ID: On Tue, 8 Mar 2022 15:47:55 GMT, Alex Menkov wrote: >> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision: >> >> Minor comment changes. > > src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/EventHandler.java line 108: > >> 106: ThreadReference eventThread = null; >> 107: if (event instanceof ClassPrepareEvent) { >> 108: eventThread = ((ClassPrepareEvent)event).thread(); > > Suggestion: > > if (event instanceof ClassPrepareEvent evt) { > eventThread = evt.thread(); > > The same for lines 109-110 ok > test/hotspot/jtreg/vmTestbase/nsk/jdb/kill/kill001/kill001.java line 53: > >> 51: * nsk.jdb.kill.kill001.kill001 >> 52: * -arch=${os.family}-${os.simpleArch} >> 53: * -waittime=1 -verbose > > please add -verbose at separate line. > And I suppose you changed waittime temporary and forgot to revert it. > The same for other tests Ok, will move to separate line. For `-waittime`, 5 seems overkill for all these tests. If anything ever goes wrong with the test, it seems you always end up waiting for a timeout. So first thing I do is change `-waittime` to 1 so I don't have to wait as long when debugging the test. I'd change it to .5 if I could, but it doesn't accept decimals. I could change it back to 5, but I don't see why it needs to be so big. Maybe @lmesnik can comment on this. ------------- PR: https://git.openjdk.java.net/loom/pull/97 From cjplummer at openjdk.java.net Tue Mar 8 20:35:58 2022 From: cjplummer at openjdk.java.net (Chris Plummer) Date: Tue, 8 Mar 2022 20:35:58 GMT Subject: RFR: Better jdb support for vthreads. Improved jdb vthread testing support. [v4] In-Reply-To: References: Message-ID: <9blGjab33q8-MbWPHH-DkKQRNkGc46mG6nekeVoCB3Y=.78729a80-3f3a-48b8-b305-9415c4bc1ee7@github.com> > This PR contains a set of some what disparate but related set of changes to JDB, JDI, and nsk jdb tests and test support (Jdb.java). > > jdb: Made the ?kill? command support `ThreadReference.stop()` throwing `IllegalThreadStateException` for vthreads, because this is how `ThreadReference.stop()` is now spec?d. This change is in `Commands.java`. The rest of the changes are just cleanup. One of the changes in the `kill001` test is to test for this (see below) > > jdb: Use `PlatformThreadOnlyFilters` to prevent `ThreadStart/Death` event for vthreads. Instead detect vthreads when events are received on them. The goal here is to prevent jdb from getting a flood of `ThreadStart/Death` events, and getting bogged down with them. With the `PlatformThreadOnlyFilters` in place, this means jdb is not notified when a vthread dies, even one that it learned about later when an event came in on it. For these each of these ?learned? vthreads a separate `ThreadDeathRequest` is needed that uses the thread itself as a `ThreadFilter`. This way jdb can tell when these vthreads die. This part is handled in `EventHandler.java`. `VMConnection.java` is where `PlatformThreadOnlyFilters` are added. > > jdb: Add `-trackallvthreads` option. This prevents the use of the `PlatformThreadsOnlyFilters` described above, and instead relies on jdb getting the initial set of vthreads from the debug agent via `VM.allThreads()` (by turning on the `enumeratevthreads` option), and by getting a `ThreadStart/Death` event for every vthread created/destroyed after connecting. This is basially how jdb used to work by default before any changes in this PR. There are 3 tests that rely on this behaviour and need this flag. They are `kill001`, `threads002`, and `trace001` (see below). Many more would rely on it if they were converted to use vthreads as these tests were. The bulk of the changes for this support comes from having to pass `trackAllVthreads` through all sorts of constuctors/inits. I wish there were a better way, but I couldn?t find a place to store this value as a static so it is easy to access. If you see a better way, let me know. > > jdb: Track vthreads separately. jdb keeps track of every thread by creating a `ThreadInfo` for each and storing it in a `List` called `threads`. I decided to store vthreads in a separate list. The reason is the list is needed by the `threads` command. It doesn?t use the `threads` list, but instead walks the `ThreadGroup` hierarchy and prints out the threads within each `ThreadGroup`. This doesn?t capture vthreads since they are not returned by `ThreadGroupReference.threads()`, even for the `VirtualThreads` group. So after the `threads` command has done its usual `ThreadGroup` traversal, it now also dumps all the vthreads. This is pretty much all hidden in `ThreadIterator.next()`, which automically transitions to getting threads from the vthread list after traversing all the `ThreadGroups`. > > `nsk/share/jdb/Jdb.java`: Added support for `getThreadIdsByName()`: There are many jdb tests that use `Jdb.getThreadIds()` to get all threads in the `threads` output that are an instance of ``. The problem is that after converting a test to support a vthread mode for all debuggee threads, the name of the class in the output will always be `java.lang.VirtualThread` (or `java.lang.Thread` when not in vthread mode), and not the test specific class name, which is usually something like `MyThread`. Making `getThreadIds()` search for `java.lang.VirtualThreads` usually ends up including threads not wanted (ones that are not `MyThread`) such as the main test thread. So `getThreadIdsByName()` was added to allow searching by the thread name (actually just the prefix of the name) rather than its class. As an example, the `threads` command output used to contain a line such as: > > ` (nsk.jdb.kill.kill001.MyThread)693 Thread-0 waiting in a monitor` > > Now it contains: > > ` (java.lang.Thread)693 MyThread-0 waiting in a monitor` > > So instead of searching for ?(MyThread)? and grabbing the threadId that comes right after it, `getThreadIdsByName()` first finds all the lines of output that contain ?nsk.jdb.kill.kill001.MyThread?, and then for those lines only gets the threadID that is right after ?(java.lang.Thread)? or ?(java.lang.VirtualThread)?. > > jdb `kill001` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. Use new `getThreadIdsByName()` support instead of `getThreadIds()`. Allow/expect the `kill` command to fail with "Illegal thread state? when in vthread mode. > > jdb `threads002` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. I forget why I decided to convert this test. Seems it was useful for testing something I was working on for this PR, but I can?t recall. Maybe it was so I could clone it for the new `threads003` test below. > > jdb `trace001` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. This is a test I had converted long ago when I first experimented with the `getThreadIdsByName()` support, so I included it with this PR. > > jdb `threads003` test: This is a new thread test that tests jdb?s ability to learn about a thread when an event arrives on it. It creates 5 threads, two of which receive a breakpoint. It looks at the `threads` output and checks that only those two vthreads are present. I also used this test to help confirm that the `ThreadDeath` events are only received for these two vthreads. This was done manually by looking for the ?TDR removed? output generated by `EventHandler.threadDeathEvent()`. I didn?t put this into the test itself since that println is just for debugging and is now commented out. Chris Plummer has updated the pull request incrementally with one additional commit since the last revision: Put -verbose on a new line. ------------- Changes: - all: https://git.openjdk.java.net/loom/pull/97/files - new: https://git.openjdk.java.net/loom/pull/97/files/d6d13846..d0b3a29c Webrevs: - full: https://webrevs.openjdk.java.net/?repo=loom&pr=97&range=03 - incr: https://webrevs.openjdk.java.net/?repo=loom&pr=97&range=02-03 Stats: 6 lines in 3 files changed: 3 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/loom/pull/97.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/97/head:pull/97 PR: https://git.openjdk.java.net/loom/pull/97 From cjplummer at openjdk.java.net Tue Mar 8 20:41:26 2022 From: cjplummer at openjdk.java.net (Chris Plummer) Date: Tue, 8 Mar 2022 20:41:26 GMT Subject: RFR: Better jdb support for vthreads. Improved jdb vthread testing support. [v5] In-Reply-To: References: Message-ID: > This PR contains a set of some what disparate but related set of changes to JDB, JDI, and nsk jdb tests and test support (Jdb.java). > > jdb: Made the ?kill? command support `ThreadReference.stop()` throwing `IllegalThreadStateException` for vthreads, because this is how `ThreadReference.stop()` is now spec?d. This change is in `Commands.java`. The rest of the changes are just cleanup. One of the changes in the `kill001` test is to test for this (see below) > > jdb: Use `PlatformThreadOnlyFilters` to prevent `ThreadStart/Death` event for vthreads. Instead detect vthreads when events are received on them. The goal here is to prevent jdb from getting a flood of `ThreadStart/Death` events, and getting bogged down with them. With the `PlatformThreadOnlyFilters` in place, this means jdb is not notified when a vthread dies, even one that it learned about later when an event came in on it. For these each of these ?learned? vthreads a separate `ThreadDeathRequest` is needed that uses the thread itself as a `ThreadFilter`. This way jdb can tell when these vthreads die. This part is handled in `EventHandler.java`. `VMConnection.java` is where `PlatformThreadOnlyFilters` are added. > > jdb: Add `-trackallvthreads` option. This prevents the use of the `PlatformThreadsOnlyFilters` described above, and instead relies on jdb getting the initial set of vthreads from the debug agent via `VM.allThreads()` (by turning on the `enumeratevthreads` option), and by getting a `ThreadStart/Death` event for every vthread created/destroyed after connecting. This is basially how jdb used to work by default before any changes in this PR. There are 3 tests that rely on this behaviour and need this flag. They are `kill001`, `threads002`, and `trace001` (see below). Many more would rely on it if they were converted to use vthreads as these tests were. The bulk of the changes for this support comes from having to pass `trackAllVthreads` through all sorts of constuctors/inits. I wish there were a better way, but I couldn?t find a place to store this value as a static so it is easy to access. If you see a better way, let me know. > > jdb: Track vthreads separately. jdb keeps track of every thread by creating a `ThreadInfo` for each and storing it in a `List` called `threads`. I decided to store vthreads in a separate list. The reason is the list is needed by the `threads` command. It doesn?t use the `threads` list, but instead walks the `ThreadGroup` hierarchy and prints out the threads within each `ThreadGroup`. This doesn?t capture vthreads since they are not returned by `ThreadGroupReference.threads()`, even for the `VirtualThreads` group. So after the `threads` command has done its usual `ThreadGroup` traversal, it now also dumps all the vthreads. This is pretty much all hidden in `ThreadIterator.next()`, which automically transitions to getting threads from the vthread list after traversing all the `ThreadGroups`. > > `nsk/share/jdb/Jdb.java`: Added support for `getThreadIdsByName()`: There are many jdb tests that use `Jdb.getThreadIds()` to get all threads in the `threads` output that are an instance of ``. The problem is that after converting a test to support a vthread mode for all debuggee threads, the name of the class in the output will always be `java.lang.VirtualThread` (or `java.lang.Thread` when not in vthread mode), and not the test specific class name, which is usually something like `MyThread`. Making `getThreadIds()` search for `java.lang.VirtualThreads` usually ends up including threads not wanted (ones that are not `MyThread`) such as the main test thread. So `getThreadIdsByName()` was added to allow searching by the thread name (actually just the prefix of the name) rather than its class. As an example, the `threads` command output used to contain a line such as: > > ` (nsk.jdb.kill.kill001.MyThread)693 Thread-0 waiting in a monitor` > > Now it contains: > > ` (java.lang.Thread)693 MyThread-0 waiting in a monitor` > > So instead of searching for ?(MyThread)? and grabbing the threadId that comes right after it, `getThreadIdsByName()` first finds all the lines of output that contain ?nsk.jdb.kill.kill001.MyThread?, and then for those lines only gets the threadID that is right after ?(java.lang.Thread)? or ?(java.lang.VirtualThread)?. > > jdb `kill001` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. Use new `getThreadIdsByName()` support instead of `getThreadIds()`. Allow/expect the `kill` command to fail with "Illegal thread state? when in vthread mode. > > jdb `threads002` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. I forget why I decided to convert this test. Seems it was useful for testing something I was working on for this PR, but I can?t recall. Maybe it was so I could clone it for the new `threads003` test below. > > jdb `trace001` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. This is a test I had converted long ago when I first experimented with the `getThreadIdsByName()` support, so I included it with this PR. > > jdb `threads003` test: This is a new thread test that tests jdb?s ability to learn about a thread when an event arrives on it. It creates 5 threads, two of which receive a breakpoint. It looks at the `threads` output and checks that only those two vthreads are present. I also used this test to help confirm that the `ThreadDeath` events are only received for these two vthreads. This was done manually by looking for the ?TDR removed? output generated by `EventHandler.threadDeathEvent()`. I didn?t put this into the test itself since that println is just for debugging and is now commented out. Chris Plummer has updated the pull request incrementally with two additional commits since the last revision: - Improved instanceof usage. - Minor cleanup of code structure ------------- Changes: - all: https://git.openjdk.java.net/loom/pull/97/files - new: https://git.openjdk.java.net/loom/pull/97/files/d0b3a29c..344a30df Webrevs: - full: https://webrevs.openjdk.java.net/?repo=loom&pr=97&range=04 - incr: https://webrevs.openjdk.java.net/?repo=loom&pr=97&range=03-04 Stats: 8 lines in 2 files changed: 2 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/loom/pull/97.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/97/head:pull/97 PR: https://git.openjdk.java.net/loom/pull/97 From cjplummer at openjdk.java.net Tue Mar 8 20:41:29 2022 From: cjplummer at openjdk.java.net (Chris Plummer) Date: Tue, 8 Mar 2022 20:41:29 GMT Subject: RFR: Better jdb support for vthreads. Improved jdb vthread testing support. [v3] In-Reply-To: References: Message-ID: On Tue, 8 Mar 2022 15:29:04 GMT, Alex Menkov wrote: >> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision: >> >> Minor comment changes. > > test/hotspot/jtreg/vmTestbase/nsk/jdb/kill/kill001/kill001.java line 133: > >> 131: // Continue each of the threads that received the "kill" exception. Not needed >> 132: // for the vthread case since they are not actually killed. >> 133: if (!vthreadMode) for (int i = 0; i < numThreads; i++) { > > if and for at the same line don't look good ok ------------- PR: https://git.openjdk.java.net/loom/pull/97 From haosun at openjdk.java.net Wed Mar 9 06:54:43 2022 From: haosun at openjdk.java.net (Hao Sun) Date: Wed, 9 Mar 2022 06:54:43 GMT Subject: RFR: 8282792: Loom: Fix optimized build after commit 4d2710 Message-ID: In commit 4d2710[1], one invocation of function print_frames() is moved from condition `!PRODUCT` to condition `ASSERT`. As a result, all the usages are now under condition `ASSERT`, leading to the compilation warning "unused-function" in optimized VM build. Hence, in this patch, we move the defintion of function print_frames() to condition `ASSERT`. [1] https://github.com/openjdk/loom/commit/4d2710#diff-74c5a41cb3476b29151b4a13732cf4756879de0aa1b1d8c4d73c38e570413fcfR2851 ------------- Commit messages: - 8282792: Loom: Fix optimized build after commit 4d2710 Changes: https://git.openjdk.java.net/loom/pull/98/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=98&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282792 Stats: 50 lines in 1 file changed: 25 ins; 25 del; 0 mod Patch: https://git.openjdk.java.net/loom/pull/98.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/98/head:pull/98 PR: https://git.openjdk.java.net/loom/pull/98 From haosun at openjdk.java.net Wed Mar 9 06:54:43 2022 From: haosun at openjdk.java.net (Hao Sun) Date: Wed, 9 Mar 2022 06:54:43 GMT Subject: RFR: 8282792: Loom: Fix optimized build after commit 4d2710 In-Reply-To: References: Message-ID: <_NlxT1HqvtJ6qKDSm_1s5fQ9CMc6R120jpw1TOynR2s=.06518901-8bcc-4378-854e-ad7b4e3d5c98@github.com> On Wed, 9 Mar 2022 06:48:49 GMT, Hao Sun wrote: > In commit 4d2710[1], one invocation of function print_frames() is moved > from condition `!PRODUCT` to condition `ASSERT`. As a result, all the > usages are now under condition `ASSERT`, leading to the compilation > warning "unused-function" in optimized VM build. > > Hence, in this patch, we move the defintion of function print_frames() > to condition `ASSERT`. > > [1] https://github.com/openjdk/loom/commit/4d2710#diff-74c5a41cb3476b29151b4a13732cf4756879de0aa1b1d8c4d73c38e570413fcfR2851 As shown in https://github.com/shqking/loom/runs/5475434690?check_suite_focus=true, optimized build can pass with this patch. ------------- PR: https://git.openjdk.java.net/loom/pull/98 From duke at openjdk.java.net Wed Mar 9 09:29:37 2022 From: duke at openjdk.java.net (duke) Date: Wed, 9 Mar 2022 09:29:37 GMT Subject: git: openjdk/loom: fibers: 5 new changesets Message-ID: Changeset: 1618e6cd Author: Alan Bateman Date: 2022-03-08 17:01:05 +0000 URL: https://git.openjdk.java.net/loom/commit/1618e6cd17d0e526c429764e0cb3f861ff107584 Improve javadoc ! src/java.base/share/classes/java/lang/Thread.java Changeset: ac3ed3f7 Author: Alan Bateman Date: 2022-03-08 17:21:18 +0000 URL: https://git.openjdk.java.net/loom/commit/ac3ed3f7aa31bfcefe65e2b0508762ed4df5ad5e Avoid loading Thread.State ! src/java.base/share/classes/java/lang/Thread.java Changeset: 7298aa60 Author: Alan Bateman Date: 2022-03-08 19:39:19 +0000 URL: https://git.openjdk.java.net/loom/commit/7298aa60b09db9732da6b23c9d98de880d4dc259 Combine two holder classes ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/vmClassMacros.hpp ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrThreadGroup.cpp ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeManager.cpp ! src/hotspot/share/prims/jvmtiEnv.cpp ! src/java.base/share/classes/java/lang/Thread.java ! src/java.base/share/classes/java/lang/ThreadLocal.java Changeset: 23f70cb1 Author: Alan Bateman Date: 2022-03-09 07:51:38 +0000 URL: https://git.openjdk.java.net/loom/commit/23f70cb14fa87490e5c0cee46ec08ce04402f908 priority should be volatile ! src/java.base/share/classes/java/lang/Thread.java Changeset: ac2866a2 Author: Alan Bateman Date: 2022-03-09 09:20:08 +0000 URL: https://git.openjdk.java.net/loom/commit/ac2866a24961d1217392b4cc1bf52ee4ee83d73d Fix typo in comment ! src/hotspot/share/prims/jvmtiEnv.cpp From duke at openjdk.java.net Wed Mar 9 12:35:54 2022 From: duke at openjdk.java.net (duke) Date: Wed, 9 Mar 2022 12:35:54 GMT Subject: git: openjdk/loom: fibers: Cleanup Message-ID: <10a5d311-6fd7-4878-9f0e-fbe8220a70f2@openjdk.java.net> Changeset: 6b9fe1fa Author: Ron Pressler Date: 2022-03-09 12:35:19 +0000 URL: https://git.openjdk.java.net/loom/commit/6b9fe1faeec1843f7802778c8da93b04ff948809 Cleanup ! src/hotspot/cpu/aarch64/instanceStackChunkKlass_aarch64.inline.hpp ! src/hotspot/cpu/x86/instanceStackChunkKlass_x86.inline.hpp ! src/hotspot/share/code/codeCache.cpp ! src/hotspot/share/compiler/oopMap.cpp ! src/hotspot/share/runtime/frame.cpp From haosun at openjdk.java.net Wed Mar 9 12:38:43 2022 From: haosun at openjdk.java.net (Hao Sun) Date: Wed, 9 Mar 2022 12:38:43 GMT Subject: RFR: 8282849: Loom: Fix minimal debug non-PCH build failure Message-ID: As described in JBS-8282849, this build failure was introduced by commit bd25c94 and commit 4d27102. Adding the missing headers would fix it. ------------- Commit messages: - 8282849: Loom: Fix minimal debug non-PCH build failure Changes: https://git.openjdk.java.net/loom/pull/99/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=99&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282849 Stats: 6 lines in 2 files changed: 6 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/loom/pull/99.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/99/head:pull/99 PR: https://git.openjdk.java.net/loom/pull/99 From rpressler at openjdk.java.net Wed Mar 9 14:31:29 2022 From: rpressler at openjdk.java.net (Ron Pressler) Date: Wed, 9 Mar 2022 14:31:29 GMT Subject: RFR: 8282849: Loom: Fix minimal debug non-PCH build failure In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 12:32:37 GMT, Hao Sun wrote: > As described in JBS-8282849, this build failure was introduced by commit > bd25c94 and commit 4d27102. Adding the missing headers would fix it. Marked as reviewed by rpressler (Lead). ------------- PR: https://git.openjdk.java.net/loom/pull/99 From duke at openjdk.java.net Wed Mar 9 20:28:34 2022 From: duke at openjdk.java.net (duke) Date: Wed, 9 Mar 2022 20:28:34 GMT Subject: git: openjdk/loom: fibers: 5 new changesets Message-ID: <395d90c4-2a7f-48fe-986b-db1ccebc9876@openjdk.java.net> Changeset: 65fa4abe Author: Alan Bateman Date: 2022-03-09 13:13:10 +0000 URL: https://git.openjdk.java.net/loom/commit/65fa4abe24241eac400c5a865d9991262da92acf gc tests passing with -Xcomp ! test/hotspot/jtreg/ProblemList-Xcomp.txt Changeset: b68e54f0 Author: Alan Bateman Date: 2022-03-09 13:13:23 +0000 URL: https://git.openjdk.java.net/loom/commit/b68e54f0b3dfffe8f7fd086a8b5c6020db7b0ee5 More adjustment to startup ! src/hotspot/share/runtime/thread.cpp ! src/java.base/share/classes/java/lang/System.java ! src/java.base/share/classes/java/lang/ref/Reference.java Changeset: 68819ed1 Author: Alan Bateman Date: 2022-03-09 13:17:43 +0000 URL: https://git.openjdk.java.net/loom/commit/68819ed1cf2b0b4c22b7d4f480493b2cb87ba073 Exclude two JFR tests to avoid noise with wrapper runs ! test/jdk/ProblemList-vthread.txt Changeset: aa8e9f6e Author: Alan Bateman Date: 2022-03-09 15:43:42 +0000 URL: https://git.openjdk.java.net/loom/commit/aa8e9f6efc25d0519264b20ab4e2e0fd648ccd7b Cleanup ! src/java.base/share/classes/jdk/internal/misc/CarrierThread.java ! src/java.base/share/classes/jdk/internal/misc/ThreadFlock.java ! src/java.base/share/classes/sun/nio/ch/PollerProvider.java Changeset: 28179fc3 Author: Alan Bateman Date: 2022-03-09 17:06:28 +0000 URL: https://git.openjdk.java.net/loom/commit/28179fc37ba39147accdf7ba1e285ce1de8ce50b Remove gate, cleanup ! src/java.base/share/classes/java/lang/System.java ! src/java.base/share/classes/java/net/URL.java ! src/java.base/share/classes/java/nio/charset/Charset.java ! src/java.base/share/classes/java/util/jar/JarFile.java - src/java.base/share/classes/jdk/internal/misc/Gate.java ! src/java.base/share/classes/sun/nio/ch/SelChImpl.java From duke at openjdk.java.net Wed Mar 9 22:48:12 2022 From: duke at openjdk.java.net (duke) Date: Wed, 9 Mar 2022 22:48:12 GMT Subject: git: openjdk/loom: fibers: Fix comment. Message-ID: <09c73b6e-2ea2-4961-9a71-66cad1f067ca@openjdk.java.net> Changeset: fd66df78 Author: Chris Plummer Date: 2022-03-08 20:11:15 +0000 URL: https://git.openjdk.java.net/loom/commit/fd66df78c2174bfe958c6f911d47d6b32fde57c1 Fix comment. ! src/jdk.jdwp.agent/share/native/libjdwp/eventHandler.c ! src/jdk.jdwp.agent/share/native/libjdwp/threadControl.c From duke at openjdk.java.net Thu Mar 10 08:19:54 2022 From: duke at openjdk.java.net (duke) Date: Thu, 10 Mar 2022 08:19:54 GMT Subject: git: openjdk/loom: fibers: fix Kitchensink failures related to interp_only_mode and SetEventNotificationMode Message-ID: Changeset: 3ed231df Author: Serguei Spitsyn Date: 2022-03-10 08:17:15 +0000 URL: https://git.openjdk.java.net/loom/commit/3ed231df10e1db8ad6261885a1831421bf02035a fix Kitchensink failures related to interp_only_mode and SetEventNotificationMode ! src/hotspot/share/prims/jvmtiEnv.cpp ! src/hotspot/share/prims/jvmtiEnvThreadState.cpp ! src/hotspot/share/prims/jvmtiThreadState.cpp From duke at openjdk.java.net Thu Mar 10 10:11:44 2022 From: duke at openjdk.java.net (duke) Date: Thu, 10 Mar 2022 10:11:44 GMT Subject: git: openjdk/loom: fibers: VirtualThread injected field for JFR epoch Message-ID: <84e686ba-60bf-4912-84d3-bec8baf02c59@openjdk.java.net> Changeset: 1a86eb32 Author: mgronlun Date: 2022-03-10 10:44:48 +0000 URL: https://git.openjdk.java.net/loom/commit/1a86eb32ae75b7efc575afe656828fe5d785276e VirtualThread injected field for JFR epoch ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/javaClasses.inline.hpp ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/jfr/jfr.cpp ! src/hotspot/share/jfr/jfr.hpp ! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrOopTraceId.hpp ! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrOopTraceId.inline.hpp ! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdEpoch.hpp ! src/hotspot/share/jfr/recorder/jfrRecorder.cpp ! src/hotspot/share/jfr/support/jfrIntrinsics.cpp ! src/hotspot/share/jfr/support/jfrIntrinsics.hpp ! src/hotspot/share/jfr/support/jfrThreadExtension.hpp ! src/hotspot/share/jfr/support/jfrThreadId.inline.hpp ! src/hotspot/share/jfr/support/jfrThreadLocal.cpp ! src/hotspot/share/jfr/support/jfrThreadLocal.hpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/services/threadIdTable.cpp ! src/java.base/share/classes/java/lang/Thread.java From duke at openjdk.java.net Thu Mar 10 12:14:48 2022 From: duke at openjdk.java.net (duke) Date: Thu, 10 Mar 2022 12:14:48 GMT Subject: git: openjdk/loom: fibers: JDK-8282877 Message-ID: <21cd2003-2047-4cb0-aec8-5479a8258f97@openjdk.java.net> Changeset: c3383c81 Author: mgronlun Date: 2022-03-10 13:13:15 +0000 URL: https://git.openjdk.java.net/loom/commit/c3383c81c43721d8502b2b13eb72c5544d225418 JDK-8282877 ! src/hotspot/share/jfr/utilities/jfrTypes.hpp ! src/hotspot/share/runtime/objectMonitor.cpp ! src/hotspot/share/runtime/vmThread.cpp ! test/jdk/ProblemList-vthread.txt From duke at openjdk.java.net Thu Mar 10 12:37:31 2022 From: duke at openjdk.java.net (duke) Date: Thu, 10 Mar 2022 12:37:31 GMT Subject: git: openjdk/loom: fibers: 74 new changesets Message-ID: <506af215-7823-44a6-a377-b29e4d99642d@openjdk.java.net> Changeset: b6c35ae4 Author: Magnus Ihse Bursie Date: 2022-03-02 18:17:47 +0000 URL: https://git.openjdk.java.net/loom/commit/b6c35ae44aeb31deb7a15ee2939156ed00b3df52 8209784: Include hsdis in the JDK Reviewed-by: erikj ! make/Hsdis.gmk ! make/Main.gmk ! make/autoconf/configure.ac ! make/autoconf/jdk-options.m4 + make/autoconf/lib-hsdis.m4 ! make/autoconf/libraries.m4 ! make/autoconf/spec.gmk.in ! make/modules/java.base/Copy.gmk Changeset: 1485883c Author: Weijun Wang Date: 2022-03-03 00:39:39 +0000 URL: https://git.openjdk.java.net/loom/commit/1485883c9e6e24315bb21f20604b1c326e862a5b 8281628: KeyAgreement : generateSecret intermittently not resetting Reviewed-by: valeriep ! src/java.base/share/classes/com/sun/crypto/provider/DHKeyAgreement.java + test/jdk/com/sun/crypto/provider/KeyAgreement/DHKeyAgreementPadding.java Changeset: 02aa7cef Author: Mandy Chung Date: 2022-03-03 01:50:02 +0000 URL: https://git.openjdk.java.net/loom/commit/02aa7cef0a9b9de1ee9a136c5641b498c0c3e5cc 8282515: More clean up on NativeLibraries just for JNI library use Reviewed-by: mcimadamore ! src/java.base/share/classes/jdk/internal/loader/NativeLibraries.java ! src/java.base/share/classes/jdk/internal/loader/RawNativeLibraries.java ! src/java.base/share/native/libjava/NativeLibraries.c + src/java.base/share/native/libjava/RawNativeLibraries.c ! test/jdk/jdk/internal/loader/NativeLibraries/Main.java ! test/jdk/jdk/internal/loader/NativeLibraries/java.base/jdk/internal/loader/NativeLibrariesTest.java Changeset: d0eb6fa2 Author: Srinivas Mandalika Committer: Abdul Kolarkunnu Date: 2022-03-03 03:26:10 +0000 URL: https://git.openjdk.java.net/loom/commit/d0eb6fa2204c4112ef57ffa7579e209ebee62551 8281569: Create tests for Frame.setMinimumSize() method Reviewed-by: aivanov + test/jdk/java/awt/Frame/SetMinimumSizeTest/SetMinimumSizeTest1.java + test/jdk/java/awt/Frame/SetMinimumSizeTest/SetMinimumSizeTest2.java Changeset: 2da67779 Author: Christian Hagedorn Date: 2022-03-03 07:17:56 +0000 URL: https://git.openjdk.java.net/loom/commit/2da677793f562236d473afe12b5c941f25f41377 8281122: [IR Framework] Cleanup IR matching code in preparation for JDK-8280378 Reviewed-by: thartmann, kvn ! test/hotspot/jtreg/compiler/lib/ir_framework/IR.java ! test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java ! test/hotspot/jtreg/compiler/lib/ir_framework/TestFramework.java - test/hotspot/jtreg/compiler/lib/ir_framework/driver/IRMatcher.java - test/hotspot/jtreg/compiler/lib/ir_framework/driver/IRMethod.java ! test/hotspot/jtreg/compiler/lib/ir_framework/driver/TestVMProcess.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/CompilationOutputBuilder.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/IRMatcher.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/IRMatcherFailureMessageBuilder.java = test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/IRViolationException.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/MatchResult.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/OutputMatch.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irmethod/FailureMessageBuilder.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irmethod/IRMethod.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irmethod/IRMethodMatchResult.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irmethod/MatchedCompilationOutputBuilder.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irmethod/MissingCompilationMessageBuilder.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irmethod/MissingCompilationResult.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irmethod/NormalFailureMessageBuilder.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irmethod/NormalMatchResult.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irrule/CheckAttribute.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irrule/CheckAttributeMatchResult.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irrule/Counts.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irrule/CountsMatchResult.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irrule/CountsRegexFailure.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irrule/FailOn.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irrule/FailOnMatchResult.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irrule/FailOnRegexFailure.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irrule/IRRule.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irrule/IRRuleMatchResult.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irrule/RegexFailure.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/parser/AbstractLine.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/parser/BlockLine.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/parser/BlockOutputReader.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/parser/FileCorruptedException.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/parser/HotSpotPidFileParser.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/parser/IREncodingParser.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/parser/IRMethodParser.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/parser/Line.java + test/hotspot/jtreg/compiler/lib/ir_framework/shared/Comparison.java + test/hotspot/jtreg/compiler/lib/ir_framework/shared/ComparisonConstraintParser.java + test/hotspot/jtreg/compiler/lib/ir_framework/shared/EmptyConstraintException.java + test/hotspot/jtreg/compiler/lib/ir_framework/shared/InvalidComparatorException.java + test/hotspot/jtreg/compiler/lib/ir_framework/shared/InvalidConstraintValueException.java + test/hotspot/jtreg/compiler/lib/ir_framework/shared/MissingConstraintValueException.java - test/hotspot/jtreg/compiler/lib/ir_framework/shared/ParsedComparator.java ! test/hotspot/jtreg/compiler/lib/ir_framework/shared/TestFormat.java + test/hotspot/jtreg/compiler/lib/ir_framework/shared/UnreachableCodeException.java ! test/hotspot/jtreg/compiler/lib/ir_framework/test/IREncodingPrinter.java ! test/hotspot/jtreg/compiler/lib/ir_framework/test/TestVM.java ! test/hotspot/jtreg/compiler/vectorapi/TestMaskedMacroLogicVector.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/examples/IRExample.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestCheckedTests.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestCompileThreshold.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestIRMatching.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestRunTests.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/Utils.java Changeset: b1f935c1 Author: Tobias Holenstein Committer: Tobias Hartmann Date: 2022-03-03 07:59:45 +0000 URL: https://git.openjdk.java.net/loom/commit/b1f935c1d0d3729470b57832cf74c43d49ea1f71 8277055: Assert "missing inlining msg" with -XX:+PrintIntrinsics Reviewed-by: roland, thartmann ! src/hotspot/share/opto/callGenerator.cpp ! test/hotspot/jtreg/compiler/print/PrintInlining.java Changeset: d4d1fbc2 Author: Thomas Schatzl Date: 2022-03-03 09:26:41 +0000 URL: https://git.openjdk.java.net/loom/commit/d4d1fbc27a2382d8d9545b7bf672cdcc81654404 8282484: G1: Predicted old time in log always zero Reviewed-by: ayang, iwalulya ! src/hotspot/share/gc/g1/g1Policy.cpp Changeset: 0402a288 Author: Prasanta Sadhukhan Date: 2022-03-03 09:51:08 +0000 URL: https://git.openjdk.java.net/loom/commit/0402a288f309d589d1dc8860e95e4ed42a1ef9f4 8037965: NullPointerException in TextLayout.getBaselineFromGraphic() for JTextComponents Reviewed-by: prr, aivanov ! src/java.desktop/share/classes/java/awt/font/TextLayout.java + test/jdk/javax/swing/JTextField/SwingUnicodeTest.java Changeset: 832729b4 Author: Prasanta Sadhukhan Date: 2022-03-03 09:53:14 +0000 URL: https://git.openjdk.java.net/loom/commit/832729b41e690d6f05da71997bbe2a74b2d6dada 6911375: mouseWheel has no effect without vertical scrollbar Reviewed-by: aivanov ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicScrollPaneUI.java + test/jdk/javax/swing/JScrollPane/TestMouseWheelScroll.java Changeset: 7822cbce Author: Coleen Phillimore Date: 2022-03-03 13:20:58 +0000 URL: https://git.openjdk.java.net/loom/commit/7822cbce10e0c0c6f9bf521faebc89a0af20734e 8276711: compiler/codecache/cli tests failing when SegmentedCodeCache used with -Xint Reviewed-by: kvn, dholmes ! src/hotspot/share/code/codeCache.cpp ! src/hotspot/share/compiler/compilerDefinitions.cpp ! test/hotspot/jtreg/compiler/codecache/cli/TestSegmentedCodeCacheOption.java ! test/hotspot/jtreg/compiler/codecache/cli/codeheapsize/TestCodeHeapSizeOptions.java ! test/hotspot/jtreg/compiler/codecache/cli/common/CodeCacheCLITestCase.java Changeset: 5c187e34 Author: Thomas Stuefe Date: 2022-03-03 13:25:10 +0000 URL: https://git.openjdk.java.net/loom/commit/5c187e34a58769a129a0aae9e4937907c9060202 8282593: JDK-8281472 breaks 32-bit builds and gtests Reviewed-by: jiefu, dholmes ! test/hotspot/gtest/runtime/test_largeOptions.cpp Changeset: 57020fd5 Author: Jonathan Gibbons Date: 2022-03-03 14:54:02 +0000 URL: https://git.openjdk.java.net/loom/commit/57020fd5822148b02e72b60b462a7402658d979a 8282582: Unused methods in Utils Reviewed-by: prappo ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java Changeset: 080baffa Author: Pavel Rappo Date: 2022-03-03 16:10:18 +0000 URL: https://git.openjdk.java.net/loom/commit/080baffa6e0b27dbbf169d6c68980351aa484b8e 8282483: Ensure that Utils.getAllInterfaces returns unique instances Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java Changeset: c777bb3d Author: Thomas Schatzl Date: 2022-03-03 16:16:44 +0000 URL: https://git.openjdk.java.net/loom/commit/c777bb3df3234faff24b92e55977c7f4ae750647 8282619: G1: Fix indentation in G1CollectedHeap::mark_evac_failure_object Reviewed-by: ayang, iwalulya ! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp Changeset: 268fa693 Author: Xue-Lei Andrew Fan Date: 2022-03-03 19:20:16 +0000 URL: https://git.openjdk.java.net/loom/commit/268fa693188b685de6289927ee5a1e99473a50f6 8282511: Use fixed certificate validation date in SSLExampleCert template Reviewed-by: rhalade ! test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java ! test/jdk/javax/net/ssl/templates/SSLExampleCert.java Changeset: 1581e3fa Author: Manukumar V S Committer: Alexey Ivanov Date: 2022-03-03 19:30:07 +0000 URL: https://git.openjdk.java.net/loom/commit/1581e3faa06358f192799b3a89718028c7f6a24b 8282402: Create a regression test for JDK-4666101 Reviewed-by: aivanov + test/jdk/javax/swing/JEditorPane/4666101/JEditorPaneNavigationTest.java Changeset: fb6b929e Author: Hai-May Chao Date: 2022-03-03 23:01:26 +0000 URL: https://git.openjdk.java.net/loom/commit/fb6b929e6e935baeccfd03a7fbc048cc8b531ce5 8277474: jarsigner does not check if algorithm parameters are disabled Reviewed-by: mullan, weijun ! src/java.base/share/classes/sun/security/util/DisabledAlgorithmConstraints.java ! src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java ! src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources.java + test/jdk/sun/security/tools/jarsigner/CheckAlgParams.java Changeset: 8478173d Author: Joe Wang Date: 2022-03-04 03:15:35 +0000 URL: https://git.openjdk.java.net/loom/commit/8478173d837113bf603aadb614badd461f474250 8282583: Update BCEL md to include the copyright notice Reviewed-by: lancea, iris, naoto ! src/java.xml/share/legal/bcel.md Changeset: 7e1c67d4 Author: Mandy Chung Date: 2022-03-04 03:41:41 +0000 URL: https://git.openjdk.java.net/loom/commit/7e1c67d4af76eba688927a24d711181570e965ef 8282608: RawNativeLibraryImpl can't be passed to NativeLibraries::findEntry0 Reviewed-by: mcimadamore, dholmes ! src/java.base/share/classes/jdk/internal/loader/NativeLibraries.java ! src/java.base/share/classes/jdk/internal/loader/NativeLibrary.java ! src/java.base/share/classes/jdk/internal/loader/RawNativeLibraries.java ! src/java.base/share/native/libjava/NativeLibraries.c Changeset: b629782b Author: Igor Veresov Date: 2022-03-04 03:49:37 +0000 URL: https://git.openjdk.java.net/loom/commit/b629782b8d44e8aa8a99c6a3381663a6169aa1ad 8279886: C1: Turn off SelectivePhiFunctions in presence of irreducible loops Reviewed-by: kvn, dlong ! src/hotspot/share/c1/c1_Compilation.cpp ! src/hotspot/share/c1/c1_Compilation.hpp ! src/hotspot/share/c1/c1_GraphBuilder.cpp ! src/hotspot/share/c1/c1_Instruction.cpp ! src/hotspot/share/c1/c1_Instruction.hpp Changeset: b3837808 Author: Manukumar V S Committer: Alexey Ivanov Date: 2022-03-04 10:56:11 +0000 URL: https://git.openjdk.java.net/loom/commit/b3837808bf13de2aa3d8c6c21cf61baac9baf2b2 8282343: Create a regression test for JDK-4518432 Reviewed-by: aivanov + test/jdk/javax/swing/JTree/4518432/JTreeNodeCopyPasteTest.java Changeset: d5e8e52f Author: Julian Waters Committer: Magnus Ihse Bursie Date: 2022-03-04 12:42:07 +0000 URL: https://git.openjdk.java.net/loom/commit/d5e8e52f02413e02200701fe8dab7a5c6ab5c77b 8282532: Allow explicitly setting build platform alongside --openjdk-target Reviewed-by: ihse ! doc/building.html ! doc/building.md ! make/autoconf/configure Changeset: a584c904 Author: Emanuel Peter Committer: Tobias Hartmann Date: 2022-03-04 12:55:57 +0000 URL: https://git.openjdk.java.net/loom/commit/a584c904a9e386d7ce80fb9cc6d49fece065d3da 8282573: ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y) Reviewed-by: psandoz, thartmann ! test/hotspot/jtreg/compiler/intrinsics/unsafe/ByteBufferTest.java Changeset: 52471539 Author: Thomas Schatzl Date: 2022-03-04 13:40:57 +0000 URL: https://git.openjdk.java.net/loom/commit/52471539c002e38a5c815045913458776381d369 8282615: G1: Fix some includes Reviewed-by: ayang, iwalulya ! src/hotspot/share/gc/g1/g1CardSetContainers.hpp ! src/hotspot/share/gc/g1/g1CardSetContainers.inline.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1EvacFailureRegions.cpp Changeset: 603050bf Author: Emanuel Peter Committer: Paul Sandoz Date: 2022-03-04 16:26:14 +0000 URL: https://git.openjdk.java.net/loom/commit/603050bfe00d7a0185d84acab2a24a803aa86f82 8282661: [BACKOUT] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y) Reviewed-by: chagedorn, psandoz ! test/hotspot/jtreg/compiler/intrinsics/unsafe/ByteBufferTest.java Changeset: f9f9c0a8 Author: Magnus Ihse Bursie Date: 2022-03-04 16:32:58 +0000 URL: https://git.openjdk.java.net/loom/commit/f9f9c0a8552f6815b22893e8984edb58991d4554 8252769: Warn in configure if git config autocrlf has invalid value Reviewed-by: erikj ! make/autoconf/basic_tools.m4 ! make/autoconf/basic_windows.m4 Changeset: 733c7907 Author: Naoto Sato Date: 2022-03-04 16:57:54 +0000 URL: https://git.openjdk.java.net/loom/commit/733c7907b0059cc734fd1aa5b8d31f9c3e2e3079 8282081: java.time.DateTimeFormatter: wrong definition of symbol F Reviewed-by: joehw, scolebourne, lancea, rriggs ! src/java.base/share/classes/java/time/format/DateTimeFormatter.java ! src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java ! test/jdk/java/time/test/java/time/format/TestDateTimeFormatterBuilder.java Changeset: 9c817d38 Author: Damon Nguyen Committer: Alexey Ivanov Date: 2022-03-04 19:26:12 +0000 URL: https://git.openjdk.java.net/loom/commit/9c817d38806708f84139e3180ac86a3805dcce5f 8015854: [macosx] JButton's HTML ImageView adding unwanted padding Reviewed-by: psadhukhan, aivanov ! src/java.desktop/macosx/classes/com/apple/laf/AquaButtonUI.java + test/jdk/javax/swing/JButton/HtmlButtonImageTest/HtmlButtonImageTest.java Changeset: e07fd395 Author: Ioi Lam Date: 2022-03-04 20:14:11 +0000 URL: https://git.openjdk.java.net/loom/commit/e07fd395bdc314867886a621ec76cf74a5f76b89 8281181: Do not use CPU Shares to compute active processor count Reviewed-by: dholmes, sgehwolf ! src/hotspot/os/linux/cgroupSubsystem_linux.cpp ! src/hotspot/os/linux/globals_linux.hpp ! src/hotspot/share/runtime/arguments.cpp ! test/hotspot/jtreg/containers/cgroup/PlainRead.java ! test/hotspot/jtreg/containers/docker/TestCPUAwareness.java ! test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java Changeset: b0028a45 Author: Jonathan Gibbons Date: 2022-03-04 21:01:52 +0000 URL: https://git.openjdk.java.net/loom/commit/b0028a459c7e99b5e4090cc19127f6347fe220ba 8272853: improve `JavadocTester.runTests` Reviewed-by: hannesw ! test/langtools/jdk/javadoc/lib/javadoc/tester/JavadocTester.java + test/langtools/jdk/javadoc/testJavadocTester/TestRunTests.java Changeset: bae0d5e7 Author: TejeshR13 Committer: Phil Race Date: 2022-03-04 22:50:32 +0000 URL: https://git.openjdk.java.net/loom/commit/bae0d5e7174fed8ffa8a30408c3cffa6e4dd3ddc 8236907: JTable added to nested panels does not paint last visible row Reviewed-by: psadhukhan, prr ! src/java.desktop/share/classes/javax/swing/TablePrintable.java ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTableUI.java + test/jdk/javax/swing/JTable/8236907/LastVisibleRow.java Changeset: c459f8f4 Author: wanghaomin Committer: Vladimir Kozlov Date: 2022-03-05 00:01:49 +0000 URL: https://git.openjdk.java.net/loom/commit/c459f8f406a99cf78814bb5722f546ae1cdb6c6f 8282142: [TestCase] compiler/inlining/ResolvedClassTest.java will fail when --with-jvm-features=-compiler1 Reviewed-by: jiefu, kvn ! test/hotspot/jtreg/compiler/inlining/ResolvedClassTest.java Changeset: 52278b80 Author: Mikael Vidstedt Date: 2022-03-05 01:36:02 +0000 URL: https://git.openjdk.java.net/loom/commit/52278b80c4b68af566327cf46b53dda5eda25a51 8282694: ProblemList runtime/CommandLine/VMDeprecatedOptions.java Reviewed-by: jjg ! test/hotspot/jtreg/ProblemList.txt Changeset: bc42e7cb Author: Thomas Stuefe Date: 2022-03-05 06:37:39 +0000 URL: https://git.openjdk.java.net/loom/commit/bc42e7cbbfd586308338bfdf535c4fcab0cdbc48 8282382: Report glibc malloc tunables in error reports Reviewed-by: zgu, dholmes ! src/hotspot/os/linux/os_linux.cpp Changeset: 974ef554 Author: Jaikiran Pai Date: 2022-03-06 08:16:39 +0000 URL: https://git.openjdk.java.net/loom/commit/974ef5542fe52f9cb8ffd8751df8a020bca503c9 8282617: sun.net.www.protocol.https.HttpsClient#putInKeepAliveCache() doesn't use a lock while dealing with "inCache" field Reviewed-by: dfuchs, michaelm ! src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java Changeset: 415bf441 Author: Masanori Yano Date: 2022-03-06 23:53:50 +0000 URL: https://git.openjdk.java.net/loom/commit/415bf44191632cd8dbcc158c0ff0992c0b61c3ba 8275715: D3D pipeline processes multiple PaintEvent at initial drawing Reviewed-by: prr ! src/java.desktop/windows/classes/sun/java2d/d3d/D3DScreenUpdateManager.java + test/jdk/sun/java2d/DirectX/MultiPaintEventTest/MultiPaintEventTest.java Changeset: 894ffb09 Author: Masanori Yano Date: 2022-03-07 01:33:41 +0000 URL: https://git.openjdk.java.net/loom/commit/894ffb098c80bfeb4209038c017d01dbf53fac0f 8282713: Invalid copyright notice in new test added by JDK-8275715 Reviewed-by: dholmes ! test/jdk/sun/java2d/DirectX/MultiPaintEventTest/MultiPaintEventTest.java Changeset: 6fc73f70 Author: Thomas Schatzl Date: 2022-03-07 13:52:19 +0000 URL: https://git.openjdk.java.net/loom/commit/6fc73f709ba9a7f4810027f6c888b63a4604f004 8282620: G1/Parallel: Constify is_in_young() predicates Reviewed-by: iwalulya, ayang ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.inline.hpp Changeset: 104e3cb2 Author: Joe Darcy Date: 2022-03-07 14:47:52 +0000 URL: https://git.openjdk.java.net/loom/commit/104e3cb24b4de5512abf9f5491f9c530b26838d3 8282696: Add constructors taking a cause to InvalidObjectException and InvalidClassException Reviewed-by: lancea ! src/java.base/share/classes/java/io/InvalidClassException.java ! src/java.base/share/classes/java/io/InvalidObjectException.java ! src/java.base/share/classes/java/io/ObjectInputStream.java ! src/java.base/share/classes/java/io/ObjectStreamClass.java ! src/java.base/share/classes/java/io/ObjectStreamException.java + test/jdk/java/io/Serializable/InvalidClassException/TestIceConstructors.java + test/jdk/java/io/Serializable/InvalidObjectException/TestIoeConstructors.java Changeset: e544e354 Author: Ivan Walulya Date: 2022-03-07 15:05:42 +0000 URL: https://git.openjdk.java.net/loom/commit/e544e354a425a242f23cee1049d6ba31b30740e0 8282621: G1: G1SegmentedArray remove unnecessary template parameter Reviewed-by: kbarrett, tschatzl ! src/hotspot/share/gc/g1/g1CardSetMemory.cpp ! src/hotspot/share/gc/g1/g1CardSetMemory.hpp ! src/hotspot/share/gc/g1/g1CardSetMemory.inline.hpp ! src/hotspot/share/gc/g1/g1SegmentedArray.hpp ! src/hotspot/share/gc/g1/g1SegmentedArray.inline.hpp Changeset: 8e70f4c3 Author: Aleksey Shipilev Date: 2022-03-07 15:23:10 +0000 URL: https://git.openjdk.java.net/loom/commit/8e70f4c3dca4cefe813c5b0fd39c386230ca2fd7 8282224: Correct TIG::bang_stack_shadow_pages comments Reviewed-by: coleenp ! src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp Changeset: f0995abe Author: Lance Andersen Date: 2022-03-07 16:10:31 +0000 URL: https://git.openjdk.java.net/loom/commit/f0995abe62b81cf9c96cc07caa0ac27d00c96ff1 8280404: Unexpected exception thrown when CEN file entry comment length is not valid Reviewed-by: alanb ! src/java.base/share/classes/java/util/zip/ZipFile.java + test/jdk/java/util/zip/ZipFile/InvalidCommentLengthTest.java Changeset: ef266d77 Author: Roland Westrelin Date: 2022-03-07 16:26:19 +0000 URL: https://git.openjdk.java.net/loom/commit/ef266d77b6eb54d7e30a0aafd8a3e8c8f4f0e43a 8278296: Generalize long range check transformation Reviewed-by: jrose, thartmann ! src/hotspot/share/opto/loopPredicate.cpp ! src/hotspot/share/opto/loopTransform.cpp ! src/hotspot/share/opto/loopnode.cpp ! src/hotspot/share/opto/loopnode.hpp ! src/hotspot/share/opto/node.hpp ! test/hotspot/jtreg/compiler/c2/irTests/TestLongRangeChecks.java ! test/hotspot/jtreg/compiler/rangechecks/TestLongRangeCheck.java Changeset: 7194097b Author: Kim Barrett Date: 2022-03-07 17:35:21 +0000 URL: https://git.openjdk.java.net/loom/commit/7194097bcae7e0fd32488834277bb18cb97cea8b 8252577: HotSpot Style Guide should link to One-True-Brace-Style description Reviewed-by: stuefe, dcubed, dholmes ! doc/hotspot-style.html ! doc/hotspot-style.md Changeset: 1faa5c80 Author: Joe Darcy Date: 2022-03-07 17:52:04 +0000 URL: https://git.openjdk.java.net/loom/commit/1faa5c8092f8baec3ca08ed059653876ec46db46 8282686: Add constructors taking a cause to SocketException Reviewed-by: alanb, xuelei, lancea, dfuchs ! src/java.base/share/classes/java/net/DatagramSocket.java ! src/java.base/share/classes/java/net/SocketException.java ! src/java.base/share/classes/javax/net/SocketFactory.java ! src/java.base/share/classes/javax/net/ssl/SSLServerSocketFactory.java ! src/java.base/share/classes/javax/net/ssl/SSLSocketFactory.java ! src/java.base/share/classes/sun/nio/ch/DatagramSocketAdaptor.java + test/jdk/java/net/SocketException/TestSocketExceptionCtor.java Changeset: 5953b229 Author: Kim Barrett Date: 2022-03-07 18:12:14 +0000 URL: https://git.openjdk.java.net/loom/commit/5953b229bf6d7834d575862e7577522ded0b6791 8257589: HotSpot Style Guide should link to rfc7282 Reviewed-by: dcubed, dholmes ! doc/hotspot-style.html ! doc/hotspot-style.md Changeset: 2e298b8b Author: Kim Barrett Date: 2022-03-07 18:20:01 +0000 URL: https://git.openjdk.java.net/loom/commit/2e298b8bf45edc37269b8b70f7784082a8f87306 8272691: Fix HotSpot style guide terminology for "non-local variables" Reviewed-by: dcubed, dholmes ! doc/hotspot-style.html ! doc/hotspot-style.md Changeset: 3996782c Author: Ravi Reddy Committer: Joe Wang Date: 2022-03-07 19:36:54 +0000 URL: https://git.openjdk.java.net/loom/commit/3996782c5af7b0396d5133fab457c507758d9340 8281093: Violating Attribute-Value Normalization in the XML specification 1.0 Reviewed-by: joehw ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityScanner.java Changeset: 5d5bf16b Author: Magnus Ihse Bursie Date: 2022-03-07 19:40:34 +0000 URL: https://git.openjdk.java.net/loom/commit/5d5bf16b0af419781fd336fe33d8eab5adf8be5a 8282567: Improve source-date handling in build system Reviewed-by: erikj, sgehwolf ! doc/building.html ! doc/building.md ! make/InitSupport.gmk ! make/autoconf/configure.ac ! make/autoconf/help.m4 ! make/autoconf/hotspot.m4 ! make/autoconf/jdk-options.m4 ! make/autoconf/spec.gmk.in Changeset: ccad3923 Author: Matteo Baccan Committer: Magnus Ihse Bursie Date: 2022-03-07 21:33:40 +0000 URL: https://git.openjdk.java.net/loom/commit/ccad39237ab860c5c5579537f740177e3f1adcc9 8282657: Code cleanup: removing double semicolons at the end of lines Reviewed-by: lancea, rriggs, ihse, prr, iris, wetmore, darcy, dholmes ! make/jdk/src/classes/build/tools/generatecharacter/CharacterScript.java ! make/langtools/tools/genstubs/GenStubs.java ! src/java.base/share/classes/java/io/File.java ! src/java.base/share/classes/java/util/WeakHashMap.java ! src/java.base/share/classes/sun/util/logging/PlatformLogger.java ! src/java.desktop/share/classes/javax/swing/RepaintManager.java ! src/java.rmi/share/classes/java/rmi/server/LogStream.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/rcache/AuthTime.java ! src/java.sql.rowset/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/XPathParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZGlobals.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/ui/FindInCodeCachePanel.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/ui/FindInHeapPanel.java ! src/jdk.jdeps/share/classes/com/sun/tools/classfile/TypeAnnotation.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/SocketChannelImplInstrumentor.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/tool/JSONWriter.java ! src/jdk.jshell/share/classes/jdk/internal/jshell/tool/Selector.java ! src/utils/LogCompilation/src/main/java/com/sun/hotspot/tools/compiler/LogParser.java ! test/hotspot/jtreg/compiler/codegen/Test6909839.java ! test/hotspot/jtreg/compiler/jvmci/compilerToVM/CompileCodeTestCase.java ! test/hotspot/jtreg/compiler/unsafe/TestMisalignedUnsafeAccess.java ! test/hotspot/jtreg/runtime/cds/appcds/TestCommon.java ! test/hotspot/jtreg/runtime/cds/appcds/customLoader/SameNameInTwoLoadersTest.java ! test/hotspot/jtreg/serviceability/jvmti/Heap/IterateHeapWithEscapeAnalysisEnabled.java ! test/hotspot/jtreg/testlibrary/ctw/src/sun/hotspot/tools/ctw/CtwRunner.java ! test/hotspot/jtreg/vmTestbase/jit/series/series.java ! test/hotspot/jtreg/vmTestbase/nsk/jdb/unmonitor/unmonitor001/unmonitor001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/BScenarios/multithrd/tc02x003.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassObjectReference/reflectedType/reflectype002.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/LocalVariable/isVisible/isvisible001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/frames/frames001.java ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/hotswap/HS203/hs203t002/hs203t002.java ! test/hotspot/jtreg/vmTestbase/nsk/share/jdb/Launcher.java ! test/jdk/com/sun/jdi/ConstantPoolInfo.java ! test/jdk/com/sun/jdi/GenericsTest.java ! test/jdk/java/awt/Component/CompEventOnHiddenComponent/CompEventOnHiddenComponent.java ! test/jdk/java/awt/EmbeddedFrame/EmbeddedFrameGrabTest/EmbeddedFrameGrabTest.java ! test/jdk/java/awt/PrintJob/PrintArcTest/PrintArcTest.java ! test/jdk/java/awt/SplashScreen/GenerateTestImage.java ! test/jdk/java/awt/print/PrinterJob/PrtException.java ! test/jdk/java/io/File/GetXSpace.java ! test/jdk/java/io/File/createTempFile/NameTooLong.java ! test/jdk/java/io/RandomAccessFile/WriteBytesChars.java ! test/jdk/java/lang/invoke/8022701/BogoLoader.java ! test/jdk/java/lang/invoke/accessProtectedSuper/BogoLoader.java ! test/jdk/java/lang/management/RuntimeMXBean/GetSystemProperties.java ! test/jdk/java/net/httpclient/AggregateRequestBodyTest.java ! test/jdk/java/nio/channels/SocketChannel/CloseTimeoutChannel.java ! test/jdk/java/rmi/dgc/dgcImplInsulation/DGCImplInsulation.java ! test/jdk/java/time/tck/java/time/zone/TCKZoneRules.java ! test/jdk/java/util/logging/TestAppletLoggerContext.java ! test/jdk/javax/net/ssl/ServerName/SSLSocketExplorer.java ! test/jdk/javax/net/ssl/ServerName/SSLSocketExplorerFailure.java ! test/jdk/javax/net/ssl/ServerName/SSLSocketExplorerMatchedSNI.java ! test/jdk/javax/net/ssl/ServerName/SSLSocketExplorerUnmatchedSNI.java ! test/jdk/javax/net/ssl/ServerName/SSLSocketExplorerWithCliSNI.java ! test/jdk/javax/net/ssl/ServerName/SSLSocketExplorerWithSrvSNI.java ! test/jdk/javax/sound/midi/Gervill/ModelIdentifier/NewModelIdentifierStringStringInt.java ! test/jdk/javax/sound/midi/Gervill/SoftChannel/NoteOff.java ! test/jdk/javax/sound/midi/Gervill/SoftChannel/NoteOff2.java ! test/jdk/javax/sql/testng/test/rowset/BaseRowSetTests.java ! test/jdk/javax/sql/testng/test/rowset/serial/SQLInputImplTests.java ! test/jdk/javax/sql/testng/test/rowset/serial/SerialArrayTests.java ! test/jdk/javax/sql/testng/test/rowset/serial/SerialExceptionTests.java ! test/jdk/javax/sql/testng/test/rowset/serial/SerialStructTests.java ! test/jdk/jdk/jfr/api/consumer/TestRecordingFile.java ! test/jdk/jdk/jfr/api/consumer/filestream/TestReuse.java ! test/jdk/jdk/jfr/api/recording/event/TestEventTime.java ! test/jdk/jdk/jfr/event/runtime/TestActiveSettingEvent.java ! test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/tooltip/ToolTipDemo.java ! test/jdk/sun/java2d/cmm/ColorConvertOp/ImageFactory.java ! test/jdk/sun/security/provider/certpath/DisabledAlgorithms/CPBuilder.java ! test/jdk/sun/security/provider/certpath/DisabledAlgorithms/CPBuilderWithMD5.java ! test/jdk/sun/tools/jhsdb/BasicLauncherTest.java ! test/jdk/tools/jar/modularJar/Basic.java ! test/jdk/tools/jar/multiRelease/data/test13/v10/version/Nested.java ! test/langtools/jdk/javadoc/tool/api/basic/JavadocTaskImplTest.java ! test/langtools/jdk/jshell/VariablesTest.java ! test/langtools/tools/doclint/RunTest.java ! test/langtools/tools/javac/generics/inference/4954546/T4954546.java Changeset: 50eb915a Author: Andrey Turbanov Date: 2022-03-07 22:00:11 +0000 URL: https://git.openjdk.java.net/loom/commit/50eb915a74aed2daf03c7d39670d3a1ac8d5cbfb 8282632: Cleanup unnecessary calls to Throwable.initCause() in java.security.jgss Reviewed-by: mullan, rhalade ! src/java.security.jgss/share/classes/sun/net/www/protocol/http/spnego/NegotiatorImpl.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/KRBError.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/dk/ArcFourCrypto.java Changeset: cde923dd Author: Ioi Lam Date: 2022-03-08 00:19:07 +0000 URL: https://git.openjdk.java.net/loom/commit/cde923dd471a22cd69ea2cd4994bb16eba780804 8282690: runtime/CommandLine/VMDeprecatedOptions.java fails after JDK-8281181 Reviewed-by: dholmes, dcubed ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java Changeset: 3f0684d0 Author: Yi Yang Date: 2022-03-08 03:14:21 +0000 URL: https://git.openjdk.java.net/loom/commit/3f0684d0b85662724af845a4ee6b97d9c5ceacbd 8275775: Add jcmd VM.classes to print details of all classes Reviewed-by: dholmes, iklam, stuefe ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/runtime/vmOperation.hpp ! src/hotspot/share/services/diagnosticCommand.cpp ! src/hotspot/share/services/diagnosticCommand.hpp + test/hotspot/jtreg/runtime/CommandLine/PrintClasses.java Changeset: 8b45dbda Author: Jamil Nimeh Date: 2022-03-08 05:50:41 +0000 URL: https://git.openjdk.java.net/loom/commit/8b45dbdae6e5dee85ef65ce25850ce692ad3e965 8282312: Minor corrections to evbroadcasti32x4 intrinsic on x86 Reviewed-by: dlong ! src/hotspot/cpu/x86/assembler_x86.cpp Changeset: e6072872 Author: Albert Mingkun Yang Date: 2022-03-08 08:24:10 +0000 URL: https://git.openjdk.java.net/loom/commit/e607287204dbb551b75e82f4de64ea3cd0f47f24 8282728: Serial: Remove unused BlockOffsetArray::Action Reviewed-by: tschatzl ! src/hotspot/share/gc/shared/blockOffsetTable.cpp ! src/hotspot/share/gc/shared/blockOffsetTable.hpp Changeset: 65ca0a57 Author: Markus Gr?nlund Date: 2022-03-08 09:28:46 +0000 URL: https://git.openjdk.java.net/loom/commit/65ca0a5776df229ee91f420585ca1e8f91e489c6 8276333: jdk/jfr/event/oldobject/TestLargeRootSet.java failed "assert(!contains(edge->reference())) failed: invariant" Reviewed-by: egahlin ! src/hotspot/share/jfr/leakprofiler/chains/dfsClosure.cpp ! src/hotspot/share/jfr/leakprofiler/chains/edgeStore.cpp ! test/jdk/ProblemList.txt Changeset: 5fab27e1 Author: Jim Laskey Date: 2022-03-08 13:25:34 +0000 URL: https://git.openjdk.java.net/loom/commit/5fab27e1b8fdf2ea27cb3b349bd339a4a6ec828b 8282144: RandomSupport.convertSeedBytesToLongs sign extension overwrites previous bytes Reviewed-by: bpb ! src/java.base/share/classes/jdk/internal/util/random/RandomSupport.java + test/jdk/java/util/Random/T8282144.java Changeset: c6d743fb Author: Magnus Ihse Bursie Date: 2022-03-08 13:57:59 +0000 URL: https://git.openjdk.java.net/loom/commit/c6d743fb920e740c7b0aac0c0ef5bdc3d60252ad 8282770: Set source date in jib profiles from buildId Reviewed-by: erikj ! make/conf/jib-profiles.js Changeset: 0f88fc18 Author: Magnus Ihse Bursie Date: 2022-03-08 14:04:59 +0000 URL: https://git.openjdk.java.net/loom/commit/0f88fc180cd5abc60605a094efa3f3a54f67f7a0 8282769: BSD date cannot handle all ISO 8601 formats Reviewed-by: erikj ! make/autoconf/util.m4 Changeset: 0cbc4b85 Author: Foivos Zakkak Committer: Severin Gehwolf Date: 2022-03-08 15:35:55 +0000 URL: https://git.openjdk.java.net/loom/commit/0cbc4b85bf8ab2ccfb8762322098c4cc7996df7d 8281266: [JVMCI] MetaUtil.toInternalName() doesn't handle hidden classes correctly Reviewed-by: sgehwolf, dnsimon ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/MetaUtil.java ! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestResolvedJavaType.java Changeset: 3e4dfc63 Author: Coleen Phillimore Date: 2022-03-08 16:10:26 +0000 URL: https://git.openjdk.java.net/loom/commit/3e4dfc63e75db7e8ccbb21a831d8d86fb7c1ac4e 8282295: SymbolPropertyEntry::set_method_type fails with assert Reviewed-by: hseigel ! src/hotspot/share/memory/universe.cpp Changeset: 2549e550 Author: Daniel Jeli?ski Committer: Daniel Fuchs Date: 2022-03-08 16:15:24 +0000 URL: https://git.openjdk.java.net/loom/commit/2549e5503806447733572643603af9a2bf4b52e5 8275640: (win) java.net.NetworkInterface issues with IPv6-only environments Reviewed-by: msheppar, dfuchs ! src/java.base/windows/native/libnet/NetworkInterface.c ! src/java.base/windows/native/libnet/NetworkInterface_winXP.c Changeset: 3fc009be Author: Ian Graves Date: 2022-03-08 16:32:18 +0000 URL: https://git.openjdk.java.net/loom/commit/3fc009be8a49f9edb8059d8612ef6ed7f048f242 8281560: Matcher.hitEnd returns unexpected results in presence of CANON_EQ flag. Reviewed-by: rriggs, lancea ! src/java.base/share/classes/java/util/regex/Pattern.java ! test/jdk/java/util/regex/RegExTest.java Changeset: 6b34884b Author: Manukumar V S Committer: Alexey Ivanov Date: 2022-03-08 17:01:03 +0000 URL: https://git.openjdk.java.net/loom/commit/6b34884b34c4d84a1b5cfa3556a188415a42b1de 8282234: Create a regression test for JDK-4532513 Reviewed-by: aivanov + test/jdk/javax/swing/JTextField/4532513/DefaultCaretRequestsFocusTest.java Changeset: 288d1afc Author: Xin Liu Date: 2022-03-08 17:33:15 +0000 URL: https://git.openjdk.java.net/loom/commit/288d1afc5a2d5ac128b1b427bc877b7815925917 8282715: typo compileony in test Test8005033.java Reviewed-by: jiefu, dholmes, thartmann ! test/hotspot/jtreg/compiler/codegen/Test8005033.java Changeset: 72e987e3 Author: Sean Mullan Date: 2022-03-08 18:18:57 +0000 URL: https://git.openjdk.java.net/loom/commit/72e987e3b49b81f2f66d125c18ab459d9ed572b6 7192189: Support endpoint identification algorithm in RFC 6125 Reviewed-by: xuelei, rhalade ! src/java.base/share/classes/sun/security/util/HostnameChecker.java = test/jdk/sun/security/util/HostnameChecker/NullHostnameCheck.java + test/jdk/sun/security/util/HostnameChecker/TestHostnameChecker.java = test/jdk/sun/security/util/HostnameChecker/cert1.crt = test/jdk/sun/security/util/HostnameChecker/cert2.crt = test/jdk/sun/security/util/HostnameChecker/cert3.crt = test/jdk/sun/security/util/HostnameChecker/cert4.crt = test/jdk/sun/security/util/HostnameChecker/cert5.crt - test/jdk/sun/security/util/HostnameMatcher/TestHostnameChecker.java Changeset: ea19114e Author: Rajan Halade Date: 2022-03-08 20:34:02 +0000 URL: https://git.openjdk.java.net/loom/commit/ea19114e66326e4be7b4b9995888ad2ead3d37dc 8282832: Update file path for HostnameMatcher/cert5.crt in test sun/security/util/Pem/encoding.sh Reviewed-by: mullan ! test/jdk/sun/security/util/Pem/encoding.sh Changeset: 49245131 Author: Hao Sun Committer: Pengfei Li Date: 2022-03-09 00:52:01 +0000 URL: https://git.openjdk.java.net/loom/commit/49245131e98c1c72c447536e5527acecb3311add 8265263: AArch64: Combine vneg with right shift count Reviewed-by: adinn, dlong ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/aarch64_neon.ad ! src/hotspot/cpu/aarch64/aarch64_neon_ad.m4 + test/micro/org/openjdk/bench/vm/compiler/VectorShiftRight.java Changeset: 12693a6c Author: Xiaohong Gong Committer: Ningsheng Jian Date: 2022-03-09 01:02:25 +0000 URL: https://git.openjdk.java.net/loom/commit/12693a6cf3e00c38a635d888419406f689657813 8282432: Optimize masked "test" Vector API with predicate feature Reviewed-by: psandoz ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Byte128Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Byte256Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Byte512Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Byte64Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ByteMaxVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ByteVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Double128Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Double256Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Double512Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Double64Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/DoubleMaxVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/DoubleVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float128Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float256Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float512Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float64Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/FloatMaxVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/FloatVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Int128Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Int256Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Int512Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Int64Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/IntMaxVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/IntVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Long128Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Long256Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Long512Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Long64Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/LongMaxVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/LongVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Short128Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Short256Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Short512Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Short64Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ShortMaxVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ShortVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-VectorBits.java.template ! test/jdk/jdk/incubator/vector/Byte128VectorTests.java ! test/jdk/jdk/incubator/vector/Byte256VectorTests.java ! test/jdk/jdk/incubator/vector/Byte512VectorTests.java ! test/jdk/jdk/incubator/vector/Byte64VectorTests.java ! test/jdk/jdk/incubator/vector/ByteMaxVectorTests.java ! test/jdk/jdk/incubator/vector/Double128VectorTests.java ! test/jdk/jdk/incubator/vector/Double256VectorTests.java ! test/jdk/jdk/incubator/vector/Double512VectorTests.java ! test/jdk/jdk/incubator/vector/Double64VectorTests.java ! test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java ! test/jdk/jdk/incubator/vector/Float128VectorTests.java ! test/jdk/jdk/incubator/vector/Float256VectorTests.java ! test/jdk/jdk/incubator/vector/Float512VectorTests.java ! test/jdk/jdk/incubator/vector/Float64VectorTests.java ! test/jdk/jdk/incubator/vector/FloatMaxVectorTests.java ! test/jdk/jdk/incubator/vector/Int128VectorTests.java ! test/jdk/jdk/incubator/vector/Int256VectorTests.java ! test/jdk/jdk/incubator/vector/Int512VectorTests.java ! test/jdk/jdk/incubator/vector/Int64VectorTests.java ! test/jdk/jdk/incubator/vector/IntMaxVectorTests.java ! test/jdk/jdk/incubator/vector/Long128VectorTests.java ! test/jdk/jdk/incubator/vector/Long256VectorTests.java ! test/jdk/jdk/incubator/vector/Long512VectorTests.java ! test/jdk/jdk/incubator/vector/Long64VectorTests.java ! test/jdk/jdk/incubator/vector/LongMaxVectorTests.java ! test/jdk/jdk/incubator/vector/Short128VectorTests.java ! test/jdk/jdk/incubator/vector/Short256VectorTests.java ! test/jdk/jdk/incubator/vector/Short512VectorTests.java ! test/jdk/jdk/incubator/vector/Short64VectorTests.java ! test/jdk/jdk/incubator/vector/ShortMaxVectorTests.java ! test/jdk/jdk/incubator/vector/templates/Unit-Test.template ! test/jdk/jdk/incubator/vector/templates/Unit-header.template Changeset: 31ad80a2 Author: Tim Prinzing Committer: Mandy Chung Date: 2022-03-09 04:02:17 +0000 URL: https://git.openjdk.java.net/loom/commit/31ad80a229e3f67823ff8f1fc914c5503f184b57 8280902: ResourceBundle::getBundle may throw NPE when invoked by JNI code with no caller frame Reviewed-by: naoto, mchung, ihse ! make/test/JtregNativeJdk.gmk ! src/java.base/share/classes/java/util/ResourceBundle.java + test/jdk/java/util/ResourceBundle/exeNullCallerResourceBundle/NullCallerResourceBundle.java + test/jdk/java/util/ResourceBundle/exeNullCallerResourceBundle/exeNullCallerResourceBundle.c Changeset: d07f7c76 Author: Emanuel Peter Committer: Tobias Hartmann Date: 2022-03-09 08:59:37 +0000 URL: https://git.openjdk.java.net/loom/commit/d07f7c76c5df1473bffa41f10a89ca1e21e001ef 8282665: [REDO] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y) Reviewed-by: psandoz, thartmann ! test/hotspot/jtreg/compiler/intrinsics/unsafe/ByteBufferTest.java Changeset: 5df2a057 Author: Zhengyu Gu Date: 2022-03-09 13:27:11 +0000 URL: https://git.openjdk.java.net/loom/commit/5df2a057707eb65148f96710bd57d8dd8d85d1ed 8282628: Potential memory leak in sun.font.FontConfigManager.getFontConfig() Reviewed-by: stuefe, dholmes, aivanov ! src/java.desktop/unix/native/common/awt/fontpath.c Changeset: e3f61b7f Author: Alan Bateman Date: 2022-03-10 11:42:12 +0000 URL: https://git.openjdk.java.net/loom/commit/e3f61b7f7bfaf757ecea6202ed9c8f418f0460a7 Merge with jdk-19+13 ! make/autoconf/configure.ac ! make/autoconf/spec.gmk.in ! make/conf/jib-profiles.js ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/x86/assembler_x86.cpp ! src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp ! src/hotspot/share/c1/c1_Compilation.cpp ! src/hotspot/share/c1/c1_Compilation.hpp ! src/hotspot/share/c1/c1_GraphBuilder.cpp ! src/hotspot/share/code/codeCache.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp ! src/hotspot/share/memory/universe.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/vmOperation.hpp ! src/hotspot/share/services/diagnosticCommand.cpp ! src/hotspot/share/services/diagnosticCommand.hpp ! src/java.base/share/classes/java/net/DatagramSocket.java ! src/java.base/share/classes/sun/nio/ch/DatagramSocketAdaptor.java ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/vmTestbase/nsk/jdb/unmonitor/unmonitor001/unmonitor001.java ! test/hotspot/jtreg/vmTestbase/nsk/share/jdb/Launcher.java ! test/jdk/ProblemList.txt ! test/jdk/jdk/jfr/event/runtime/TestActiveSettingEvent.java ! make/autoconf/configure.ac ! make/autoconf/spec.gmk.in ! make/conf/jib-profiles.js ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/x86/assembler_x86.cpp ! src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp ! src/hotspot/share/c1/c1_Compilation.cpp ! src/hotspot/share/c1/c1_Compilation.hpp ! src/hotspot/share/c1/c1_GraphBuilder.cpp ! src/hotspot/share/code/codeCache.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp ! src/hotspot/share/memory/universe.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/vmOperation.hpp ! src/hotspot/share/services/diagnosticCommand.cpp ! src/hotspot/share/services/diagnosticCommand.hpp ! src/java.base/share/classes/java/net/DatagramSocket.java ! src/java.base/share/classes/sun/nio/ch/DatagramSocketAdaptor.java ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/vmTestbase/nsk/jdb/unmonitor/unmonitor001/unmonitor001.java ! test/hotspot/jtreg/vmTestbase/nsk/share/jdb/Launcher.java ! test/jdk/ProblemList.txt ! test/jdk/jdk/jfr/event/runtime/TestActiveSettingEvent.java Changeset: 55847ee0 Author: Alan Bateman Date: 2022-03-10 12:24:17 +0000 URL: https://git.openjdk.java.net/loom/commit/55847ee07ec86ab0fe2d01440112d4106bf204a1 Merge From duke at openjdk.java.net Thu Mar 10 12:41:55 2022 From: duke at openjdk.java.net (duke) Date: Thu, 10 Mar 2022 12:41:55 GMT Subject: git: openjdk/loom: master: 72 new changesets Message-ID: <09052435-50e1-458b-86b1-a0c19c0e410a@openjdk.java.net> Changeset: b6c35ae4 Author: Magnus Ihse Bursie Date: 2022-03-02 18:17:47 +0000 URL: https://git.openjdk.java.net/loom/commit/b6c35ae44aeb31deb7a15ee2939156ed00b3df52 8209784: Include hsdis in the JDK Reviewed-by: erikj ! make/Hsdis.gmk ! make/Main.gmk ! make/autoconf/configure.ac ! make/autoconf/jdk-options.m4 + make/autoconf/lib-hsdis.m4 ! make/autoconf/libraries.m4 ! make/autoconf/spec.gmk.in ! make/modules/java.base/Copy.gmk Changeset: 1485883c Author: Weijun Wang Date: 2022-03-03 00:39:39 +0000 URL: https://git.openjdk.java.net/loom/commit/1485883c9e6e24315bb21f20604b1c326e862a5b 8281628: KeyAgreement : generateSecret intermittently not resetting Reviewed-by: valeriep ! src/java.base/share/classes/com/sun/crypto/provider/DHKeyAgreement.java + test/jdk/com/sun/crypto/provider/KeyAgreement/DHKeyAgreementPadding.java Changeset: 02aa7cef Author: Mandy Chung Date: 2022-03-03 01:50:02 +0000 URL: https://git.openjdk.java.net/loom/commit/02aa7cef0a9b9de1ee9a136c5641b498c0c3e5cc 8282515: More clean up on NativeLibraries just for JNI library use Reviewed-by: mcimadamore ! src/java.base/share/classes/jdk/internal/loader/NativeLibraries.java ! src/java.base/share/classes/jdk/internal/loader/RawNativeLibraries.java ! src/java.base/share/native/libjava/NativeLibraries.c + src/java.base/share/native/libjava/RawNativeLibraries.c ! test/jdk/jdk/internal/loader/NativeLibraries/Main.java ! test/jdk/jdk/internal/loader/NativeLibraries/java.base/jdk/internal/loader/NativeLibrariesTest.java Changeset: d0eb6fa2 Author: Srinivas Mandalika Committer: Abdul Kolarkunnu Date: 2022-03-03 03:26:10 +0000 URL: https://git.openjdk.java.net/loom/commit/d0eb6fa2204c4112ef57ffa7579e209ebee62551 8281569: Create tests for Frame.setMinimumSize() method Reviewed-by: aivanov + test/jdk/java/awt/Frame/SetMinimumSizeTest/SetMinimumSizeTest1.java + test/jdk/java/awt/Frame/SetMinimumSizeTest/SetMinimumSizeTest2.java Changeset: 2da67779 Author: Christian Hagedorn Date: 2022-03-03 07:17:56 +0000 URL: https://git.openjdk.java.net/loom/commit/2da677793f562236d473afe12b5c941f25f41377 8281122: [IR Framework] Cleanup IR matching code in preparation for JDK-8280378 Reviewed-by: thartmann, kvn ! test/hotspot/jtreg/compiler/lib/ir_framework/IR.java ! test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java ! test/hotspot/jtreg/compiler/lib/ir_framework/TestFramework.java - test/hotspot/jtreg/compiler/lib/ir_framework/driver/IRMatcher.java - test/hotspot/jtreg/compiler/lib/ir_framework/driver/IRMethod.java ! test/hotspot/jtreg/compiler/lib/ir_framework/driver/TestVMProcess.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/CompilationOutputBuilder.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/IRMatcher.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/IRMatcherFailureMessageBuilder.java = test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/IRViolationException.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/MatchResult.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/OutputMatch.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irmethod/FailureMessageBuilder.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irmethod/IRMethod.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irmethod/IRMethodMatchResult.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irmethod/MatchedCompilationOutputBuilder.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irmethod/MissingCompilationMessageBuilder.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irmethod/MissingCompilationResult.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irmethod/NormalFailureMessageBuilder.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irmethod/NormalMatchResult.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irrule/CheckAttribute.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irrule/CheckAttributeMatchResult.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irrule/Counts.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irrule/CountsMatchResult.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irrule/CountsRegexFailure.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irrule/FailOn.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irrule/FailOnMatchResult.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irrule/FailOnRegexFailure.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irrule/IRRule.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irrule/IRRuleMatchResult.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irrule/RegexFailure.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/parser/AbstractLine.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/parser/BlockLine.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/parser/BlockOutputReader.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/parser/FileCorruptedException.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/parser/HotSpotPidFileParser.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/parser/IREncodingParser.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/parser/IRMethodParser.java + test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/parser/Line.java + test/hotspot/jtreg/compiler/lib/ir_framework/shared/Comparison.java + test/hotspot/jtreg/compiler/lib/ir_framework/shared/ComparisonConstraintParser.java + test/hotspot/jtreg/compiler/lib/ir_framework/shared/EmptyConstraintException.java + test/hotspot/jtreg/compiler/lib/ir_framework/shared/InvalidComparatorException.java + test/hotspot/jtreg/compiler/lib/ir_framework/shared/InvalidConstraintValueException.java + test/hotspot/jtreg/compiler/lib/ir_framework/shared/MissingConstraintValueException.java - test/hotspot/jtreg/compiler/lib/ir_framework/shared/ParsedComparator.java ! test/hotspot/jtreg/compiler/lib/ir_framework/shared/TestFormat.java + test/hotspot/jtreg/compiler/lib/ir_framework/shared/UnreachableCodeException.java ! test/hotspot/jtreg/compiler/lib/ir_framework/test/IREncodingPrinter.java ! test/hotspot/jtreg/compiler/lib/ir_framework/test/TestVM.java ! test/hotspot/jtreg/compiler/vectorapi/TestMaskedMacroLogicVector.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/examples/IRExample.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestCheckedTests.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestCompileThreshold.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestIRMatching.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestRunTests.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/Utils.java Changeset: b1f935c1 Author: Tobias Holenstein Committer: Tobias Hartmann Date: 2022-03-03 07:59:45 +0000 URL: https://git.openjdk.java.net/loom/commit/b1f935c1d0d3729470b57832cf74c43d49ea1f71 8277055: Assert "missing inlining msg" with -XX:+PrintIntrinsics Reviewed-by: roland, thartmann ! src/hotspot/share/opto/callGenerator.cpp ! test/hotspot/jtreg/compiler/print/PrintInlining.java Changeset: d4d1fbc2 Author: Thomas Schatzl Date: 2022-03-03 09:26:41 +0000 URL: https://git.openjdk.java.net/loom/commit/d4d1fbc27a2382d8d9545b7bf672cdcc81654404 8282484: G1: Predicted old time in log always zero Reviewed-by: ayang, iwalulya ! src/hotspot/share/gc/g1/g1Policy.cpp Changeset: 0402a288 Author: Prasanta Sadhukhan Date: 2022-03-03 09:51:08 +0000 URL: https://git.openjdk.java.net/loom/commit/0402a288f309d589d1dc8860e95e4ed42a1ef9f4 8037965: NullPointerException in TextLayout.getBaselineFromGraphic() for JTextComponents Reviewed-by: prr, aivanov ! src/java.desktop/share/classes/java/awt/font/TextLayout.java + test/jdk/javax/swing/JTextField/SwingUnicodeTest.java Changeset: 832729b4 Author: Prasanta Sadhukhan Date: 2022-03-03 09:53:14 +0000 URL: https://git.openjdk.java.net/loom/commit/832729b41e690d6f05da71997bbe2a74b2d6dada 6911375: mouseWheel has no effect without vertical scrollbar Reviewed-by: aivanov ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicScrollPaneUI.java + test/jdk/javax/swing/JScrollPane/TestMouseWheelScroll.java Changeset: 7822cbce Author: Coleen Phillimore Date: 2022-03-03 13:20:58 +0000 URL: https://git.openjdk.java.net/loom/commit/7822cbce10e0c0c6f9bf521faebc89a0af20734e 8276711: compiler/codecache/cli tests failing when SegmentedCodeCache used with -Xint Reviewed-by: kvn, dholmes ! src/hotspot/share/code/codeCache.cpp ! src/hotspot/share/compiler/compilerDefinitions.cpp ! test/hotspot/jtreg/compiler/codecache/cli/TestSegmentedCodeCacheOption.java ! test/hotspot/jtreg/compiler/codecache/cli/codeheapsize/TestCodeHeapSizeOptions.java ! test/hotspot/jtreg/compiler/codecache/cli/common/CodeCacheCLITestCase.java Changeset: 5c187e34 Author: Thomas Stuefe Date: 2022-03-03 13:25:10 +0000 URL: https://git.openjdk.java.net/loom/commit/5c187e34a58769a129a0aae9e4937907c9060202 8282593: JDK-8281472 breaks 32-bit builds and gtests Reviewed-by: jiefu, dholmes ! test/hotspot/gtest/runtime/test_largeOptions.cpp Changeset: 57020fd5 Author: Jonathan Gibbons Date: 2022-03-03 14:54:02 +0000 URL: https://git.openjdk.java.net/loom/commit/57020fd5822148b02e72b60b462a7402658d979a 8282582: Unused methods in Utils Reviewed-by: prappo ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java Changeset: 080baffa Author: Pavel Rappo Date: 2022-03-03 16:10:18 +0000 URL: https://git.openjdk.java.net/loom/commit/080baffa6e0b27dbbf169d6c68980351aa484b8e 8282483: Ensure that Utils.getAllInterfaces returns unique instances Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java Changeset: c777bb3d Author: Thomas Schatzl Date: 2022-03-03 16:16:44 +0000 URL: https://git.openjdk.java.net/loom/commit/c777bb3df3234faff24b92e55977c7f4ae750647 8282619: G1: Fix indentation in G1CollectedHeap::mark_evac_failure_object Reviewed-by: ayang, iwalulya ! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp Changeset: 268fa693 Author: Xue-Lei Andrew Fan Date: 2022-03-03 19:20:16 +0000 URL: https://git.openjdk.java.net/loom/commit/268fa693188b685de6289927ee5a1e99473a50f6 8282511: Use fixed certificate validation date in SSLExampleCert template Reviewed-by: rhalade ! test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java ! test/jdk/javax/net/ssl/templates/SSLExampleCert.java Changeset: 1581e3fa Author: Manukumar V S Committer: Alexey Ivanov Date: 2022-03-03 19:30:07 +0000 URL: https://git.openjdk.java.net/loom/commit/1581e3faa06358f192799b3a89718028c7f6a24b 8282402: Create a regression test for JDK-4666101 Reviewed-by: aivanov + test/jdk/javax/swing/JEditorPane/4666101/JEditorPaneNavigationTest.java Changeset: fb6b929e Author: Hai-May Chao Date: 2022-03-03 23:01:26 +0000 URL: https://git.openjdk.java.net/loom/commit/fb6b929e6e935baeccfd03a7fbc048cc8b531ce5 8277474: jarsigner does not check if algorithm parameters are disabled Reviewed-by: mullan, weijun ! src/java.base/share/classes/sun/security/util/DisabledAlgorithmConstraints.java ! src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java ! src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources.java + test/jdk/sun/security/tools/jarsigner/CheckAlgParams.java Changeset: 8478173d Author: Joe Wang Date: 2022-03-04 03:15:35 +0000 URL: https://git.openjdk.java.net/loom/commit/8478173d837113bf603aadb614badd461f474250 8282583: Update BCEL md to include the copyright notice Reviewed-by: lancea, iris, naoto ! src/java.xml/share/legal/bcel.md Changeset: 7e1c67d4 Author: Mandy Chung Date: 2022-03-04 03:41:41 +0000 URL: https://git.openjdk.java.net/loom/commit/7e1c67d4af76eba688927a24d711181570e965ef 8282608: RawNativeLibraryImpl can't be passed to NativeLibraries::findEntry0 Reviewed-by: mcimadamore, dholmes ! src/java.base/share/classes/jdk/internal/loader/NativeLibraries.java ! src/java.base/share/classes/jdk/internal/loader/NativeLibrary.java ! src/java.base/share/classes/jdk/internal/loader/RawNativeLibraries.java ! src/java.base/share/native/libjava/NativeLibraries.c Changeset: b629782b Author: Igor Veresov Date: 2022-03-04 03:49:37 +0000 URL: https://git.openjdk.java.net/loom/commit/b629782b8d44e8aa8a99c6a3381663a6169aa1ad 8279886: C1: Turn off SelectivePhiFunctions in presence of irreducible loops Reviewed-by: kvn, dlong ! src/hotspot/share/c1/c1_Compilation.cpp ! src/hotspot/share/c1/c1_Compilation.hpp ! src/hotspot/share/c1/c1_GraphBuilder.cpp ! src/hotspot/share/c1/c1_Instruction.cpp ! src/hotspot/share/c1/c1_Instruction.hpp Changeset: b3837808 Author: Manukumar V S Committer: Alexey Ivanov Date: 2022-03-04 10:56:11 +0000 URL: https://git.openjdk.java.net/loom/commit/b3837808bf13de2aa3d8c6c21cf61baac9baf2b2 8282343: Create a regression test for JDK-4518432 Reviewed-by: aivanov + test/jdk/javax/swing/JTree/4518432/JTreeNodeCopyPasteTest.java Changeset: d5e8e52f Author: Julian Waters Committer: Magnus Ihse Bursie Date: 2022-03-04 12:42:07 +0000 URL: https://git.openjdk.java.net/loom/commit/d5e8e52f02413e02200701fe8dab7a5c6ab5c77b 8282532: Allow explicitly setting build platform alongside --openjdk-target Reviewed-by: ihse ! doc/building.html ! doc/building.md ! make/autoconf/configure Changeset: a584c904 Author: Emanuel Peter Committer: Tobias Hartmann Date: 2022-03-04 12:55:57 +0000 URL: https://git.openjdk.java.net/loom/commit/a584c904a9e386d7ce80fb9cc6d49fece065d3da 8282573: ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y) Reviewed-by: psandoz, thartmann ! test/hotspot/jtreg/compiler/intrinsics/unsafe/ByteBufferTest.java Changeset: 52471539 Author: Thomas Schatzl Date: 2022-03-04 13:40:57 +0000 URL: https://git.openjdk.java.net/loom/commit/52471539c002e38a5c815045913458776381d369 8282615: G1: Fix some includes Reviewed-by: ayang, iwalulya ! src/hotspot/share/gc/g1/g1CardSetContainers.hpp ! src/hotspot/share/gc/g1/g1CardSetContainers.inline.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1EvacFailureRegions.cpp Changeset: 603050bf Author: Emanuel Peter Committer: Paul Sandoz Date: 2022-03-04 16:26:14 +0000 URL: https://git.openjdk.java.net/loom/commit/603050bfe00d7a0185d84acab2a24a803aa86f82 8282661: [BACKOUT] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y) Reviewed-by: chagedorn, psandoz ! test/hotspot/jtreg/compiler/intrinsics/unsafe/ByteBufferTest.java Changeset: f9f9c0a8 Author: Magnus Ihse Bursie Date: 2022-03-04 16:32:58 +0000 URL: https://git.openjdk.java.net/loom/commit/f9f9c0a8552f6815b22893e8984edb58991d4554 8252769: Warn in configure if git config autocrlf has invalid value Reviewed-by: erikj ! make/autoconf/basic_tools.m4 ! make/autoconf/basic_windows.m4 Changeset: 733c7907 Author: Naoto Sato Date: 2022-03-04 16:57:54 +0000 URL: https://git.openjdk.java.net/loom/commit/733c7907b0059cc734fd1aa5b8d31f9c3e2e3079 8282081: java.time.DateTimeFormatter: wrong definition of symbol F Reviewed-by: joehw, scolebourne, lancea, rriggs ! src/java.base/share/classes/java/time/format/DateTimeFormatter.java ! src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java ! test/jdk/java/time/test/java/time/format/TestDateTimeFormatterBuilder.java Changeset: 9c817d38 Author: Damon Nguyen Committer: Alexey Ivanov Date: 2022-03-04 19:26:12 +0000 URL: https://git.openjdk.java.net/loom/commit/9c817d38806708f84139e3180ac86a3805dcce5f 8015854: [macosx] JButton's HTML ImageView adding unwanted padding Reviewed-by: psadhukhan, aivanov ! src/java.desktop/macosx/classes/com/apple/laf/AquaButtonUI.java + test/jdk/javax/swing/JButton/HtmlButtonImageTest/HtmlButtonImageTest.java Changeset: e07fd395 Author: Ioi Lam Date: 2022-03-04 20:14:11 +0000 URL: https://git.openjdk.java.net/loom/commit/e07fd395bdc314867886a621ec76cf74a5f76b89 8281181: Do not use CPU Shares to compute active processor count Reviewed-by: dholmes, sgehwolf ! src/hotspot/os/linux/cgroupSubsystem_linux.cpp ! src/hotspot/os/linux/globals_linux.hpp ! src/hotspot/share/runtime/arguments.cpp ! test/hotspot/jtreg/containers/cgroup/PlainRead.java ! test/hotspot/jtreg/containers/docker/TestCPUAwareness.java ! test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java Changeset: b0028a45 Author: Jonathan Gibbons Date: 2022-03-04 21:01:52 +0000 URL: https://git.openjdk.java.net/loom/commit/b0028a459c7e99b5e4090cc19127f6347fe220ba 8272853: improve `JavadocTester.runTests` Reviewed-by: hannesw ! test/langtools/jdk/javadoc/lib/javadoc/tester/JavadocTester.java + test/langtools/jdk/javadoc/testJavadocTester/TestRunTests.java Changeset: bae0d5e7 Author: TejeshR13 Committer: Phil Race Date: 2022-03-04 22:50:32 +0000 URL: https://git.openjdk.java.net/loom/commit/bae0d5e7174fed8ffa8a30408c3cffa6e4dd3ddc 8236907: JTable added to nested panels does not paint last visible row Reviewed-by: psadhukhan, prr ! src/java.desktop/share/classes/javax/swing/TablePrintable.java ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTableUI.java + test/jdk/javax/swing/JTable/8236907/LastVisibleRow.java Changeset: c459f8f4 Author: wanghaomin Committer: Vladimir Kozlov Date: 2022-03-05 00:01:49 +0000 URL: https://git.openjdk.java.net/loom/commit/c459f8f406a99cf78814bb5722f546ae1cdb6c6f 8282142: [TestCase] compiler/inlining/ResolvedClassTest.java will fail when --with-jvm-features=-compiler1 Reviewed-by: jiefu, kvn ! test/hotspot/jtreg/compiler/inlining/ResolvedClassTest.java Changeset: 52278b80 Author: Mikael Vidstedt Date: 2022-03-05 01:36:02 +0000 URL: https://git.openjdk.java.net/loom/commit/52278b80c4b68af566327cf46b53dda5eda25a51 8282694: ProblemList runtime/CommandLine/VMDeprecatedOptions.java Reviewed-by: jjg ! test/hotspot/jtreg/ProblemList.txt Changeset: bc42e7cb Author: Thomas Stuefe Date: 2022-03-05 06:37:39 +0000 URL: https://git.openjdk.java.net/loom/commit/bc42e7cbbfd586308338bfdf535c4fcab0cdbc48 8282382: Report glibc malloc tunables in error reports Reviewed-by: zgu, dholmes ! src/hotspot/os/linux/os_linux.cpp Changeset: 974ef554 Author: Jaikiran Pai Date: 2022-03-06 08:16:39 +0000 URL: https://git.openjdk.java.net/loom/commit/974ef5542fe52f9cb8ffd8751df8a020bca503c9 8282617: sun.net.www.protocol.https.HttpsClient#putInKeepAliveCache() doesn't use a lock while dealing with "inCache" field Reviewed-by: dfuchs, michaelm ! src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java Changeset: 415bf441 Author: Masanori Yano Date: 2022-03-06 23:53:50 +0000 URL: https://git.openjdk.java.net/loom/commit/415bf44191632cd8dbcc158c0ff0992c0b61c3ba 8275715: D3D pipeline processes multiple PaintEvent at initial drawing Reviewed-by: prr ! src/java.desktop/windows/classes/sun/java2d/d3d/D3DScreenUpdateManager.java + test/jdk/sun/java2d/DirectX/MultiPaintEventTest/MultiPaintEventTest.java Changeset: 894ffb09 Author: Masanori Yano Date: 2022-03-07 01:33:41 +0000 URL: https://git.openjdk.java.net/loom/commit/894ffb098c80bfeb4209038c017d01dbf53fac0f 8282713: Invalid copyright notice in new test added by JDK-8275715 Reviewed-by: dholmes ! test/jdk/sun/java2d/DirectX/MultiPaintEventTest/MultiPaintEventTest.java Changeset: 6fc73f70 Author: Thomas Schatzl Date: 2022-03-07 13:52:19 +0000 URL: https://git.openjdk.java.net/loom/commit/6fc73f709ba9a7f4810027f6c888b63a4604f004 8282620: G1/Parallel: Constify is_in_young() predicates Reviewed-by: iwalulya, ayang ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.inline.hpp Changeset: 104e3cb2 Author: Joe Darcy Date: 2022-03-07 14:47:52 +0000 URL: https://git.openjdk.java.net/loom/commit/104e3cb24b4de5512abf9f5491f9c530b26838d3 8282696: Add constructors taking a cause to InvalidObjectException and InvalidClassException Reviewed-by: lancea ! src/java.base/share/classes/java/io/InvalidClassException.java ! src/java.base/share/classes/java/io/InvalidObjectException.java ! src/java.base/share/classes/java/io/ObjectInputStream.java ! src/java.base/share/classes/java/io/ObjectStreamClass.java ! src/java.base/share/classes/java/io/ObjectStreamException.java + test/jdk/java/io/Serializable/InvalidClassException/TestIceConstructors.java + test/jdk/java/io/Serializable/InvalidObjectException/TestIoeConstructors.java Changeset: e544e354 Author: Ivan Walulya Date: 2022-03-07 15:05:42 +0000 URL: https://git.openjdk.java.net/loom/commit/e544e354a425a242f23cee1049d6ba31b30740e0 8282621: G1: G1SegmentedArray remove unnecessary template parameter Reviewed-by: kbarrett, tschatzl ! src/hotspot/share/gc/g1/g1CardSetMemory.cpp ! src/hotspot/share/gc/g1/g1CardSetMemory.hpp ! src/hotspot/share/gc/g1/g1CardSetMemory.inline.hpp ! src/hotspot/share/gc/g1/g1SegmentedArray.hpp ! src/hotspot/share/gc/g1/g1SegmentedArray.inline.hpp Changeset: 8e70f4c3 Author: Aleksey Shipilev Date: 2022-03-07 15:23:10 +0000 URL: https://git.openjdk.java.net/loom/commit/8e70f4c3dca4cefe813c5b0fd39c386230ca2fd7 8282224: Correct TIG::bang_stack_shadow_pages comments Reviewed-by: coleenp ! src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp Changeset: f0995abe Author: Lance Andersen Date: 2022-03-07 16:10:31 +0000 URL: https://git.openjdk.java.net/loom/commit/f0995abe62b81cf9c96cc07caa0ac27d00c96ff1 8280404: Unexpected exception thrown when CEN file entry comment length is not valid Reviewed-by: alanb ! src/java.base/share/classes/java/util/zip/ZipFile.java + test/jdk/java/util/zip/ZipFile/InvalidCommentLengthTest.java Changeset: ef266d77 Author: Roland Westrelin Date: 2022-03-07 16:26:19 +0000 URL: https://git.openjdk.java.net/loom/commit/ef266d77b6eb54d7e30a0aafd8a3e8c8f4f0e43a 8278296: Generalize long range check transformation Reviewed-by: jrose, thartmann ! src/hotspot/share/opto/loopPredicate.cpp ! src/hotspot/share/opto/loopTransform.cpp ! src/hotspot/share/opto/loopnode.cpp ! src/hotspot/share/opto/loopnode.hpp ! src/hotspot/share/opto/node.hpp ! test/hotspot/jtreg/compiler/c2/irTests/TestLongRangeChecks.java ! test/hotspot/jtreg/compiler/rangechecks/TestLongRangeCheck.java Changeset: 7194097b Author: Kim Barrett Date: 2022-03-07 17:35:21 +0000 URL: https://git.openjdk.java.net/loom/commit/7194097bcae7e0fd32488834277bb18cb97cea8b 8252577: HotSpot Style Guide should link to One-True-Brace-Style description Reviewed-by: stuefe, dcubed, dholmes ! doc/hotspot-style.html ! doc/hotspot-style.md Changeset: 1faa5c80 Author: Joe Darcy Date: 2022-03-07 17:52:04 +0000 URL: https://git.openjdk.java.net/loom/commit/1faa5c8092f8baec3ca08ed059653876ec46db46 8282686: Add constructors taking a cause to SocketException Reviewed-by: alanb, xuelei, lancea, dfuchs ! src/java.base/share/classes/java/net/DatagramSocket.java ! src/java.base/share/classes/java/net/SocketException.java ! src/java.base/share/classes/javax/net/SocketFactory.java ! src/java.base/share/classes/javax/net/ssl/SSLServerSocketFactory.java ! src/java.base/share/classes/javax/net/ssl/SSLSocketFactory.java ! src/java.base/share/classes/sun/nio/ch/DatagramSocketAdaptor.java + test/jdk/java/net/SocketException/TestSocketExceptionCtor.java Changeset: 5953b229 Author: Kim Barrett Date: 2022-03-07 18:12:14 +0000 URL: https://git.openjdk.java.net/loom/commit/5953b229bf6d7834d575862e7577522ded0b6791 8257589: HotSpot Style Guide should link to rfc7282 Reviewed-by: dcubed, dholmes ! doc/hotspot-style.html ! doc/hotspot-style.md Changeset: 2e298b8b Author: Kim Barrett Date: 2022-03-07 18:20:01 +0000 URL: https://git.openjdk.java.net/loom/commit/2e298b8bf45edc37269b8b70f7784082a8f87306 8272691: Fix HotSpot style guide terminology for "non-local variables" Reviewed-by: dcubed, dholmes ! doc/hotspot-style.html ! doc/hotspot-style.md Changeset: 3996782c Author: Ravi Reddy Committer: Joe Wang Date: 2022-03-07 19:36:54 +0000 URL: https://git.openjdk.java.net/loom/commit/3996782c5af7b0396d5133fab457c507758d9340 8281093: Violating Attribute-Value Normalization in the XML specification 1.0 Reviewed-by: joehw ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityScanner.java Changeset: 5d5bf16b Author: Magnus Ihse Bursie Date: 2022-03-07 19:40:34 +0000 URL: https://git.openjdk.java.net/loom/commit/5d5bf16b0af419781fd336fe33d8eab5adf8be5a 8282567: Improve source-date handling in build system Reviewed-by: erikj, sgehwolf ! doc/building.html ! doc/building.md ! make/InitSupport.gmk ! make/autoconf/configure.ac ! make/autoconf/help.m4 ! make/autoconf/hotspot.m4 ! make/autoconf/jdk-options.m4 ! make/autoconf/spec.gmk.in Changeset: ccad3923 Author: Matteo Baccan Committer: Magnus Ihse Bursie Date: 2022-03-07 21:33:40 +0000 URL: https://git.openjdk.java.net/loom/commit/ccad39237ab860c5c5579537f740177e3f1adcc9 8282657: Code cleanup: removing double semicolons at the end of lines Reviewed-by: lancea, rriggs, ihse, prr, iris, wetmore, darcy, dholmes ! make/jdk/src/classes/build/tools/generatecharacter/CharacterScript.java ! make/langtools/tools/genstubs/GenStubs.java ! src/java.base/share/classes/java/io/File.java ! src/java.base/share/classes/java/util/WeakHashMap.java ! src/java.base/share/classes/sun/util/logging/PlatformLogger.java ! src/java.desktop/share/classes/javax/swing/RepaintManager.java ! src/java.rmi/share/classes/java/rmi/server/LogStream.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/rcache/AuthTime.java ! src/java.sql.rowset/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/XPathParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZGlobals.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/ui/FindInCodeCachePanel.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/ui/FindInHeapPanel.java ! src/jdk.jdeps/share/classes/com/sun/tools/classfile/TypeAnnotation.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/SocketChannelImplInstrumentor.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/tool/JSONWriter.java ! src/jdk.jshell/share/classes/jdk/internal/jshell/tool/Selector.java ! src/utils/LogCompilation/src/main/java/com/sun/hotspot/tools/compiler/LogParser.java ! test/hotspot/jtreg/compiler/codegen/Test6909839.java ! test/hotspot/jtreg/compiler/jvmci/compilerToVM/CompileCodeTestCase.java ! test/hotspot/jtreg/compiler/unsafe/TestMisalignedUnsafeAccess.java ! test/hotspot/jtreg/runtime/cds/appcds/TestCommon.java ! test/hotspot/jtreg/runtime/cds/appcds/customLoader/SameNameInTwoLoadersTest.java ! test/hotspot/jtreg/serviceability/jvmti/Heap/IterateHeapWithEscapeAnalysisEnabled.java ! test/hotspot/jtreg/testlibrary/ctw/src/sun/hotspot/tools/ctw/CtwRunner.java ! test/hotspot/jtreg/vmTestbase/jit/series/series.java ! test/hotspot/jtreg/vmTestbase/nsk/jdb/unmonitor/unmonitor001/unmonitor001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/BScenarios/multithrd/tc02x003.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassObjectReference/reflectedType/reflectype002.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/LocalVariable/isVisible/isvisible001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/frames/frames001.java ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/hotswap/HS203/hs203t002/hs203t002.java ! test/hotspot/jtreg/vmTestbase/nsk/share/jdb/Launcher.java ! test/jdk/com/sun/jdi/ConstantPoolInfo.java ! test/jdk/com/sun/jdi/GenericsTest.java ! test/jdk/java/awt/Component/CompEventOnHiddenComponent/CompEventOnHiddenComponent.java ! test/jdk/java/awt/EmbeddedFrame/EmbeddedFrameGrabTest/EmbeddedFrameGrabTest.java ! test/jdk/java/awt/PrintJob/PrintArcTest/PrintArcTest.java ! test/jdk/java/awt/SplashScreen/GenerateTestImage.java ! test/jdk/java/awt/print/PrinterJob/PrtException.java ! test/jdk/java/io/File/GetXSpace.java ! test/jdk/java/io/File/createTempFile/NameTooLong.java ! test/jdk/java/io/RandomAccessFile/WriteBytesChars.java ! test/jdk/java/lang/invoke/8022701/BogoLoader.java ! test/jdk/java/lang/invoke/accessProtectedSuper/BogoLoader.java ! test/jdk/java/lang/management/RuntimeMXBean/GetSystemProperties.java ! test/jdk/java/net/httpclient/AggregateRequestBodyTest.java ! test/jdk/java/nio/channels/SocketChannel/CloseTimeoutChannel.java ! test/jdk/java/rmi/dgc/dgcImplInsulation/DGCImplInsulation.java ! test/jdk/java/time/tck/java/time/zone/TCKZoneRules.java ! test/jdk/java/util/logging/TestAppletLoggerContext.java ! test/jdk/javax/net/ssl/ServerName/SSLSocketExplorer.java ! test/jdk/javax/net/ssl/ServerName/SSLSocketExplorerFailure.java ! test/jdk/javax/net/ssl/ServerName/SSLSocketExplorerMatchedSNI.java ! test/jdk/javax/net/ssl/ServerName/SSLSocketExplorerUnmatchedSNI.java ! test/jdk/javax/net/ssl/ServerName/SSLSocketExplorerWithCliSNI.java ! test/jdk/javax/net/ssl/ServerName/SSLSocketExplorerWithSrvSNI.java ! test/jdk/javax/sound/midi/Gervill/ModelIdentifier/NewModelIdentifierStringStringInt.java ! test/jdk/javax/sound/midi/Gervill/SoftChannel/NoteOff.java ! test/jdk/javax/sound/midi/Gervill/SoftChannel/NoteOff2.java ! test/jdk/javax/sql/testng/test/rowset/BaseRowSetTests.java ! test/jdk/javax/sql/testng/test/rowset/serial/SQLInputImplTests.java ! test/jdk/javax/sql/testng/test/rowset/serial/SerialArrayTests.java ! test/jdk/javax/sql/testng/test/rowset/serial/SerialExceptionTests.java ! test/jdk/javax/sql/testng/test/rowset/serial/SerialStructTests.java ! test/jdk/jdk/jfr/api/consumer/TestRecordingFile.java ! test/jdk/jdk/jfr/api/consumer/filestream/TestReuse.java ! test/jdk/jdk/jfr/api/recording/event/TestEventTime.java ! test/jdk/jdk/jfr/event/runtime/TestActiveSettingEvent.java ! test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/tooltip/ToolTipDemo.java ! test/jdk/sun/java2d/cmm/ColorConvertOp/ImageFactory.java ! test/jdk/sun/security/provider/certpath/DisabledAlgorithms/CPBuilder.java ! test/jdk/sun/security/provider/certpath/DisabledAlgorithms/CPBuilderWithMD5.java ! test/jdk/sun/tools/jhsdb/BasicLauncherTest.java ! test/jdk/tools/jar/modularJar/Basic.java ! test/jdk/tools/jar/multiRelease/data/test13/v10/version/Nested.java ! test/langtools/jdk/javadoc/tool/api/basic/JavadocTaskImplTest.java ! test/langtools/jdk/jshell/VariablesTest.java ! test/langtools/tools/doclint/RunTest.java ! test/langtools/tools/javac/generics/inference/4954546/T4954546.java Changeset: 50eb915a Author: Andrey Turbanov Date: 2022-03-07 22:00:11 +0000 URL: https://git.openjdk.java.net/loom/commit/50eb915a74aed2daf03c7d39670d3a1ac8d5cbfb 8282632: Cleanup unnecessary calls to Throwable.initCause() in java.security.jgss Reviewed-by: mullan, rhalade ! src/java.security.jgss/share/classes/sun/net/www/protocol/http/spnego/NegotiatorImpl.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/KRBError.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/dk/ArcFourCrypto.java Changeset: cde923dd Author: Ioi Lam Date: 2022-03-08 00:19:07 +0000 URL: https://git.openjdk.java.net/loom/commit/cde923dd471a22cd69ea2cd4994bb16eba780804 8282690: runtime/CommandLine/VMDeprecatedOptions.java fails after JDK-8281181 Reviewed-by: dholmes, dcubed ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java Changeset: 3f0684d0 Author: Yi Yang Date: 2022-03-08 03:14:21 +0000 URL: https://git.openjdk.java.net/loom/commit/3f0684d0b85662724af845a4ee6b97d9c5ceacbd 8275775: Add jcmd VM.classes to print details of all classes Reviewed-by: dholmes, iklam, stuefe ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/runtime/vmOperation.hpp ! src/hotspot/share/services/diagnosticCommand.cpp ! src/hotspot/share/services/diagnosticCommand.hpp + test/hotspot/jtreg/runtime/CommandLine/PrintClasses.java Changeset: 8b45dbda Author: Jamil Nimeh Date: 2022-03-08 05:50:41 +0000 URL: https://git.openjdk.java.net/loom/commit/8b45dbdae6e5dee85ef65ce25850ce692ad3e965 8282312: Minor corrections to evbroadcasti32x4 intrinsic on x86 Reviewed-by: dlong ! src/hotspot/cpu/x86/assembler_x86.cpp Changeset: e6072872 Author: Albert Mingkun Yang Date: 2022-03-08 08:24:10 +0000 URL: https://git.openjdk.java.net/loom/commit/e607287204dbb551b75e82f4de64ea3cd0f47f24 8282728: Serial: Remove unused BlockOffsetArray::Action Reviewed-by: tschatzl ! src/hotspot/share/gc/shared/blockOffsetTable.cpp ! src/hotspot/share/gc/shared/blockOffsetTable.hpp Changeset: 65ca0a57 Author: Markus Gr?nlund Date: 2022-03-08 09:28:46 +0000 URL: https://git.openjdk.java.net/loom/commit/65ca0a5776df229ee91f420585ca1e8f91e489c6 8276333: jdk/jfr/event/oldobject/TestLargeRootSet.java failed "assert(!contains(edge->reference())) failed: invariant" Reviewed-by: egahlin ! src/hotspot/share/jfr/leakprofiler/chains/dfsClosure.cpp ! src/hotspot/share/jfr/leakprofiler/chains/edgeStore.cpp ! test/jdk/ProblemList.txt Changeset: 5fab27e1 Author: Jim Laskey Date: 2022-03-08 13:25:34 +0000 URL: https://git.openjdk.java.net/loom/commit/5fab27e1b8fdf2ea27cb3b349bd339a4a6ec828b 8282144: RandomSupport.convertSeedBytesToLongs sign extension overwrites previous bytes Reviewed-by: bpb ! src/java.base/share/classes/jdk/internal/util/random/RandomSupport.java + test/jdk/java/util/Random/T8282144.java Changeset: c6d743fb Author: Magnus Ihse Bursie Date: 2022-03-08 13:57:59 +0000 URL: https://git.openjdk.java.net/loom/commit/c6d743fb920e740c7b0aac0c0ef5bdc3d60252ad 8282770: Set source date in jib profiles from buildId Reviewed-by: erikj ! make/conf/jib-profiles.js Changeset: 0f88fc18 Author: Magnus Ihse Bursie Date: 2022-03-08 14:04:59 +0000 URL: https://git.openjdk.java.net/loom/commit/0f88fc180cd5abc60605a094efa3f3a54f67f7a0 8282769: BSD date cannot handle all ISO 8601 formats Reviewed-by: erikj ! make/autoconf/util.m4 Changeset: 0cbc4b85 Author: Foivos Zakkak Committer: Severin Gehwolf Date: 2022-03-08 15:35:55 +0000 URL: https://git.openjdk.java.net/loom/commit/0cbc4b85bf8ab2ccfb8762322098c4cc7996df7d 8281266: [JVMCI] MetaUtil.toInternalName() doesn't handle hidden classes correctly Reviewed-by: sgehwolf, dnsimon ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/MetaUtil.java ! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestResolvedJavaType.java Changeset: 3e4dfc63 Author: Coleen Phillimore Date: 2022-03-08 16:10:26 +0000 URL: https://git.openjdk.java.net/loom/commit/3e4dfc63e75db7e8ccbb21a831d8d86fb7c1ac4e 8282295: SymbolPropertyEntry::set_method_type fails with assert Reviewed-by: hseigel ! src/hotspot/share/memory/universe.cpp Changeset: 2549e550 Author: Daniel Jeli?ski Committer: Daniel Fuchs Date: 2022-03-08 16:15:24 +0000 URL: https://git.openjdk.java.net/loom/commit/2549e5503806447733572643603af9a2bf4b52e5 8275640: (win) java.net.NetworkInterface issues with IPv6-only environments Reviewed-by: msheppar, dfuchs ! src/java.base/windows/native/libnet/NetworkInterface.c ! src/java.base/windows/native/libnet/NetworkInterface_winXP.c Changeset: 3fc009be Author: Ian Graves Date: 2022-03-08 16:32:18 +0000 URL: https://git.openjdk.java.net/loom/commit/3fc009be8a49f9edb8059d8612ef6ed7f048f242 8281560: Matcher.hitEnd returns unexpected results in presence of CANON_EQ flag. Reviewed-by: rriggs, lancea ! src/java.base/share/classes/java/util/regex/Pattern.java ! test/jdk/java/util/regex/RegExTest.java Changeset: 6b34884b Author: Manukumar V S Committer: Alexey Ivanov Date: 2022-03-08 17:01:03 +0000 URL: https://git.openjdk.java.net/loom/commit/6b34884b34c4d84a1b5cfa3556a188415a42b1de 8282234: Create a regression test for JDK-4532513 Reviewed-by: aivanov + test/jdk/javax/swing/JTextField/4532513/DefaultCaretRequestsFocusTest.java Changeset: 288d1afc Author: Xin Liu Date: 2022-03-08 17:33:15 +0000 URL: https://git.openjdk.java.net/loom/commit/288d1afc5a2d5ac128b1b427bc877b7815925917 8282715: typo compileony in test Test8005033.java Reviewed-by: jiefu, dholmes, thartmann ! test/hotspot/jtreg/compiler/codegen/Test8005033.java Changeset: 72e987e3 Author: Sean Mullan Date: 2022-03-08 18:18:57 +0000 URL: https://git.openjdk.java.net/loom/commit/72e987e3b49b81f2f66d125c18ab459d9ed572b6 7192189: Support endpoint identification algorithm in RFC 6125 Reviewed-by: xuelei, rhalade ! src/java.base/share/classes/sun/security/util/HostnameChecker.java = test/jdk/sun/security/util/HostnameChecker/NullHostnameCheck.java + test/jdk/sun/security/util/HostnameChecker/TestHostnameChecker.java = test/jdk/sun/security/util/HostnameChecker/cert1.crt = test/jdk/sun/security/util/HostnameChecker/cert2.crt = test/jdk/sun/security/util/HostnameChecker/cert3.crt = test/jdk/sun/security/util/HostnameChecker/cert4.crt = test/jdk/sun/security/util/HostnameChecker/cert5.crt - test/jdk/sun/security/util/HostnameMatcher/TestHostnameChecker.java Changeset: ea19114e Author: Rajan Halade Date: 2022-03-08 20:34:02 +0000 URL: https://git.openjdk.java.net/loom/commit/ea19114e66326e4be7b4b9995888ad2ead3d37dc 8282832: Update file path for HostnameMatcher/cert5.crt in test sun/security/util/Pem/encoding.sh Reviewed-by: mullan ! test/jdk/sun/security/util/Pem/encoding.sh Changeset: 49245131 Author: Hao Sun Committer: Pengfei Li Date: 2022-03-09 00:52:01 +0000 URL: https://git.openjdk.java.net/loom/commit/49245131e98c1c72c447536e5527acecb3311add 8265263: AArch64: Combine vneg with right shift count Reviewed-by: adinn, dlong ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/aarch64_neon.ad ! src/hotspot/cpu/aarch64/aarch64_neon_ad.m4 + test/micro/org/openjdk/bench/vm/compiler/VectorShiftRight.java Changeset: 12693a6c Author: Xiaohong Gong Committer: Ningsheng Jian Date: 2022-03-09 01:02:25 +0000 URL: https://git.openjdk.java.net/loom/commit/12693a6cf3e00c38a635d888419406f689657813 8282432: Optimize masked "test" Vector API with predicate feature Reviewed-by: psandoz ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Byte128Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Byte256Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Byte512Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Byte64Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ByteMaxVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ByteVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Double128Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Double256Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Double512Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Double64Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/DoubleMaxVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/DoubleVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float128Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float256Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float512Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float64Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/FloatMaxVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/FloatVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Int128Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Int256Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Int512Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Int64Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/IntMaxVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/IntVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Long128Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Long256Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Long512Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Long64Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/LongMaxVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/LongVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Short128Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Short256Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Short512Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Short64Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ShortMaxVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ShortVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-VectorBits.java.template ! test/jdk/jdk/incubator/vector/Byte128VectorTests.java ! test/jdk/jdk/incubator/vector/Byte256VectorTests.java ! test/jdk/jdk/incubator/vector/Byte512VectorTests.java ! test/jdk/jdk/incubator/vector/Byte64VectorTests.java ! test/jdk/jdk/incubator/vector/ByteMaxVectorTests.java ! test/jdk/jdk/incubator/vector/Double128VectorTests.java ! test/jdk/jdk/incubator/vector/Double256VectorTests.java ! test/jdk/jdk/incubator/vector/Double512VectorTests.java ! test/jdk/jdk/incubator/vector/Double64VectorTests.java ! test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java ! test/jdk/jdk/incubator/vector/Float128VectorTests.java ! test/jdk/jdk/incubator/vector/Float256VectorTests.java ! test/jdk/jdk/incubator/vector/Float512VectorTests.java ! test/jdk/jdk/incubator/vector/Float64VectorTests.java ! test/jdk/jdk/incubator/vector/FloatMaxVectorTests.java ! test/jdk/jdk/incubator/vector/Int128VectorTests.java ! test/jdk/jdk/incubator/vector/Int256VectorTests.java ! test/jdk/jdk/incubator/vector/Int512VectorTests.java ! test/jdk/jdk/incubator/vector/Int64VectorTests.java ! test/jdk/jdk/incubator/vector/IntMaxVectorTests.java ! test/jdk/jdk/incubator/vector/Long128VectorTests.java ! test/jdk/jdk/incubator/vector/Long256VectorTests.java ! test/jdk/jdk/incubator/vector/Long512VectorTests.java ! test/jdk/jdk/incubator/vector/Long64VectorTests.java ! test/jdk/jdk/incubator/vector/LongMaxVectorTests.java ! test/jdk/jdk/incubator/vector/Short128VectorTests.java ! test/jdk/jdk/incubator/vector/Short256VectorTests.java ! test/jdk/jdk/incubator/vector/Short512VectorTests.java ! test/jdk/jdk/incubator/vector/Short64VectorTests.java ! test/jdk/jdk/incubator/vector/ShortMaxVectorTests.java ! test/jdk/jdk/incubator/vector/templates/Unit-Test.template ! test/jdk/jdk/incubator/vector/templates/Unit-header.template Changeset: 31ad80a2 Author: Tim Prinzing Committer: Mandy Chung Date: 2022-03-09 04:02:17 +0000 URL: https://git.openjdk.java.net/loom/commit/31ad80a229e3f67823ff8f1fc914c5503f184b57 8280902: ResourceBundle::getBundle may throw NPE when invoked by JNI code with no caller frame Reviewed-by: naoto, mchung, ihse ! make/test/JtregNativeJdk.gmk ! src/java.base/share/classes/java/util/ResourceBundle.java + test/jdk/java/util/ResourceBundle/exeNullCallerResourceBundle/NullCallerResourceBundle.java + test/jdk/java/util/ResourceBundle/exeNullCallerResourceBundle/exeNullCallerResourceBundle.c Changeset: d07f7c76 Author: Emanuel Peter Committer: Tobias Hartmann Date: 2022-03-09 08:59:37 +0000 URL: https://git.openjdk.java.net/loom/commit/d07f7c76c5df1473bffa41f10a89ca1e21e001ef 8282665: [REDO] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y) Reviewed-by: psandoz, thartmann ! test/hotspot/jtreg/compiler/intrinsics/unsafe/ByteBufferTest.java Changeset: 5df2a057 Author: Zhengyu Gu Date: 2022-03-09 13:27:11 +0000 URL: https://git.openjdk.java.net/loom/commit/5df2a057707eb65148f96710bd57d8dd8d85d1ed 8282628: Potential memory leak in sun.font.FontConfigManager.getFontConfig() Reviewed-by: stuefe, dholmes, aivanov ! src/java.desktop/unix/native/common/awt/fontpath.c From duke at openjdk.java.net Thu Mar 10 15:09:56 2022 From: duke at openjdk.java.net (duke) Date: Thu, 10 Mar 2022 15:09:56 GMT Subject: git: openjdk/loom: fibers: JFR virtual thread jtreg wrapper test fixes Message-ID: <3665c847-8ca0-410c-9f40-8dd7d04eec23@openjdk.java.net> Changeset: 615786e6 Author: mgronlun Date: 2022-03-10 16:08:05 +0000 URL: https://git.openjdk.java.net/loom/commit/615786e6e9c07398a392038150f08bb1e1f46828 JFR virtual thread jtreg wrapper test fixes ! src/hotspot/share/jfr/jni/jfrJavaSupport.cpp ! src/hotspot/share/jfr/jni/jfrJavaSupport.hpp ! src/hotspot/share/jfr/jni/jfrJniMethod.cpp ! src/hotspot/share/jfr/support/jfrThreadId.inline.hpp ! src/hotspot/share/jfr/support/jfrThreadLocal.cpp ! test/jdk/ProblemList-vthread.txt ! test/jdk/ProblemList.txt From duke at openjdk.java.net Thu Mar 10 15:22:19 2022 From: duke at openjdk.java.net (duke) Date: Thu, 10 Mar 2022 15:22:19 GMT Subject: git: openjdk/loom: fibers: 2 new changesets Message-ID: <56e9cebf-4637-47ff-baef-c4cf29852b46@openjdk.java.net> Changeset: 63041f64 Author: Ron Pressler Date: 2022-03-10 15:20:09 +0000 URL: https://git.openjdk.java.net/loom/commit/63041f640ad80bef2b16428eedf379b7e862e687 Comments ! src/hotspot/cpu/aarch64/continuation_aarch64.inline.hpp ! src/hotspot/cpu/x86/continuation_x86.inline.hpp ! src/hotspot/share/oops/instanceStackChunkKlass.hpp Changeset: 0e1c5bff Author: Ron Pressler Date: 2022-03-10 15:20:43 +0000 URL: https://git.openjdk.java.net/loom/commit/0e1c5bff0c6f5fe65f61219da4e9c298eccc7269 Don't capture continuation scopes in stack traces (performance regression) ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/runtime/continuation.cpp ! src/hotspot/share/runtime/continuation.hpp ! src/hotspot/share/services/threadService.cpp ! src/hotspot/share/services/threadService.hpp ! test/jdk/jdk/internal/vm/Continuation/Basic.java From duke at openjdk.java.net Thu Mar 10 16:25:07 2022 From: duke at openjdk.java.net (duke) Date: Thu, 10 Mar 2022 16:25:07 GMT Subject: git: openjdk/loom: fibers: 3 new changesets Message-ID: <932c6a95-cd25-4ad1-8298-6bf02db8b1bb@openjdk.java.net> Changeset: fd954cc7 Author: Alan Bateman Date: 2022-03-10 10:58:21 +0000 URL: https://git.openjdk.java.net/loom/commit/fd954cc79d6cc865c3cd9f7ddbf2887d5a8391c3 Improve error description ! make/data/jdwp/jdwp.spec Changeset: 27bf9650 Author: Alan Bateman Date: 2022-03-10 14:08:09 +0000 URL: https://git.openjdk.java.net/loom/commit/27bf9650bdb55dfe9e8aacf7aa9932a6146a3fd0 Update problem lists ! test/hotspot/jtreg/ProblemList.txt ! test/jdk/ProblemList.txt Changeset: 94506a56 Author: Alan Bateman Date: 2022-03-10 15:00:00 +0000 URL: https://git.openjdk.java.net/loom/commit/94506a56b7c5d562de5a45c8f36bf168a86d0f41 Re-implement Gate as ThreadTracker ! src/java.base/share/classes/java/net/URL.java ! src/java.base/share/classes/java/nio/charset/Charset.java ! src/java.base/share/classes/java/util/jar/JarFile.java + src/java.base/share/classes/jdk/internal/misc/ThreadTracker.java From duke at openjdk.java.net Thu Mar 10 18:29:12 2022 From: duke at openjdk.java.net (duke) Date: Thu, 10 Mar 2022 18:29:12 GMT Subject: git: openjdk/loom: fibers: replace err code INVALID_THREAD with OPAQUE_FRAME in PopFrame and ForceEarlyReturn for threads Message-ID: <7464e36d-3b66-4b8f-a29a-107034a7a747@openjdk.java.net> Changeset: 7ffe747f Author: Serguei Spitsyn Date: 2022-03-10 18:25:45 +0000 URL: https://git.openjdk.java.net/loom/commit/7ffe747fa6075c4721a83719ed2d51500dddb179 replace err code INVALID_THREAD with OPAQUE_FRAME in PopFrame and ForceEarlyReturn for threads ! src/hotspot/share/prims/jvmti.xml ! src/hotspot/share/prims/jvmtiEnv.cpp ! src/hotspot/share/prims/jvmtiEnvBase.cpp ! src/hotspot/share/prims/jvmtiEnvBase.hpp ! test/hotspot/jtreg/ProblemList-vthread.txt ! test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadUnsupportedTest/libVThreadUnsupportedTest.cpp From duke at openjdk.java.net Thu Mar 10 19:35:56 2022 From: duke at openjdk.java.net (duke) Date: Thu, 10 Mar 2022 19:35:56 GMT Subject: git: openjdk/loom: fibers: 2 new changesets Message-ID: <8b5562be-df35-4ce2-ab62-f07fce164847@openjdk.java.net> Changeset: 5c6b782a Author: Alan Bateman Date: 2022-03-10 18:47:26 +0000 URL: https://git.openjdk.java.net/loom/commit/5c6b782ac16a28edfc32dad75be6fd616e4296e7 Remove jdk/jfr/event/gc/detailed/TestZPageAllocationEvent.java from exclude list ! test/jdk/ProblemList.txt Changeset: f8fe54b0 Author: Alan Bateman Date: 2022-03-10 19:03:29 +0000 URL: https://git.openjdk.java.net/loom/commit/f8fe54b04bb9bfd79bc5aa0d5fc4a298c5d87f7b Remove serviceability/sa/ClhsdbScanOops.java from exclude list ! test/hotspot/jtreg/ProblemList-Xcomp.txt From duke at openjdk.java.net Thu Mar 10 21:03:44 2022 From: duke at openjdk.java.net (duke) Date: Thu, 10 Mar 2022 21:03:44 GMT Subject: git: openjdk/loom: fibers: JCStress updated, Message-ID: Changeset: 186f3fc2 Author: lmesnik Date: 2022-03-10 13:01:40 +0000 URL: https://git.openjdk.java.net/loom/commit/186f3fc2672e8f085b2a7e97b8b2194b83c23702 JCStress updated, ! test/hotspot/jtreg/applications/jcstress/JcstressRunner.java From duke at openjdk.java.net Thu Mar 10 22:53:28 2022 From: duke at openjdk.java.net (duke) Date: Thu, 10 Mar 2022 22:53:28 GMT Subject: git: openjdk/loom: fibers: JFR make write_event() re-entrant for recursive thread id Message-ID: <37b02871-97b8-4cbc-accc-22984b5d6a5c@openjdk.java.net> Changeset: a6b943ca Author: mgronlun Date: 2022-03-10 23:50:20 +0000 URL: https://git.openjdk.java.net/loom/commit/a6b943ca5591dc360f4a34705cfb2c563188a410 JFR make write_event() re-entrant for recursive thread id ! src/hotspot/share/jfr/recorder/service/jfrEvent.hpp From duke at openjdk.java.net Fri Mar 11 11:32:25 2022 From: duke at openjdk.java.net (duke) Date: Fri, 11 Mar 2022 11:32:25 GMT Subject: git: openjdk/loom: fibers: 3 new changesets Message-ID: <87c038bf-1606-4db3-a5b7-3f9e05d64342@openjdk.java.net> Changeset: a966bcdb Author: Ron Pressler Date: 2022-03-11 11:26:51 +0000 URL: https://git.openjdk.java.net/loom/commit/a966bcdbfc77f53e0996d2986609f064dce6c592 Remove unused StackFrameInfo methods ! src/java.base/share/classes/java/lang/StackFrameInfo.java ! src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/java.base/share/classes/jdk/internal/access/JavaLangInvokeAccess.java Changeset: 117148dc Author: Ron Pressler Date: 2022-03-11 11:31:04 +0000 URL: https://git.openjdk.java.net/loom/commit/117148dc444088ee596762f1c5de2cb4ca8878c1 Remove commented-out code ! src/hotspot/share/runtime/continuation.cpp Changeset: bbe9f322 Author: Ron Pressler Date: 2022-03-11 11:31:26 +0000 URL: https://git.openjdk.java.net/loom/commit/bbe9f322c7d1b91a988078ceb5d416b29981e4f3 Cleanup ! src/hotspot/share/runtime/frame.cpp From duke at openjdk.java.net Fri Mar 11 11:41:15 2022 From: duke at openjdk.java.net (duke) Date: Fri, 11 Mar 2022 11:41:15 GMT Subject: git: openjdk/loom: fibers: JFR make write_event() re-entrant also for stacktraces Message-ID: <6bbf2d7f-f461-43ab-86e7-fa0cbbdd79ec@openjdk.java.net> Changeset: a65f4020 Author: mgronlun Date: 2022-03-11 12:39:28 +0000 URL: https://git.openjdk.java.net/loom/commit/a65f4020e6fd9fe1d482a7de53a96a6b28a24b33 JFR make write_event() re-entrant also for stacktraces ! src/hotspot/share/jfr/recorder/service/jfrEvent.hpp From duke at openjdk.java.net Fri Mar 11 12:19:08 2022 From: duke at openjdk.java.net (duke) Date: Fri, 11 Mar 2022 12:19:08 GMT Subject: git: openjdk/loom: fibers: 5 new changesets Message-ID: <6a408fac-66b4-4551-8996-892dcda7fe26@openjdk.java.net> Changeset: 088063e7 Author: Erik ?sterlund Date: 2022-03-02 15:25:33 +0000 URL: https://git.openjdk.java.net/loom/commit/088063e7755c8fddf53d58049d908778a6a89632 Remove junk ! src/hotspot/share/oops/instanceStackChunkKlass.cpp ! src/hotspot/share/oops/instanceStackChunkKlass.hpp ! src/hotspot/share/oops/instanceStackChunkKlass.inline.hpp Changeset: d9b1a8f6 Author: Erik ?sterlund Date: 2022-03-10 12:55:38 +0000 URL: https://git.openjdk.java.net/loom/commit/d9b1a8f6d13585f463373340abe945e4fc26ae4c Remove stack chunk shrinking logic ! src/hotspot/share/gc/g1/g1FullGCCompactTask.cpp ! src/hotspot/share/gc/g1/g1FullGCCompactionPoint.cpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.cpp ! src/hotspot/share/gc/parallel/psPromotionManager.inline.hpp ! src/hotspot/share/gc/serial/defNewGeneration.cpp ! src/hotspot/share/gc/shared/genCollectedHeap.cpp ! src/hotspot/share/gc/shared/generation.cpp ! src/hotspot/share/gc/z/zMark.cpp ! src/hotspot/share/gc/z/zRelocate.cpp ! src/hotspot/share/gc/z/zUtils.hpp ! src/hotspot/share/gc/z/zUtils.inline.hpp ! src/hotspot/share/oops/instanceStackChunkKlass.cpp ! src/hotspot/share/oops/instanceStackChunkKlass.hpp ! src/hotspot/share/oops/klass.cpp ! src/hotspot/share/oops/klass.hpp ! src/hotspot/share/oops/oop.hpp ! src/hotspot/share/oops/oop.inline.hpp ! src/hotspot/share/runtime/globals.hpp Changeset: 5ac96136 Author: Erik ?sterlund Date: 2022-03-03 09:30:16 +0000 URL: https://git.openjdk.java.net/loom/commit/5ac96136cbe108f64278e617e258976e5906634a Simplify GC code to deal more explicitly with stack chunks ! src/hotspot/share/gc/g1/g1FullGCCompactTask.cpp ! src/hotspot/share/gc/g1/g1FullGCCompactionPoint.cpp ! src/hotspot/share/gc/g1/g1FullGCMarker.inline.hpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.cpp ! src/hotspot/share/gc/parallel/psParallelCompact.inline.hpp ! src/hotspot/share/gc/parallel/psPromotionManager.cpp ! src/hotspot/share/gc/serial/defNewGeneration.cpp ! src/hotspot/share/gc/serial/markSweep.inline.hpp + src/hotspot/share/gc/shared/continuationGCSupport.hpp + src/hotspot/share/gc/shared/continuationGCSupport.inline.hpp ! src/hotspot/share/gc/shared/genCollectedHeap.cpp ! src/hotspot/share/gc/z/zMark.cpp ! src/hotspot/share/oops/instanceStackChunkKlass.cpp ! src/hotspot/share/oops/instanceStackChunkKlass.hpp Changeset: e0a9bea1 Author: Erik ?sterlund Date: 2022-03-08 14:00:07 +0000 URL: https://git.openjdk.java.net/loom/commit/e0a9bea1abcc45371527e9e461625602cb2bd64f Remove TODOs for reading oop locals from virtualized stacks ! src/hotspot/cpu/aarch64/frame_aarch64.inline.hpp ! src/hotspot/cpu/x86/frame_x86.inline.hpp ! src/hotspot/share/runtime/frame.cpp ! src/hotspot/share/runtime/sharedRuntime.cpp ! src/hotspot/share/runtime/stackValue.cpp Changeset: c51ee624 Author: Erik ?sterlund Date: 2022-03-10 16:26:02 +0000 URL: https://git.openjdk.java.net/loom/commit/c51ee624796be185c5a6ecb0d340fd846d4bc412 Update nmethod entry barrier on attach ! src/hotspot/share/gc/g1/g1BarrierSet.cpp ! src/hotspot/share/gc/shared/barrierSet.cpp ! src/hotspot/share/gc/shared/barrierSet.hpp From duke at openjdk.java.net Fri Mar 11 13:03:03 2022 From: duke at openjdk.java.net (duke) Date: Fri, 11 Mar 2022 13:03:03 GMT Subject: git: openjdk/loom: fibers: Remove dead oopmap_metadata code Message-ID: Changeset: c263cf2b Author: Erik ?sterlund Date: 2022-03-11 12:17:43 +0000 URL: https://git.openjdk.java.net/loom/commit/c263cf2b30779d7367e00ba5f4eda92295cf068d Remove dead oopmap_metadata code ! src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp ! src/hotspot/cpu/x86/c1_MacroAssembler_x86.cpp ! src/hotspot/cpu/x86/c1_Runtime1_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/x86.ad ! src/hotspot/share/c1/c1_LIRAssembler.cpp ! src/hotspot/share/c1/c1_MacroAssembler.hpp From duke at openjdk.java.net Fri Mar 11 13:42:27 2022 From: duke at openjdk.java.net (duke) Date: Fri, 11 Mar 2022 13:42:27 GMT Subject: git: openjdk/loom: fibers: Resetting SegmentedCodeCache moved with JDK-8276711 Message-ID: Changeset: 35f85183 Author: Coleen Phillimore Date: 2022-03-11 13:41:11 +0000 URL: https://git.openjdk.java.net/loom/commit/35f851831308a5bb9dc041dfa68023725d6e2ad1 Resetting SegmentedCodeCache moved with JDK-8276711 ! src/hotspot/share/runtime/arguments.cpp From duke at openjdk.java.net Fri Mar 11 16:00:09 2022 From: duke at openjdk.java.net (duke) Date: Fri, 11 Mar 2022 16:00:09 GMT Subject: git: openjdk/loom: fibers: 7 new changesets Message-ID: Changeset: 2fa969de Author: Alan Bateman Date: 2022-03-11 12:28:09 +0000 URL: https://git.openjdk.java.net/loom/commit/2fa969deb3fdbad7c77925cadb4d6c9f3269615c Cleanup/comments ! src/java.base/share/classes/java/lang/Thread.java ! src/java.base/share/classes/java/lang/VirtualThread.java ! src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/java.base/share/classes/jdk/internal/access/JavaLangInvokeAccess.java Changeset: 4177f1dd Author: Alan Bateman Date: 2022-03-11 13:39:54 +0000 URL: https://git.openjdk.java.net/loom/commit/4177f1ddc1f20266dbff28710877327359b42dea Remove unused fields/methods ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/java.base/share/classes/java/lang/StackFrameInfo.java ! src/java.base/share/classes/java/lang/StackStreamFactory.java ! src/java.base/share/classes/java/lang/StackTraceElement.java Changeset: 60119661 Author: Alan Bateman Date: 2022-03-11 13:40:07 +0000 URL: https://git.openjdk.java.net/loom/commit/60119661e14c0eebf59b6d9267aa51ff2c7e23d4 Fix comment ! src/java.base/share/classes/java/lang/PinnedThreadPrinter.java Changeset: 90ac57bd Author: Alan Bateman Date: 2022-03-11 13:51:55 +0000 URL: https://git.openjdk.java.net/loom/commit/90ac57bd4adb4eb8561bb6c8ede8c9a5ddd98d51 Fix @param ! src/java.base/share/classes/java/lang/StackTraceElement.java Changeset: df1c9b1d Author: Alan Bateman Date: 2022-03-11 14:08:50 +0000 URL: https://git.openjdk.java.net/loom/commit/df1c9b1d4c195ee3537a11d3d6212fb1ace8f6bc Trailing space, headers ! src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp ! src/java.base/share/native/libjava/PreviewFeatures.c ! src/java.base/share/native/libjava/RandomAccessFile.c ! src/java.base/share/native/libjava/StackTraceElement.c Changeset: b87f92b8 Author: Alan Bateman Date: 2022-03-11 15:18:46 +0000 URL: https://git.openjdk.java.net/loom/commit/b87f92b81e2bc12b44f927d6afeccd55f493abbb Cleanup ! src/java.base/share/classes/sun/nio/ch/DatagramChannelImpl.java ! src/java.base/share/classes/sun/nio/ch/NativeThreadSet.java ! src/java.base/share/classes/sun/nio/ch/NioSocketImpl.java ! src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java ! src/java.base/unix/classes/sun/nio/ch/NativeThread.java ! src/java.base/windows/classes/sun/nio/ch/NativeThread.java Changeset: 1207895f Author: Alan Bateman Date: 2022-03-11 15:27:05 +0000 URL: https://git.openjdk.java.net/loom/commit/1207895f5e0534efdc3f106223ae449161a60f4d Remove stale comment ! src/java.base/share/classes/sun/nio/ch/NativeThreadSet.java From duke at openjdk.java.net Fri Mar 11 17:46:44 2022 From: duke at openjdk.java.net (duke) Date: Fri, 11 Mar 2022 17:46:44 GMT Subject: git: openjdk/loom: fibers: Proper error handling of JVMTI OPAQUE_FRAME errors in JDWP and JDI. Get at least one JDI test running in vthread mode to detect OPAQUE_FRAME for each of PopFrame, ForceEarlyReturn, and SetLocalXXX. Message-ID: Changeset: 6a9145b6 Author: Chris Plummer Date: 2022-03-11 17:45:35 +0000 URL: https://git.openjdk.java.net/loom/commit/6a9145b68e691853c7eeddb6409409137cde7b7b Proper error handling of JVMTI OPAQUE_FRAME errors in JDWP and JDI. Get at least one JDI test running in vthread mode to detect OPAQUE_FRAME for each of PopFrame, ForceEarlyReturn, and SetLocalXXX. ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ThreadReferenceImpl.java ! src/jdk.jdwp.agent/share/native/libjdwp/StackFrameImpl.c ! src/jdk.jdwp.agent/share/native/libjdwp/ThreadReferenceImpl.c ! test/hotspot/jtreg/ProblemList-vthread.txt ! test/hotspot/jtreg/vmTestbase/nsk/jdi/StackFrame/_bounds_/bounds002.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/forceEarlyReturn/forceEarlyReturn002/forceEarlyReturn002.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/forceEarlyReturn/forceEarlyReturn002/forceEarlyReturn002a.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/popFrames/popframes001.java From duke at openjdk.java.net Sat Mar 12 02:04:08 2022 From: duke at openjdk.java.net (duke) Date: Sat, 12 Mar 2022 02:04:08 GMT Subject: git: openjdk/loom: fibers: 4 new changesets Message-ID: <1c654f00-53f4-4fb5-afb5-37d0fb40d85a@openjdk.java.net> Changeset: c2fbf046 Author: Ron Pressler Date: 2022-03-11 22:07:26 +0000 URL: https://git.openjdk.java.net/loom/commit/c2fbf04620732a11b178e5654969fdaf4c3bcd30 remove unused code ! src/java.base/share/classes/java/lang/LiveStackFrameInfo.java ! src/java.base/share/classes/java/lang/StackFrameInfo.java Changeset: ee199a2d Author: Ron Pressler Date: 2022-03-11 22:08:09 +0000 URL: https://git.openjdk.java.net/loom/commit/ee199a2d3160eeedec9e7e87862e6c835bace2b3 Cleanup ! src/hotspot/share/runtime/vframe.cpp ! src/hotspot/share/runtime/vframe.inline.hpp Changeset: 74d8c702 Author: Ron Pressler Date: 2022-03-11 22:08:33 +0000 URL: https://git.openjdk.java.net/loom/commit/74d8c7028aaf7b31d1b08395e29f5afe96dbb1fc Cleanup ! src/java.base/share/classes/jdk/internal/vm/Continuation.java Changeset: 433e6d12 Author: Ron Pressler Date: 2022-03-12 02:01:42 +0000 URL: https://git.openjdk.java.net/loom/commit/433e6d12ef7a0cf5b6dccc176eb77962fffa47b0 Fix and cleanup some JVMTI stack-walking ! src/hotspot/cpu/aarch64/continuation_aarch64.inline.hpp ! src/hotspot/cpu/x86/continuation_x86.inline.hpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/javaClasses.inline.hpp ! src/hotspot/share/prims/jvmtiEnvBase.cpp ! src/hotspot/share/prims/jvmtiEnvBase.hpp ! src/hotspot/share/prims/jvmtiImpl.cpp ! src/hotspot/share/runtime/continuation.cpp ! src/hotspot/share/runtime/continuation.hpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/thread.inline.hpp ! src/hotspot/share/runtime/vframe.cpp ! src/hotspot/share/runtime/vframe.hpp From duke at openjdk.java.net Sat Mar 12 08:56:01 2022 From: duke at openjdk.java.net (duke) Date: Sat, 12 Mar 2022 08:56:01 GMT Subject: git: openjdk/loom: fibers: 4 new changesets Message-ID: <1772d12d-03a6-4e59-b289-7a9ddadc92c9@openjdk.java.net> Changeset: 332ff9fe Author: Alan Bateman Date: 2022-03-11 18:19:33 +0000 URL: https://git.openjdk.java.net/loom/commit/332ff9feaeb585fd07ed07da49bc0159dc1f46d9 Rename field/method to improve readability ! src/java.base/share/classes/java/nio/channels/spi/AbstractSelectableChannel.java ! src/java.base/share/classes/sun/nio/ch/DatagramChannelImpl.java ! src/java.base/share/classes/sun/nio/ch/ServerSocketChannelImpl.java ! src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java Changeset: a10fd3b0 Author: Alan Bateman Date: 2022-03-12 06:47:51 +0000 URL: https://git.openjdk.java.net/loom/commit/a10fd3b06cebe45508841476333ce149f9f6b59c TG cannot be null when attaching ! src/java.base/share/classes/java/lang/SecurityManager.java ! src/java.base/share/classes/java/lang/Thread.java Changeset: bfe5bf3d Author: Alan Bateman Date: 2022-03-12 08:21:46 +0000 URL: https://git.openjdk.java.net/loom/commit/bfe5bf3d8596cc4a12261a05676f594270f3dc86 More cleanup ! src/java.base/share/classes/java/lang/Thread.java Changeset: 46502be2 Author: Alan Bateman Date: 2022-03-12 08:54:58 +0000 URL: https://git.openjdk.java.net/loom/commit/46502be263a9a851691ac9fb7a3007758c0b0601 Remove duplicate error ! make/data/jdwp/jdwp.spec From duke at openjdk.java.net Sat Mar 12 09:37:28 2022 From: duke at openjdk.java.net (duke) Date: Sat, 12 Mar 2022 09:37:28 GMT Subject: git: openjdk/loom: fibers: Temporarily exclude two JFR tests Message-ID: <21a42c43-bea8-4f57-9036-f66d330fc024@openjdk.java.net> Changeset: 8c6de4bb Author: Alan Bateman Date: 2022-03-12 09:34:37 +0000 URL: https://git.openjdk.java.net/loom/commit/8c6de4bb3e38531d6fbb082051117aedf70bf4d9 Temporarily exclude two JFR tests ! test/jdk/ProblemList-vthread.txt ! test/jdk/ProblemList.txt From duke at openjdk.java.net Sat Mar 12 14:57:40 2022 From: duke at openjdk.java.net (duke) Date: Sat, 12 Mar 2022 14:57:40 GMT Subject: git: openjdk/loom: fibers: 2 new changesets Message-ID: <2179cad5-0f41-4428-8d0f-8ccc68c8418d@openjdk.java.net> Changeset: 52bbaaca Author: Ron Pressler Date: 2022-03-12 13:57:23 +0000 URL: https://git.openjdk.java.net/loom/commit/52bbaacafe4ecf26ab4b8493f05cf396116ad914 Fix generate_cont_jump_from_safepoint ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp Changeset: c4ebd428 Author: Ron Pressler Date: 2022-03-12 13:58:04 +0000 URL: https://git.openjdk.java.net/loom/commit/c4ebd42837311fc75013ebd23b824abbb5342fa5 Check for JvmtiMountTransition annotations in is_safe_to_preempt ! src/hotspot/share/prims/jvmtiEnvBase.cpp ! src/hotspot/share/runtime/continuation.cpp ! src/hotspot/share/runtime/registerMap.hpp ! src/hotspot/share/runtime/vframe.hpp ! src/hotspot/share/runtime/vframe.inline.hpp From duke at openjdk.java.net Mon Mar 14 07:16:43 2022 From: duke at openjdk.java.net (duke) Date: Mon, 14 Mar 2022 07:16:43 GMT Subject: git: openjdk/loom: fibers: 8 new changesets Message-ID: <9e3bf66e-28bf-4a21-b089-7c2a1e489c7e@openjdk.java.net> Changeset: a8ff397c Author: Alan Bateman Date: 2022-03-13 07:03:04 +0000 URL: https://git.openjdk.java.net/loom/commit/a8ff397c1eae04d05c3134fe6e422371bd4d5e9b Rename property ! src/java.base/share/classes/java/lang/VirtualThread.java ! test/jdk/java/lang/Thread/virtual/StackTraceWhenRunnable.java Changeset: b302ba32 Author: Alan Bateman Date: 2022-03-13 07:32:51 +0000 URL: https://git.openjdk.java.net/loom/commit/b302ba32119645a4388c8a406ffdb11c52572d3d More cleanup ! src/java.base/share/classes/java/lang/Thread.java ! src/java.base/share/classes/java/lang/ThreadBuilders.java ! test/jdk/java/lang/Thread/UncaughtExceptionsTest.java Changeset: 44639cf1 Author: Alan Bateman Date: 2022-03-13 08:21:47 +0000 URL: https://git.openjdk.java.net/loom/commit/44639cf187a2a3710ce7eb77f1c4e5faa07ca3ae Remove misleading statement about reuse ! src/java.base/share/classes/java/lang/Thread.java Changeset: 157f70c2 Author: Alan Bateman Date: 2022-03-13 08:40:37 +0000 URL: https://git.openjdk.java.net/loom/commit/157f70c23c600fc471ad4f8c0f555a90d3220aae Rename shared secret ! src/java.base/share/classes/java/util/concurrent/ThreadLocalRandom.java = src/java.base/share/classes/jdk/internal/access/JavaUtilConcurrentTLRAccess.java ! src/java.base/share/classes/jdk/internal/access/SharedSecrets.java ! src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/ScopeLocal.java Changeset: 6e86a24b Author: Alan Bateman Date: 2022-03-13 19:14:24 +0000 URL: https://git.openjdk.java.net/loom/commit/6e86a24bca66774cad6007a8a4219e93facfe4d4 Remove spurius space ! test/lib/jdk/test/lib/process/ProcessTools.java Changeset: d1526407 Author: Alan Bateman Date: 2022-03-13 19:47:46 +0000 URL: https://git.openjdk.java.net/loom/commit/d1526407425c9069dba7d2fcfa833e1d59297e66 Remove list of methods that no longer exist from strace stress tests ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/vmTestbase/nsk/stress/strace/strace001.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/strace/strace002.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/strace/strace003.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/strace/strace004.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/strace/strace005.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/strace/strace006.java Changeset: d47a53f1 Author: Alan Bateman Date: 2022-03-14 06:54:14 +0000 URL: https://git.openjdk.java.net/loom/commit/d47a53f1d68b52526d2074271297d14c8bb15fc7 INVALID_THREAD does not mean thread has terminated ! make/data/jdwp/jdwp.spec Changeset: a47b9b24 Author: Alan Bateman Date: 2022-03-14 07:04:26 +0000 URL: https://git.openjdk.java.net/loom/commit/a47b9b24d4c3d653554ca3db7deb7d99d084fe4e Cleanup ! src/java.base/share/classes/java/lang/Thread.java From duke at openjdk.java.net Mon Mar 14 10:23:39 2022 From: duke at openjdk.java.net (duke) Date: Mon, 14 Mar 2022 10:23:39 GMT Subject: git: openjdk/loom: fibers: 4 new changesets Message-ID: <6255ce31-5226-4936-bd67-bdb673db0b45@openjdk.java.net> Changeset: c537886f Author: Erik ?sterlund Date: 2022-03-11 12:17:43 +0000 URL: https://git.openjdk.java.net/loom/commit/c537886ffa0eb29f198883063a3b02bf49179cc5 Remove should_fix code and reduce templates ! src/hotspot/share/gc/epsilon/epsilonHeap.hpp ! src/hotspot/share/gc/g1/g1BarrierSet.hpp ! src/hotspot/share/gc/g1/g1BarrierSet.inline.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp ! src/hotspot/share/gc/shared/barrierSet.hpp ! src/hotspot/share/gc/shared/barrierSet.inline.hpp ! src/hotspot/share/gc/shared/collectedHeap.hpp ! src/hotspot/share/gc/shared/genCollectedHeap.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp ! src/hotspot/share/gc/z/zBarrierSet.hpp ! src/hotspot/share/gc/z/zBarrierSet.inline.hpp ! src/hotspot/share/gc/z/zCollectedHeap.hpp ! src/hotspot/share/gc/z/zCollectedHeap.inline.hpp ! src/hotspot/share/oops/instanceStackChunkKlass.hpp ! src/hotspot/share/oops/instanceStackChunkKlass.inline.hpp ! src/hotspot/share/oops/oopsHierarchy.hpp ! src/hotspot/share/oops/stackChunkOop.hpp ! src/hotspot/share/oops/stackChunkOop.inline.hpp ! src/hotspot/share/runtime/continuation.cpp ! src/hotspot/share/runtime/handles.hpp Changeset: 9c6e48ef Author: Erik ?sterlund Date: 2022-03-11 15:36:25 +0000 URL: https://git.openjdk.java.net/loom/commit/9c6e48ef968a44e803732005382f632946cb3d65 Remove gcSP and FIX_DERIVED_POINTERS remains ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/javaClasses.inline.hpp ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/oops/instanceStackChunkKlass.cpp ! src/hotspot/share/oops/instanceStackChunkKlass.hpp ! src/hotspot/share/oops/stackChunkOop.hpp ! src/hotspot/share/oops/stackChunkOop.inline.hpp ! src/hotspot/share/runtime/continuation.cpp Changeset: a6e1486a Author: Erik ?sterlund Date: 2022-03-11 15:42:35 +0000 URL: https://git.openjdk.java.net/loom/commit/a6e1486a5fb60ca46a2665c53bec6d27f45dab28 Remove gc_type templates ! src/hotspot/share/oops/instanceStackChunkKlass.cpp ! src/hotspot/share/oops/instanceStackChunkKlass.hpp ! src/hotspot/share/oops/instanceStackChunkKlass.inline.hpp ! src/hotspot/share/oops/stackChunkOop.hpp Changeset: ba68b138 Author: Erik ?sterlund Date: 2022-03-11 16:22:54 +0000 URL: https://git.openjdk.java.net/loom/commit/ba68b138b5896e2725dc586747f46825ae1e91fa Remove dead code ! src/hotspot/cpu/x86/interp_masm_x86.cpp From coleenp at openjdk.java.net Mon Mar 14 12:45:40 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Mon, 14 Mar 2022 12:45:40 GMT Subject: RFR: Make addressing mode a property of the C++ frame type Message-ID: I added an assert in most of the places where we had . Passes loom-tier1,loom-tier2,loom-tier3. ------------- Commit messages: - Fix function name. - Make addressing mode a property of the C++ frame type, which requires setting it when frames are created for stack chunk oops, and during freezing and thawing. Changes: https://git.openjdk.java.net/loom/pull/100/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=100&range=00 Stats: 400 lines in 35 files changed: 107 ins; 146 del; 147 mod Patch: https://git.openjdk.java.net/loom/pull/100.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/100/head:pull/100 PR: https://git.openjdk.java.net/loom/pull/100 From coleenp at openjdk.java.net Mon Mar 14 12:45:40 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Mon, 14 Mar 2022 12:45:40 GMT Subject: RFR: Make addressing mode a property of the C++ frame type In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 12:35:46 GMT, Coleen Phillimore wrote: > I added an assert in most of the places where we had . > Passes loom-tier1,loom-tier2,loom-tier3. I rebased this and am trying to build with other platforms. ------------- PR: https://git.openjdk.java.net/loom/pull/100 From coleenp at openjdk.java.net Mon Mar 14 14:09:03 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Mon, 14 Mar 2022 14:09:03 GMT Subject: RFR: Make addressing mode a property of the C++ frame type [v2] In-Reply-To: References: Message-ID: > I added an assert in most of the places where we had . > Passes loom-tier1,loom-tier2,loom-tier3. Coleen Phillimore has updated the pull request incrementally with two additional commits since the last revision: - Fix other platform bits. - merge error ------------- Changes: - all: https://git.openjdk.java.net/loom/pull/100/files - new: https://git.openjdk.java.net/loom/pull/100/files/105cf01c..39a8cfa3 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=loom&pr=100&range=01 - incr: https://webrevs.openjdk.java.net/?repo=loom&pr=100&range=00-01 Stats: 10 lines in 4 files changed: 0 ins; 7 del; 3 mod Patch: https://git.openjdk.java.net/loom/pull/100.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/100/head:pull/100 PR: https://git.openjdk.java.net/loom/pull/100 From coleenp at openjdk.java.net Mon Mar 14 16:14:45 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Mon, 14 Mar 2022 16:14:45 GMT Subject: RFR: Make addressing mode a property of the C++ frame type [v3] In-Reply-To: References: Message-ID: > I added an assert in most of the places where we had . > Passes loom-tier1,loom-tier2,loom-tier3. Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision: Fix other platform bits. ------------- Changes: - all: https://git.openjdk.java.net/loom/pull/100/files - new: https://git.openjdk.java.net/loom/pull/100/files/39a8cfa3..e6430e5c Webrevs: - full: https://webrevs.openjdk.java.net/?repo=loom&pr=100&range=02 - incr: https://webrevs.openjdk.java.net/?repo=loom&pr=100&range=01-02 Stats: 22 lines in 3 files changed: 7 ins; 0 del; 15 mod Patch: https://git.openjdk.java.net/loom/pull/100.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/100/head:pull/100 PR: https://git.openjdk.java.net/loom/pull/100 From duke at openjdk.java.net Mon Mar 14 18:37:42 2022 From: duke at openjdk.java.net (duke) Date: Mon, 14 Mar 2022 18:37:42 GMT Subject: git: openjdk/loom: fibers: 3 new changesets Message-ID: Changeset: 8e4c0298 Author: Alan Bateman Date: 2022-03-14 12:11:55 +0000 URL: https://git.openjdk.java.net/loom/commit/8e4c0298b61e1255b30a3f696f80706b1bfba4a2 Fixed build issue ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp Changeset: 70a8ecce Author: Alan Bateman Date: 2022-03-14 12:59:30 +0000 URL: https://git.openjdk.java.net/loom/commit/70a8ecce86329e1b5c76c1fd4441eb4fb6fa7718 Spec clarification ! src/java.base/share/classes/java/lang/ThreadGroup.java Changeset: 1f489c56 Author: Alan Bateman Date: 2022-03-14 15:47:12 +0000 URL: https://git.openjdk.java.net/loom/commit/1f489c56c57ea19abbb1b468dfa04508e4469304 TG.list needs to allow for threads to terminate ! src/java.base/share/classes/java/lang/ThreadGroup.java From duke at openjdk.java.net Mon Mar 14 20:12:06 2022 From: duke at openjdk.java.net (duke) Date: Mon, 14 Mar 2022 20:12:06 GMT Subject: git: openjdk/loom: fibers: Make addressing mode a property of the C++ frame type Message-ID: Changeset: af5cef8c Author: Coleen Phillimore Date: 2022-03-14 20:11:28 +0000 URL: https://git.openjdk.java.net/loom/commit/af5cef8c9e2843179b760327c15e798da2c44070 Make addressing mode a property of the C++ frame type ! src/hotspot/cpu/aarch64/continuation_aarch64.inline.hpp ! src/hotspot/cpu/aarch64/frame_aarch64.cpp ! src/hotspot/cpu/aarch64/frame_aarch64.hpp ! src/hotspot/cpu/aarch64/frame_aarch64.inline.hpp ! src/hotspot/cpu/aarch64/frame_helpers_aarch64.inline.hpp ! src/hotspot/cpu/aarch64/instanceStackChunkKlass_aarch64.inline.hpp ! src/hotspot/cpu/arm/frame_arm.cpp ! src/hotspot/cpu/arm/frame_arm.hpp ! src/hotspot/cpu/arm/frame_arm.inline.hpp ! src/hotspot/cpu/arm/frame_helpers_arm.inline.hpp ! src/hotspot/cpu/ppc/frame_helpers_ppc.inline.hpp ! src/hotspot/cpu/ppc/frame_ppc.cpp ! src/hotspot/cpu/ppc/frame_ppc.hpp ! src/hotspot/cpu/ppc/frame_ppc.inline.hpp ! src/hotspot/cpu/s390/frame_helpers_s390.inline.hpp ! src/hotspot/cpu/s390/frame_s390.cpp ! src/hotspot/cpu/s390/frame_s390.hpp ! src/hotspot/cpu/s390/frame_s390.inline.hpp ! src/hotspot/cpu/x86/continuation_x86.inline.hpp ! src/hotspot/cpu/x86/frame_helpers_x86.inline.hpp ! src/hotspot/cpu/x86/frame_x86.cpp ! src/hotspot/cpu/x86/frame_x86.hpp ! src/hotspot/cpu/x86/frame_x86.inline.hpp ! src/hotspot/cpu/x86/instanceStackChunkKlass_x86.inline.hpp ! src/hotspot/cpu/zero/frame_helpers_zero.inline.hpp ! src/hotspot/cpu/zero/frame_zero.cpp ! src/hotspot/cpu/zero/frame_zero.hpp ! src/hotspot/cpu/zero/frame_zero.inline.hpp ! src/hotspot/share/oops/instanceStackChunkKlass.cpp ! src/hotspot/share/oops/instanceStackChunkKlass.inline.hpp ! src/hotspot/share/oops/stackChunkOop.inline.hpp ! src/hotspot/share/runtime/continuation.cpp ! src/hotspot/share/runtime/frame.cpp ! src/hotspot/share/runtime/frame.hpp ! src/hotspot/share/runtime/frame_helpers.inline.hpp From coleenp at openjdk.java.net Mon Mar 14 20:14:12 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Mon, 14 Mar 2022 20:14:12 GMT Subject: RFR: Make addressing mode a property of the C++ frame type [v3] In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 16:14:45 GMT, Coleen Phillimore wrote: >> I added an assert in most of the places where we had . >> Passes loom-tier1,loom-tier2,loom-tier3. > > Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision: > > Fix other platform bits. Thanks Ron for reviewing offline and further suggestions. ------------- PR: https://git.openjdk.java.net/loom/pull/100 From coleenp at openjdk.java.net Mon Mar 14 20:14:13 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Mon, 14 Mar 2022 20:14:13 GMT Subject: Integrated: Make addressing mode a property of the C++ frame type In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 12:35:46 GMT, Coleen Phillimore wrote: > I added an assert in most of the places where we had . > Passes loom-tier1,loom-tier2,loom-tier3. This pull request has now been integrated. Changeset: af5cef8c Author: Coleen Phillimore URL: https://git.openjdk.java.net/loom/commit/af5cef8c9e2843179b760327c15e798da2c44070 Stats: 414 lines in 35 files changed: 114 ins; 153 del; 147 mod Make addressing mode a property of the C++ frame type ------------- PR: https://git.openjdk.java.net/loom/pull/100 From duke at openjdk.java.net Mon Mar 14 20:19:35 2022 From: duke at openjdk.java.net (duke) Date: Mon, 14 Mar 2022 20:19:35 GMT Subject: git: openjdk/loom: fibers: Missed aarch64 one. Message-ID: <07ad52d2-db72-479a-b320-ea9a97ea16dc@openjdk.java.net> Changeset: 0e0cf2ec Author: Coleen Phillimore Date: 2022-03-14 20:18:33 +0000 URL: https://git.openjdk.java.net/loom/commit/0e0cf2ecec215c7a2ae37fe7cf6c4e0796452960 Missed aarch64 one. ! src/hotspot/cpu/aarch64/continuation_aarch64.inline.hpp From duke at openjdk.java.net Mon Mar 14 20:35:40 2022 From: duke at openjdk.java.net (duke) Date: Mon, 14 Mar 2022 20:35:40 GMT Subject: git: openjdk/loom: fibers: 4 new changesets Message-ID: Changeset: 6338bc16 Author: Ron Pressler Date: 2022-03-14 19:16:18 +0000 URL: https://git.openjdk.java.net/loom/commit/6338bc162437213aa6f8ff6833c945bb09817b0d - ! src/hotspot/share/runtime/continuation.cpp Changeset: 1032840f Author: Ron Pressler Date: 2022-03-14 19:17:14 +0000 URL: https://git.openjdk.java.net/loom/commit/1032840fc5cfc15c8bb8e0420324b6e7d33d2cdc Remove continuation scopes from java_lang_Thread::async_get_stack_trace ! src/hotspot/share/classfile/javaClasses.cpp Changeset: 46da0dd7 Author: Ron Pressler Date: 2022-03-14 19:29:33 +0000 URL: https://git.openjdk.java.net/loom/commit/46da0dd72b269d470b40e9f13235ef342c387a42 Set RegisterMap to process_frames in ThreadStackTrace::dump_stack_at_safepoint ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/services/threadService.cpp Changeset: a6ea22fb Author: Ron Pressler Date: 2022-03-14 20:34:02 +0000 URL: https://git.openjdk.java.net/loom/commit/a6ea22fba154ba9021decf46acd6a44cdc2a5042 Move calculation of Method::_num_stack_arg_slots to Fingerprinter (startup performance regression) ! src/hotspot/share/oops/constMethod.hpp ! src/hotspot/share/oops/method.cpp ! src/hotspot/share/oops/method.hpp ! src/hotspot/share/runtime/signature.cpp ! src/hotspot/share/runtime/signature.hpp ! src/hotspot/share/runtime/vmStructs.cpp From duke at openjdk.java.net Mon Mar 14 20:41:43 2022 From: duke at openjdk.java.net (duke) Date: Mon, 14 Mar 2022 20:41:43 GMT Subject: git: openjdk/loom: fibers: minor cleanup Message-ID: Changeset: 62409013 Author: Chris Plummer Date: 2022-03-14 20:40:02 +0000 URL: https://git.openjdk.java.net/loom/commit/62409013ab62896ebd915261f22bfee929396980 minor cleanup ! src/jdk.jdwp.agent/share/native/libjdwp/ThreadReferenceImpl.c ! src/jdk.jdwp.agent/share/native/libjdwp/threadControl.c From coleenp at openjdk.java.net Tue Mar 15 00:58:06 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Tue, 15 Mar 2022 00:58:06 GMT Subject: RFR: Revert non-const ref from leftover from prior change. Message-ID: Minor remanent from prior change, and I fixed the other platforms while I was there. ------------- Commit messages: - Revert non-const ref from leftover from prior change. Changes: https://git.openjdk.java.net/loom/pull/101/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=101&range=00 Stats: 21 lines in 7 files changed: 0 ins; 8 del; 13 mod Patch: https://git.openjdk.java.net/loom/pull/101.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/101/head:pull/101 PR: https://git.openjdk.java.net/loom/pull/101 From lmesnik at openjdk.java.net Tue Mar 15 01:38:13 2022 From: lmesnik at openjdk.java.net (Leonid Mesnik) Date: Tue, 15 Mar 2022 01:38:13 GMT Subject: RFR: Better jdb support for vthreads. Improved jdb vthread testing support. [v5] In-Reply-To: References: Message-ID: On Tue, 8 Mar 2022 20:41:26 GMT, Chris Plummer wrote: >> This PR contains a set of some what disparate but related set of changes to JDB, JDI, and nsk jdb tests and test support (Jdb.java). >> >> jdb: Made the ?kill? command support `ThreadReference.stop()` throwing `IllegalThreadStateException` for vthreads, because this is how `ThreadReference.stop()` is now spec?d. This change is in `Commands.java`. The rest of the changes are just cleanup. One of the changes in the `kill001` test is to test for this (see below) >> >> jdb: Use `PlatformThreadOnlyFilters` to prevent `ThreadStart/Death` event for vthreads. Instead detect vthreads when events are received on them. The goal here is to prevent jdb from getting a flood of `ThreadStart/Death` events, and getting bogged down with them. With the `PlatformThreadOnlyFilters` in place, this means jdb is not notified when a vthread dies, even one that it learned about later when an event came in on it. For these each of these ?learned? vthreads a separate `ThreadDeathRequest` is needed that uses the thread itself as a `ThreadFilter`. This way jdb can tell when these vthreads die. This part is handled in `EventHandler.java`. `VMConnection.java` is where `PlatformThreadOnlyFilters` are added. >> >> jdb: Add `-trackallvthreads` option. This prevents the use of the `PlatformThreadsOnlyFilters` described above, and instead relies on jdb getting the initial set of vthreads from the debug agent via `VM.allThreads()` (by turning on the `enumeratevthreads` option), and by getting a `ThreadStart/Death` event for every vthread created/destroyed after connecting. This is basially how jdb used to work by default before any changes in this PR. There are 3 tests that rely on this behaviour and need this flag. They are `kill001`, `threads002`, and `trace001` (see below). Many more would rely on it if they were converted to use vthreads as these tests were. The bulk of the changes for this support comes from having to pass `trackAllVthreads` through all sorts of constuctors/inits. I wish there were a better way, but I couldn?t find a place to store this value as a static so it is easy to access. If you see a better way, let me know. >> >> jdb: Track vthreads separately. jdb keeps track of every thread by creating a `ThreadInfo` for each and storing it in a `List` called `threads`. I decided to store vthreads in a separate list. The reason is the list is needed by the `threads` command. It doesn?t use the `threads` list, but instead walks the `ThreadGroup` hierarchy and prints out the threads within each `ThreadGroup`. This doesn?t capture vthreads since they are not returned by `ThreadGroupReference.threads()`, even for the `VirtualThreads` group. So after the `threads` command has done its usual `ThreadGroup` traversal, it now also dumps all the vthreads. This is pretty much all hidden in `ThreadIterator.next()`, which automically transitions to getting threads from the vthread list after traversing all the `ThreadGroups`. >> >> `nsk/share/jdb/Jdb.java`: Added support for `getThreadIdsByName()`: There are many jdb tests that use `Jdb.getThreadIds()` to get all threads in the `threads` output that are an instance of ``. The problem is that after converting a test to support a vthread mode for all debuggee threads, the name of the class in the output will always be `java.lang.VirtualThread` (or `java.lang.Thread` when not in vthread mode), and not the test specific class name, which is usually something like `MyThread`. Making `getThreadIds()` search for `java.lang.VirtualThreads` usually ends up including threads not wanted (ones that are not `MyThread`) such as the main test thread. So `getThreadIdsByName()` was added to allow searching by the thread name (actually just the prefix of the name) rather than its class. As an example, the `threads` command output used to contain a line such as: >> >> ` (nsk.jdb.kill.kill001.MyThread)693 Thread-0 waiting in a monitor` >> >> Now it contains: >> >> ` (java.lang.Thread)693 MyThread-0 waiting in a monitor` >> >> So instead of searching for ?(MyThread)? and grabbing the threadId that comes right after it, `getThreadIdsByName()` first finds all the lines of output that contain ?nsk.jdb.kill.kill001.MyThread?, and then for those lines only gets the threadID that is right after ?(java.lang.Thread)? or ?(java.lang.VirtualThread)?. >> >> jdb `kill001` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. Use new `getThreadIdsByName()` support instead of `getThreadIds()`. Allow/expect the `kill` command to fail with "Illegal thread state? when in vthread mode. >> >> jdb `threads002` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. I forget why I decided to convert this test. Seems it was useful for testing something I was working on for this PR, but I can?t recall. Maybe it was so I could clone it for the new `threads003` test below. >> >> jdb `trace001` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. This is a test I had converted long ago when I first experimented with the `getThreadIdsByName()` support, so I included it with this PR. >> >> jdb `threads003` test: This is a new thread test that tests jdb?s ability to learn about a thread when an event arrives on it. It creates 5 threads, two of which receive a breakpoint. It looks at the `threads` output and checks that only those two vthreads are present. I also used this test to help confirm that the `ThreadDeath` events are only received for these two vthreads. This was done manually by looking for the ?TDR removed? output generated by `EventHandler.threadDeathEvent()`. I didn?t put this into the test itself since that println is just for debugging and is now commented out. > > Chris Plummer has updated the pull request incrementally with two additional commits since the last revision: > > - Improved instanceof usage. > - Minor cleanup of code structure test/hotspot/jtreg/vmTestbase/nsk/jdb/threads/threads002/threads002a.java line 57: > 55: for (int i = 0; i < numThreads ; i++) { > 56: String name = THREAD_NAME + "-" + i; > 57: holder[i] = JDIThreadFactory.newThread(new MyThread(lock), name); Please change MyThread to implements Runnable from extends Thread. test/hotspot/jtreg/vmTestbase/nsk/jdb/threads/threads003/threads003a.java line 106: > 104: } > 105: > 106: class MyThread extends Thread { Please change MyThread to implements Runnable from extends Thread. ------------- PR: https://git.openjdk.java.net/loom/pull/97 From coleenp at openjdk.java.net Tue Mar 15 13:22:14 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Tue, 15 Mar 2022 13:22:14 GMT Subject: Integrated: Revert non-const ref from leftover from prior change. In-Reply-To: References: Message-ID: On Tue, 15 Mar 2022 00:52:23 GMT, Coleen Phillimore wrote: > Minor remanent from prior change, and I fixed the other platforms while I was there. This pull request has now been integrated. Changeset: b9c4e8e6 Author: Coleen Phillimore URL: https://git.openjdk.java.net/loom/commit/b9c4e8e6cd373506b7c68bdd7c1ec998ae042127 Stats: 21 lines in 7 files changed: 0 ins; 8 del; 13 mod Revert non-const ref from leftover from prior change. ------------- PR: https://git.openjdk.java.net/loom/pull/101 From duke at openjdk.java.net Tue Mar 15 14:25:00 2022 From: duke at openjdk.java.net (duke) Date: Tue, 15 Mar 2022 14:25:00 GMT Subject: git: openjdk/loom: fibers: 3 new changesets Message-ID: <21880613-ecea-4ff5-9dd0-4c1d07c8247c@openjdk.java.net> Changeset: 15fcb68d Author: Erik ?sterlund Date: 2022-03-14 12:07:25 +0000 URL: https://git.openjdk.java.net/loom/commit/15fcb68dc3edfed22ce347aaea8302162ce2c2f4 Workaround for inaccurate derived pointer oop maps ! src/hotspot/share/oops/instanceStackChunkKlass.cpp Changeset: f222b4f9 Author: Erik ?sterlund Date: 2022-03-14 12:21:35 +0000 URL: https://git.openjdk.java.net/loom/commit/f222b4f92136246355d3506d0d685a5999fd2fc0 Move ZGC barrier assert to slow path to avoid false positives ! src/hotspot/share/gc/z/zBarrier.cpp ! src/hotspot/share/gc/z/zBarrier.inline.hpp Changeset: 70366bed Author: Erik ?sterlund Date: 2022-03-15 08:23:37 +0000 URL: https://git.openjdk.java.net/loom/commit/70366bedf0305e9fedb8987103b487654acc194d Thaw shouldn't take fast path if chunk has been GCed ! src/hotspot/share/oops/stackChunkOop.hpp ! src/hotspot/share/oops/stackChunkOop.inline.hpp ! src/hotspot/share/runtime/continuation.cpp From duke at openjdk.java.net Tue Mar 15 15:11:51 2022 From: duke at openjdk.java.net (duke) Date: Tue, 15 Mar 2022 15:11:51 GMT Subject: git: openjdk/loom: fibers: 2 new changesets Message-ID: Changeset: 1b9b3782 Author: Coleen Phillimore Date: 2022-03-15 14:23:28 +0000 URL: https://git.openjdk.java.net/loom/commit/1b9b37825736eb467e6fbbca8afbb9ef9ee64a43 Missed an aarch64 one again. ! src/hotspot/cpu/aarch64/continuation_aarch64.inline.hpp Changeset: a1860a44 Author: Coleen Phillimore Date: 2022-03-15 15:09:43 +0000 URL: https://git.openjdk.java.net/loom/commit/a1860a447721440ceb7b273442828410703ecea0 Merge branch 'fibers' of github:openjdk/loom into fibers From eosterlund at openjdk.java.net Tue Mar 15 15:43:24 2022 From: eosterlund at openjdk.java.net (Erik =?UTF-8?B?w5ZzdGVybHVuZA==?=) Date: Tue, 15 Mar 2022 15:43:24 GMT Subject: RFR: 8282209: G1: Use synchronous concurrent marking for the code cache In-Reply-To: References: Message-ID: On Tue, 15 Mar 2022 15:33:47 GMT, Leo Korinth wrote: > This fix removes collect_for_codecache(), and uses collect() directly instead. This has the advantage that the g1 code path can be run concurrently using a concurrent mark instead of a full gc. Looks good. Ship it! ------------- Marked as reviewed by eosterlund (Committer). PR: https://git.openjdk.java.net/loom/pull/102 From duke at openjdk.java.net Tue Mar 15 16:12:33 2022 From: duke at openjdk.java.net (duke) Date: Tue, 15 Mar 2022 16:12:33 GMT Subject: git: openjdk/loom: fibers: 2 new changesets Message-ID: <13c3f40f-8c1b-4a13-8a6e-fca350e07245@openjdk.java.net> Changeset: 1f0a0ecf Author: Ron Pressler Date: 2022-03-15 16:09:23 +0000 URL: https://git.openjdk.java.net/loom/commit/1f0a0ecf4ce8ba870a43fb57c9b57399eed0fbc7 Add a comment explaining CONT_JFR ! src/hotspot/share/runtime/continuation.cpp Changeset: b03e5cda Author: Ron Pressler Date: 2022-03-15 16:09:59 +0000 URL: https://git.openjdk.java.net/loom/commit/b03e5cda6340dec68c3e613e5096e6a134d1c714 Fix barriers on preemption ! src/hotspot/share/runtime/continuation.cpp From duke at openjdk.java.net Tue Mar 15 16:14:52 2022 From: duke at openjdk.java.net (duke) Date: Tue, 15 Mar 2022 16:14:52 GMT Subject: git: openjdk/loom: fibers: 4 new changesets Message-ID: <74cc1e74-c75b-442d-a93b-d7c17c8d7a4b@openjdk.java.net> Changeset: c967022f Author: Alan Bateman Date: 2022-03-15 07:49:36 +0000 URL: https://git.openjdk.java.net/loom/commit/c967022f153ca938a7a859a288676372fb417d22 Rename field ! src/java.base/share/classes/sun/nio/ch/DatagramChannelImpl.java ! src/java.base/share/classes/sun/nio/ch/ServerSocketChannelImpl.java ! src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java Changeset: 9e74d2e7 Author: Alan Bateman Date: 2022-03-15 10:26:03 +0000 URL: https://git.openjdk.java.net/loom/commit/9e74d2e759c4149d6a9d8c9890cf2d348a6bfbfd Cleanup ! src/java.base/share/classes/java/lang/System.java ! src/java.base/share/classes/java/lang/VirtualThread.java ! src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java ! src/java.base/share/classes/jdk/internal/misc/VirtualThreads.java Changeset: d9d14aae Author: Alan Bateman Date: 2022-03-15 13:54:15 +0000 URL: https://git.openjdk.java.net/loom/commit/d9d14aaef545b08d66eca2cb709c8c5a3f4725a2 Exclude GCMBufferTest from -Xcomp runs ! test/jdk/ProblemList-Xcomp.txt Changeset: fa42f2b8 Author: Alan Bateman Date: 2022-03-15 13:54:34 +0000 URL: https://git.openjdk.java.net/loom/commit/fa42f2b809a975aa7e21e0cbacb6ec029eb863e8 Update GetFrameCount/framecnt01 to align with current impl ! test/hotspot/jtreg/serviceability/jvmti/thread/GetFrameCount/framecnt01/framecnt01.java From duke at openjdk.java.net Tue Mar 15 18:58:57 2022 From: duke at openjdk.java.net (duke) Date: Tue, 15 Mar 2022 18:58:57 GMT Subject: git: openjdk/loom: fibers: Add ContinuationEntry::is_virtual_thread() Message-ID: <5695f92b-f28f-45e7-acfa-f86fc01ec8a3@openjdk.java.net> Changeset: 8a0c83ef Author: Ron Pressler Date: 2022-03-15 18:57:34 +0000 URL: https://git.openjdk.java.net/loom/commit/8a0c83ef7888e3e72b56abca94e5aa937e82b93b Add ContinuationEntry::is_virtual_thread() ! src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/vmIntrinsics.hpp ! src/hotspot/share/runtime/continuation.cpp ! src/hotspot/share/runtime/continuation.hpp ! src/hotspot/share/runtime/frame.cpp ! src/hotspot/share/runtime/thread.inline.hpp ! src/hotspot/share/runtime/vframe.inline.hpp ! src/java.base/share/classes/java/lang/System.java ! src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java ! src/java.base/share/classes/jdk/internal/vm/Continuation.java ! test/jdk/jdk/internal/vm/Continuation/Preempt.java From eosterlund at openjdk.java.net Wed Mar 16 08:00:07 2022 From: eosterlund at openjdk.java.net (Erik =?UTF-8?B?w5ZzdGVybHVuZA==?=) Date: Wed, 16 Mar 2022 08:00:07 GMT Subject: RFR: 8282209: G1: Use synchronous concurrent marking for the code cache [v3] In-Reply-To: <1ngjw0z1d2QwjMzAVOC7J4nkl-SxEtvdwgywxmUhdC4=.0e6dc2db-72d0-43d2-948f-e0286957ab63@github.com> References: <1ngjw0z1d2QwjMzAVOC7J4nkl-SxEtvdwgywxmUhdC4=.0e6dc2db-72d0-43d2-948f-e0286957ab63@github.com> Message-ID: On Tue, 15 Mar 2022 17:20:47 GMT, Leo Korinth wrote: >> This fix removes collect_for_codecache(), and uses collect() directly instead. This has the advantage that the g1 code path can be run concurrently using a concurrent mark instead of a full gc. > > Leo Korinth has updated the pull request incrementally with one additional commit since the last revision: > > fix whitespace Looks good. Ship it! ------------- Marked as reviewed by eosterlund (Committer). PR: https://git.openjdk.java.net/loom/pull/102 From eosterlund at openjdk.java.net Wed Mar 16 08:24:56 2022 From: eosterlund at openjdk.java.net (Erik =?UTF-8?B?w5ZzdGVybHVuZA==?=) Date: Wed, 16 Mar 2022 08:24:56 GMT Subject: RFR: Fix includes, braces, and whitespaces In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 06:41:09 GMT, Stefan Karlsson wrote: > Fix includes > - sort order > - missing includes > - .inline.hpp from .hpp file > > Add braces to if/for statements > > Fix whitespaces, newlines and alignment Very nice. Ship it! ------------- Marked as reviewed by eosterlund (Committer). PR: https://git.openjdk.java.net/loom/pull/103 From duke at openjdk.java.net Wed Mar 16 08:57:12 2022 From: duke at openjdk.java.net (duke) Date: Wed, 16 Mar 2022 08:57:12 GMT Subject: git: openjdk/loom: fibers: fix Kitchensink failures related to interp_only_mode for unmounted virtual threads Message-ID: <4fe07131-3b66-43bd-b83e-f352303a1e61@openjdk.java.net> Changeset: fb34338a Author: Serguei Spitsyn Date: 2022-03-16 08:55:42 +0000 URL: https://git.openjdk.java.net/loom/commit/fb34338ae26743c461676aca355c9d91c956cf6e fix Kitchensink failures related to interp_only_mode for unmounted virtual threads ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/prims/jvmtiEnv.cpp ! src/hotspot/share/prims/jvmtiEventController.cpp ! src/hotspot/share/prims/jvmtiEventController.hpp ! src/hotspot/share/prims/jvmtiThreadState.cpp ! src/hotspot/share/prims/jvmtiThreadState.hpp From duke at openjdk.java.net Wed Mar 16 10:16:35 2022 From: duke at openjdk.java.net (duke) Date: Wed, 16 Mar 2022 10:16:35 GMT Subject: git: openjdk/loom: fibers: 3 new changesets Message-ID: <7853e855-9d0c-4d2d-b08c-b26605f1ecb5@openjdk.java.net> Changeset: 0e8a8967 Author: Alan Bateman Date: 2022-03-15 18:08:34 +0000 URL: https://git.openjdk.java.net/loom/commit/0e8a89671369614c69f96442dbf4d33af1d3b3db Improve comment ! test/jdk/java/util/concurrent/ExecutorService/CloseTest.java Changeset: 187d7aed Author: Alan Bateman Date: 2022-03-16 07:19:16 +0000 URL: https://git.openjdk.java.net/loom/commit/187d7aed0736c1e81d93c15aba3f35af76e98d38 Increase max expected duration to allow for loaded test machines ! test/jdk/java/lang/Thread/JoinWithDuration.java ! test/jdk/java/lang/Thread/SleepWithDuration.java Changeset: 81750b3d Author: Alan Bateman Date: 2022-03-16 09:12:10 +0000 URL: https://git.openjdk.java.net/loom/commit/81750b3d48abec8893376ced15132e612c253b44 Make clear the cases where invalid thread is returned ! make/data/jdwp/jdwp.spec From lkorinth at openjdk.java.net Tue Mar 15 15:43:24 2022 From: lkorinth at openjdk.java.net (Leo Korinth) Date: Tue, 15 Mar 2022 15:43:24 GMT Subject: RFR: 8282209: G1: Use synchronous concurrent marking for the code cache Message-ID: This fix removes collect_for_codecache(), and uses collect() directly instead. This has the advantage that the g1 code path can be run concurrently using a concurrent mark instead of a full gc. ------------- Commit messages: - 8282209: G1: Use synchronous concurrent marking for the code cache Changes: https://git.openjdk.java.net/loom/pull/102/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=102&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282209 Stats: 132 lines in 11 files changed: 5 ins; 106 del; 21 mod Patch: https://git.openjdk.java.net/loom/pull/102.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/102/head:pull/102 PR: https://git.openjdk.java.net/loom/pull/102 From tschatzl at openjdk.java.net Tue Mar 15 15:56:52 2022 From: tschatzl at openjdk.java.net (Thomas Schatzl) Date: Tue, 15 Mar 2022 15:56:52 GMT Subject: RFR: 8282209: G1: Use synchronous concurrent marking for the code cache In-Reply-To: References: Message-ID: On Tue, 15 Mar 2022 15:33:47 GMT, Leo Korinth wrote: > This fix removes collect_for_codecache(), and uses collect() directly instead. This has the advantage that the g1 code path can be run concurrently using a concurrent mark instead of a full gc. Changes requested by tschatzl (no project role). src/hotspot/share/gc/g1/g1FullCollector.cpp line 198: > 196: // caches marked between the two concurrent marks will live a bit > 197: // longer than needed. > 198: CodeCache::start_marking_cycle(); Please add a helper method for this copy&paste in `G1CollectedHeap`. Something like `start_codecache_marking_cycle_if_inactive` (not perfect) or similar. src/hotspot/share/gc/g1/g1Policy.cpp line 1086: > 1084: (cause == GCCause::_wb_breakpoint)) { > 1085: // Initiate a user requested concurrent start or run to a breakpoint. > 1086: // A concurrent start must be young only GC, so the collector state The comment needs an update. to ------------- PR: https://git.openjdk.java.net/loom/pull/102 From lkorinth at openjdk.java.net Tue Mar 15 17:12:50 2022 From: lkorinth at openjdk.java.net (Leo Korinth) Date: Tue, 15 Mar 2022 17:12:50 GMT Subject: RFR: 8282209: G1: Use synchronous concurrent marking for the code cache [v2] In-Reply-To: References: Message-ID: > This fix removes collect_for_codecache(), and uses collect() directly instead. This has the advantage that the g1 code path can be run concurrently using a concurrent mark instead of a full gc. Leo Korinth has updated the pull request incrementally with one additional commit since the last revision: extract static method, and fixup comment ------------- Changes: - all: https://git.openjdk.java.net/loom/pull/102/files - new: https://git.openjdk.java.net/loom/pull/102/files/7c1a6c78..fc2b3863 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=loom&pr=102&range=01 - incr: https://webrevs.openjdk.java.net/?repo=loom&pr=102&range=00-01 Stats: 35 lines in 5 files changed: 13 ins; 17 del; 5 mod Patch: https://git.openjdk.java.net/loom/pull/102.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/102/head:pull/102 PR: https://git.openjdk.java.net/loom/pull/102 From lkorinth at openjdk.java.net Tue Mar 15 17:20:47 2022 From: lkorinth at openjdk.java.net (Leo Korinth) Date: Tue, 15 Mar 2022 17:20:47 GMT Subject: RFR: 8282209: G1: Use synchronous concurrent marking for the code cache [v3] In-Reply-To: References: Message-ID: <1ngjw0z1d2QwjMzAVOC7J4nkl-SxEtvdwgywxmUhdC4=.0e6dc2db-72d0-43d2-948f-e0286957ab63@github.com> > This fix removes collect_for_codecache(), and uses collect() directly instead. This has the advantage that the g1 code path can be run concurrently using a concurrent mark instead of a full gc. Leo Korinth has updated the pull request incrementally with one additional commit since the last revision: fix whitespace ------------- Changes: - all: https://git.openjdk.java.net/loom/pull/102/files - new: https://git.openjdk.java.net/loom/pull/102/files/fc2b3863..00b5a06e Webrevs: - full: https://webrevs.openjdk.java.net/?repo=loom&pr=102&range=02 - incr: https://webrevs.openjdk.java.net/?repo=loom&pr=102&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/loom/pull/102.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/102/head:pull/102 PR: https://git.openjdk.java.net/loom/pull/102 From tschatzl at openjdk.java.net Tue Mar 15 20:31:54 2022 From: tschatzl at openjdk.java.net (Thomas Schatzl) Date: Tue, 15 Mar 2022 20:31:54 GMT Subject: RFR: 8282209: G1: Use synchronous concurrent marking for the code cache [v3] In-Reply-To: <1ngjw0z1d2QwjMzAVOC7J4nkl-SxEtvdwgywxmUhdC4=.0e6dc2db-72d0-43d2-948f-e0286957ab63@github.com> References: <1ngjw0z1d2QwjMzAVOC7J4nkl-SxEtvdwgywxmUhdC4=.0e6dc2db-72d0-43d2-948f-e0286957ab63@github.com> Message-ID: On Tue, 15 Mar 2022 17:20:47 GMT, Leo Korinth wrote: >> This fix removes collect_for_codecache(), and uses collect() directly instead. This has the advantage that the g1 code path can be run concurrently using a concurrent mark instead of a full gc. > > Leo Korinth has updated the pull request incrementally with one additional commit since the last revision: > > fix whitespace Lgtm. Thanks. ------------- Marked as reviewed by tschatzl (no project role). PR: https://git.openjdk.java.net/loom/pull/102 From stefank at openjdk.java.net Wed Mar 16 07:00:29 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Wed, 16 Mar 2022 07:00:29 GMT Subject: RFR: Fix includes, braces, and whitespaces Message-ID: Fix includes - sort order - missing includes - .inline.hpp from .hpp file Add braces to if/for statements Fix whitespaces, newlines and alignment ------------- Commit messages: - Fix includes, braces, and whitespaces Changes: https://git.openjdk.java.net/loom/pull/103/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=103&range=00 Stats: 670 lines in 92 files changed: 354 ins; 109 del; 207 mod Patch: https://git.openjdk.java.net/loom/pull/103.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/103/head:pull/103 PR: https://git.openjdk.java.net/loom/pull/103 From stefank at openjdk.java.net Wed Mar 16 10:24:51 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Wed, 16 Mar 2022 10:24:51 GMT Subject: Integrated: Fix includes, braces, and whitespaces In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 06:41:09 GMT, Stefan Karlsson wrote: > Fix includes > - sort order > - missing includes > - .inline.hpp from .hpp file > > Add braces to if/for statements > > Fix whitespaces, newlines and alignment This pull request has now been integrated. Changeset: 174cc901 Author: Stefan Karlsson Committer: Alan Bateman URL: https://git.openjdk.java.net/loom/commit/174cc901529e2b1acead5587d39a07fa1e326d4a Stats: 670 lines in 92 files changed: 354 ins; 109 del; 207 mod Fix includes, braces, and whitespaces Reviewed-by: eosterlund ------------- PR: https://git.openjdk.java.net/loom/pull/103 From stefank at openjdk.java.net Wed Mar 16 11:00:24 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Wed, 16 Mar 2022 11:00:24 GMT Subject: RFR: Loom compile times Message-ID: It takes almost double the time to compile HotSpot in the Loom repository compared to the mainline. One source of this regression is the include of the *CollectedHeap.inline.hpp files in the *BarrierSet.inline.hpp files, needed to inline the requires_barriers call all the way down to the GC implementations. This patch removes the inlining and calls the virtual calls instead. This recuperate most of the lost compilation speed, but not quite all (still about a 20% regression). I've verified with a small micro that this doesn't increase the freeze/thaw times. In fact, it increased the performance slightly. Comparing the generated code, I see that the inlined code had two branches and made a jump to the fast path (and not the expected slow path). With the non-inlined call there's only one branch and the fast-path is right after the check. The two patches on top of the fix just removes infrastructure that isn't needed when this has been removed. ------------- Commit messages: - Remove ConfigT - Remove BarrierSet template parameter - Stop inlining BS requires_barriers Changes: https://git.openjdk.java.net/loom/pull/104/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=104&range=00 Stats: 177 lines in 13 files changed: 25 ins; 122 del; 30 mod Patch: https://git.openjdk.java.net/loom/pull/104.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/104/head:pull/104 PR: https://git.openjdk.java.net/loom/pull/104 From coleenp at openjdk.java.net Wed Mar 16 13:01:05 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Wed, 16 Mar 2022 13:01:05 GMT Subject: RFR: Loom compile times In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 10:54:26 GMT, Stefan Karlsson wrote: > It takes almost double the time to compile HotSpot in the Loom repository compared to the mainline. One source of this regression is the include of the *CollectedHeap.inline.hpp files in the *BarrierSet.inline.hpp files, needed to inline the requires_barriers call all the way down to the GC implementations. > > This patch removes the inlining and calls the virtual calls instead. This recuperate most of the lost compilation speed, but not quite all (still about a 20% regression). I've verified with a small micro that this doesn't increase the freeze/thaw times. In fact, it increased the performance slightly. Comparing the generated code, I see that the inlined code had two branches and made a jump to the fast path (and not the expected slow path). With the non-inlined call there's only one branch and the fast-path is right after the check. > > The two patches on top of the fix just removes infrastructure that isn't needed when this has been removed. Thanks Stefan, I'll apply your patch locally. ------------- Marked as reviewed by coleenp (Committer). PR: https://git.openjdk.java.net/loom/pull/104 From stefank at openjdk.java.net Wed Mar 16 13:35:07 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Wed, 16 Mar 2022 13:35:07 GMT Subject: RFR: Loom compile times In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 10:54:26 GMT, Stefan Karlsson wrote: > It takes almost double the time to compile HotSpot in the Loom repository compared to the mainline. One source of this regression is the include of the *CollectedHeap.inline.hpp files in the *BarrierSet.inline.hpp files, needed to inline the requires_barriers call all the way down to the GC implementations. > > This patch removes the inlining and calls the virtual calls instead. This recuperate most of the lost compilation speed, but not quite all (still about a 20% regression). I've verified with a small micro that this doesn't increase the freeze/thaw times. In fact, it increased the performance slightly. Comparing the generated code, I see that the inlined code had two branches and made a jump to the fast path (and not the expected slow path). With the non-inlined call there's only one branch and the fast-path is right after the check. > > The two patches on top of the fix just removes infrastructure that isn't needed when this has been removed. I've been asked to make a minimal change that keeps the ConfigT class. I'll publish a new PR. ------------- PR: https://git.openjdk.java.net/loom/pull/104 From stefank at openjdk.java.net Wed Mar 16 13:35:07 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Wed, 16 Mar 2022 13:35:07 GMT Subject: Withdrawn: Loom compile times In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 10:54:26 GMT, Stefan Karlsson wrote: > It takes almost double the time to compile HotSpot in the Loom repository compared to the mainline. One source of this regression is the include of the *CollectedHeap.inline.hpp files in the *BarrierSet.inline.hpp files, needed to inline the requires_barriers call all the way down to the GC implementations. > > This patch removes the inlining and calls the virtual calls instead. This recuperate most of the lost compilation speed, but not quite all (still about a 20% regression). I've verified with a small micro that this doesn't increase the freeze/thaw times. In fact, it increased the performance slightly. Comparing the generated code, I see that the inlined code had two branches and made a jump to the fast path (and not the expected slow path). With the non-inlined call there's only one branch and the fast-path is right after the check. > > The two patches on top of the fix just removes infrastructure that isn't needed when this has been removed. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/loom/pull/104 From stefank at openjdk.java.net Wed Mar 16 13:41:11 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Wed, 16 Mar 2022 13:41:11 GMT Subject: RFR: Loom compile times minimal Message-ID: <8HkBJl5_-bEPmZy2QMlMbfNLeAW6XVO7S3H58gB-6iU=.724d6d1f-50c4-4271-b899-fa4bf5031c35@github.com> (Minimal version of PR #104) It takes almost double the time to compile HotSpot in the Loom repository compared to the mainline. One source of this regression is the include of the *CollectedHeap.inline.hpp files in the *BarrierSet.inline.hpp files, needed to inline the requires_barriers call all the way down to the GC implementations. This patch removes the inlining and calls the virtual calls instead. This recuperate most of the lost compilation speed, but not quite all (still about a 20% regression). I've verified with a small micro that this doesn't increase the freeze/thaw times. In fact, it increased the performance slightly. Comparing the generated code, I see that the inlined code had two branches and made a jump to the fast path (and not the expected slow path). With the non-inlined call there's only one branch and the fast-path is right after the check. ------------- Commit messages: - Keep using ConfigT - Stop inlining BS requires_barriers Changes: https://git.openjdk.java.net/loom/pull/105/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=105&range=00 Stats: 102 lines in 13 files changed: 25 ins; 75 del; 2 mod Patch: https://git.openjdk.java.net/loom/pull/105.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/105/head:pull/105 PR: https://git.openjdk.java.net/loom/pull/105 From eosterlund at openjdk.java.net Wed Mar 16 14:10:48 2022 From: eosterlund at openjdk.java.net (Erik =?UTF-8?B?w5ZzdGVybHVuZA==?=) Date: Wed, 16 Mar 2022 14:10:48 GMT Subject: RFR: Loom compile times minimal In-Reply-To: <8HkBJl5_-bEPmZy2QMlMbfNLeAW6XVO7S3H58gB-6iU=.724d6d1f-50c4-4271-b899-fa4bf5031c35@github.com> References: <8HkBJl5_-bEPmZy2QMlMbfNLeAW6XVO7S3H58gB-6iU=.724d6d1f-50c4-4271-b899-fa4bf5031c35@github.com> Message-ID: On Wed, 16 Mar 2022 13:34:15 GMT, Stefan Karlsson wrote: > (Minimal version of PR #104) > > It takes almost double the time to compile HotSpot in the Loom repository compared to the mainline. One source of this regression is the include of the *CollectedHeap.inline.hpp files in the *BarrierSet.inline.hpp files, needed to inline the requires_barriers call all the way down to the GC implementations. > > This patch removes the inlining and calls the virtual calls instead. This recuperate most of the lost compilation speed, but not quite all (still about a 20% regression). I've verified with a small micro that this doesn't increase the freeze/thaw times. In fact, it increased the performance slightly. Comparing the generated code, I see that the inlined code had two branches and made a jump to the fast path (and not the expected slow path). With the non-inlined call there's only one branch and the fast-path is right after the check. Looks good. ------------- Marked as reviewed by eosterlund (Committer). PR: https://git.openjdk.java.net/loom/pull/105 From coleenp at openjdk.java.net Wed Mar 16 14:33:28 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Wed, 16 Mar 2022 14:33:28 GMT Subject: RFR: Note frames that are on the heap, rather than addressing mode Message-ID: ... for interpreted frames. This changes "addressing mode" to a boolean whether the frame is on the heap instead. The compiler frames don't have code that uses the relative offsets but the frames can be marked as on-heap anyway. There's one place that I passed false, not sure if that's right. Not urgent to code review. Tested with: alias loomjprt='mach5 --patch-based --extra-src-dirs /scratch/cphillim/hg/jdk-loom -j loom-tier1,loom-tier2,loom-tier3' ------------- Commit messages: - Note frames that are on the heap, rather than addressing mode for interpreted frames. - Note frames that are on the heap, rather than addressing mode for interpreted frames. Changes: https://git.openjdk.java.net/loom/pull/106/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=106&range=00 Stats: 152 lines in 20 files changed: 18 ins; 51 del; 83 mod Patch: https://git.openjdk.java.net/loom/pull/106.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/106/head:pull/106 PR: https://git.openjdk.java.net/loom/pull/106 From duke at openjdk.java.net Wed Mar 16 14:49:38 2022 From: duke at openjdk.java.net (duke) Date: Wed, 16 Mar 2022 14:49:38 GMT Subject: git: openjdk/loom: fibers: Loom compile times minimal Message-ID: <5ae23b45-2ef3-4204-b6f7-89991a413ac8@openjdk.java.net> Changeset: 970249de Author: Stefan Karlsson Committer: Alan Bateman Date: 2022-03-16 14:48:59 +0000 URL: https://git.openjdk.java.net/loom/commit/970249de8d97f881f1d596dbfca79c0fa4e33a02 Loom compile times minimal Reviewed-by: eosterlund ! src/hotspot/share/classfile/javaClasses.inline.hpp ! src/hotspot/share/gc/g1/g1BarrierSet.hpp ! src/hotspot/share/gc/g1/g1BarrierSet.inline.hpp ! src/hotspot/share/gc/shared/barrierSet.hpp ! src/hotspot/share/gc/shared/barrierSet.inline.hpp ! src/hotspot/share/gc/z/zBarrierSet.hpp ! src/hotspot/share/gc/z/zBarrierSet.inline.hpp ! src/hotspot/share/gc/z/zCollectedHeap.cpp ! src/hotspot/share/gc/z/zCollectedHeap.hpp - src/hotspot/share/gc/z/zCollectedHeap.inline.hpp ! src/hotspot/share/oops/instanceStackChunkKlass.cpp ! src/hotspot/share/runtime/continuation.cpp ! src/hotspot/share/runtime/threadSMR.cpp From stefank at openjdk.java.net Wed Mar 16 14:52:56 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Wed, 16 Mar 2022 14:52:56 GMT Subject: Integrated: Loom compile times minimal In-Reply-To: <8HkBJl5_-bEPmZy2QMlMbfNLeAW6XVO7S3H58gB-6iU=.724d6d1f-50c4-4271-b899-fa4bf5031c35@github.com> References: <8HkBJl5_-bEPmZy2QMlMbfNLeAW6XVO7S3H58gB-6iU=.724d6d1f-50c4-4271-b899-fa4bf5031c35@github.com> Message-ID: On Wed, 16 Mar 2022 13:34:15 GMT, Stefan Karlsson wrote: > (Minimal version of PR #104) > > It takes almost double the time to compile HotSpot in the Loom repository compared to the mainline. One source of this regression is the include of the *CollectedHeap.inline.hpp files in the *BarrierSet.inline.hpp files, needed to inline the requires_barriers call all the way down to the GC implementations. > > This patch removes the inlining and calls the virtual calls instead. This recuperate most of the lost compilation speed, but not quite all (still about a 20% regression). I've verified with a small micro that this doesn't increase the freeze/thaw times. In fact, it increased the performance slightly. Comparing the generated code, I see that the inlined code had two branches and made a jump to the fast path (and not the expected slow path). With the non-inlined call there's only one branch and the fast-path is right after the check. This pull request has now been integrated. Changeset: 970249de Author: Stefan Karlsson Committer: Alan Bateman URL: https://git.openjdk.java.net/loom/commit/970249de8d97f881f1d596dbfca79c0fa4e33a02 Stats: 102 lines in 13 files changed: 25 ins; 75 del; 2 mod Loom compile times minimal Reviewed-by: eosterlund ------------- PR: https://git.openjdk.java.net/loom/pull/105 From stefank at openjdk.java.net Wed Mar 16 15:00:19 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Wed, 16 Mar 2022 15:00:19 GMT Subject: RFR: Remove space after asserts Message-ID: Simple textual replacement of `assert (` with `assert(`. I've only changed asserts introduced/changed for Loom. ------------- Commit messages: - Remove space after asserts Changes: https://git.openjdk.java.net/loom/pull/107/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=107&range=00 Stats: 451 lines in 43 files changed: 0 ins; 0 del; 451 mod Patch: https://git.openjdk.java.net/loom/pull/107.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/107/head:pull/107 PR: https://git.openjdk.java.net/loom/pull/107 From tschatzl at openjdk.java.net Wed Mar 16 15:11:56 2022 From: tschatzl at openjdk.java.net (Thomas Schatzl) Date: Wed, 16 Mar 2022 15:11:56 GMT Subject: RFR: Remove space after asserts In-Reply-To: References: Message-ID: <_5F4QNN7E-0XIuRfDF1mCnkOY3tpfBj27TPVZUOIrhQ=.a61794ab-1caf-4124-a2a3-f1af873adf73@github.com> On Wed, 16 Mar 2022 14:54:49 GMT, Stefan Karlsson wrote: > Simple textual replacement of `assert (` with `assert(`. I've only changed asserts introduced/changed for Loom. Lgtm. ------------- Marked as reviewed by tschatzl (no project role). PR: https://git.openjdk.java.net/loom/pull/107 From stefank at openjdk.java.net Wed Mar 16 16:28:07 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Wed, 16 Mar 2022 16:28:07 GMT Subject: RFR: Remove space after asserts In-Reply-To: References: Message-ID: <83S8o1ca1Z6NCK2A3uKmQuGsa_vu2LjkM8FbtnKGSD8=.b3df5dfe-d96f-40d1-a759-2810d07a38fc@github.com> On Wed, 16 Mar 2022 14:54:49 GMT, Stefan Karlsson wrote: > Simple textual replacement of `assert (` with `assert(`. I've only changed asserts introduced/changed for Loom. Testing the defer command: ------------- PR: https://git.openjdk.java.net/loom/pull/107 From lkorinth at openjdk.java.net Wed Mar 16 16:36:58 2022 From: lkorinth at openjdk.java.net (Leo Korinth) Date: Wed, 16 Mar 2022 16:36:58 GMT Subject: Integrated: 8282209: G1: Use synchronous concurrent marking for the code cache In-Reply-To: References: Message-ID: On Tue, 15 Mar 2022 15:33:47 GMT, Leo Korinth wrote: > This fix removes collect_for_codecache(), and uses collect() directly instead. This has the advantage that the g1 code path can be run concurrently using a concurrent mark instead of a full gc. This pull request has now been integrated. Changeset: ebbf2016 Author: Leo Korinth Committer: Erik ?sterlund URL: https://git.openjdk.java.net/loom/commit/ebbf2016bee5b61552e2824183d2fad9cb8aabe0 Stats: 148 lines in 12 files changed: 15 ins; 120 del; 13 mod 8282209: G1: Use synchronous concurrent marking for the code cache Reviewed-by: eosterlund, tschatzl ------------- PR: https://git.openjdk.java.net/loom/pull/102 From stefank at openjdk.java.net Wed Mar 16 16:44:53 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Wed, 16 Mar 2022 16:44:53 GMT Subject: Integrated: Remove space after asserts In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 14:54:49 GMT, Stefan Karlsson wrote: > Simple textual replacement of `assert (` with `assert(`. I've only changed asserts introduced/changed for Loom. This pull request has now been integrated. Changeset: f4dd8759 Author: Stefan Karlsson Committer: Alan Bateman URL: https://git.openjdk.java.net/loom/commit/f4dd8759579e352b4f6491ad4aa2f6e81b7feae0 Stats: 451 lines in 43 files changed: 0 ins; 0 del; 451 mod Remove space after asserts Reviewed-by: tschatzl ------------- PR: https://git.openjdk.java.net/loom/pull/107 From rpressler at openjdk.java.net Wed Mar 16 16:55:04 2022 From: rpressler at openjdk.java.net (Ron Pressler) Date: Wed, 16 Mar 2022 16:55:04 GMT Subject: RFR: Note frames that are on the heap, rather than addressing mode In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 14:27:33 GMT, Coleen Phillimore wrote: > ... for interpreted frames. > This changes "addressing mode" to a boolean whether the frame is on the heap instead. The compiler frames don't have code that uses the relative offsets but the frames can be marked as on-heap anyway. > There's one place that I passed false, not sure if that's right. > Not urgent to code review. > Tested with: alias loomjprt='mach5 --patch-based --extra-src-dirs /scratch/cphillim/hg/jdk-loom -j loom-tier1,loom-tier2,loom-tier3' Marked as reviewed by rpressler (Lead). ------------- PR: https://git.openjdk.java.net/loom/pull/106 From duke at openjdk.java.net Wed Mar 16 23:02:35 2022 From: duke at openjdk.java.net (duke) Date: Wed, 16 Mar 2022 23:02:35 GMT Subject: git: openjdk/loom: fibers: 4 new changesets Message-ID: <4bff1ce9-b4f5-4728-8db9-da3f7e10ad35@openjdk.java.net> Changeset: 1260b775 Author: Ron Pressler Date: 2022-03-16 20:20:49 +0000 URL: https://git.openjdk.java.net/loom/commit/1260b7759af5a54bd9779169c3246db3531b94cc - ! src/hotspot/share/prims/stackwalk.cpp ! src/hotspot/share/runtime/frame_helpers.inline.hpp Changeset: ac390f61 Author: Ron Pressler Date: 2022-03-16 20:21:21 +0000 URL: https://git.openjdk.java.net/loom/commit/ac390f6169787899eb2b7afe86474a54793fbacc Implement Continuation::get_continuation_entry_for_entry_frame more correctly ! src/hotspot/share/runtime/continuation.cpp ! src/hotspot/share/runtime/continuation.hpp ! src/hotspot/share/runtime/frame.cpp Changeset: 0d8802d0 Author: Erik ?sterlund Committer: Ron Pressler Date: 2022-03-15 14:23:47 +0000 URL: https://git.openjdk.java.net/loom/commit/0d8802d0e59ef85e158b21c31744d5f2f894ecb6 Dont patch displacment concurrently for post call nops ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/x86_64.ad ! src/hotspot/share/code/codeCache.cpp ! src/hotspot/share/code/codeCache.hpp ! src/hotspot/share/code/codeCache.inline.hpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/code/nmethod.hpp ! src/hotspot/share/code/relocInfo.hpp Changeset: 97864cda Author: Erik ?sterlund Committer: Ron Pressler Date: 2022-03-16 15:01:16 +0000 URL: https://git.openjdk.java.net/loom/commit/97864cda587bff0ea00812bf9563f4e47b95fe8d Optimize nmethod entry barriers on AArch64 ! src/hotspot/cpu/aarch64/gc/shared/barrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/shared/barrierSetAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/gc/shared/barrierSetNMethod_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/z/zBarrierSetAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/share/runtime/thread.hpp From duke at openjdk.java.net Thu Mar 17 09:11:47 2022 From: duke at openjdk.java.net (duke) Date: Thu, 17 Mar 2022 09:11:47 GMT Subject: git: openjdk/loom: fibers: 61 new changesets Message-ID: Changeset: 6d8d156c Author: Xue-Lei Andrew Fan Date: 2022-03-09 16:11:07 +0000 URL: https://git.openjdk.java.net/loom/commit/6d8d156c97b90a9ab4776c6b42563a962d959741 8280494: (D)TLS signature schemes Reviewed-by: mullan ! src/java.base/share/classes/javax/net/ssl/SSLParameters.java ! src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java ! src/java.base/share/classes/sun/security/ssl/SignatureScheme.java ! src/java.base/share/classes/sun/security/ssl/Utilities.java + test/jdk/javax/net/ssl/DTLS/DTLSSignatureSchemes.java + test/jdk/javax/net/ssl/SSLParameters/SignatureSchemes.java Changeset: 70318e1d Author: Weijun Wang Date: 2022-03-09 16:47:03 +0000 URL: https://git.openjdk.java.net/loom/commit/70318e1d17072198be5674ebe7118fb5f9373144 8282884: Provide OID aliases for MD2, MD5, and OAEP Reviewed-by: xuelei ! src/java.base/share/classes/com/sun/crypto/provider/SunJCE.java ! src/java.base/share/classes/sun/security/provider/SunEntries.java Changeset: ff766204 Author: Chris Plummer Date: 2022-03-09 19:42:47 +0000 URL: https://git.openjdk.java.net/loom/commit/ff76620487c307514c435443bbaebc9a6c473f5d 8282641: Make jdb "threadgroup" command with no args reset the current threadgroup back to the default Reviewed-by: kevinw, amenkov ! src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/Commands.java ! src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources.java ! src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_ja.java ! src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_zh_CN.java ! test/hotspot/jtreg/vmTestbase/nsk/jdb/threadgroup/threadgroup002/threadgroup002.java Changeset: 8aba4de9 Author: Rajat Mahajan Committer: Sergey Bylokhov Date: 2022-03-10 05:09:29 +0000 URL: https://git.openjdk.java.net/loom/commit/8aba4de98477a3bcfcde8db71e0d797965f774c7 8249592: Robot.mouseMove moves cursor to incorrect location when display scale varies and Java runs in DPI Unaware mode Reviewed-by: serb, aivanov ! src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp Changeset: 5b78a82e Author: Prasanta Sadhukhan Date: 2022-03-10 09:22:21 +0000 URL: https://git.openjdk.java.net/loom/commit/5b78a82e9d4b73e5bf3c6e099564206ecbda889b 7017094: ParsedSynthStyle: parameter name "direction" should be changed to "tabIndex" Reviewed-by: jdv, aivanov, prr ! src/java.desktop/share/classes/javax/swing/plaf/synth/ParsedSynthStyle.java Changeset: 6a3a7b94 Author: Prasanta Sadhukhan Date: 2022-03-10 09:26:36 +0000 URL: https://git.openjdk.java.net/loom/commit/6a3a7b94a4c342ce12ad553f1ba2818ca3a77f36 6218162: DefaultTableColumnModel.getColumn() method should mention ArrayIndexOutOfBoundsException Reviewed-by: aivanov, prr ! src/java.desktop/share/classes/javax/swing/table/DefaultTableColumnModel.java Changeset: 83d77186 Author: Thomas Schatzl Date: 2022-03-10 11:28:29 +0000 URL: https://git.openjdk.java.net/loom/commit/83d771869046c2a2bf251ee5aebaceba60555e65 8282893: Remove MacroAssembler::push/pop_callee_saved_registers Reviewed-by: redestad ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp Changeset: 9c88c5bb Author: Magnus Ihse Bursie Date: 2022-03-10 13:50:05 +0000 URL: https://git.openjdk.java.net/loom/commit/9c88c5bb63fb67f301e843d1bd5700d7e5e95204 8282948: JDK-8274980 missed correct handling of MACOSX_BUNDLE_BUILD_VERSION Reviewed-by: erikj ! make/autoconf/jdk-version.m4 Changeset: 7c8ea9f0 Author: Tyler Steele Committer: Martin Doerr Date: 2022-03-10 15:09:19 +0000 URL: https://git.openjdk.java.net/loom/commit/7c8ea9f05b35069e2b5b43e1a0e46f7dbe374e4c 8282509: [exploded image] ResolvedClassTest fails with similar output Reviewed-by: mdoerr, dlong ! test/hotspot/jtreg/compiler/inlining/ResolvedClassTest.java Changeset: 26747990 Author: Alex Blewitt Committer: Aleksey Shipilev Date: 2022-03-10 15:27:29 +0000 URL: https://git.openjdk.java.net/loom/commit/26747990053ab8f378d7f64cd7e565e530af88fc 8282878: Removed _JavaThread from PhaseTraceTime Reviewed-by: shade, thartmann ! src/hotspot/share/c1/c1_Compilation.cpp Changeset: 1668c02e Author: Anton Litvinov Date: 2022-03-10 16:37:55 +0000 URL: https://git.openjdk.java.net/loom/commit/1668c02ee83cc4f7bd7b2fe5bb7ef59b5dbda081 8277922: Unable to click JCheckBox in JTable through Java Access Bridge Reviewed-by: aivanov, serb ! src/java.desktop/share/classes/javax/swing/JTable.java + test/jdk/javax/accessibility/JTable/BooleanRendererHasAccessibleActionTest.java Changeset: e8a1ce00 Author: Brian Burkhalter Date: 2022-03-10 16:38:44 +0000 URL: https://git.openjdk.java.net/loom/commit/e8a1ce00b2981a698b4ba3e09a8b2d49d0051ccb 8280881: (fs) UnixNativeDispatcher.close0 may throw UnixException Reviewed-by: alanb ! src/java.base/linux/classes/sun/nio/fs/LinuxDosFileAttributeView.java ! src/java.base/linux/classes/sun/nio/fs/LinuxWatchService.java ! src/java.base/unix/classes/sun/nio/fs/UnixCopyFile.java ! src/java.base/unix/classes/sun/nio/fs/UnixDirectoryStream.java ! src/java.base/unix/classes/sun/nio/fs/UnixFileAttributeViews.java ! src/java.base/unix/classes/sun/nio/fs/UnixFileStore.java ! src/java.base/unix/classes/sun/nio/fs/UnixFileSystemProvider.java ! src/java.base/unix/classes/sun/nio/fs/UnixNativeDispatcher.java ! src/java.base/unix/classes/sun/nio/fs/UnixSecureDirectoryStream.java ! src/java.base/unix/classes/sun/nio/fs/UnixUserDefinedFileAttributeView.java Changeset: fdce97df Author: Brian Burkhalter Date: 2022-03-10 17:36:51 +0000 URL: https://git.openjdk.java.net/loom/commit/fdce97df5f03d9aa37d85f271d08971ec47db01d 8267820: (fs) Files.copy should attempt to copy POSIX attributes when target file in custom file system Reviewed-by: lancea, alanb ! src/java.base/share/classes/java/nio/file/CopyMoveHelper.java ! test/jdk/java/nio/file/Files/CopyAndMove.java ! test/jdk/jdk/nio/zipfs/TestPosix.java ! test/jdk/jdk/nio/zipfs/test.policy ! test/jdk/jdk/nio/zipfs/test.policy.posix Changeset: 879b6445 Author: Zhengyu Gu Date: 2022-03-10 18:23:41 +0000 URL: https://git.openjdk.java.net/loom/commit/879b6445e33ad3a07461d01ea8f28a09979a4313 8282897: Fix call parameter to GetStringChars() in HostLocaleProviderAdapter_md.c Reviewed-by: shade, naoto ! src/java.base/windows/native/libjava/HostLocaleProviderAdapter_md.c Changeset: 1f295239 Author: John Jiang Date: 2022-03-10 18:25:06 +0000 URL: https://git.openjdk.java.net/loom/commit/1f295239b97cccfff24df259215d34c712065867 8282932: a space is needed for the unsupported protocol exception message in ProtocolVersion Reviewed-by: xuelei, mullan ! src/java.base/share/classes/sun/security/ssl/ProtocolVersion.java Changeset: b13cacc5 Author: Brian Burkhalter Date: 2022-03-10 18:25:53 +0000 URL: https://git.openjdk.java.net/loom/commit/b13cacc575f58c206c928f2756698b027ee07b6f 8254574: PrintWriter handling of InterruptedIOException should be removed Reviewed-by: alanb ! src/java.base/share/classes/java/io/PrintStream.java ! src/java.base/share/classes/java/io/PrintWriter.java Changeset: 7b91bbba Author: Aleksey Shipilev Date: 2022-03-10 18:53:59 +0000 URL: https://git.openjdk.java.net/loom/commit/7b91bbba82e871edaf133343415e254972c6ddc7 8282170: JVMTI SetBreakpoint metaspace allocation test Reviewed-by: cjplummer, lmesnik + test/hotspot/jtreg/serviceability/jvmti/SetBreakpoint/TestManyBreakpoints.java + test/hotspot/jtreg/serviceability/jvmti/SetBreakpoint/libTestManyBreakpoints.cpp Changeset: f5217b47 Author: Chris Plummer Date: 2022-03-10 19:08:10 +0000 URL: https://git.openjdk.java.net/loom/commit/f5217b475e2bfcbc649dd1e067222bf500429663 8282852: Debug agent asserts in classTrack_addPreparedClass() Reviewed-by: amenkov, lmesnik ! src/jdk.jdwp.agent/share/native/libjdwp/classTrack.c Changeset: bb7ee5a0 Author: Daniel D. Daugherty Date: 2022-03-10 19:13:55 +0000 URL: https://git.openjdk.java.net/loom/commit/bb7ee5a04ae21a9f9dc6c59a990f7e571e832f0d 8282314: nsk/jvmti/SuspendThread/suspendthrd003 may leak memory Reviewed-by: dholmes, cjplummer, amenkov, lmesnik, mseledtsov ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/SuspendThread/suspendthrd003.java ! test/hotspot/jtreg/vmTestbase/nsk/share/Log.java Changeset: a5a1a32d Author: Yi Yang Date: 2022-03-11 02:27:01 +0000 URL: https://git.openjdk.java.net/loom/commit/a5a1a32db65b98f0d7bae20cf054be2fbbf2cf3a 8282883: Use JVM_LEAF to avoid ThreadStateTransition for some simple JVM entries Reviewed-by: dholmes, shade ! src/hotspot/share/prims/jvm.cpp Changeset: 88f0938c Author: Yi Yang Date: 2022-03-11 02:28:07 +0000 URL: https://git.openjdk.java.net/loom/commit/88f0938c943bfacf748ddb0588a301c2cf7e941e 8272493: Suboptimal code generation around Preconditions.checkIndex intrinsic with AVX2 Reviewed-by: redestad, thartmann ! src/hotspot/share/opto/library_call.cpp Changeset: 1a5a496a Author: Ivan Walulya Date: 2022-03-11 08:43:04 +0000 URL: https://git.openjdk.java.net/loom/commit/1a5a496aee0f4c33cb67b0853bbf23313fd6ec7d 8282763: G1: G1CardSetContainer remove intrusive-list details. Reviewed-by: tschatzl, kbarrett, ayang ! src/hotspot/share/gc/g1/g1CardSetContainers.hpp ! src/hotspot/share/gc/g1/g1CardSetContainers.inline.hpp Changeset: cab9def1 Author: Julian Waters Committer: Magnus Ihse Bursie Date: 2022-03-11 09:12:19 +0000 URL: https://git.openjdk.java.net/loom/commit/cab9def1c1ab28b0b1a8cf268d0853f6e2bfa77f 8282700: Properly handle several --without options during configure Reviewed-by: ihse ! make/autoconf/jdk-version.m4 Changeset: f99193ae Author: Christian Stein Committer: Erik Gahlin Date: 2022-03-11 09:58:22 +0000 URL: https://git.openjdk.java.net/loom/commit/f99193ae3fe8b7bcba34a451890da37cab5ebffb 8282811: Typo in IAE details message of `RecordedObject.getValueDescriptor` Reviewed-by: egahlin ! src/jdk.jfr/share/classes/jdk/jfr/consumer/RecordedObject.java Changeset: 95ca9443 Author: Mahendra Chhipa Committer: Daniel Fuchs Date: 2022-03-11 10:48:57 +0000 URL: https://git.openjdk.java.net/loom/commit/95ca94436d12974d98b1b999f9cc8408d64cbe3c 8282354: Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/ tests Reviewed-by: dfuchs ! test/jdk/java/net/ProxySelector/LoopbackAddresses.java ! test/jdk/java/net/ProxySelector/ProxyTest.java ! test/jdk/java/net/URL/PerConnectionProxy.java ! test/jdk/java/net/URLConnection/B5052093.java ! test/jdk/sun/net/www/AuthHeaderTest.java ! test/jdk/sun/net/www/http/KeepAliveCache/B5045306.java - test/jdk/sun/net/www/httptest/AbstractCallback.java - test/jdk/sun/net/www/httptest/ClosedChannelList.java - test/jdk/sun/net/www/httptest/HttpCallback.java - test/jdk/sun/net/www/httptest/HttpTransaction.java - test/jdk/sun/net/www/httptest/TestHttpServer.java ! test/jdk/sun/security/ssl/InputRecord/ClientHelloRead.java Changeset: 0fd09d38 Author: Zhengyu Gu Date: 2022-03-11 13:25:09 +0000 URL: https://git.openjdk.java.net/loom/commit/0fd09d383b9921f26d2d609ab330630a4520325a 8282978: Wrong parameter passed to GetStringXXXChars in various places Reviewed-by: alanb, dfuchs ! src/java.base/unix/native/libnet/Inet4AddressImpl.c ! src/java.base/unix/native/libnet/Inet6AddressImpl.c ! src/java.base/windows/native/libnet/Inet4AddressImpl.c ! src/java.base/windows/native/libnet/Inet6AddressImpl.c ! src/java.desktop/unix/native/libawt_xawt/xawt/XlibWrapper.c ! src/java.desktop/windows/native/libawt/windows/awt_Button.cpp ! src/java.desktop/windows/native/libawt/windows/awt_Checkbox.cpp ! src/java.desktop/windows/native/libawt/windows/awt_Desktop.cpp ! src/java.desktop/windows/native/libawt/windows/awt_Win32GraphicsEnv.cpp Changeset: 374193b6 Author: Pavel Rappo Date: 2022-03-11 22:41:47 +0000 URL: https://git.openjdk.java.net/loom/commit/374193b6d2465a356941f9588a0ccf6d97cb76f6 8283041: [javadoc] Crashes using {@return} with @param Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java ! test/langtools/jdk/javadoc/doclet/testReturnTag/TestReturnTag.java Changeset: 5c408c14 Author: Joshua Zhu Committer: Jie Fu Date: 2022-03-12 04:04:28 +0000 URL: https://git.openjdk.java.net/loom/commit/5c408c1410e15087f735a815b7edc716d514b1b3 8282874: Bad performance on gather/scatter API caused by different IntSpecies of indexMap Reviewed-by: psandoz ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ByteVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/DoubleVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/FloatVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/IntVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/LongVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ShortVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template Changeset: 3cf83a67 Author: Jaikiran Pai Date: 2022-03-14 03:17:57 +0000 URL: https://git.openjdk.java.net/loom/commit/3cf83a671eaedd78d87197dffa76dcc3fededb78 8282572: EnumSet should be a sealed class Reviewed-by: sundar ! src/java.base/share/classes/java/util/EnumSet.java ! src/java.base/share/classes/java/util/JumboEnumSet.java ! src/java.base/share/classes/java/util/RegularEnumSet.java Changeset: fde31498 Author: Jatin Bhateja Date: 2022-03-14 07:11:23 +0000 URL: https://git.openjdk.java.net/loom/commit/fde31498963d76630ada31bd0e0cf3035f87445b 8281375: Accelerate bitCount operation for AVX2 and AVX512 target. Reviewed-by: sviswanathan, thartmann ! src/hotspot/cpu/aarch64/matcher_aarch64.hpp ! src/hotspot/cpu/arm/matcher_arm.hpp ! src/hotspot/cpu/ppc/matcher_ppc.hpp ! src/hotspot/cpu/s390/matcher_s390.hpp ! src/hotspot/cpu/x86/assembler_x86.cpp ! src/hotspot/cpu/x86/assembler_x86.hpp ! src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp ! src/hotspot/cpu/x86/c2_MacroAssembler_x86.hpp ! src/hotspot/cpu/x86/matcher_x86.hpp ! src/hotspot/cpu/x86/stubGenerator_x86_32.cpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/cpu/x86/stubRoutines_x86.cpp ! src/hotspot/cpu/x86/stubRoutines_x86.hpp ! src/hotspot/cpu/x86/x86.ad ! src/hotspot/share/opto/loopTransform.cpp ! test/hotspot/jtreg/compiler/vectorization/TestPopCountVectorLong.java Changeset: c0e3d107 Author: Thomas Schatzl Date: 2022-03-14 09:02:12 +0000 URL: https://git.openjdk.java.net/loom/commit/c0e3d107f67a1a333dbe58ae745200d85764c74e 8283008: KRegister documentation out of date Reviewed-by: dlong, sviswanathan, jiefu, jbhateja ! src/hotspot/cpu/x86/register_x86.hpp Changeset: 01570ca9 Author: Aleksey Shipilev Date: 2022-03-14 09:03:05 +0000 URL: https://git.openjdk.java.net/loom/commit/01570ca92d234481df2d540027e320b91af415a0 8283017: GHA: Workflows break with update release versions Reviewed-by: erikj, ihse ! .github/workflows/submit.yml Changeset: 5f3d4032 Author: Ahmed Muhsin Committer: Christian Hagedorn Date: 2022-03-14 09:05:53 +0000 URL: https://git.openjdk.java.net/loom/commit/5f3d4032f3a8854f7afde28698e66a7b6684aed7 8272735: Add missing SubL node transformations Reviewed-by: thartmann, chagedorn ! src/hotspot/share/opto/subnode.cpp ! test/hotspot/jtreg/compiler/c2/irTests/SubINodeIdealizationTests.java ! test/hotspot/jtreg/compiler/c2/irTests/SubLNodeIdealizationTests.java Changeset: ea9eeea8 Author: Roland Westrelin Date: 2022-03-14 13:59:13 +0000 URL: https://git.openjdk.java.net/loom/commit/ea9eeea8ffea6ed32a270051c6986f4f059943c0 8281322: C2: always construct strip mined loop initially (even if strip mining is disabled) Reviewed-by: chagedorn, thartmann ! src/hotspot/share/opto/loopnode.cpp ! src/hotspot/share/opto/loopnode.hpp + test/hotspot/jtreg/compiler/c2/irTests/TestCountedLoopSafepoint.java ! test/hotspot/jtreg/compiler/c2/irTests/TestLongRangeChecks.java Changeset: 08573cc3 Author: Zdenek Zambersky Committer: Bradford Wetmore Date: 2022-03-14 14:21:58 +0000 URL: https://git.openjdk.java.net/loom/commit/08573cc3b2370a697a7bd4ad0665ee20ae148d39 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket Reviewed-by: wetmore, xuelei ! src/java.base/share/classes/javax/net/ssl/SSLSocket.java Changeset: 13cebffe Author: Brian Burkhalter Date: 2022-03-14 16:10:15 +0000 URL: https://git.openjdk.java.net/loom/commit/13cebffe618255ae29310c95fd1b91576e576751 8058924: FileReader(String) documentation is insufficient Reviewed-by: naoto, lancea ! src/java.base/share/classes/java/io/package-info.java Changeset: c96085ea Author: Naoto Sato Date: 2022-03-14 16:28:15 +0000 URL: https://git.openjdk.java.net/loom/commit/c96085eaab1f6b21e084b94fcc619d090f0afc97 8282929: Localized monetary symbols are not reflected in `toLocalizedPattern` return value Reviewed-by: joehw, lancea ! src/java.base/share/classes/java/text/DecimalFormat.java + test/jdk/java/text/Format/DecimalFormat/ToLocalizedPatternTest.java Changeset: 7833667f Author: Emanuel Peter Committer: Harold Seigel Date: 2022-03-14 17:35:09 +0000 URL: https://git.openjdk.java.net/loom/commit/7833667f0e2151fc56c7c1533015f004f02f7ab2 8282881: Print exception message in VM crash with -XX:AbortVMOnException Reviewed-by: dholmes, hseigel ! src/hotspot/share/utilities/exceptions.cpp Changeset: 70bd57ed Author: Carter Kozak Committer: Daniel Fuchs Date: 2022-03-14 17:54:19 +0000 URL: https://git.openjdk.java.net/loom/commit/70bd57ed3544cdb41029d425507ba4b9b35c8cdb 8283049: Fix non-singleton LoggerFinder error message: s/on/one Reviewed-by: dfuchs ! src/java.base/share/classes/jdk/internal/logger/LoggerFinderLoader.java ! test/jdk/java/lang/System/LoggerFinder/internal/LoggerFinderLoaderTest/LoggerFinderLoaderTest.java Changeset: f66070b0 Author: Phil Race Date: 2022-03-14 18:05:38 +0000 URL: https://git.openjdk.java.net/loom/commit/f66070b00d4311c6e3a6fbf38956fa2d5da5fada 8282577: ICC_Profile.setData(int, byte[]) invalidates the profile Reviewed-by: serb ! src/java.desktop/share/native/liblcms/LCMS.c + test/jdk/java/awt/color/ICC_ColorSpace/SetTagDataValidation.java ! test/jdk/java/awt/color/ICC_Profile/MTGetData.java Changeset: 5bf6a7f7 Author: Chris Plummer Date: 2022-03-14 18:15:40 +0000 URL: https://git.openjdk.java.net/loom/commit/5bf6a7f7d78506118ded0f0bf6383b0825366619 8282691: add jdb "-R" option for passing any argument to the launched debuggee process Reviewed-by: alanb, kevinw ! src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTY.java ! src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources.java ! src/jdk.jdi/share/man/jdb.1 ! test/jdk/com/sun/jdi/JdbOptions.java Changeset: a244051a Author: Mikael Vidstedt Date: 2022-03-14 18:37:41 +0000 URL: https://git.openjdk.java.net/loom/commit/a244051a8c967039d7639afcaf83f7d92af49613 8283062: Uninitialized warnings in libgtest with GCC 11.2 Reviewed-by: jiefu, erikj ! make/hotspot/lib/CompileGtest.gmk Changeset: 5ba5e21f Author: Hannes Walln?fer Date: 2022-03-14 20:28:07 +0000 URL: https://git.openjdk.java.net/loom/commit/5ba5e21fd2a02d15d4d56931cae4f9a978470c88 8282214: Upgrade JQuery to version 3.6.0 Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDoclet.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/script-dir/jquery-3.5.1.min.js = src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/script-dir/jquery-3.6.0.js + src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/script-dir/jquery-3.6.0.min.js ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/DocPaths.java ! src/jdk.javadoc/share/legal/jquery.md ! test/langtools/jdk/javadoc/doclet/testSearch/TestSearch.java ! test/langtools/jdk/javadoc/tool/api/basic/APITest.java Changeset: 6013d09e Author: Hannes Walln?fer Date: 2022-03-14 20:29:15 +0000 URL: https://git.openjdk.java.net/loom/commit/6013d09e82693a1c07cf0bf6daffd95114b3cbfa 8268866: Javascript when used in an iframe cannot display search results Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/search.js.template Changeset: 34d4ffce Author: Dean Long Date: 2022-03-15 07:24:50 +0000 URL: https://git.openjdk.java.net/loom/commit/34d4ffcea5d71560c549655967de863342b48984 8279317: compiler/jvmci/compilerToVM/DisassembleCodeBlobTest.java assumes immutable code Reviewed-by: dnsimon, iveresov ! test/hotspot/jtreg/compiler/jvmci/compilerToVM/DisassembleCodeBlobTest.java Changeset: 710653ce Author: Daniel Fuchs Date: 2022-03-15 12:59:54 +0000 URL: https://git.openjdk.java.net/loom/commit/710653ce1856d13161ae1786d7c5f71997536e78 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently Reviewed-by: jpai, michaelm ! src/java.net.http/share/classes/jdk/internal/net/http/Exchange.java ! src/java.net.http/share/classes/jdk/internal/net/http/Http2ClientImpl.java ! src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java ! test/jdk/java/net/httpclient/CancelRequestTest.java Changeset: 2cddf3f5 Author: Zhengyu Gu Date: 2022-03-15 14:16:35 +0000 URL: https://git.openjdk.java.net/loom/commit/2cddf3f5391518ea40796e6c4759047d51b7b312 8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows Reviewed-by: naoto, alanb ! src/java.base/windows/native/libjava/HostLocaleProviderAdapter_md.c Changeset: 4de72014 Author: Tyler Steele Committer: Thomas Stuefe Date: 2022-03-15 14:52:27 +0000 URL: https://git.openjdk.java.net/loom/commit/4de72014d3a33469399fec6f428f35c47c4cfbe0 8283122: [AIX, s390] UnsafeCopyMemory 'Mismatched' Tests Fail on Big Endian Systems Reviewed-by: thartmann, stuefe ! test/hotspot/jtreg/compiler/unsafe/UnsafeCopyMemory.java Changeset: f43ffe21 Author: Hai-May Chao Date: 2022-03-15 15:54:47 +0000 URL: https://git.openjdk.java.net/loom/commit/f43ffe211f8ff287697092c39e4c25a16b40a383 8282633: jarsigner output does not explain why an EC key is disabled if its curve has been disabled Reviewed-by: weijun ! src/java.base/share/classes/sun/security/tools/keytool/Main.java ! src/java.base/share/classes/sun/security/util/KeyUtil.java ! src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java ! src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources.java + test/jdk/sun/security/tools/jarsigner/DisableCurveTest.java Changeset: 671b6efd Author: Joe Darcy Date: 2022-03-15 16:05:37 +0000 URL: https://git.openjdk.java.net/loom/commit/671b6efd6126384c0630d1cd84f53f52995e68d8 8283143: Use minimal-length literals to initialize PI and E constants Reviewed-by: smarks ! src/java.base/share/classes/java/lang/Math.java ! src/java.base/share/classes/java/lang/StrictMath.java Changeset: 05a83e03 Author: Joe Darcy Date: 2022-03-15 16:22:11 +0000 URL: https://git.openjdk.java.net/loom/commit/05a83e03ca35b4885b48bb0e7d188baf8f7d9d7f 8283124: Add constant for tau to Math and StrictMath Reviewed-by: bpb, iris ! src/java.base/share/classes/java/lang/Math.java ! src/java.base/share/classes/java/lang/StrictMath.java Changeset: 12dca36c Author: Tobias Hartmann Date: 2022-03-15 16:28:54 +0000 URL: https://git.openjdk.java.net/loom/commit/12dca36c73583d0ed2e1f684b056100dc1f2ef55 8283189: Bad copyright header in UnsafeCopyMemory.java Reviewed-by: chagedorn, dcubed ! test/hotspot/jtreg/compiler/unsafe/UnsafeCopyMemory.java Changeset: 32f8437d Author: Joe Darcy Date: 2022-03-15 17:33:45 +0000 URL: https://git.openjdk.java.net/loom/commit/32f8437d85a003914d5ca35bdddebdc732ab222d 8283075: Bad IllegalArgumentException message for out of range rank from ClassDesc.arrayType(int) Reviewed-by: vromero, alanb ! src/java.base/share/classes/java/lang/constant/ClassDesc.java ! test/jdk/java/lang/constant/ClassDescTest.java Changeset: ac06bdb1 Author: Man Cao Date: 2022-03-15 20:05:33 +0000 URL: https://git.openjdk.java.net/loom/commit/ac06bdb1239a97b7ea2fee8280da8ebc9728dc30 8282507: Add a separate license file for hsdis Reviewed-by: ihse + src/utils/hsdis/hsdis-license.txt Changeset: 1465ea98 Author: Dean Long Date: 2022-03-15 20:17:36 +0000 URL: https://git.openjdk.java.net/loom/commit/1465ea98b7736b5960a8b546ccc366c3e3260bdd 8282355: compiler/arguments/TestCodeEntryAlignment.java failed "guarantee(sect->end() <= tend) failed: sanity" Reviewed-by: jiefu, thartmann, shade ! src/hotspot/share/runtime/stubRoutines.cpp ! test/hotspot/jtreg/compiler/arguments/TestCodeEntryAlignment.java Changeset: bacfaa3e Author: Quan Anh Mai Committer: Sandhya Viswanathan Date: 2022-03-16 01:10:22 +0000 URL: https://git.openjdk.java.net/loom/commit/bacfaa3ee16882563200ef3b3df4441b33664451 8282414: x86: Enhance the assembler to generate more compact instructions Reviewed-by: thartmann, sviswanathan ! src/hotspot/cpu/x86/assembler_x86.cpp ! src/hotspot/cpu/x86/assembler_x86.hpp ! src/hotspot/cpu/x86/x86_64.ad Changeset: 27fe3d7f Author: Toshio Nakamura Committer: Sergey Bylokhov Date: 2022-03-16 01:11:40 +0000 URL: https://git.openjdk.java.net/loom/commit/27fe3d7f8db4ede6441a7cc325d9f29eb4a1d10d 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled Reviewed-by: prr, serb ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CTextPipe.java + test/jdk/java/awt/font/GlyphVector/MultiSlotFontTest.java Changeset: 4df24c5d Author: Joe Darcy Date: 2022-03-16 02:02:10 +0000 URL: https://git.openjdk.java.net/loom/commit/4df24c5df38eeacc73097f71383916e9a0933839 8283230: Improve @jls usage in ElementType Reviewed-by: jjg, iris ! src/java.base/share/classes/java/lang/annotation/ElementType.java Changeset: de4f04cb Author: Ioi Lam Date: 2022-03-16 03:12:48 +0000 URL: https://git.openjdk.java.net/loom/commit/de4f04cb71a26ce03b96460cb8d1c1e28cd1ed38 8253495: CDS generates non-deterministic output Reviewed-by: erikj, kbarrett, ccheung, ihse ! make/scripts/compare.sh ! src/hotspot/share/cds/archiveBuilder.cpp ! src/hotspot/share/cds/archiveUtils.hpp ! src/hotspot/share/cds/dumpTimeClassInfo.hpp ! src/hotspot/share/cds/heapShared.cpp ! src/hotspot/share/cds/heapShared.hpp ! src/hotspot/share/gc/shared/collectedHeap.cpp ! src/hotspot/share/gc/shared/collectedHeap.hpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/runtime/os.cpp ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/runtime/cds/DeterministicDump.java ! test/hotspot/jtreg/runtime/cds/appcds/javaldr/LockDuringDump.java ! test/hotspot/jtreg/runtime/cds/appcds/javaldr/LockDuringDumpAgent.java ! test/lib/jdk/test/lib/cds/CDSOptions.java Changeset: 08cadb47 Author: Swati Sharma Committer: Jatin Bhateja Date: 2022-03-16 09:48:09 +0000 URL: https://git.openjdk.java.net/loom/commit/08cadb4754da0d5e68ee2df45f4098d203d14115 8271195: Use largest available large page size smaller than LargePageSizeInBytes when available Co-authored-by: Jatin Bhateja Reviewed-by: ayang, tschatzl ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/share/memory/virtualspace.cpp + test/micro/org/openjdk/bench/vm/gc/MicroLargePages.java Changeset: f1d9570e Author: Alan Bateman Date: 2022-03-17 07:36:08 +0000 URL: https://git.openjdk.java.net/loom/commit/f1d9570eb89030bcad4ed954e64efa5903d73b91 Merge with jdk-19+14 ! src/hotspot/cpu/x86/assembler_x86.cpp ! src/hotspot/cpu/x86/assembler_x86.hpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/stubGenerator_x86_32.cpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/cpu/x86/stubRoutines_x86.hpp ! src/hotspot/cpu/x86/x86.ad ! src/hotspot/cpu/x86/x86_64.ad ! src/hotspot/share/c1/c1_Compilation.cpp ! src/hotspot/share/cds/heapShared.cpp ! src/hotspot/share/gc/shared/collectedHeap.cpp ! src/hotspot/share/gc/shared/collectedHeap.hpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/runtime/stubRoutines.cpp ! src/java.base/share/classes/java/io/PrintStream.java ! src/java.base/share/classes/java/io/PrintWriter.java ! src/java.base/unix/classes/sun/nio/fs/UnixCopyFile.java ! src/java.base/unix/classes/sun/nio/fs/UnixNativeDispatcher.java ! src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTY.java ! test/hotspot/jtreg/ProblemList.txt ! src/hotspot/cpu/x86/assembler_x86.cpp ! src/hotspot/cpu/x86/assembler_x86.hpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/stubGenerator_x86_32.cpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/cpu/x86/stubRoutines_x86.hpp ! src/hotspot/cpu/x86/x86.ad ! src/hotspot/cpu/x86/x86_64.ad ! src/hotspot/share/c1/c1_Compilation.cpp ! src/hotspot/share/cds/heapShared.cpp ! src/hotspot/share/gc/shared/collectedHeap.cpp ! src/hotspot/share/gc/shared/collectedHeap.hpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/runtime/stubRoutines.cpp ! src/java.base/share/classes/java/io/PrintStream.java ! src/java.base/share/classes/java/io/PrintWriter.java ! src/java.base/unix/classes/sun/nio/fs/UnixCopyFile.java ! src/java.base/unix/classes/sun/nio/fs/UnixNativeDispatcher.java ! src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTY.java ! test/hotspot/jtreg/ProblemList.txt From duke at openjdk.java.net Thu Mar 17 09:15:26 2022 From: duke at openjdk.java.net (duke) Date: Thu, 17 Mar 2022 09:15:26 GMT Subject: git: openjdk/loom: master: 60 new changesets Message-ID: <9cd61c34-8d67-4e29-9145-322764126ba6@openjdk.java.net> Changeset: 6d8d156c Author: Xue-Lei Andrew Fan Date: 2022-03-09 16:11:07 +0000 URL: https://git.openjdk.java.net/loom/commit/6d8d156c97b90a9ab4776c6b42563a962d959741 8280494: (D)TLS signature schemes Reviewed-by: mullan ! src/java.base/share/classes/javax/net/ssl/SSLParameters.java ! src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java ! src/java.base/share/classes/sun/security/ssl/SignatureScheme.java ! src/java.base/share/classes/sun/security/ssl/Utilities.java + test/jdk/javax/net/ssl/DTLS/DTLSSignatureSchemes.java + test/jdk/javax/net/ssl/SSLParameters/SignatureSchemes.java Changeset: 70318e1d Author: Weijun Wang Date: 2022-03-09 16:47:03 +0000 URL: https://git.openjdk.java.net/loom/commit/70318e1d17072198be5674ebe7118fb5f9373144 8282884: Provide OID aliases for MD2, MD5, and OAEP Reviewed-by: xuelei ! src/java.base/share/classes/com/sun/crypto/provider/SunJCE.java ! src/java.base/share/classes/sun/security/provider/SunEntries.java Changeset: ff766204 Author: Chris Plummer Date: 2022-03-09 19:42:47 +0000 URL: https://git.openjdk.java.net/loom/commit/ff76620487c307514c435443bbaebc9a6c473f5d 8282641: Make jdb "threadgroup" command with no args reset the current threadgroup back to the default Reviewed-by: kevinw, amenkov ! src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/Commands.java ! src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources.java ! src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_ja.java ! src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_zh_CN.java ! test/hotspot/jtreg/vmTestbase/nsk/jdb/threadgroup/threadgroup002/threadgroup002.java Changeset: 8aba4de9 Author: Rajat Mahajan Committer: Sergey Bylokhov Date: 2022-03-10 05:09:29 +0000 URL: https://git.openjdk.java.net/loom/commit/8aba4de98477a3bcfcde8db71e0d797965f774c7 8249592: Robot.mouseMove moves cursor to incorrect location when display scale varies and Java runs in DPI Unaware mode Reviewed-by: serb, aivanov ! src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp Changeset: 5b78a82e Author: Prasanta Sadhukhan Date: 2022-03-10 09:22:21 +0000 URL: https://git.openjdk.java.net/loom/commit/5b78a82e9d4b73e5bf3c6e099564206ecbda889b 7017094: ParsedSynthStyle: parameter name "direction" should be changed to "tabIndex" Reviewed-by: jdv, aivanov, prr ! src/java.desktop/share/classes/javax/swing/plaf/synth/ParsedSynthStyle.java Changeset: 6a3a7b94 Author: Prasanta Sadhukhan Date: 2022-03-10 09:26:36 +0000 URL: https://git.openjdk.java.net/loom/commit/6a3a7b94a4c342ce12ad553f1ba2818ca3a77f36 6218162: DefaultTableColumnModel.getColumn() method should mention ArrayIndexOutOfBoundsException Reviewed-by: aivanov, prr ! src/java.desktop/share/classes/javax/swing/table/DefaultTableColumnModel.java Changeset: 83d77186 Author: Thomas Schatzl Date: 2022-03-10 11:28:29 +0000 URL: https://git.openjdk.java.net/loom/commit/83d771869046c2a2bf251ee5aebaceba60555e65 8282893: Remove MacroAssembler::push/pop_callee_saved_registers Reviewed-by: redestad ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp Changeset: 9c88c5bb Author: Magnus Ihse Bursie Date: 2022-03-10 13:50:05 +0000 URL: https://git.openjdk.java.net/loom/commit/9c88c5bb63fb67f301e843d1bd5700d7e5e95204 8282948: JDK-8274980 missed correct handling of MACOSX_BUNDLE_BUILD_VERSION Reviewed-by: erikj ! make/autoconf/jdk-version.m4 Changeset: 7c8ea9f0 Author: Tyler Steele Committer: Martin Doerr Date: 2022-03-10 15:09:19 +0000 URL: https://git.openjdk.java.net/loom/commit/7c8ea9f05b35069e2b5b43e1a0e46f7dbe374e4c 8282509: [exploded image] ResolvedClassTest fails with similar output Reviewed-by: mdoerr, dlong ! test/hotspot/jtreg/compiler/inlining/ResolvedClassTest.java Changeset: 26747990 Author: Alex Blewitt Committer: Aleksey Shipilev Date: 2022-03-10 15:27:29 +0000 URL: https://git.openjdk.java.net/loom/commit/26747990053ab8f378d7f64cd7e565e530af88fc 8282878: Removed _JavaThread from PhaseTraceTime Reviewed-by: shade, thartmann ! src/hotspot/share/c1/c1_Compilation.cpp Changeset: 1668c02e Author: Anton Litvinov Date: 2022-03-10 16:37:55 +0000 URL: https://git.openjdk.java.net/loom/commit/1668c02ee83cc4f7bd7b2fe5bb7ef59b5dbda081 8277922: Unable to click JCheckBox in JTable through Java Access Bridge Reviewed-by: aivanov, serb ! src/java.desktop/share/classes/javax/swing/JTable.java + test/jdk/javax/accessibility/JTable/BooleanRendererHasAccessibleActionTest.java Changeset: e8a1ce00 Author: Brian Burkhalter Date: 2022-03-10 16:38:44 +0000 URL: https://git.openjdk.java.net/loom/commit/e8a1ce00b2981a698b4ba3e09a8b2d49d0051ccb 8280881: (fs) UnixNativeDispatcher.close0 may throw UnixException Reviewed-by: alanb ! src/java.base/linux/classes/sun/nio/fs/LinuxDosFileAttributeView.java ! src/java.base/linux/classes/sun/nio/fs/LinuxWatchService.java ! src/java.base/unix/classes/sun/nio/fs/UnixCopyFile.java ! src/java.base/unix/classes/sun/nio/fs/UnixDirectoryStream.java ! src/java.base/unix/classes/sun/nio/fs/UnixFileAttributeViews.java ! src/java.base/unix/classes/sun/nio/fs/UnixFileStore.java ! src/java.base/unix/classes/sun/nio/fs/UnixFileSystemProvider.java ! src/java.base/unix/classes/sun/nio/fs/UnixNativeDispatcher.java ! src/java.base/unix/classes/sun/nio/fs/UnixSecureDirectoryStream.java ! src/java.base/unix/classes/sun/nio/fs/UnixUserDefinedFileAttributeView.java Changeset: fdce97df Author: Brian Burkhalter Date: 2022-03-10 17:36:51 +0000 URL: https://git.openjdk.java.net/loom/commit/fdce97df5f03d9aa37d85f271d08971ec47db01d 8267820: (fs) Files.copy should attempt to copy POSIX attributes when target file in custom file system Reviewed-by: lancea, alanb ! src/java.base/share/classes/java/nio/file/CopyMoveHelper.java ! test/jdk/java/nio/file/Files/CopyAndMove.java ! test/jdk/jdk/nio/zipfs/TestPosix.java ! test/jdk/jdk/nio/zipfs/test.policy ! test/jdk/jdk/nio/zipfs/test.policy.posix Changeset: 879b6445 Author: Zhengyu Gu Date: 2022-03-10 18:23:41 +0000 URL: https://git.openjdk.java.net/loom/commit/879b6445e33ad3a07461d01ea8f28a09979a4313 8282897: Fix call parameter to GetStringChars() in HostLocaleProviderAdapter_md.c Reviewed-by: shade, naoto ! src/java.base/windows/native/libjava/HostLocaleProviderAdapter_md.c Changeset: 1f295239 Author: John Jiang Date: 2022-03-10 18:25:06 +0000 URL: https://git.openjdk.java.net/loom/commit/1f295239b97cccfff24df259215d34c712065867 8282932: a space is needed for the unsupported protocol exception message in ProtocolVersion Reviewed-by: xuelei, mullan ! src/java.base/share/classes/sun/security/ssl/ProtocolVersion.java Changeset: b13cacc5 Author: Brian Burkhalter Date: 2022-03-10 18:25:53 +0000 URL: https://git.openjdk.java.net/loom/commit/b13cacc575f58c206c928f2756698b027ee07b6f 8254574: PrintWriter handling of InterruptedIOException should be removed Reviewed-by: alanb ! src/java.base/share/classes/java/io/PrintStream.java ! src/java.base/share/classes/java/io/PrintWriter.java Changeset: 7b91bbba Author: Aleksey Shipilev Date: 2022-03-10 18:53:59 +0000 URL: https://git.openjdk.java.net/loom/commit/7b91bbba82e871edaf133343415e254972c6ddc7 8282170: JVMTI SetBreakpoint metaspace allocation test Reviewed-by: cjplummer, lmesnik + test/hotspot/jtreg/serviceability/jvmti/SetBreakpoint/TestManyBreakpoints.java + test/hotspot/jtreg/serviceability/jvmti/SetBreakpoint/libTestManyBreakpoints.cpp Changeset: f5217b47 Author: Chris Plummer Date: 2022-03-10 19:08:10 +0000 URL: https://git.openjdk.java.net/loom/commit/f5217b475e2bfcbc649dd1e067222bf500429663 8282852: Debug agent asserts in classTrack_addPreparedClass() Reviewed-by: amenkov, lmesnik ! src/jdk.jdwp.agent/share/native/libjdwp/classTrack.c Changeset: bb7ee5a0 Author: Daniel D. Daugherty Date: 2022-03-10 19:13:55 +0000 URL: https://git.openjdk.java.net/loom/commit/bb7ee5a04ae21a9f9dc6c59a990f7e571e832f0d 8282314: nsk/jvmti/SuspendThread/suspendthrd003 may leak memory Reviewed-by: dholmes, cjplummer, amenkov, lmesnik, mseledtsov ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/SuspendThread/suspendthrd003.java ! test/hotspot/jtreg/vmTestbase/nsk/share/Log.java Changeset: a5a1a32d Author: Yi Yang Date: 2022-03-11 02:27:01 +0000 URL: https://git.openjdk.java.net/loom/commit/a5a1a32db65b98f0d7bae20cf054be2fbbf2cf3a 8282883: Use JVM_LEAF to avoid ThreadStateTransition for some simple JVM entries Reviewed-by: dholmes, shade ! src/hotspot/share/prims/jvm.cpp Changeset: 88f0938c Author: Yi Yang Date: 2022-03-11 02:28:07 +0000 URL: https://git.openjdk.java.net/loom/commit/88f0938c943bfacf748ddb0588a301c2cf7e941e 8272493: Suboptimal code generation around Preconditions.checkIndex intrinsic with AVX2 Reviewed-by: redestad, thartmann ! src/hotspot/share/opto/library_call.cpp Changeset: 1a5a496a Author: Ivan Walulya Date: 2022-03-11 08:43:04 +0000 URL: https://git.openjdk.java.net/loom/commit/1a5a496aee0f4c33cb67b0853bbf23313fd6ec7d 8282763: G1: G1CardSetContainer remove intrusive-list details. Reviewed-by: tschatzl, kbarrett, ayang ! src/hotspot/share/gc/g1/g1CardSetContainers.hpp ! src/hotspot/share/gc/g1/g1CardSetContainers.inline.hpp Changeset: cab9def1 Author: Julian Waters Committer: Magnus Ihse Bursie Date: 2022-03-11 09:12:19 +0000 URL: https://git.openjdk.java.net/loom/commit/cab9def1c1ab28b0b1a8cf268d0853f6e2bfa77f 8282700: Properly handle several --without options during configure Reviewed-by: ihse ! make/autoconf/jdk-version.m4 Changeset: f99193ae Author: Christian Stein Committer: Erik Gahlin Date: 2022-03-11 09:58:22 +0000 URL: https://git.openjdk.java.net/loom/commit/f99193ae3fe8b7bcba34a451890da37cab5ebffb 8282811: Typo in IAE details message of `RecordedObject.getValueDescriptor` Reviewed-by: egahlin ! src/jdk.jfr/share/classes/jdk/jfr/consumer/RecordedObject.java Changeset: 95ca9443 Author: Mahendra Chhipa Committer: Daniel Fuchs Date: 2022-03-11 10:48:57 +0000 URL: https://git.openjdk.java.net/loom/commit/95ca94436d12974d98b1b999f9cc8408d64cbe3c 8282354: Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/ tests Reviewed-by: dfuchs ! test/jdk/java/net/ProxySelector/LoopbackAddresses.java ! test/jdk/java/net/ProxySelector/ProxyTest.java ! test/jdk/java/net/URL/PerConnectionProxy.java ! test/jdk/java/net/URLConnection/B5052093.java ! test/jdk/sun/net/www/AuthHeaderTest.java ! test/jdk/sun/net/www/http/KeepAliveCache/B5045306.java - test/jdk/sun/net/www/httptest/AbstractCallback.java - test/jdk/sun/net/www/httptest/ClosedChannelList.java - test/jdk/sun/net/www/httptest/HttpCallback.java - test/jdk/sun/net/www/httptest/HttpTransaction.java - test/jdk/sun/net/www/httptest/TestHttpServer.java ! test/jdk/sun/security/ssl/InputRecord/ClientHelloRead.java Changeset: 0fd09d38 Author: Zhengyu Gu Date: 2022-03-11 13:25:09 +0000 URL: https://git.openjdk.java.net/loom/commit/0fd09d383b9921f26d2d609ab330630a4520325a 8282978: Wrong parameter passed to GetStringXXXChars in various places Reviewed-by: alanb, dfuchs ! src/java.base/unix/native/libnet/Inet4AddressImpl.c ! src/java.base/unix/native/libnet/Inet6AddressImpl.c ! src/java.base/windows/native/libnet/Inet4AddressImpl.c ! src/java.base/windows/native/libnet/Inet6AddressImpl.c ! src/java.desktop/unix/native/libawt_xawt/xawt/XlibWrapper.c ! src/java.desktop/windows/native/libawt/windows/awt_Button.cpp ! src/java.desktop/windows/native/libawt/windows/awt_Checkbox.cpp ! src/java.desktop/windows/native/libawt/windows/awt_Desktop.cpp ! src/java.desktop/windows/native/libawt/windows/awt_Win32GraphicsEnv.cpp Changeset: 374193b6 Author: Pavel Rappo Date: 2022-03-11 22:41:47 +0000 URL: https://git.openjdk.java.net/loom/commit/374193b6d2465a356941f9588a0ccf6d97cb76f6 8283041: [javadoc] Crashes using {@return} with @param Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java ! test/langtools/jdk/javadoc/doclet/testReturnTag/TestReturnTag.java Changeset: 5c408c14 Author: Joshua Zhu Committer: Jie Fu Date: 2022-03-12 04:04:28 +0000 URL: https://git.openjdk.java.net/loom/commit/5c408c1410e15087f735a815b7edc716d514b1b3 8282874: Bad performance on gather/scatter API caused by different IntSpecies of indexMap Reviewed-by: psandoz ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ByteVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/DoubleVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/FloatVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/IntVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/LongVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ShortVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template Changeset: 3cf83a67 Author: Jaikiran Pai Date: 2022-03-14 03:17:57 +0000 URL: https://git.openjdk.java.net/loom/commit/3cf83a671eaedd78d87197dffa76dcc3fededb78 8282572: EnumSet should be a sealed class Reviewed-by: sundar ! src/java.base/share/classes/java/util/EnumSet.java ! src/java.base/share/classes/java/util/JumboEnumSet.java ! src/java.base/share/classes/java/util/RegularEnumSet.java Changeset: fde31498 Author: Jatin Bhateja Date: 2022-03-14 07:11:23 +0000 URL: https://git.openjdk.java.net/loom/commit/fde31498963d76630ada31bd0e0cf3035f87445b 8281375: Accelerate bitCount operation for AVX2 and AVX512 target. Reviewed-by: sviswanathan, thartmann ! src/hotspot/cpu/aarch64/matcher_aarch64.hpp ! src/hotspot/cpu/arm/matcher_arm.hpp ! src/hotspot/cpu/ppc/matcher_ppc.hpp ! src/hotspot/cpu/s390/matcher_s390.hpp ! src/hotspot/cpu/x86/assembler_x86.cpp ! src/hotspot/cpu/x86/assembler_x86.hpp ! src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp ! src/hotspot/cpu/x86/c2_MacroAssembler_x86.hpp ! src/hotspot/cpu/x86/matcher_x86.hpp ! src/hotspot/cpu/x86/stubGenerator_x86_32.cpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/cpu/x86/stubRoutines_x86.cpp ! src/hotspot/cpu/x86/stubRoutines_x86.hpp ! src/hotspot/cpu/x86/x86.ad ! src/hotspot/share/opto/loopTransform.cpp ! test/hotspot/jtreg/compiler/vectorization/TestPopCountVectorLong.java Changeset: c0e3d107 Author: Thomas Schatzl Date: 2022-03-14 09:02:12 +0000 URL: https://git.openjdk.java.net/loom/commit/c0e3d107f67a1a333dbe58ae745200d85764c74e 8283008: KRegister documentation out of date Reviewed-by: dlong, sviswanathan, jiefu, jbhateja ! src/hotspot/cpu/x86/register_x86.hpp Changeset: 01570ca9 Author: Aleksey Shipilev Date: 2022-03-14 09:03:05 +0000 URL: https://git.openjdk.java.net/loom/commit/01570ca92d234481df2d540027e320b91af415a0 8283017: GHA: Workflows break with update release versions Reviewed-by: erikj, ihse ! .github/workflows/submit.yml Changeset: 5f3d4032 Author: Ahmed Muhsin Committer: Christian Hagedorn Date: 2022-03-14 09:05:53 +0000 URL: https://git.openjdk.java.net/loom/commit/5f3d4032f3a8854f7afde28698e66a7b6684aed7 8272735: Add missing SubL node transformations Reviewed-by: thartmann, chagedorn ! src/hotspot/share/opto/subnode.cpp ! test/hotspot/jtreg/compiler/c2/irTests/SubINodeIdealizationTests.java ! test/hotspot/jtreg/compiler/c2/irTests/SubLNodeIdealizationTests.java Changeset: ea9eeea8 Author: Roland Westrelin Date: 2022-03-14 13:59:13 +0000 URL: https://git.openjdk.java.net/loom/commit/ea9eeea8ffea6ed32a270051c6986f4f059943c0 8281322: C2: always construct strip mined loop initially (even if strip mining is disabled) Reviewed-by: chagedorn, thartmann ! src/hotspot/share/opto/loopnode.cpp ! src/hotspot/share/opto/loopnode.hpp + test/hotspot/jtreg/compiler/c2/irTests/TestCountedLoopSafepoint.java ! test/hotspot/jtreg/compiler/c2/irTests/TestLongRangeChecks.java Changeset: 08573cc3 Author: Zdenek Zambersky Committer: Bradford Wetmore Date: 2022-03-14 14:21:58 +0000 URL: https://git.openjdk.java.net/loom/commit/08573cc3b2370a697a7bd4ad0665ee20ae148d39 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket Reviewed-by: wetmore, xuelei ! src/java.base/share/classes/javax/net/ssl/SSLSocket.java Changeset: 13cebffe Author: Brian Burkhalter Date: 2022-03-14 16:10:15 +0000 URL: https://git.openjdk.java.net/loom/commit/13cebffe618255ae29310c95fd1b91576e576751 8058924: FileReader(String) documentation is insufficient Reviewed-by: naoto, lancea ! src/java.base/share/classes/java/io/package-info.java Changeset: c96085ea Author: Naoto Sato Date: 2022-03-14 16:28:15 +0000 URL: https://git.openjdk.java.net/loom/commit/c96085eaab1f6b21e084b94fcc619d090f0afc97 8282929: Localized monetary symbols are not reflected in `toLocalizedPattern` return value Reviewed-by: joehw, lancea ! src/java.base/share/classes/java/text/DecimalFormat.java + test/jdk/java/text/Format/DecimalFormat/ToLocalizedPatternTest.java Changeset: 7833667f Author: Emanuel Peter Committer: Harold Seigel Date: 2022-03-14 17:35:09 +0000 URL: https://git.openjdk.java.net/loom/commit/7833667f0e2151fc56c7c1533015f004f02f7ab2 8282881: Print exception message in VM crash with -XX:AbortVMOnException Reviewed-by: dholmes, hseigel ! src/hotspot/share/utilities/exceptions.cpp Changeset: 70bd57ed Author: Carter Kozak Committer: Daniel Fuchs Date: 2022-03-14 17:54:19 +0000 URL: https://git.openjdk.java.net/loom/commit/70bd57ed3544cdb41029d425507ba4b9b35c8cdb 8283049: Fix non-singleton LoggerFinder error message: s/on/one Reviewed-by: dfuchs ! src/java.base/share/classes/jdk/internal/logger/LoggerFinderLoader.java ! test/jdk/java/lang/System/LoggerFinder/internal/LoggerFinderLoaderTest/LoggerFinderLoaderTest.java Changeset: f66070b0 Author: Phil Race Date: 2022-03-14 18:05:38 +0000 URL: https://git.openjdk.java.net/loom/commit/f66070b00d4311c6e3a6fbf38956fa2d5da5fada 8282577: ICC_Profile.setData(int, byte[]) invalidates the profile Reviewed-by: serb ! src/java.desktop/share/native/liblcms/LCMS.c + test/jdk/java/awt/color/ICC_ColorSpace/SetTagDataValidation.java ! test/jdk/java/awt/color/ICC_Profile/MTGetData.java Changeset: 5bf6a7f7 Author: Chris Plummer Date: 2022-03-14 18:15:40 +0000 URL: https://git.openjdk.java.net/loom/commit/5bf6a7f7d78506118ded0f0bf6383b0825366619 8282691: add jdb "-R" option for passing any argument to the launched debuggee process Reviewed-by: alanb, kevinw ! src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTY.java ! src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources.java ! src/jdk.jdi/share/man/jdb.1 ! test/jdk/com/sun/jdi/JdbOptions.java Changeset: a244051a Author: Mikael Vidstedt Date: 2022-03-14 18:37:41 +0000 URL: https://git.openjdk.java.net/loom/commit/a244051a8c967039d7639afcaf83f7d92af49613 8283062: Uninitialized warnings in libgtest with GCC 11.2 Reviewed-by: jiefu, erikj ! make/hotspot/lib/CompileGtest.gmk Changeset: 5ba5e21f Author: Hannes Walln?fer Date: 2022-03-14 20:28:07 +0000 URL: https://git.openjdk.java.net/loom/commit/5ba5e21fd2a02d15d4d56931cae4f9a978470c88 8282214: Upgrade JQuery to version 3.6.0 Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDoclet.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/script-dir/jquery-3.5.1.min.js = src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/script-dir/jquery-3.6.0.js + src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/script-dir/jquery-3.6.0.min.js ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/DocPaths.java ! src/jdk.javadoc/share/legal/jquery.md ! test/langtools/jdk/javadoc/doclet/testSearch/TestSearch.java ! test/langtools/jdk/javadoc/tool/api/basic/APITest.java Changeset: 6013d09e Author: Hannes Walln?fer Date: 2022-03-14 20:29:15 +0000 URL: https://git.openjdk.java.net/loom/commit/6013d09e82693a1c07cf0bf6daffd95114b3cbfa 8268866: Javascript when used in an iframe cannot display search results Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/search.js.template Changeset: 34d4ffce Author: Dean Long Date: 2022-03-15 07:24:50 +0000 URL: https://git.openjdk.java.net/loom/commit/34d4ffcea5d71560c549655967de863342b48984 8279317: compiler/jvmci/compilerToVM/DisassembleCodeBlobTest.java assumes immutable code Reviewed-by: dnsimon, iveresov ! test/hotspot/jtreg/compiler/jvmci/compilerToVM/DisassembleCodeBlobTest.java Changeset: 710653ce Author: Daniel Fuchs Date: 2022-03-15 12:59:54 +0000 URL: https://git.openjdk.java.net/loom/commit/710653ce1856d13161ae1786d7c5f71997536e78 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently Reviewed-by: jpai, michaelm ! src/java.net.http/share/classes/jdk/internal/net/http/Exchange.java ! src/java.net.http/share/classes/jdk/internal/net/http/Http2ClientImpl.java ! src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java ! test/jdk/java/net/httpclient/CancelRequestTest.java Changeset: 2cddf3f5 Author: Zhengyu Gu Date: 2022-03-15 14:16:35 +0000 URL: https://git.openjdk.java.net/loom/commit/2cddf3f5391518ea40796e6c4759047d51b7b312 8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows Reviewed-by: naoto, alanb ! src/java.base/windows/native/libjava/HostLocaleProviderAdapter_md.c Changeset: 4de72014 Author: Tyler Steele Committer: Thomas Stuefe Date: 2022-03-15 14:52:27 +0000 URL: https://git.openjdk.java.net/loom/commit/4de72014d3a33469399fec6f428f35c47c4cfbe0 8283122: [AIX, s390] UnsafeCopyMemory 'Mismatched' Tests Fail on Big Endian Systems Reviewed-by: thartmann, stuefe ! test/hotspot/jtreg/compiler/unsafe/UnsafeCopyMemory.java Changeset: f43ffe21 Author: Hai-May Chao Date: 2022-03-15 15:54:47 +0000 URL: https://git.openjdk.java.net/loom/commit/f43ffe211f8ff287697092c39e4c25a16b40a383 8282633: jarsigner output does not explain why an EC key is disabled if its curve has been disabled Reviewed-by: weijun ! src/java.base/share/classes/sun/security/tools/keytool/Main.java ! src/java.base/share/classes/sun/security/util/KeyUtil.java ! src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java ! src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources.java + test/jdk/sun/security/tools/jarsigner/DisableCurveTest.java Changeset: 671b6efd Author: Joe Darcy Date: 2022-03-15 16:05:37 +0000 URL: https://git.openjdk.java.net/loom/commit/671b6efd6126384c0630d1cd84f53f52995e68d8 8283143: Use minimal-length literals to initialize PI and E constants Reviewed-by: smarks ! src/java.base/share/classes/java/lang/Math.java ! src/java.base/share/classes/java/lang/StrictMath.java Changeset: 05a83e03 Author: Joe Darcy Date: 2022-03-15 16:22:11 +0000 URL: https://git.openjdk.java.net/loom/commit/05a83e03ca35b4885b48bb0e7d188baf8f7d9d7f 8283124: Add constant for tau to Math and StrictMath Reviewed-by: bpb, iris ! src/java.base/share/classes/java/lang/Math.java ! src/java.base/share/classes/java/lang/StrictMath.java Changeset: 12dca36c Author: Tobias Hartmann Date: 2022-03-15 16:28:54 +0000 URL: https://git.openjdk.java.net/loom/commit/12dca36c73583d0ed2e1f684b056100dc1f2ef55 8283189: Bad copyright header in UnsafeCopyMemory.java Reviewed-by: chagedorn, dcubed ! test/hotspot/jtreg/compiler/unsafe/UnsafeCopyMemory.java Changeset: 32f8437d Author: Joe Darcy Date: 2022-03-15 17:33:45 +0000 URL: https://git.openjdk.java.net/loom/commit/32f8437d85a003914d5ca35bdddebdc732ab222d 8283075: Bad IllegalArgumentException message for out of range rank from ClassDesc.arrayType(int) Reviewed-by: vromero, alanb ! src/java.base/share/classes/java/lang/constant/ClassDesc.java ! test/jdk/java/lang/constant/ClassDescTest.java Changeset: ac06bdb1 Author: Man Cao Date: 2022-03-15 20:05:33 +0000 URL: https://git.openjdk.java.net/loom/commit/ac06bdb1239a97b7ea2fee8280da8ebc9728dc30 8282507: Add a separate license file for hsdis Reviewed-by: ihse + src/utils/hsdis/hsdis-license.txt Changeset: 1465ea98 Author: Dean Long Date: 2022-03-15 20:17:36 +0000 URL: https://git.openjdk.java.net/loom/commit/1465ea98b7736b5960a8b546ccc366c3e3260bdd 8282355: compiler/arguments/TestCodeEntryAlignment.java failed "guarantee(sect->end() <= tend) failed: sanity" Reviewed-by: jiefu, thartmann, shade ! src/hotspot/share/runtime/stubRoutines.cpp ! test/hotspot/jtreg/compiler/arguments/TestCodeEntryAlignment.java Changeset: bacfaa3e Author: Quan Anh Mai Committer: Sandhya Viswanathan Date: 2022-03-16 01:10:22 +0000 URL: https://git.openjdk.java.net/loom/commit/bacfaa3ee16882563200ef3b3df4441b33664451 8282414: x86: Enhance the assembler to generate more compact instructions Reviewed-by: thartmann, sviswanathan ! src/hotspot/cpu/x86/assembler_x86.cpp ! src/hotspot/cpu/x86/assembler_x86.hpp ! src/hotspot/cpu/x86/x86_64.ad Changeset: 27fe3d7f Author: Toshio Nakamura Committer: Sergey Bylokhov Date: 2022-03-16 01:11:40 +0000 URL: https://git.openjdk.java.net/loom/commit/27fe3d7f8db4ede6441a7cc325d9f29eb4a1d10d 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled Reviewed-by: prr, serb ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CTextPipe.java + test/jdk/java/awt/font/GlyphVector/MultiSlotFontTest.java Changeset: 4df24c5d Author: Joe Darcy Date: 2022-03-16 02:02:10 +0000 URL: https://git.openjdk.java.net/loom/commit/4df24c5df38eeacc73097f71383916e9a0933839 8283230: Improve @jls usage in ElementType Reviewed-by: jjg, iris ! src/java.base/share/classes/java/lang/annotation/ElementType.java Changeset: de4f04cb Author: Ioi Lam Date: 2022-03-16 03:12:48 +0000 URL: https://git.openjdk.java.net/loom/commit/de4f04cb71a26ce03b96460cb8d1c1e28cd1ed38 8253495: CDS generates non-deterministic output Reviewed-by: erikj, kbarrett, ccheung, ihse ! make/scripts/compare.sh ! src/hotspot/share/cds/archiveBuilder.cpp ! src/hotspot/share/cds/archiveUtils.hpp ! src/hotspot/share/cds/dumpTimeClassInfo.hpp ! src/hotspot/share/cds/heapShared.cpp ! src/hotspot/share/cds/heapShared.hpp ! src/hotspot/share/gc/shared/collectedHeap.cpp ! src/hotspot/share/gc/shared/collectedHeap.hpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/runtime/os.cpp ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/runtime/cds/DeterministicDump.java ! test/hotspot/jtreg/runtime/cds/appcds/javaldr/LockDuringDump.java ! test/hotspot/jtreg/runtime/cds/appcds/javaldr/LockDuringDumpAgent.java ! test/lib/jdk/test/lib/cds/CDSOptions.java Changeset: 08cadb47 Author: Swati Sharma Committer: Jatin Bhateja Date: 2022-03-16 09:48:09 +0000 URL: https://git.openjdk.java.net/loom/commit/08cadb4754da0d5e68ee2df45f4098d203d14115 8271195: Use largest available large page size smaller than LargePageSizeInBytes when available Co-authored-by: Jatin Bhateja Reviewed-by: ayang, tschatzl ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/share/memory/virtualspace.cpp + test/micro/org/openjdk/bench/vm/gc/MicroLargePages.java From duke at openjdk.java.net Thu Mar 17 14:36:24 2022 From: duke at openjdk.java.net (duke) Date: Thu, 17 Mar 2022 14:36:24 GMT Subject: git: openjdk/loom: fibers: Add LoomVM flag Message-ID: <33e89070-abe9-4c2a-9469-4c3595faa006@openjdk.java.net> Changeset: 92e98522 Author: Ron Pressler Date: 2022-03-17 14:23:43 +0000 URL: https://git.openjdk.java.net/loom/commit/92e98522ba4172bce267a6868fed70d61d46d792 Add LoomVM flag ! src/hotspot/share/runtime/continuation.cpp ! src/hotspot/share/runtime/globals.hpp From duke at openjdk.java.net Thu Mar 17 16:39:17 2022 From: duke at openjdk.java.net (duke) Date: Thu, 17 Mar 2022 16:39:17 GMT Subject: git: openjdk/loom: fibers: AArch64 nmethod entry barrier overhaul leftovers Message-ID: Changeset: 66b98dd9 Author: Erik ?sterlund Date: 2022-03-17 13:33:52 +0000 URL: https://git.openjdk.java.net/loom/commit/66b98dd96bb75b266e585f713011c3da653bf27f AArch64 nmethod entry barrier overhaul leftovers ! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp ! src/hotspot/share/gc/shared/barrierSetNMethod.cpp ! src/hotspot/share/runtime/thread.hpp From coleenp at openjdk.java.net Thu Mar 17 18:42:21 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Thu, 17 Mar 2022 18:42:21 GMT Subject: RFR: Note frames that are on the heap, rather than addressing mode [v2] In-Reply-To: References: Message-ID: > ... for interpreted frames. > This changes "addressing mode" to a boolean whether the frame is on the heap instead. The compiler frames don't have code that uses the relative offsets but the frames can be marked as on-heap anyway. > There's one place that I passed false, not sure if that's right. > Not urgent to code review. > Tested with: alias loomjprt='mach5 --patch-based --extra-src-dirs /scratch/cphillim/hg/jdk-loom -j loom-tier1,loom-tier2,loom-tier3' Coleen Phillimore has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Merge branch 'fibers' into heap-frame - Note frames that are on the heap, rather than addressing mode for interpreted frames. - Note frames that are on the heap, rather than addressing mode for interpreted frames. ------------- Changes: https://git.openjdk.java.net/loom/pull/106/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=106&range=01 Stats: 154 lines in 20 files changed: 18 ins; 51 del; 85 mod Patch: https://git.openjdk.java.net/loom/pull/106.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/106/head:pull/106 PR: https://git.openjdk.java.net/loom/pull/106 From coleenp at openjdk.java.net Thu Mar 17 18:42:21 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Thu, 17 Mar 2022 18:42:21 GMT Subject: RFR: Note frames that are on the heap, rather than addressing mode In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 14:27:33 GMT, Coleen Phillimore wrote: > ... for interpreted frames. > This changes "addressing mode" to a boolean whether the frame is on the heap instead. The compiler frames don't have code that uses the relative offsets but the frames can be marked as on-heap anyway. > There's one place that I passed false, not sure if that's right. > Not urgent to code review. > Tested with: alias loomjprt='mach5 --patch-based --extra-src-dirs /scratch/cphillim/hg/jdk-loom -j loom-tier1,loom-tier2,loom-tier3' Thanks Ron! ------------- PR: https://git.openjdk.java.net/loom/pull/106 From coleenp at openjdk.java.net Thu Mar 17 18:42:22 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Thu, 17 Mar 2022 18:42:22 GMT Subject: Integrated: Note frames that are on the heap, rather than addressing mode In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 14:27:33 GMT, Coleen Phillimore wrote: > ... for interpreted frames. > This changes "addressing mode" to a boolean whether the frame is on the heap instead. The compiler frames don't have code that uses the relative offsets but the frames can be marked as on-heap anyway. > There's one place that I passed false, not sure if that's right. > Not urgent to code review. > Tested with: alias loomjprt='mach5 --patch-based --extra-src-dirs /scratch/cphillim/hg/jdk-loom -j loom-tier1,loom-tier2,loom-tier3' This pull request has now been integrated. Changeset: d405b732 Author: Coleen Phillimore URL: https://git.openjdk.java.net/loom/commit/d405b73268a508f4a69ad1dcec6f67d8f3f2b8f7 Stats: 154 lines in 20 files changed: 18 ins; 51 del; 85 mod Note frames that are on the heap, rather than addressing mode Reviewed-by: rpressler ------------- PR: https://git.openjdk.java.net/loom/pull/106 From cjplummer at openjdk.java.net Fri Mar 18 07:38:37 2022 From: cjplummer at openjdk.java.net (Chris Plummer) Date: Fri, 18 Mar 2022 07:38:37 GMT Subject: RFR: Better jdb support for vthreads. Improved jdb vthread testing support. [v6] In-Reply-To: References: Message-ID: > This PR contains a set of some what disparate but related set of changes to JDB, JDI, and nsk jdb tests and test support (Jdb.java). > > jdb: Made the ?kill? command support `ThreadReference.stop()` throwing `IllegalThreadStateException` for vthreads, because this is how `ThreadReference.stop()` is now spec?d. This change is in `Commands.java`. The rest of the changes are just cleanup. One of the changes in the `kill001` test is to test for this (see below) > > jdb: Use `PlatformThreadOnlyFilters` to prevent `ThreadStart/Death` event for vthreads. Instead detect vthreads when events are received on them. The goal here is to prevent jdb from getting a flood of `ThreadStart/Death` events, and getting bogged down with them. With the `PlatformThreadOnlyFilters` in place, this means jdb is not notified when a vthread dies, even one that it learned about later when an event came in on it. For these each of these ?learned? vthreads a separate `ThreadDeathRequest` is needed that uses the thread itself as a `ThreadFilter`. This way jdb can tell when these vthreads die. This part is handled in `EventHandler.java`. `VMConnection.java` is where `PlatformThreadOnlyFilters` are added. > > jdb: Add `-trackallvthreads` option. This prevents the use of the `PlatformThreadsOnlyFilters` described above, and instead relies on jdb getting the initial set of vthreads from the debug agent via `VM.allThreads()` (by turning on the `enumeratevthreads` option), and by getting a `ThreadStart/Death` event for every vthread created/destroyed after connecting. This is basially how jdb used to work by default before any changes in this PR. There are 3 tests that rely on this behaviour and need this flag. They are `kill001`, `threads002`, and `trace001` (see below). Many more would rely on it if they were converted to use vthreads as these tests were. The bulk of the changes for this support comes from having to pass `trackAllVthreads` through all sorts of constuctors/inits. I wish there were a better way, but I couldn?t find a place to store this value as a static so it is easy to access. If you see a better way, let me know. > > jdb: Track vthreads separately. jdb keeps track of every thread by creating a `ThreadInfo` for each and storing it in a `List` called `threads`. I decided to store vthreads in a separate list. The reason is the list is needed by the `threads` command. It doesn?t use the `threads` list, but instead walks the `ThreadGroup` hierarchy and prints out the threads within each `ThreadGroup`. This doesn?t capture vthreads since they are not returned by `ThreadGroupReference.threads()`, even for the `VirtualThreads` group. So after the `threads` command has done its usual `ThreadGroup` traversal, it now also dumps all the vthreads. This is pretty much all hidden in `ThreadIterator.next()`, which automically transitions to getting threads from the vthread list after traversing all the `ThreadGroups`. > > `nsk/share/jdb/Jdb.java`: Added support for `getThreadIdsByName()`: There are many jdb tests that use `Jdb.getThreadIds()` to get all threads in the `threads` output that are an instance of ``. The problem is that after converting a test to support a vthread mode for all debuggee threads, the name of the class in the output will always be `java.lang.VirtualThread` (or `java.lang.Thread` when not in vthread mode), and not the test specific class name, which is usually something like `MyThread`. Making `getThreadIds()` search for `java.lang.VirtualThreads` usually ends up including threads not wanted (ones that are not `MyThread`) such as the main test thread. So `getThreadIdsByName()` was added to allow searching by the thread name (actually just the prefix of the name) rather than its class. As an example, the `threads` command output used to contain a line such as: > > ` (nsk.jdb.kill.kill001.MyThread)693 Thread-0 waiting in a monitor` > > Now it contains: > > ` (java.lang.Thread)693 MyThread-0 waiting in a monitor` > > So instead of searching for ?(MyThread)? and grabbing the threadId that comes right after it, `getThreadIdsByName()` first finds all the lines of output that contain ?nsk.jdb.kill.kill001.MyThread?, and then for those lines only gets the threadID that is right after ?(java.lang.Thread)? or ?(java.lang.VirtualThread)?. > > jdb `kill001` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. Use new `getThreadIdsByName()` support instead of `getThreadIds()`. Allow/expect the `kill` command to fail with "Illegal thread state? when in vthread mode. > > jdb `threads002` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. I forget why I decided to convert this test. Seems it was useful for testing something I was working on for this PR, but I can?t recall. Maybe it was so I could clone it for the new `threads003` test below. > > jdb `trace001` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. This is a test I had converted long ago when I first experimented with the `getThreadIdsByName()` support, so I included it with this PR. > > jdb `threads003` test: This is a new thread test that tests jdb?s ability to learn about a thread when an event arrives on it. It creates 5 threads, two of which receive a breakpoint. It looks at the `threads` output and checks that only those two vthreads are present. I also used this test to help confirm that the `ThreadDeath` events are only received for these two vthreads. This was done manually by looking for the ?TDR removed? output generated by `EventHandler.threadDeathEvent()`. I didn?t put this into the test itself since that println is just for debugging and is now commented out. Chris Plummer has updated the pull request incrementally with four additional commits since the last revision: - Rename trackallvthreads to trackvthreads. - use implements Runnable instead of extends Thread. - Use waittime=5 intead of 1 like the other tests do. - Rename trackallvthreads to trackvthreads. ------------- Changes: - all: https://git.openjdk.java.net/loom/pull/97/files - new: https://git.openjdk.java.net/loom/pull/97/files/344a30df..e73ae936 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=loom&pr=97&range=05 - incr: https://webrevs.openjdk.java.net/?repo=loom&pr=97&range=04-05 Stats: 27 lines in 11 files changed: 0 ins; 0 del; 27 mod Patch: https://git.openjdk.java.net/loom/pull/97.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/97/head:pull/97 PR: https://git.openjdk.java.net/loom/pull/97 From stefank at openjdk.java.net Fri Mar 18 09:27:11 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Fri, 18 Mar 2022 09:27:11 GMT Subject: RFR: Loom cleanups Message-ID: Various cleanups and restructuring. ------------- Commit messages: - Restructure stackChunkOop bitmap - Move copy_alignment to continuation.cpp - Restructuring stackChunkOop files - Small cleanups to instanceStackChunkKlass.cpp - Cleanup InstanceStackChunkKlass friendship - Limit classes using chunk_frames - Split out classes out of InstanceStackChunkKlass files - Simplify InstanceStackChunkKlass copy - Move inlined functions - Simpler devirtualization of bitmap closure - ... and 1 more: https://git.openjdk.java.net/loom/compare/d405b732...7ab30096 Changes: https://git.openjdk.java.net/loom/pull/108/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=108&range=00 Stats: 4001 lines in 50 files changed: 2285 ins; 1617 del; 99 mod Patch: https://git.openjdk.java.net/loom/pull/108.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/108/head:pull/108 PR: https://git.openjdk.java.net/loom/pull/108 From coleenp at openjdk.java.net Fri Mar 18 11:32:42 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Fri, 18 Mar 2022 11:32:42 GMT Subject: RFR: Loom cleanups In-Reply-To: References: Message-ID: <1usNxUE58wB5OLzsAdSnnWpi8msZn35ZkFotD9M6QfE=.6ee342b5-f411-4bd7-bf47-f88544bcb00c@github.com> On Fri, 18 Mar 2022 09:20:19 GMT, Stefan Karlsson wrote: > Various cleanups and restructuring. Thank you! this was one of the things I wanted most. I was reviewing the stackChunkFrameStream separation patch. Good. ------------- Marked as reviewed by coleenp (Committer). PR: https://git.openjdk.java.net/loom/pull/108 From duke at openjdk.java.net Fri Mar 18 11:47:36 2022 From: duke at openjdk.java.net (duke) Date: Fri, 18 Mar 2022 11:47:36 GMT Subject: git: openjdk/loom: fibers: decrease GetSetLocalTest execution time for stability Message-ID: Changeset: 8fc11826 Author: Serguei Spitsyn Date: 2022-03-18 11:46:05 +0000 URL: https://git.openjdk.java.net/loom/commit/8fc1182661b8935fad83cb16bbdfedaf756488eb decrease GetSetLocalTest execution time for stability ! test/hotspot/jtreg/serviceability/jvmti/vthread/GetSetLocalTest/libGetSetLocalTest.cpp From eosterlund at openjdk.java.net Fri Mar 18 14:04:56 2022 From: eosterlund at openjdk.java.net (Erik =?UTF-8?B?w5ZzdGVybHVuZA==?=) Date: Fri, 18 Mar 2022 14:04:56 GMT Subject: RFR: Loom cleanups In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 09:20:19 GMT, Stefan Karlsson wrote: > Various cleanups and restructuring. Nice cleaup! ------------- Marked as reviewed by eosterlund (Committer). PR: https://git.openjdk.java.net/loom/pull/108 From duke at openjdk.java.net Fri Mar 18 16:11:58 2022 From: duke at openjdk.java.net (duke) Date: Fri, 18 Mar 2022 16:11:58 GMT Subject: git: openjdk/loom: fibers: 18 new changesets Message-ID: Changeset: d94a518e Author: Erik ?sterlund Committer: Ron Pressler Date: 2022-03-17 16:55:20 +0000 URL: https://git.openjdk.java.net/loom/commit/d94a518e712b63ecdcc060e45e695d914804ff4d Disable nmethod entry barriers when not using continuations ! src/hotspot/share/code/codeCache.cpp ! src/hotspot/share/gc/shared/barrierSet.cpp ! src/hotspot/share/memory/iterator.cpp ! src/hotspot/share/runtime/thread.cpp Changeset: 1afbe1dc Author: Erik ?sterlund Committer: Ron Pressler Date: 2022-03-17 17:04:31 +0000 URL: https://git.openjdk.java.net/loom/commit/1afbe1dca97d989df6a8c4b0579a2cbc242b4a9b Disable C2 held montor count tracking when loom is disabled ! src/hotspot/share/opto/macro.cpp Changeset: 8b0b25c4 Author: Ron Pressler Date: 2022-03-17 20:52:15 +0000 URL: https://git.openjdk.java.net/loom/commit/8b0b25c4d7804e1c18550f66f99fa2e84b296176 - ! src/hotspot/share/oops/instanceStackChunkKlass.cpp ! src/hotspot/share/runtime/thread.cpp Changeset: 1704b24a Author: Ron Pressler Date: 2022-03-18 10:22:09 +0000 URL: https://git.openjdk.java.net/loom/commit/1704b24a612196e95444a866df15688e5f523b16 Add debug declarations ! src/hotspot/share/oops/instanceStackChunkKlass.cpp ! src/hotspot/share/utilities/debug.cpp ! src/hotspot/share/utilities/debug.hpp Changeset: 16963b3c Author: Ron Pressler Date: 2022-03-18 10:22:17 +0000 URL: https://git.openjdk.java.net/loom/commit/16963b3ca3ebf3751fdc69825e46fc2ff429f74b - ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp Changeset: 8db14fd5 Author: Ron Pressler Date: 2022-03-18 11:05:41 +0000 URL: https://git.openjdk.java.net/loom/commit/8db14fd5b9284f04f80b9857de10400b8f51bcd2 Add JavaFrameAnchor::patch_last_Java_pc ! src/hotspot/cpu/aarch64/frame_aarch64.cpp ! src/hotspot/cpu/aarch64/javaFrameAnchor_aarch64.hpp ! src/hotspot/cpu/x86/frame_x86.cpp ! src/hotspot/cpu/x86/javaFrameAnchor_x86.hpp ! src/hotspot/share/runtime/continuation.cpp Changeset: 3ffdc2fe Author: Ron Pressler Date: 2022-03-18 12:52:53 +0000 URL: https://git.openjdk.java.net/loom/commit/3ffdc2fe46468244a96a542c89579ce16417bc8f Run UnexpectedDeoptimizationTest and UnexpectedDeoptimizationAllTest with a virtual thread ! test/hotspot/jtreg/compiler/codecache/stress/Helper.java ! test/hotspot/jtreg/compiler/codecache/stress/UnexpectedDeoptimizationAllTest.java ! test/hotspot/jtreg/compiler/codecache/stress/UnexpectedDeoptimizationTest.java Changeset: b6a9b339 Author: Stefan Karlsson Committer: Ron Pressler Date: 2022-03-17 09:19:12 +0000 URL: https://git.openjdk.java.net/loom/commit/b6a9b33947b7794c7e64275372955eda501009ce Remove unused is_concurrent_gc ! src/hotspot/share/gc/epsilon/epsilonBarrierSet.hpp ! src/hotspot/share/gc/shared/cardTableBarrierSet.hpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp ! src/hotspot/share/gc/z/zBarrierSet.hpp Changeset: 5fcf720c Author: Stefan Karlsson Committer: Ron Pressler Date: 2022-03-17 09:59:07 +0000 URL: https://git.openjdk.java.net/loom/commit/5fcf720c5ef3b890629f0db8d69ca303f7e74340 Simpler devirtualization of bitmap closure ! src/hotspot/share/gc/z/zCollectedHeap.cpp ! src/hotspot/share/memory/iterator.inline.hpp ! src/hotspot/share/oops/instanceStackChunkKlass.inline.hpp ! src/hotspot/share/utilities/bitMap.inline.hpp Changeset: fe611835 Author: Stefan Karlsson Committer: Ron Pressler Date: 2022-03-17 11:15:30 +0000 URL: https://git.openjdk.java.net/loom/commit/fe6118353700b3146408fc6c2c3a76590d2e19b8 Move inlined functions ! src/hotspot/share/oops/instanceStackChunkKlass.cpp ! src/hotspot/share/runtime/continuation.cpp ! src/hotspot/share/runtime/deoptimization.cpp ! src/hotspot/share/runtime/frame.cpp ! src/hotspot/share/runtime/frame_helpers.inline.hpp ! src/hotspot/share/runtime/stackValue.hpp + src/hotspot/share/runtime/stackValue.inline.hpp ! src/hotspot/share/runtime/vframe.hpp ! src/hotspot/share/runtime/vframe.inline.hpp ! src/hotspot/share/runtime/vframe_hp.cpp Changeset: ddf9a5db Author: Stefan Karlsson Committer: Ron Pressler Date: 2022-03-17 11:55:49 +0000 URL: https://git.openjdk.java.net/loom/commit/ddf9a5dbb18180f7b19d14c8478db7e85f15d7c9 Simplify InstanceStackChunkKlass copy ! src/hotspot/share/oops/instanceStackChunkKlass.cpp ! src/hotspot/share/oops/instanceStackChunkKlass.hpp Changeset: 3b253e96 Author: Stefan Karlsson Committer: Ron Pressler Date: 2022-03-17 13:43:00 +0000 URL: https://git.openjdk.java.net/loom/commit/3b253e96e352eb06f009bc11d158250ce8c506e6 Split out classes out of InstanceStackChunkKlass files ! src/hotspot/cpu/aarch64/instanceStackChunkKlass_aarch64.inline.hpp + src/hotspot/cpu/aarch64/smallRegisterMap_aarch64.inline.hpp + src/hotspot/cpu/aarch64/stackChunkFrameStream_aarch64.inline.hpp + src/hotspot/cpu/aarch64/stackChunkOop_aarch64.inline.hpp ! src/hotspot/cpu/arm/instanceStackChunkKlass_arm.inline.hpp + src/hotspot/cpu/arm/smallRegisterMap_arm.inline.hpp + src/hotspot/cpu/arm/stackChunkFrameStream_arm.inline.hpp + src/hotspot/cpu/arm/stackChunkOop_arm.inline.hpp ! src/hotspot/cpu/ppc/instanceStackChunkKlass_ppc.inline.hpp + src/hotspot/cpu/ppc/smallRegisterMap_ppc.inline.hpp + src/hotspot/cpu/ppc/stackChunkFrameStream_ppc.inline.hpp + src/hotspot/cpu/ppc/stackChunkOop_ppc.inline.hpp ! src/hotspot/cpu/s390/instanceStackChunkKlass_s390.inline.hpp + src/hotspot/cpu/s390/smallRegisterMap_s390.inline.hpp + src/hotspot/cpu/s390/stackChunkFrameStream_s390.inline.hpp + src/hotspot/cpu/s390/stackChunkOop_s390.inline.hpp ! src/hotspot/cpu/x86/instanceStackChunkKlass_x86.inline.hpp + src/hotspot/cpu/x86/smallRegisterMap_x86.inline.hpp + src/hotspot/cpu/x86/stackChunkFrameStream_x86.inline.hpp + src/hotspot/cpu/x86/stackChunkOop_x86.inline.hpp ! src/hotspot/cpu/zero/instanceStackChunkKlass_zero.inline.hpp + src/hotspot/cpu/zero/smallRegisterMap_zero.inline.hpp + src/hotspot/cpu/zero/stackChunkFrameStream_zero.inline.hpp + src/hotspot/cpu/zero/stackChunkOop_zero.inline.hpp ! src/hotspot/share/oops/instanceStackChunkKlass.cpp ! src/hotspot/share/oops/instanceStackChunkKlass.hpp ! src/hotspot/share/oops/instanceStackChunkKlass.inline.hpp ! src/hotspot/share/oops/stackChunkOop.cpp ! src/hotspot/share/oops/stackChunkOop.inline.hpp ! src/hotspot/share/runtime/continuation.cpp + src/hotspot/share/runtime/smallRegisterMap.inline.hpp + src/hotspot/share/runtime/stackChunkFrameStream.hpp + src/hotspot/share/runtime/stackChunkFrameStream.inline.hpp ! src/hotspot/share/runtime/stackValue.cpp Changeset: eb45a208 Author: Stefan Karlsson Committer: Ron Pressler Date: 2022-03-17 14:06:47 +0000 URL: https://git.openjdk.java.net/loom/commit/eb45a208abefbe5a574e94026819967248d0fa3d Limit classes using chunk_frames ! src/hotspot/share/oops/instanceStackChunkKlass.cpp ! src/hotspot/share/oops/instanceStackChunkKlass.hpp ! src/hotspot/share/oops/instanceStackChunkKlass.inline.hpp ! src/hotspot/share/oops/stackChunkOop.hpp ! src/hotspot/share/oops/stackChunkOop.inline.hpp ! src/hotspot/share/runtime/stackChunkFrameStream.hpp Changeset: 6ab4687e Author: Stefan Karlsson Committer: Ron Pressler Date: 2022-03-17 14:29:10 +0000 URL: https://git.openjdk.java.net/loom/commit/6ab4687e40182438b1c20f796597d1969715b0fa Cleanup InstanceStackChunkKlass friendship ! src/hotspot/share/oops/instanceStackChunkKlass.hpp ! src/hotspot/share/oops/instanceStackChunkKlass.inline.hpp ! src/hotspot/share/oops/stackChunkOop.hpp ! src/hotspot/share/oops/stackChunkOop.inline.hpp ! src/hotspot/share/runtime/continuation.cpp Changeset: b5f2c84c Author: Stefan Karlsson Committer: Ron Pressler Date: 2022-03-17 15:24:33 +0000 URL: https://git.openjdk.java.net/loom/commit/b5f2c84cfb80f246a2df8615372ce684795a69f2 Small cleanups to instanceStackChunkKlass.cpp ! src/hotspot/share/oops/instanceStackChunkKlass.cpp ! src/hotspot/share/oops/instanceStackChunkKlass.hpp Changeset: 29c94bc1 Author: Stefan Karlsson Committer: Ron Pressler Date: 2022-03-17 16:19:07 +0000 URL: https://git.openjdk.java.net/loom/commit/29c94bc139a6306f3676d97fcc8f93a0888a2168 Restructuring stackChunkOop files ! src/hotspot/share/oops/stackChunkOop.cpp ! src/hotspot/share/oops/stackChunkOop.hpp ! src/hotspot/share/oops/stackChunkOop.inline.hpp Changeset: 1e46a719 Author: Stefan Karlsson Committer: Ron Pressler Date: 2022-03-17 16:24:09 +0000 URL: https://git.openjdk.java.net/loom/commit/1e46a7192e85c20349d14d47fe9c21e809a3847b Move copy_alignment to continuation.cpp ! src/hotspot/share/oops/stackChunkOop.hpp ! src/hotspot/share/runtime/continuation.cpp Changeset: 02acc6a6 Author: Stefan Karlsson Committer: Ron Pressler Date: 2022-03-17 19:14:29 +0000 URL: https://git.openjdk.java.net/loom/commit/02acc6a6360a122ff8b912e904dd9ad5e7659d06 Restructure stackChunkOop bitmap ! src/hotspot/share/oops/instanceStackChunkKlass.hpp ! src/hotspot/share/oops/instanceStackChunkKlass.inline.hpp ! src/hotspot/share/oops/stackChunkOop.hpp ! src/hotspot/share/oops/stackChunkOop.inline.hpp From cjplummer at openjdk.java.net Fri Mar 18 17:03:00 2022 From: cjplummer at openjdk.java.net (Chris Plummer) Date: Fri, 18 Mar 2022 17:03:00 GMT Subject: Integrated: Better jdb support for vthreads. Improved jdb vthread testing support. In-Reply-To: References: Message-ID: On Mon, 7 Mar 2022 03:35:55 GMT, Chris Plummer wrote: > This PR contains a set of some what disparate but related set of changes to JDB, JDI, and nsk jdb tests and test support (Jdb.java). > > jdb: Made the ?kill? command support `ThreadReference.stop()` throwing `IllegalThreadStateException` for vthreads, because this is how `ThreadReference.stop()` is now spec?d. This change is in `Commands.java`. The rest of the changes are just cleanup. One of the changes in the `kill001` test is to test for this (see below) > > jdb: Use `PlatformThreadOnlyFilters` to prevent `ThreadStart/Death` event for vthreads. Instead detect vthreads when events are received on them. The goal here is to prevent jdb from getting a flood of `ThreadStart/Death` events, and getting bogged down with them. With the `PlatformThreadOnlyFilters` in place, this means jdb is not notified when a vthread dies, even one that it learned about later when an event came in on it. For these each of these ?learned? vthreads a separate `ThreadDeathRequest` is needed that uses the thread itself as a `ThreadFilter`. This way jdb can tell when these vthreads die. This part is handled in `EventHandler.java`. `VMConnection.java` is where `PlatformThreadOnlyFilters` are added. > > jdb: Add `-trackallvthreads` option. This prevents the use of the `PlatformThreadsOnlyFilters` described above, and instead relies on jdb getting the initial set of vthreads from the debug agent via `VM.allThreads()` (by turning on the `enumeratevthreads` option), and by getting a `ThreadStart/Death` event for every vthread created/destroyed after connecting. This is basially how jdb used to work by default before any changes in this PR. There are 3 tests that rely on this behaviour and need this flag. They are `kill001`, `threads002`, and `trace001` (see below). Many more would rely on it if they were converted to use vthreads as these tests were. The bulk of the changes for this support comes from having to pass `trackAllVthreads` through all sorts of constuctors/inits. I wish there were a better way, but I couldn?t find a place to store this value as a static so it is easy to access. If you see a better way, let me know. > > jdb: Track vthreads separately. jdb keeps track of every thread by creating a `ThreadInfo` for each and storing it in a `List` called `threads`. I decided to store vthreads in a separate list. The reason is the list is needed by the `threads` command. It doesn?t use the `threads` list, but instead walks the `ThreadGroup` hierarchy and prints out the threads within each `ThreadGroup`. This doesn?t capture vthreads since they are not returned by `ThreadGroupReference.threads()`, even for the `VirtualThreads` group. So after the `threads` command has done its usual `ThreadGroup` traversal, it now also dumps all the vthreads. This is pretty much all hidden in `ThreadIterator.next()`, which automically transitions to getting threads from the vthread list after traversing all the `ThreadGroups`. > > `nsk/share/jdb/Jdb.java`: Added support for `getThreadIdsByName()`: There are many jdb tests that use `Jdb.getThreadIds()` to get all threads in the `threads` output that are an instance of ``. The problem is that after converting a test to support a vthread mode for all debuggee threads, the name of the class in the output will always be `java.lang.VirtualThread` (or `java.lang.Thread` when not in vthread mode), and not the test specific class name, which is usually something like `MyThread`. Making `getThreadIds()` search for `java.lang.VirtualThreads` usually ends up including threads not wanted (ones that are not `MyThread`) such as the main test thread. So `getThreadIdsByName()` was added to allow searching by the thread name (actually just the prefix of the name) rather than its class. As an example, the `threads` command output used to contain a line such as: > > ` (nsk.jdb.kill.kill001.MyThread)693 Thread-0 waiting in a monitor` > > Now it contains: > > ` (java.lang.Thread)693 MyThread-0 waiting in a monitor` > > So instead of searching for ?(MyThread)? and grabbing the threadId that comes right after it, `getThreadIdsByName()` first finds all the lines of output that contain ?nsk.jdb.kill.kill001.MyThread?, and then for those lines only gets the threadID that is right after ?(java.lang.Thread)? or ?(java.lang.VirtualThread)?. > > jdb `kill001` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. Use new `getThreadIdsByName()` support instead of `getThreadIds()`. Allow/expect the `kill` command to fail with "Illegal thread state? when in vthread mode. > > jdb `threads002` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. I forget why I decided to convert this test. Seems it was useful for testing something I was working on for this PR, but I can?t recall. Maybe it was so I could clone it for the new `threads003` test below. > > jdb `trace001` test: Convert to support all debuggee threads being vthreads by using `JDIThreadFactory`. Enable new jdb `-trackallvthreads` option. This is a test I had converted long ago when I first experimented with the `getThreadIdsByName()` support, so I included it with this PR. > > jdb `threads003` test: This is a new thread test that tests jdb?s ability to learn about a thread when an event arrives on it. It creates 5 threads, two of which receive a breakpoint. It looks at the `threads` output and checks that only those two vthreads are present. I also used this test to help confirm that the `ThreadDeath` events are only received for these two vthreads. This was done manually by looking for the ?TDR removed? output generated by `EventHandler.threadDeathEvent()`. I didn?t put this into the test itself since that println is just for debugging and is now commented out. This pull request has now been integrated. Changeset: 47929b86 Author: Chris Plummer URL: https://git.openjdk.java.net/loom/commit/47929b8656c2d7945fa8b049ffbed93845b4a06f Stats: 494 lines in 17 files changed: 422 ins; 2 del; 70 mod Better jdb support for vthreads. Improved jdb vthread testing support. ------------- PR: https://git.openjdk.java.net/loom/pull/97 From duke at openjdk.java.net Fri Mar 18 17:20:09 2022 From: duke at openjdk.java.net (duke) Date: Fri, 18 Mar 2022 17:20:09 GMT Subject: git: openjdk/loom: fibers: Minor comment improvment Message-ID: <6e148a9c-73e7-4ea4-bcda-0efcb6dafbfa@openjdk.java.net> Changeset: ac85b960 Author: Chris Plummer Date: 2022-03-18 17:17:23 +0000 URL: https://git.openjdk.java.net/loom/commit/ac85b960cf01fe7283b2e9da69f8e812bd9b80d3 Minor comment improvment ! src/jdk.jdwp.agent/share/native/libjdwp/threadControl.c From duke at openjdk.java.net Fri Mar 18 19:36:57 2022 From: duke at openjdk.java.net (duke) Date: Fri, 18 Mar 2022 19:36:57 GMT Subject: git: openjdk/loom: fibers: 2 new changesets Message-ID: Changeset: c512d926 Author: Ron Pressler Date: 2022-03-18 17:49:30 +0000 URL: https://git.openjdk.java.net/loom/commit/c512d9268cc331f0edba42e75450a7ce7245f8bc 8283297: Remove mounted vthread information from JavaThread::print_thread_state_on ! src/hotspot/share/runtime/thread.cpp Changeset: 2cd331f7 Author: Ron Pressler Date: 2022-03-18 18:09:08 +0000 URL: https://git.openjdk.java.net/loom/commit/2cd331f72c2c8aa92f05f075aa28b815e350ea70 Move JavaThread::_mounted_vthread to oop storage ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/vmStructs.cpp From duke at openjdk.java.net Fri Mar 18 20:49:30 2022 From: duke at openjdk.java.net (duke) Date: Fri, 18 Mar 2022 20:49:30 GMT Subject: git: openjdk/loom: fibers: Fix bounds002. Sometimes main() is still the topmost frame when the thread is supsended, so StackFrame.setValue() on a vthread should be expected to work in that case, not fail with OpaqueFrameException. Message-ID: Changeset: 6d31fb13 Author: Chris Plummer Date: 2022-03-18 20:48:41 +0000 URL: https://git.openjdk.java.net/loom/commit/6d31fb137069c1fe7b15c9546cf8756561c4ca5a Fix bounds002. Sometimes main() is still the topmost frame when the thread is supsended, so StackFrame.setValue() on a vthread should be expected to work in that case, not fail with OpaqueFrameException. ! test/hotspot/jtreg/vmTestbase/nsk/jdi/StackFrame/_bounds_/bounds002.java From duke at openjdk.java.net Sat Mar 19 03:48:59 2022 From: duke at openjdk.java.net (duke) Date: Sat, 19 Mar 2022 03:48:59 GMT Subject: git: openjdk/loom: fibers: ThreadReference.popFrames() should throw NativeMethodException if OPAQUE_FRAME is returned and the method is native. Message-ID: Changeset: 528abf94 Author: Chris Plummer Date: 2022-03-19 03:47:45 +0000 URL: https://git.openjdk.java.net/loom/commit/528abf94f70e03ac88a4d18e95b2dc83964a8ce9 ThreadReference.popFrames() should throw NativeMethodException if OPAQUE_FRAME is returned and the method is native. ! src/jdk.jdi/share/classes/com/sun/tools/jdi/StackFrameImpl.java From duke at openjdk.java.net Sat Mar 19 06:12:26 2022 From: duke at openjdk.java.net (duke) Date: Sat, 19 Mar 2022 06:12:26 GMT Subject: git: openjdk/loom: fibers: Document jdb -trackvthreads option. Message-ID: Changeset: d743d591 Author: Chris Plummer Date: 2022-03-19 06:10:44 +0000 URL: https://git.openjdk.java.net/loom/commit/d743d5918febf1af5edcb972652b9d3f5c75e10d Document jdb -trackvthreads option. ! src/jdk.jdi/share/man/jdb.1 From duke at openjdk.java.net Sat Mar 19 10:30:42 2022 From: duke at openjdk.java.net (duke) Date: Sat, 19 Mar 2022 10:30:42 GMT Subject: git: openjdk/loom: fibers: add extra debug log msg to GetSetLocalTest Message-ID: <956368c8-b629-4583-8db6-2c0c4db0b3a5@openjdk.java.net> Changeset: e20e0aec Author: Serguei Spitsyn Date: 2022-03-19 10:29:49 +0000 URL: https://git.openjdk.java.net/loom/commit/e20e0aecaa98ab6c4c52a7180d0ab786fbf33a94 add extra debug log msg to GetSetLocalTest ! test/hotspot/jtreg/serviceability/jvmti/vthread/GetSetLocalTest/libGetSetLocalTest.cpp From duke at openjdk.java.net Sat Mar 19 10:52:02 2022 From: duke at openjdk.java.net (duke) Date: Sat, 19 Mar 2022 10:52:02 GMT Subject: git: openjdk/loom: fibers: add more debug log messages to GetSetLocalTest Message-ID: <8894c07f-47c3-4f1b-8ed4-376357698b99@openjdk.java.net> Changeset: ea9c29d3 Author: Serguei Spitsyn Date: 2022-03-19 10:50:40 +0000 URL: https://git.openjdk.java.net/loom/commit/ea9c29d3f2835c8314f02e8f0388b6f066e7e11c add more debug log messages to GetSetLocalTest ! test/hotspot/jtreg/serviceability/jvmti/vthread/GetSetLocalTest/libGetSetLocalTest.cpp From duke at openjdk.java.net Sat Mar 19 17:41:15 2022 From: duke at openjdk.java.net (duke) Date: Sat, 19 Mar 2022 17:41:15 GMT Subject: git: openjdk/loom: fibers: Fix 8243016. Some Thread fields have moved into new Thread class. Message-ID: <7d434b88-2776-41a5-96e0-c59bccb29805@openjdk.java.net> Changeset: 9f738d62 Author: Chris Plummer Date: 2022-03-19 17:39:49 +0000 URL: https://git.openjdk.java.net/loom/commit/9f738d62db2a81e4de268f427ccc4856f633a8db Fix 8243016. Some Thread fields have moved into new Thread class. ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/SystemDictionary.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/OopUtilities.java ! test/hotspot/jtreg/ProblemList.txt From duke at openjdk.java.net Sat Mar 19 18:27:51 2022 From: duke at openjdk.java.net (duke) Date: Sat, 19 Mar 2022 18:27:51 GMT Subject: git: openjdk/loom: fibers: Get rid of SA support for ThreadGroups. It wasn't being used by any tool, and doesn't work properly now that ThreadGroup no longer keeps track of all threads in the group. Message-ID: Changeset: 616bb69c Author: Chris Plummer Date: 2022-03-19 18:26:10 +0000 URL: https://git.openjdk.java.net/loom/commit/616bb69ca06101de1d81c3bd40a09ded733f7ddb Get rid of SA support for ThreadGroups. It wasn't being used by any tool, and doesn't work properly now that ThreadGroup no longer keeps track of all threads in the group. ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/SystemDictionary.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/OopUtilities.java From duke at openjdk.java.net Sat Mar 19 18:53:27 2022 From: duke at openjdk.java.net (duke) Date: Sat, 19 Mar 2022 18:53:27 GMT Subject: git: openjdk/loom: fibers: JFR: vthread include/exclude, support for recursive thread id, stacktraces to avoid loading oops, coalesce vthread checkpoints for bulk serialization Message-ID: <9766915f-0efa-4546-8f82-cb107a5ddef2@openjdk.java.net> Changeset: 6cad8075 Author: mgronlun Date: 2022-03-19 19:51:38 +0000 URL: https://git.openjdk.java.net/loom/commit/6cad8075e06060f396c10c41c66897fcb427d423 JFR: vthread include/exclude, support for recursive thread id, stacktraces to avoid loading oops, coalesce vthread checkpoints for bulk serialization ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/javaClasses.inline.hpp ! src/hotspot/share/gc/shared/copyFailedInfo.hpp ! src/hotspot/share/jfr/jfr.cpp ! src/hotspot/share/jfr/jfrEvents.hpp ! src/hotspot/share/jfr/jni/jfrJavaSupport.cpp ! src/hotspot/share/jfr/jni/jfrJavaSupport.hpp ! src/hotspot/share/jfr/jni/jfrJniMethod.cpp ! src/hotspot/share/jfr/metadata/metadata.xml ! src/hotspot/share/jfr/periodic/jfrPeriodic.cpp ! src/hotspot/share/jfr/periodic/jfrThreadCPULoadEvent.cpp ! src/hotspot/share/jfr/periodic/sampling/jfrThreadSampler.cpp ! src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointManager.cpp ! src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointWriter.cpp ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrThreadState.cpp ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrType.cpp ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeManager.cpp ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeManager.hpp ! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrOopTraceId.hpp ! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrOopTraceId.inline.hpp ! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdEpoch.cpp ! src/hotspot/share/jfr/recorder/service/jfrEvent.hpp ! src/hotspot/share/jfr/recorder/service/jfrRecorderThread.cpp ! src/hotspot/share/jfr/recorder/stacktrace/jfrStackTrace.cpp ! src/hotspot/share/jfr/recorder/stacktrace/jfrStackTraceRepository.cpp ! src/hotspot/share/jfr/recorder/storage/jfrBuffer.cpp ! src/hotspot/share/jfr/recorder/storage/jfrBuffer.hpp ! src/hotspot/share/jfr/recorder/storage/jfrMemorySpace.inline.hpp ! src/hotspot/share/jfr/recorder/storage/jfrStorage.cpp ! src/hotspot/share/jfr/recorder/storage/jfrStorageUtils.hpp ! src/hotspot/share/jfr/support/jfrIntrinsics.cpp ! src/hotspot/share/jfr/support/jfrThreadExtension.hpp ! src/hotspot/share/jfr/support/jfrThreadId.hpp ! src/hotspot/share/jfr/support/jfrThreadId.inline.hpp ! src/hotspot/share/jfr/support/jfrThreadLocal.cpp ! src/hotspot/share/jfr/support/jfrThreadLocal.hpp ! src/hotspot/share/jfr/writers/jfrJavaEventWriter.cpp ! src/hotspot/share/jfr/writers/jfrJavaEventWriter.hpp ! src/hotspot/share/jfr/writers/jfrStorageAdapter.hpp ! src/hotspot/share/jfr/writers/jfrStreamWriterHost.hpp ! src/hotspot/share/jfr/writers/jfrStreamWriterHost.inline.hpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/prims/jni.cpp ! src/hotspot/share/runtime/continuation.cpp ! src/hotspot/share/runtime/java.cpp ! src/jdk.jfr/share/classes/jdk/jfr/internal/EventHandlerCreator.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/EventWriter.java ! test/jdk/ProblemList-vthread.txt ! test/jdk/jdk/jfr/api/consumer/recordingstream/TestRecursive.java = test/jdk/jdk/jfr/jvm/LatchedThread.java ! test/jdk/jdk/jfr/jvm/TestThreadExclusion.java + test/jdk/jdk/jfr/jvm/TestVirtualThreadExclusion.java ! test/jdk/jdk/jfr/threading/TestManyVirtualThreads.java ! test/jdk/jdk/jfr/threading/TestNestedVirtualThreads.java ! test/micro/org/openjdk/bench/loom/Skynet.java ! test/micro/pom.xml From duke at openjdk.java.net Sat Mar 19 20:06:13 2022 From: duke at openjdk.java.net (duke) Date: Sat, 19 Mar 2022 20:06:13 GMT Subject: git: openjdk/loom: fibers: Fix previous commit to pop(). Error checking was not correct. Message-ID: <185811a3-240a-4776-978b-52603d37a9b1@openjdk.java.net> Changeset: f6b45f3b Author: Chris Plummer Date: 2022-03-19 20:00:51 +0000 URL: https://git.openjdk.java.net/loom/commit/f6b45f3b423eb3205fbe3ddc44a91e4b25295012 Fix previous commit to pop(). Error checking was not correct. ! src/jdk.jdi/share/classes/com/sun/tools/jdi/StackFrameImpl.java From duke at openjdk.java.net Sun Mar 20 12:20:13 2022 From: duke at openjdk.java.net (duke) Date: Sun, 20 Mar 2022 12:20:13 GMT Subject: git: openjdk/loom: fibers: JFR: map the vthread default name onto the empty string instead of null Message-ID: <26d00625-c46c-4ad8-b71a-bd49f3298329@openjdk.java.net> Changeset: 686e2445 Author: mgronlun Date: 2022-03-20 13:18:13 +0000 URL: https://git.openjdk.java.net/loom/commit/686e2445a65144bf6d219bc18bee55e7507837fa JFR: map the vthread default name onto the empty string instead of null ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrThreadState.cpp ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrThreadState.hpp ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrType.cpp ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrType.hpp ! src/hotspot/share/jfr/support/jfrIntrinsics.cpp ! src/hotspot/share/jfr/support/jfrThreadLocal.cpp ! src/hotspot/share/jfr/writers/jfrWriterHost.hpp ! src/hotspot/share/jfr/writers/jfrWriterHost.inline.hpp ! src/hotspot/share/opto/library_call.cpp ! src/jdk.jfr/share/classes/jdk/jfr/internal/EventWriter.java ! test/jdk/jdk/jfr/threading/TestManyVirtualThreads.java ! test/jdk/jdk/jfr/threading/TestNestedVirtualThreads.java From duke at openjdk.java.net Sun Mar 20 16:54:31 2022 From: duke at openjdk.java.net (duke) Date: Sun, 20 Mar 2022 16:54:31 GMT Subject: git: openjdk/loom: fibers: 5 new changesets Message-ID: <283515e0-3ba3-451a-b94e-08b45b4b8530@openjdk.java.net> Changeset: c3d46469 Author: Ron Pressler Date: 2022-03-20 12:36:59 +0000 URL: https://git.openjdk.java.net/loom/commit/c3d46469db73370f441c73bfee0546839248b929 Use text blocks in RedefineClasses tests ! test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineAddLambdaExpression.java ! test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineDoubleDelete.java ! test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineFinalizer.java ! test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineInterfaceCall.java ! test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineInterfaceMethods.java ! test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefinePreviousVersions.java ! test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineRunningMethods.java ! test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineRunningMethodsWithBacktrace.java ! test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineSubtractLambdaExpression.java ! test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TestRedefineCondy.java Changeset: 28a2ff9d Author: Ron Pressler Date: 2022-03-20 12:38:51 +0000 URL: https://git.openjdk.java.net/loom/commit/28a2ff9dcad526d2f6c349d3bd949ed282e3673d Whitespace ! src/hotspot/share/runtime/thread.cpp Changeset: 5aaf10b5 Author: Ron Pressler Date: 2022-03-20 14:45:07 +0000 URL: https://git.openjdk.java.net/loom/commit/5aaf10b5cf35f250b11bf491579e3d8c97444cbc Guard stub generation and held_monitor_count in the interpreter with Continuations::enabled() ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp Changeset: 1a5f019d Author: Ron Pressler Date: 2022-03-20 14:58:33 +0000 URL: https://git.openjdk.java.net/loom/commit/1a5f019db504d3a31d5e4569eeabacbf40823a79 Refactor nmethod & Method marking in chunks ! src/hotspot/share/oops/instanceStackChunkKlass.cpp Changeset: d514ce50 Author: Ron Pressler Date: 2022-03-20 16:52:43 +0000 URL: https://git.openjdk.java.net/loom/commit/d514ce505721be6432cbc6d62d257b2b71de7c5f Remove assertion ! src/hotspot/share/prims/jvmtiEnvBase.cpp From duke at openjdk.java.net Sun Mar 20 17:06:17 2022 From: duke at openjdk.java.net (duke) Date: Sun, 20 Mar 2022 17:06:17 GMT Subject: git: openjdk/loom: fibers: 3 new changesets Message-ID: <4eca35c9-5913-4d1f-909a-d973cc246b44@openjdk.java.net> Changeset: 4a4d9216 Author: Alan Bateman Date: 2022-03-20 08:32:43 +0000 URL: https://git.openjdk.java.net/loom/commit/4a4d92160281b76f022af58b424e344e5b4711eb Exclude PasteAndMeasurementsUITest from wrapper runs, uses Thread.stop ! test/langtools/ProblemList-vthread.txt Changeset: 4b1ec510 Author: Alan Bateman Date: 2022-03-20 08:39:21 +0000 URL: https://git.openjdk.java.net/loom/commit/4b1ec51072bebd19c840cb08dd37346b4c702997 Reduce noise in tier6 ! test/hotspot/jtreg/ProblemList-Xcomp.txt Changeset: b5c7e734 Author: Alan Bateman Date: 2022-03-20 14:31:03 +0000 URL: https://git.openjdk.java.net/loom/commit/b5c7e734eaaf5e77fc2194915c9fd07e6b95a169 Test should not run with release builds ! test/hotspot/jtreg/compiler/arguments/TestCodeEntryAlignment.java From haosun at openjdk.java.net Mon Mar 21 05:10:11 2022 From: haosun at openjdk.java.net (Hao Sun) Date: Mon, 21 Mar 2022 05:10:11 GMT Subject: RFR: 8282849: Loom: Fix minimal debug non-PCH build failure [v2] In-Reply-To: References: Message-ID: > As described in JBS-8282849, this build failure was introduced by commit > bd25c94 and commit 4d27102. Adding the missing headers would fix it. Hao Sun has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge branch 'fibers' into minimal-build - 8282849: Loom: Fix minimal debug non-PCH build failure As described in JBS-8282849, this build failure was introduced by commit bd25c94 and commit 4d27102. Adding the missing headers would fix it. ------------- Changes: https://git.openjdk.java.net/loom/pull/99/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=99&range=01 Stats: 6 lines in 2 files changed: 6 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/loom/pull/99.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/99/head:pull/99 PR: https://git.openjdk.java.net/loom/pull/99 From haosun at openjdk.java.net Mon Mar 21 05:15:33 2022 From: haosun at openjdk.java.net (Hao Sun) Date: Mon, 21 Mar 2022 05:15:33 GMT Subject: RFR: 8282849: Loom: Fix minimal debug non-PCH build failure [v3] In-Reply-To: References: Message-ID: > As described in JBS-8282849, this build failure was introduced by commit > bd25c94 and commit 4d27102. Adding the missing headers would fix it. Hao Sun has updated the pull request incrementally with one additional commit since the last revision: Fix build error after commit 6cad807 Header "jfr/support/jfrThreadId.hpp" was removed in commit 6cad807, leading to the following build error: === Output from failing command(s) repeated here === * For target hotspot_variant-minimal_libjvm_objs_cardGeneration.o: In file included from ~/jdk_src/src/hotspot/share/gc/serial/defNewGeneration.hpp:30, from ~/jdk_src/src/hotspot/share/gc/serial/defNewGeneration.inline.hpp:28, from ~/jdk_src/src/hotspot/share/gc/shared/genOopClosures.inline.hpp:39, from ~/jdk_src/src/hotspot/share/gc/shared/cardGeneration.cpp:32: ~/jdk_src/src/hotspot/share/gc/shared/copyFailedInfo.hpp:66:3: error: 'traceid' does not name a type 66 | traceid _thread_trace_id; | ^~~~~~~ ~/jdk_src/src/hotspot/share/gc/shared/copyFailedInfo.hpp:81:3: error: 'traceid' does not name a type 81 | traceid thread_trace_id() const { return _thread_trace_id; } | ^~~~~~~ ~/jdk_src/src/hotspot/share/gc/shared/copyFailedInfo.hpp: In constructor 'PromotionFailedInfo::PromotionFailedInfo()': ~/jdk_src/src/hotspot/share/gc/shared/copyFailedInfo.hpp:69:45: error: class 'PromotionFailedInfo' does not have any field named '_thread_trace_id' 69 | PromotionFailedInfo() : CopyFailedInfo(), _thread_trace_id(0) {} | ^~~~~~~~~~~~~~~~ ~/jdk_src/src/hotspot/share/gc/shared/copyFailedInfo.hpp: In member function 'virtual void PromotionFailedInfo::register_copy_failure(size_t)': ... (rest of output omitted) * All command lines available in ~/build-release/make-support/failure-logs. === End of repeated output === ------------- Changes: - all: https://git.openjdk.java.net/loom/pull/99/files - new: https://git.openjdk.java.net/loom/pull/99/files/7be51b8f..978cfa3e Webrevs: - full: https://webrevs.openjdk.java.net/?repo=loom&pr=99&range=02 - incr: https://webrevs.openjdk.java.net/?repo=loom&pr=99&range=01-02 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/loom/pull/99.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/99/head:pull/99 PR: https://git.openjdk.java.net/loom/pull/99 From tschatzl at openjdk.java.net Mon Mar 21 12:30:17 2022 From: tschatzl at openjdk.java.net (Thomas Schatzl) Date: Mon, 21 Mar 2022 12:30:17 GMT Subject: Integrated: Fix compilation with gcc 11.2 Message-ID: Hi all, please review this small change to add code that disables the `-Wnonnull` warning for `JvmtiThreadState::state_for_while_locked`; the warning/error seems to be in error. Thanks, Thomas ------------- Commit messages: - Disable wrong warning Changes: https://git.openjdk.java.net/loom/pull/109/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=109&range=00 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/loom/pull/109.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/109/head:pull/109 PR: https://git.openjdk.java.net/loom/pull/109 From rpressler at openjdk.java.net Mon Mar 21 12:30:18 2022 From: rpressler at openjdk.java.net (Ron Pressler) Date: Mon, 21 Mar 2022 12:30:18 GMT Subject: Integrated: Fix compilation with gcc 11.2 In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 12:09:34 GMT, Thomas Schatzl wrote: > Hi all, > > please review this small change to add code that disables the `-Wnonnull` warning for `JvmtiThreadState::state_for_while_locked`; the warning/error seems to be in error. > > Thanks, > Thomas Marked as reviewed by rpressler (Lead). ------------- PR: https://git.openjdk.java.net/loom/pull/109 From tschatzl at openjdk.java.net Mon Mar 21 12:30:18 2022 From: tschatzl at openjdk.java.net (Thomas Schatzl) Date: Mon, 21 Mar 2022 12:30:18 GMT Subject: Integrated: Fix compilation with gcc 11.2 In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 12:09:34 GMT, Thomas Schatzl wrote: > Hi all, > > please review this small change to add code that disables the `-Wnonnull` warning for `JvmtiThreadState::state_for_while_locked`; the warning/error seems to be in error. > > Thanks, > Thomas Sorry for the back and forth with the PR as I was trying out something; did not expect that anyone reviewed a draft. Since I'm not committer, you will need to bring it/sponsor I guess. ------------- PR: https://git.openjdk.java.net/loom/pull/109 From tschatzl at openjdk.java.net Mon Mar 21 12:30:19 2022 From: tschatzl at openjdk.java.net (Thomas Schatzl) Date: Mon, 21 Mar 2022 12:30:19 GMT Subject: Integrated: Fix compilation with gcc 11.2 In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 12:09:34 GMT, Thomas Schatzl wrote: > Hi all, > > please review this small change to add code that disables the `-Wnonnull` warning for `JvmtiThreadState::state_for_while_locked`; the warning/error seems to be in error. > > Thanks, > Thomas This pull request has now been integrated. Changeset: 6c224b31 Author: Thomas Schatzl Committer: Erik ?sterlund URL: https://git.openjdk.java.net/loom/commit/6c224b3144005e862140aefce6b5f8c18204d36d Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Fix compilation with gcc 11.2 Reviewed-by: rpressler ------------- PR: https://git.openjdk.java.net/loom/pull/109 From duke at openjdk.java.net Mon Mar 21 13:09:40 2022 From: duke at openjdk.java.net (duke) Date: Mon, 21 Mar 2022 13:09:40 GMT Subject: git: openjdk/loom: fibers: Compiled method iterator that blocks the sweeper to prevent racy Message-ID: <6701b6d7-45fe-4bef-a7ef-93b59b9a1bed@openjdk.java.net> Changeset: 986a9006 Author: Rickard B?ckman Date: 2022-03-18 14:53:17 +0000 URL: https://git.openjdk.java.net/loom/commit/986a9006e2323bd5ba238f2778e22a5bb57087a1 Compiled method iterator that blocks the sweeper to prevent racy zombies. ! src/hotspot/share/code/codeCache.cpp ! src/hotspot/share/code/codeCache.hpp ! src/hotspot/share/runtime/deoptimization.cpp ! src/hotspot/share/runtime/sweeper.cpp From coleenp at openjdk.java.net Mon Mar 21 14:09:12 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Mon, 21 Mar 2022 14:09:12 GMT Subject: RFR: Remove Config In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 13:28:53 GMT, Robbin Ehn wrote: > For you to consider. > - Adds 1-2ns (thaw+freeze) (<0.5%) > - Passes t1-3 (no new issues found) > - Reduces compilation time with over 30 seconds (15-20%). > - Loom have the same compile time as vanilla jdk/jdk. Looks good. This helps readability and we need convince ourselves that there's no other way to get this small bit of performance back other than these templates. src/hotspot/share/runtime/continuation.cpp line 2613: > 2611: stackChunkOop chunk = _cont.tail(); > 2612: chunk->bitmap().clear_range(chunk->bit_index_for((typename ConfigT::OopT*)start), > 2613: chunk->bit_index_for((typename ConfigT::OopT*)(start+range))); I hate C++ template syntax. ------------- Marked as reviewed by coleenp (Committer). PR: https://git.openjdk.java.net/loom/pull/110 From rpressler at openjdk.java.net Mon Mar 21 14:09:13 2022 From: rpressler at openjdk.java.net (Ron Pressler) Date: Mon, 21 Mar 2022 14:09:13 GMT Subject: RFR: Remove Config In-Reply-To: References: Message-ID: <9RPpBdjnen2tqx-gqlv3LZRtRPjbR-qxaLvlk6UK2bs=.4109ae0e-b456-4006-8898-221cb3a1cb6e@github.com> On Mon, 21 Mar 2022 13:28:53 GMT, Robbin Ehn wrote: > For you to consider. > - Adds 1-2ns (thaw+freeze) (<0.5%) > - Passes t1-3 (no new issues found) > - Reduces compilation time with over 30 seconds (15-20%). > - Loom have the same compile time as vanilla jdk/jdk. We'll get to this a bit later :) ------------- PR: https://git.openjdk.java.net/loom/pull/110 From duke at openjdk.java.net Mon Mar 21 18:05:37 2022 From: duke at openjdk.java.net (duke) Date: Mon, 21 Mar 2022 18:05:37 GMT Subject: git: openjdk/loom: fibers: 2 new changesets Message-ID: <56198f5d-414d-46e0-af9e-b4df94008325@openjdk.java.net> Changeset: 4b2e9899 Author: Alan Bateman Date: 2022-03-21 12:50:22 +0000 URL: https://git.openjdk.java.net/loom/commit/4b2e9899aaf9bbc76c39fb2ff9caaaa180dae8db Virtual threads not supported if target VM is older release ! src/jdk.jdi/share/classes/com/sun/tools/jdi/EventRequestManagerImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ThreadReferenceImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java Changeset: 052776ec Author: Alan Bateman Date: 2022-03-21 18:02:58 +0000 URL: https://git.openjdk.java.net/loom/commit/052776ecf5e46058da48163f91be61794e4f2d65 Change default thread name to empty string ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrThreadState.cpp ! src/java.base/share/classes/java/lang/Thread.java ! src/java.base/share/classes/java/lang/VirtualThread.java ! test/jdk/java/lang/Thread/BuilderTest.java ! test/jdk/java/lang/Thread/virtual/ThreadAPI.java From duke at openjdk.java.net Mon Mar 21 18:51:48 2022 From: duke at openjdk.java.net (duke) Date: Mon, 21 Mar 2022 18:51:48 GMT Subject: git: openjdk/loom: fibers: 46 new changesets Message-ID: Changeset: 9b8afce3 Author: Magnus Ihse Bursie Date: 2022-03-16 16:07:32 +0000 URL: https://git.openjdk.java.net/loom/commit/9b8afce3791080d664c5051a86592706f5b0ade0 8283260: gcc is not supported on mac Reviewed-by: erikj ! make/autoconf/flags-ldflags.m4 ! make/autoconf/toolchain.m4 Changeset: 0cf291bc Author: Joe Darcy Date: 2022-03-16 16:17:50 +0000 URL: https://git.openjdk.java.net/loom/commit/0cf291bc31acf69c767c5d39d21b1195e6d761b2 8283234: Improve @jls usage in java.base Reviewed-by: iris ! src/java.base/share/classes/java/lang/StringConcatHelper.java ! src/java.base/share/classes/java/lang/invoke/MethodHandle.java ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java ! src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java ! src/java.base/share/classes/java/lang/reflect/TypeVariable.java Changeset: 3e393047 Author: XenoAmess Committer: Stuart Marks Date: 2022-03-16 16:48:49 +0000 URL: https://git.openjdk.java.net/loom/commit/3e393047e12147a81e2899784b943923fc34da8e 8281631: HashMap copy constructor and putAll can over-allocate table Reviewed-by: smarks ! src/java.base/share/classes/java/util/HashMap.java ! src/java.base/share/classes/java/util/WeakHashMap.java ! test/jdk/ProblemList.txt ! test/jdk/java/util/HashMap/WhiteBoxResizeTest.java Changeset: 3da5204b Author: Jie Fu Date: 2022-03-17 00:05:57 +0000 URL: https://git.openjdk.java.net/loom/commit/3da5204b3c3a3f95bddcdcfe2628c2e0ed8a12d9 8283229: compiler/arguments/TestCodeEntryAlignment.java fails with release VMs Reviewed-by: dlong ! test/hotspot/jtreg/compiler/arguments/TestCodeEntryAlignment.java Changeset: a5ebcc0c Author: Ivan Walulya Date: 2022-03-17 08:54:29 +0000 URL: https://git.openjdk.java.net/loom/commit/a5ebcc0c04bedd87bc9a523b0a45b50fc4b0f5f0 8282072: G1: Rename CardSetPtr to CardSetContainerPtr Reviewed-by: ayang, tschatzl ! src/hotspot/share/gc/g1/g1CardSet.cpp ! src/hotspot/share/gc/g1/g1CardSet.hpp ! src/hotspot/share/gc/g1/g1CardSet.inline.hpp ! src/hotspot/share/gc/g1/g1CardSetContainers.hpp ! src/hotspot/share/gc/g1/g1CardSetContainers.inline.hpp ! src/hotspot/share/gc/g1/heapRegionRemSet.inline.hpp ! test/hotspot/gtest/gc/g1/test_g1CardSet.cpp ! test/hotspot/gtest/gc/g1/test_g1CardSetContainers.cpp Changeset: 096bca4a Author: Prasanta Sadhukhan Date: 2022-03-17 09:10:08 +0000 URL: https://git.openjdk.java.net/loom/commit/096bca4a9c5e8ac2668dd965df92153ea1d80add 8282473: Refactor swing classes javadoc to use @throws instead of @exception Reviewed-by: aivanov, dmarkov, prr ! src/java.desktop/share/classes/javax/swing/AbstractButton.java ! src/java.desktop/share/classes/javax/swing/AbstractListModel.java ! src/java.desktop/share/classes/javax/swing/BorderFactory.java ! src/java.desktop/share/classes/javax/swing/BoxLayout.java ! src/java.desktop/share/classes/javax/swing/DefaultBoundedRangeModel.java ! src/java.desktop/share/classes/javax/swing/DefaultButtonModel.java ! src/java.desktop/share/classes/javax/swing/DefaultListModel.java ! src/java.desktop/share/classes/javax/swing/DefaultListSelectionModel.java ! src/java.desktop/share/classes/javax/swing/DefaultSingleSelectionModel.java ! src/java.desktop/share/classes/javax/swing/JApplet.java ! src/java.desktop/share/classes/javax/swing/JColorChooser.java ! src/java.desktop/share/classes/javax/swing/JComboBox.java ! src/java.desktop/share/classes/javax/swing/JComponent.java ! src/java.desktop/share/classes/javax/swing/JEditorPane.java ! src/java.desktop/share/classes/javax/swing/JFileChooser.java ! src/java.desktop/share/classes/javax/swing/JFrame.java ! src/java.desktop/share/classes/javax/swing/JInternalFrame.java ! src/java.desktop/share/classes/javax/swing/JLabel.java ! src/java.desktop/share/classes/javax/swing/JLayer.java ! src/java.desktop/share/classes/javax/swing/JList.java ! src/java.desktop/share/classes/javax/swing/JMenu.java ! src/java.desktop/share/classes/javax/swing/JOptionPane.java ! src/java.desktop/share/classes/javax/swing/JPasswordField.java ! src/java.desktop/share/classes/javax/swing/JPopupMenu.java ! src/java.desktop/share/classes/javax/swing/JProgressBar.java ! src/java.desktop/share/classes/javax/swing/JRootPane.java ! src/java.desktop/share/classes/javax/swing/JScrollBar.java ! src/java.desktop/share/classes/javax/swing/JScrollPane.java ! src/java.desktop/share/classes/javax/swing/JSeparator.java ! src/java.desktop/share/classes/javax/swing/JSlider.java ! src/java.desktop/share/classes/javax/swing/JSpinner.java ! src/java.desktop/share/classes/javax/swing/JSplitPane.java ! src/java.desktop/share/classes/javax/swing/JTabbedPane.java ! src/java.desktop/share/classes/javax/swing/JTable.java ! src/java.desktop/share/classes/javax/swing/JTextArea.java ! src/java.desktop/share/classes/javax/swing/JTextField.java ! src/java.desktop/share/classes/javax/swing/JTextPane.java ! src/java.desktop/share/classes/javax/swing/JToolBar.java ! src/java.desktop/share/classes/javax/swing/JTree.java ! src/java.desktop/share/classes/javax/swing/JViewport.java ! src/java.desktop/share/classes/javax/swing/JWindow.java ! src/java.desktop/share/classes/javax/swing/OverlayLayout.java ! src/java.desktop/share/classes/javax/swing/Popup.java ! src/java.desktop/share/classes/javax/swing/PopupFactory.java ! src/java.desktop/share/classes/javax/swing/ProgressMonitor.java ! src/java.desktop/share/classes/javax/swing/RootPaneContainer.java ! src/java.desktop/share/classes/javax/swing/ScrollPaneLayout.java ! src/java.desktop/share/classes/javax/swing/SizeSequence.java ! src/java.desktop/share/classes/javax/swing/SwingUtilities.java ! src/java.desktop/share/classes/javax/swing/Timer.java ! src/java.desktop/share/classes/javax/swing/TransferHandler.java ! src/java.desktop/share/classes/javax/swing/colorchooser/AbstractColorChooserPanel.java ! src/java.desktop/share/classes/javax/swing/event/EventListenerList.java ! src/java.desktop/share/classes/javax/swing/plaf/TextUI.java ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicHTML.java ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextFieldUI.java ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextUI.java ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTransferable.java ! src/java.desktop/share/classes/javax/swing/table/AbstractTableModel.java ! src/java.desktop/share/classes/javax/swing/table/DefaultTableColumnModel.java ! src/java.desktop/share/classes/javax/swing/table/DefaultTableModel.java ! src/java.desktop/share/classes/javax/swing/table/JTableHeader.java ! src/java.desktop/share/classes/javax/swing/table/TableColumnModel.java ! src/java.desktop/share/classes/javax/swing/text/AbstractDocument.java ! src/java.desktop/share/classes/javax/swing/text/AbstractWriter.java ! src/java.desktop/share/classes/javax/swing/text/AsyncBoxView.java ! src/java.desktop/share/classes/javax/swing/text/BoxView.java ! src/java.desktop/share/classes/javax/swing/text/ComponentView.java ! src/java.desktop/share/classes/javax/swing/text/CompositeView.java ! src/java.desktop/share/classes/javax/swing/text/DefaultCaret.java ! src/java.desktop/share/classes/javax/swing/text/DefaultEditorKit.java ! src/java.desktop/share/classes/javax/swing/text/DefaultHighlighter.java ! src/java.desktop/share/classes/javax/swing/text/DefaultStyledDocument.java ! src/java.desktop/share/classes/javax/swing/text/Document.java ! src/java.desktop/share/classes/javax/swing/text/DocumentFilter.java ! src/java.desktop/share/classes/javax/swing/text/EditorKit.java ! src/java.desktop/share/classes/javax/swing/text/FieldView.java ! src/java.desktop/share/classes/javax/swing/text/GapContent.java ! src/java.desktop/share/classes/javax/swing/text/GlyphPainter2.java ! src/java.desktop/share/classes/javax/swing/text/GlyphView.java ! src/java.desktop/share/classes/javax/swing/text/Highlighter.java ! src/java.desktop/share/classes/javax/swing/text/IconView.java ! src/java.desktop/share/classes/javax/swing/text/JTextComponent.java ! src/java.desktop/share/classes/javax/swing/text/NavigationFilter.java ! src/java.desktop/share/classes/javax/swing/text/ParagraphView.java ! src/java.desktop/share/classes/javax/swing/text/PasswordView.java ! src/java.desktop/share/classes/javax/swing/text/PlainDocument.java ! src/java.desktop/share/classes/javax/swing/text/PlainView.java ! src/java.desktop/share/classes/javax/swing/text/StringContent.java ! src/java.desktop/share/classes/javax/swing/text/StyleContext.java ! src/java.desktop/share/classes/javax/swing/text/StyledEditorKit.java ! src/java.desktop/share/classes/javax/swing/text/TableView.java ! src/java.desktop/share/classes/javax/swing/text/Utilities.java ! src/java.desktop/share/classes/javax/swing/text/View.java ! src/java.desktop/share/classes/javax/swing/text/WrappedPlainView.java ! src/java.desktop/share/classes/javax/swing/text/ZoneView.java ! src/java.desktop/share/classes/javax/swing/text/html/AccessibleHTML.java ! src/java.desktop/share/classes/javax/swing/text/html/BlockView.java ! src/java.desktop/share/classes/javax/swing/text/html/FormView.java ! src/java.desktop/share/classes/javax/swing/text/html/HRuleView.java ! src/java.desktop/share/classes/javax/swing/text/html/HTMLDocument.java ! src/java.desktop/share/classes/javax/swing/text/html/HTMLEditorKit.java ! src/java.desktop/share/classes/javax/swing/text/html/HTMLWriter.java ! src/java.desktop/share/classes/javax/swing/text/html/ImageView.java ! src/java.desktop/share/classes/javax/swing/text/html/MinimalHTMLWriter.java ! src/java.desktop/share/classes/javax/swing/text/html/OptionListModel.java ! src/java.desktop/share/classes/javax/swing/text/html/StyleSheet.java ! src/java.desktop/share/classes/javax/swing/text/html/TableView.java ! src/java.desktop/share/classes/javax/swing/text/rtf/RTFEditorKit.java ! src/java.desktop/share/classes/javax/swing/tree/DefaultMutableTreeNode.java ! src/java.desktop/share/classes/javax/swing/tree/DefaultTreeModel.java ! src/java.desktop/share/classes/javax/swing/tree/DefaultTreeSelectionModel.java ! src/java.desktop/share/classes/javax/swing/undo/AbstractUndoableEdit.java Changeset: 249d5536 Author: Prasanta Sadhukhan Date: 2022-03-17 09:15:54 +0000 URL: https://git.openjdk.java.net/loom/commit/249d553659ab75a2271e98c77e7d62f662ffa684 8282602: Refactor awt classes javadoc to use @throws instead of @exception Reviewed-by: aivanov, prr ! src/java.desktop/share/classes/java/awt/AWTEventMulticaster.java ! src/java.desktop/share/classes/java/awt/BorderLayout.java ! src/java.desktop/share/classes/java/awt/BufferCapabilities.java ! src/java.desktop/share/classes/java/awt/Button.java ! src/java.desktop/share/classes/java/awt/Canvas.java ! src/java.desktop/share/classes/java/awt/CardLayout.java ! src/java.desktop/share/classes/java/awt/Checkbox.java ! src/java.desktop/share/classes/java/awt/CheckboxMenuItem.java ! src/java.desktop/share/classes/java/awt/Choice.java ! src/java.desktop/share/classes/java/awt/Color.java ! src/java.desktop/share/classes/java/awt/Component.java ! src/java.desktop/share/classes/java/awt/Container.java ! src/java.desktop/share/classes/java/awt/Cursor.java ! src/java.desktop/share/classes/java/awt/Dialog.java ! src/java.desktop/share/classes/java/awt/EventQueue.java ! src/java.desktop/share/classes/java/awt/FileDialog.java ! src/java.desktop/share/classes/java/awt/Frame.java ! src/java.desktop/share/classes/java/awt/GraphicsConfiguration.java ! src/java.desktop/share/classes/java/awt/GraphicsDevice.java ! src/java.desktop/share/classes/java/awt/GraphicsEnvironment.java ! src/java.desktop/share/classes/java/awt/GridBagLayout.java ! src/java.desktop/share/classes/java/awt/GridLayout.java ! src/java.desktop/share/classes/java/awt/Image.java ! src/java.desktop/share/classes/java/awt/Label.java ! src/java.desktop/share/classes/java/awt/List.java ! src/java.desktop/share/classes/java/awt/MediaTracker.java ! src/java.desktop/share/classes/java/awt/Menu.java ! src/java.desktop/share/classes/java/awt/MenuBar.java ! src/java.desktop/share/classes/java/awt/MenuComponent.java ! src/java.desktop/share/classes/java/awt/MenuItem.java ! src/java.desktop/share/classes/java/awt/MouseInfo.java ! src/java.desktop/share/classes/java/awt/Polygon.java ! src/java.desktop/share/classes/java/awt/PopupMenu.java ! src/java.desktop/share/classes/java/awt/RenderingHints.java ! src/java.desktop/share/classes/java/awt/Scrollbar.java ! src/java.desktop/share/classes/java/awt/TextArea.java ! src/java.desktop/share/classes/java/awt/TextComponent.java ! src/java.desktop/share/classes/java/awt/TextField.java ! src/java.desktop/share/classes/java/awt/Toolkit.java ! src/java.desktop/share/classes/java/awt/Window.java ! src/java.desktop/share/classes/java/awt/dnd/DragSource.java ! src/java.desktop/share/classes/java/awt/dnd/DropTarget.java ! src/java.desktop/share/classes/java/awt/event/InputMethodEvent.java ! src/java.desktop/share/classes/java/awt/font/TextLayout.java ! src/java.desktop/share/classes/java/awt/geom/AffineTransform.java ! src/java.desktop/share/classes/java/awt/geom/CubicCurve2D.java ! src/java.desktop/share/classes/java/awt/geom/Dimension2D.java ! src/java.desktop/share/classes/java/awt/geom/FlatteningPathIterator.java ! src/java.desktop/share/classes/java/awt/geom/Line2D.java ! src/java.desktop/share/classes/java/awt/geom/Path2D.java ! src/java.desktop/share/classes/java/awt/geom/Point2D.java ! src/java.desktop/share/classes/java/awt/geom/QuadCurve2D.java ! src/java.desktop/share/classes/java/awt/geom/RectangularShape.java ! src/java.desktop/share/classes/java/awt/im/InputContext.java ! src/java.desktop/share/classes/java/awt/im/InputMethodHighlight.java ! src/java.desktop/share/classes/java/awt/im/spi/InputMethod.java ! src/java.desktop/share/classes/java/awt/im/spi/InputMethodContext.java ! src/java.desktop/share/classes/java/awt/im/spi/InputMethodDescriptor.java ! src/java.desktop/share/classes/java/awt/image/BufferedImage.java ! src/java.desktop/share/classes/java/awt/image/ByteLookupTable.java ! src/java.desktop/share/classes/java/awt/image/ColorConvertOp.java ! src/java.desktop/share/classes/java/awt/image/DirectColorModel.java ! src/java.desktop/share/classes/java/awt/image/ImageFilter.java ! src/java.desktop/share/classes/java/awt/image/MultiPixelPackedSampleModel.java ! src/java.desktop/share/classes/java/awt/image/PixelGrabber.java ! src/java.desktop/share/classes/java/awt/image/RGBImageFilter.java ! src/java.desktop/share/classes/java/awt/image/Raster.java ! src/java.desktop/share/classes/java/awt/image/ShortLookupTable.java ! src/java.desktop/share/classes/java/awt/image/SinglePixelPackedSampleModel.java ! src/java.desktop/share/classes/java/awt/image/WritableRaster.java ! src/java.desktop/share/classes/java/awt/print/PageFormat.java ! src/java.desktop/share/classes/java/awt/print/Printable.java ! src/java.desktop/share/classes/java/awt/print/PrinterJob.java Changeset: beedae11 Author: Claes Redestad Date: 2022-03-17 09:20:24 +0000 URL: https://git.openjdk.java.net/loom/commit/beedae1141b6b650dc4cedf1f038afc1c8b460dd 8281146: Replace StringCoding.hasNegatives with countPositives Co-authored-by: Lutz Schmidt Co-authored-by: Martin Doerr Reviewed-by: kvn, lucy, rriggs ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/cpu/aarch64/stubRoutines_aarch64.cpp ! src/hotspot/cpu/aarch64/stubRoutines_aarch64.hpp ! src/hotspot/cpu/ppc/c2_MacroAssembler_ppc.cpp ! src/hotspot/cpu/ppc/c2_MacroAssembler_ppc.hpp ! src/hotspot/cpu/ppc/ppc.ad ! src/hotspot/cpu/s390/c2_MacroAssembler_s390.cpp ! src/hotspot/cpu/s390/c2_MacroAssembler_s390.hpp ! src/hotspot/cpu/s390/s390.ad ! src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp ! src/hotspot/cpu/x86/c2_MacroAssembler_x86.hpp ! src/hotspot/cpu/x86/x86_32.ad ! src/hotspot/cpu/x86/x86_64.ad ! src/hotspot/share/adlc/formssel.cpp ! src/hotspot/share/classfile/vmIntrinsics.cpp ! src/hotspot/share/classfile/vmIntrinsics.hpp ! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp ! src/hotspot/share/jvmci/vmStructs_jvmci.cpp ! src/hotspot/share/opto/c2compiler.cpp ! src/hotspot/share/opto/classes.hpp ! src/hotspot/share/opto/escape.cpp ! src/hotspot/share/opto/intrinsicnode.hpp ! src/hotspot/share/opto/lcm.cpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/opto/library_call.hpp ! src/hotspot/share/opto/loopTransform.cpp ! src/hotspot/share/opto/loopnode.cpp ! src/hotspot/share/opto/matcher.cpp ! src/java.base/share/classes/java/lang/String.java ! src/java.base/share/classes/java/lang/StringCoding.java + test/hotspot/jtreg/compiler/intrinsics/string/TestCountPositives.java ! test/hotspot/jtreg/compiler/patches/java.base/java/lang/Helper.java ! test/micro/org/openjdk/bench/java/lang/StringDecode.java Changeset: bad658e8 Author: Albert Mingkun Yang Date: 2022-03-17 09:47:51 +0000 URL: https://git.openjdk.java.net/loom/commit/bad658e8e93c831631d41b6dbf66a0a102cd0462 8282727: Parallel: Remove PSPromotionManager::_totally_drain Reviewed-by: tschatzl, kbarrett ! src/hotspot/share/gc/parallel/psPromotionManager.cpp ! src/hotspot/share/gc/parallel/psPromotionManager.hpp Changeset: 69e4e338 Author: Doug Simon Date: 2022-03-17 12:51:10 +0000 URL: https://git.openjdk.java.net/loom/commit/69e4e338b19c0ffd2f0881be1bbb19a5642bc4d4 8283056: show abstract machine code in hs-err for all VM crashes Reviewed-by: thartmann, dholmes ! src/hotspot/share/utilities/vmError.cpp Changeset: 0f1766df Author: Julian Waters Committer: Magnus Ihse Bursie Date: 2022-03-17 15:30:17 +0000 URL: https://git.openjdk.java.net/loom/commit/0f1766dff633e55532d94069d7266a7fe625286c 8283320: Error message for Windows libraries always points to --with-msvcr-dll no matter the actual file name Reviewed-by: erikj, ihse ! make/autoconf/toolchain_microsoft.m4 Changeset: 31df6a60 Author: Albert Mingkun Yang Date: 2022-03-17 16:17:18 +0000 URL: https://git.openjdk.java.net/loom/commit/31df6a60a8853be224d8c8b8c8ca6aea1bae2167 8283188: Build time regression caused by JDK-8278917 Reviewed-by: kbarrett, tschatzl ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp Changeset: 5ef1990d Author: Joe Darcy Date: 2022-03-17 16:37:20 +0000 URL: https://git.openjdk.java.net/loom/commit/5ef1990d6ce35a85c86689badba465b6c8f9f4a1 8283274: Improve @jvms usage in java.base Reviewed-by: iris ! src/java.base/share/classes/java/lang/constant/ClassDesc.java ! src/java.base/share/classes/java/lang/constant/Constable.java ! src/java.base/share/classes/java/lang/constant/ConstantDesc.java ! src/java.base/share/classes/java/lang/constant/package-info.java ! src/java.base/share/classes/java/lang/invoke/ConstantBootstraps.java ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java Changeset: b004fb05 Author: Ioi Lam Date: 2022-03-17 17:50:20 +0000 URL: https://git.openjdk.java.net/loom/commit/b004fb0550d8fc94e3f6412975c23c0a2ac2a42f 8282773: Refactor parsing of integer VM options Reviewed-by: dholmes, kbarrett ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/flags/debug_globals.hpp ! test/hotspot/gtest/runtime/test_arguments.cpp - test/hotspot/gtest/runtime/test_largeOptions.cpp Changeset: 002e3667 Author: Claes Redestad Date: 2022-03-17 21:15:36 +0000 URL: https://git.openjdk.java.net/loom/commit/002e3667443d94e2303c875daf72cf1ccbbb0099 8283325: US_ASCII decoder relies on String.decodeASCII being exhaustive Reviewed-by: rriggs, dcubed ! src/java.base/share/classes/java/lang/String.java + test/jdk/java/nio/charset/CharsetDecoder/ASCIIDecode.java Changeset: d83cee98 Author: Alexander Matveev Date: 2022-03-18 03:14:32 +0000 URL: https://git.openjdk.java.net/loom/commit/d83cee98b5e6628f19f1b5dea11038079dd0c758 8282407: Missing ')' in MacResources.properties Reviewed-by: naoto ! src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/MacResources.properties ! src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/MacResources_ja.properties ! src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/MacResources_zh_CN.properties Changeset: cab4ff64 Author: Tyler Steele Committer: Thomas Stuefe Date: 2022-03-18 07:02:26 +0000 URL: https://git.openjdk.java.net/loom/commit/cab4ff64541393a974ea91e35167668ef0036804 8283225: ClassLoader.c produces incorrect OutOfMemory Exception when length is 0 (aix) Reviewed-by: stuefe, rriggs, dholmes ! src/java.base/share/native/libjava/ClassLoader.c Changeset: b96cb048 Author: Jie Fu Date: 2022-03-18 07:58:58 +0000 URL: https://git.openjdk.java.net/loom/commit/b96cb048f1a7f3ae6e745b245f2b04c64ebb911e 8283353: compiler/c2/cr6865031/Test.java and compiler/runtime/Test6826736.java fails on x86_32 Reviewed-by: chagedorn ! test/hotspot/jtreg/compiler/c2/cr6865031/Test.java ! test/hotspot/jtreg/compiler/runtime/Test6826736.java Changeset: 4b5079b9 Author: Erik Gahlin Date: 2022-03-18 13:18:38 +0000 URL: https://git.openjdk.java.net/loom/commit/4b5079b9836c1cc881f571d060b310f58c8a860c 8283202: Potential off-read when checking JFR's status in awaitFinished Reviewed-by: mgronlun ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/ChunkHeader.java Changeset: c72bcfc1 Author: Erik Gahlin Date: 2022-03-18 13:27:49 +0000 URL: https://git.openjdk.java.net/loom/commit/c72bcfc1b230d22137ac7f683cf46dc70b6e3d16 8283289: JFR: Rename CheckPoint Reviewed-by: mgronlun ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/ChunkParser.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/filter/CheckPointEvent.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/filter/CheckPointPool.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/filter/ChunkWriter.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/tool/Summary.java ! src/jdk.management.jfr/share/classes/jdk/management/jfr/DiskRepository.java Changeset: 85cc6f14 Author: Andrew Leonard Date: 2022-03-18 13:40:35 +0000 URL: https://git.openjdk.java.net/loom/commit/85cc6f1440aa7e073cab894cb9a72d9eed4e8369 8283315: jrt-fs.jar not always deterministically built Reviewed-by: ihse ! make/common/JarArchive.gmk Changeset: b2aa085e Author: Erik Gahlin Date: 2022-03-18 14:54:56 +0000 URL: https://git.openjdk.java.net/loom/commit/b2aa085e67711a32e1679b68aabb092058dca044 8283378: JFR: Checkpoint classes not renamed properly Reviewed-by: dcubed = src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/filter/CheckpointEvent.java = src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/filter/CheckpointPool.java Changeset: ff0b0927 Author: Ravi Reddy Committer: Lance Andersen Date: 2022-03-18 15:31:30 +0000 URL: https://git.openjdk.java.net/loom/commit/ff0b0927a2df8b36f8fd6ed41bd4e20e71a5b653 8278794: Infinite loop in DeflaterOutputStream.finish() Reviewed-by: coffeys, lancea ! src/java.base/share/classes/java/util/zip/Deflater.java ! src/java.base/share/classes/java/util/zip/DeflaterOutputStream.java ! src/java.base/share/classes/java/util/zip/ZipOutputStream.java - test/jdk/java/util/zip/CloseDeflaterTest.java + test/jdk/java/util/zip/CloseInflaterDeflaterTest.java Changeset: d8893fad Author: Mikael Vidstedt Date: 2022-03-18 20:28:39 +0000 URL: https://git.openjdk.java.net/loom/commit/d8893fad23d1ee6841336b96c34599643edb81ce 8283059: Uninitialized warning in check_code.c with GCC 11.2 Reviewed-by: dholmes ! src/java.base/share/native/libverify/check_code.c Changeset: 8384ac4e Author: Mikael Vidstedt Date: 2022-03-18 22:01:27 +0000 URL: https://git.openjdk.java.net/loom/commit/8384ac4ed3eaaa18998ab88e1ca36358c212e699 8283057: Update GCC to version 11.2 for Oracle builds on Linux Reviewed-by: erikj ! doc/building.html ! doc/building.md ! make/conf/jib-profiles.js ! make/devkit/Tools.gmk Changeset: 0c3094c8 Author: Ichiroh Takiguchi Date: 2022-03-19 04:43:20 +0000 URL: https://git.openjdk.java.net/loom/commit/0c3094c8186b4d53e8bad80e2369fc7b9ae9e201 8204541: Correctly support AIX xlC 16.1 symbol visibility flags Reviewed-by: ihse, stuefe ! make/autoconf/flags-ldflags.m4 ! make/common/modules/LauncherCommon.gmk ! make/common/modules/LibCommon.gmk Changeset: 3e58a438 Author: Tyler Steele Committer: Thomas Stuefe Date: 2022-03-19 07:06:47 +0000 URL: https://git.openjdk.java.net/loom/commit/3e58a438e9051d4c976273eea35e36d37d5428c3 8283287: ClassLoader.c cleanups Reviewed-by: stuefe, alanb, rriggs ! src/java.base/share/native/libjava/ClassLoader.c Changeset: 10ccfffa Author: Jie Fu Date: 2022-03-19 07:08:47 +0000 URL: https://git.openjdk.java.net/loom/commit/10ccfffae1f18dd1a3d2f3dca53ad547d3d3ecb5 8283352: [CDS] SharedBaseAddress.java fails on x86_32 Reviewed-by: dholmes, iklam, stuefe ! test/hotspot/jtreg/runtime/cds/SharedBaseAddress.java ! test/hotspot/jtreg/runtime/cds/appcds/SharedBaseAddress.java Changeset: e8caf84f Author: Andrey Turbanov Date: 2022-03-19 13:29:49 +0000 URL: https://git.openjdk.java.net/loom/commit/e8caf84fb9dfcbb59da6459972724b6780b0871a 8282574: Cleanup unnecessary calls to Throwable.initCause() in jdk.compiler Reviewed-by: darcy ! src/jdk.compiler/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/Pretty.java Changeset: 80415e04 Author: Andrey Turbanov Date: 2022-03-19 13:31:50 +0000 URL: https://git.openjdk.java.net/loom/commit/80415e04c5fd6709e7e5b5ffb7a3d9431b672d99 8282534: Remove redundant null check in ChaCha20Cipher.engineInit Reviewed-by: xuelei ! src/java.base/share/classes/com/sun/crypto/provider/ChaCha20Cipher.java Changeset: 3f923b82 Author: Daniel D. Daugherty Date: 2022-03-19 13:43:06 +0000 URL: https://git.openjdk.java.net/loom/commit/3f923b82c31325504430b50dee262fd460004e7b 8282704: runtime/Thread/StopAtExit.java may leak memory Reviewed-by: dholmes, alanb ! test/hotspot/jtreg/runtime/Thread/StopAtExit.java Changeset: 4df67426 Author: Xue-Lei Andrew Fan Date: 2022-03-20 06:46:13 +0000 URL: https://git.openjdk.java.net/loom/commit/4df67426ed02f18af0757897acb28b636a317a91 8282723: Add constructors taking a cause to JSSE exceptions Reviewed-by: wetmore, iris ! src/java.base/share/classes/javax/net/ssl/SSLException.java ! src/java.base/share/classes/javax/net/ssl/SSLHandshakeException.java ! src/java.base/share/classes/javax/net/ssl/SSLKeyException.java ! src/java.base/share/classes/javax/net/ssl/SSLPeerUnverifiedException.java ! src/java.base/share/classes/javax/net/ssl/SSLProtocolException.java ! src/java.base/share/classes/sun/security/ssl/Alert.java ! src/java.base/share/classes/sun/security/ssl/DHClientKeyExchange.java ! src/java.base/share/classes/sun/security/ssl/ECDHKeyExchange.java ! src/java.base/share/classes/sun/security/ssl/KAKeyDerivation.java ! src/java.base/share/classes/sun/security/ssl/NewSessionTicket.java ! src/java.base/share/classes/sun/security/ssl/SSLBasicKeyDerivation.java ! src/java.base/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/java.base/share/classes/sun/security/ssl/SSLEngineInputRecord.java ! src/java.base/share/classes/sun/security/ssl/SSLSecretDerivation.java ! src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java ! src/java.base/share/classes/sun/security/ssl/SSLSocketInputRecord.java ! src/java.base/share/classes/sun/security/ssl/SSLTrafficKeyDerivation.java ! src/java.base/share/classes/sun/security/ssl/ServerHello.java ! src/java.base/share/classes/sun/security/ssl/ServerNameExtension.java ! src/java.naming/share/classes/com/sun/jndi/ldap/ext/StartTlsResponseImpl.java ! src/java.net.http/share/classes/jdk/internal/net/http/HttpClientImpl.java ! src/java.net.http/share/classes/jdk/internal/net/http/common/SSLTube.java ! test/jdk/javax/net/ssl/ALPN/SSLServerSocketAlpnTest.java ! test/jdk/javax/net/ssl/ALPN/SSLSocketAlpnTest.java + test/jdk/javax/net/ssl/SSLException/CheckSSLHandshakeException.java + test/jdk/javax/net/ssl/SSLException/CheckSSLKeyException.java + test/jdk/javax/net/ssl/SSLException/CheckSSLPeerUnverifiedException.java + test/jdk/javax/net/ssl/SSLException/CheckSSLProtocolException.java ! test/jdk/javax/net/ssl/templates/SSLSocketSSLEngineTemplate.java ! test/jdk/javax/net/ssl/templates/SSLSocketTemplate.java Changeset: 8a2d5ab0 Author: Maxim Kartashev Committer: Alexey Ivanov Date: 2022-03-21 07:21:00 +0000 URL: https://git.openjdk.java.net/loom/commit/8a2d5ab07e6a1668f3e3918bdc8a30bd28a8f93b 8282270: java/awt/Robot Screen Capture tests fail after 8280861 Reviewed-by: aivanov ! test/jdk/ProblemList.txt ! test/jdk/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java ! test/jdk/java/awt/Robot/HiDPIScreenCapture/ScreenCaptureGtkTest.java Changeset: b451273d Author: Manukumar V S Committer: Alexey Ivanov Date: 2022-03-21 07:33:20 +0000 URL: https://git.openjdk.java.net/loom/commit/b451273d209d9dfce3d7c4464defe0df523dfc7c 8282548: Create a regression test for JDK-4330998 Reviewed-by: aivanov + test/jdk/javax/swing/JEditorPane/4330998/JEditorPaneSetTextNullTest.java Changeset: 83a1c904 Author: Manukumar V S Committer: Alexey Ivanov Date: 2022-03-21 07:36:21 +0000 URL: https://git.openjdk.java.net/loom/commit/83a1c90433343107eaa2a7fa41b9b07f86b6ce19 8282789: Create a regression test for the JTree usecase of JDK-4618767 Reviewed-by: aivanov + test/jdk/javax/swing/JTree/4618767/JTreeSelectedElementTest.java Changeset: e709cb05 Author: Thomas Schatzl Date: 2022-03-21 08:25:33 +0000 URL: https://git.openjdk.java.net/loom/commit/e709cb05dcf67462f266c1f3dae30976b562676d 8283186: Explicitly pass a third temp register to MacroAssembler::store_heap_oop Reviewed-by: eosterlund ! src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.hpp ! src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.hpp ! src/hotspot/cpu/x86/gc/shared/cardTableBarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/shared/cardTableBarrierSetAssembler_x86.hpp ! src/hotspot/cpu/x86/gc/shared/modRefBarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/shared/modRefBarrierSetAssembler_x86.hpp ! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp ! src/hotspot/cpu/x86/gc/z/zBarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/z/zBarrierSetAssembler_x86.hpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/cpu/x86/templateTable_x86.cpp Changeset: ec62d90d Author: Albert Mingkun Yang Date: 2022-03-21 08:39:17 +0000 URL: https://git.openjdk.java.net/loom/commit/ec62d90db2428d0da6ed0f338858f5bc2a76e991 8283365: G1: Remove duplicate assertions in HeapRegion::oops_on_memregion_seq_iterate_careful Reviewed-by: kbarrett, tschatzl ! src/hotspot/share/gc/g1/heapRegion.inline.hpp Changeset: fd930151 Author: Albert Mingkun Yang Date: 2022-03-21 08:40:14 +0000 URL: https://git.openjdk.java.net/loom/commit/fd9301514e2093d9dcd7bcd9e4b812146b20dd03 8283332: G1: Stricter assertion in G1BlockOffsetTablePart::forward_to_block_containing_addr Reviewed-by: kbarrett, iwalulya ! src/hotspot/share/gc/g1/g1BlockOffsetTable.inline.hpp Changeset: eb4849e5 Author: Thomas Schatzl Date: 2022-03-21 10:42:38 +0000 URL: https://git.openjdk.java.net/loom/commit/eb4849e5615dd307a5abc435a0204a6d26610fcb 8283327: Add methods to save/restore registers when calling into the VM from C1/interpreter barrier code Reviewed-by: eosterlund, dlong ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/register_aarch64.hpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/register_x86.hpp ! src/hotspot/share/asm/register.hpp Changeset: ed5ed753 Author: Ron Pressler Date: 2022-03-21 11:14:56 +0000 URL: https://git.openjdk.java.net/loom/commit/ed5ed753df28e24c05f0ea6df1d09db2bad21aaf Merge branch 'master' into fibers ! make/autoconf/toolchain.m4 ! make/conf/jib-profiles.js ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/cpu/x86/templateTable_x86.cpp ! src/hotspot/cpu/x86/x86_32.ad ! src/hotspot/cpu/x86/x86_64.ad ! src/hotspot/share/classfile/vmIntrinsics.cpp ! src/hotspot/share/classfile/vmIntrinsics.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp ! src/hotspot/share/gc/parallel/psPromotionManager.cpp ! src/hotspot/share/jvmci/vmStructs_jvmci.cpp ! src/hotspot/share/opto/c2compiler.cpp ! src/hotspot/share/opto/intrinsicnode.hpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/opto/library_call.hpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/utilities/vmError.cpp ! test/jdk/ProblemList.txt ! make/autoconf/toolchain.m4 ! make/conf/jib-profiles.js ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/cpu/x86/templateTable_x86.cpp ! src/hotspot/cpu/x86/x86_32.ad ! src/hotspot/cpu/x86/x86_64.ad ! src/hotspot/share/classfile/vmIntrinsics.cpp ! src/hotspot/share/classfile/vmIntrinsics.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp ! src/hotspot/share/gc/parallel/psPromotionManager.cpp ! src/hotspot/share/jvmci/vmStructs_jvmci.cpp ! src/hotspot/share/opto/c2compiler.cpp ! src/hotspot/share/opto/intrinsicnode.hpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/opto/library_call.hpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/utilities/vmError.cpp ! test/jdk/ProblemList.txt Changeset: 2cabb98b Author: Ron Pressler Date: 2022-03-21 12:34:43 +0000 URL: https://git.openjdk.java.net/loom/commit/2cabb98b2cce2fc4a7ec6978622216c62de61a2f Merge remote-tracking branch 'origin/fibers' into fibers Changeset: 90ef2e2b Author: Ron Pressler Date: 2022-03-21 18:38:54 +0000 URL: https://git.openjdk.java.net/loom/commit/90ef2e2be0fe1e6bae30857741c1a6789c284bba Fig g1BarrierSetAssembler to push_call_clobbered_registers/pop_call_clobbered_registers. ! src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.cpp Changeset: 838a02e1 Author: Ron Pressler Date: 2022-03-21 18:39:16 +0000 URL: https://git.openjdk.java.net/loom/commit/838a02e1538ee536dc383def869b2eba146b77ea Add comment ! src/hotspot/share/oops/instanceStackChunkKlass.cpp Changeset: e64550c9 Author: Ron Pressler Date: 2022-03-21 18:39:28 +0000 URL: https://git.openjdk.java.net/loom/commit/e64550c958ecff78fb841b7af4bed69542e4d619 Improve assertions ! src/hotspot/share/runtime/stackChunkFrameStream.inline.hpp Changeset: 54b4c2e1 Author: Ron Pressler Date: 2022-03-21 18:44:05 +0000 URL: https://git.openjdk.java.net/loom/commit/54b4c2e1118de3d616e51edc94ca2e3c88981154 Fix G1 nmethod marking (8283425) ! src/hotspot/share/gc/g1/g1CodeBlobClosure.cpp Changeset: 88ede02e Author: Ron Pressler Date: 2022-03-21 18:45:40 +0000 URL: https://git.openjdk.java.net/loom/commit/88ede02ed07830665b3b949959e2c2d1a1ccb2d4 Merge remote-tracking branch 'origin/fibers' into fibers From duke at openjdk.java.net Mon Mar 21 19:01:39 2022 From: duke at openjdk.java.net (duke) Date: Mon, 21 Mar 2022 19:01:39 GMT Subject: git: openjdk/loom: fibers: cleanup jfrThreadName::name Message-ID: <5e5e8e13-8856-41a2-acdd-180d11086b74@openjdk.java.net> Changeset: 43062348 Author: mgronlun Date: 2022-03-21 19:59:53 +0000 URL: https://git.openjdk.java.net/loom/commit/430623484ec8470458499cb645e752e34b04a8b8 cleanup jfrThreadName::name ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrThreadState.cpp From duke at openjdk.java.net Mon Mar 21 19:05:55 2022 From: duke at openjdk.java.net (duke) Date: Mon, 21 Mar 2022 19:05:55 GMT Subject: git: openjdk/loom: master: 39 new changesets Message-ID: Changeset: 9b8afce3 Author: Magnus Ihse Bursie Date: 2022-03-16 16:07:32 +0000 URL: https://git.openjdk.java.net/loom/commit/9b8afce3791080d664c5051a86592706f5b0ade0 8283260: gcc is not supported on mac Reviewed-by: erikj ! make/autoconf/flags-ldflags.m4 ! make/autoconf/toolchain.m4 Changeset: 0cf291bc Author: Joe Darcy Date: 2022-03-16 16:17:50 +0000 URL: https://git.openjdk.java.net/loom/commit/0cf291bc31acf69c767c5d39d21b1195e6d761b2 8283234: Improve @jls usage in java.base Reviewed-by: iris ! src/java.base/share/classes/java/lang/StringConcatHelper.java ! src/java.base/share/classes/java/lang/invoke/MethodHandle.java ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java ! src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java ! src/java.base/share/classes/java/lang/reflect/TypeVariable.java Changeset: 3e393047 Author: XenoAmess Committer: Stuart Marks Date: 2022-03-16 16:48:49 +0000 URL: https://git.openjdk.java.net/loom/commit/3e393047e12147a81e2899784b943923fc34da8e 8281631: HashMap copy constructor and putAll can over-allocate table Reviewed-by: smarks ! src/java.base/share/classes/java/util/HashMap.java ! src/java.base/share/classes/java/util/WeakHashMap.java ! test/jdk/ProblemList.txt ! test/jdk/java/util/HashMap/WhiteBoxResizeTest.java Changeset: 3da5204b Author: Jie Fu Date: 2022-03-17 00:05:57 +0000 URL: https://git.openjdk.java.net/loom/commit/3da5204b3c3a3f95bddcdcfe2628c2e0ed8a12d9 8283229: compiler/arguments/TestCodeEntryAlignment.java fails with release VMs Reviewed-by: dlong ! test/hotspot/jtreg/compiler/arguments/TestCodeEntryAlignment.java Changeset: a5ebcc0c Author: Ivan Walulya Date: 2022-03-17 08:54:29 +0000 URL: https://git.openjdk.java.net/loom/commit/a5ebcc0c04bedd87bc9a523b0a45b50fc4b0f5f0 8282072: G1: Rename CardSetPtr to CardSetContainerPtr Reviewed-by: ayang, tschatzl ! src/hotspot/share/gc/g1/g1CardSet.cpp ! src/hotspot/share/gc/g1/g1CardSet.hpp ! src/hotspot/share/gc/g1/g1CardSet.inline.hpp ! src/hotspot/share/gc/g1/g1CardSetContainers.hpp ! src/hotspot/share/gc/g1/g1CardSetContainers.inline.hpp ! src/hotspot/share/gc/g1/heapRegionRemSet.inline.hpp ! test/hotspot/gtest/gc/g1/test_g1CardSet.cpp ! test/hotspot/gtest/gc/g1/test_g1CardSetContainers.cpp Changeset: 096bca4a Author: Prasanta Sadhukhan Date: 2022-03-17 09:10:08 +0000 URL: https://git.openjdk.java.net/loom/commit/096bca4a9c5e8ac2668dd965df92153ea1d80add 8282473: Refactor swing classes javadoc to use @throws instead of @exception Reviewed-by: aivanov, dmarkov, prr ! src/java.desktop/share/classes/javax/swing/AbstractButton.java ! src/java.desktop/share/classes/javax/swing/AbstractListModel.java ! src/java.desktop/share/classes/javax/swing/BorderFactory.java ! src/java.desktop/share/classes/javax/swing/BoxLayout.java ! src/java.desktop/share/classes/javax/swing/DefaultBoundedRangeModel.java ! src/java.desktop/share/classes/javax/swing/DefaultButtonModel.java ! src/java.desktop/share/classes/javax/swing/DefaultListModel.java ! src/java.desktop/share/classes/javax/swing/DefaultListSelectionModel.java ! src/java.desktop/share/classes/javax/swing/DefaultSingleSelectionModel.java ! src/java.desktop/share/classes/javax/swing/JApplet.java ! src/java.desktop/share/classes/javax/swing/JColorChooser.java ! src/java.desktop/share/classes/javax/swing/JComboBox.java ! src/java.desktop/share/classes/javax/swing/JComponent.java ! src/java.desktop/share/classes/javax/swing/JEditorPane.java ! src/java.desktop/share/classes/javax/swing/JFileChooser.java ! src/java.desktop/share/classes/javax/swing/JFrame.java ! src/java.desktop/share/classes/javax/swing/JInternalFrame.java ! src/java.desktop/share/classes/javax/swing/JLabel.java ! src/java.desktop/share/classes/javax/swing/JLayer.java ! src/java.desktop/share/classes/javax/swing/JList.java ! src/java.desktop/share/classes/javax/swing/JMenu.java ! src/java.desktop/share/classes/javax/swing/JOptionPane.java ! src/java.desktop/share/classes/javax/swing/JPasswordField.java ! src/java.desktop/share/classes/javax/swing/JPopupMenu.java ! src/java.desktop/share/classes/javax/swing/JProgressBar.java ! src/java.desktop/share/classes/javax/swing/JRootPane.java ! src/java.desktop/share/classes/javax/swing/JScrollBar.java ! src/java.desktop/share/classes/javax/swing/JScrollPane.java ! src/java.desktop/share/classes/javax/swing/JSeparator.java ! src/java.desktop/share/classes/javax/swing/JSlider.java ! src/java.desktop/share/classes/javax/swing/JSpinner.java ! src/java.desktop/share/classes/javax/swing/JSplitPane.java ! src/java.desktop/share/classes/javax/swing/JTabbedPane.java ! src/java.desktop/share/classes/javax/swing/JTable.java ! src/java.desktop/share/classes/javax/swing/JTextArea.java ! src/java.desktop/share/classes/javax/swing/JTextField.java ! src/java.desktop/share/classes/javax/swing/JTextPane.java ! src/java.desktop/share/classes/javax/swing/JToolBar.java ! src/java.desktop/share/classes/javax/swing/JTree.java ! src/java.desktop/share/classes/javax/swing/JViewport.java ! src/java.desktop/share/classes/javax/swing/JWindow.java ! src/java.desktop/share/classes/javax/swing/OverlayLayout.java ! src/java.desktop/share/classes/javax/swing/Popup.java ! src/java.desktop/share/classes/javax/swing/PopupFactory.java ! src/java.desktop/share/classes/javax/swing/ProgressMonitor.java ! src/java.desktop/share/classes/javax/swing/RootPaneContainer.java ! src/java.desktop/share/classes/javax/swing/ScrollPaneLayout.java ! src/java.desktop/share/classes/javax/swing/SizeSequence.java ! src/java.desktop/share/classes/javax/swing/SwingUtilities.java ! src/java.desktop/share/classes/javax/swing/Timer.java ! src/java.desktop/share/classes/javax/swing/TransferHandler.java ! src/java.desktop/share/classes/javax/swing/colorchooser/AbstractColorChooserPanel.java ! src/java.desktop/share/classes/javax/swing/event/EventListenerList.java ! src/java.desktop/share/classes/javax/swing/plaf/TextUI.java ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicHTML.java ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextFieldUI.java ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextUI.java ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTransferable.java ! src/java.desktop/share/classes/javax/swing/table/AbstractTableModel.java ! src/java.desktop/share/classes/javax/swing/table/DefaultTableColumnModel.java ! src/java.desktop/share/classes/javax/swing/table/DefaultTableModel.java ! src/java.desktop/share/classes/javax/swing/table/JTableHeader.java ! src/java.desktop/share/classes/javax/swing/table/TableColumnModel.java ! src/java.desktop/share/classes/javax/swing/text/AbstractDocument.java ! src/java.desktop/share/classes/javax/swing/text/AbstractWriter.java ! src/java.desktop/share/classes/javax/swing/text/AsyncBoxView.java ! src/java.desktop/share/classes/javax/swing/text/BoxView.java ! src/java.desktop/share/classes/javax/swing/text/ComponentView.java ! src/java.desktop/share/classes/javax/swing/text/CompositeView.java ! src/java.desktop/share/classes/javax/swing/text/DefaultCaret.java ! src/java.desktop/share/classes/javax/swing/text/DefaultEditorKit.java ! src/java.desktop/share/classes/javax/swing/text/DefaultHighlighter.java ! src/java.desktop/share/classes/javax/swing/text/DefaultStyledDocument.java ! src/java.desktop/share/classes/javax/swing/text/Document.java ! src/java.desktop/share/classes/javax/swing/text/DocumentFilter.java ! src/java.desktop/share/classes/javax/swing/text/EditorKit.java ! src/java.desktop/share/classes/javax/swing/text/FieldView.java ! src/java.desktop/share/classes/javax/swing/text/GapContent.java ! src/java.desktop/share/classes/javax/swing/text/GlyphPainter2.java ! src/java.desktop/share/classes/javax/swing/text/GlyphView.java ! src/java.desktop/share/classes/javax/swing/text/Highlighter.java ! src/java.desktop/share/classes/javax/swing/text/IconView.java ! src/java.desktop/share/classes/javax/swing/text/JTextComponent.java ! src/java.desktop/share/classes/javax/swing/text/NavigationFilter.java ! src/java.desktop/share/classes/javax/swing/text/ParagraphView.java ! src/java.desktop/share/classes/javax/swing/text/PasswordView.java ! src/java.desktop/share/classes/javax/swing/text/PlainDocument.java ! src/java.desktop/share/classes/javax/swing/text/PlainView.java ! src/java.desktop/share/classes/javax/swing/text/StringContent.java ! src/java.desktop/share/classes/javax/swing/text/StyleContext.java ! src/java.desktop/share/classes/javax/swing/text/StyledEditorKit.java ! src/java.desktop/share/classes/javax/swing/text/TableView.java ! src/java.desktop/share/classes/javax/swing/text/Utilities.java ! src/java.desktop/share/classes/javax/swing/text/View.java ! src/java.desktop/share/classes/javax/swing/text/WrappedPlainView.java ! src/java.desktop/share/classes/javax/swing/text/ZoneView.java ! src/java.desktop/share/classes/javax/swing/text/html/AccessibleHTML.java ! src/java.desktop/share/classes/javax/swing/text/html/BlockView.java ! src/java.desktop/share/classes/javax/swing/text/html/FormView.java ! src/java.desktop/share/classes/javax/swing/text/html/HRuleView.java ! src/java.desktop/share/classes/javax/swing/text/html/HTMLDocument.java ! src/java.desktop/share/classes/javax/swing/text/html/HTMLEditorKit.java ! src/java.desktop/share/classes/javax/swing/text/html/HTMLWriter.java ! src/java.desktop/share/classes/javax/swing/text/html/ImageView.java ! src/java.desktop/share/classes/javax/swing/text/html/MinimalHTMLWriter.java ! src/java.desktop/share/classes/javax/swing/text/html/OptionListModel.java ! src/java.desktop/share/classes/javax/swing/text/html/StyleSheet.java ! src/java.desktop/share/classes/javax/swing/text/html/TableView.java ! src/java.desktop/share/classes/javax/swing/text/rtf/RTFEditorKit.java ! src/java.desktop/share/classes/javax/swing/tree/DefaultMutableTreeNode.java ! src/java.desktop/share/classes/javax/swing/tree/DefaultTreeModel.java ! src/java.desktop/share/classes/javax/swing/tree/DefaultTreeSelectionModel.java ! src/java.desktop/share/classes/javax/swing/undo/AbstractUndoableEdit.java Changeset: 249d5536 Author: Prasanta Sadhukhan Date: 2022-03-17 09:15:54 +0000 URL: https://git.openjdk.java.net/loom/commit/249d553659ab75a2271e98c77e7d62f662ffa684 8282602: Refactor awt classes javadoc to use @throws instead of @exception Reviewed-by: aivanov, prr ! src/java.desktop/share/classes/java/awt/AWTEventMulticaster.java ! src/java.desktop/share/classes/java/awt/BorderLayout.java ! src/java.desktop/share/classes/java/awt/BufferCapabilities.java ! src/java.desktop/share/classes/java/awt/Button.java ! src/java.desktop/share/classes/java/awt/Canvas.java ! src/java.desktop/share/classes/java/awt/CardLayout.java ! src/java.desktop/share/classes/java/awt/Checkbox.java ! src/java.desktop/share/classes/java/awt/CheckboxMenuItem.java ! src/java.desktop/share/classes/java/awt/Choice.java ! src/java.desktop/share/classes/java/awt/Color.java ! src/java.desktop/share/classes/java/awt/Component.java ! src/java.desktop/share/classes/java/awt/Container.java ! src/java.desktop/share/classes/java/awt/Cursor.java ! src/java.desktop/share/classes/java/awt/Dialog.java ! src/java.desktop/share/classes/java/awt/EventQueue.java ! src/java.desktop/share/classes/java/awt/FileDialog.java ! src/java.desktop/share/classes/java/awt/Frame.java ! src/java.desktop/share/classes/java/awt/GraphicsConfiguration.java ! src/java.desktop/share/classes/java/awt/GraphicsDevice.java ! src/java.desktop/share/classes/java/awt/GraphicsEnvironment.java ! src/java.desktop/share/classes/java/awt/GridBagLayout.java ! src/java.desktop/share/classes/java/awt/GridLayout.java ! src/java.desktop/share/classes/java/awt/Image.java ! src/java.desktop/share/classes/java/awt/Label.java ! src/java.desktop/share/classes/java/awt/List.java ! src/java.desktop/share/classes/java/awt/MediaTracker.java ! src/java.desktop/share/classes/java/awt/Menu.java ! src/java.desktop/share/classes/java/awt/MenuBar.java ! src/java.desktop/share/classes/java/awt/MenuComponent.java ! src/java.desktop/share/classes/java/awt/MenuItem.java ! src/java.desktop/share/classes/java/awt/MouseInfo.java ! src/java.desktop/share/classes/java/awt/Polygon.java ! src/java.desktop/share/classes/java/awt/PopupMenu.java ! src/java.desktop/share/classes/java/awt/RenderingHints.java ! src/java.desktop/share/classes/java/awt/Scrollbar.java ! src/java.desktop/share/classes/java/awt/TextArea.java ! src/java.desktop/share/classes/java/awt/TextComponent.java ! src/java.desktop/share/classes/java/awt/TextField.java ! src/java.desktop/share/classes/java/awt/Toolkit.java ! src/java.desktop/share/classes/java/awt/Window.java ! src/java.desktop/share/classes/java/awt/dnd/DragSource.java ! src/java.desktop/share/classes/java/awt/dnd/DropTarget.java ! src/java.desktop/share/classes/java/awt/event/InputMethodEvent.java ! src/java.desktop/share/classes/java/awt/font/TextLayout.java ! src/java.desktop/share/classes/java/awt/geom/AffineTransform.java ! src/java.desktop/share/classes/java/awt/geom/CubicCurve2D.java ! src/java.desktop/share/classes/java/awt/geom/Dimension2D.java ! src/java.desktop/share/classes/java/awt/geom/FlatteningPathIterator.java ! src/java.desktop/share/classes/java/awt/geom/Line2D.java ! src/java.desktop/share/classes/java/awt/geom/Path2D.java ! src/java.desktop/share/classes/java/awt/geom/Point2D.java ! src/java.desktop/share/classes/java/awt/geom/QuadCurve2D.java ! src/java.desktop/share/classes/java/awt/geom/RectangularShape.java ! src/java.desktop/share/classes/java/awt/im/InputContext.java ! src/java.desktop/share/classes/java/awt/im/InputMethodHighlight.java ! src/java.desktop/share/classes/java/awt/im/spi/InputMethod.java ! src/java.desktop/share/classes/java/awt/im/spi/InputMethodContext.java ! src/java.desktop/share/classes/java/awt/im/spi/InputMethodDescriptor.java ! src/java.desktop/share/classes/java/awt/image/BufferedImage.java ! src/java.desktop/share/classes/java/awt/image/ByteLookupTable.java ! src/java.desktop/share/classes/java/awt/image/ColorConvertOp.java ! src/java.desktop/share/classes/java/awt/image/DirectColorModel.java ! src/java.desktop/share/classes/java/awt/image/ImageFilter.java ! src/java.desktop/share/classes/java/awt/image/MultiPixelPackedSampleModel.java ! src/java.desktop/share/classes/java/awt/image/PixelGrabber.java ! src/java.desktop/share/classes/java/awt/image/RGBImageFilter.java ! src/java.desktop/share/classes/java/awt/image/Raster.java ! src/java.desktop/share/classes/java/awt/image/ShortLookupTable.java ! src/java.desktop/share/classes/java/awt/image/SinglePixelPackedSampleModel.java ! src/java.desktop/share/classes/java/awt/image/WritableRaster.java ! src/java.desktop/share/classes/java/awt/print/PageFormat.java ! src/java.desktop/share/classes/java/awt/print/Printable.java ! src/java.desktop/share/classes/java/awt/print/PrinterJob.java Changeset: beedae11 Author: Claes Redestad Date: 2022-03-17 09:20:24 +0000 URL: https://git.openjdk.java.net/loom/commit/beedae1141b6b650dc4cedf1f038afc1c8b460dd 8281146: Replace StringCoding.hasNegatives with countPositives Co-authored-by: Lutz Schmidt Co-authored-by: Martin Doerr Reviewed-by: kvn, lucy, rriggs ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/cpu/aarch64/stubRoutines_aarch64.cpp ! src/hotspot/cpu/aarch64/stubRoutines_aarch64.hpp ! src/hotspot/cpu/ppc/c2_MacroAssembler_ppc.cpp ! src/hotspot/cpu/ppc/c2_MacroAssembler_ppc.hpp ! src/hotspot/cpu/ppc/ppc.ad ! src/hotspot/cpu/s390/c2_MacroAssembler_s390.cpp ! src/hotspot/cpu/s390/c2_MacroAssembler_s390.hpp ! src/hotspot/cpu/s390/s390.ad ! src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp ! src/hotspot/cpu/x86/c2_MacroAssembler_x86.hpp ! src/hotspot/cpu/x86/x86_32.ad ! src/hotspot/cpu/x86/x86_64.ad ! src/hotspot/share/adlc/formssel.cpp ! src/hotspot/share/classfile/vmIntrinsics.cpp ! src/hotspot/share/classfile/vmIntrinsics.hpp ! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp ! src/hotspot/share/jvmci/vmStructs_jvmci.cpp ! src/hotspot/share/opto/c2compiler.cpp ! src/hotspot/share/opto/classes.hpp ! src/hotspot/share/opto/escape.cpp ! src/hotspot/share/opto/intrinsicnode.hpp ! src/hotspot/share/opto/lcm.cpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/opto/library_call.hpp ! src/hotspot/share/opto/loopTransform.cpp ! src/hotspot/share/opto/loopnode.cpp ! src/hotspot/share/opto/matcher.cpp ! src/java.base/share/classes/java/lang/String.java ! src/java.base/share/classes/java/lang/StringCoding.java + test/hotspot/jtreg/compiler/intrinsics/string/TestCountPositives.java ! test/hotspot/jtreg/compiler/patches/java.base/java/lang/Helper.java ! test/micro/org/openjdk/bench/java/lang/StringDecode.java Changeset: bad658e8 Author: Albert Mingkun Yang Date: 2022-03-17 09:47:51 +0000 URL: https://git.openjdk.java.net/loom/commit/bad658e8e93c831631d41b6dbf66a0a102cd0462 8282727: Parallel: Remove PSPromotionManager::_totally_drain Reviewed-by: tschatzl, kbarrett ! src/hotspot/share/gc/parallel/psPromotionManager.cpp ! src/hotspot/share/gc/parallel/psPromotionManager.hpp Changeset: 69e4e338 Author: Doug Simon Date: 2022-03-17 12:51:10 +0000 URL: https://git.openjdk.java.net/loom/commit/69e4e338b19c0ffd2f0881be1bbb19a5642bc4d4 8283056: show abstract machine code in hs-err for all VM crashes Reviewed-by: thartmann, dholmes ! src/hotspot/share/utilities/vmError.cpp Changeset: 0f1766df Author: Julian Waters Committer: Magnus Ihse Bursie Date: 2022-03-17 15:30:17 +0000 URL: https://git.openjdk.java.net/loom/commit/0f1766dff633e55532d94069d7266a7fe625286c 8283320: Error message for Windows libraries always points to --with-msvcr-dll no matter the actual file name Reviewed-by: erikj, ihse ! make/autoconf/toolchain_microsoft.m4 Changeset: 31df6a60 Author: Albert Mingkun Yang Date: 2022-03-17 16:17:18 +0000 URL: https://git.openjdk.java.net/loom/commit/31df6a60a8853be224d8c8b8c8ca6aea1bae2167 8283188: Build time regression caused by JDK-8278917 Reviewed-by: kbarrett, tschatzl ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp Changeset: 5ef1990d Author: Joe Darcy Date: 2022-03-17 16:37:20 +0000 URL: https://git.openjdk.java.net/loom/commit/5ef1990d6ce35a85c86689badba465b6c8f9f4a1 8283274: Improve @jvms usage in java.base Reviewed-by: iris ! src/java.base/share/classes/java/lang/constant/ClassDesc.java ! src/java.base/share/classes/java/lang/constant/Constable.java ! src/java.base/share/classes/java/lang/constant/ConstantDesc.java ! src/java.base/share/classes/java/lang/constant/package-info.java ! src/java.base/share/classes/java/lang/invoke/ConstantBootstraps.java ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java Changeset: b004fb05 Author: Ioi Lam Date: 2022-03-17 17:50:20 +0000 URL: https://git.openjdk.java.net/loom/commit/b004fb0550d8fc94e3f6412975c23c0a2ac2a42f 8282773: Refactor parsing of integer VM options Reviewed-by: dholmes, kbarrett ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/flags/debug_globals.hpp ! test/hotspot/gtest/runtime/test_arguments.cpp - test/hotspot/gtest/runtime/test_largeOptions.cpp Changeset: 002e3667 Author: Claes Redestad Date: 2022-03-17 21:15:36 +0000 URL: https://git.openjdk.java.net/loom/commit/002e3667443d94e2303c875daf72cf1ccbbb0099 8283325: US_ASCII decoder relies on String.decodeASCII being exhaustive Reviewed-by: rriggs, dcubed ! src/java.base/share/classes/java/lang/String.java + test/jdk/java/nio/charset/CharsetDecoder/ASCIIDecode.java Changeset: d83cee98 Author: Alexander Matveev Date: 2022-03-18 03:14:32 +0000 URL: https://git.openjdk.java.net/loom/commit/d83cee98b5e6628f19f1b5dea11038079dd0c758 8282407: Missing ')' in MacResources.properties Reviewed-by: naoto ! src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/MacResources.properties ! src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/MacResources_ja.properties ! src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/MacResources_zh_CN.properties Changeset: cab4ff64 Author: Tyler Steele Committer: Thomas Stuefe Date: 2022-03-18 07:02:26 +0000 URL: https://git.openjdk.java.net/loom/commit/cab4ff64541393a974ea91e35167668ef0036804 8283225: ClassLoader.c produces incorrect OutOfMemory Exception when length is 0 (aix) Reviewed-by: stuefe, rriggs, dholmes ! src/java.base/share/native/libjava/ClassLoader.c Changeset: b96cb048 Author: Jie Fu Date: 2022-03-18 07:58:58 +0000 URL: https://git.openjdk.java.net/loom/commit/b96cb048f1a7f3ae6e745b245f2b04c64ebb911e 8283353: compiler/c2/cr6865031/Test.java and compiler/runtime/Test6826736.java fails on x86_32 Reviewed-by: chagedorn ! test/hotspot/jtreg/compiler/c2/cr6865031/Test.java ! test/hotspot/jtreg/compiler/runtime/Test6826736.java Changeset: 4b5079b9 Author: Erik Gahlin Date: 2022-03-18 13:18:38 +0000 URL: https://git.openjdk.java.net/loom/commit/4b5079b9836c1cc881f571d060b310f58c8a860c 8283202: Potential off-read when checking JFR's status in awaitFinished Reviewed-by: mgronlun ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/ChunkHeader.java Changeset: c72bcfc1 Author: Erik Gahlin Date: 2022-03-18 13:27:49 +0000 URL: https://git.openjdk.java.net/loom/commit/c72bcfc1b230d22137ac7f683cf46dc70b6e3d16 8283289: JFR: Rename CheckPoint Reviewed-by: mgronlun ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/ChunkParser.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/filter/CheckPointEvent.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/filter/CheckPointPool.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/filter/ChunkWriter.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/tool/Summary.java ! src/jdk.management.jfr/share/classes/jdk/management/jfr/DiskRepository.java Changeset: 85cc6f14 Author: Andrew Leonard Date: 2022-03-18 13:40:35 +0000 URL: https://git.openjdk.java.net/loom/commit/85cc6f1440aa7e073cab894cb9a72d9eed4e8369 8283315: jrt-fs.jar not always deterministically built Reviewed-by: ihse ! make/common/JarArchive.gmk Changeset: b2aa085e Author: Erik Gahlin Date: 2022-03-18 14:54:56 +0000 URL: https://git.openjdk.java.net/loom/commit/b2aa085e67711a32e1679b68aabb092058dca044 8283378: JFR: Checkpoint classes not renamed properly Reviewed-by: dcubed = src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/filter/CheckpointEvent.java = src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/filter/CheckpointPool.java Changeset: ff0b0927 Author: Ravi Reddy Committer: Lance Andersen Date: 2022-03-18 15:31:30 +0000 URL: https://git.openjdk.java.net/loom/commit/ff0b0927a2df8b36f8fd6ed41bd4e20e71a5b653 8278794: Infinite loop in DeflaterOutputStream.finish() Reviewed-by: coffeys, lancea ! src/java.base/share/classes/java/util/zip/Deflater.java ! src/java.base/share/classes/java/util/zip/DeflaterOutputStream.java ! src/java.base/share/classes/java/util/zip/ZipOutputStream.java - test/jdk/java/util/zip/CloseDeflaterTest.java + test/jdk/java/util/zip/CloseInflaterDeflaterTest.java Changeset: d8893fad Author: Mikael Vidstedt Date: 2022-03-18 20:28:39 +0000 URL: https://git.openjdk.java.net/loom/commit/d8893fad23d1ee6841336b96c34599643edb81ce 8283059: Uninitialized warning in check_code.c with GCC 11.2 Reviewed-by: dholmes ! src/java.base/share/native/libverify/check_code.c Changeset: 8384ac4e Author: Mikael Vidstedt Date: 2022-03-18 22:01:27 +0000 URL: https://git.openjdk.java.net/loom/commit/8384ac4ed3eaaa18998ab88e1ca36358c212e699 8283057: Update GCC to version 11.2 for Oracle builds on Linux Reviewed-by: erikj ! doc/building.html ! doc/building.md ! make/conf/jib-profiles.js ! make/devkit/Tools.gmk Changeset: 0c3094c8 Author: Ichiroh Takiguchi Date: 2022-03-19 04:43:20 +0000 URL: https://git.openjdk.java.net/loom/commit/0c3094c8186b4d53e8bad80e2369fc7b9ae9e201 8204541: Correctly support AIX xlC 16.1 symbol visibility flags Reviewed-by: ihse, stuefe ! make/autoconf/flags-ldflags.m4 ! make/common/modules/LauncherCommon.gmk ! make/common/modules/LibCommon.gmk Changeset: 3e58a438 Author: Tyler Steele Committer: Thomas Stuefe Date: 2022-03-19 07:06:47 +0000 URL: https://git.openjdk.java.net/loom/commit/3e58a438e9051d4c976273eea35e36d37d5428c3 8283287: ClassLoader.c cleanups Reviewed-by: stuefe, alanb, rriggs ! src/java.base/share/native/libjava/ClassLoader.c Changeset: 10ccfffa Author: Jie Fu Date: 2022-03-19 07:08:47 +0000 URL: https://git.openjdk.java.net/loom/commit/10ccfffae1f18dd1a3d2f3dca53ad547d3d3ecb5 8283352: [CDS] SharedBaseAddress.java fails on x86_32 Reviewed-by: dholmes, iklam, stuefe ! test/hotspot/jtreg/runtime/cds/SharedBaseAddress.java ! test/hotspot/jtreg/runtime/cds/appcds/SharedBaseAddress.java Changeset: e8caf84f Author: Andrey Turbanov Date: 2022-03-19 13:29:49 +0000 URL: https://git.openjdk.java.net/loom/commit/e8caf84fb9dfcbb59da6459972724b6780b0871a 8282574: Cleanup unnecessary calls to Throwable.initCause() in jdk.compiler Reviewed-by: darcy ! src/jdk.compiler/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/Pretty.java Changeset: 80415e04 Author: Andrey Turbanov Date: 2022-03-19 13:31:50 +0000 URL: https://git.openjdk.java.net/loom/commit/80415e04c5fd6709e7e5b5ffb7a3d9431b672d99 8282534: Remove redundant null check in ChaCha20Cipher.engineInit Reviewed-by: xuelei ! src/java.base/share/classes/com/sun/crypto/provider/ChaCha20Cipher.java Changeset: 3f923b82 Author: Daniel D. Daugherty Date: 2022-03-19 13:43:06 +0000 URL: https://git.openjdk.java.net/loom/commit/3f923b82c31325504430b50dee262fd460004e7b 8282704: runtime/Thread/StopAtExit.java may leak memory Reviewed-by: dholmes, alanb ! test/hotspot/jtreg/runtime/Thread/StopAtExit.java Changeset: 4df67426 Author: Xue-Lei Andrew Fan Date: 2022-03-20 06:46:13 +0000 URL: https://git.openjdk.java.net/loom/commit/4df67426ed02f18af0757897acb28b636a317a91 8282723: Add constructors taking a cause to JSSE exceptions Reviewed-by: wetmore, iris ! src/java.base/share/classes/javax/net/ssl/SSLException.java ! src/java.base/share/classes/javax/net/ssl/SSLHandshakeException.java ! src/java.base/share/classes/javax/net/ssl/SSLKeyException.java ! src/java.base/share/classes/javax/net/ssl/SSLPeerUnverifiedException.java ! src/java.base/share/classes/javax/net/ssl/SSLProtocolException.java ! src/java.base/share/classes/sun/security/ssl/Alert.java ! src/java.base/share/classes/sun/security/ssl/DHClientKeyExchange.java ! src/java.base/share/classes/sun/security/ssl/ECDHKeyExchange.java ! src/java.base/share/classes/sun/security/ssl/KAKeyDerivation.java ! src/java.base/share/classes/sun/security/ssl/NewSessionTicket.java ! src/java.base/share/classes/sun/security/ssl/SSLBasicKeyDerivation.java ! src/java.base/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/java.base/share/classes/sun/security/ssl/SSLEngineInputRecord.java ! src/java.base/share/classes/sun/security/ssl/SSLSecretDerivation.java ! src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java ! src/java.base/share/classes/sun/security/ssl/SSLSocketInputRecord.java ! src/java.base/share/classes/sun/security/ssl/SSLTrafficKeyDerivation.java ! src/java.base/share/classes/sun/security/ssl/ServerHello.java ! src/java.base/share/classes/sun/security/ssl/ServerNameExtension.java ! src/java.naming/share/classes/com/sun/jndi/ldap/ext/StartTlsResponseImpl.java ! src/java.net.http/share/classes/jdk/internal/net/http/HttpClientImpl.java ! src/java.net.http/share/classes/jdk/internal/net/http/common/SSLTube.java ! test/jdk/javax/net/ssl/ALPN/SSLServerSocketAlpnTest.java ! test/jdk/javax/net/ssl/ALPN/SSLSocketAlpnTest.java + test/jdk/javax/net/ssl/SSLException/CheckSSLHandshakeException.java + test/jdk/javax/net/ssl/SSLException/CheckSSLKeyException.java + test/jdk/javax/net/ssl/SSLException/CheckSSLPeerUnverifiedException.java + test/jdk/javax/net/ssl/SSLException/CheckSSLProtocolException.java ! test/jdk/javax/net/ssl/templates/SSLSocketSSLEngineTemplate.java ! test/jdk/javax/net/ssl/templates/SSLSocketTemplate.java Changeset: 8a2d5ab0 Author: Maxim Kartashev Committer: Alexey Ivanov Date: 2022-03-21 07:21:00 +0000 URL: https://git.openjdk.java.net/loom/commit/8a2d5ab07e6a1668f3e3918bdc8a30bd28a8f93b 8282270: java/awt/Robot Screen Capture tests fail after 8280861 Reviewed-by: aivanov ! test/jdk/ProblemList.txt ! test/jdk/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java ! test/jdk/java/awt/Robot/HiDPIScreenCapture/ScreenCaptureGtkTest.java Changeset: b451273d Author: Manukumar V S Committer: Alexey Ivanov Date: 2022-03-21 07:33:20 +0000 URL: https://git.openjdk.java.net/loom/commit/b451273d209d9dfce3d7c4464defe0df523dfc7c 8282548: Create a regression test for JDK-4330998 Reviewed-by: aivanov + test/jdk/javax/swing/JEditorPane/4330998/JEditorPaneSetTextNullTest.java Changeset: 83a1c904 Author: Manukumar V S Committer: Alexey Ivanov Date: 2022-03-21 07:36:21 +0000 URL: https://git.openjdk.java.net/loom/commit/83a1c90433343107eaa2a7fa41b9b07f86b6ce19 8282789: Create a regression test for the JTree usecase of JDK-4618767 Reviewed-by: aivanov + test/jdk/javax/swing/JTree/4618767/JTreeSelectedElementTest.java Changeset: e709cb05 Author: Thomas Schatzl Date: 2022-03-21 08:25:33 +0000 URL: https://git.openjdk.java.net/loom/commit/e709cb05dcf67462f266c1f3dae30976b562676d 8283186: Explicitly pass a third temp register to MacroAssembler::store_heap_oop Reviewed-by: eosterlund ! src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.hpp ! src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.hpp ! src/hotspot/cpu/x86/gc/shared/cardTableBarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/shared/cardTableBarrierSetAssembler_x86.hpp ! src/hotspot/cpu/x86/gc/shared/modRefBarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/shared/modRefBarrierSetAssembler_x86.hpp ! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp ! src/hotspot/cpu/x86/gc/z/zBarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/z/zBarrierSetAssembler_x86.hpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/cpu/x86/templateTable_x86.cpp Changeset: ec62d90d Author: Albert Mingkun Yang Date: 2022-03-21 08:39:17 +0000 URL: https://git.openjdk.java.net/loom/commit/ec62d90db2428d0da6ed0f338858f5bc2a76e991 8283365: G1: Remove duplicate assertions in HeapRegion::oops_on_memregion_seq_iterate_careful Reviewed-by: kbarrett, tschatzl ! src/hotspot/share/gc/g1/heapRegion.inline.hpp Changeset: fd930151 Author: Albert Mingkun Yang Date: 2022-03-21 08:40:14 +0000 URL: https://git.openjdk.java.net/loom/commit/fd9301514e2093d9dcd7bcd9e4b812146b20dd03 8283332: G1: Stricter assertion in G1BlockOffsetTablePart::forward_to_block_containing_addr Reviewed-by: kbarrett, iwalulya ! src/hotspot/share/gc/g1/g1BlockOffsetTable.inline.hpp Changeset: eb4849e5 Author: Thomas Schatzl Date: 2022-03-21 10:42:38 +0000 URL: https://git.openjdk.java.net/loom/commit/eb4849e5615dd307a5abc435a0204a6d26610fcb 8283327: Add methods to save/restore registers when calling into the VM from C1/interpreter barrier code Reviewed-by: eosterlund, dlong ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/register_aarch64.hpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/register_x86.hpp ! src/hotspot/share/asm/register.hpp From duke at openjdk.java.net Mon Mar 21 20:22:41 2022 From: duke at openjdk.java.net (duke) Date: Mon, 21 Mar 2022 20:22:41 GMT Subject: git: openjdk/loom: fibers: Fix LoomVM flag Message-ID: <1d2fad23-a1b7-4a27-9c04-d8440dfcd33a@openjdk.java.net> Changeset: b9d53fd2 Author: Ron Pressler Date: 2022-03-21 19:59:07 +0000 URL: https://git.openjdk.java.net/loom/commit/b9d53fd2812f753f6e82d534bc77f14685803c16 Fix LoomVM flag ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp ! src/hotspot/share/gc/shared/barrierSet.cpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp From coleenp at openjdk.java.net Mon Mar 21 21:46:20 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Mon, 21 Mar 2022 21:46:20 GMT Subject: RFR: Make compile on other platforms. Message-ID: <1d17UKZv8uqXauk7Jmsty0MHYvn-ngDfOTz-CACk-7g=.d511465d-b0d9-415c-a7fb-45b20126c108@github.com> This patch with additions and deletions of dummy stubs gets loom to compile on zero, ppc, s390, arm, linux 32 bit open, ie platforms that Oracle doesn't support. There are two not nice #if !defined(AMD64) || !defined(AARCH64) || defined(ZERO) changes. One for platform dependent code in signature.cpp and the other is because linux zero product inlining detects the dummy null return as input to memcpy. Also has a stack walking change that makes zero not complete compilation with the built compiler because of dummy returns. Removing this doesn't cause any test failures in the loom tier1-3 code. ------------- Commit messages: - Make compile on other platforms. Changes: https://git.openjdk.java.net/loom/pull/111/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=111&range=00 Stats: 90 lines in 14 files changed: 7 ins; 55 del; 28 mod Patch: https://git.openjdk.java.net/loom/pull/111.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/111/head:pull/111 PR: https://git.openjdk.java.net/loom/pull/111 From duke at openjdk.java.net Tue Mar 22 01:31:52 2022 From: duke at openjdk.java.net (duke) Date: Tue, 22 Mar 2022 01:31:52 GMT Subject: git: openjdk/loom: fibers: fix GetSetLocalTest for correct completion Message-ID: Changeset: 54f76b55 Author: Serguei Spitsyn Date: 2022-03-22 01:29:38 +0000 URL: https://git.openjdk.java.net/loom/commit/54f76b552a292359e3cf1be7db532f1b4ceaaf21 fix GetSetLocalTest for correct completion ! test/hotspot/jtreg/serviceability/jvmti/vthread/GetSetLocalTest/GetSetLocalTest.java ! test/hotspot/jtreg/serviceability/jvmti/vthread/GetSetLocalTest/libGetSetLocalTest.cpp From haosun at openjdk.java.net Tue Mar 22 01:32:14 2022 From: haosun at openjdk.java.net (Hao Sun) Date: Tue, 22 Mar 2022 01:32:14 GMT Subject: RFR: 8282849: Loom: Fix minimal debug non-PCH build failure [v4] In-Reply-To: References: Message-ID: > As described in JBS-8282849, this build failure was introduced by commit > bd25c94 and commit 4d27102. Adding the missing headers would fix it. Hao Sun has updated the pull request incrementally with one additional commit since the last revision: Revert the updates in instanceStackChunkKlass.cpp and javaClasses.inline.hpp The errors in file javaClasses.inline.hpp and file instanceStackChunkKlass.cpp were fixed in commit https://github.com/openjdk/loom/commit/970249d. We revert our previous updates in v1 in this patch. ------------- Changes: - all: https://git.openjdk.java.net/loom/pull/99/files - new: https://git.openjdk.java.net/loom/pull/99/files/978cfa3e..097d442e Webrevs: - full: https://webrevs.openjdk.java.net/?repo=loom&pr=99&range=03 - incr: https://webrevs.openjdk.java.net/?repo=loom&pr=99&range=02-03 Stats: 6 lines in 2 files changed: 0 ins; 6 del; 0 mod Patch: https://git.openjdk.java.net/loom/pull/99.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/99/head:pull/99 PR: https://git.openjdk.java.net/loom/pull/99 From stefank at openjdk.java.net Tue Mar 22 08:22:10 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Tue, 22 Mar 2022 08:22:10 GMT Subject: RFR: Simplify G1CodeBlobClosure Message-ID: There's no need to introduce a new _keepalive_is_strong property in the G1CodeBlobClosure. The existing _strong is set to true when the evacuation participates in the marking of the old gen, which is when we need to mark the nmethods as "maybe on continuation". The name _strong in this context is not great and it doesn't convey the actual meaning. Maybe something for a future G1 cleanup. ------------- Commit messages: - Simplify G1CodeBlobClosure Changes: https://git.openjdk.java.net/loom/pull/112/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=112&range=00 Stats: 12 lines in 4 files changed: 0 ins; 3 del; 9 mod Patch: https://git.openjdk.java.net/loom/pull/112.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/112/head:pull/112 PR: https://git.openjdk.java.net/loom/pull/112 From tschatzl at openjdk.java.net Tue Mar 22 08:41:50 2022 From: tschatzl at openjdk.java.net (Thomas Schatzl) Date: Tue, 22 Mar 2022 08:41:50 GMT Subject: RFR: Simplify G1CodeBlobClosure In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 08:16:29 GMT, Stefan Karlsson wrote: > There's no need to introduce a new _keepalive_is_strong property in the G1CodeBlobClosure. The existing _strong is set to true when the evacuation participates in the marking of the old gen, which is when we need to mark the nmethods as "maybe on continuation". The name _strong in this context is not great and it doesn't convey the actual meaning. Maybe something for a future G1 cleanup. Thanks for looking into this - that change has been one of the stranger to me as well. Looks good. ------------- Marked as reviewed by tschatzl (no project role). PR: https://git.openjdk.java.net/loom/pull/112 From stefank at openjdk.java.net Tue Mar 22 09:15:14 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Tue, 22 Mar 2022 09:15:14 GMT Subject: RFR: Fix SerialGC bug in full_process_roots Message-ID: There seems to have been an inadvertent change to argument to fix_relocations in full_process_roots. The bug doesn't cause any problems, it just calls an expensive operation (fix_oop_relocations) unnecessarily. Restore the old value. ------------- Commit messages: - Fix SerialGC bug in full_process_roots Changes: https://git.openjdk.java.net/loom/pull/113/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=113&range=00 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/loom/pull/113.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/113/head:pull/113 PR: https://git.openjdk.java.net/loom/pull/113 From tschatzl at openjdk.java.net Tue Mar 22 10:49:55 2022 From: tschatzl at openjdk.java.net (Thomas Schatzl) Date: Tue, 22 Mar 2022 10:49:55 GMT Subject: RFR: Fix SerialGC bug in full_process_roots In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 09:10:01 GMT, Stefan Karlsson wrote: > There seems to have been an inadvertent change to argument to fix_relocations in full_process_roots. The bug doesn't cause any problems, it just calls an expensive operation (fix_oop_relocations) unnecessarily. Restore the old value. Marked as reviewed by tschatzl (no project role). ------------- PR: https://git.openjdk.java.net/loom/pull/113 From coleenp at openjdk.java.net Tue Mar 22 12:21:55 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Tue, 22 Mar 2022 12:21:55 GMT Subject: RFR: Make compile on other platforms. In-Reply-To: <1d17UKZv8uqXauk7Jmsty0MHYvn-ngDfOTz-CACk-7g=.d511465d-b0d9-415c-a7fb-45b20126c108@github.com> References: <1d17UKZv8uqXauk7Jmsty0MHYvn-ngDfOTz-CACk-7g=.d511465d-b0d9-415c-a7fb-45b20126c108@github.com> Message-ID: On Mon, 21 Mar 2022 21:39:56 GMT, Coleen Phillimore wrote: > This patch with additions and deletions of dummy stubs gets loom to compile on zero, ppc, s390, arm, linux 32 bit open, ie platforms that Oracle doesn't support. > There are two not nice > #if !defined(AMD64) || !defined(AARCH64) || defined(ZERO) > changes. One for platform dependent code in signature.cpp and the other is because linux zero product inlining detects the dummy null return as input to memcpy. > Also has a stack walking change that makes zero not complete compilation with the built compiler because of dummy returns. Removing this doesn't cause any test failures in the loom tier1-3 code. @[shqking](https://github.com/shqking) Can you have a look? thanks. ------------- PR: https://git.openjdk.java.net/loom/pull/111 From duke at openjdk.java.net Tue Mar 22 12:27:15 2022 From: duke at openjdk.java.net (duke) Date: Tue, 22 Mar 2022 12:27:15 GMT Subject: git: openjdk/loom: fibers: 2 new changesets Message-ID: Changeset: c3398fa2 Author: Alan Bateman Date: 2022-03-21 18:34:50 +0000 URL: https://git.openjdk.java.net/loom/commit/c3398fa21f362d03a431eba94fbfd9df27bc8799 Ensure isVirtual is cached ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ThreadReferenceImpl.java Changeset: 3646ccf6 Author: Alan Bateman Date: 2022-03-22 12:24:05 +0000 URL: https://git.openjdk.java.net/loom/commit/3646ccf65bcfd5f46115836c7dc545322b1887fa Update com/sun/jdi test infra to allow for threads with no names ! test/jdk/com/sun/jdi/lib/jdb/Jdb.java From alanb at openjdk.java.net Tue Mar 22 12:27:50 2022 From: alanb at openjdk.java.net (Alan Bateman) Date: Tue, 22 Mar 2022 12:27:50 GMT Subject: RFR: Make compile on other platforms. In-Reply-To: <1d17UKZv8uqXauk7Jmsty0MHYvn-ngDfOTz-CACk-7g=.d511465d-b0d9-415c-a7fb-45b20126c108@github.com> References: <1d17UKZv8uqXauk7Jmsty0MHYvn-ngDfOTz-CACk-7g=.d511465d-b0d9-415c-a7fb-45b20126c108@github.com> Message-ID: On Mon, 21 Mar 2022 21:39:56 GMT, Coleen Phillimore wrote: > This patch with additions and deletions of dummy stubs gets loom to compile on zero, ppc, s390, arm, linux 32 bit open, ie platforms that Oracle doesn't support. > There are two not nice > #if !defined(AMD64) || !defined(AARCH64) || defined(ZERO) > changes. One for platform dependent code in signature.cpp and the other is because linux zero product inlining detects the dummy null return as input to memcpy. > Also has a stack walking change that makes zero not complete compilation with the built compiler because of dummy returns. Removing this doesn't cause any test failures in the loom tier1-3 code. Marked as reviewed by alanb (Committer). ------------- PR: https://git.openjdk.java.net/loom/pull/111 From alanb at openjdk.java.net Tue Mar 22 12:49:43 2022 From: alanb at openjdk.java.net (Alan Bateman) Date: Tue, 22 Mar 2022 12:49:43 GMT Subject: RFR: 8282849: Loom: Fix minimal debug non-PCH build failure [v4] In-Reply-To: References: Message-ID: <2pAX2GFxrUs8mUDiX0162YprAjKFMm976Z67acp6qps=.39421bc3-81dd-4762-b7b7-b16bc62838f1@github.com> On Tue, 22 Mar 2022 01:32:14 GMT, Hao Sun wrote: >> As described in JBS-8282849, this build failure was introduced by commit >> bd25c94 and commit 4d27102. Adding the missing headers would fix it. > > Hao Sun has updated the pull request incrementally with one additional commit since the last revision: > > Revert the updates in instanceStackChunkKlass.cpp and javaClasses.inline.hpp > > The errors in file javaClasses.inline.hpp and file > instanceStackChunkKlass.cpp were fixed in commit > https://github.com/openjdk/loom/commit/970249d. > > We revert our previous updates in v1 in this patch. This make sense, good to see that it's down to one include now. ------------- Marked as reviewed by alanb (Committer). PR: https://git.openjdk.java.net/loom/pull/99 From stefank at openjdk.java.net Tue Mar 22 13:12:51 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Tue, 22 Mar 2022 13:12:51 GMT Subject: RFR: Simplify G1CodeBlobClosure In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 08:16:29 GMT, Stefan Karlsson wrote: > There's no need to introduce a new _keepalive_is_strong property in the G1CodeBlobClosure. The existing _strong is set to true when the evacuation participates in the marking of the old gen, which is when we need to mark the nmethods as "maybe on continuation". The name _strong in this context is not great and it doesn't convey the actual meaning. Maybe something for a future G1 cleanup. Thanks for reviewing! ------------- PR: https://git.openjdk.java.net/loom/pull/112 From stefank at openjdk.java.net Tue Mar 22 13:13:54 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Tue, 22 Mar 2022 13:13:54 GMT Subject: RFR: Fix SerialGC bug in full_process_roots In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 09:10:01 GMT, Stefan Karlsson wrote: > There seems to have been an inadvertent change to argument to fix_relocations in full_process_roots. The bug doesn't cause any problems, it just calls an expensive operation (fix_oop_relocations) unnecessarily. Restore the old value. Thanks for reviewing! ------------- PR: https://git.openjdk.java.net/loom/pull/113 From duke at openjdk.java.net Tue Mar 22 13:21:20 2022 From: duke at openjdk.java.net (duke) Date: Tue, 22 Mar 2022 13:21:20 GMT Subject: git: openjdk/loom: fibers: Fix problems with CompiledMethodIterator Message-ID: <151e3c70-c1a4-4468-8b56-d6d2e35d77ba@openjdk.java.net> Changeset: 24a1e88f Author: Rickard B?ckman Date: 2022-03-22 12:24:06 +0000 URL: https://git.openjdk.java.net/loom/commit/24a1e88f40a6ae214141f874edb65f70663767f8 Fix problems with CompiledMethodIterator ! src/hotspot/share/code/codeCache.cpp ! src/hotspot/share/code/codeCache.hpp ! src/hotspot/share/runtime/sweeper.cpp From duke at openjdk.java.net Tue Mar 22 13:58:09 2022 From: duke at openjdk.java.net (duke) Date: Tue, 22 Mar 2022 13:58:09 GMT Subject: git: openjdk/loom: fibers: Make compile on other platforms. Message-ID: <4530d60b-4909-470e-936c-0d7defe91954@openjdk.java.net> Changeset: 16e4713c Author: Coleen Phillimore Date: 2022-03-22 13:57:46 +0000 URL: https://git.openjdk.java.net/loom/commit/16e4713cede546735dbeddbd646f1e52f39b6893 Make compile on other platforms. Reviewed-by: alanb ! src/hotspot/cpu/arm/continuation_arm.inline.hpp ! src/hotspot/cpu/arm/frame_arm.cpp ! src/hotspot/cpu/ppc/continuation_ppc.inline.hpp ! src/hotspot/cpu/ppc/frame_ppc.cpp ! src/hotspot/cpu/s390/continuation_s390.inline.hpp ! src/hotspot/cpu/s390/frame_s390.cpp ! src/hotspot/cpu/zero/continuation_zero.inline.hpp ! src/hotspot/cpu/zero/frame_zero.cpp ! src/hotspot/os_cpu/linux_arm/atomic_linux_arm.hpp ! src/hotspot/os_cpu/linux_x86/atomic_linux_x86.hpp ! src/hotspot/share/oops/stackChunkOop.inline.hpp ! src/hotspot/share/runtime/signature.cpp ! src/hotspot/share/runtime/threadIdentifiers.cpp ! src/hotspot/share/runtime/vframe.inline.hpp From coleenp at openjdk.java.net Tue Mar 22 13:58:50 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Tue, 22 Mar 2022 13:58:50 GMT Subject: RFR: Make compile on other platforms. In-Reply-To: <1d17UKZv8uqXauk7Jmsty0MHYvn-ngDfOTz-CACk-7g=.d511465d-b0d9-415c-a7fb-45b20126c108@github.com> References: <1d17UKZv8uqXauk7Jmsty0MHYvn-ngDfOTz-CACk-7g=.d511465d-b0d9-415c-a7fb-45b20126c108@github.com> Message-ID: On Mon, 21 Mar 2022 21:39:56 GMT, Coleen Phillimore wrote: > This patch with additions and deletions of dummy stubs gets loom to compile on zero, ppc, s390, arm, linux 32 bit open, ie platforms that Oracle doesn't support. > There are two not nice > #if !defined(AMD64) || !defined(AARCH64) || defined(ZERO) > changes. One for platform dependent code in signature.cpp and the other is because linux zero product inlining detects the dummy null return as input to memcpy. > Also has a stack walking change that makes zero not complete compilation with the built compiler because of dummy returns. Removing this doesn't cause any test failures in the loom tier1-3 code. Thanks Alan. ------------- PR: https://git.openjdk.java.net/loom/pull/111 From coleenp at openjdk.java.net Tue Mar 22 14:01:46 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Tue, 22 Mar 2022 14:01:46 GMT Subject: Integrated: Make compile on other platforms. In-Reply-To: <1d17UKZv8uqXauk7Jmsty0MHYvn-ngDfOTz-CACk-7g=.d511465d-b0d9-415c-a7fb-45b20126c108@github.com> References: <1d17UKZv8uqXauk7Jmsty0MHYvn-ngDfOTz-CACk-7g=.d511465d-b0d9-415c-a7fb-45b20126c108@github.com> Message-ID: On Mon, 21 Mar 2022 21:39:56 GMT, Coleen Phillimore wrote: > This patch with additions and deletions of dummy stubs gets loom to compile on zero, ppc, s390, arm, linux 32 bit open, ie platforms that Oracle doesn't support. > There are two not nice > #if !defined(AMD64) || !defined(AARCH64) || defined(ZERO) > changes. One for platform dependent code in signature.cpp and the other is because linux zero product inlining detects the dummy null return as input to memcpy. > Also has a stack walking change that makes zero not complete compilation with the built compiler because of dummy returns. Removing this doesn't cause any test failures in the loom tier1-3 code. This pull request has now been integrated. Changeset: 16e4713c Author: Coleen Phillimore URL: https://git.openjdk.java.net/loom/commit/16e4713cede546735dbeddbd646f1e52f39b6893 Stats: 90 lines in 14 files changed: 7 ins; 55 del; 28 mod Make compile on other platforms. Reviewed-by: alanb ------------- PR: https://git.openjdk.java.net/loom/pull/111 From haosun at openjdk.java.net Tue Mar 22 14:01:50 2022 From: haosun at openjdk.java.net (Hao Sun) Date: Tue, 22 Mar 2022 14:01:50 GMT Subject: RFR: 8282849: Loom: Fix minimal debug non-PCH build failure [v4] In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 14:28:19 GMT, Ron Pressler wrote: >> Hao Sun has updated the pull request incrementally with one additional commit since the last revision: >> >> Revert the updates in instanceStackChunkKlass.cpp and javaClasses.inline.hpp >> >> The errors in file javaClasses.inline.hpp and file >> instanceStackChunkKlass.cpp were fixed in commit >> https://github.com/openjdk/loom/commit/970249d. >> >> We revert our previous updates in v1 in this patch. > > Marked as reviewed by rpressler (Lead). May I have your second review of this patch? @pron Thanks. ------------- PR: https://git.openjdk.java.net/loom/pull/99 From duke at openjdk.java.net Tue Mar 22 14:59:14 2022 From: duke at openjdk.java.net (duke) Date: Tue, 22 Mar 2022 14:59:14 GMT Subject: git: openjdk/loom: fibers: JFR: cleanups Message-ID: Changeset: 41d4ba55 Author: mgronlun Date: 2022-03-22 15:57:30 +0000 URL: https://git.openjdk.java.net/loom/commit/41d4ba55cdab94892e6cffbd30489ca2d21b0028 JFR: cleanups ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/share/c1/c1_LIRGenerator.cpp ! src/hotspot/share/c1/c1_Runtime1.cpp ! src/hotspot/share/gc/shared/copyFailedInfo.hpp ! src/hotspot/share/jfr/jfr.cpp ! src/hotspot/share/jfr/jfr.hpp ! src/hotspot/share/jfr/jfrEvents.hpp ! src/hotspot/share/jfr/jni/jfrJavaSupport.cpp ! src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointManager.cpp ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrType.cpp ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrType.hpp ! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdLoadBarrier.hpp ! src/hotspot/share/jfr/recorder/jfrRecorder.hpp ! src/hotspot/share/jfr/recorder/repository/jfrEmergencyDump.cpp ! src/hotspot/share/jfr/recorder/repository/jfrEmergencyDump.hpp ! src/hotspot/share/jfr/recorder/stacktrace/jfrStackTrace.cpp ! src/hotspot/share/jfr/recorder/stacktrace/jfrStackTrace.hpp ! src/hotspot/share/jfr/recorder/stacktrace/jfrStackTraceRepository.cpp ! src/hotspot/share/jfr/recorder/stacktrace/jfrStackTraceRepository.hpp ! src/hotspot/share/jfr/recorder/storage/jfrBuffer.cpp ! src/hotspot/share/jfr/recorder/storage/jfrBuffer.hpp ! src/hotspot/share/jfr/recorder/storage/jfrEpochStorage.inline.hpp ! src/hotspot/share/jfr/recorder/storage/jfrMemorySpace.inline.hpp ! src/hotspot/share/jfr/recorder/storage/jfrStorageUtils.hpp ! src/hotspot/share/jfr/support/jfrIntrinsics.cpp ! src/hotspot/share/jfr/support/jfrIntrinsics.hpp ! src/hotspot/share/jfr/support/jfrThreadLocal.cpp ! src/hotspot/share/jfr/support/jfrTraceIdExtension.hpp ! src/hotspot/share/jfr/utilities/jfrTypes.hpp ! src/hotspot/share/jfr/writers/jfrStreamWriterHost.hpp ! src/hotspot/share/jfr/writers/jfrStreamWriterHost.inline.hpp ! src/hotspot/share/jfr/writers/jfrWriterHost.inline.hpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/opto/runtime.cpp ! src/hotspot/share/opto/runtime.hpp ! src/hotspot/share/prims/jni.cpp ! src/hotspot/share/runtime/java.cpp ! src/jdk.jfr/share/classes/jdk/jfr/internal/JVM.java From coleenp at openjdk.java.net Tue Mar 22 15:00:45 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Tue, 22 Mar 2022 15:00:45 GMT Subject: RFR: Small fixes - shipment one In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 14:18:42 GMT, Robbin Ehn wrote: > Reducing the number of variables, the number of assignment to each variable, white-spaces, renamed some variables, removed unnecessary template, etc... > Except the removal of template 'bottom', the code is the same. (assert is moved up one level) > > Passes 1-3 (no new failures) > It seem to be slightly faster than before, but at least on par. > > This is not complete at all, but to avoid merge conflict I want to ship, and also make someone happy about removing a template. I like these cleanups. Only one I had a question about. Thank you. src/hotspot/share/runtime/continuation.cpp line 180: > 178: #define VERIFY_CONTINUATION(cont) verify_continuation((cont)) > 179: NOINLINE static bool verify_stack_chunk(oop chunk) { return InstanceStackChunkKlass::verify(chunk); } > 180: #define VERIFY_STACK_CHUNK(chunk) verify_stack_chunk((chunk)) Thanks for fixing this. I know Ron likes to see the asserts have a line number of the caller but there's a PR to fix this and almost all of use some debugger to see where the assert comes from in the call stack, if it's not already in the hs_err file. src/hotspot/share/runtime/continuation.cpp line 1160: > 1158: // properties of the continuation on the stack; all sizes are in words > 1159: intptr_t* const stack_top = top_sp + ContinuationHelper::frame_metadata; > 1160: const int stack_argsize = _cont.argsize(); I like this spelled out in the places it's used. I wonder if _cont.argsize() is the stacksize of the stack chunk oops. There are no comments really what it is. cont_size seems to be the stack size of the entire continuation, ie the sum of all the stack chunk oops? Dunno. We're going to need some comments. src/hotspot/share/runtime/continuation.cpp line 1213: > 1211: > 1212: chunk = allocate_chunk(cont_size + ContinuationHelper::frame_metadata); > 1213: if (UNLIKELY(chunk == nullptr || !_thread->cont_fastpath() || _barriers)) { // OOME/probably humongous This is just a strange set of conditions. Why would you allocate_chunk if _thread->cont_fastpath() is false? or _barriers, whatever that means. Really don't expect a function like allocate_chunk to have side effects. Maybe in the latter two conditions, you still want to zero out the chunk in the tail and don't want to remove this. src/hotspot/share/runtime/continuation.cpp line 1847: > 1845: assert((intptr_t)chunk->start_address() % 8 == 0, ""); > 1846: > 1847: init_chunk(chunk); I tried taking this out as an experiment because I thought after Java heap allocation, it would be already zeroed, but it wasn't. ------------- Marked as reviewed by coleenp (Committer). PR: https://git.openjdk.java.net/loom/pull/114 From coleenp at openjdk.java.net Tue Mar 22 15:12:56 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Tue, 22 Mar 2022 15:12:56 GMT Subject: RFR: Small fixes - shipment one In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 14:18:42 GMT, Robbin Ehn wrote: > Reducing the number of variables, the number of assignment to each variable, white-spaces, renamed some variables, removed unnecessary template, etc... > Except the removal of template 'bottom', the code is the same. (assert is moved up one level) > > Passes 1-3 (no new failures) > It seem to be slightly faster than before, but at least on par. > > This is not complete at all, but to avoid merge conflict I want to ship, and also make someone happy about removing a template. | and also make someone happy about removing a template. me! ------------- PR: https://git.openjdk.java.net/loom/pull/114 From coleenp at openjdk.java.net Tue Mar 22 15:41:53 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Tue, 22 Mar 2022 15:41:53 GMT Subject: RFR: Small fixes - shipment one In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 15:26:14 GMT, Robbin Ehn wrote: >> src/hotspot/share/runtime/continuation.cpp line 1213: >> >>> 1211: >>> 1212: chunk = allocate_chunk(cont_size + ContinuationHelper::frame_metadata); >>> 1213: if (UNLIKELY(chunk == nullptr || !_thread->cont_fastpath() || _barriers)) { // OOME/probably humongous >> >> This is just a strange set of conditions. Why would you allocate_chunk if _thread->cont_fastpath() is false? or _barriers, whatever that means. Really don't expect a function like allocate_chunk to have side effects. >> Maybe in the latter two conditions, you still want to zero out the chunk in the tail and don't want to remove this. > > The variable _barriers is set by allocate_chunk, so it must be check afterwards. > If allocation safepoints and there is JVM TI qeury it can 'remove' us as available for fastpath. > If allocation fails due to OOME. > > The init_chunk() should always zero enought. Ok, thanks for confirming that it's already zeroed. ------------- PR: https://git.openjdk.java.net/loom/pull/114 From duke at openjdk.java.net Tue Mar 22 15:44:18 2022 From: duke at openjdk.java.net (duke) Date: Tue, 22 Mar 2022 15:44:18 GMT Subject: git: openjdk/loom: fibers: JFR: adjustment Message-ID: Changeset: da3d2da6 Author: mgronlun Date: 2022-03-22 16:41:58 +0000 URL: https://git.openjdk.java.net/loom/commit/da3d2da61ff512d356d1e56c8bfb2d8a13185a02 JFR: adjustment ! src/hotspot/share/jfr/recorder/repository/jfrEmergencyDump.cpp From coleenp at openjdk.java.net Tue Mar 22 15:49:47 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Tue, 22 Mar 2022 15:49:47 GMT Subject: RFR: Small fixes - shipment one In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 15:33:51 GMT, Robbin Ehn wrote: >> src/hotspot/share/runtime/continuation.cpp line 180: >> >>> 178: #define VERIFY_CONTINUATION(cont) verify_continuation((cont)) >>> 179: NOINLINE static bool verify_stack_chunk(oop chunk) { return InstanceStackChunkKlass::verify(chunk); } >>> 180: #define VERIFY_STACK_CHUNK(chunk) verify_stack_chunk((chunk)) >> >> Thanks for fixing this. I know Ron likes to see the asserts have a line number of the caller but there's a PR to fix this and almost all of use some debugger to see where the assert comes from in the call stack, if it's not already in the hs_err file. > > A better approach would be to print the line number in the assert: > > InstanceStackChunkKlass::verify(chunk, __LINE__); > The assert would be assert(good, "%u: ....", lineno, ....) ; I guess if the callers are different, you can tell by the caller which is why this is seldom something I've noticed or thought needed fixing. ------------- PR: https://git.openjdk.java.net/loom/pull/114 From eosterlund at openjdk.java.net Tue Mar 22 16:28:36 2022 From: eosterlund at openjdk.java.net (Erik =?UTF-8?B?w5ZzdGVybHVuZA==?=) Date: Tue, 22 Mar 2022 16:28:36 GMT Subject: RFR: Simplify G1CodeBlobClosure In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 08:16:29 GMT, Stefan Karlsson wrote: > There's no need to introduce a new _keepalive_is_strong property in the G1CodeBlobClosure. The existing _strong is set to true when the evacuation participates in the marking of the old gen, which is when we need to mark the nmethods as "maybe on continuation". The name _strong in this context is not great and it doesn't convey the actual meaning. Maybe something for a future G1 cleanup. Marked as reviewed by eosterlund (Committer). ------------- PR: https://git.openjdk.java.net/loom/pull/112 From eosterlund at openjdk.java.net Tue Mar 22 16:31:00 2022 From: eosterlund at openjdk.java.net (Erik =?UTF-8?B?w5ZzdGVybHVuZA==?=) Date: Tue, 22 Mar 2022 16:31:00 GMT Subject: RFR: Fix SerialGC bug in full_process_roots In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 09:10:01 GMT, Stefan Karlsson wrote: > There seems to have been an inadvertent change to argument to fix_relocations in full_process_roots. The bug doesn't cause any problems, it just calls an expensive operation (fix_oop_relocations) unnecessarily. Restore the old value. Marked as reviewed by eosterlund (Committer). ------------- PR: https://git.openjdk.java.net/loom/pull/113 From stefank at openjdk.java.net Tue Mar 22 16:31:01 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Tue, 22 Mar 2022 16:31:01 GMT Subject: Integrated: Fix SerialGC bug in full_process_roots In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 09:10:01 GMT, Stefan Karlsson wrote: > There seems to have been an inadvertent change to argument to fix_relocations in full_process_roots. The bug doesn't cause any problems, it just calls an expensive operation (fix_oop_relocations) unnecessarily. Restore the old value. This pull request has now been integrated. Changeset: 2aba64a8 Author: Stefan Karlsson Committer: Erik ?sterlund URL: https://git.openjdk.java.net/loom/commit/2aba64a8328e2dfb66b982621aff485c2acc94cd Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Fix SerialGC bug in full_process_roots Reviewed-by: tschatzl, eosterlund ------------- PR: https://git.openjdk.java.net/loom/pull/113 From eosterlund at openjdk.java.net Tue Mar 22 16:32:43 2022 From: eosterlund at openjdk.java.net (Erik =?UTF-8?B?w5ZzdGVybHVuZA==?=) Date: Tue, 22 Mar 2022 16:32:43 GMT Subject: RFR: 8282849: Loom: Fix minimal debug non-PCH build failure [v4] In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 01:32:14 GMT, Hao Sun wrote: >> As described in JBS-8282849, this build failure was introduced by commit >> bd25c94 and commit 4d27102. Adding the missing headers would fix it. > > Hao Sun has updated the pull request incrementally with one additional commit since the last revision: > > Revert the updates in instanceStackChunkKlass.cpp and javaClasses.inline.hpp > > The errors in file javaClasses.inline.hpp and file > instanceStackChunkKlass.cpp were fixed in commit > https://github.com/openjdk/loom/commit/970249d. > > We revert our previous updates in v1 in this patch. Marked as reviewed by eosterlund (Committer). ------------- PR: https://git.openjdk.java.net/loom/pull/99 From eosterlund at openjdk.java.net Tue Mar 22 16:37:43 2022 From: eosterlund at openjdk.java.net (Erik =?UTF-8?B?w5ZzdGVybHVuZA==?=) Date: Tue, 22 Mar 2022 16:37:43 GMT Subject: RFR: Small fixes - shipment one In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 14:18:42 GMT, Robbin Ehn wrote: > Reducing the number of variables, the number of assignment to each variable, white-spaces, renamed some variables, removed unnecessary template, etc... > Except the removal of template 'bottom', the code is the same. (assert is moved up one level) > > Passes 1-3 (no new failures) > It seem to be slightly faster than before, but at least on par. > > This is not complete at all, but to avoid merge conflict I want to ship, and also make someone happy about removing a template. Marked as reviewed by eosterlund (Committer). ------------- PR: https://git.openjdk.java.net/loom/pull/114 From eosterlund at openjdk.java.net Tue Mar 22 16:42:44 2022 From: eosterlund at openjdk.java.net (Erik =?UTF-8?B?w5ZzdGVybHVuZA==?=) Date: Tue, 22 Mar 2022 16:42:44 GMT Subject: RFR: Remove Config [v2] In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 07:47:31 GMT, Robbin Ehn wrote: >> For you to consider. >> - Adds 1-2ns (thaw+freeze) (<0.5%) >> - Passes t1-3 (no new issues found) >> - Reduces compilation time with over 30 seconds (15-20%). >> - Loom have the same compile time as vanilla jdk/jdk. > > Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'fibers' into templates > - Fixed jcheck WS error > - Remove Config Looks good. ------------- Marked as reviewed by eosterlund (Committer). PR: https://git.openjdk.java.net/loom/pull/110 From coleenp at openjdk.java.net Tue Mar 22 16:50:01 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Tue, 22 Mar 2022 16:50:01 GMT Subject: RFR: Move back BacktraceBuilder Message-ID: Just code motion to help with the review. Tested with build fastdebug, product and loom-tier1 to loom-tier3 (in progress) ------------- Commit messages: - Move back BacktraceBuilder Changes: https://git.openjdk.java.net/loom/pull/115/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=115&range=00 Stats: 445 lines in 1 file changed: 223 ins; 222 del; 0 mod Patch: https://git.openjdk.java.net/loom/pull/115.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/115/head:pull/115 PR: https://git.openjdk.java.net/loom/pull/115 From duke at openjdk.java.net Tue Mar 22 16:56:52 2022 From: duke at openjdk.java.net (duke) Date: Tue, 22 Mar 2022 16:56:52 GMT Subject: git: openjdk/loom: fibers: ThreadIdentifier to use cmpxchg for 64-bit values Message-ID: Changeset: b18e0e84 Author: mgronlun Date: 2022-03-22 17:54:40 +0000 URL: https://git.openjdk.java.net/loom/commit/b18e0e84a27c2f0118a6791576f91762dd9bfe46 ThreadIdentifier to use cmpxchg for 64-bit values ! src/hotspot/share/jfr/support/jfrThreadLocal.cpp ! src/hotspot/share/prims/jvm.cpp + src/hotspot/share/runtime/threadIdentifier.cpp + src/hotspot/share/runtime/threadIdentifier.hpp - src/hotspot/share/runtime/threadIdentifiers.cpp - src/hotspot/share/runtime/threadIdentifiers.hpp From tschatzl at openjdk.java.net Tue Mar 22 17:41:35 2022 From: tschatzl at openjdk.java.net (Thomas Schatzl) Date: Tue, 22 Mar 2022 17:41:35 GMT Subject: RFR: Move back BacktraceBuilder In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 16:43:40 GMT, Coleen Phillimore wrote: > Just code motion to help with the review. > Tested with build fastdebug, product and loom-tier1 to loom-tier3 (in progress) Marked as reviewed by tschatzl (no project role). ------------- PR: https://git.openjdk.java.net/loom/pull/115 From duke at openjdk.java.net Tue Mar 22 18:07:46 2022 From: duke at openjdk.java.net (duke) Date: Tue, 22 Mar 2022 18:07:46 GMT Subject: git: openjdk/loom: fibers: 4 new changesets Message-ID: <68411a2f-cd06-45a0-a4a1-1fb012b120a2@openjdk.java.net> Changeset: a3af3cdc Author: Ron Pressler Date: 2022-03-22 14:51:53 +0000 URL: https://git.openjdk.java.net/loom/commit/a3af3cdc39a3c917ae5e0bfee171a1a529bf4e38 - ! src/hotspot/share/runtime/continuation.cpp Changeset: 42ad3454 Author: Ron Pressler Date: 2022-03-22 14:52:31 +0000 URL: https://git.openjdk.java.net/loom/commit/42ad3454128d8ac360d0960001c22726951fa69a Initialize ConstantPoolCache::_marking_cycle ! src/hotspot/share/oops/cpCache.inline.hpp Changeset: 5c7fbbf0 Author: Ron Pressler Date: 2022-03-22 15:48:49 +0000 URL: https://git.openjdk.java.net/loom/commit/5c7fbbf0eb9c23ae53c00f94653773207b6eea7a Test for can_be_deoptimized() in CodeCache::make_marked_nmethods_deoptimized ! src/hotspot/share/code/codeCache.cpp Changeset: 857eb995 Author: Ron Pressler Date: 2022-03-22 15:49:05 +0000 URL: https://git.openjdk.java.net/loom/commit/857eb9951995e5157e235c091555debe8c7b03a4 use is_special_native_intrinsic() in Method::is_always_compilable() ! src/hotspot/share/oops/method.cpp From duke at openjdk.java.net Tue Mar 22 18:17:53 2022 From: duke at openjdk.java.net (duke) Date: Tue, 22 Mar 2022 18:17:53 GMT Subject: git: openjdk/loom: fibers: JFR: adjustment Message-ID: Changeset: 87a93c26 Author: mgronlun Date: 2022-03-22 19:15:41 +0000 URL: https://git.openjdk.java.net/loom/commit/87a93c267eac8fab2aef69c766f7594053801a84 JFR: adjustment ! src/hotspot/share/jfr/support/jfrThreadLocal.cpp From duke at openjdk.java.net Tue Mar 22 18:21:35 2022 From: duke at openjdk.java.net (duke) Date: Tue, 22 Mar 2022 18:21:35 GMT Subject: git: openjdk/loom: fibers: JFR: adjustment Message-ID: Changeset: 862a0b2c Author: mgronlun Date: 2022-03-22 19:21:02 +0000 URL: https://git.openjdk.java.net/loom/commit/862a0b2cca98acd5446eee29f0c18192bfd83af9 JFR: adjustment ! src/hotspot/share/jfr/support/jfrThreadLocal.cpp From duke at openjdk.java.net Tue Mar 22 18:39:53 2022 From: duke at openjdk.java.net (duke) Date: Tue, 22 Mar 2022 18:39:53 GMT Subject: git: openjdk/loom: fibers: JFR: hosting type Thread does not map to < 127, because all events are mapped before types Message-ID: <7129830c-7636-49da-81fa-567edb60882a@openjdk.java.net> Changeset: 0a95b707 Author: mgronlun Date: 2022-03-22 19:38:49 +0000 URL: https://git.openjdk.java.net/loom/commit/0a95b707e5654bdb33fdd7d2ad522df295534be3 JFR: hosting type Thread does not map to < 127, because all events are mapped before types ! src/hotspot/share/jfr/metadata/metadata.xml ! src/hotspot/share/jfr/support/jfrThreadLocal.cpp From coleenp at openjdk.java.net Tue Mar 22 18:41:48 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Tue, 22 Mar 2022 18:41:48 GMT Subject: RFR: Move back BacktraceBuilder In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 16:43:40 GMT, Coleen Phillimore wrote: > Just code motion to help with the review. > Tested with build fastdebug, product and loom-tier1 to loom-tier3 (in progress) Thanks Thomas. ------------- PR: https://git.openjdk.java.net/loom/pull/115 From coleenp at openjdk.java.net Tue Mar 22 18:45:37 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Tue, 22 Mar 2022 18:45:37 GMT Subject: Integrated: Move back BacktraceBuilder In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 16:43:40 GMT, Coleen Phillimore wrote: > Just code motion to help with the review. > Tested with build fastdebug, product and loom-tier1 to loom-tier3 (in progress) This pull request has now been integrated. Changeset: 96e5a7c2 Author: Coleen Phillimore URL: https://git.openjdk.java.net/loom/commit/96e5a7c26ed3e8fa1759633bbbaa8db288f99af9 Stats: 445 lines in 1 file changed: 223 ins; 222 del; 0 mod Move back BacktraceBuilder Reviewed-by: tschatzl ------------- PR: https://git.openjdk.java.net/loom/pull/115 From haosun at openjdk.java.net Tue Mar 22 19:50:43 2022 From: haosun at openjdk.java.net (Hao Sun) Date: Tue, 22 Mar 2022 19:50:43 GMT Subject: RFR: 8282849: Loom: Fix minimal debug non-PCH build failure [v4] In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 01:32:14 GMT, Hao Sun wrote: >> As described in JBS-8282849, this build failure was introduced by commit >> bd25c94 and commit 4d27102. Adding the missing headers would fix it. > > Hao Sun has updated the pull request incrementally with one additional commit since the last revision: > > Revert the updates in instanceStackChunkKlass.cpp and javaClasses.inline.hpp > > The errors in file javaClasses.inline.hpp and file > instanceStackChunkKlass.cpp were fixed in commit > https://github.com/openjdk/loom/commit/970249d. > > We revert our previous updates in v1 in this patch. Thanks for your reviews! ------------- PR: https://git.openjdk.java.net/loom/pull/99 From duke at openjdk.java.net Tue Mar 22 21:11:53 2022 From: duke at openjdk.java.net (duke) Date: Tue, 22 Mar 2022 21:11:53 GMT Subject: git: openjdk/loom: fibers: JFR: subtle time function pointer address change in refactoring Message-ID: Changeset: c4b95611 Author: mgronlun Date: 2022-03-22 22:03:43 +0000 URL: https://git.openjdk.java.net/loom/commit/c4b95611bda651e927ea4568d428733acba6178b JFR: subtle time function pointer address change in refactoring ! src/hotspot/share/c1/c1_LIRGenerator.cpp ! src/hotspot/share/c1/c1_Runtime1.cpp ! src/hotspot/share/opto/library_call.cpp From haosun at openjdk.java.net Wed Mar 23 00:03:56 2022 From: haosun at openjdk.java.net (Hao Sun) Date: Wed, 23 Mar 2022 00:03:56 GMT Subject: RFR: 8282849: Loom: Fix minimal debug non-PCH build failure [v4] In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 01:32:14 GMT, Hao Sun wrote: >> As described in JBS-8282849, this build failure was introduced by commit >> bd25c94 and commit 4d27102. Adding the missing headers would fix it. > > Hao Sun has updated the pull request incrementally with one additional commit since the last revision: > > Revert the updates in instanceStackChunkKlass.cpp and javaClasses.inline.hpp > > The errors in file javaClasses.inline.hpp and file > instanceStackChunkKlass.cpp were fixed in commit > https://github.com/openjdk/loom/commit/970249d. > > We revert our previous updates in v1 in this patch. As noted by `jcheck`, the update in file `copyFailedInfo.hpp` has already been done in the `fibers` branch via commit https://github.com/openjdk/loom/commit/41d4ba55c Besides, I further checked in my local environment that the `minimal` build can pass now with the latest code in `fibers` branch. Hence, I'd like to close this PR. Many thanks to all the reviewers anyway. ------------- PR: https://git.openjdk.java.net/loom/pull/99 From haosun at openjdk.java.net Wed Mar 23 00:03:57 2022 From: haosun at openjdk.java.net (Hao Sun) Date: Wed, 23 Mar 2022 00:03:57 GMT Subject: Withdrawn: 8282849: Loom: Fix minimal debug non-PCH build failure In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 12:32:37 GMT, Hao Sun wrote: > As described in JBS-8282849, this build failure was introduced by commit > bd25c94 and commit 4d27102. Adding the missing headers would fix it. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/loom/pull/99 From haosun at openjdk.java.net Wed Mar 23 01:57:19 2022 From: haosun at openjdk.java.net (Hao Sun) Date: Wed, 23 Mar 2022 01:57:19 GMT Subject: RFR: 8282792: Loom: Fix optimized build after commit 4d2710 [v2] In-Reply-To: References: Message-ID: > In commit 4d2710[1], one invocation of function print_frames() is moved > from condition `!PRODUCT` to condition `ASSERT`. As a result, all the > usages are now under condition `ASSERT`, leading to the compilation > warning "unused-function" in optimized VM build. > > Hence, in this patch, we move the defintion of function print_frames() > to condition `ASSERT`. > > [1] https://github.com/openjdk/loom/commit/4d2710#diff-74c5a41cb3476b29151b4a13732cf4756879de0aa1b1d8c4d73c38e570413fcfR2851 Hao Sun has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge branch 'fibers' into optimized-build - 8282792: Loom: Fix optimized build after commit 4d2710 In commit 4d2710[1], one invocation of function print_frames() is moved from condition `!PRODUCT` to condition `ASSERT`. As a result, all the usages are now under condition `ASSERT`, leading to the compilation warning "unused-function" in optimized VM build. Hence, in this patch, we move the defintion of function print_frames() to condition `ASSERT`. [1] https://github.com/openjdk/loom/commit/4d2710#diff-74c5a41cb3476b29151b4a13732cf4756879de0aa1b1d8c4d73c38e570413fcfR2851 ------------- Changes: https://git.openjdk.java.net/loom/pull/98/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=98&range=01 Stats: 52 lines in 1 file changed: 25 ins; 27 del; 0 mod Patch: https://git.openjdk.java.net/loom/pull/98.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/98/head:pull/98 PR: https://git.openjdk.java.net/loom/pull/98 From eosterlund at openjdk.java.net Wed Mar 23 05:57:48 2022 From: eosterlund at openjdk.java.net (Erik =?UTF-8?B?w5ZzdGVybHVuZA==?=) Date: Wed, 23 Mar 2022 05:57:48 GMT Subject: RFR: 8282792: Loom: Fix optimized build after commit 4d2710 [v2] In-Reply-To: References: Message-ID: On Wed, 23 Mar 2022 01:57:19 GMT, Hao Sun wrote: >> In commit 4d2710[1], one invocation of function print_frames() is moved >> from condition `!PRODUCT` to condition `ASSERT`. As a result, all the >> usages are now under condition `ASSERT`, leading to the compilation >> warning "unused-function" in optimized VM build. >> >> Hence, in this patch, we move the defintion of function print_frames() >> to condition `ASSERT`. >> >> [1] https://github.com/openjdk/loom/commit/4d2710#diff-74c5a41cb3476b29151b4a13732cf4756879de0aa1b1d8c4d73c38e570413fcfR2851 > > Hao Sun has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: > > - Merge branch 'fibers' into optimized-build > - 8282792: Loom: Fix optimized build after commit 4d2710 > > In commit 4d2710[1], one invocation of function print_frames() is moved > from condition `!PRODUCT` to condition `ASSERT`. As a result, all the > usages are now under condition `ASSERT`, leading to the compilation > warning "unused-function" in optimized VM build. > > Hence, in this patch, we move the defintion of function print_frames() > to condition `ASSERT`. > > [1] https://github.com/openjdk/loom/commit/4d2710#diff-74c5a41cb3476b29151b4a13732cf4756879de0aa1b1d8c4d73c38e570413fcfR2851 Marked as reviewed by eosterlund (Committer). ------------- PR: https://git.openjdk.java.net/loom/pull/98 From stefank at openjdk.java.net Wed Mar 23 08:40:37 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Wed, 23 Mar 2022 08:40:37 GMT Subject: Integrated: Simplify G1CodeBlobClosure In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 08:16:29 GMT, Stefan Karlsson wrote: > There's no need to introduce a new _keepalive_is_strong property in the G1CodeBlobClosure. The existing _strong is set to true when the evacuation participates in the marking of the old gen, which is when we need to mark the nmethods as "maybe on continuation". The name _strong in this context is not great and it doesn't convey the actual meaning. Maybe something for a future G1 cleanup. This pull request has now been integrated. Changeset: 61d79b2c Author: Stefan Karlsson Committer: Erik ?sterlund URL: https://git.openjdk.java.net/loom/commit/61d79b2c080bbcb9fb4cdb1bd5df5af094d1f2e7 Stats: 12 lines in 4 files changed: 0 ins; 3 del; 9 mod Simplify G1CodeBlobClosure Reviewed-by: tschatzl, eosterlund ------------- PR: https://git.openjdk.java.net/loom/pull/112 From duke at openjdk.java.net Wed Mar 23 09:04:48 2022 From: duke at openjdk.java.net (duke) Date: Wed, 23 Mar 2022 09:04:48 GMT Subject: git: openjdk/loom: fibers: adjust JvmtiVTMTDisabler traps to avoid timeouts in Kitchensink Message-ID: <9a7255f1-285d-48ba-a80a-db7e950b12e7@openjdk.java.net> Changeset: c9d15b56 Author: Serguei Spitsyn Date: 2022-03-23 09:03:39 +0000 URL: https://git.openjdk.java.net/loom/commit/c9d15b56dd3dd11830d06c2aa898ee03cf3a0452 adjust JvmtiVTMTDisabler traps to avoid timeouts in Kitchensink ! src/hotspot/share/prims/jvmtiThreadState.cpp From tschatzl at openjdk.java.net Wed Mar 23 09:16:24 2022 From: tschatzl at openjdk.java.net (Thomas Schatzl) Date: Wed, 23 Mar 2022 09:16:24 GMT Subject: RFR: Garbage collectors explicitly transform stack chunk Message-ID: Hi all, can I have reviews for this change that makes garbage collectors explicitly transform stack chunks instead of relying on magic happening in `InstanceStackChunkKlass::copy_dis/conjoint`. It also contains some refactoring suggested by @stefank in `Generation::promote`. Other than that it is a fairly straightforward change to replace `InstanceStackChunkKlass::copy_dis/conjoint` calls with explicit calls to `Copy::aligned_dis/conjoint_words` and `ContinuationGCSupport::transform_stack_chunk`. This reduces code, and makes the code more understandable. Test: tier1-5 Thanks, Thomas ------------- Commit messages: - undo assumption that stackchunks are not humongous - Clenaup - eriko "review" comments - Initial version Changes: https://git.openjdk.java.net/loom/pull/116/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=116&range=00 Stats: 133 lines in 18 files changed: 27 ins; 84 del; 22 mod Patch: https://git.openjdk.java.net/loom/pull/116.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/116/head:pull/116 PR: https://git.openjdk.java.net/loom/pull/116 From stefank at openjdk.java.net Wed Mar 23 09:28:53 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Wed, 23 Mar 2022 09:28:53 GMT Subject: RFR: Garbage collectors explicitly transform stack chunk In-Reply-To: References: Message-ID: On Wed, 23 Mar 2022 09:09:36 GMT, Thomas Schatzl wrote: > Hi all, > > can I have reviews for this change that makes garbage collectors explicitly transform stack chunks instead of relying on magic happening in `InstanceStackChunkKlass::copy_dis/conjoint`. > > It also contains some refactoring suggested by @stefank in `Generation::promote`. Other than that it is a fairly straightforward change to replace `InstanceStackChunkKlass::copy_dis/conjoint` calls with explicit calls to `Copy::aligned_dis/conjoint_words` and `ContinuationGCSupport::transform_stack_chunk`. > > This reduces code, and makes the code more understandable. > > Test: tier1-5 > > Thanks, > Thomas Marked as reviewed by stefank (no project role). ------------- PR: https://git.openjdk.java.net/loom/pull/116 From duke at openjdk.java.net Wed Mar 23 10:25:33 2022 From: duke at openjdk.java.net (duke) Date: Wed, 23 Mar 2022 10:25:33 GMT Subject: git: openjdk/loom: fibers: fix one more root cause to hang in GetSetLocalTest Message-ID: <5a751a8f-5a99-4e94-aef7-78cb9dd7a33a@openjdk.java.net> Changeset: dee63e36 Author: Serguei Spitsyn Date: 2022-03-23 10:23:22 +0000 URL: https://git.openjdk.java.net/loom/commit/dee63e363b592c800bfdf8efb8f4295220e8948c fix one more root cause to hang in GetSetLocalTest ! test/hotspot/jtreg/serviceability/jvmti/vthread/GetSetLocalTest/GetSetLocalTest.java From stefank at openjdk.java.net Wed Mar 23 10:52:14 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Wed, 23 Mar 2022 10:52:14 GMT Subject: RFR: Use single-condition instance type checks Message-ID: Loom requires specialized code for stackChunks objects when marking/copying objects. This adds extra checks for every visited object. The current implementation checks both the layout helper, then checks the _kind flag. I suggest that we reimplement this as a single check against the Klass::_id field. This change would probably be a good cleanup for the mainline. ------------- Commit messages: - Use single-condition instance type checks Changes: https://git.openjdk.java.net/loom/pull/118/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=118&range=00 Stats: 79 lines in 15 files changed: 4 ins; 33 del; 42 mod Patch: https://git.openjdk.java.net/loom/pull/118.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/118/head:pull/118 PR: https://git.openjdk.java.net/loom/pull/118 From eosterlund at openjdk.java.net Wed Mar 23 11:02:51 2022 From: eosterlund at openjdk.java.net (Erik =?UTF-8?B?w5ZzdGVybHVuZA==?=) Date: Wed, 23 Mar 2022 11:02:51 GMT Subject: RFR: Garbage collectors explicitly transform stack chunk In-Reply-To: References: Message-ID: On Wed, 23 Mar 2022 09:09:36 GMT, Thomas Schatzl wrote: > Hi all, > > can I have reviews for this change that makes garbage collectors explicitly transform stack chunks instead of relying on magic happening in `InstanceStackChunkKlass::copy_dis/conjoint`. > > It also contains some refactoring suggested by @stefank in `Generation::promote`. Other than that it is a fairly straightforward change to replace `InstanceStackChunkKlass::copy_dis/conjoint` calls with explicit calls to `Copy::aligned_dis/conjoint_words` and `ContinuationGCSupport::transform_stack_chunk`. > > This reduces code, and makes the code more understandable. > > Test: tier1-5 > > Thanks, > Thomas Looks good. ------------- Marked as reviewed by eosterlund (Committer). PR: https://git.openjdk.java.net/loom/pull/116 From duke at openjdk.java.net Wed Mar 23 11:07:05 2022 From: duke at openjdk.java.net (duke) Date: Wed, 23 Mar 2022 11:07:05 GMT Subject: git: openjdk/loom: fibers: Revert "Initialize ConstantPoolCache::_marking_cycle" Message-ID: Changeset: f31cc985 Author: mgronlun Date: 2022-03-23 12:00:26 +0000 URL: https://git.openjdk.java.net/loom/commit/f31cc985f70fad1cfbcac1f42bab1b2468e538cf Revert "Initialize ConstantPoolCache::_marking_cycle" This reverts commit 42ad3454128d8ac360d0960001c22726951fa69a. It caused also scratch classes to be unloading, reporting getting multiple instances of the same class. ! src/hotspot/share/oops/cpCache.inline.hpp From eosterlund at openjdk.java.net Wed Mar 23 11:26:48 2022 From: eosterlund at openjdk.java.net (Erik =?UTF-8?B?w5ZzdGVybHVuZA==?=) Date: Wed, 23 Mar 2022 11:26:48 GMT Subject: RFR: Use single-condition instance type checks In-Reply-To: References: Message-ID: On Wed, 23 Mar 2022 10:41:41 GMT, Stefan Karlsson wrote: > Loom requires specialized code for stackChunks objects when marking/copying objects. This adds extra checks for every visited object. The current implementation checks both the layout helper, then checks the _kind flag. I suggest that we reimplement this as a single check against the Klass::_id field. > > This change would probably be a good cleanup for the mainline. Looks good. ------------- Marked as reviewed by eosterlund (Committer). PR: https://git.openjdk.java.net/loom/pull/118 From tschatzl at openjdk.java.net Wed Mar 23 11:30:50 2022 From: tschatzl at openjdk.java.net (Thomas Schatzl) Date: Wed, 23 Mar 2022 11:30:50 GMT Subject: RFR: Use single-condition instance type checks In-Reply-To: References: Message-ID: On Wed, 23 Mar 2022 10:41:41 GMT, Stefan Karlsson wrote: > Loom requires specialized code for stackChunks objects when marking/copying objects. This adds extra checks for every visited object. The current implementation checks both the layout helper, then checks the _kind flag. I suggest that we reimplement this as a single check against the Klass::_id field. > > This change would probably be a good cleanup for the mainline. Marked as reviewed by tschatzl (no project role). ------------- PR: https://git.openjdk.java.net/loom/pull/118 From coleenp at openjdk.java.net Wed Mar 23 11:57:41 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Wed, 23 Mar 2022 11:57:41 GMT Subject: RFR: Use single-condition instance type checks In-Reply-To: References: Message-ID: On Wed, 23 Mar 2022 10:41:41 GMT, Stefan Karlsson wrote: > Loom requires specialized code for stackChunks objects when marking/copying objects. This adds extra checks for every visited object. The current implementation checks both the layout helper, then checks the _kind flag. I suggest that we reimplement this as a single check against the Klass::_id field. > > This change would probably be a good cleanup for the mainline. This is good. ------------- Marked as reviewed by coleenp (Committer). PR: https://git.openjdk.java.net/loom/pull/118 From tschatzl at openjdk.java.net Wed Mar 23 15:25:55 2022 From: tschatzl at openjdk.java.net (Thomas Schatzl) Date: Wed, 23 Mar 2022 15:25:55 GMT Subject: RFR: Garbage collectors explicitly transform stack chunk In-Reply-To: References: Message-ID: On Wed, 23 Mar 2022 09:25:05 GMT, Stefan Karlsson wrote: >> Hi all, >> >> can I have reviews for this change that makes garbage collectors explicitly transform stack chunks instead of relying on magic happening in `InstanceStackChunkKlass::copy_dis/conjoint`. >> >> It also contains some refactoring suggested by @stefank in `Generation::promote`. Other than that it is a fairly straightforward change to replace `InstanceStackChunkKlass::copy_dis/conjoint` calls with explicit calls to `Copy::aligned_dis/conjoint_words` and `ContinuationGCSupport::transform_stack_chunk`. >> >> This reduces code, and makes the code more understandable. >> >> Test: tier1-5 >> >> Thanks, >> Thomas > > Marked as reviewed by stefank (no project role). Thanks @stefank @fisk for your reviews ------------- PR: https://git.openjdk.java.net/loom/pull/116 From duke at openjdk.java.net Wed Mar 23 18:06:21 2022 From: duke at openjdk.java.net (duke) Date: Wed, 23 Mar 2022 18:06:21 GMT Subject: git: openjdk/loom: fibers: JFR: write names of JVM threads unconditionally Message-ID: Changeset: b28d0f5c Author: mgronlun Date: 2022-03-23 19:05:08 +0000 URL: https://git.openjdk.java.net/loom/commit/b28d0f5ced817be25cddce43028c3330d461aa49 JFR: write names of JVM threads unconditionally ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrType.cpp From duke at openjdk.java.net Wed Mar 23 19:00:52 2022 From: duke at openjdk.java.net (duke) Date: Wed, 23 Mar 2022 19:00:52 GMT Subject: git: openjdk/loom: fibers: fix 8283586 - need a longer sleep time. Message-ID: Changeset: 3b64b706 Author: Chris Plummer Date: 2022-03-23 18:59:38 +0000 URL: https://git.openjdk.java.net/loom/commit/3b64b706426cd3e0739f3bd4c579f5e7114ac322 fix 8283586 - need a longer sleep time. ! test/hotspot/jtreg/vmTestbase/nsk/jdb/kill/kill001/kill001a.java From duke at openjdk.java.net Wed Mar 23 19:18:20 2022 From: duke at openjdk.java.net (duke) Date: Wed, 23 Mar 2022 19:18:20 GMT Subject: git: openjdk/loom: fibers: adjust GetSetLocalTest shutdown Message-ID: Changeset: 90c3c405 Author: Serguei Spitsyn Date: 2022-03-23 19:17:13 +0000 URL: https://git.openjdk.java.net/loom/commit/90c3c4057fcccb4758b6bb73d4c0893c3e4cb788 adjust GetSetLocalTest shutdown ! test/hotspot/jtreg/serviceability/jvmti/vthread/GetSetLocalTest/GetSetLocalTest.java From stefank at openjdk.java.net Wed Mar 23 19:32:51 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Wed, 23 Mar 2022 19:32:51 GMT Subject: RFR: Loom cleanups In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 09:20:19 GMT, Stefan Karlsson wrote: > Various cleanups and restructuring. Closed, since all the changes were pushed outside of this PR. ------------- PR: https://git.openjdk.java.net/loom/pull/108 From stefank at openjdk.java.net Wed Mar 23 19:32:52 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Wed, 23 Mar 2022 19:32:52 GMT Subject: Withdrawn: Loom cleanups In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 09:20:19 GMT, Stefan Karlsson wrote: > Various cleanups and restructuring. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/loom/pull/108 From duke at openjdk.java.net Wed Mar 23 19:36:44 2022 From: duke at openjdk.java.net (duke) Date: Wed, 23 Mar 2022 19:36:44 GMT Subject: git: openjdk/loom: fibers: 4 new changesets Message-ID: <46d1f99a-bc24-4ed8-b23c-4418568711e8@openjdk.java.net> Changeset: c885b51f Author: Ron Pressler Date: 2022-03-22 20:08:15 +0000 URL: https://git.openjdk.java.net/loom/commit/c885b51fccd1605b881b726e99aca42bc719d56a Comments ! src/hotspot/share/runtime/continuation.hpp Changeset: e90fdfd2 Author: Erik ?sterlund Committer: Ron Pressler Date: 2022-03-22 15:22:11 +0000 URL: https://git.openjdk.java.net/loom/commit/e90fdfd2e996563646337d1ce7ecf9a04d452ae9 Clean up C2 AArch64 post call nop code ! src/hotspot/cpu/aarch64/aarch64.ad Changeset: 6d26c74a Author: Erik ?sterlund Committer: Ron Pressler Date: 2022-03-23 12:07:47 +0000 URL: https://git.openjdk.java.net/loom/commit/6d26c74a1e3b32f54c33cc8682c810f9d55f2a88 Resolve sweeper deadlock ! src/hotspot/share/code/compiledMethod.cpp Changeset: 11ebec78 Author: Erik ?sterlund Committer: Ron Pressler Date: 2022-03-23 15:02:22 +0000 URL: https://git.openjdk.java.net/loom/commit/11ebec7884b8cb4d5391802f6396c8dc94e1bfaf Take CodeCache_lock ! src/hotspot/share/code/compiledMethod.cpp From duke at openjdk.java.net Wed Mar 23 20:49:35 2022 From: duke at openjdk.java.net (duke) Date: Wed, 23 Mar 2022 20:49:35 GMT Subject: git: openjdk/loom: fibers: failure_handler updated to use JavaThread.dump Message-ID: Changeset: b9a37d51 Author: lmesnik Date: 2022-03-23 14:48:21 +0000 URL: https://git.openjdk.java.net/loom/commit/b9a37d5131039eb7b9bedf024ff52a3560fa6d13 failure_handler updated to use JavaThread.dump ! test/failure_handler/src/share/conf/common.properties From rehn at openjdk.java.net Mon Mar 21 14:09:11 2022 From: rehn at openjdk.java.net (Robbin Ehn) Date: Mon, 21 Mar 2022 14:09:11 GMT Subject: RFR: Remove Config Message-ID: For you to consider. - Adds 1-2ns (thaw+freeze) (<0.5%) - Passes t1-3 (no new issues found) - Reduces compilation time with over 30 seconds (15-20%). - Loom have the same compile time as vanilla jdk/jdk. ------------- Commit messages: - Fixed jcheck WS error - Remove Config Changes: https://git.openjdk.java.net/loom/pull/110/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=110&range=00 Stats: 288 lines in 11 files changed: 7 ins; 167 del; 114 mod Patch: https://git.openjdk.java.net/loom/pull/110.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/110/head:pull/110 PR: https://git.openjdk.java.net/loom/pull/110 From rehn at openjdk.java.net Tue Mar 22 07:47:31 2022 From: rehn at openjdk.java.net (Robbin Ehn) Date: Tue, 22 Mar 2022 07:47:31 GMT Subject: RFR: Remove Config [v2] In-Reply-To: References: Message-ID: > For you to consider. > - Adds 1-2ns (thaw+freeze) (<0.5%) > - Passes t1-3 (no new issues found) > - Reduces compilation time with over 30 seconds (15-20%). > - Loom have the same compile time as vanilla jdk/jdk. Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'fibers' into templates - Fixed jcheck WS error - Remove Config ------------- Changes: - all: https://git.openjdk.java.net/loom/pull/110/files - new: https://git.openjdk.java.net/loom/pull/110/files/a023a127..07af4de3 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=loom&pr=110&range=01 - incr: https://webrevs.openjdk.java.net/?repo=loom&pr=110&range=00-01 Stats: 5347 lines in 369 files changed: 2615 ins; 737 del; 1995 mod Patch: https://git.openjdk.java.net/loom/pull/110.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/110/head:pull/110 PR: https://git.openjdk.java.net/loom/pull/110 From rehn at openjdk.java.net Tue Mar 22 14:27:15 2022 From: rehn at openjdk.java.net (Robbin Ehn) Date: Tue, 22 Mar 2022 14:27:15 GMT Subject: RFR: Small fixes - shipment one Message-ID: Reducing the number of variables, the number of assignment to each variable, white-spaces, renamed some variables, removed unnecessary template, etc... Except the removal of template 'bottom', the code is the same. (assert is moved up one level) Passes 1-3 (no new failures) It seem to be slightly faster than before, but at least on par. This is not complete at all, but to avoid merge conflict I want to ship, and also make someone happy about removing a template. ------------- Commit messages: - Reverted wrong accidential change - Fixed assert on uninit var - Removed unused template - Rename, whitespace, brackets, assignment - Removed unused variable - Use chunk sp directly in if statement - Renamed some variables - Don't cache _cont.argsize() - Fixed init_chunk - Single if bail-out fast path failure - ... and 6 more: https://git.openjdk.java.net/loom/compare/16e4713c...475d195a Changes: https://git.openjdk.java.net/loom/pull/114/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=114&range=00 Stats: 134 lines in 7 files changed: 19 ins; 27 del; 88 mod Patch: https://git.openjdk.java.net/loom/pull/114.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/114/head:pull/114 PR: https://git.openjdk.java.net/loom/pull/114 From rehn at openjdk.java.net Tue Mar 22 15:12:58 2022 From: rehn at openjdk.java.net (Robbin Ehn) Date: Tue, 22 Mar 2022 15:12:58 GMT Subject: RFR: Small fixes - shipment one In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 14:48:34 GMT, Coleen Phillimore wrote: >> Reducing the number of variables, the number of assignment to each variable, white-spaces, renamed some variables, removed unnecessary template, etc... >> Except the removal of template 'bottom', the code is the same. (assert is moved up one level) >> >> Passes 1-3 (no new failures) >> It seem to be slightly faster than before, but at least on par. >> >> This is not complete at all, but to avoid merge conflict I want to ship, and also make someone happy about removing a template. > > src/hotspot/share/runtime/continuation.cpp line 1847: > >> 1845: assert((intptr_t)chunk->start_address() % 8 == 0, ""); >> 1846: >> 1847: init_chunk(chunk); > > I tried taking this out as an experiment because I thought after Java heap allocation, it would be already zeroed, but it wasn't. Yes, the allocation returns memory without zeroing it. ------------- PR: https://git.openjdk.java.net/loom/pull/114 From rehn at openjdk.java.net Tue Mar 22 15:30:04 2022 From: rehn at openjdk.java.net (Robbin Ehn) Date: Tue, 22 Mar 2022 15:30:04 GMT Subject: RFR: Small fixes - shipment one In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 14:51:53 GMT, Coleen Phillimore wrote: >> Reducing the number of variables, the number of assignment to each variable, white-spaces, renamed some variables, removed unnecessary template, etc... >> Except the removal of template 'bottom', the code is the same. (assert is moved up one level) >> >> Passes 1-3 (no new failures) >> It seem to be slightly faster than before, but at least on par. >> >> This is not complete at all, but to avoid merge conflict I want to ship, and also make someone happy about removing a template. > > src/hotspot/share/runtime/continuation.cpp line 1213: > >> 1211: >> 1212: chunk = allocate_chunk(cont_size + ContinuationHelper::frame_metadata); >> 1213: if (UNLIKELY(chunk == nullptr || !_thread->cont_fastpath() || _barriers)) { // OOME/probably humongous > > This is just a strange set of conditions. Why would you allocate_chunk if _thread->cont_fastpath() is false? or _barriers, whatever that means. Really don't expect a function like allocate_chunk to have side effects. > Maybe in the latter two conditions, you still want to zero out the chunk in the tail and don't want to remove this. The variable _barriers is set by allocate_chunk, so it must be check afterwards. If allocation safepoints and there is JVM TI qeury it can 'remove' us as available for fastpath. If allocation fails due to OOME. The init_chunk() should always zero enought. ------------- PR: https://git.openjdk.java.net/loom/pull/114 From rehn at openjdk.java.net Tue Mar 22 15:38:02 2022 From: rehn at openjdk.java.net (Robbin Ehn) Date: Tue, 22 Mar 2022 15:38:02 GMT Subject: RFR: Small fixes - shipment one In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 14:33:12 GMT, Coleen Phillimore wrote: >> Reducing the number of variables, the number of assignment to each variable, white-spaces, renamed some variables, removed unnecessary template, etc... >> Except the removal of template 'bottom', the code is the same. (assert is moved up one level) >> >> Passes 1-3 (no new failures) >> It seem to be slightly faster than before, but at least on par. >> >> This is not complete at all, but to avoid merge conflict I want to ship, and also make someone happy about removing a template. > > src/hotspot/share/runtime/continuation.cpp line 180: > >> 178: #define VERIFY_CONTINUATION(cont) verify_continuation((cont)) >> 179: NOINLINE static bool verify_stack_chunk(oop chunk) { return InstanceStackChunkKlass::verify(chunk); } >> 180: #define VERIFY_STACK_CHUNK(chunk) verify_stack_chunk((chunk)) > > Thanks for fixing this. I know Ron likes to see the asserts have a line number of the caller but there's a PR to fix this and almost all of use some debugger to see where the assert comes from in the call stack, if it's not already in the hs_err file. A better approach would be to print the line number in the assert: InstanceStackChunkKlass::verify(chunk, __LINE__); The assert would be assert(good, "%u: ....", lineno, ....) ; > src/hotspot/share/runtime/continuation.cpp line 1160: > >> 1158: // properties of the continuation on the stack; all sizes are in words >> 1159: intptr_t* const stack_top = top_sp + ContinuationHelper::frame_metadata; >> 1160: const int stack_argsize = _cont.argsize(); > > I like this spelled out in the places it's used. I wonder if _cont.argsize() is the stacksize of the stack chunk oops. There are no comments really what it is. > cont_size seems to be the stack size of the entire continuation, ie the sum of all the stack chunk oops? Dunno. We're going to need some comments. _cont argsize is normally: inline int StackChunkFrameStream::stack_argsize() But it depends what we mean, a single intepreted frame must have the args from caller to be mounted. But if caller is already mounted we already have those arguments. ------------- PR: https://git.openjdk.java.net/loom/pull/114 From rehn at openjdk.java.net Tue Mar 22 17:17:02 2022 From: rehn at openjdk.java.net (Robbin Ehn) Date: Tue, 22 Mar 2022 17:17:02 GMT Subject: RFR: Remove Config [v3] In-Reply-To: References: Message-ID: > For you to consider. > - Adds 1-2ns (thaw+freeze) (<0.5%) > - Passes t1-3 (no new issues found) > - Reduces compilation time with over 30 seconds (15-20%). > - Loom have the same compile time as vanilla jdk/jdk. Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: - Merge branch 'fibers' into templates - Merge branch 'fibers' into templates - Fixed jcheck WS error - Remove Config ------------- Changes: https://git.openjdk.java.net/loom/pull/110/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=110&range=02 Stats: 282 lines in 11 files changed: 7 ins; 161 del; 114 mod Patch: https://git.openjdk.java.net/loom/pull/110.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/110/head:pull/110 PR: https://git.openjdk.java.net/loom/pull/110 From rehn at openjdk.java.net Tue Mar 22 17:22:41 2022 From: rehn at openjdk.java.net (Robbin Ehn) Date: Tue, 22 Mar 2022 17:22:41 GMT Subject: Integrated: Small fixes - shipment one In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 14:18:42 GMT, Robbin Ehn wrote: > Reducing the number of variables, the number of assignment to each variable, white-spaces, renamed some variables, removed unnecessary template, etc... > Except the removal of template 'bottom', the code is the same. (assert is moved up one level) > > Passes 1-3 (no new failures) > It seem to be slightly faster than before, but at least on par. > > This is not complete at all, but to avoid merge conflict I want to ship, and also make someone happy about removing a template. This pull request has now been integrated. Changeset: 18ab1a68 Author: Robbin Ehn URL: https://git.openjdk.java.net/loom/commit/18ab1a68994e235545d9a334407c8c00499a63be Stats: 134 lines in 7 files changed: 19 ins; 27 del; 88 mod Small fixes - shipment one Reviewed-by: coleenp, eosterlund ------------- PR: https://git.openjdk.java.net/loom/pull/114 From rehn at openjdk.java.net Tue Mar 22 17:39:06 2022 From: rehn at openjdk.java.net (Robbin Ehn) Date: Tue, 22 Mar 2022 17:39:06 GMT Subject: RFR: Remove Config [v4] In-Reply-To: References: Message-ID: > For you to consider. > - Adds 1-2ns (thaw+freeze) (<0.5%) > - Passes t1-3 (no new issues found) > - Reduces compilation time with over 30 seconds (15-20%). > - Loom have the same compile time as vanilla jdk/jdk. Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: - Merge branch 'fibers' into templates - Merge branch 'fibers' into templates - Merge branch 'fibers' into templates - Fixed jcheck WS error - Remove Config ------------- Changes: https://git.openjdk.java.net/loom/pull/110/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=110&range=03 Stats: 282 lines in 11 files changed: 7 ins; 161 del; 114 mod Patch: https://git.openjdk.java.net/loom/pull/110.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/110/head:pull/110 PR: https://git.openjdk.java.net/loom/pull/110 From enikitin at openjdk.java.net Wed Mar 23 09:58:08 2022 From: enikitin at openjdk.java.net (Evgeny Nikitin) Date: Wed, 23 Mar 2022 09:58:08 GMT Subject: RFR: JcstressRunner: remove artifact version duplication Message-ID: Tiny style-related fix: allows for modifying the artifact version in only one line. Testing: some Jcstress tests using that Runner were run locally. ------------- Commit messages: - JcstressRunner: remove artifact version duplication Changes: https://git.openjdk.java.net/loom/pull/117/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=117&range=00 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/loom/pull/117.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/117/head:pull/117 PR: https://git.openjdk.java.net/loom/pull/117 From duke at openjdk.java.net Thu Mar 24 01:12:29 2022 From: duke at openjdk.java.net (duke) Date: Thu, 24 Mar 2022 01:12:29 GMT Subject: git: openjdk/loom: fibers: Refactor Freeze and Thaw classes Message-ID: Changeset: 01f58a1d Author: Ron Pressler Date: 2022-03-24 00:28:57 +0000 URL: https://git.openjdk.java.net/loom/commit/01f58a1df175edd0840200d38219479d37642baf Refactor Freeze and Thaw classes ! src/hotspot/cpu/aarch64/continuation_aarch64.inline.hpp ! src/hotspot/cpu/x86/continuation_x86.inline.hpp ! src/hotspot/share/runtime/continuation.cpp From stefank at openjdk.java.net Thu Mar 24 07:14:22 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Thu, 24 Mar 2022 07:14:22 GMT Subject: RFR: Loom checked stack chunk casts Message-ID: Replace raw oop to stackChunkOops casts with calls to a ::cast function which asserts that the oops is a stackChunkOop. This is similar to what we do for other types like *Klass, *CollectedHeap, *Thread, ... Given that we assert when converting oops to stackChunkOops, I've also removed the redundant is_stackChunk asserts. ------------- Commit messages: - Remove redundant is_stackChunk asserts - Use cast function to convert from oop to stackChunkOop Changes: https://git.openjdk.java.net/loom/pull/119/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=119&range=00 Stats: 47 lines in 8 files changed: 10 ins; 16 del; 21 mod Patch: https://git.openjdk.java.net/loom/pull/119.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/119/head:pull/119 PR: https://git.openjdk.java.net/loom/pull/119 From stefank at openjdk.java.net Thu Mar 24 07:19:26 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Thu, 24 Mar 2022 07:19:26 GMT Subject: RFR: Loom checked stack chunk casts [v2] In-Reply-To: References: Message-ID: > Replace raw oop to stackChunkOops casts with calls to a ::cast function which asserts that the oops is a stackChunkOop. This is similar to what we do for other types like *Klass, *CollectedHeap, *Thread, ... > > Given that we assert when converting oops to stackChunkOops, I've also removed the redundant is_stackChunk asserts. Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision: Don't cast nullptr to oop ------------- Changes: - all: https://git.openjdk.java.net/loom/pull/119/files - new: https://git.openjdk.java.net/loom/pull/119/files/adefd721..ca4623c6 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=loom&pr=119&range=01 - incr: https://webrevs.openjdk.java.net/?repo=loom&pr=119&range=00-01 Stats: 17 lines in 3 files changed: 0 ins; 0 del; 17 mod Patch: https://git.openjdk.java.net/loom/pull/119.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/119/head:pull/119 PR: https://git.openjdk.java.net/loom/pull/119 From duke at openjdk.java.net Thu Mar 24 07:28:33 2022 From: duke at openjdk.java.net (duke) Date: Thu, 24 Mar 2022 07:28:33 GMT Subject: git: openjdk/loom: fibers: 36 new changesets Message-ID: <2528702d-afb8-4138-899c-94fccfc27390@openjdk.java.net> Changeset: b617f1db Author: Thomas Schatzl Date: 2022-03-21 11:30:26 +0000 URL: https://git.openjdk.java.net/loom/commit/b617f1db4ec5d54b1ea541fb885e296da928f166 8283447: Remove unused LIR_Assembler::_bs Reviewed-by: redestad ! src/hotspot/share/c1/c1_LIRAssembler.cpp ! src/hotspot/share/c1/c1_LIRAssembler.hpp Changeset: 909986c7 Author: Zhengyu Gu Date: 2022-03-21 12:26:58 +0000 URL: https://git.openjdk.java.net/loom/commit/909986c7e110c8ac3ba16750be7707b1ec344ee5 8283217: Leak FcObjectSet in getFontConfigLocations() in fontpath.c Reviewed-by: prr, aivanov ! src/java.desktop/unix/native/common/awt/fontpath.c Changeset: cb576da5 Author: Zhengyu Gu Date: 2022-03-21 12:28:17 +0000 URL: https://git.openjdk.java.net/loom/commit/cb576da575ea3c8f14087dd312313843764ca2f4 8283379: Memory leak in FileHeaderHelper Reviewed-by: dholmes, iklam, stuefe ! src/hotspot/share/cds/filemap.cpp Changeset: c4dc58e1 Author: Naoto Sato Date: 2022-03-21 15:33:09 +0000 URL: https://git.openjdk.java.net/loom/commit/c4dc58e12e197562dce90c0027aa74c29047cea6 8283277: ISO 4217 Amendment 171 Update Reviewed-by: iris, joehw ! make/data/currency/CurrencyData.properties ! src/java.base/share/classes/sun/util/resources/CurrencyNames.properties ! test/jdk/java/util/Currency/ValidateISO4217.java ! test/jdk/java/util/Currency/tablea1.txt ! test/jdk/sun/text/resources/LocaleData ! test/jdk/sun/text/resources/LocaleDataTest.java Changeset: 999da9bf Author: Johannes Bechberger Committer: Thomas Stuefe Date: 2022-03-21 15:49:59 +0000 URL: https://git.openjdk.java.net/loom/commit/999da9bfc5be703141cdc07af455b4b6b2cc1aae 8282306: os::is_first_C_frame(frame*) crashes on invalid link access Reviewed-by: stuefe, mdoerr ! src/hotspot/cpu/aarch64/frame_aarch64.inline.hpp ! src/hotspot/cpu/arm/frame_arm.inline.hpp ! src/hotspot/cpu/ppc/frame_ppc.inline.hpp ! src/hotspot/cpu/s390/frame_s390.inline.hpp ! src/hotspot/cpu/x86/frame_x86.inline.hpp ! src/hotspot/cpu/zero/frame_zero.inline.hpp ! src/hotspot/share/runtime/frame.hpp ! src/hotspot/share/runtime/os.cpp ! src/hotspot/share/runtime/safefetch.inline.hpp ! src/hotspot/share/runtime/thread.cpp ! test/hotspot/gtest/runtime/test_os.cpp Changeset: 19d34bdf Author: Albert Mingkun Yang Date: 2022-03-21 16:20:20 +0000 URL: https://git.openjdk.java.net/loom/commit/19d34bdf99e98a9ef614cb7f93c141e6c82bedcb 8281879: Serial: Merge CardGeneration into TenuredGeneration Reviewed-by: tschatzl, iwalulya ! src/hotspot/share/gc/serial/tenuredGeneration.cpp ! src/hotspot/share/gc/serial/tenuredGeneration.hpp ! src/hotspot/share/gc/serial/tenuredGeneration.inline.hpp ! src/hotspot/share/gc/serial/vmStructs_serial.hpp - src/hotspot/share/gc/shared/cardGeneration.cpp - src/hotspot/share/gc/shared/cardGeneration.hpp - src/hotspot/share/gc/shared/cardGeneration.inline.hpp ! src/hotspot/share/gc/shared/generation.hpp ! src/hotspot/share/gc/shared/vmStructs_gc.hpp ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/serial/TenuredGeneration.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/CardGeneration.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/Generation.java ! test/hotspot/jtreg/serviceability/sa/ClhsdbVmStructsDump.java ! test/hotspot/jtreg/serviceability/sa/TestType.java Changeset: f4f87284 Author: Albert Mingkun Yang Date: 2022-03-21 16:21:30 +0000 URL: https://git.openjdk.java.net/loom/commit/f4f87284cbbe95958d8c7d8adc0f5c5e260892ca 8283097: Parallel: Move filler object logic inside PSPromotionLAB::unallocate_object Reviewed-by: tschatzl, iwalulya ! src/hotspot/share/gc/parallel/psPromotionLAB.cpp ! src/hotspot/share/gc/parallel/psPromotionLAB.hpp ! src/hotspot/share/gc/parallel/psPromotionManager.inline.hpp Changeset: 14b9e80b Author: Joe Darcy Date: 2022-03-21 16:57:17 +0000 URL: https://git.openjdk.java.net/loom/commit/14b9e80b8adcc0ab0634357f5a7c25f24fd6808c 8283415: Update java.lang.ref to use sealed classes Reviewed-by: kbarrett, alanb ! src/java.base/share/classes/java/lang/ref/FinalReference.java ! src/java.base/share/classes/java/lang/ref/PhantomReference.java ! src/java.base/share/classes/java/lang/ref/Reference.java ! src/java.base/share/classes/java/lang/ref/SoftReference.java ! src/java.base/share/classes/java/lang/ref/WeakReference.java Changeset: f8878cb0 Author: Magnus Ihse Bursie Date: 2022-03-21 21:34:09 +0000 URL: https://git.openjdk.java.net/loom/commit/f8878cb0cc436993ef1222bc13b00b923d91aad1 8257733: Move module-specific data from make to respective module Reviewed-by: jjg, weijun, naoto, erikj, prr, alanb, mchung ! make/ModuleWrapper.gmk ! make/ToolsJdk.gmk ! make/UpdateX11Wrappers.gmk ! make/langtools/src/classes/build/tools/symbolgenerator/CreateSymbols.java ! make/modules/java.base/Gendata.gmk ! make/modules/java.base/Gensrc.gmk ! make/modules/java.base/gendata/GendataBlockedCerts.gmk ! make/modules/java.base/gendata/GendataBreakIterator.gmk ! make/modules/java.base/gendata/GendataPublicSuffixList.gmk ! make/modules/java.base/gendata/GendataTZDB.gmk ! make/modules/java.base/gensrc/GensrcBuffer.gmk ! make/modules/java.base/gensrc/GensrcCharacterData.gmk ! make/modules/java.base/gensrc/GensrcCharsetCoder.gmk ! make/modules/java.base/gensrc/GensrcEmojiData.gmk ! make/modules/java.base/gensrc/GensrcExceptions.gmk ! make/modules/java.base/gensrc/GensrcLocaleData.gmk ! make/modules/java.base/gensrc/GensrcScopedMemoryAccess.gmk ! make/modules/java.base/gensrc/GensrcVarHandles.gmk ! make/modules/java.desktop/gendata/GendataFontConfig.gmk ! make/modules/java.desktop/gensrc/GensrcIcons.gmk ! make/modules/java.desktop/gensrc/GensrcSwing.gmk ! make/modules/java.desktop/gensrc/GensrcX11Wrappers.gmk ! make/modules/jdk.charsets/Gensrc.gmk ! make/modules/jdk.compiler/Gendata.gmk ! make/modules/jdk.javadoc/Gendata.gmk ! make/modules/jdk.jdi/Gensrc.gmk ! make/modules/jdk.localedata/Gensrc.gmk ! make/scripts/generate-symbol-data.sh = src/java.base/share/classes/java/lang/CharacterData00.java.template = src/java.base/share/classes/java/lang/CharacterData01.java.template = src/java.base/share/classes/java/lang/CharacterData02.java.template = src/java.base/share/classes/java/lang/CharacterData03.java.template = src/java.base/share/classes/java/lang/CharacterData0E.java.template = src/java.base/share/classes/java/lang/CharacterDataLatin1.java.template = src/java.base/share/data/blockedcertsconverter/blocked.certs.pem = src/java.base/share/data/cacerts/README = src/java.base/share/data/cacerts/actalisauthenticationrootca = src/java.base/share/data/cacerts/addtrustexternalca = src/java.base/share/data/cacerts/addtrustqualifiedca = src/java.base/share/data/cacerts/affirmtrustcommercialca = src/java.base/share/data/cacerts/affirmtrustnetworkingca = src/java.base/share/data/cacerts/affirmtrustpremiumca = src/java.base/share/data/cacerts/affirmtrustpremiumeccca = src/java.base/share/data/cacerts/amazonrootca1 = src/java.base/share/data/cacerts/amazonrootca2 = src/java.base/share/data/cacerts/amazonrootca3 = src/java.base/share/data/cacerts/amazonrootca4 = src/java.base/share/data/cacerts/baltimorecybertrustca = src/java.base/share/data/cacerts/buypassclass2ca = src/java.base/share/data/cacerts/buypassclass3ca = src/java.base/share/data/cacerts/camerfirmachambersca = src/java.base/share/data/cacerts/camerfirmachamberscommerceca = src/java.base/share/data/cacerts/camerfirmachambersignca = src/java.base/share/data/cacerts/certumca = src/java.base/share/data/cacerts/certumtrustednetworkca = src/java.base/share/data/cacerts/chunghwaepkirootca = src/java.base/share/data/cacerts/comodoaaaca = src/java.base/share/data/cacerts/comodoeccca = src/java.base/share/data/cacerts/comodorsaca = src/java.base/share/data/cacerts/digicertassuredidg2 = src/java.base/share/data/cacerts/digicertassuredidg3 = src/java.base/share/data/cacerts/digicertassuredidrootca = src/java.base/share/data/cacerts/digicertglobalrootca = src/java.base/share/data/cacerts/digicertglobalrootg2 = src/java.base/share/data/cacerts/digicertglobalrootg3 = src/java.base/share/data/cacerts/digicerthighassuranceevrootca = src/java.base/share/data/cacerts/digicerttrustedrootg4 = src/java.base/share/data/cacerts/dtrustclass3ca2 = src/java.base/share/data/cacerts/dtrustclass3ca2ev = src/java.base/share/data/cacerts/entrust2048ca = src/java.base/share/data/cacerts/entrustevca = src/java.base/share/data/cacerts/entrustrootcaec1 = src/java.base/share/data/cacerts/entrustrootcag2 = src/java.base/share/data/cacerts/entrustrootcag4 = src/java.base/share/data/cacerts/geotrustglobalca = src/java.base/share/data/cacerts/geotrustprimaryca = src/java.base/share/data/cacerts/geotrustprimarycag2 = src/java.base/share/data/cacerts/geotrustprimarycag3 = src/java.base/share/data/cacerts/geotrustuniversalca = src/java.base/share/data/cacerts/globalsignca = src/java.base/share/data/cacerts/globalsigneccrootcar4 = src/java.base/share/data/cacerts/globalsigneccrootcar5 = src/java.base/share/data/cacerts/globalsignr3ca = src/java.base/share/data/cacerts/globalsignrootcar6 = src/java.base/share/data/cacerts/godaddyclass2ca = src/java.base/share/data/cacerts/godaddyrootg2ca = src/java.base/share/data/cacerts/haricaeccrootca2015 = src/java.base/share/data/cacerts/haricarootca2015 = src/java.base/share/data/cacerts/identrustcommercial = src/java.base/share/data/cacerts/identrustpublicca = src/java.base/share/data/cacerts/letsencryptisrgx1 = src/java.base/share/data/cacerts/luxtrustglobalroot2ca = src/java.base/share/data/cacerts/luxtrustglobalrootca = src/java.base/share/data/cacerts/quovadisrootca = src/java.base/share/data/cacerts/quovadisrootca1g3 = src/java.base/share/data/cacerts/quovadisrootca2 = src/java.base/share/data/cacerts/quovadisrootca2g3 = src/java.base/share/data/cacerts/quovadisrootca3 = src/java.base/share/data/cacerts/quovadisrootca3g3 = src/java.base/share/data/cacerts/secomscrootca1 = src/java.base/share/data/cacerts/secomscrootca2 = src/java.base/share/data/cacerts/securetrustca = src/java.base/share/data/cacerts/sslrooteccca = src/java.base/share/data/cacerts/sslrootevrsaca = src/java.base/share/data/cacerts/sslrootrsaca = src/java.base/share/data/cacerts/starfieldclass2ca = src/java.base/share/data/cacerts/starfieldrootg2ca = src/java.base/share/data/cacerts/starfieldservicesrootg2ca = src/java.base/share/data/cacerts/swisssigngoldg2ca = src/java.base/share/data/cacerts/swisssignplatinumg2ca = src/java.base/share/data/cacerts/swisssignsilverg2ca = src/java.base/share/data/cacerts/teliasonerarootcav1 = src/java.base/share/data/cacerts/thawteprimaryrootca = src/java.base/share/data/cacerts/thawteprimaryrootcag2 = src/java.base/share/data/cacerts/thawteprimaryrootcag3 = src/java.base/share/data/cacerts/ttelesecglobalrootclass2ca = src/java.base/share/data/cacerts/ttelesecglobalrootclass3ca = src/java.base/share/data/cacerts/usertrusteccca = src/java.base/share/data/cacerts/usertrustrsaca = src/java.base/share/data/cacerts/utnuserfirstobjectca = src/java.base/share/data/cacerts/verisignclass3g3ca = src/java.base/share/data/cacerts/verisignclass3g4ca = src/java.base/share/data/cacerts/verisignclass3g5ca = src/java.base/share/data/cacerts/verisignuniversalrootca = src/java.base/share/data/cacerts/xrampglobalca = src/java.base/share/data/currency/CurrencyData.properties = src/java.base/share/data/lsrdata/language-subtag-registry.txt = src/java.base/share/data/publicsuffixlist/VERSION = src/java.base/share/data/publicsuffixlist/public_suffix_list.dat = src/java.base/share/data/tzdata/VERSION = src/java.base/share/data/tzdata/africa = src/java.base/share/data/tzdata/antarctica = src/java.base/share/data/tzdata/asia = src/java.base/share/data/tzdata/australasia = src/java.base/share/data/tzdata/backward = src/java.base/share/data/tzdata/etcetera = src/java.base/share/data/tzdata/europe = src/java.base/share/data/tzdata/factory = src/java.base/share/data/tzdata/gmt = src/java.base/share/data/tzdata/iso3166.tab = src/java.base/share/data/tzdata/jdk11_backward = src/java.base/share/data/tzdata/leapseconds = src/java.base/share/data/tzdata/northamerica = src/java.base/share/data/tzdata/solar87 = src/java.base/share/data/tzdata/solar88 = src/java.base/share/data/tzdata/solar89 = src/java.base/share/data/tzdata/southamerica = src/java.base/share/data/tzdata/zone.tab = src/java.base/share/data/unicodedata/Blocks.txt = src/java.base/share/data/unicodedata/DerivedCoreProperties.txt = src/java.base/share/data/unicodedata/NormalizationTest.txt = src/java.base/share/data/unicodedata/PropList.txt = src/java.base/share/data/unicodedata/PropertyValueAliases.txt = src/java.base/share/data/unicodedata/ReadMe.txt = src/java.base/share/data/unicodedata/Scripts.txt = src/java.base/share/data/unicodedata/SpecialCasing.txt = src/java.base/share/data/unicodedata/UnicodeData.txt = src/java.base/share/data/unicodedata/auxiliary/GraphemeBreakProperty.txt = src/java.base/share/data/unicodedata/auxiliary/GraphemeBreakTest.txt = src/java.base/share/data/unicodedata/emoji/emoji-data.txt = src/java.desktop/aix/data/fontconfig/fontconfig.properties = src/java.desktop/bsd/data/fontconfig/fontconfig.properties = src/java.desktop/macosx/data/fontconfig/fontconfig.properties = src/java.desktop/macosx/data/macosxicons/JavaApp.icns = src/java.desktop/share/data/dtdbuilder/HTMLlat1.sgml = src/java.desktop/share/data/dtdbuilder/HTMLspecial.sgml = src/java.desktop/share/data/dtdbuilder/HTMLsymbol.sgml = src/java.desktop/share/data/dtdbuilder/html32.dtd = src/java.desktop/share/data/dtdbuilder/public.map = src/java.desktop/unix/data/x11wrappergen/sizes-32.txt = src/java.desktop/unix/data/x11wrappergen/sizes-64.txt = src/java.desktop/unix/data/x11wrappergen/xlibtypes.txt = src/java.desktop/windows/data/fontconfig/fontconfig.properties = src/java.se/share/data/jdwp/jdwp.spec = src/jdk.compiler/share/data/symbols/README = src/jdk.compiler/share/data/symbols/include.list = src/jdk.compiler/share/data/symbols/java.activation-8.sym.txt = src/jdk.compiler/share/data/symbols/java.activation-9.sym.txt = src/jdk.compiler/share/data/symbols/java.activation-A.sym.txt = src/jdk.compiler/share/data/symbols/java.activation-B.sym.txt = src/jdk.compiler/share/data/symbols/java.base-7.sym.txt = src/jdk.compiler/share/data/symbols/java.base-8.sym.txt = src/jdk.compiler/share/data/symbols/java.base-9.sym.txt = src/jdk.compiler/share/data/symbols/java.base-A.sym.txt = src/jdk.compiler/share/data/symbols/java.base-B.sym.txt = src/jdk.compiler/share/data/symbols/java.base-C.sym.txt = src/jdk.compiler/share/data/symbols/java.base-D.sym.txt = src/jdk.compiler/share/data/symbols/java.base-E.sym.txt = src/jdk.compiler/share/data/symbols/java.base-F.sym.txt = src/jdk.compiler/share/data/symbols/java.base-G.sym.txt = src/jdk.compiler/share/data/symbols/java.base-H.sym.txt = src/jdk.compiler/share/data/symbols/java.base-I.sym.txt = src/jdk.compiler/share/data/symbols/java.compiler-7.sym.txt = src/jdk.compiler/share/data/symbols/java.compiler-8.sym.txt = src/jdk.compiler/share/data/symbols/java.compiler-9.sym.txt = src/jdk.compiler/share/data/symbols/java.compiler-A.sym.txt = src/jdk.compiler/share/data/symbols/java.compiler-B.sym.txt = src/jdk.compiler/share/data/symbols/java.compiler-C.sym.txt = src/jdk.compiler/share/data/symbols/java.compiler-D.sym.txt = src/jdk.compiler/share/data/symbols/java.compiler-E.sym.txt = src/jdk.compiler/share/data/symbols/java.compiler-F.sym.txt = src/jdk.compiler/share/data/symbols/java.compiler-G.sym.txt = src/jdk.compiler/share/data/symbols/java.compiler-H.sym.txt = src/jdk.compiler/share/data/symbols/java.compiler-I.sym.txt = src/jdk.compiler/share/data/symbols/java.corba-8.sym.txt = src/jdk.compiler/share/data/symbols/java.corba-9.sym.txt = src/jdk.compiler/share/data/symbols/java.corba-A.sym.txt = src/jdk.compiler/share/data/symbols/java.corba-B.sym.txt = src/jdk.compiler/share/data/symbols/java.datatransfer-7.sym.txt = src/jdk.compiler/share/data/symbols/java.datatransfer-8.sym.txt = src/jdk.compiler/share/data/symbols/java.datatransfer-9.sym.txt = src/jdk.compiler/share/data/symbols/java.datatransfer-A.sym.txt = src/jdk.compiler/share/data/symbols/java.datatransfer-B.sym.txt = src/jdk.compiler/share/data/symbols/java.datatransfer-G.sym.txt = src/jdk.compiler/share/data/symbols/java.datatransfer-H.sym.txt = src/jdk.compiler/share/data/symbols/java.datatransfer-I.sym.txt = src/jdk.compiler/share/data/symbols/java.desktop-7.sym.txt = src/jdk.compiler/share/data/symbols/java.desktop-8.sym.txt = src/jdk.compiler/share/data/symbols/java.desktop-9.sym.txt = src/jdk.compiler/share/data/symbols/java.desktop-A.sym.txt = src/jdk.compiler/share/data/symbols/java.desktop-B.sym.txt = src/jdk.compiler/share/data/symbols/java.desktop-C.sym.txt = src/jdk.compiler/share/data/symbols/java.desktop-D.sym.txt = src/jdk.compiler/share/data/symbols/java.desktop-E.sym.txt = src/jdk.compiler/share/data/symbols/java.desktop-F.sym.txt = src/jdk.compiler/share/data/symbols/java.desktop-G.sym.txt = src/jdk.compiler/share/data/symbols/java.desktop-H.sym.txt = src/jdk.compiler/share/data/symbols/java.desktop-I.sym.txt = src/jdk.compiler/share/data/symbols/java.instrument-8.sym.txt = src/jdk.compiler/share/data/symbols/java.instrument-9.sym.txt = src/jdk.compiler/share/data/symbols/java.instrument-A.sym.txt = src/jdk.compiler/share/data/symbols/java.instrument-B.sym.txt = src/jdk.compiler/share/data/symbols/java.instrument-G.sym.txt = src/jdk.compiler/share/data/symbols/java.instrument-H.sym.txt = src/jdk.compiler/share/data/symbols/java.instrument-I.sym.txt = src/jdk.compiler/share/data/symbols/java.logging-7.sym.txt = src/jdk.compiler/share/data/symbols/java.logging-8.sym.txt = src/jdk.compiler/share/data/symbols/java.logging-9.sym.txt = src/jdk.compiler/share/data/symbols/java.logging-A.sym.txt = src/jdk.compiler/share/data/symbols/java.logging-B.sym.txt = src/jdk.compiler/share/data/symbols/java.logging-G.sym.txt = src/jdk.compiler/share/data/symbols/java.logging-H.sym.txt = src/jdk.compiler/share/data/symbols/java.logging-I.sym.txt = src/jdk.compiler/share/data/symbols/java.management-7.sym.txt = src/jdk.compiler/share/data/symbols/java.management-8.sym.txt = src/jdk.compiler/share/data/symbols/java.management-9.sym.txt = src/jdk.compiler/share/data/symbols/java.management-A.sym.txt = src/jdk.compiler/share/data/symbols/java.management-B.sym.txt = src/jdk.compiler/share/data/symbols/java.management-D.sym.txt = src/jdk.compiler/share/data/symbols/java.management-G.sym.txt = src/jdk.compiler/share/data/symbols/java.management-H.sym.txt = src/jdk.compiler/share/data/symbols/java.management-I.sym.txt = src/jdk.compiler/share/data/symbols/java.management.rmi-8.sym.txt = src/jdk.compiler/share/data/symbols/java.management.rmi-9.sym.txt = src/jdk.compiler/share/data/symbols/java.management.rmi-A.sym.txt = src/jdk.compiler/share/data/symbols/java.management.rmi-B.sym.txt = src/jdk.compiler/share/data/symbols/java.management.rmi-D.sym.txt = src/jdk.compiler/share/data/symbols/java.management.rmi-F.sym.txt = src/jdk.compiler/share/data/symbols/java.management.rmi-G.sym.txt = src/jdk.compiler/share/data/symbols/java.management.rmi-H.sym.txt = src/jdk.compiler/share/data/symbols/java.management.rmi-I.sym.txt = src/jdk.compiler/share/data/symbols/java.naming-7.sym.txt = src/jdk.compiler/share/data/symbols/java.naming-8.sym.txt = src/jdk.compiler/share/data/symbols/java.naming-9.sym.txt = src/jdk.compiler/share/data/symbols/java.naming-A.sym.txt = src/jdk.compiler/share/data/symbols/java.naming-B.sym.txt = src/jdk.compiler/share/data/symbols/java.naming-C.sym.txt = src/jdk.compiler/share/data/symbols/java.naming-F.sym.txt = src/jdk.compiler/share/data/symbols/java.naming-G.sym.txt = src/jdk.compiler/share/data/symbols/java.naming-H.sym.txt = src/jdk.compiler/share/data/symbols/java.naming-I.sym.txt = src/jdk.compiler/share/data/symbols/java.net.http-B.sym.txt = src/jdk.compiler/share/data/symbols/java.net.http-D.sym.txt = src/jdk.compiler/share/data/symbols/java.net.http-G.sym.txt = src/jdk.compiler/share/data/symbols/java.net.http-I.sym.txt = src/jdk.compiler/share/data/symbols/java.prefs-7.sym.txt = src/jdk.compiler/share/data/symbols/java.prefs-8.sym.txt = src/jdk.compiler/share/data/symbols/java.prefs-9.sym.txt = src/jdk.compiler/share/data/symbols/java.prefs-A.sym.txt = src/jdk.compiler/share/data/symbols/java.prefs-B.sym.txt = src/jdk.compiler/share/data/symbols/java.rmi-7.sym.txt = src/jdk.compiler/share/data/symbols/java.rmi-8.sym.txt = src/jdk.compiler/share/data/symbols/java.rmi-9.sym.txt = src/jdk.compiler/share/data/symbols/java.rmi-A.sym.txt = src/jdk.compiler/share/data/symbols/java.rmi-B.sym.txt = src/jdk.compiler/share/data/symbols/java.rmi-C.sym.txt = src/jdk.compiler/share/data/symbols/java.rmi-F.sym.txt = src/jdk.compiler/share/data/symbols/java.rmi-G.sym.txt = src/jdk.compiler/share/data/symbols/java.rmi-H.sym.txt = src/jdk.compiler/share/data/symbols/java.rmi-I.sym.txt = src/jdk.compiler/share/data/symbols/java.scripting-7.sym.txt = src/jdk.compiler/share/data/symbols/java.scripting-8.sym.txt = src/jdk.compiler/share/data/symbols/java.scripting-9.sym.txt = src/jdk.compiler/share/data/symbols/java.scripting-A.sym.txt = src/jdk.compiler/share/data/symbols/java.scripting-B.sym.txt = src/jdk.compiler/share/data/symbols/java.scripting-G.sym.txt = src/jdk.compiler/share/data/symbols/java.scripting-H.sym.txt = src/jdk.compiler/share/data/symbols/java.scripting-I.sym.txt = src/jdk.compiler/share/data/symbols/java.se-9.sym.txt = src/jdk.compiler/share/data/symbols/java.se-A.sym.txt = src/jdk.compiler/share/data/symbols/java.se-B.sym.txt = src/jdk.compiler/share/data/symbols/java.se.ee-9.sym.txt = src/jdk.compiler/share/data/symbols/java.se.ee-A.sym.txt = src/jdk.compiler/share/data/symbols/java.se.ee-B.sym.txt = src/jdk.compiler/share/data/symbols/java.security.jgss-7.sym.txt = src/jdk.compiler/share/data/symbols/java.security.jgss-8.sym.txt = src/jdk.compiler/share/data/symbols/java.security.jgss-9.sym.txt = src/jdk.compiler/share/data/symbols/java.security.jgss-A.sym.txt = src/jdk.compiler/share/data/symbols/java.security.jgss-B.sym.txt = src/jdk.compiler/share/data/symbols/java.security.jgss-D.sym.txt = src/jdk.compiler/share/data/symbols/java.security.jgss-G.sym.txt = src/jdk.compiler/share/data/symbols/java.security.jgss-H.sym.txt = src/jdk.compiler/share/data/symbols/java.security.jgss-I.sym.txt = src/jdk.compiler/share/data/symbols/java.security.sasl-7.sym.txt = src/jdk.compiler/share/data/symbols/java.security.sasl-8.sym.txt = src/jdk.compiler/share/data/symbols/java.security.sasl-9.sym.txt = src/jdk.compiler/share/data/symbols/java.security.sasl-A.sym.txt = src/jdk.compiler/share/data/symbols/java.security.sasl-B.sym.txt = src/jdk.compiler/share/data/symbols/java.security.sasl-G.sym.txt = src/jdk.compiler/share/data/symbols/java.security.sasl-H.sym.txt = src/jdk.compiler/share/data/symbols/java.security.sasl-I.sym.txt = src/jdk.compiler/share/data/symbols/java.smartcardio-9.sym.txt = src/jdk.compiler/share/data/symbols/java.smartcardio-A.sym.txt = src/jdk.compiler/share/data/symbols/java.smartcardio-B.sym.txt = src/jdk.compiler/share/data/symbols/java.smartcardio-G.sym.txt = src/jdk.compiler/share/data/symbols/java.smartcardio-H.sym.txt = src/jdk.compiler/share/data/symbols/java.smartcardio-I.sym.txt = src/jdk.compiler/share/data/symbols/java.sql-7.sym.txt = src/jdk.compiler/share/data/symbols/java.sql-8.sym.txt = src/jdk.compiler/share/data/symbols/java.sql-9.sym.txt = src/jdk.compiler/share/data/symbols/java.sql-A.sym.txt = src/jdk.compiler/share/data/symbols/java.sql-B.sym.txt = src/jdk.compiler/share/data/symbols/java.sql-G.sym.txt = src/jdk.compiler/share/data/symbols/java.sql-H.sym.txt = src/jdk.compiler/share/data/symbols/java.sql-I.sym.txt = src/jdk.compiler/share/data/symbols/java.sql.rowset-7.sym.txt = src/jdk.compiler/share/data/symbols/java.sql.rowset-8.sym.txt = src/jdk.compiler/share/data/symbols/java.sql.rowset-9.sym.txt = src/jdk.compiler/share/data/symbols/java.sql.rowset-A.sym.txt = src/jdk.compiler/share/data/symbols/java.sql.rowset-B.sym.txt = src/jdk.compiler/share/data/symbols/java.sql.rowset-G.sym.txt = src/jdk.compiler/share/data/symbols/java.sql.rowset-H.sym.txt = src/jdk.compiler/share/data/symbols/java.sql.rowset-I.sym.txt = src/jdk.compiler/share/data/symbols/java.transaction-8.sym.txt = src/jdk.compiler/share/data/symbols/java.transaction-9.sym.txt = src/jdk.compiler/share/data/symbols/java.transaction-A.sym.txt = src/jdk.compiler/share/data/symbols/java.transaction-B.sym.txt = src/jdk.compiler/share/data/symbols/java.transaction.xa-B.sym.txt = src/jdk.compiler/share/data/symbols/java.xml-7.sym.txt = src/jdk.compiler/share/data/symbols/java.xml-8.sym.txt = src/jdk.compiler/share/data/symbols/java.xml-9.sym.txt = src/jdk.compiler/share/data/symbols/java.xml-A.sym.txt = src/jdk.compiler/share/data/symbols/java.xml-B.sym.txt = src/jdk.compiler/share/data/symbols/java.xml-C.sym.txt = src/jdk.compiler/share/data/symbols/java.xml-D.sym.txt = src/jdk.compiler/share/data/symbols/java.xml-E.sym.txt = src/jdk.compiler/share/data/symbols/java.xml-F.sym.txt = src/jdk.compiler/share/data/symbols/java.xml-G.sym.txt = src/jdk.compiler/share/data/symbols/java.xml-H.sym.txt = src/jdk.compiler/share/data/symbols/java.xml-I.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.bind-7.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.bind-8.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.bind-9.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.bind-A.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.bind-B.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.crypto-8.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.crypto-9.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.crypto-A.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.crypto-B.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.crypto-D.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.crypto-G.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.crypto-H.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.crypto-I.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.ws-8.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.ws-9.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.ws-A.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.ws-B.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.ws.annotation-7.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.ws.annotation-8.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.ws.annotation-9.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.ws.annotation-A.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.ws.annotation-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.accessibility-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.accessibility-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.accessibility-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.accessibility-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.accessibility-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.accessibility-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.attach-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.attach-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.attach-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.attach-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.attach-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.attach-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.charsets-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.charsets-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.charsets-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.compiler-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.compiler-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.compiler-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.compiler-C.sym.txt = src/jdk.compiler/share/data/symbols/jdk.compiler-D.sym.txt = src/jdk.compiler/share/data/symbols/jdk.compiler-E.sym.txt = src/jdk.compiler/share/data/symbols/jdk.compiler-F.sym.txt = src/jdk.compiler/share/data/symbols/jdk.compiler-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.compiler-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.compiler-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.crypto.cryptoki-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.crypto.cryptoki-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.crypto.cryptoki-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.crypto.ec-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.crypto.ec-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.crypto.ec-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.dynalink-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.dynalink-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.dynalink-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.dynalink-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.dynalink-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.dynalink-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.editpad-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.editpad-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.editpad-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.hotspot.agent-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.hotspot.agent-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.hotspot.agent-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.httpserver-7.sym.txt = src/jdk.compiler/share/data/symbols/jdk.httpserver-8.sym.txt = src/jdk.compiler/share/data/symbols/jdk.httpserver-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.httpserver-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.httpserver-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.httpserver-D.sym.txt = src/jdk.compiler/share/data/symbols/jdk.httpserver-E.sym.txt = src/jdk.compiler/share/data/symbols/jdk.httpserver-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.httpserver-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.httpserver-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.incubator.foreign-E.sym.txt = src/jdk.compiler/share/data/symbols/jdk.incubator.foreign-F.sym.txt = src/jdk.compiler/share/data/symbols/jdk.incubator.foreign-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.incubator.foreign-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.incubator.foreign-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.incubator.httpclient-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.incubator.httpclient-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.incubator.httpclient-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.incubator.jpackage-E.sym.txt = src/jdk.compiler/share/data/symbols/jdk.incubator.jpackage-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.incubator.vector-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.incubator.vector-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.incubator.vector-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jartool-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jartool-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jartool-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jartool-D.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jartool-F.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jartool-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jartool-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jartool-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.javadoc-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.javadoc-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.javadoc-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.javadoc-D.sym.txt = src/jdk.compiler/share/data/symbols/jdk.javadoc-F.sym.txt = src/jdk.compiler/share/data/symbols/jdk.javadoc-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.javadoc-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.javadoc-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jcmd-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jcmd-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jcmd-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jconsole-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jconsole-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jconsole-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jconsole-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jconsole-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jconsole-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jdeps-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jdeps-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jdeps-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jdi-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jdi-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jdi-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jdi-F.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jdi-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jdi-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jdi-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jdwp.agent-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jdwp.agent-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jdwp.agent-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jfr-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jfr-C.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jfr-E.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jfr-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jfr-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jlink-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jlink-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jlink-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jlink-D.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jlink-E.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jlink-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jpackage-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jshell-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jshell-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jshell-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jshell-D.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jshell-E.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jshell-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jshell-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jshell-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jsobject-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jsobject-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jsobject-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jsobject-C.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jsobject-E.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jsobject-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jsobject-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jsobject-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jstatd-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jstatd-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jstatd-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.localedata-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.localedata-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.localedata-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management-7.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management-8.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management-E.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management.agent-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management.agent-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management.agent-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management.jfr-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management.jfr-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management.jfr-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management.jfr-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.naming.dns-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.naming.dns-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.naming.dns-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.naming.rmi-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.naming.rmi-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.naming.rmi-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.net-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.net-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.net-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.net-E.sym.txt = src/jdk.compiler/share/data/symbols/jdk.net-F.sym.txt = src/jdk.compiler/share/data/symbols/jdk.net-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.net-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.net-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.nio.mapmode-F.sym.txt = src/jdk.compiler/share/data/symbols/jdk.pack-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.pack-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.pack-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.pack-E.sym.txt = src/jdk.compiler/share/data/symbols/jdk.policytool-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.policytool-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.rmic-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.rmic-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.rmic-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.rmic-F.sym.txt = src/jdk.compiler/share/data/symbols/jdk.scripting.nashorn-7.sym.txt = src/jdk.compiler/share/data/symbols/jdk.scripting.nashorn-8.sym.txt = src/jdk.compiler/share/data/symbols/jdk.scripting.nashorn-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.scripting.nashorn-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.scripting.nashorn-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.scripting.nashorn-F.sym.txt = src/jdk.compiler/share/data/symbols/jdk.sctp-7.sym.txt = src/jdk.compiler/share/data/symbols/jdk.sctp-8.sym.txt = src/jdk.compiler/share/data/symbols/jdk.sctp-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.sctp-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.sctp-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.sctp-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.sctp-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.sctp-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.auth-7.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.auth-8.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.auth-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.auth-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.auth-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.auth-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.auth-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.auth-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.jgss-7.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.jgss-8.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.jgss-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.jgss-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.jgss-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.jgss-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.jgss-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.jgss-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.unsupported-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.unsupported-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.unsupported-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.unsupported-C.sym.txt = src/jdk.compiler/share/data/symbols/jdk.unsupported-F.sym.txt = src/jdk.compiler/share/data/symbols/jdk.unsupported-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.unsupported-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.unsupported-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.xml.dom-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.xml.dom-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.xml.dom-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.xml.dom-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.xml.dom-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.xml.dom-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.zipfs-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.zipfs-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.zipfs-B.sym.txt = src/jdk.compiler/share/data/symbols/symbols ! test/jdk/java/security/misc/Versions.java ! test/jdk/java/util/Currency/CurrencyTest.java ! test/jdk/java/util/Locale/LSRDataTest.java ! test/jdk/lib/testlibrary/java/lang/UCDFiles.java ! test/jdk/sun/nio/cs/TestCharsetMapping.java ! test/jdk/sun/nio/cs/TestMS950.java ! test/jdk/sun/security/lib/CheckBlockedCerts.java ! test/jdk/sun/util/calendar/zi/TestZoneInfo310.java ! test/langtools/tools/javac/platform/CanHandleClassFilesTest.java ! test/langtools/tools/javac/sym/ElementStructureTest.java Changeset: f3dc0c88 Author: David Holmes Date: 2022-03-22 01:12:29 +0000 URL: https://git.openjdk.java.net/loom/commit/f3dc0c88ea00a3745f5f105404e0788a0f616407 8282721: HotSpot Style Guide should allow considered use of C++ thread_local Reviewed-by: kbarrett, jrose, dcubed, stuefe, mdoerr, kvn ! doc/hotspot-style.html ! doc/hotspot-style.md Changeset: 81d63734 Author: David Holmes Date: 2022-03-22 01:20:31 +0000 URL: https://git.openjdk.java.net/loom/commit/81d63734bc2e2a18063cb6afbc53f8813a0ba880 8282469: Allow considered use of C++ thread_local in Hotspot Reviewed-by: kbarrett, dcubed - src/hotspot/share/memory/operator_new.cpp ! src/hotspot/share/utilities/globalDefinitions.hpp Changeset: 849b1952 Author: Manukumar V S Committer: Sergey Bylokhov Date: 2022-03-22 01:28:06 +0000 URL: https://git.openjdk.java.net/loom/commit/849b19523a666bd2ec110876bfd5679b20be77f4 8282937: Write a regression test for JDK-4820080 Reviewed-by: serb + test/jdk/javax/swing/JSplitPane/4820080/JSplitPaneDragColorTest.java Changeset: 37fc77ef Author: Kevin Walls Date: 2022-03-22 07:54:41 +0000 URL: https://git.openjdk.java.net/loom/commit/37fc77ef60dd97c4acc468ecfeb6753132974720 8283092: JMX subclass permission check redundant with strong encapsulation Reviewed-by: dfuchs, mchung ! src/java.management/share/classes/java/lang/management/ManagementFactory.java ! src/java.management/share/classes/sun/management/spi/PlatformMBeanProvider.java ! src/jdk.management.agent/share/classes/jdk/internal/agent/spi/AgentProvider.java ! test/jdk/sun/management/PlatformMBeanProviderConstructorCheck.java Changeset: a6fd0b21 Author: Srinivas Mandalika Committer: Sergey Bylokhov Date: 2022-03-22 09:20:12 +0000 URL: https://git.openjdk.java.net/loom/commit/a6fd0b21ddc1575366eed8d47191f6b14b2d7cb6 8283087: Create a test or JDK-4715503 Reviewed-by: serb + test/jdk/javax/accessibility/4715503/AccessibleJTableCellBoundingRectangleTest.java Changeset: 85628a87 Author: Roland Westrelin Date: 2022-03-22 10:34:33 +0000 URL: https://git.openjdk.java.net/loom/commit/85628a871df3fdeec1b422d1c01c222abe45d0a8 8282592: C2: assert(false) failed: graph should be schedulable Reviewed-by: chagedorn, thartmann ! src/hotspot/share/opto/loopTransform.cpp ! src/hotspot/share/opto/loopopts.cpp + test/hotspot/jtreg/compiler/c2/irTests/TestSkeletonPredicates.java Changeset: c0f984e5 Author: Zhengyu Gu Date: 2022-03-22 13:30:26 +0000 URL: https://git.openjdk.java.net/loom/commit/c0f984e5fbba7b44fa7b0a4309896ef9ccb4e666 8283456: Make CompiledICHolder::live_count/live_not_claimed_count debug only Reviewed-by: dholmes ! src/hotspot/share/oops/compiledICHolder.cpp ! src/hotspot/share/oops/compiledICHolder.hpp Changeset: fabde3b7 Author: Roland Westrelin Date: 2022-03-22 14:06:49 +0000 URL: https://git.openjdk.java.net/loom/commit/fabde3b7b8ed5e576febe8138c14696ccdf636d5 8283451: C2: assert(_base == Long) failed: Not a Long Reviewed-by: thartmann, chagedorn ! src/hotspot/share/opto/phaseX.cpp + test/hotspot/jtreg/compiler/c2/TestModDivTopInput.java Changeset: 557ff4b3 Author: Jim Laskey Date: 2022-03-22 15:32:46 +0000 URL: https://git.openjdk.java.net/loom/commit/557ff4b3558f95723ebaff680b8524b0cb979559 8282625: Formatter caches Locale/DecimalFormatSymbols poorly Reviewed-by: naoto, rriggs, jpai ! src/java.base/share/classes/java/text/DecimalFormatSymbols.java ! src/java.base/share/classes/java/util/Formatter.java ! test/jdk/java/text/Format/NumberFormat/IntlTestDecimalFormatSymbols.java Changeset: d29c7e74 Author: Emanuel Peter Committer: Tobias Hartmann Date: 2022-03-22 16:23:23 +0000 URL: https://git.openjdk.java.net/loom/commit/d29c7e740d51cb50a1aa0a941a5b460782f8da68 8282590: C2: assert(addp->is_AddP() && addp->outcnt() > 0) failed: Don't process dead nodes Reviewed-by: thartmann, chagedorn ! src/hotspot/share/opto/arraycopynode.cpp ! src/hotspot/share/opto/subtypenode.cpp ! test/hotspot/jtreg/compiler/arraycopy/TestArrayCopyAsLoadsStores.java Changeset: f7d21c35 Author: Joe Darcy Date: 2022-03-22 16:26:23 +0000 URL: https://git.openjdk.java.net/loom/commit/f7d21c3523d87584b62a1143bfe52d067cf77519 8283480: Make AbstractStringBuilder sealed Reviewed-by: jjg, rriggs, jlaskey, dfuchs ! src/java.base/share/classes/java/lang/AbstractStringBuilder.java Changeset: 33eb89df Author: Phil Race Date: 2022-03-22 21:48:42 +0000 URL: https://git.openjdk.java.net/loom/commit/33eb89dfeb4a43e1ad2c3dd657ec3b6ee7abbb3a 8283457: [macos] libpng build failures with Xcode13.3 Reviewed-by: erikj ! make/modules/java.desktop/lib/Awt2dLibraries.gmk Changeset: 8cc12350 Author: David Holmes Date: 2022-03-23 00:06:53 +0000 URL: https://git.openjdk.java.net/loom/commit/8cc12350294c202ae4050471587b95135a9f6ac6 8282952: Thread::exit should be immune to Thread.stop Reviewed-by: dcubed, pchilanomate, alanb ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/thread.inline.hpp Changeset: 6ea996c2 Author: Ichiroh Takiguchi Date: 2022-03-23 01:39:20 +0000 URL: https://git.openjdk.java.net/loom/commit/6ea996c20591cafa9673d9c697437ce2c48e4616 8282422: JTable.print() failed with UnsupportedCharsetException on AIX ko_KR locale Reviewed-by: prr, serb ! src/java.desktop/share/classes/sun/awt/FontConfiguration.java Changeset: b035fda4 Author: Thomas Stuefe Date: 2022-03-23 06:06:51 +0000 URL: https://git.openjdk.java.net/loom/commit/b035fda459284fa130bf936743a8579a6888160b 8283497: [windows] print TMP and TEMP in hs_err and VM.info Reviewed-by: ysuenaga, dholmes ! src/hotspot/share/utilities/vmError.cpp Changeset: 82e1a1cf Author: Aleksey Shipilev Date: 2022-03-23 06:30:19 +0000 URL: https://git.openjdk.java.net/loom/commit/82e1a1cf8bafddfa2ecf11c2ce88ed4eaa091757 8283257: x86: Clean up invocation/branch counter updates code Reviewed-by: redestad, kvn ! src/hotspot/cpu/x86/interp_masm_x86.cpp ! src/hotspot/cpu/x86/interp_masm_x86.hpp ! src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp ! src/hotspot/cpu/x86/templateTable_x86.cpp Changeset: 1443f6b9 Author: Aleksey Shipilev Date: 2022-03-23 06:31:36 +0000 URL: https://git.openjdk.java.net/loom/commit/1443f6b9191c127abdae38cadb1a44af3c652f1d 8283199: Linux os::cpu_microcode_revision() stalls cold startup Reviewed-by: dholmes, redestad, stuefe ! src/hotspot/os_cpu/linux_x86/os_linux_x86.cpp Changeset: 86015e15 Author: Sibabrata Sahoo Date: 2022-03-23 06:45:37 +0000 URL: https://git.openjdk.java.net/loom/commit/86015e15a5105a779ee065cca64479c8d4fbc074 8282293: Domain value for system property jdk.https.negotiate.cbt should be case-insensitive Reviewed-by: weijun, rhalade ! src/java.base/share/classes/sun/net/www/protocol/https/AbstractDelegateHttpsURLConnection.java ! test/jdk/sun/security/krb5/auto/HttpsCB.java Changeset: 58487ddc Author: Thomas Stuefe Date: 2022-03-23 06:46:55 +0000 URL: https://git.openjdk.java.net/loom/commit/58487ddc170f73123668f29c99097b16ba84aa9b 8283249: CompressedClassPointers.java fails on ppc with 'Narrow klass shift: 0' missing Reviewed-by: iklam ! test/hotspot/jtreg/runtime/CompressedOops/CompressedClassPointers.java Changeset: 026b8530 Author: Jie Fu Date: 2022-03-23 08:48:17 +0000 URL: https://git.openjdk.java.net/loom/commit/026b85303c01326bc49a1105a89853d7641fcd50 8283298: Make CodeCacheSegmentSize a product flag Reviewed-by: dlong, kvn ! src/hotspot/share/interpreter/templateInterpreter.cpp ! src/hotspot/share/prims/methodHandles.cpp ! src/hotspot/share/runtime/globals.hpp ! test/hotspot/jtreg/compiler/arguments/TestCodeEntryAlignment.java Changeset: d8c55725 Author: Quan Anh Mai Committer: Jie Fu Date: 2022-03-23 09:45:23 +0000 URL: https://git.openjdk.java.net/loom/commit/d8c55725e0f85e21c16bb81e3f1a9bcfacc59f87 8282204: Use lea instructions for arithmetic operations on x86_64 Reviewed-by: jiefu, sviswanathan, thartmann ! src/hotspot/cpu/x86/assembler_x86.cpp ! src/hotspot/cpu/x86/vm_version_x86.hpp ! src/hotspot/cpu/x86/x86_64.ad + test/micro/org/openjdk/bench/vm/compiler/LeaInstruction.java Changeset: 91fab6ad Author: Jaikiran Pai Date: 2022-03-23 09:47:44 +0000 URL: https://git.openjdk.java.net/loom/commit/91fab6ad59d2a4baf58802fc6e6039af3dd8d578 8283411: InflaterInputStream holds on to a temporary byte array of 512 bytes Reviewed-by: lancea, vtewari, alanb ! src/java.base/share/classes/java/util/zip/InflaterInputStream.java Changeset: 6ed0ba2f Author: Vicente Romero Date: 2022-03-23 10:34:09 +0000 URL: https://git.openjdk.java.net/loom/commit/6ed0ba2f8a2af58c45a6b7be684ef30d15af6ead 8283543: indentation error at com.sun.tools.javac.comp.Enter::visitTopLevel Reviewed-by: darcy, iris ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Enter.java Changeset: 61d7d868 Author: Kevin Walls Date: 2022-03-23 11:03:25 +0000 URL: https://git.openjdk.java.net/loom/commit/61d7d868db030d878f4a1c4467075e8d4e116a6e 8283254: Remove redundant class jdk/internal/agent/spi/AgentProvider Reviewed-by: mchung, redestad, dfuchs ! src/jdk.management.agent/share/classes/jdk/internal/agent/Agent.java - src/jdk.management.agent/share/classes/jdk/internal/agent/spi/AgentProvider.java ! src/jdk.management.agent/share/classes/module-info.java Changeset: 78ef2fde Author: Thomas Stuefe Date: 2022-03-23 12:55:28 +0000 URL: https://git.openjdk.java.net/loom/commit/78ef2fdef68c5161c8875296e9479026ac89743a 8283562: JDK-8282306 breaks gtests on zero Reviewed-by: shade ! test/hotspot/gtest/runtime/test_os.cpp Changeset: ccda5b66 Author: Alan Bateman Date: 2022-03-24 05:43:03 +0000 URL: https://git.openjdk.java.net/loom/commit/ccda5b66cdf4733c3f5329d93e157c982b6779ce Merge with jdk-19+15 ! src/hotspot/cpu/aarch64/frame_aarch64.inline.hpp ! src/hotspot/cpu/arm/frame_arm.inline.hpp ! src/hotspot/cpu/ppc/frame_ppc.inline.hpp ! src/hotspot/cpu/s390/frame_s390.inline.hpp ! src/hotspot/cpu/x86/assembler_x86.cpp ! src/hotspot/cpu/x86/frame_x86.inline.hpp ! src/hotspot/cpu/x86/interp_masm_x86.cpp ! src/hotspot/cpu/x86/interp_masm_x86.hpp ! src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp ! src/hotspot/cpu/x86/templateTable_x86.cpp ! src/hotspot/cpu/x86/vm_version_x86.hpp ! src/hotspot/cpu/x86/x86_64.ad ! src/hotspot/cpu/zero/frame_zero.inline.hpp ! src/hotspot/share/c1/c1_LIRAssembler.cpp ! src/hotspot/share/c1/c1_LIRAssembler.hpp ! src/hotspot/share/gc/parallel/psPromotionManager.inline.hpp ! src/hotspot/share/runtime/frame.hpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/thread.inline.hpp ! src/hotspot/share/utilities/globalDefinitions.hpp ! src/hotspot/share/utilities/vmError.cpp ! src/java.base/share/classes/java/lang/ref/Reference.java = src/java.se/share/data/jdwp/jdwp.spec ! src/hotspot/cpu/aarch64/frame_aarch64.inline.hpp ! src/hotspot/cpu/arm/frame_arm.inline.hpp ! src/hotspot/cpu/ppc/frame_ppc.inline.hpp ! src/hotspot/cpu/s390/frame_s390.inline.hpp ! src/hotspot/cpu/x86/assembler_x86.cpp ! src/hotspot/cpu/x86/frame_x86.inline.hpp ! src/hotspot/cpu/x86/interp_masm_x86.cpp ! src/hotspot/cpu/x86/interp_masm_x86.hpp ! src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp ! src/hotspot/cpu/x86/templateTable_x86.cpp ! src/hotspot/cpu/x86/vm_version_x86.hpp ! src/hotspot/cpu/x86/x86_64.ad ! src/hotspot/cpu/zero/frame_zero.inline.hpp ! src/hotspot/share/c1/c1_LIRAssembler.cpp ! src/hotspot/share/c1/c1_LIRAssembler.hpp ! src/hotspot/share/gc/parallel/psPromotionManager.inline.hpp ! src/hotspot/share/runtime/frame.hpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/thread.inline.hpp ! src/hotspot/share/utilities/globalDefinitions.hpp ! src/hotspot/share/utilities/vmError.cpp ! src/java.base/share/classes/java/lang/ref/Reference.java ! src/java.se/share/data/jdwp/jdwp.spec Changeset: f436d45f Author: Alan Bateman Date: 2022-03-24 07:09:35 +0000 URL: https://git.openjdk.java.net/loom/commit/f436d45fee76aa93db26880021d3babaec1b5657 Exclude runtime/Thread/StopAtExit.java ! test/hotspot/jtreg/ProblemList.txt From duke at openjdk.java.net Thu Mar 24 07:30:29 2022 From: duke at openjdk.java.net (duke) Date: Thu, 24 Mar 2022 07:30:29 GMT Subject: git: openjdk/loom: master: 34 new changesets Message-ID: <633dc745-0fe3-477a-a76e-bab622d97c05@openjdk.java.net> Changeset: b617f1db Author: Thomas Schatzl Date: 2022-03-21 11:30:26 +0000 URL: https://git.openjdk.java.net/loom/commit/b617f1db4ec5d54b1ea541fb885e296da928f166 8283447: Remove unused LIR_Assembler::_bs Reviewed-by: redestad ! src/hotspot/share/c1/c1_LIRAssembler.cpp ! src/hotspot/share/c1/c1_LIRAssembler.hpp Changeset: 909986c7 Author: Zhengyu Gu Date: 2022-03-21 12:26:58 +0000 URL: https://git.openjdk.java.net/loom/commit/909986c7e110c8ac3ba16750be7707b1ec344ee5 8283217: Leak FcObjectSet in getFontConfigLocations() in fontpath.c Reviewed-by: prr, aivanov ! src/java.desktop/unix/native/common/awt/fontpath.c Changeset: cb576da5 Author: Zhengyu Gu Date: 2022-03-21 12:28:17 +0000 URL: https://git.openjdk.java.net/loom/commit/cb576da575ea3c8f14087dd312313843764ca2f4 8283379: Memory leak in FileHeaderHelper Reviewed-by: dholmes, iklam, stuefe ! src/hotspot/share/cds/filemap.cpp Changeset: c4dc58e1 Author: Naoto Sato Date: 2022-03-21 15:33:09 +0000 URL: https://git.openjdk.java.net/loom/commit/c4dc58e12e197562dce90c0027aa74c29047cea6 8283277: ISO 4217 Amendment 171 Update Reviewed-by: iris, joehw ! make/data/currency/CurrencyData.properties ! src/java.base/share/classes/sun/util/resources/CurrencyNames.properties ! test/jdk/java/util/Currency/ValidateISO4217.java ! test/jdk/java/util/Currency/tablea1.txt ! test/jdk/sun/text/resources/LocaleData ! test/jdk/sun/text/resources/LocaleDataTest.java Changeset: 999da9bf Author: Johannes Bechberger Committer: Thomas Stuefe Date: 2022-03-21 15:49:59 +0000 URL: https://git.openjdk.java.net/loom/commit/999da9bfc5be703141cdc07af455b4b6b2cc1aae 8282306: os::is_first_C_frame(frame*) crashes on invalid link access Reviewed-by: stuefe, mdoerr ! src/hotspot/cpu/aarch64/frame_aarch64.inline.hpp ! src/hotspot/cpu/arm/frame_arm.inline.hpp ! src/hotspot/cpu/ppc/frame_ppc.inline.hpp ! src/hotspot/cpu/s390/frame_s390.inline.hpp ! src/hotspot/cpu/x86/frame_x86.inline.hpp ! src/hotspot/cpu/zero/frame_zero.inline.hpp ! src/hotspot/share/runtime/frame.hpp ! src/hotspot/share/runtime/os.cpp ! src/hotspot/share/runtime/safefetch.inline.hpp ! src/hotspot/share/runtime/thread.cpp ! test/hotspot/gtest/runtime/test_os.cpp Changeset: 19d34bdf Author: Albert Mingkun Yang Date: 2022-03-21 16:20:20 +0000 URL: https://git.openjdk.java.net/loom/commit/19d34bdf99e98a9ef614cb7f93c141e6c82bedcb 8281879: Serial: Merge CardGeneration into TenuredGeneration Reviewed-by: tschatzl, iwalulya ! src/hotspot/share/gc/serial/tenuredGeneration.cpp ! src/hotspot/share/gc/serial/tenuredGeneration.hpp ! src/hotspot/share/gc/serial/tenuredGeneration.inline.hpp ! src/hotspot/share/gc/serial/vmStructs_serial.hpp - src/hotspot/share/gc/shared/cardGeneration.cpp - src/hotspot/share/gc/shared/cardGeneration.hpp - src/hotspot/share/gc/shared/cardGeneration.inline.hpp ! src/hotspot/share/gc/shared/generation.hpp ! src/hotspot/share/gc/shared/vmStructs_gc.hpp ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/serial/TenuredGeneration.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/CardGeneration.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/Generation.java ! test/hotspot/jtreg/serviceability/sa/ClhsdbVmStructsDump.java ! test/hotspot/jtreg/serviceability/sa/TestType.java Changeset: f4f87284 Author: Albert Mingkun Yang Date: 2022-03-21 16:21:30 +0000 URL: https://git.openjdk.java.net/loom/commit/f4f87284cbbe95958d8c7d8adc0f5c5e260892ca 8283097: Parallel: Move filler object logic inside PSPromotionLAB::unallocate_object Reviewed-by: tschatzl, iwalulya ! src/hotspot/share/gc/parallel/psPromotionLAB.cpp ! src/hotspot/share/gc/parallel/psPromotionLAB.hpp ! src/hotspot/share/gc/parallel/psPromotionManager.inline.hpp Changeset: 14b9e80b Author: Joe Darcy Date: 2022-03-21 16:57:17 +0000 URL: https://git.openjdk.java.net/loom/commit/14b9e80b8adcc0ab0634357f5a7c25f24fd6808c 8283415: Update java.lang.ref to use sealed classes Reviewed-by: kbarrett, alanb ! src/java.base/share/classes/java/lang/ref/FinalReference.java ! src/java.base/share/classes/java/lang/ref/PhantomReference.java ! src/java.base/share/classes/java/lang/ref/Reference.java ! src/java.base/share/classes/java/lang/ref/SoftReference.java ! src/java.base/share/classes/java/lang/ref/WeakReference.java Changeset: f8878cb0 Author: Magnus Ihse Bursie Date: 2022-03-21 21:34:09 +0000 URL: https://git.openjdk.java.net/loom/commit/f8878cb0cc436993ef1222bc13b00b923d91aad1 8257733: Move module-specific data from make to respective module Reviewed-by: jjg, weijun, naoto, erikj, prr, alanb, mchung ! make/ModuleWrapper.gmk ! make/ToolsJdk.gmk ! make/UpdateX11Wrappers.gmk ! make/langtools/src/classes/build/tools/symbolgenerator/CreateSymbols.java ! make/modules/java.base/Gendata.gmk ! make/modules/java.base/Gensrc.gmk ! make/modules/java.base/gendata/GendataBlockedCerts.gmk ! make/modules/java.base/gendata/GendataBreakIterator.gmk ! make/modules/java.base/gendata/GendataPublicSuffixList.gmk ! make/modules/java.base/gendata/GendataTZDB.gmk ! make/modules/java.base/gensrc/GensrcBuffer.gmk ! make/modules/java.base/gensrc/GensrcCharacterData.gmk ! make/modules/java.base/gensrc/GensrcCharsetCoder.gmk ! make/modules/java.base/gensrc/GensrcEmojiData.gmk ! make/modules/java.base/gensrc/GensrcExceptions.gmk ! make/modules/java.base/gensrc/GensrcLocaleData.gmk ! make/modules/java.base/gensrc/GensrcScopedMemoryAccess.gmk ! make/modules/java.base/gensrc/GensrcVarHandles.gmk ! make/modules/java.desktop/gendata/GendataFontConfig.gmk ! make/modules/java.desktop/gensrc/GensrcIcons.gmk ! make/modules/java.desktop/gensrc/GensrcSwing.gmk ! make/modules/java.desktop/gensrc/GensrcX11Wrappers.gmk ! make/modules/jdk.charsets/Gensrc.gmk ! make/modules/jdk.compiler/Gendata.gmk ! make/modules/jdk.javadoc/Gendata.gmk ! make/modules/jdk.jdi/Gensrc.gmk ! make/modules/jdk.localedata/Gensrc.gmk ! make/scripts/generate-symbol-data.sh = src/java.base/share/classes/java/lang/CharacterData00.java.template = src/java.base/share/classes/java/lang/CharacterData01.java.template = src/java.base/share/classes/java/lang/CharacterData02.java.template = src/java.base/share/classes/java/lang/CharacterData03.java.template = src/java.base/share/classes/java/lang/CharacterData0E.java.template = src/java.base/share/classes/java/lang/CharacterDataLatin1.java.template = src/java.base/share/data/blockedcertsconverter/blocked.certs.pem = src/java.base/share/data/cacerts/README = src/java.base/share/data/cacerts/actalisauthenticationrootca = src/java.base/share/data/cacerts/addtrustexternalca = src/java.base/share/data/cacerts/addtrustqualifiedca = src/java.base/share/data/cacerts/affirmtrustcommercialca = src/java.base/share/data/cacerts/affirmtrustnetworkingca = src/java.base/share/data/cacerts/affirmtrustpremiumca = src/java.base/share/data/cacerts/affirmtrustpremiumeccca = src/java.base/share/data/cacerts/amazonrootca1 = src/java.base/share/data/cacerts/amazonrootca2 = src/java.base/share/data/cacerts/amazonrootca3 = src/java.base/share/data/cacerts/amazonrootca4 = src/java.base/share/data/cacerts/baltimorecybertrustca = src/java.base/share/data/cacerts/buypassclass2ca = src/java.base/share/data/cacerts/buypassclass3ca = src/java.base/share/data/cacerts/camerfirmachambersca = src/java.base/share/data/cacerts/camerfirmachamberscommerceca = src/java.base/share/data/cacerts/camerfirmachambersignca = src/java.base/share/data/cacerts/certumca = src/java.base/share/data/cacerts/certumtrustednetworkca = src/java.base/share/data/cacerts/chunghwaepkirootca = src/java.base/share/data/cacerts/comodoaaaca = src/java.base/share/data/cacerts/comodoeccca = src/java.base/share/data/cacerts/comodorsaca = src/java.base/share/data/cacerts/digicertassuredidg2 = src/java.base/share/data/cacerts/digicertassuredidg3 = src/java.base/share/data/cacerts/digicertassuredidrootca = src/java.base/share/data/cacerts/digicertglobalrootca = src/java.base/share/data/cacerts/digicertglobalrootg2 = src/java.base/share/data/cacerts/digicertglobalrootg3 = src/java.base/share/data/cacerts/digicerthighassuranceevrootca = src/java.base/share/data/cacerts/digicerttrustedrootg4 = src/java.base/share/data/cacerts/dtrustclass3ca2 = src/java.base/share/data/cacerts/dtrustclass3ca2ev = src/java.base/share/data/cacerts/entrust2048ca = src/java.base/share/data/cacerts/entrustevca = src/java.base/share/data/cacerts/entrustrootcaec1 = src/java.base/share/data/cacerts/entrustrootcag2 = src/java.base/share/data/cacerts/entrustrootcag4 = src/java.base/share/data/cacerts/geotrustglobalca = src/java.base/share/data/cacerts/geotrustprimaryca = src/java.base/share/data/cacerts/geotrustprimarycag2 = src/java.base/share/data/cacerts/geotrustprimarycag3 = src/java.base/share/data/cacerts/geotrustuniversalca = src/java.base/share/data/cacerts/globalsignca = src/java.base/share/data/cacerts/globalsigneccrootcar4 = src/java.base/share/data/cacerts/globalsigneccrootcar5 = src/java.base/share/data/cacerts/globalsignr3ca = src/java.base/share/data/cacerts/globalsignrootcar6 = src/java.base/share/data/cacerts/godaddyclass2ca = src/java.base/share/data/cacerts/godaddyrootg2ca = src/java.base/share/data/cacerts/haricaeccrootca2015 = src/java.base/share/data/cacerts/haricarootca2015 = src/java.base/share/data/cacerts/identrustcommercial = src/java.base/share/data/cacerts/identrustpublicca = src/java.base/share/data/cacerts/letsencryptisrgx1 = src/java.base/share/data/cacerts/luxtrustglobalroot2ca = src/java.base/share/data/cacerts/luxtrustglobalrootca = src/java.base/share/data/cacerts/quovadisrootca = src/java.base/share/data/cacerts/quovadisrootca1g3 = src/java.base/share/data/cacerts/quovadisrootca2 = src/java.base/share/data/cacerts/quovadisrootca2g3 = src/java.base/share/data/cacerts/quovadisrootca3 = src/java.base/share/data/cacerts/quovadisrootca3g3 = src/java.base/share/data/cacerts/secomscrootca1 = src/java.base/share/data/cacerts/secomscrootca2 = src/java.base/share/data/cacerts/securetrustca = src/java.base/share/data/cacerts/sslrooteccca = src/java.base/share/data/cacerts/sslrootevrsaca = src/java.base/share/data/cacerts/sslrootrsaca = src/java.base/share/data/cacerts/starfieldclass2ca = src/java.base/share/data/cacerts/starfieldrootg2ca = src/java.base/share/data/cacerts/starfieldservicesrootg2ca = src/java.base/share/data/cacerts/swisssigngoldg2ca = src/java.base/share/data/cacerts/swisssignplatinumg2ca = src/java.base/share/data/cacerts/swisssignsilverg2ca = src/java.base/share/data/cacerts/teliasonerarootcav1 = src/java.base/share/data/cacerts/thawteprimaryrootca = src/java.base/share/data/cacerts/thawteprimaryrootcag2 = src/java.base/share/data/cacerts/thawteprimaryrootcag3 = src/java.base/share/data/cacerts/ttelesecglobalrootclass2ca = src/java.base/share/data/cacerts/ttelesecglobalrootclass3ca = src/java.base/share/data/cacerts/usertrusteccca = src/java.base/share/data/cacerts/usertrustrsaca = src/java.base/share/data/cacerts/utnuserfirstobjectca = src/java.base/share/data/cacerts/verisignclass3g3ca = src/java.base/share/data/cacerts/verisignclass3g4ca = src/java.base/share/data/cacerts/verisignclass3g5ca = src/java.base/share/data/cacerts/verisignuniversalrootca = src/java.base/share/data/cacerts/xrampglobalca = src/java.base/share/data/currency/CurrencyData.properties = src/java.base/share/data/lsrdata/language-subtag-registry.txt = src/java.base/share/data/publicsuffixlist/VERSION = src/java.base/share/data/publicsuffixlist/public_suffix_list.dat = src/java.base/share/data/tzdata/VERSION = src/java.base/share/data/tzdata/africa = src/java.base/share/data/tzdata/antarctica = src/java.base/share/data/tzdata/asia = src/java.base/share/data/tzdata/australasia = src/java.base/share/data/tzdata/backward = src/java.base/share/data/tzdata/etcetera = src/java.base/share/data/tzdata/europe = src/java.base/share/data/tzdata/factory = src/java.base/share/data/tzdata/gmt = src/java.base/share/data/tzdata/iso3166.tab = src/java.base/share/data/tzdata/jdk11_backward = src/java.base/share/data/tzdata/leapseconds = src/java.base/share/data/tzdata/northamerica = src/java.base/share/data/tzdata/solar87 = src/java.base/share/data/tzdata/solar88 = src/java.base/share/data/tzdata/solar89 = src/java.base/share/data/tzdata/southamerica = src/java.base/share/data/tzdata/zone.tab = src/java.base/share/data/unicodedata/Blocks.txt = src/java.base/share/data/unicodedata/DerivedCoreProperties.txt = src/java.base/share/data/unicodedata/NormalizationTest.txt = src/java.base/share/data/unicodedata/PropList.txt = src/java.base/share/data/unicodedata/PropertyValueAliases.txt = src/java.base/share/data/unicodedata/ReadMe.txt = src/java.base/share/data/unicodedata/Scripts.txt = src/java.base/share/data/unicodedata/SpecialCasing.txt = src/java.base/share/data/unicodedata/UnicodeData.txt = src/java.base/share/data/unicodedata/auxiliary/GraphemeBreakProperty.txt = src/java.base/share/data/unicodedata/auxiliary/GraphemeBreakTest.txt = src/java.base/share/data/unicodedata/emoji/emoji-data.txt = src/java.desktop/aix/data/fontconfig/fontconfig.properties = src/java.desktop/bsd/data/fontconfig/fontconfig.properties = src/java.desktop/macosx/data/fontconfig/fontconfig.properties = src/java.desktop/macosx/data/macosxicons/JavaApp.icns = src/java.desktop/share/data/dtdbuilder/HTMLlat1.sgml = src/java.desktop/share/data/dtdbuilder/HTMLspecial.sgml = src/java.desktop/share/data/dtdbuilder/HTMLsymbol.sgml = src/java.desktop/share/data/dtdbuilder/html32.dtd = src/java.desktop/share/data/dtdbuilder/public.map = src/java.desktop/unix/data/x11wrappergen/sizes-32.txt = src/java.desktop/unix/data/x11wrappergen/sizes-64.txt = src/java.desktop/unix/data/x11wrappergen/xlibtypes.txt = src/java.desktop/windows/data/fontconfig/fontconfig.properties = src/java.se/share/data/jdwp/jdwp.spec = src/jdk.compiler/share/data/symbols/README = src/jdk.compiler/share/data/symbols/include.list = src/jdk.compiler/share/data/symbols/java.activation-8.sym.txt = src/jdk.compiler/share/data/symbols/java.activation-9.sym.txt = src/jdk.compiler/share/data/symbols/java.activation-A.sym.txt = src/jdk.compiler/share/data/symbols/java.activation-B.sym.txt = src/jdk.compiler/share/data/symbols/java.base-7.sym.txt = src/jdk.compiler/share/data/symbols/java.base-8.sym.txt = src/jdk.compiler/share/data/symbols/java.base-9.sym.txt = src/jdk.compiler/share/data/symbols/java.base-A.sym.txt = src/jdk.compiler/share/data/symbols/java.base-B.sym.txt = src/jdk.compiler/share/data/symbols/java.base-C.sym.txt = src/jdk.compiler/share/data/symbols/java.base-D.sym.txt = src/jdk.compiler/share/data/symbols/java.base-E.sym.txt = src/jdk.compiler/share/data/symbols/java.base-F.sym.txt = src/jdk.compiler/share/data/symbols/java.base-G.sym.txt = src/jdk.compiler/share/data/symbols/java.base-H.sym.txt = src/jdk.compiler/share/data/symbols/java.base-I.sym.txt = src/jdk.compiler/share/data/symbols/java.compiler-7.sym.txt = src/jdk.compiler/share/data/symbols/java.compiler-8.sym.txt = src/jdk.compiler/share/data/symbols/java.compiler-9.sym.txt = src/jdk.compiler/share/data/symbols/java.compiler-A.sym.txt = src/jdk.compiler/share/data/symbols/java.compiler-B.sym.txt = src/jdk.compiler/share/data/symbols/java.compiler-C.sym.txt = src/jdk.compiler/share/data/symbols/java.compiler-D.sym.txt = src/jdk.compiler/share/data/symbols/java.compiler-E.sym.txt = src/jdk.compiler/share/data/symbols/java.compiler-F.sym.txt = src/jdk.compiler/share/data/symbols/java.compiler-G.sym.txt = src/jdk.compiler/share/data/symbols/java.compiler-H.sym.txt = src/jdk.compiler/share/data/symbols/java.compiler-I.sym.txt = src/jdk.compiler/share/data/symbols/java.corba-8.sym.txt = src/jdk.compiler/share/data/symbols/java.corba-9.sym.txt = src/jdk.compiler/share/data/symbols/java.corba-A.sym.txt = src/jdk.compiler/share/data/symbols/java.corba-B.sym.txt = src/jdk.compiler/share/data/symbols/java.datatransfer-7.sym.txt = src/jdk.compiler/share/data/symbols/java.datatransfer-8.sym.txt = src/jdk.compiler/share/data/symbols/java.datatransfer-9.sym.txt = src/jdk.compiler/share/data/symbols/java.datatransfer-A.sym.txt = src/jdk.compiler/share/data/symbols/java.datatransfer-B.sym.txt = src/jdk.compiler/share/data/symbols/java.datatransfer-G.sym.txt = src/jdk.compiler/share/data/symbols/java.datatransfer-H.sym.txt = src/jdk.compiler/share/data/symbols/java.datatransfer-I.sym.txt = src/jdk.compiler/share/data/symbols/java.desktop-7.sym.txt = src/jdk.compiler/share/data/symbols/java.desktop-8.sym.txt = src/jdk.compiler/share/data/symbols/java.desktop-9.sym.txt = src/jdk.compiler/share/data/symbols/java.desktop-A.sym.txt = src/jdk.compiler/share/data/symbols/java.desktop-B.sym.txt = src/jdk.compiler/share/data/symbols/java.desktop-C.sym.txt = src/jdk.compiler/share/data/symbols/java.desktop-D.sym.txt = src/jdk.compiler/share/data/symbols/java.desktop-E.sym.txt = src/jdk.compiler/share/data/symbols/java.desktop-F.sym.txt = src/jdk.compiler/share/data/symbols/java.desktop-G.sym.txt = src/jdk.compiler/share/data/symbols/java.desktop-H.sym.txt = src/jdk.compiler/share/data/symbols/java.desktop-I.sym.txt = src/jdk.compiler/share/data/symbols/java.instrument-8.sym.txt = src/jdk.compiler/share/data/symbols/java.instrument-9.sym.txt = src/jdk.compiler/share/data/symbols/java.instrument-A.sym.txt = src/jdk.compiler/share/data/symbols/java.instrument-B.sym.txt = src/jdk.compiler/share/data/symbols/java.instrument-G.sym.txt = src/jdk.compiler/share/data/symbols/java.instrument-H.sym.txt = src/jdk.compiler/share/data/symbols/java.instrument-I.sym.txt = src/jdk.compiler/share/data/symbols/java.logging-7.sym.txt = src/jdk.compiler/share/data/symbols/java.logging-8.sym.txt = src/jdk.compiler/share/data/symbols/java.logging-9.sym.txt = src/jdk.compiler/share/data/symbols/java.logging-A.sym.txt = src/jdk.compiler/share/data/symbols/java.logging-B.sym.txt = src/jdk.compiler/share/data/symbols/java.logging-G.sym.txt = src/jdk.compiler/share/data/symbols/java.logging-H.sym.txt = src/jdk.compiler/share/data/symbols/java.logging-I.sym.txt = src/jdk.compiler/share/data/symbols/java.management-7.sym.txt = src/jdk.compiler/share/data/symbols/java.management-8.sym.txt = src/jdk.compiler/share/data/symbols/java.management-9.sym.txt = src/jdk.compiler/share/data/symbols/java.management-A.sym.txt = src/jdk.compiler/share/data/symbols/java.management-B.sym.txt = src/jdk.compiler/share/data/symbols/java.management-D.sym.txt = src/jdk.compiler/share/data/symbols/java.management-G.sym.txt = src/jdk.compiler/share/data/symbols/java.management-H.sym.txt = src/jdk.compiler/share/data/symbols/java.management-I.sym.txt = src/jdk.compiler/share/data/symbols/java.management.rmi-8.sym.txt = src/jdk.compiler/share/data/symbols/java.management.rmi-9.sym.txt = src/jdk.compiler/share/data/symbols/java.management.rmi-A.sym.txt = src/jdk.compiler/share/data/symbols/java.management.rmi-B.sym.txt = src/jdk.compiler/share/data/symbols/java.management.rmi-D.sym.txt = src/jdk.compiler/share/data/symbols/java.management.rmi-F.sym.txt = src/jdk.compiler/share/data/symbols/java.management.rmi-G.sym.txt = src/jdk.compiler/share/data/symbols/java.management.rmi-H.sym.txt = src/jdk.compiler/share/data/symbols/java.management.rmi-I.sym.txt = src/jdk.compiler/share/data/symbols/java.naming-7.sym.txt = src/jdk.compiler/share/data/symbols/java.naming-8.sym.txt = src/jdk.compiler/share/data/symbols/java.naming-9.sym.txt = src/jdk.compiler/share/data/symbols/java.naming-A.sym.txt = src/jdk.compiler/share/data/symbols/java.naming-B.sym.txt = src/jdk.compiler/share/data/symbols/java.naming-C.sym.txt = src/jdk.compiler/share/data/symbols/java.naming-F.sym.txt = src/jdk.compiler/share/data/symbols/java.naming-G.sym.txt = src/jdk.compiler/share/data/symbols/java.naming-H.sym.txt = src/jdk.compiler/share/data/symbols/java.naming-I.sym.txt = src/jdk.compiler/share/data/symbols/java.net.http-B.sym.txt = src/jdk.compiler/share/data/symbols/java.net.http-D.sym.txt = src/jdk.compiler/share/data/symbols/java.net.http-G.sym.txt = src/jdk.compiler/share/data/symbols/java.net.http-I.sym.txt = src/jdk.compiler/share/data/symbols/java.prefs-7.sym.txt = src/jdk.compiler/share/data/symbols/java.prefs-8.sym.txt = src/jdk.compiler/share/data/symbols/java.prefs-9.sym.txt = src/jdk.compiler/share/data/symbols/java.prefs-A.sym.txt = src/jdk.compiler/share/data/symbols/java.prefs-B.sym.txt = src/jdk.compiler/share/data/symbols/java.rmi-7.sym.txt = src/jdk.compiler/share/data/symbols/java.rmi-8.sym.txt = src/jdk.compiler/share/data/symbols/java.rmi-9.sym.txt = src/jdk.compiler/share/data/symbols/java.rmi-A.sym.txt = src/jdk.compiler/share/data/symbols/java.rmi-B.sym.txt = src/jdk.compiler/share/data/symbols/java.rmi-C.sym.txt = src/jdk.compiler/share/data/symbols/java.rmi-F.sym.txt = src/jdk.compiler/share/data/symbols/java.rmi-G.sym.txt = src/jdk.compiler/share/data/symbols/java.rmi-H.sym.txt = src/jdk.compiler/share/data/symbols/java.rmi-I.sym.txt = src/jdk.compiler/share/data/symbols/java.scripting-7.sym.txt = src/jdk.compiler/share/data/symbols/java.scripting-8.sym.txt = src/jdk.compiler/share/data/symbols/java.scripting-9.sym.txt = src/jdk.compiler/share/data/symbols/java.scripting-A.sym.txt = src/jdk.compiler/share/data/symbols/java.scripting-B.sym.txt = src/jdk.compiler/share/data/symbols/java.scripting-G.sym.txt = src/jdk.compiler/share/data/symbols/java.scripting-H.sym.txt = src/jdk.compiler/share/data/symbols/java.scripting-I.sym.txt = src/jdk.compiler/share/data/symbols/java.se-9.sym.txt = src/jdk.compiler/share/data/symbols/java.se-A.sym.txt = src/jdk.compiler/share/data/symbols/java.se-B.sym.txt = src/jdk.compiler/share/data/symbols/java.se.ee-9.sym.txt = src/jdk.compiler/share/data/symbols/java.se.ee-A.sym.txt = src/jdk.compiler/share/data/symbols/java.se.ee-B.sym.txt = src/jdk.compiler/share/data/symbols/java.security.jgss-7.sym.txt = src/jdk.compiler/share/data/symbols/java.security.jgss-8.sym.txt = src/jdk.compiler/share/data/symbols/java.security.jgss-9.sym.txt = src/jdk.compiler/share/data/symbols/java.security.jgss-A.sym.txt = src/jdk.compiler/share/data/symbols/java.security.jgss-B.sym.txt = src/jdk.compiler/share/data/symbols/java.security.jgss-D.sym.txt = src/jdk.compiler/share/data/symbols/java.security.jgss-G.sym.txt = src/jdk.compiler/share/data/symbols/java.security.jgss-H.sym.txt = src/jdk.compiler/share/data/symbols/java.security.jgss-I.sym.txt = src/jdk.compiler/share/data/symbols/java.security.sasl-7.sym.txt = src/jdk.compiler/share/data/symbols/java.security.sasl-8.sym.txt = src/jdk.compiler/share/data/symbols/java.security.sasl-9.sym.txt = src/jdk.compiler/share/data/symbols/java.security.sasl-A.sym.txt = src/jdk.compiler/share/data/symbols/java.security.sasl-B.sym.txt = src/jdk.compiler/share/data/symbols/java.security.sasl-G.sym.txt = src/jdk.compiler/share/data/symbols/java.security.sasl-H.sym.txt = src/jdk.compiler/share/data/symbols/java.security.sasl-I.sym.txt = src/jdk.compiler/share/data/symbols/java.smartcardio-9.sym.txt = src/jdk.compiler/share/data/symbols/java.smartcardio-A.sym.txt = src/jdk.compiler/share/data/symbols/java.smartcardio-B.sym.txt = src/jdk.compiler/share/data/symbols/java.smartcardio-G.sym.txt = src/jdk.compiler/share/data/symbols/java.smartcardio-H.sym.txt = src/jdk.compiler/share/data/symbols/java.smartcardio-I.sym.txt = src/jdk.compiler/share/data/symbols/java.sql-7.sym.txt = src/jdk.compiler/share/data/symbols/java.sql-8.sym.txt = src/jdk.compiler/share/data/symbols/java.sql-9.sym.txt = src/jdk.compiler/share/data/symbols/java.sql-A.sym.txt = src/jdk.compiler/share/data/symbols/java.sql-B.sym.txt = src/jdk.compiler/share/data/symbols/java.sql-G.sym.txt = src/jdk.compiler/share/data/symbols/java.sql-H.sym.txt = src/jdk.compiler/share/data/symbols/java.sql-I.sym.txt = src/jdk.compiler/share/data/symbols/java.sql.rowset-7.sym.txt = src/jdk.compiler/share/data/symbols/java.sql.rowset-8.sym.txt = src/jdk.compiler/share/data/symbols/java.sql.rowset-9.sym.txt = src/jdk.compiler/share/data/symbols/java.sql.rowset-A.sym.txt = src/jdk.compiler/share/data/symbols/java.sql.rowset-B.sym.txt = src/jdk.compiler/share/data/symbols/java.sql.rowset-G.sym.txt = src/jdk.compiler/share/data/symbols/java.sql.rowset-H.sym.txt = src/jdk.compiler/share/data/symbols/java.sql.rowset-I.sym.txt = src/jdk.compiler/share/data/symbols/java.transaction-8.sym.txt = src/jdk.compiler/share/data/symbols/java.transaction-9.sym.txt = src/jdk.compiler/share/data/symbols/java.transaction-A.sym.txt = src/jdk.compiler/share/data/symbols/java.transaction-B.sym.txt = src/jdk.compiler/share/data/symbols/java.transaction.xa-B.sym.txt = src/jdk.compiler/share/data/symbols/java.xml-7.sym.txt = src/jdk.compiler/share/data/symbols/java.xml-8.sym.txt = src/jdk.compiler/share/data/symbols/java.xml-9.sym.txt = src/jdk.compiler/share/data/symbols/java.xml-A.sym.txt = src/jdk.compiler/share/data/symbols/java.xml-B.sym.txt = src/jdk.compiler/share/data/symbols/java.xml-C.sym.txt = src/jdk.compiler/share/data/symbols/java.xml-D.sym.txt = src/jdk.compiler/share/data/symbols/java.xml-E.sym.txt = src/jdk.compiler/share/data/symbols/java.xml-F.sym.txt = src/jdk.compiler/share/data/symbols/java.xml-G.sym.txt = src/jdk.compiler/share/data/symbols/java.xml-H.sym.txt = src/jdk.compiler/share/data/symbols/java.xml-I.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.bind-7.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.bind-8.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.bind-9.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.bind-A.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.bind-B.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.crypto-8.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.crypto-9.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.crypto-A.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.crypto-B.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.crypto-D.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.crypto-G.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.crypto-H.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.crypto-I.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.ws-8.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.ws-9.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.ws-A.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.ws-B.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.ws.annotation-7.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.ws.annotation-8.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.ws.annotation-9.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.ws.annotation-A.sym.txt = src/jdk.compiler/share/data/symbols/java.xml.ws.annotation-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.accessibility-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.accessibility-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.accessibility-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.accessibility-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.accessibility-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.accessibility-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.attach-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.attach-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.attach-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.attach-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.attach-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.attach-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.charsets-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.charsets-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.charsets-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.compiler-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.compiler-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.compiler-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.compiler-C.sym.txt = src/jdk.compiler/share/data/symbols/jdk.compiler-D.sym.txt = src/jdk.compiler/share/data/symbols/jdk.compiler-E.sym.txt = src/jdk.compiler/share/data/symbols/jdk.compiler-F.sym.txt = src/jdk.compiler/share/data/symbols/jdk.compiler-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.compiler-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.compiler-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.crypto.cryptoki-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.crypto.cryptoki-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.crypto.cryptoki-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.crypto.ec-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.crypto.ec-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.crypto.ec-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.dynalink-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.dynalink-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.dynalink-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.dynalink-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.dynalink-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.dynalink-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.editpad-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.editpad-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.editpad-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.hotspot.agent-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.hotspot.agent-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.hotspot.agent-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.httpserver-7.sym.txt = src/jdk.compiler/share/data/symbols/jdk.httpserver-8.sym.txt = src/jdk.compiler/share/data/symbols/jdk.httpserver-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.httpserver-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.httpserver-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.httpserver-D.sym.txt = src/jdk.compiler/share/data/symbols/jdk.httpserver-E.sym.txt = src/jdk.compiler/share/data/symbols/jdk.httpserver-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.httpserver-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.httpserver-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.incubator.foreign-E.sym.txt = src/jdk.compiler/share/data/symbols/jdk.incubator.foreign-F.sym.txt = src/jdk.compiler/share/data/symbols/jdk.incubator.foreign-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.incubator.foreign-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.incubator.foreign-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.incubator.httpclient-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.incubator.httpclient-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.incubator.httpclient-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.incubator.jpackage-E.sym.txt = src/jdk.compiler/share/data/symbols/jdk.incubator.jpackage-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.incubator.vector-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.incubator.vector-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.incubator.vector-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jartool-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jartool-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jartool-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jartool-D.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jartool-F.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jartool-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jartool-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jartool-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.javadoc-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.javadoc-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.javadoc-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.javadoc-D.sym.txt = src/jdk.compiler/share/data/symbols/jdk.javadoc-F.sym.txt = src/jdk.compiler/share/data/symbols/jdk.javadoc-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.javadoc-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.javadoc-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jcmd-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jcmd-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jcmd-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jconsole-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jconsole-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jconsole-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jconsole-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jconsole-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jconsole-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jdeps-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jdeps-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jdeps-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jdi-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jdi-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jdi-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jdi-F.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jdi-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jdi-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jdi-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jdwp.agent-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jdwp.agent-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jdwp.agent-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jfr-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jfr-C.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jfr-E.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jfr-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jfr-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jlink-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jlink-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jlink-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jlink-D.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jlink-E.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jlink-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jpackage-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jshell-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jshell-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jshell-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jshell-D.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jshell-E.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jshell-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jshell-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jshell-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jsobject-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jsobject-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jsobject-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jsobject-C.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jsobject-E.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jsobject-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jsobject-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jsobject-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jstatd-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jstatd-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.jstatd-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.localedata-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.localedata-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.localedata-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management-7.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management-8.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management-E.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management.agent-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management.agent-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management.agent-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management.jfr-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management.jfr-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management.jfr-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.management.jfr-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.naming.dns-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.naming.dns-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.naming.dns-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.naming.rmi-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.naming.rmi-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.naming.rmi-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.net-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.net-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.net-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.net-E.sym.txt = src/jdk.compiler/share/data/symbols/jdk.net-F.sym.txt = src/jdk.compiler/share/data/symbols/jdk.net-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.net-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.net-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.nio.mapmode-F.sym.txt = src/jdk.compiler/share/data/symbols/jdk.pack-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.pack-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.pack-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.pack-E.sym.txt = src/jdk.compiler/share/data/symbols/jdk.policytool-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.policytool-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.rmic-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.rmic-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.rmic-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.rmic-F.sym.txt = src/jdk.compiler/share/data/symbols/jdk.scripting.nashorn-7.sym.txt = src/jdk.compiler/share/data/symbols/jdk.scripting.nashorn-8.sym.txt = src/jdk.compiler/share/data/symbols/jdk.scripting.nashorn-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.scripting.nashorn-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.scripting.nashorn-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.scripting.nashorn-F.sym.txt = src/jdk.compiler/share/data/symbols/jdk.sctp-7.sym.txt = src/jdk.compiler/share/data/symbols/jdk.sctp-8.sym.txt = src/jdk.compiler/share/data/symbols/jdk.sctp-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.sctp-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.sctp-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.sctp-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.sctp-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.sctp-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.auth-7.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.auth-8.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.auth-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.auth-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.auth-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.auth-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.auth-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.auth-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.jgss-7.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.jgss-8.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.jgss-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.jgss-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.jgss-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.jgss-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.jgss-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.security.jgss-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.unsupported-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.unsupported-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.unsupported-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.unsupported-C.sym.txt = src/jdk.compiler/share/data/symbols/jdk.unsupported-F.sym.txt = src/jdk.compiler/share/data/symbols/jdk.unsupported-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.unsupported-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.unsupported-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.xml.dom-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.xml.dom-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.xml.dom-B.sym.txt = src/jdk.compiler/share/data/symbols/jdk.xml.dom-G.sym.txt = src/jdk.compiler/share/data/symbols/jdk.xml.dom-H.sym.txt = src/jdk.compiler/share/data/symbols/jdk.xml.dom-I.sym.txt = src/jdk.compiler/share/data/symbols/jdk.zipfs-9.sym.txt = src/jdk.compiler/share/data/symbols/jdk.zipfs-A.sym.txt = src/jdk.compiler/share/data/symbols/jdk.zipfs-B.sym.txt = src/jdk.compiler/share/data/symbols/symbols ! test/jdk/java/security/misc/Versions.java ! test/jdk/java/util/Currency/CurrencyTest.java ! test/jdk/java/util/Locale/LSRDataTest.java ! test/jdk/lib/testlibrary/java/lang/UCDFiles.java ! test/jdk/sun/nio/cs/TestCharsetMapping.java ! test/jdk/sun/nio/cs/TestMS950.java ! test/jdk/sun/security/lib/CheckBlockedCerts.java ! test/jdk/sun/util/calendar/zi/TestZoneInfo310.java ! test/langtools/tools/javac/platform/CanHandleClassFilesTest.java ! test/langtools/tools/javac/sym/ElementStructureTest.java Changeset: f3dc0c88 Author: David Holmes Date: 2022-03-22 01:12:29 +0000 URL: https://git.openjdk.java.net/loom/commit/f3dc0c88ea00a3745f5f105404e0788a0f616407 8282721: HotSpot Style Guide should allow considered use of C++ thread_local Reviewed-by: kbarrett, jrose, dcubed, stuefe, mdoerr, kvn ! doc/hotspot-style.html ! doc/hotspot-style.md Changeset: 81d63734 Author: David Holmes Date: 2022-03-22 01:20:31 +0000 URL: https://git.openjdk.java.net/loom/commit/81d63734bc2e2a18063cb6afbc53f8813a0ba880 8282469: Allow considered use of C++ thread_local in Hotspot Reviewed-by: kbarrett, dcubed - src/hotspot/share/memory/operator_new.cpp ! src/hotspot/share/utilities/globalDefinitions.hpp Changeset: 849b1952 Author: Manukumar V S Committer: Sergey Bylokhov Date: 2022-03-22 01:28:06 +0000 URL: https://git.openjdk.java.net/loom/commit/849b19523a666bd2ec110876bfd5679b20be77f4 8282937: Write a regression test for JDK-4820080 Reviewed-by: serb + test/jdk/javax/swing/JSplitPane/4820080/JSplitPaneDragColorTest.java Changeset: 37fc77ef Author: Kevin Walls Date: 2022-03-22 07:54:41 +0000 URL: https://git.openjdk.java.net/loom/commit/37fc77ef60dd97c4acc468ecfeb6753132974720 8283092: JMX subclass permission check redundant with strong encapsulation Reviewed-by: dfuchs, mchung ! src/java.management/share/classes/java/lang/management/ManagementFactory.java ! src/java.management/share/classes/sun/management/spi/PlatformMBeanProvider.java ! src/jdk.management.agent/share/classes/jdk/internal/agent/spi/AgentProvider.java ! test/jdk/sun/management/PlatformMBeanProviderConstructorCheck.java Changeset: a6fd0b21 Author: Srinivas Mandalika Committer: Sergey Bylokhov Date: 2022-03-22 09:20:12 +0000 URL: https://git.openjdk.java.net/loom/commit/a6fd0b21ddc1575366eed8d47191f6b14b2d7cb6 8283087: Create a test or JDK-4715503 Reviewed-by: serb + test/jdk/javax/accessibility/4715503/AccessibleJTableCellBoundingRectangleTest.java Changeset: 85628a87 Author: Roland Westrelin Date: 2022-03-22 10:34:33 +0000 URL: https://git.openjdk.java.net/loom/commit/85628a871df3fdeec1b422d1c01c222abe45d0a8 8282592: C2: assert(false) failed: graph should be schedulable Reviewed-by: chagedorn, thartmann ! src/hotspot/share/opto/loopTransform.cpp ! src/hotspot/share/opto/loopopts.cpp + test/hotspot/jtreg/compiler/c2/irTests/TestSkeletonPredicates.java Changeset: c0f984e5 Author: Zhengyu Gu Date: 2022-03-22 13:30:26 +0000 URL: https://git.openjdk.java.net/loom/commit/c0f984e5fbba7b44fa7b0a4309896ef9ccb4e666 8283456: Make CompiledICHolder::live_count/live_not_claimed_count debug only Reviewed-by: dholmes ! src/hotspot/share/oops/compiledICHolder.cpp ! src/hotspot/share/oops/compiledICHolder.hpp Changeset: fabde3b7 Author: Roland Westrelin Date: 2022-03-22 14:06:49 +0000 URL: https://git.openjdk.java.net/loom/commit/fabde3b7b8ed5e576febe8138c14696ccdf636d5 8283451: C2: assert(_base == Long) failed: Not a Long Reviewed-by: thartmann, chagedorn ! src/hotspot/share/opto/phaseX.cpp + test/hotspot/jtreg/compiler/c2/TestModDivTopInput.java Changeset: 557ff4b3 Author: Jim Laskey Date: 2022-03-22 15:32:46 +0000 URL: https://git.openjdk.java.net/loom/commit/557ff4b3558f95723ebaff680b8524b0cb979559 8282625: Formatter caches Locale/DecimalFormatSymbols poorly Reviewed-by: naoto, rriggs, jpai ! src/java.base/share/classes/java/text/DecimalFormatSymbols.java ! src/java.base/share/classes/java/util/Formatter.java ! test/jdk/java/text/Format/NumberFormat/IntlTestDecimalFormatSymbols.java Changeset: d29c7e74 Author: Emanuel Peter Committer: Tobias Hartmann Date: 2022-03-22 16:23:23 +0000 URL: https://git.openjdk.java.net/loom/commit/d29c7e740d51cb50a1aa0a941a5b460782f8da68 8282590: C2: assert(addp->is_AddP() && addp->outcnt() > 0) failed: Don't process dead nodes Reviewed-by: thartmann, chagedorn ! src/hotspot/share/opto/arraycopynode.cpp ! src/hotspot/share/opto/subtypenode.cpp ! test/hotspot/jtreg/compiler/arraycopy/TestArrayCopyAsLoadsStores.java Changeset: f7d21c35 Author: Joe Darcy Date: 2022-03-22 16:26:23 +0000 URL: https://git.openjdk.java.net/loom/commit/f7d21c3523d87584b62a1143bfe52d067cf77519 8283480: Make AbstractStringBuilder sealed Reviewed-by: jjg, rriggs, jlaskey, dfuchs ! src/java.base/share/classes/java/lang/AbstractStringBuilder.java Changeset: 33eb89df Author: Phil Race Date: 2022-03-22 21:48:42 +0000 URL: https://git.openjdk.java.net/loom/commit/33eb89dfeb4a43e1ad2c3dd657ec3b6ee7abbb3a 8283457: [macos] libpng build failures with Xcode13.3 Reviewed-by: erikj ! make/modules/java.desktop/lib/Awt2dLibraries.gmk Changeset: 8cc12350 Author: David Holmes Date: 2022-03-23 00:06:53 +0000 URL: https://git.openjdk.java.net/loom/commit/8cc12350294c202ae4050471587b95135a9f6ac6 8282952: Thread::exit should be immune to Thread.stop Reviewed-by: dcubed, pchilanomate, alanb ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/thread.inline.hpp Changeset: 6ea996c2 Author: Ichiroh Takiguchi Date: 2022-03-23 01:39:20 +0000 URL: https://git.openjdk.java.net/loom/commit/6ea996c20591cafa9673d9c697437ce2c48e4616 8282422: JTable.print() failed with UnsupportedCharsetException on AIX ko_KR locale Reviewed-by: prr, serb ! src/java.desktop/share/classes/sun/awt/FontConfiguration.java Changeset: b035fda4 Author: Thomas Stuefe Date: 2022-03-23 06:06:51 +0000 URL: https://git.openjdk.java.net/loom/commit/b035fda459284fa130bf936743a8579a6888160b 8283497: [windows] print TMP and TEMP in hs_err and VM.info Reviewed-by: ysuenaga, dholmes ! src/hotspot/share/utilities/vmError.cpp Changeset: 82e1a1cf Author: Aleksey Shipilev Date: 2022-03-23 06:30:19 +0000 URL: https://git.openjdk.java.net/loom/commit/82e1a1cf8bafddfa2ecf11c2ce88ed4eaa091757 8283257: x86: Clean up invocation/branch counter updates code Reviewed-by: redestad, kvn ! src/hotspot/cpu/x86/interp_masm_x86.cpp ! src/hotspot/cpu/x86/interp_masm_x86.hpp ! src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp ! src/hotspot/cpu/x86/templateTable_x86.cpp Changeset: 1443f6b9 Author: Aleksey Shipilev Date: 2022-03-23 06:31:36 +0000 URL: https://git.openjdk.java.net/loom/commit/1443f6b9191c127abdae38cadb1a44af3c652f1d 8283199: Linux os::cpu_microcode_revision() stalls cold startup Reviewed-by: dholmes, redestad, stuefe ! src/hotspot/os_cpu/linux_x86/os_linux_x86.cpp Changeset: 86015e15 Author: Sibabrata Sahoo Date: 2022-03-23 06:45:37 +0000 URL: https://git.openjdk.java.net/loom/commit/86015e15a5105a779ee065cca64479c8d4fbc074 8282293: Domain value for system property jdk.https.negotiate.cbt should be case-insensitive Reviewed-by: weijun, rhalade ! src/java.base/share/classes/sun/net/www/protocol/https/AbstractDelegateHttpsURLConnection.java ! test/jdk/sun/security/krb5/auto/HttpsCB.java Changeset: 58487ddc Author: Thomas Stuefe Date: 2022-03-23 06:46:55 +0000 URL: https://git.openjdk.java.net/loom/commit/58487ddc170f73123668f29c99097b16ba84aa9b 8283249: CompressedClassPointers.java fails on ppc with 'Narrow klass shift: 0' missing Reviewed-by: iklam ! test/hotspot/jtreg/runtime/CompressedOops/CompressedClassPointers.java Changeset: 026b8530 Author: Jie Fu Date: 2022-03-23 08:48:17 +0000 URL: https://git.openjdk.java.net/loom/commit/026b85303c01326bc49a1105a89853d7641fcd50 8283298: Make CodeCacheSegmentSize a product flag Reviewed-by: dlong, kvn ! src/hotspot/share/interpreter/templateInterpreter.cpp ! src/hotspot/share/prims/methodHandles.cpp ! src/hotspot/share/runtime/globals.hpp ! test/hotspot/jtreg/compiler/arguments/TestCodeEntryAlignment.java Changeset: d8c55725 Author: Quan Anh Mai Committer: Jie Fu Date: 2022-03-23 09:45:23 +0000 URL: https://git.openjdk.java.net/loom/commit/d8c55725e0f85e21c16bb81e3f1a9bcfacc59f87 8282204: Use lea instructions for arithmetic operations on x86_64 Reviewed-by: jiefu, sviswanathan, thartmann ! src/hotspot/cpu/x86/assembler_x86.cpp ! src/hotspot/cpu/x86/vm_version_x86.hpp ! src/hotspot/cpu/x86/x86_64.ad + test/micro/org/openjdk/bench/vm/compiler/LeaInstruction.java Changeset: 91fab6ad Author: Jaikiran Pai Date: 2022-03-23 09:47:44 +0000 URL: https://git.openjdk.java.net/loom/commit/91fab6ad59d2a4baf58802fc6e6039af3dd8d578 8283411: InflaterInputStream holds on to a temporary byte array of 512 bytes Reviewed-by: lancea, vtewari, alanb ! src/java.base/share/classes/java/util/zip/InflaterInputStream.java Changeset: 6ed0ba2f Author: Vicente Romero Date: 2022-03-23 10:34:09 +0000 URL: https://git.openjdk.java.net/loom/commit/6ed0ba2f8a2af58c45a6b7be684ef30d15af6ead 8283543: indentation error at com.sun.tools.javac.comp.Enter::visitTopLevel Reviewed-by: darcy, iris ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Enter.java Changeset: 61d7d868 Author: Kevin Walls Date: 2022-03-23 11:03:25 +0000 URL: https://git.openjdk.java.net/loom/commit/61d7d868db030d878f4a1c4467075e8d4e116a6e 8283254: Remove redundant class jdk/internal/agent/spi/AgentProvider Reviewed-by: mchung, redestad, dfuchs ! src/jdk.management.agent/share/classes/jdk/internal/agent/Agent.java - src/jdk.management.agent/share/classes/jdk/internal/agent/spi/AgentProvider.java ! src/jdk.management.agent/share/classes/module-info.java Changeset: 78ef2fde Author: Thomas Stuefe Date: 2022-03-23 12:55:28 +0000 URL: https://git.openjdk.java.net/loom/commit/78ef2fdef68c5161c8875296e9479026ac89743a 8283562: JDK-8282306 breaks gtests on zero Reviewed-by: shade ! test/hotspot/gtest/runtime/test_os.cpp From haosun at openjdk.java.net Thu Mar 24 07:38:13 2022 From: haosun at openjdk.java.net (Hao Sun) Date: Thu, 24 Mar 2022 07:38:13 GMT Subject: RFR: 8282792: Loom: Fix optimized build after commit 4d2710 [v2] In-Reply-To: References: Message-ID: <-vaaSvyRnq_cOsIeFOPocOe_jaGEdMRQEYhcOOPkJ68=.5afda127-62bd-4d89-859d-7d74bdba454d@github.com> On Wed, 23 Mar 2022 05:54:02 GMT, Erik ?sterlund wrote: >> Hao Sun has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: >> >> - Merge branch 'fibers' into optimized-build >> - 8282792: Loom: Fix optimized build after commit 4d2710 >> >> In commit 4d2710[1], one invocation of function print_frames() is moved >> from condition `!PRODUCT` to condition `ASSERT`. As a result, all the >> usages are now under condition `ASSERT`, leading to the compilation >> warning "unused-function" in optimized VM build. >> >> Hence, in this patch, we move the defintion of function print_frames() >> to condition `ASSERT`. >> >> [1] https://github.com/openjdk/loom/commit/4d2710#diff-74c5a41cb3476b29151b4a13732cf4756879de0aa1b1d8c4d73c38e570413fcfR2851 > > Marked as reviewed by eosterlund (Committer). Thanks for your review. @fisk ------------- PR: https://git.openjdk.java.net/loom/pull/98 From duke at openjdk.java.net Thu Mar 24 07:41:53 2022 From: duke at openjdk.java.net (duke) Date: Thu, 24 Mar 2022 07:41:53 GMT Subject: git: openjdk/loom: fibers: fix WRONG_PHASE issue in nsk.jvmti threadstart002 test Message-ID: <16ea3e3a-05f9-4d1c-bb3d-ddfff49d95da@openjdk.java.net> Changeset: 48256139 Author: Serguei Spitsyn Date: 2022-03-24 07:40:24 +0000 URL: https://git.openjdk.java.net/loom/commit/48256139831abe58d1be44809331f90cf50624fb fix WRONG_PHASE issue in nsk.jvmti threadstart002 test ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/ThreadStart/threadstart002/threadstart002.cpp From duke at openjdk.java.net Thu Mar 24 07:58:07 2022 From: duke at openjdk.java.net (duke) Date: Thu, 24 Mar 2022 07:58:07 GMT Subject: git: openjdk/loom: fibers: 6 new changesets Message-ID: Changeset: 0e8ea70e Author: Alan Bateman Date: 2022-03-22 19:28:19 +0000 URL: https://git.openjdk.java.net/loom/commit/0e8ea70eb155740d094f96267c5082ab26a9074d Remove spurious dot ! src/hotspot/share/prims/jvmti.xml Changeset: 27cb871c Author: Alan Bateman Date: 2022-03-23 15:20:23 +0000 URL: https://git.openjdk.java.net/loom/commit/27cb871c5a4d88c6717af89e6a392b51de2f9db7 Rename thread dump cmd ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/services/diagnosticCommand.cpp ! src/hotspot/share/services/diagnosticCommand.hpp ! src/java.base/share/classes/jdk/internal/vm/ThreadDumper.java = test/hotspot/jtreg/serviceability/dcmd/thread/ThreadDumpToFileTest.java Changeset: 289ede43 Author: Alan Bateman Date: 2022-03-23 18:28:42 +0000 URL: https://git.openjdk.java.net/loom/commit/289ede4350b9362229affbca81e4f8a798bb0117 Allow group to expand during stop ! src/java.desktop/share/classes/sun/awt/AppContext.java ! src/jdk.jshell/share/classes/jdk/jshell/execution/LocalExecutionControl.java Changeset: 521c2ff1 Author: Alan Bateman Date: 2022-03-23 19:20:40 +0000 URL: https://git.openjdk.java.net/loom/commit/521c2ff1c76ee28b8d93fb17a2b2ef4acef8cda4 ThreadDumpToFileTest should run with wrapper, different main thread ! src/hotspot/share/classfile/vmSymbols.hpp ! test/hotspot/jtreg/ProblemList-vthread.txt Changeset: 9a79c32e Author: Alan Bateman Date: 2022-03-23 19:40:03 +0000 URL: https://git.openjdk.java.net/loom/commit/9a79c32eff44cce6cb0cedb12b6375a54bf64a20 Fix headers ! src/java.management/share/classes/java/lang/management/ThreadInfo.java ! src/java.management/share/classes/sun/management/ThreadImpl.java ! src/jdk.jdwp.agent/share/native/libjdwp/StackFrameImpl.c ! src/jdk.jdwp.agent/share/native/libjdwp/ThreadGroupReferenceImpl.c ! src/jdk.jdwp.agent/share/native/libjdwp/inStream.c Changeset: 7317a172 Author: Alan Bateman Date: 2022-03-24 05:36:54 +0000 URL: https://git.openjdk.java.net/loom/commit/7317a1728a55d13297ad5b8e41fef2ac39497b56 Sync up failure handler with new command name ! test/failure_handler/src/share/conf/common.properties From eosterlund at openjdk.java.net Thu Mar 24 08:28:05 2022 From: eosterlund at openjdk.java.net (Erik =?UTF-8?B?w5ZzdGVybHVuZA==?=) Date: Thu, 24 Mar 2022 08:28:05 GMT Subject: RFR: Loom checked stack chunk casts [v2] In-Reply-To: References: Message-ID: On Thu, 24 Mar 2022 07:19:26 GMT, Stefan Karlsson wrote: >> Replace raw oop to stackChunkOops casts with calls to a ::cast function which asserts that the oops is a stackChunkOop. This is similar to what we do for other types like *Klass, *CollectedHeap, *Thread, ... >> >> Given that we assert when converting oops to stackChunkOops, I've also removed the redundant is_stackChunk asserts. > > Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision: > > Don't cast nullptr to oop Looks good. ------------- Marked as reviewed by eosterlund (Committer). PR: https://git.openjdk.java.net/loom/pull/119 From stefank at openjdk.java.net Thu Mar 24 08:52:41 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Thu, 24 Mar 2022 08:52:41 GMT Subject: RFR: Loom checked stack chunk casts [v3] In-Reply-To: References: Message-ID: > Replace raw oop to stackChunkOops casts with calls to a ::cast function which asserts that the oops is a stackChunkOop. This is similar to what we do for other types like *Klass, *CollectedHeap, *Thread, ... > > Given that we assert when converting oops to stackChunkOops, I've also removed the redundant is_stackChunk asserts. Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision: Allow nullptr in the cast function ------------- Changes: - all: https://git.openjdk.java.net/loom/pull/119/files - new: https://git.openjdk.java.net/loom/pull/119/files/ca4623c6..ff50caeb Webrevs: - full: https://webrevs.openjdk.java.net/?repo=loom&pr=119&range=02 - incr: https://webrevs.openjdk.java.net/?repo=loom&pr=119&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/loom/pull/119.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/119/head:pull/119 PR: https://git.openjdk.java.net/loom/pull/119 From dlong at openjdk.java.net Thu Mar 24 09:17:28 2022 From: dlong at openjdk.java.net (Dean Long) Date: Thu, 24 Mar 2022 09:17:28 GMT Subject: RFR: vthreads don't support the reserved stack zone Message-ID: vthreads don't support the reserved stack zone ------------- Commit messages: - vthreads don't support the reserved stack zone Changes: https://git.openjdk.java.net/loom/pull/120/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=120&range=00 Stats: 12 lines in 3 files changed: 11 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/loom/pull/120.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/120/head:pull/120 PR: https://git.openjdk.java.net/loom/pull/120 From eosterlund at openjdk.java.net Thu Mar 24 09:17:28 2022 From: eosterlund at openjdk.java.net (Erik =?UTF-8?B?w5ZzdGVybHVuZA==?=) Date: Thu, 24 Mar 2022 09:17:28 GMT Subject: RFR: vthreads don't support the reserved stack zone In-Reply-To: References: Message-ID: <00VAAEqk_-vt5Cg3J33xtphSpzHCMd4avBhol_5CBnw=.2845f5d0-1207-4997-a0ed-2072fde7d330@github.com> On Thu, 24 Mar 2022 08:37:07 GMT, Dean Long wrote: > vthreads don't support the reserved stack zone Looks good. ------------- Marked as reviewed by eosterlund (Committer). PR: https://git.openjdk.java.net/loom/pull/120 From duke at openjdk.java.net Thu Mar 24 09:20:05 2022 From: duke at openjdk.java.net (duke) Date: Thu, 24 Mar 2022 09:20:05 GMT Subject: git: openjdk/loom: fibers: Use single-condition instance type checks Message-ID: Changeset: b9d8aff6 Author: Stefan Karlsson Committer: Erik ?sterlund Date: 2022-03-24 09:17:48 +0000 URL: https://git.openjdk.java.net/loom/commit/b9d8aff6db6c77b6c88643925512a9240783e766 Use single-condition instance type checks Reviewed-by: eosterlund, tschatzl, coleenp ! src/hotspot/share/gc/g1/g1FullGCMarker.inline.hpp ! src/hotspot/share/jvmci/vmStructs_jvmci.cpp ! src/hotspot/share/oops/instanceClassLoaderKlass.hpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/oops/instanceMirrorKlass.hpp ! src/hotspot/share/oops/instanceRefKlass.cpp ! src/hotspot/share/oops/instanceRefKlass.hpp ! src/hotspot/share/oops/instanceStackChunkKlass.cpp ! src/hotspot/share/oops/instanceStackChunkKlass.hpp ! src/hotspot/share/oops/klass.hpp ! src/hotspot/share/oops/oop.cpp ! src/hotspot/share/oops/oop.hpp ! src/hotspot/share/oops/oop.inline.hpp ! src/hotspot/share/runtime/vmStructs.cpp From tschatzl at openjdk.java.net Thu Mar 24 09:20:07 2022 From: tschatzl at openjdk.java.net (Thomas Schatzl) Date: Thu, 24 Mar 2022 09:20:07 GMT Subject: Integrated: Garbage collectors explicitly transform stack chunk In-Reply-To: References: Message-ID: <1-Ibwbt-ntEtFSztOGQVMx7VPsveHgiC3oO-z9ZqHXo=.0ac8f94a-0bfc-4d12-8909-c992b3b4e516@github.com> On Wed, 23 Mar 2022 09:09:36 GMT, Thomas Schatzl wrote: > Hi all, > > can I have reviews for this change that makes garbage collectors explicitly transform stack chunks instead of relying on magic happening in `InstanceStackChunkKlass::copy_dis/conjoint`. > > It also contains some refactoring suggested by @stefank in `Generation::promote`. Other than that it is a fairly straightforward change to replace `InstanceStackChunkKlass::copy_dis/conjoint` calls with explicit calls to `Copy::aligned_dis/conjoint_words` and `ContinuationGCSupport::transform_stack_chunk`. > > This reduces code, and makes the code more understandable. > > Test: tier1-5 > > Thanks, > Thomas This pull request has now been integrated. Changeset: 5f5d881a Author: Thomas Schatzl Committer: Erik ?sterlund URL: https://git.openjdk.java.net/loom/commit/5f5d881a8fe51a632a06c08812e0125f5172e8c5 Stats: 133 lines in 18 files changed: 27 ins; 84 del; 22 mod Garbage collectors explicitly transform stack chunk Reviewed-by: stefank, eosterlund ------------- PR: https://git.openjdk.java.net/loom/pull/116 From stefank at openjdk.java.net Thu Mar 24 09:21:57 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Thu, 24 Mar 2022 09:21:57 GMT Subject: Integrated: Use single-condition instance type checks In-Reply-To: References: Message-ID: On Wed, 23 Mar 2022 10:41:41 GMT, Stefan Karlsson wrote: > Loom requires specialized code for stackChunks objects when marking/copying objects. This adds extra checks for every visited object. The current implementation checks both the layout helper, then checks the _kind flag. I suggest that we reimplement this as a single check against the Klass::_id field. > > This change would probably be a good cleanup for the mainline. This pull request has now been integrated. Changeset: b9d8aff6 Author: Stefan Karlsson Committer: Erik ?sterlund URL: https://git.openjdk.java.net/loom/commit/b9d8aff6db6c77b6c88643925512a9240783e766 Stats: 79 lines in 15 files changed: 4 ins; 33 del; 42 mod Use single-condition instance type checks Reviewed-by: eosterlund, tschatzl, coleenp ------------- PR: https://git.openjdk.java.net/loom/pull/118 From haosun at openjdk.java.net Thu Mar 24 09:23:57 2022 From: haosun at openjdk.java.net (Hao Sun) Date: Thu, 24 Mar 2022 09:23:57 GMT Subject: Integrated: 8282792: Loom: Fix optimized build after commit 4d2710 In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 06:48:49 GMT, Hao Sun wrote: > In commit 4d2710[1], one invocation of function print_frames() is moved > from condition `!PRODUCT` to condition `ASSERT`. As a result, all the > usages are now under condition `ASSERT`, leading to the compilation > warning "unused-function" in optimized VM build. > > Hence, in this patch, we move the defintion of function print_frames() > to condition `ASSERT`. > > [1] https://github.com/openjdk/loom/commit/4d2710#diff-74c5a41cb3476b29151b4a13732cf4756879de0aa1b1d8c4d73c38e570413fcfR2851 This pull request has now been integrated. Changeset: b83c1c82 Author: Hao Sun Committer: Erik ?sterlund URL: https://git.openjdk.java.net/loom/commit/b83c1c828962ff274daf26b9b8ff2802a255a2a3 Stats: 52 lines in 1 file changed: 25 ins; 27 del; 0 mod 8282792: Loom: Fix optimized build after commit 4d2710 Reviewed-by: eosterlund ------------- PR: https://git.openjdk.java.net/loom/pull/98 From duke at openjdk.java.net Thu Mar 24 11:53:57 2022 From: duke at openjdk.java.net (duke) Date: Thu, 24 Mar 2022 11:53:57 GMT Subject: git: openjdk/loom: fibers: Remove more templates Message-ID: <5a0f0e24-c2c6-4d8e-a0db-052a50d80c67@openjdk.java.net> Changeset: b709b3f8 Author: Ron Pressler Date: 2022-03-24 11:38:58 +0000 URL: https://git.openjdk.java.net/loom/commit/b709b3f8f76a7a89a366048a50df9564c91cc78c Remove more templates ! src/hotspot/cpu/aarch64/continuation_aarch64.inline.hpp ! src/hotspot/cpu/x86/continuation_x86.inline.hpp ! src/hotspot/share/runtime/continuation.cpp From stefank at openjdk.java.net Thu Mar 24 13:09:27 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Thu, 24 Mar 2022 13:09:27 GMT Subject: RFR: Loom checked stack chunk casts [v4] In-Reply-To: References: Message-ID: > Replace raw oop to stackChunkOops casts with calls to a ::cast function which asserts that the oops is a stackChunkOop. This is similar to what we do for other types like *Klass, *CollectedHeap, *Thread, ... > > Given that we assert when converting oops to stackChunkOops, I've also removed the redundant is_stackChunk asserts. Stefan Karlsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: - Merge remote-tracking branch 'loom/fibers' into loom_checked_stack_chunk_casts - Allow nullptr in the cast function - Don't cast nullptr to oop - Remove redundant is_stackChunk asserts - Use cast function to convert from oop to stackChunkOop ------------- Changes: https://git.openjdk.java.net/loom/pull/119/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=119&range=03 Stats: 64 lines in 10 files changed: 11 ins; 16 del; 37 mod Patch: https://git.openjdk.java.net/loom/pull/119.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/119/head:pull/119 PR: https://git.openjdk.java.net/loom/pull/119 From stefank at openjdk.java.net Thu Mar 24 13:17:05 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Thu, 24 Mar 2022 13:17:05 GMT Subject: Integrated: Loom checked stack chunk casts In-Reply-To: References: Message-ID: <5188W1SDVjtTsUtyMCdMCiO6ZMQXusXGP60yVP437ZM=.69a674e6-ce85-4708-a9f8-3707bd919e8c@github.com> On Thu, 24 Mar 2022 07:07:40 GMT, Stefan Karlsson wrote: > Replace raw oop to stackChunkOops casts with calls to a ::cast function which asserts that the oops is a stackChunkOop. This is similar to what we do for other types like *Klass, *CollectedHeap, *Thread, ... > > Given that we assert when converting oops to stackChunkOops, I've also removed the redundant is_stackChunk asserts. This pull request has now been integrated. Changeset: 1a947434 Author: Stefan Karlsson Committer: Ron Pressler URL: https://git.openjdk.java.net/loom/commit/1a947434fce0134e60cf746f18539e567e5516e1 Stats: 64 lines in 10 files changed: 11 ins; 16 del; 37 mod Loom checked stack chunk casts Reviewed-by: eosterlund ------------- PR: https://git.openjdk.java.net/loom/pull/119 From coleenp at openjdk.java.net Thu Mar 24 16:39:29 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Thu, 24 Mar 2022 16:39:29 GMT Subject: RFR: Renamed ContMirror ContinuationWrapper, make cont variable names =?UTF-8?B?aW50b+KApg==?= Message-ID: ? continuation if pointing at the Java instance. Now cont variable names are only for the ContinuationWrapper. There's only one non-variable name change in vframe.cpp Running loom-tier1-3 testing in progress. ------------- Commit messages: - Renamed ContMirror ContinuationWrapper, make cont variable names into continuation if pointing at the Java instance. Now cont variable names are only for the ContinuationWrapper. Changes: https://git.openjdk.java.net/loom/pull/121/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=121&range=00 Stats: 264 lines in 15 files changed: 23 ins; 17 del; 224 mod Patch: https://git.openjdk.java.net/loom/pull/121.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/121/head:pull/121 PR: https://git.openjdk.java.net/loom/pull/121 From rpressler at openjdk.java.net Thu Mar 24 17:37:08 2022 From: rpressler at openjdk.java.net (Ron Pressler) Date: Thu, 24 Mar 2022 17:37:08 GMT Subject: RFR: Renamed ContMirror ContinuationWrapper, make cont variable names =?UTF-8?B?aW50b+KApg==?= In-Reply-To: References: Message-ID: On Thu, 24 Mar 2022 16:32:36 GMT, Coleen Phillimore wrote: > ? continuation if pointing at the Java instance. Now cont variable names are only for the ContinuationWrapper. > There's only one non-variable name change in vframe.cpp > Running loom-tier1-3 testing in progress. Marked as reviewed by rpressler (Lead). ------------- PR: https://git.openjdk.java.net/loom/pull/121 From coleenp at openjdk.java.net Thu Mar 24 17:43:56 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Thu, 24 Mar 2022 17:43:56 GMT Subject: RFR: vthreads don't support the reserved stack zone In-Reply-To: References: Message-ID: On Thu, 24 Mar 2022 08:37:07 GMT, Dean Long wrote: > vthreads don't support the reserved stack zone I hate to be picky but I don't like that this had to move in_stack_reserved_zone. We wanted to move all the stack overflow functions out of thread. Can you pass thread to the overflow_state->in_stack_reserved_zone(thread, addr) instead? ------------- PR: https://git.openjdk.java.net/loom/pull/120 From rpressler at openjdk.java.net Thu Mar 24 19:51:10 2022 From: rpressler at openjdk.java.net (Ron Pressler) Date: Thu, 24 Mar 2022 19:51:10 GMT Subject: RFR: vthreads don't support the reserved stack zone In-Reply-To: References: Message-ID: On Thu, 24 Mar 2022 08:37:07 GMT, Dean Long wrote: > vthreads don't support the reserved stack zone Marked as reviewed by rpressler (Lead). ------------- PR: https://git.openjdk.java.net/loom/pull/120 From coleenp at openjdk.java.net Thu Mar 24 19:53:45 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Thu, 24 Mar 2022 19:53:45 GMT Subject: RFR: Renamed ContMirror ContinuationWrapper, make cont variable names =?UTF-8?B?aW50b+KApg==?= [v2] In-Reply-To: References: Message-ID: > ? continuation if pointing at the Java instance. Now cont variable names are only for the ContinuationWrapper. > There's only one non-variable name change in vframe.cpp > Running loom-tier1-3 testing in progress. Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision: wish C++ would check declarations as well. fix cont names in declarations. ------------- Changes: - all: https://git.openjdk.java.net/loom/pull/121/files - new: https://git.openjdk.java.net/loom/pull/121/files/903c5c04..989a7a00 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=loom&pr=121&range=01 - incr: https://webrevs.openjdk.java.net/?repo=loom&pr=121&range=00-01 Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/loom/pull/121.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/121/head:pull/121 PR: https://git.openjdk.java.net/loom/pull/121 From dlong at openjdk.java.net Thu Mar 24 20:20:09 2022 From: dlong at openjdk.java.net (Dean Long) Date: Thu, 24 Mar 2022 20:20:09 GMT Subject: RFR: vthreads don't support the reserved stack zone In-Reply-To: References: Message-ID: On Thu, 24 Mar 2022 17:40:26 GMT, Coleen Phillimore wrote: > Can you pass thread to the overflow_state->in_stack_reserved_zone(thread, addr) instead? I don't really like that, since it means stack overflow functions would need to know about virtual threads. This function seems to be called in exactly one place, so I can just put the check in the signal handler where we check for arm32. ------------- PR: https://git.openjdk.java.net/loom/pull/120 From dlong at openjdk.java.net Thu Mar 24 20:45:57 2022 From: dlong at openjdk.java.net (Dean Long) Date: Thu, 24 Mar 2022 20:45:57 GMT Subject: RFR: vthreads don't support the reserved stack zone In-Reply-To: References: Message-ID: On Thu, 24 Mar 2022 08:37:07 GMT, Dean Long wrote: > vthreads don't support the reserved stack zone I can also imagine doing something like: bool JavaThread::stack_reserved_zone_supported() or static bool FeaturesSupport::stack_reserved_zone_supported(JavaThread *) but it seems like overkill. ------------- PR: https://git.openjdk.java.net/loom/pull/120 From coleenp at openjdk.java.net Thu Mar 24 20:55:08 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Thu, 24 Mar 2022 20:55:08 GMT Subject: RFR: vthreads don't support the reserved stack zone In-Reply-To: References: Message-ID: On Thu, 24 Mar 2022 08:37:07 GMT, Dean Long wrote: > vthreads don't support the reserved stack zone Ok. I guess all ways of fixing it spreads knowledge of virtual threads, which the thread code knows the most about. I guess your original change is the best. I moved all of those functions out of Thread but I guess this one has to go back. ------------- Marked as reviewed by coleenp (Committer). PR: https://git.openjdk.java.net/loom/pull/120 From coleenp at openjdk.java.net Thu Mar 24 21:01:09 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Thu, 24 Mar 2022 21:01:09 GMT Subject: RFR: Renamed ContMirror ContinuationWrapper, make cont variable names =?UTF-8?B?aW50b+KApg==?= [v2] In-Reply-To: References: Message-ID: On Thu, 24 Mar 2022 19:53:45 GMT, Coleen Phillimore wrote: >> ? continuation if pointing at the Java instance. Now cont variable names are only for the ContinuationWrapper. >> There's only one non-variable name change in vframe.cpp >> Running loom-tier1-3 testing in progress. > > Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision: > > wish C++ would check declarations as well. fix cont names in declarations. Thanks Ron and Patricio ------------- PR: https://git.openjdk.java.net/loom/pull/121 From coleenp at openjdk.java.net Thu Mar 24 21:01:10 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Thu, 24 Mar 2022 21:01:10 GMT Subject: Integrated: Renamed ContMirror ContinuationWrapper, make cont variable names =?UTF-8?B?aW50b+KApg==?= In-Reply-To: References: Message-ID: On Thu, 24 Mar 2022 16:32:36 GMT, Coleen Phillimore wrote: > ? continuation if pointing at the Java instance. Now cont variable names are only for the ContinuationWrapper. > There's only one non-variable name change in vframe.cpp > Running loom-tier1-3 testing in progress. This pull request has now been integrated. Changeset: ccf8f30c Author: Coleen Phillimore URL: https://git.openjdk.java.net/loom/commit/ccf8f30c3d7fcb6ce30bbe67576ca72bb2f05023 Stats: 270 lines in 15 files changed: 23 ins; 17 del; 230 mod Renamed ContMirror ContinuationWrapper, make cont variable names into? Reviewed-by: rpressler, pchilanomate ------------- PR: https://git.openjdk.java.net/loom/pull/121 From dlong at openjdk.java.net Thu Mar 24 21:30:46 2022 From: dlong at openjdk.java.net (Dean Long) Date: Thu, 24 Mar 2022 21:30:46 GMT Subject: RFR: vthreads don't support the reserved stack zone [v2] In-Reply-To: References: Message-ID: > vthreads don't support the reserved stack zone Dean Long has updated the pull request incrementally with one additional commit since the last revision: redo ------------- Changes: - all: https://git.openjdk.java.net/loom/pull/120/files - new: https://git.openjdk.java.net/loom/pull/120/files/df139bc5..06f83010 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=loom&pr=120&range=01 - incr: https://webrevs.openjdk.java.net/?repo=loom&pr=120&range=00-01 Stats: 13 lines in 3 files changed: 1 ins; 11 del; 1 mod Patch: https://git.openjdk.java.net/loom/pull/120.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/120/head:pull/120 PR: https://git.openjdk.java.net/loom/pull/120 From dlong at openjdk.java.net Thu Mar 24 21:30:46 2022 From: dlong at openjdk.java.net (Dean Long) Date: Thu, 24 Mar 2022 21:30:46 GMT Subject: RFR: vthreads don't support the reserved stack zone In-Reply-To: References: Message-ID: On Thu, 24 Mar 2022 20:51:19 GMT, Coleen Phillimore wrote: >> vthreads don't support the reserved stack zone > > I guess all ways of fixing it spreads knowledge of virtual threads, which the thread code knows the most about. I guess your original change is the best. I moved all of those functions out of Thread but I guess this one has to go back. @coleenp , I pushed a new version before seeing your comment. Let me know which version you like better. ------------- PR: https://git.openjdk.java.net/loom/pull/120 From duke at openjdk.java.net Thu Mar 24 21:43:09 2022 From: duke at openjdk.java.net (duke) Date: Thu, 24 Mar 2022 21:43:09 GMT Subject: git: openjdk/loom: fibers: split vthread problemlists Message-ID: Changeset: b305b6e0 Author: lmesnik Date: 2022-03-24 15:40:53 +0000 URL: https://git.openjdk.java.net/loom/commit/b305b6e06befb4e5bc416c96234a6e334a89d68f split vthread problemlists + test/hotspot/jtreg/ProblemList-svc-vthread.txt ! test/hotspot/jtreg/ProblemList-vthread.txt From coleenp at openjdk.java.net Thu Mar 24 22:35:27 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Thu, 24 Mar 2022 22:35:27 GMT Subject: RFR: Lower case verify calls Message-ID: This is another cosmetic change to fix the verify functions so that there is one less null string assert. ------------- Commit messages: - Lower case verify calls Changes: https://git.openjdk.java.net/loom/pull/122/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=122&range=00 Stats: 30 lines in 2 files changed: 5 ins; 5 del; 20 mod Patch: https://git.openjdk.java.net/loom/pull/122.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/122/head:pull/122 PR: https://git.openjdk.java.net/loom/pull/122 From duke at openjdk.java.net Fri Mar 25 04:58:30 2022 From: duke at openjdk.java.net (duke) Date: Fri, 25 Mar 2022 04:58:30 GMT Subject: git: openjdk/loom: fibers: Problem list tests that require at least 6 carrier threads, and therefore at least 6 cores. Only problem listed for macosx-x64. Message-ID: <7f6f764c-c5b0-495e-854a-a960ad8efe33@openjdk.java.net> Changeset: 439b52b0 Author: Chris Plummer Date: 2022-03-25 04:57:49 +0000 URL: https://git.openjdk.java.net/loom/commit/439b52b07d975ff65383458304a52bc35127792f Problem list tests that require at least 6 carrier threads, and therefore at least 6 cores. Only problem listed for macosx-x64. ! test/hotspot/jtreg/ProblemList-svc-vthread.txt From duke at openjdk.java.net Fri Mar 25 10:09:49 2022 From: duke at openjdk.java.net (duke) Date: Fri, 25 Mar 2022 10:09:49 GMT Subject: git: openjdk/loom: fibers: JVMTI cleanup: get rid of unneeded debug tracing Message-ID: <08642f46-851f-49fd-a6bd-2736598785a7@openjdk.java.net> Changeset: 90c37a54 Author: Serguei Spitsyn Date: 2022-03-25 10:08:21 +0000 URL: https://git.openjdk.java.net/loom/commit/90c37a54ae76bc12c4e12af5ea42686fa06c144b JVMTI cleanup: get rid of unneeded debug tracing ! src/hotspot/share/prims/jvmtiExport.cpp ! src/hotspot/share/prims/jvmtiThreadState.cpp From coleenp at openjdk.java.net Fri Mar 25 13:32:54 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Fri, 25 Mar 2022 13:32:54 GMT Subject: RFR: Lower case verify calls [v2] In-Reply-To: References: Message-ID: > This is another cosmetic change to fix the verify functions so that there is one less null string assert. Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision: Remove copy_alignment template parameter as it is unused. ------------- Changes: - all: https://git.openjdk.java.net/loom/pull/122/files - new: https://git.openjdk.java.net/loom/pull/122/files/c1961790..eaaf0d1c Webrevs: - full: https://webrevs.openjdk.java.net/?repo=loom&pr=122&range=01 - incr: https://webrevs.openjdk.java.net/?repo=loom&pr=122&range=00-01 Stats: 14 lines in 1 file changed: 0 ins; 6 del; 8 mod Patch: https://git.openjdk.java.net/loom/pull/122.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/122/head:pull/122 PR: https://git.openjdk.java.net/loom/pull/122 From rehn at openjdk.java.net Fri Mar 25 13:32:55 2022 From: rehn at openjdk.java.net (Robbin Ehn) Date: Fri, 25 Mar 2022 13:32:55 GMT Subject: RFR: Lower case verify calls [v2] In-Reply-To: References: Message-ID: On Fri, 25 Mar 2022 13:29:29 GMT, Coleen Phillimore wrote: >> This is another cosmetic change to fix the verify functions so that there is one less null string assert. > > Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision: > > Remove copy_alignment template parameter as it is unused. Marked as reviewed by rehn (Committer). ------------- PR: https://git.openjdk.java.net/loom/pull/122 From coleenp at openjdk.java.net Fri Mar 25 13:39:10 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Fri, 25 Mar 2022 13:39:10 GMT Subject: RFR: Lower case verify calls [v2] In-Reply-To: References: Message-ID: On Fri, 25 Mar 2022 13:32:54 GMT, Coleen Phillimore wrote: >> This is another cosmetic change to fix the verify functions so that there is one less null string assert. >> >> This change also removes the copy_alignment template parameter as Patricio, Robbin and I noticed it's unused. Which is good because then we'd have to wonder when and why it would be less than the default. Also DWORD is a windows thing so looked odd in shared code and not sure if it matches what windows thinks DWORD is. > > Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision: > > Remove copy_alignment template parameter as it is unused. Thanks Robbin. ------------- PR: https://git.openjdk.java.net/loom/pull/122 From coleenp at openjdk.java.net Fri Mar 25 13:39:11 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Fri, 25 Mar 2022 13:39:11 GMT Subject: Integrated: Lower case verify calls In-Reply-To: References: Message-ID: On Thu, 24 Mar 2022 22:27:51 GMT, Coleen Phillimore wrote: > This is another cosmetic change to fix the verify functions so that there is one less null string assert. > > This change also removes the copy_alignment template parameter as Patricio, Robbin and I noticed it's unused. Which is good because then we'd have to wonder when and why it would be less than the default. Also DWORD is a windows thing so looked odd in shared code and not sure if it matches what windows thinks DWORD is. This pull request has now been integrated. Changeset: e6849098 Author: Coleen Phillimore URL: https://git.openjdk.java.net/loom/commit/e68490980b0d389d8ae960d079e11c16241f4096 Stats: 44 lines in 2 files changed: 5 ins; 11 del; 28 mod Lower case verify calls Reviewed-by: rehn ------------- PR: https://git.openjdk.java.net/loom/pull/122 From tschatzl at openjdk.java.net Fri Mar 25 13:50:31 2022 From: tschatzl at openjdk.java.net (Thomas Schatzl) Date: Fri, 25 Mar 2022 13:50:31 GMT Subject: RFR: Various GC cleanups Message-ID: Please review these cleanups, mostly done by @stefank. It is probably best to review the commits separately. Testing: loom-tier1-3 Regards, Thomas ------------- Commit messages: - minor additions - Move functions to stackChunkOopDesc - Harmonize relativize and transform stack chunk functions - Small alignment issue - Deduplicate relativize_frame - Remove duplication of bit index calculations - Remove bit_offset use 0 indexing for bits - Clean up more assert ( - Remove casts in iterate_stack Changes: https://git.openjdk.java.net/loom/pull/123/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=123&range=00 Stats: 782 lines in 17 files changed: 335 ins; 358 del; 89 mod Patch: https://git.openjdk.java.net/loom/pull/123.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/123/head:pull/123 PR: https://git.openjdk.java.net/loom/pull/123 From rehn at openjdk.java.net Fri Mar 25 14:30:33 2022 From: rehn at openjdk.java.net (Robbin Ehn) Date: Fri, 25 Mar 2022 14:30:33 GMT Subject: RFR: Assorted minor things Message-ID: Assorted minor things ------------- Commit messages: - Missed zero - Fixed - requires creep fix - Removed unused template from arch - Removed _mode and asorted - Removed unused template and asorted - Fixed assert - Fixes with some asserts - Requires barrier fix - Asorted - ... and 2 more: https://git.openjdk.java.net/loom/compare/e6849098...fa4df677 Changes: https://git.openjdk.java.net/loom/pull/124/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=124&range=00 Stats: 164 lines in 7 files changed: 30 ins; 62 del; 72 mod Patch: https://git.openjdk.java.net/loom/pull/124.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/124/head:pull/124 PR: https://git.openjdk.java.net/loom/pull/124 From coleenp at openjdk.java.net Fri Mar 25 14:30:33 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Fri, 25 Mar 2022 14:30:33 GMT Subject: RFR: Assorted minor things In-Reply-To: References: Message-ID: On Fri, 25 Mar 2022 14:17:55 GMT, Robbin Ehn wrote: > Assorted minor things Yes looks good. ------------- Marked as reviewed by coleenp (Committer). PR: https://git.openjdk.java.net/loom/pull/124 From stefank at openjdk.java.net Fri Mar 25 15:56:04 2022 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Fri, 25 Mar 2022 15:56:04 GMT Subject: RFR: Various GC cleanups In-Reply-To: References: Message-ID: On Fri, 25 Mar 2022 13:43:57 GMT, Thomas Schatzl wrote: > Please review these cleanups, mostly done by @stefank. > > It is probably best to review the commits separately. > > Testing: loom-tier1-3 > > Regards, > Thomas Marked as reviewed by stefank (no project role). ------------- PR: https://git.openjdk.java.net/loom/pull/123 From duke at openjdk.java.net Fri Mar 25 16:02:49 2022 From: duke at openjdk.java.net (duke) Date: Fri, 25 Mar 2022 16:02:49 GMT Subject: git: openjdk/loom: fibers: 10 new changesets Message-ID: Changeset: acac89f9 Author: Ron Pressler Date: 2022-03-24 13:09:46 +0000 URL: https://git.openjdk.java.net/loom/commit/acac89f9df9042667ff9b5ae3e98053650455a58 Test for Continuations::enabled() in Continuation::is_return_barrier_entry() ! src/hotspot/share/runtime/continuation.cpp Changeset: fbcb960c Author: Stefan Karlsson Committer: Ron Pressler Date: 2022-03-24 17:22:51 +0000 URL: https://git.openjdk.java.net/loom/commit/fbcb960cb1e6e6058b00f2c4d56df6a8f826346b Remove casts in iterate_stack ! src/hotspot/share/oops/instanceStackChunkKlass.inline.hpp Changeset: 62508ca0 Author: Stefan Karlsson Committer: Ron Pressler Date: 2022-03-24 17:33:38 +0000 URL: https://git.openjdk.java.net/loom/commit/62508ca0e9d5f6ac7bf4a02262a18658047eff5b Clean up more assert ( ! src/hotspot/cpu/aarch64/continuation_aarch64.inline.hpp ! src/hotspot/cpu/aarch64/frame_helpers_aarch64.inline.hpp ! src/hotspot/cpu/aarch64/stackChunkFrameStream_aarch64.inline.hpp ! src/hotspot/cpu/x86/smallRegisterMap_x86.inline.hpp ! src/hotspot/cpu/x86/stackChunkFrameStream_x86.inline.hpp ! src/hotspot/share/oops/instanceStackChunkKlass.inline.hpp ! src/hotspot/share/runtime/continuation.cpp ! src/hotspot/share/runtime/stackChunkFrameStream.inline.hpp Changeset: 90408ec2 Author: Stefan Karlsson Committer: Ron Pressler Date: 2022-03-25 06:52:29 +0000 URL: https://git.openjdk.java.net/loom/commit/90408ec2395beba8cca29458614c391dd07a0ba1 Remove bit_offset use 0 indexing for bits ! src/hotspot/share/oops/instanceStackChunkKlass.cpp ! src/hotspot/share/oops/instanceStackChunkKlass.hpp ! src/hotspot/share/oops/instanceStackChunkKlass.inline.hpp ! src/hotspot/share/oops/stackChunkOop.hpp ! src/hotspot/share/oops/stackChunkOop.inline.hpp Changeset: e8598bb6 Author: Stefan Karlsson Committer: Ron Pressler Date: 2022-03-25 07:12:05 +0000 URL: https://git.openjdk.java.net/loom/commit/e8598bb639a148ecf53f59e778e2f53e6492eb4d Remove duplication of bit index calculations ! src/hotspot/share/oops/instanceStackChunkKlass.cpp ! src/hotspot/share/oops/stackChunkOop.inline.hpp Changeset: 7b51a2bb Author: Stefan Karlsson Committer: Ron Pressler Date: 2022-03-25 07:27:04 +0000 URL: https://git.openjdk.java.net/loom/commit/7b51a2bbd928bcd9d6b61672d3381320fcb34749 Deduplicate relativize_frame ! src/hotspot/share/oops/instanceStackChunkKlass.cpp Changeset: 4c846d28 Author: Stefan Karlsson Committer: Ron Pressler Date: 2022-03-25 08:37:27 +0000 URL: https://git.openjdk.java.net/loom/commit/4c846d28605688240ef758a65266cf3f748fa8f3 Small alignment issue ! src/hotspot/share/runtime/continuation.cpp Changeset: 4a6cfcce Author: Stefan Karlsson Committer: Ron Pressler Date: 2022-03-25 08:39:27 +0000 URL: https://git.openjdk.java.net/loom/commit/4a6cfcce4aaf3a9d2a91e1f3c9422a5c04a43590 Harmonize relativize and transform stack chunk functions ! src/hotspot/share/gc/shared/continuationGCSupport.hpp ! src/hotspot/share/gc/shared/continuationGCSupport.inline.hpp ! src/hotspot/share/gc/z/zMark.cpp ! src/hotspot/share/oops/instanceStackChunkKlass.cpp ! src/hotspot/share/oops/instanceStackChunkKlass.hpp Changeset: 0d77e1a9 Author: Stefan Karlsson Committer: Ron Pressler Date: 2022-03-25 11:20:05 +0000 URL: https://git.openjdk.java.net/loom/commit/0d77e1a92b0259d54ef3d2ad344a52c1725994c3 Move functions to stackChunkOopDesc ! src/hotspot/share/gc/shared/continuationGCSupport.inline.hpp ! src/hotspot/share/oops/instanceStackChunkKlass.cpp ! src/hotspot/share/oops/instanceStackChunkKlass.hpp ! src/hotspot/share/oops/instanceStackChunkKlass.inline.hpp ! src/hotspot/share/oops/stackChunkOop.cpp ! src/hotspot/share/oops/stackChunkOop.hpp ! src/hotspot/share/oops/stackChunkOop.inline.hpp ! src/hotspot/share/runtime/continuation.cpp ! src/hotspot/share/runtime/stackChunkFrameStream.hpp ! src/hotspot/share/runtime/stackChunkFrameStream.inline.hpp Changeset: 8012839c Author: Thomas Schatzl Committer: Ron Pressler Date: 2022-03-25 12:07:32 +0000 URL: https://git.openjdk.java.net/loom/commit/8012839cc84729f29916eb2318cfa947c6de9fe0 minor additions ! src/hotspot/share/gc/shared/continuationGCSupport.hpp ! src/hotspot/share/gc/shared/continuationGCSupport.inline.hpp ! src/hotspot/share/oops/stackChunkOop.cpp From rehn at openjdk.java.net Fri Mar 25 16:05:53 2022 From: rehn at openjdk.java.net (Robbin Ehn) Date: Fri, 25 Mar 2022 16:05:53 GMT Subject: RFR: Assorted minor things [v2] In-Reply-To: References: Message-ID: > Assorted minor things Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision: - Merge branch 'fibers' into mefix - Missed zero - Fixed - requires creep fix - Removed unused template from arch - Removed _mode and asorted - Removed unused template and asorted - Fixed assert - Fixes with some asserts - Requires barrier fix - ... and 3 more: https://git.openjdk.java.net/loom/compare/fad6a905...c540d83c ------------- Changes: - all: https://git.openjdk.java.net/loom/pull/124/files - new: https://git.openjdk.java.net/loom/pull/124/files/fa4df677..c540d83c Webrevs: - full: https://webrevs.openjdk.java.net/?repo=loom&pr=124&range=01 - incr: https://webrevs.openjdk.java.net/?repo=loom&pr=124&range=00-01 Stats: 783 lines in 17 files changed: 336 ins; 358 del; 89 mod Patch: https://git.openjdk.java.net/loom/pull/124.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/124/head:pull/124 PR: https://git.openjdk.java.net/loom/pull/124 From rehn at openjdk.java.net Fri Mar 25 18:21:12 2022 From: rehn at openjdk.java.net (Robbin Ehn) Date: Fri, 25 Mar 2022 18:21:12 GMT Subject: Integrated: Assorted minor things In-Reply-To: References: Message-ID: <-D2sfl0IVKfkZ60GhsF_HrXsyNlhEQ2NBgsrvGBqepk=.3b044f42-66df-43de-9359-b66ada488365@github.com> On Fri, 25 Mar 2022 14:17:55 GMT, Robbin Ehn wrote: > Assorted minor things This pull request has now been integrated. Changeset: 183e314c Author: Robbin Ehn URL: https://git.openjdk.java.net/loom/commit/183e314cade85544f2196c395469e69e1511a914 Stats: 164 lines in 7 files changed: 30 ins; 62 del; 72 mod Assorted minor things Reviewed-by: coleenp ------------- PR: https://git.openjdk.java.net/loom/pull/124 From duke at openjdk.java.net Fri Mar 25 20:08:11 2022 From: duke at openjdk.java.net (duke) Date: Fri, 25 Mar 2022 20:08:11 GMT Subject: git: openjdk/loom: fibers: 5 new changesets Message-ID: Changeset: 6b968e4b Author: Alan Bateman Date: 2022-03-24 20:05:28 +0000 URL: https://git.openjdk.java.net/loom/commit/6b968e4bfcc753100c69ef8f8fa5cb88cbbf4890 Show thread id before name in dump ! src/java.base/share/classes/jdk/internal/vm/ThreadDumper.java Changeset: bd9410d1 Author: Alan Bateman Date: 2022-03-25 13:24:57 +0000 URL: https://git.openjdk.java.net/loom/commit/bd9410d1e3a37179c2d21ac5424ac5db7bb77864 Update test to align with new format ! test/hotspot/jtreg/serviceability/dcmd/thread/ThreadDumpToFileTest.java Changeset: 393088fb Author: Alan Bateman Date: 2022-03-25 17:28:14 +0000 URL: https://git.openjdk.java.net/loom/commit/393088fb61329ce350537da615847f83e97ca52c Exclude serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorVMEventsTest.java ! test/hotspot/jtreg/ProblemList.txt Changeset: 2f91494e Author: Alan Bateman Date: 2022-03-25 18:18:33 +0000 URL: https://git.openjdk.java.net/loom/commit/2f91494ef841a9ef1c8ab7288139a6d04058635d ForkJoinPool update from jsr166-cvs/dl ! src/java.base/share/classes/java/util/concurrent/CountedCompleter.java ! src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java ! src/java.base/share/classes/java/util/concurrent/ForkJoinTask.java ! src/java.base/share/classes/java/util/concurrent/ForkJoinWorkerThread.java Changeset: a5f1e86d Author: Alan Bateman Date: 2022-03-25 18:18:46 +0000 URL: https://git.openjdk.java.net/loom/commit/a5f1e86dbac8fbfa9efd54dfb0d7830533184300 Update to use lazySubmit directly ! src/java.base/share/classes/java/lang/VirtualThread.java From coleenp at openjdk.java.net Fri Mar 25 23:02:55 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Fri, 25 Mar 2022 23:02:55 GMT Subject: RFR: vthreads don't support the reserved stack zone [v2] In-Reply-To: References: Message-ID: On Thu, 24 Mar 2022 21:30:46 GMT, Dean Long wrote: >> vthreads don't support the reserved stack zone > > Dean Long has updated the pull request incrementally with one additional commit since the last revision: > > redo Hi Dean, I like this version better. Thank you! ------------- Marked as reviewed by coleenp (Committer). PR: https://git.openjdk.java.net/loom/pull/120 From duke at openjdk.java.net Sat Mar 26 00:27:31 2022 From: duke at openjdk.java.net (duke) Date: Sat, 26 Mar 2022 00:27:31 GMT Subject: git: openjdk/loom: fibers: Fix other platforms except 32 bits. Message-ID: Changeset: 4c97ec20 Author: Coleen Phillimore Date: 2022-03-26 00:25:56 +0000 URL: https://git.openjdk.java.net/loom/commit/4c97ec20524e3b9d4fa7d7a9dc706c6e30ef95a0 Fix other platforms except 32 bits. ! src/hotspot/cpu/arm/continuation_arm.inline.hpp ! src/hotspot/cpu/ppc/continuation_ppc.inline.hpp ! src/hotspot/cpu/s390/continuation_s390.inline.hpp ! src/hotspot/cpu/zero/continuation_zero.inline.hpp From dlong at openjdk.java.net Sat Mar 26 09:18:04 2022 From: dlong at openjdk.java.net (Dean Long) Date: Sat, 26 Mar 2022 09:18:04 GMT Subject: Integrated: vthreads don't support the reserved stack zone In-Reply-To: References: Message-ID: On Thu, 24 Mar 2022 08:37:07 GMT, Dean Long wrote: > vthreads don't support the reserved stack zone This pull request has now been integrated. Changeset: 4c54c53e Author: Dean Long URL: https://git.openjdk.java.net/loom/commit/4c54c53e9f113c262203e330775c95e1123b23b5 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod vthreads don't support the reserved stack zone Reviewed-by: eosterlund, coleenp, rpressler ------------- PR: https://git.openjdk.java.net/loom/pull/120 From dlong at openjdk.java.net Sat Mar 26 09:40:49 2022 From: dlong at openjdk.java.net (Dean Long) Date: Sat, 26 Mar 2022 09:40:49 GMT Subject: RFR: vthreads don't support the reserved stack zone [v2] In-Reply-To: References: Message-ID: On Thu, 24 Mar 2022 21:30:46 GMT, Dean Long wrote: >> vthreads don't support the reserved stack zone > > Dean Long has updated the pull request incrementally with one additional commit since the last revision: > > redo Thanks all for the reviews. ------------- PR: https://git.openjdk.java.net/loom/pull/120 From duke at openjdk.java.net Sun Mar 27 03:55:19 2022 From: duke at openjdk.java.net (duke) Date: Sun, 27 Mar 2022 03:55:19 GMT Subject: git: openjdk/loom: fibers: JVMTI cleanup: get rid of some TBD comments Message-ID: <92d49edb-4310-4903-b9e3-52bb2806a25a@openjdk.java.net> Changeset: 920c3246 Author: Serguei Spitsyn Date: 2022-03-27 03:54:08 +0000 URL: https://git.openjdk.java.net/loom/commit/920c324673aa40a7e18b62c61c49aec023478098 JVMTI cleanup: get rid of some TBD comments ! src/hotspot/share/prims/jvmtiEnvThreadState.cpp ! src/hotspot/share/prims/jvmtiEventController.cpp From duke at openjdk.java.net Sun Mar 27 04:17:32 2022 From: duke at openjdk.java.net (duke) Date: Sun, 27 Mar 2022 04:17:32 GMT Subject: git: openjdk/loom: fibers: 2 new changesets Message-ID: <394698c4-f551-469d-b520-4b5b2179eba8@openjdk.java.net> Changeset: 4ab7281d Author: Chris Plummer Date: 2022-03-27 04:14:10 +0000 URL: https://git.openjdk.java.net/loom/commit/4ab7281d915283c2201e0207b3cd62a881c5f2ea Update comment. ! test/hotspot/jtreg/vmTestbase/nsk/share/jdi/Binder.java Changeset: c9b088d3 Author: Chris Plummer Date: 2022-03-27 04:15:12 +0000 URL: https://git.openjdk.java.net/loom/commit/c9b088d35c9af381916d57fd8196ba85b2e188e3 Fix for 8283717. Will also be fixing this in jdk/jdk with a PR. ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadStartEvent/thread/thread001.java From duke at openjdk.java.net Sun Mar 27 06:11:03 2022 From: duke at openjdk.java.net (duke) Date: Sun, 27 Mar 2022 06:11:03 GMT Subject: git: openjdk/loom: fibers: 5 new changesets Message-ID: <4fd08308-bdc7-48af-b99f-36352e5aded1@openjdk.java.net> Changeset: f8b07851 Author: Alan Bateman Date: 2022-03-26 09:32:28 +0000 URL: https://git.openjdk.java.net/loom/commit/f8b07851ad39d257888b3d1ad8e2994732205165 Exclude java/util/logging/CheckZombieLockTest.java from wrapper runs ! test/jdk/ProblemList-vthread.txt Changeset: cefd0c91 Author: Alan Bateman Date: 2022-03-26 09:41:34 +0000 URL: https://git.openjdk.java.net/loom/commit/cefd0c91438d9501c412139b16af3b2739d66e2b Update tck tests from jsr166-cvs/dl ! test/jdk/java/util/concurrent/tck/ExecutorsTest.java + test/jdk/java/util/concurrent/tck/ForkJoinPool19Test.java ! test/jdk/java/util/concurrent/tck/ForkJoinPoolTest.java ! test/jdk/java/util/concurrent/tck/JSR166TestCase.java Changeset: 46bd6582 Author: Alan Bateman Date: 2022-03-26 16:30:46 +0000 URL: https://git.openjdk.java.net/loom/commit/46bd658267cda707c9293d643ae3e291bed180da Add header ! test/hotspot/jtreg/ProblemList-svc-vthread.txt Changeset: 08ecc711 Author: Alan Bateman Date: 2022-03-27 06:58:06 +0000 URL: https://git.openjdk.java.net/loom/commit/08ecc711cbc09cfc52b322f35908766429eecb87 Fix header ! src/java.base/share/classes/java/util/concurrent/CountedCompleter.java Changeset: d528caa6 Author: Alan Bateman Date: 2022-03-27 06:59:54 +0000 URL: https://git.openjdk.java.net/loom/commit/d528caa6c9b961f399362d66c65aafb339751c4f ForkJoinPool update from jsr166-cvs/dl ! src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java From duke at openjdk.java.net Sun Mar 27 14:36:19 2022 From: duke at openjdk.java.net (duke) Date: Sun, 27 Mar 2022 14:36:19 GMT Subject: git: openjdk/loom: fibers: Update exclude lists to reduce noise in test runs Message-ID: <712094c3-bab5-4974-a9f7-830a6eb9476d@openjdk.java.net> Changeset: 4d22432b Author: Alan Bateman Date: 2022-03-27 15:34:11 +0000 URL: https://git.openjdk.java.net/loom/commit/4d22432bf02c525236faa4c1ee5c821c948737d2 Update exclude lists to reduce noise in test runs ! test/hotspot/jtreg/ProblemList.txt ! test/jdk/ProblemList-vthread.txt ! test/jdk/ProblemList.txt From mlippincott at paypal.com Mon Mar 28 07:25:27 2022 From: mlippincott at paypal.com (Mark Lippincott) Date: Mon, 28 Mar 2022 07:25:27 +0000 Subject: Possible bug parking virtual threads with large stacks Message-ID: Hello all, A few of us at PayPal have been experimenting with the Loom binaries released over the past few months and while testing limitations, we ran into what we believe may be a bug. It seems that with many virtual threads with a large enough stack and light workload, a StackOverflowError occurs when parking a virtual thread. Using the code below, on a GCP instance with 4 cores and 16GB ram, a StackOverflowError is thrown with a stack depth of roughly 2000 and 20 virtual threads with Thread.startVirtualThread(). Under 20 virtual threads does not produce this error. Adding some workload between each stack depth function call causes the error to disappear at 20 threads. Using the ExecutorService from Executors.newVirtualThreadPerTaskExecutor() seems to increase these limitations. public class TestStackDepth { static final int sleepDuration = 3600000; static int numThreads; static int stackDepth; static int workload; public static void run(int threadId, int stack, boolean logData) { BigInteger a = BigInteger.ZERO; BigInteger b = BigInteger.ONE; for (int i = 0; i < workload; i++) { b = a.add(b); a = b.subtract(a); } String s = b.toString(); if (stack > 0) { if (logData && stack % 100 == 0) { System.out.printf("Thread %d: %d\n", threadId, stack); } run(threadId, stack - 1, logData); } else { if (logData) { System.out.printf("Thread %d in final depth %s\n", threadId, s.substring(0, Math.min(4, s.length()))); } try { Thread.sleep(sleepDuration); } catch (InterruptedException e) { e.printStackTrace(); } } } public static void main(String[] argv) { numThreads = Integer.parseInt(argv[0]); stackDepth = Integer.parseInt(argv[1]); int execType = Integer.parseInt(argv[2]); workload = Integer.parseInt(argv[3]); ExecutorService executor = Executors.newVirtualThreadPerTaskExecutor(); for (int i = 0; i < numThreads; i++) { int threadId = i + 1; boolean logData = threadId % (Math.max(1, numThreads / 10)) == 0; switch (execType) { case 1 -> Thread.startVirtualThread(() -> run(threadId, stackDepth, logData)); case 2 -> run(threadId, stackDepth, logData); case 3 -> Thread.ofPlatform().start(() -> run(threadId, stackDepth, logData)); case 4 -> Thread.ofVirtual().start(() -> run(threadId, stackDepth, logData)); case 5 -> executor.submit(() -> run(threadId, stackDepth, logData)); } } try { Thread.sleep(sleepDuration * 2); } catch (InterruptedException e) { e.printStackTrace(); } } } Running above code with arguments "20 2000 1 0" results in StackOverflowError. Increasing workload to 1000 removes error: "20 2000 1 1000". Using executor, stack depth can be increased to 3000: "20 3000 5 0". Altering the code even slightly seems to change the depth at which the error is thrown, but it seems to be consistent when run on the same machine. Thanks, Mark From ron.pressler at oracle.com Mon Mar 28 10:58:06 2022 From: ron.pressler at oracle.com (Ron Pressler) Date: Mon, 28 Mar 2022 10:58:06 +0000 Subject: Possible bug parking virtual threads with large stacks In-Reply-To: References: Message-ID: <7700A366-87E9-4C94-8693-4901296476F0@oracle.com> Hi. Can you try warming up the test program to make sure this isn?t just an effect of interpreted methods and compiled methods having different stack-frame sizes? Also, can you try increasing the maximum thread stack size with -Xss and see if that helps? ? Ron > On 28 Mar 2022, at 08:25, Mark Lippincott wrote: > > Hello all, > > A few of us at PayPal have been experimenting with the Loom binaries released over the past few months and while testing limitations, we ran into what we believe may be a bug. It seems that with many virtual threads with a large enough stack and light workload, a StackOverflowError occurs when parking a virtual thread. > > Using the code below, on a GCP instance with 4 cores and 16GB ram, a StackOverflowError is thrown with a stack depth of roughly 2000 and 20 virtual threads with Thread.startVirtualThread(). Under 20 virtual threads does not produce this error. Adding some workload between each stack depth function call causes the error to disappear at 20 threads. > > Using the ExecutorService from Executors.newVirtualThreadPerTaskExecutor() seems to increase these limitations. > > public class TestStackDepth { > static final int sleepDuration = 3600000; > static int numThreads; > static int stackDepth; > static int workload; > > public static void run(int threadId, int stack, boolean logData) { > BigInteger a = BigInteger.ZERO; > BigInteger b = BigInteger.ONE; > for (int i = 0; i < workload; i++) { > b = a.add(b); > a = b.subtract(a); > } > String s = b.toString(); > > if (stack > 0) { > if (logData && stack % 100 == 0) { > System.out.printf("Thread %d: %d\n", threadId, stack); > } > run(threadId, stack - 1, logData); > } else { > if (logData) { > System.out.printf("Thread %d in final depth %s\n", threadId, s.substring(0, Math.min(4, s.length()))); > } > > try { > Thread.sleep(sleepDuration); > } catch (InterruptedException e) { > e.printStackTrace(); > } > } > } > > public static void main(String[] argv) { > numThreads = Integer.parseInt(argv[0]); > stackDepth = Integer.parseInt(argv[1]); > int execType = Integer.parseInt(argv[2]); > workload = Integer.parseInt(argv[3]); > > ExecutorService executor = Executors.newVirtualThreadPerTaskExecutor(); > > for (int i = 0; i < numThreads; i++) { > int threadId = i + 1; > boolean logData = threadId % (Math.max(1, numThreads / 10)) == 0; > switch (execType) { > case 1 -> Thread.startVirtualThread(() -> run(threadId, stackDepth, logData)); > case 2 -> run(threadId, stackDepth, logData); > case 3 -> Thread.ofPlatform().start(() -> run(threadId, stackDepth, logData)); > case 4 -> Thread.ofVirtual().start(() -> run(threadId, stackDepth, logData)); > case 5 -> executor.submit(() -> run(threadId, stackDepth, logData)); > } > } > > try { > Thread.sleep(sleepDuration * 2); > } catch (InterruptedException e) { > e.printStackTrace(); > } > } > } > > Running above code with arguments "20 2000 1 0" results in StackOverflowError. > Increasing workload to 1000 removes error: "20 2000 1 1000". > Using executor, stack depth can be increased to 3000: "20 3000 5 0". > > Altering the code even slightly seems to change the depth at which the error is thrown, but it seems to be consistent when run on the same machine. > > Thanks, > Mark From tschatzl at openjdk.java.net Mon Mar 28 13:12:53 2022 From: tschatzl at openjdk.java.net (Thomas Schatzl) Date: Mon, 28 Mar 2022 13:12:53 GMT Subject: RFR: Various GC cleanups In-Reply-To: References: Message-ID: On Fri, 25 Mar 2022 13:43:57 GMT, Thomas Schatzl wrote: > Please review these cleanups, mostly done by @stefank. > > It is probably best to review the commits separately. > > Testing: loom-tier1-3 > > Regards, > Thomas This PR has already been pulled, so closing this out. ------------- PR: https://git.openjdk.java.net/loom/pull/123 From tschatzl at openjdk.java.net Mon Mar 28 13:12:53 2022 From: tschatzl at openjdk.java.net (Thomas Schatzl) Date: Mon, 28 Mar 2022 13:12:53 GMT Subject: Withdrawn: Various GC cleanups In-Reply-To: References: Message-ID: On Fri, 25 Mar 2022 13:43:57 GMT, Thomas Schatzl wrote: > Please review these cleanups, mostly done by @stefank. > > It is probably best to review the commits separately. > > Testing: loom-tier1-3 > > Regards, > Thomas This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/loom/pull/123 From tschatzl at openjdk.java.net Mon Mar 28 14:32:16 2022 From: tschatzl at openjdk.java.net (Thomas Schatzl) Date: Mon, 28 Mar 2022 14:32:16 GMT Subject: RFR: Various GC cleanups In-Reply-To: References: Message-ID: On Fri, 25 Mar 2022 13:43:57 GMT, Thomas Schatzl wrote: > Please review these cleanups, mostly done by @stefank. > > It is probably best to review the commits separately. > > Testing: loom-tier1-3 > > Regards, > Thomas Sorry for the open-close dance. Yes, the change has definitely already been merged. ------------- PR: https://git.openjdk.java.net/loom/pull/123 From duke at openjdk.java.net Mon Mar 28 14:47:26 2022 From: duke at openjdk.java.net (duke) Date: Mon, 28 Mar 2022 14:47:26 GMT Subject: git: openjdk/loom: fibers: 2 new changesets Message-ID: Changeset: 7309b19a Author: Ron Pressler Date: 2022-03-28 12:23:57 +0000 URL: https://git.openjdk.java.net/loom/commit/7309b19a3a558a6a135ce8c5a936e6a7c09528c5 fix ContinuationEntry initialization on aarch64 ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp Changeset: 19a64e89 Author: Ron Pressler Date: 2022-03-28 12:24:33 +0000 URL: https://git.openjdk.java.net/loom/commit/19a64e8913eaf3d0eebe0fd5b12976bcca2c996a Move pinning filed from Continuation to ContinuationEntry ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/javaClasses.inline.hpp ! src/hotspot/share/runtime/continuation.cpp ! src/hotspot/share/runtime/continuation.hpp ! src/java.base/share/classes/jdk/internal/vm/Continuation.java From duke at openjdk.java.net Mon Mar 28 15:58:51 2022 From: duke at openjdk.java.net (duke) Date: Mon, 28 Mar 2022 15:58:51 GMT Subject: git: openjdk/loom: fibers: 2 new changesets Message-ID: <2e00b219-4e41-48c2-9443-ae1faee494ac@openjdk.java.net> Changeset: b12b40d4 Author: Ron Pressler Date: 2022-03-28 15:55:55 +0000 URL: https://git.openjdk.java.net/loom/commit/b12b40d4f7ca203662683070c4bddd8d577cbcec A small refactor ! src/hotspot/share/runtime/continuation.cpp Changeset: db2f7ff9 Author: Ron Pressler Date: 2022-03-28 16:40:28 +0000 URL: https://git.openjdk.java.net/loom/commit/db2f7ff953da7da9d9964cb2a91e829a9e110d28 - ! src/hotspot/share/runtime/continuation.cpp From duke at openjdk.java.net Mon Mar 28 20:57:36 2022 From: duke at openjdk.java.net (duke) Date: Mon, 28 Mar 2022 20:57:36 GMT Subject: git: openjdk/loom: fibers: 2 new changesets Message-ID: <575bcb89-9ee3-4516-887c-3562fdc34835@openjdk.java.net> Changeset: 38934d13 Author: Chris Plummer Date: 2022-03-28 20:55:18 +0000 URL: https://git.openjdk.java.net/loom/commit/38934d139a3e0297b7dd19855840018b482e96ba Fix 8283796. Make sure the threads created by the debuggee are daemon threads. ! test/jdk/com/sun/jdi/ResumeOneThreadTest.java Changeset: e507c65e Author: Chris Plummer Date: 2022-03-28 20:56:15 +0000 URL: https://git.openjdk.java.net/loom/commit/e507c65ee040f032962ffc656ceabb398d1d3afc Fix comment typo. ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadStartEvent/thread/thread001.java From duke at openjdk.java.net Mon Mar 28 21:24:12 2022 From: duke at openjdk.java.net (duke) Date: Mon, 28 Mar 2022 21:24:12 GMT Subject: git: openjdk/loom: fibers: reverted jcstress to jdk/jdk Message-ID: Changeset: 4de04bc4 Author: lmesnik Date: 2022-03-28 15:23:34 +0000 URL: https://git.openjdk.java.net/loom/commit/4de04bc4af0b02cf6d0e8f79f9c0e6c595108229 reverted jcstress to jdk/jdk ! test/hotspot/jtreg/applications/jcstress/TestGenerator.java ! test/hotspot/jtreg/applications/jcstress/accessAtomic.java ! test/hotspot/jtreg/applications/jcstress/acqrel.java ! test/hotspot/jtreg/applications/jcstress/atomicity.java ! test/hotspot/jtreg/applications/jcstress/atomics.java ! test/hotspot/jtreg/applications/jcstress/causality.java ! test/hotspot/jtreg/applications/jcstress/coherence.java ! test/hotspot/jtreg/applications/jcstress/copy.java ! test/hotspot/jtreg/applications/jcstress/countdownlatch.java ! test/hotspot/jtreg/applications/jcstress/defaultValues.java ! test/hotspot/jtreg/applications/jcstress/executors.java ! test/hotspot/jtreg/applications/jcstress/fences.java ! test/hotspot/jtreg/applications/jcstress/future.java ! test/hotspot/jtreg/applications/jcstress/init.java ! test/hotspot/jtreg/applications/jcstress/initClass.java ! test/hotspot/jtreg/applications/jcstress/initLen.java ! test/hotspot/jtreg/applications/jcstress/interrupt.java ! test/hotspot/jtreg/applications/jcstress/locks.java ! test/hotspot/jtreg/applications/jcstress/memeffects.java ! test/hotspot/jtreg/applications/jcstress/seqcst.java ! test/hotspot/jtreg/applications/jcstress/singletons.java ! test/hotspot/jtreg/applications/jcstress/strings.java ! test/hotspot/jtreg/applications/jcstress/tearing.java ! test/hotspot/jtreg/applications/jcstress/threadlocal.java ! test/hotspot/jtreg/applications/jcstress/unsafe.java ! test/hotspot/jtreg/applications/jcstress/varhandles.java ! test/hotspot/jtreg/applications/jcstress/volatiles.java From duke at openjdk.java.net Mon Mar 28 22:49:54 2022 From: duke at openjdk.java.net (duke) Date: Mon, 28 Mar 2022 22:49:54 GMT Subject: git: openjdk/loom: fibers: serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java excluded Message-ID: <9f5e84b7-f0ad-4310-8068-478586ba2497@openjdk.java.net> Changeset: e4773974 Author: lmesnik Date: 2022-03-28 16:47:02 +0000 URL: https://git.openjdk.java.net/loom/commit/e477397477cbbcc15305506a4905d165963b1e5a serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java excluded ! test/hotspot/jtreg/ProblemList.txt From duke at openjdk.java.net Tue Mar 29 01:14:41 2022 From: duke at openjdk.java.net (duke) Date: Tue, 29 Mar 2022 01:14:41 GMT Subject: git: openjdk/loom: fibers: vmTestbase/gc/gctests/SoftReference/soft001 fixed Message-ID: <269837d0-09d5-40af-9fe8-ca586ab80525@openjdk.java.net> Changeset: 37bb454b Author: lmesnik Date: 2022-03-28 19:14:01 +0000 URL: https://git.openjdk.java.net/loom/commit/37bb454bbcc9f07c00c51da3d3d8ec1a0f7bf9e5 vmTestbase/gc/gctests/SoftReference/soft001 fixed ! test/hotspot/jtreg/vmTestbase/nsk/share/log/LogSupport.java From cjplummer at openjdk.java.net Tue Mar 29 02:21:34 2022 From: cjplummer at openjdk.java.net (Chris Plummer) Date: Tue, 29 Mar 2022 02:21:34 GMT Subject: RFR: Make sure nsk debugger tests launch the debuggee with --enable-preview Message-ID: Make sure nsk debugger tests launch the debuggee with --enable-preview #125 ------------- Commit messages: - Make sure nsk debugger tests launch the debuggee with --enable-preview Changes: https://git.openjdk.java.net/loom/pull/125/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=125&range=00 Stats: 22 lines in 3 files changed: 20 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/loom/pull/125.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/125/head:pull/125 PR: https://git.openjdk.java.net/loom/pull/125 From lmesnik at openjdk.java.net Tue Mar 29 03:38:09 2022 From: lmesnik at openjdk.java.net (Leonid Mesnik) Date: Tue, 29 Mar 2022 03:38:09 GMT Subject: RFR: Make sure nsk debugger tests launch the debuggee with --enable-preview In-Reply-To: References: Message-ID: On Tue, 29 Mar 2022 01:36:41 GMT, Chris Plummer wrote: > Make sure nsk debugger tests launch the debuggee with --enable-preview Marked as reviewed by lmesnik (Committer). ------------- PR: https://git.openjdk.java.net/loom/pull/125 From duke at openjdk.java.net Tue Mar 29 06:50:16 2022 From: duke at openjdk.java.net (duke) Date: Tue, 29 Mar 2022 06:50:16 GMT Subject: git: openjdk/loom: fibers: 3 new changesets Message-ID: Changeset: 1d618567 Author: Alan Bateman Date: 2022-03-29 07:29:04 +0000 URL: https://git.openjdk.java.net/loom/commit/1d618567e6404c9856a8ff987948f5df0f5e1422 Exclude serviceability/jvmti/events/FramePop/framepop02/framepop02.java ! test/hotspot/jtreg/ProblemList.txt Changeset: 79c150ba Author: Alan Bateman Date: 2022-03-29 07:30:28 +0000 URL: https://git.openjdk.java.net/loom/commit/79c150ba553c2af5cf7f3dae7806b9db60ddaa90 Exclude java/foreign/StdLibTest.java from wrapper runs until sync up to jdk-19+16 ! test/jdk/ProblemList-vthread.txt Changeset: 2b77a6f3 Author: Alan Bateman Date: 2022-03-29 07:48:11 +0000 URL: https://git.openjdk.java.net/loom/commit/2b77a6f3ecf26603e635e698e32d9e8d52d44058 Carrier thread should not inherit initial values of TLs ! src/java.base/share/classes/java/util/concurrent/ForkJoinWorkerThread.java ! src/java.base/share/classes/jdk/internal/misc/CarrierThread.java From rehn at openjdk.java.net Tue Mar 29 08:24:28 2022 From: rehn at openjdk.java.net (Robbin Ehn) Date: Tue, 29 Mar 2022 08:24:28 GMT Subject: RFR: Remove Config [v5] In-Reply-To: References: Message-ID: > For you to consider. > - Adds 1-2ns (thaw+freeze) (<0.5%) > - Passes t1-3 (no new issues found) > - Reduces compilation time with over 30 seconds (15-20%). > - Loom have the same compile time as vanilla jdk/jdk. Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Remove Config ------------- Changes: https://git.openjdk.java.net/loom/pull/110/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=110&range=04 Stats: 329 lines in 12 files changed: 15 ins; 139 del; 175 mod Patch: https://git.openjdk.java.net/loom/pull/110.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/110/head:pull/110 PR: https://git.openjdk.java.net/loom/pull/110 From duke at openjdk.java.net Tue Mar 29 11:49:16 2022 From: duke at openjdk.java.net (duke) Date: Tue, 29 Mar 2022 11:49:16 GMT Subject: git: openjdk/loom: fibers: 2 new changesets Message-ID: <379ccff4-3d11-4330-af00-1063232de726@openjdk.java.net> Changeset: aecd5d62 Author: Ron Pressler Date: 2022-03-29 12:24:19 +0000 URL: https://git.openjdk.java.net/loom/commit/aecd5d6287d5b503b96e4093b48e47326558acdc Don't check for requires_barriers when allocating with ZGC ! src/hotspot/share/runtime/continuation.cpp Changeset: 80a9facf Author: Ron Pressler Date: 2022-03-29 12:25:35 +0000 URL: https://git.openjdk.java.net/loom/commit/80a9facf97a03e7f2fd2277b51a512891143f5d8 Store thread ids rather than oops in VThreadList ! src/hotspot/share/prims/jvmtiThreadState.cpp ! src/hotspot/share/prims/jvmtiThreadState.hpp From duke at openjdk.java.net Tue Mar 29 13:47:22 2022 From: duke at openjdk.java.net (duke) Date: Tue, 29 Mar 2022 13:47:22 GMT Subject: git: openjdk/loom: fibers: 3 new changesets Message-ID: Changeset: 4def2c3f Author: Ron Pressler Date: 2022-03-29 14:37:12 +0000 URL: https://git.openjdk.java.net/loom/commit/4def2c3f47f735d10e4fcb061df2e1b544804e63 Cleanup ! src/hotspot/share/oops/instanceStackChunkKlass.cpp Changeset: 001cb44a Author: Ron Pressler Date: 2022-03-29 14:37:32 +0000 URL: https://git.openjdk.java.net/loom/commit/001cb44a300e43e4b72afc7e28cacd3a32f2ba3c Assertions ! src/hotspot/share/runtime/continuation.cpp Changeset: c5fa6741 Author: Ron Pressler Date: 2022-03-29 14:38:07 +0000 URL: https://git.openjdk.java.net/loom/commit/c5fa6741162b2ffdaa8abaed3483847690ad71d0 Fix JvmtiEnv::GetCurrentThreadCpuTime to not access an oop ! src/hotspot/share/prims/jvmtiEnv.cpp From duke at openjdk.java.net Tue Mar 29 15:21:21 2022 From: duke at openjdk.java.net (duke) Date: Tue, 29 Mar 2022 15:21:21 GMT Subject: git: openjdk/loom: fibers: 2 new changesets Message-ID: Changeset: 46a1b2dc Author: Ron Pressler Date: 2022-03-29 16:17:56 +0000 URL: https://git.openjdk.java.net/loom/commit/46a1b2dc11aa86c268dfe28f157068aec653d02a Fix allocate_chunk ! src/hotspot/share/gc/shared/memAllocator.cpp ! src/hotspot/share/gc/shared/memAllocator.hpp ! src/hotspot/share/runtime/continuation.cpp Changeset: 2c500fb2 Author: Ron Pressler Date: 2022-03-29 16:19:13 +0000 URL: https://git.openjdk.java.net/loom/commit/2c500fb2dcbb6432034970d5da8681236c469431 Throw StackOverflowError when freezing a humongous chunk ! src/hotspot/share/runtime/continuation.cpp ! test/jdk/jdk/internal/vm/Continuation/HumongousStack.java From duke at openjdk.java.net Tue Mar 29 16:02:50 2022 From: duke at openjdk.java.net (duke) Date: Tue, 29 Mar 2022 16:02:50 GMT Subject: git: openjdk/loom: fibers: 2 new changesets Message-ID: <0f0a0c9f-95bf-4571-a41a-d307a47944e0@openjdk.java.net> Changeset: b26ac3c4 Author: lmesnik Date: 2022-03-29 10:01:24 +0000 URL: https://git.openjdk.java.net/loom/commit/b26ac3c451774ac93aef6013de90ed8705a777fa updated jcstress lib version ! test/hotspot/jtreg/applications/jcstress/JcstressRunner.java Changeset: 5511fe50 Author: lmesnik Date: 2022-03-29 10:01:51 +0000 URL: https://git.openjdk.java.net/loom/commit/5511fe50d561fa01f79957f0e51f0c8804be5af5 Merge branch 'fibers' of https://github.com/openjdk/loom into fibers From coleenp at openjdk.java.net Tue Mar 29 16:10:13 2022 From: coleenp at openjdk.java.net (Coleen Phillimore) Date: Tue, 29 Mar 2022 16:10:13 GMT Subject: RFR: Remove Config [v5] In-Reply-To: References: Message-ID: On Tue, 29 Mar 2022 08:24:28 GMT, Robbin Ehn wrote: >> For you to consider. >> - Adds 1-2ns (thaw+freeze) (<0.5%) >> - Passes t1-3 (no new issues found) >> - Reduces compilation time with over 30 seconds (15-20%). >> - Loom have the same compile time as vanilla jdk/jdk. > > Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Remove Config more whitespace errors... ------------- PR: https://git.openjdk.java.net/loom/pull/110 From cjplummer at openjdk.java.net Tue Mar 29 16:13:08 2022 From: cjplummer at openjdk.java.net (Chris Plummer) Date: Tue, 29 Mar 2022 16:13:08 GMT Subject: Integrated: Make sure nsk debugger tests launch the debuggee with --enable-preview In-Reply-To: References: Message-ID: <7A0IMOY4vlMdtdN4QCM0TZB7OWIC3nN0llEJw6CMfqc=.46427b32-b25a-466d-b696-4a2583afcbac@github.com> On Tue, 29 Mar 2022 01:36:41 GMT, Chris Plummer wrote: > Make sure nsk debugger tests launch the debuggee with --enable-preview This pull request has now been integrated. Changeset: 80d98bfd Author: Chris Plummer URL: https://git.openjdk.java.net/loom/commit/80d98bfd8a185d63533f8b7de11ff37480c5c25e Stats: 22 lines in 3 files changed: 20 ins; 0 del; 2 mod Make sure nsk debugger tests launch the debuggee with --enable-preview Reviewed-by: lmesnik ------------- PR: https://git.openjdk.java.net/loom/pull/125 From duke at openjdk.java.net Tue Mar 29 23:29:07 2022 From: duke at openjdk.java.net (duke) Date: Tue, 29 Mar 2022 23:29:07 GMT Subject: git: openjdk/loom: fibers: 3 new changesets Message-ID: Changeset: d45f9671 Author: Ron Pressler Date: 2022-03-29 17:31:31 +0000 URL: https://git.openjdk.java.net/loom/commit/d45f9671b6a3c26e68a2a525f34687e7a85b6c34 Cleanup ! src/hotspot/share/gc/shared/memAllocator.cpp ! src/hotspot/share/gc/shared/memAllocator.hpp ! src/hotspot/share/runtime/continuation.cpp Changeset: 68d5b5ae Author: Ron Pressler Date: 2022-03-29 17:31:57 +0000 URL: https://git.openjdk.java.net/loom/commit/68d5b5ae2c60e8569623188558f683dd0093b918 Don't resolve the mounted_thread OopHandle in GetCurrentThreadCpuTime ! src/hotspot/share/prims/jvmtiEnv.cpp Changeset: d395bdbd Author: Ron Pressler Date: 2022-03-29 20:11:51 +0000 URL: https://git.openjdk.java.net/loom/commit/d395bdbd23514c10e2991cf2348b5f88b0f2da28 Add Handle::replace method ! src/hotspot/share/prims/stackwalk.cpp ! src/hotspot/share/runtime/frame.cpp ! src/hotspot/share/runtime/handles.hpp ! src/hotspot/share/runtime/handles.inline.hpp From rehn at openjdk.java.net Wed Mar 30 06:20:26 2022 From: rehn at openjdk.java.net (Robbin Ehn) Date: Wed, 30 Mar 2022 06:20:26 GMT Subject: RFR: Remove Config [v6] In-Reply-To: References: Message-ID: > For you to consider. > - Adds 1-2ns (thaw+freeze) (<0.5%) > - Passes t1-3 (no new issues found) > - Reduces compilation time with over 30 seconds (15-20%). > - Loom have the same compile time as vanilla jdk/jdk. Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Remove Config ------------- Changes: https://git.openjdk.java.net/loom/pull/110/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=110&range=05 Stats: 330 lines in 12 files changed: 15 ins; 139 del; 176 mod Patch: https://git.openjdk.java.net/loom/pull/110.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/110/head:pull/110 PR: https://git.openjdk.java.net/loom/pull/110 From rehn at openjdk.java.net Wed Mar 30 10:25:38 2022 From: rehn at openjdk.java.net (Robbin Ehn) Date: Wed, 30 Mar 2022 10:25:38 GMT Subject: RFR: Reverted unrelated, wrong or unused changes Message-ID: Reverted to master unrelated, wrong or unused changes. Running loom-t1 ------------- Commit messages: - Rev vmError.cpp - Reverted safepoint.xpp - Reverted prefetch - Reverted objectMonitor.inline.hpp - Reverted interfaceSupport.inline.hpp - Removed added extra space Changes: https://git.openjdk.java.net/loom/pull/126/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=126&range=00 Stats: 45 lines in 13 files changed: 2 ins; 41 del; 2 mod Patch: https://git.openjdk.java.net/loom/pull/126.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/126/head:pull/126 PR: https://git.openjdk.java.net/loom/pull/126 From rehn at openjdk.java.net Wed Mar 30 10:30:35 2022 From: rehn at openjdk.java.net (Robbin Ehn) Date: Wed, 30 Mar 2022 10:30:35 GMT Subject: RFR: Remove Config [v7] In-Reply-To: References: Message-ID: > For you to consider. > - Adds 1-2ns (thaw+freeze) (<0.5%) > - Passes t1-3 (no new issues found) > - Reduces compilation time with over 30 seconds (15-20%). > - Loom have the same compile time as vanilla jdk/jdk. Robbin Ehn has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Remove Config ------------- Changes: - all: https://git.openjdk.java.net/loom/pull/110/files - new: https://git.openjdk.java.net/loom/pull/110/files/92e8f9a6..96afa959 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=loom&pr=110&range=06 - incr: https://webrevs.openjdk.java.net/?repo=loom&pr=110&range=05-06 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/loom/pull/110.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/110/head:pull/110 PR: https://git.openjdk.java.net/loom/pull/110 From eosterlund at openjdk.java.net Wed Mar 30 10:30:54 2022 From: eosterlund at openjdk.java.net (Erik =?UTF-8?B?w5ZzdGVybHVuZA==?=) Date: Wed, 30 Mar 2022 10:30:54 GMT Subject: RFR: Reverted unrelated, wrong or unused changes In-Reply-To: References: Message-ID: On Wed, 30 Mar 2022 10:16:52 GMT, Robbin Ehn wrote: > Reverted to master unrelated, wrong or unused changes. > > Running loom-t1 Looks good. ------------- Marked as reviewed by eosterlund (Committer). PR: https://git.openjdk.java.net/loom/pull/126 From tschatzl at openjdk.java.net Wed Mar 30 11:07:47 2022 From: tschatzl at openjdk.java.net (Thomas Schatzl) Date: Wed, 30 Mar 2022 11:07:47 GMT Subject: RFR: Reverted unrelated, wrong or unused changes In-Reply-To: References: Message-ID: On Wed, 30 Mar 2022 10:16:52 GMT, Robbin Ehn wrote: > Reverted to master unrelated, wrong or unused changes. > > Running loom-t1 Marked as reviewed by tschatzl (no project role). ------------- PR: https://git.openjdk.java.net/loom/pull/126 From rehn at openjdk.java.net Wed Mar 30 11:31:04 2022 From: rehn at openjdk.java.net (Robbin Ehn) Date: Wed, 30 Mar 2022 11:31:04 GMT Subject: RFR: Reverted unrelated, wrong or unused changes In-Reply-To: References: Message-ID: On Wed, 30 Mar 2022 10:16:52 GMT, Robbin Ehn wrote: > Reverted to master unrelated, wrong or unused changes. > > Running loom-t1 Thanks! ------------- PR: https://git.openjdk.java.net/loom/pull/126 From rehn at openjdk.java.net Wed Mar 30 11:31:05 2022 From: rehn at openjdk.java.net (Robbin Ehn) Date: Wed, 30 Mar 2022 11:31:05 GMT Subject: Integrated: Reverted unrelated, wrong or unused changes In-Reply-To: References: Message-ID: On Wed, 30 Mar 2022 10:16:52 GMT, Robbin Ehn wrote: > Reverted to master unrelated, wrong or unused changes. > > Running loom-t1 This pull request has now been integrated. Changeset: 68052ef2 Author: Robbin Ehn URL: https://git.openjdk.java.net/loom/commit/68052ef21dca26e1a7aecca346917de669a1c4b6 Stats: 45 lines in 13 files changed: 2 ins; 41 del; 2 mod Reverted unrelated, wrong or unused changes Reviewed-by: eosterlund, tschatzl ------------- PR: https://git.openjdk.java.net/loom/pull/126 From duke at openjdk.java.net Wed Mar 30 11:42:44 2022 From: duke at openjdk.java.net (duke) Date: Wed, 30 Mar 2022 11:42:44 GMT Subject: git: openjdk/loom: fibers: suspend carrier thread after vthread unmount if requested; rename _thread_suspended field Message-ID: <5f810e12-5e08-49e8-86aa-b552ad5368ea@openjdk.java.net> Changeset: 2be78097 Author: Serguei Spitsyn Date: 2022-03-30 11:39:41 +0000 URL: https://git.openjdk.java.net/loom/commit/2be780976f54cd1b84f011e233a6d9a4b8148b8f suspend carrier thread after vthread unmount if requested; rename _thread_suspended field ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/prims/jvmtiEnvBase.cpp ! src/hotspot/share/prims/jvmtiThreadState.cpp ! src/hotspot/share/prims/jvmtiThreadState.hpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/thread.inline.hpp From duke at openjdk.java.net Wed Mar 30 12:17:39 2022 From: duke at openjdk.java.net (duke) Date: Wed, 30 Mar 2022 12:17:39 GMT Subject: git: openjdk/loom: fibers: 21 new changesets Message-ID: Changeset: a3997553 Author: Stefan Karlsson Date: 2022-03-29 09:08:23 +0000 URL: https://git.openjdk.java.net/loom/commit/a39975538ea70f6f742b542ac87f119e3e4dd230 8283784: java_lang_String::as_platform_dependent_str stores to oop in native state ! src/hotspot/share/classfile/javaClasses.cpp Changeset: 0fbf8dbc Author: Stefan Karlsson Date: 2022-03-29 09:08:49 +0000 URL: https://git.openjdk.java.net/loom/commit/0fbf8dbc81afcea045390ad2411fc67ed42f88d1 InstanceKlass::class_loader_printer test access oop in native state ! test/hotspot/gtest/oops/test_instanceKlass.cpp Changeset: aafeb59b Author: Stefan Karlsson Date: 2022-03-29 09:11:13 +0000 URL: https://git.openjdk.java.net/loom/commit/aafeb59b4cf2e9bf0defac38aed34788300c934a Verify thread state in Access API ! src/hotspot/share/oops/accessBackend.cpp ! src/hotspot/share/oops/accessBackend.hpp Changeset: 51771d00 Author: Stefan Karlsson Date: 2022-03-29 09:51:43 +0000 URL: https://git.openjdk.java.net/loom/commit/51771d00cfa17dfacd5e3fe4a3376b814928dcd8 Remove out-commented friends ! src/hotspot/share/oops/instanceStackChunkKlass.hpp Changeset: d7c57564 Author: Stefan Karlsson Date: 2022-03-29 10:46:29 +0000 URL: https://git.openjdk.java.net/loom/commit/d7c5756483b441eee5682bada3f7ffb87875a585 Rename oop_oop_iterate_stack_helper ! src/hotspot/share/oops/instanceStackChunkKlass.hpp ! src/hotspot/share/oops/instanceStackChunkKlass.inline.hpp Changeset: 952df154 Author: Stefan Karlsson Date: 2022-03-29 11:06:57 +0000 URL: https://git.openjdk.java.net/loom/commit/952df1548e4001b600bc155c86bb34a60515448e Remove dynamic UseCompressedOops check in oop_oop_iterate_stack_with_bitmap ! src/hotspot/share/oops/instanceStackChunkKlass.hpp ! src/hotspot/share/oops/instanceStackChunkKlass.inline.hpp Changeset: 611b5bbd Author: Stefan Karlsson Date: 2022-03-29 11:09:09 +0000 URL: https://git.openjdk.java.net/loom/commit/611b5bbd3a5cda1984ace33b2d8784ce6f067fe8 Remove do_metadata virtual call in OopOopIterateStackClosure ! src/hotspot/share/oops/instanceStackChunkKlass.cpp Changeset: 2e7dfc67 Author: Stefan Karlsson Date: 2022-03-29 11:20:43 +0000 URL: https://git.openjdk.java.net/loom/commit/2e7dfc678dfed3f220e51c4b254f5e67e360a416 Minor cleanups to oop_oop_iterate_stack closures ! src/hotspot/share/oops/instanceStackChunkKlass.cpp Changeset: e7a2806b Author: Stefan Karlsson Date: 2022-03-29 11:22:33 +0000 URL: https://git.openjdk.java.net/loom/commit/e7a2806b01150772b8c1e3da47ca4da693f68dba Don't use anonymous namespaces ! src/hotspot/share/oops/instanceStackChunkKlass.cpp Changeset: ecc0f4c3 Author: Stefan Karlsson Date: 2022-03-29 11:32:18 +0000 URL: https://git.openjdk.java.net/loom/commit/ecc0f4c324588da7eb8c5e4a82cdc16d6b9798b0 Move the rest of StackChunkFrameStream out of instanceStackChunkKlass files ! src/hotspot/share/oops/instanceStackChunkKlass.cpp ! src/hotspot/share/runtime/frame.hpp + src/hotspot/share/runtime/stackChunkFrameStream.cpp Changeset: a344abe3 Author: Stefan Karlsson Date: 2022-03-29 11:34:16 +0000 URL: https://git.openjdk.java.net/loom/commit/a344abe3eda9b25b5505aa9cb90d4cede33eacf0 Remove unused variables ! src/hotspot/share/oops/instanceStackChunkKlass.cpp Changeset: 1d9d9099 Author: Stefan Karlsson Date: 2022-03-29 11:41:27 +0000 URL: https://git.openjdk.java.net/loom/commit/1d9d9099f2e1b0bcc1fd151eb126ef85e57de776 Tidy up safe_load ! src/hotspot/share/oops/instanceStackChunkKlass.cpp Changeset: 5ff96058 Author: Stefan Karlsson Date: 2022-03-29 13:46:15 +0000 URL: https://git.openjdk.java.net/loom/commit/5ff96058ce067e8a52077a6e6c04b75ffedfa8a0 Stricter types in UncompressOopsOopClosure ! src/hotspot/share/oops/instanceStackChunkKlass.cpp Changeset: 1b5e1d71 Author: Stefan Karlsson Date: 2022-03-29 14:01:09 +0000 URL: https://git.openjdk.java.net/loom/commit/1b5e1d71f7b1014484837eaa8a24159e713d3b24 Further deduplicate and rename relativize dervied oops function and classes ! src/hotspot/share/oops/instanceStackChunkKlass.cpp ! src/hotspot/share/oops/stackChunkOop.cpp ! src/hotspot/share/oops/stackChunkOop.hpp Changeset: 8855e0b1 Author: Stefan Karlsson Date: 2022-03-29 15:51:20 +0000 URL: https://git.openjdk.java.net/loom/commit/8855e0b1f68d0fa8f5fd92b4d40dd19453fded77 Workaround ZGC + finalizable stack chunks problem ! src/hotspot/share/gc/shared/continuationGCSupport.hpp ! src/hotspot/share/gc/shared/continuationGCSupport.inline.hpp ! src/hotspot/share/gc/z/zMark.cpp Changeset: 4b829a27 Author: Stefan Karlsson Date: 2022-03-29 15:51:37 +0000 URL: https://git.openjdk.java.net/loom/commit/4b829a27752a9a249d5a4b4ae7c5c4cc5d2bad25 Move fix_thawed_frame ! src/hotspot/share/oops/instanceStackChunkKlass.cpp ! src/hotspot/share/oops/instanceStackChunkKlass.hpp ! src/hotspot/share/oops/stackChunkOop.cpp ! src/hotspot/share/oops/stackChunkOop.hpp ! src/hotspot/share/runtime/continuation.cpp Changeset: d0c67248 Author: Stefan Karlsson Date: 2022-03-29 18:07:38 +0000 URL: https://git.openjdk.java.net/loom/commit/d0c672488d2676a965b48bbfa87fdb3a87c59e05 Add comment explaining ZGC check in RelativizeDerivedOopClosure ! src/hotspot/share/gc/z/zMark.cpp ! src/hotspot/share/oops/stackChunkOop.cpp Changeset: 6af7d754 Author: Stefan Karlsson Date: 2022-03-29 18:23:35 +0000 URL: https://git.openjdk.java.net/loom/commit/6af7d754261fda9eca51e15566477296fd6c3f07 Add and update comments in RelativizeDerivedOopClosure ! src/hotspot/share/oops/stackChunkOop.cpp Changeset: a8ab5738 Author: Stefan Karlsson Date: 2022-03-29 18:31:50 +0000 URL: https://git.openjdk.java.net/loom/commit/a8ab57383ec54ed14b1cce1b60d982565f818efd Fix GenCollectedHeap::requires_barriers include problem ! src/hotspot/share/gc/shared/genCollectedHeap.cpp ! src/hotspot/share/gc/shared/genCollectedHeap.hpp Changeset: ed7f56a8 Author: Stefan Karlsson Date: 2022-03-30 09:01:10 +0000 URL: https://git.openjdk.java.net/loom/commit/ed7f56a8fa602d374adf1a861235fddd5b2a210a Remove unused copy declaration ! src/hotspot/share/oops/instanceStackChunkKlass.hpp Changeset: f97f96ba Author: Stefan Karlsson Date: 2022-03-30 10:58:53 +0000 URL: https://git.openjdk.java.net/loom/commit/f97f96bab50b66742c6fde5d2c95ca12677ec6bf Typo ! src/hotspot/share/oops/stackChunkOop.cpp From duke at openjdk.java.net Wed Mar 30 16:19:59 2022 From: duke at openjdk.java.net (duke) Date: Wed, 30 Mar 2022 16:19:59 GMT Subject: git: openjdk/loom: fibers: Fix throwing of SOE on humongous chunks Message-ID: <3a257738-f771-45af-aa9c-c5419e2b418e@openjdk.java.net> Changeset: 0e112b9d Author: Ron Pressler Date: 2022-03-30 17:17:47 +0000 URL: https://git.openjdk.java.net/loom/commit/0e112b9d0a08803c89f8bc7bc4fd6bbe321f29eb Fix throwing of SOE on humongous chunks ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/shared/collectedHeap.cpp ! src/hotspot/share/gc/shared/collectedHeap.hpp ! src/hotspot/share/runtime/continuation.cpp From duke at openjdk.java.net Wed Mar 30 16:22:46 2022 From: duke at openjdk.java.net (duke) Date: Wed, 30 Mar 2022 16:22:46 GMT Subject: git: openjdk/loom: fibers: - Message-ID: <62021426-664c-47a3-a1e0-2e261ec8442e@openjdk.java.net> Changeset: d94eff44 Author: Ron Pressler Date: 2022-03-30 17:21:06 +0000 URL: https://git.openjdk.java.net/loom/commit/d94eff44dc2f3d5e85ef8efa1459f1d1eb06ca72 - ! src/hotspot/share/runtime/continuation.cpp From duke at openjdk.java.net Wed Mar 30 18:10:57 2022 From: duke at openjdk.java.net (duke) Date: Wed, 30 Mar 2022 18:10:57 GMT Subject: git: openjdk/loom: fibers: Properly fix 8283586. Real issue was a race condition when incrementing a counter. Message-ID: <64db44ef-ec1c-4df7-a006-ea2194522a30@openjdk.java.net> Changeset: 1711c74f Author: Chris Plummer Date: 2022-03-30 18:09:28 +0000 URL: https://git.openjdk.java.net/loom/commit/1711c74fa7c0bff0f98aaaa76dbfee0af2d9dc6d Properly fix 8283586. Real issue was a race condition when incrementing a counter. ! test/hotspot/jtreg/vmTestbase/nsk/jdb/kill/kill001/kill001a.java From duke at openjdk.java.net Wed Mar 30 19:10:40 2022 From: duke at openjdk.java.net (duke) Date: Wed, 30 Mar 2022 19:10:40 GMT Subject: git: openjdk/loom: fibers: Problem list allthr001 failure. Message-ID: <757a1338-457d-4248-9af4-984152f5fcc4@openjdk.java.net> Changeset: 31775a60 Author: Chris Plummer Date: 2022-03-30 19:09:01 +0000 URL: https://git.openjdk.java.net/loom/commit/31775a60f0daaf6007e13953ecf080eebfec9a72 Problem list allthr001 failure. ! test/hotspot/jtreg/ProblemList-svc-vthread.txt From duke at openjdk.java.net Wed Mar 30 20:23:03 2022 From: duke at openjdk.java.net (duke) Date: Wed, 30 Mar 2022 20:23:03 GMT Subject: git: openjdk/loom: fibers: minor cleanup in jvmtiThreadState.cpp Message-ID: Changeset: c8cce92a Author: Serguei Spitsyn Date: 2022-03-30 20:22:25 +0000 URL: https://git.openjdk.java.net/loom/commit/c8cce92a8897acbb04d4f894aac973a2055b3d50 minor cleanup in jvmtiThreadState.cpp ! src/hotspot/share/prims/jvmtiThreadState.cpp From duke at openjdk.java.net Wed Mar 30 21:58:24 2022 From: duke at openjdk.java.net (duke) Date: Wed, 30 Mar 2022 21:58:24 GMT Subject: git: openjdk/loom: fibers: JVMTI cleanup: replace mounted_vthread with jvmti_vthread Message-ID: <218715b1-080e-4e87-8b5e-4a842dc88155@openjdk.java.net> Changeset: 2e133ac3 Author: Serguei Spitsyn Date: 2022-03-30 21:56:32 +0000 URL: https://git.openjdk.java.net/loom/commit/2e133ac3ebb73aa229ef51930a269f738d7bf0c3 JVMTI cleanup: replace mounted_vthread with jvmti_vthread ! src/hotspot/share/prims/jvmtiEnv.cpp ! src/hotspot/share/prims/jvmtiEnvBase.cpp ! src/hotspot/share/prims/jvmtiEnvBase.hpp ! src/hotspot/share/prims/jvmtiEventController.cpp ! src/hotspot/share/prims/jvmtiExport.cpp ! src/hotspot/share/prims/jvmtiExtensions.cpp ! src/hotspot/share/prims/jvmtiThreadState.cpp ! src/hotspot/share/prims/jvmtiThreadState.inline.hpp ! src/hotspot/share/prims/jvmtiTrace.cpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/vmStructs.cpp