Request for review: 7131367 [macosx] reg test test/java/awt/Window/TranslucentJAppletTest fails

Sergey Bylokhov sergey.bylokhov at oracle.com
Wed Feb 1 06:30:34 PST 2012


01.02.2012 18:25, Artem Ananiev wrote:
>
> On 2/1/2012 5:02 PM, Sergey Bylokhov wrote:
>> Hi Everyone,
>> Peers shouldn't accumulate an alpha after repainting, so clearRect was
>> added. And now we call setVisible for window after full initialization.
>>
>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7131367
>> Webrev can be found at: 
>> http://cr.openjdk.java.net/~serb/7131367/webrev.00/
>
> Is replaceSurfaceData(1, null) removal from LWWindowPeer.initialize() 
> intentional? As far as I understand, it would lead to 
> getOn/OffScreenGraphics() to return null, until the window is visible 
> or its opacity/insets/etc. values are changed. Is drawing into an 
> invisible window supported now and will it be supported after your fix?
replaceSurfaceData will be called anyway from 
super.initialize()->setVisible()
>
> Thanks,
>
> Artem
>


-- 
Best regards, Sergey.



More information about the macosx-port-dev mailing list