Review request for 7141296: [macosx] Mouse Wheel Turn closes combobox popup

Mike Swingler swingler at apple.com
Fri Feb 10 17:49:10 PST 2012


On Feb 10, 2012, at 11:37 AM, Alexander Potochkin wrote:

> Hello
> 
> Please review the following fix:
> http://cr.openjdk.java.net/~alexp/7141296/webrev.00/
> 
> the bug's description is here:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7141296
> 
> When JScrollPane can't scroll it doesn't consume the mouseWheel event
> and the Swing popup gets closed,  to please AquaLaF I consume the event even when the scrollBar is invisible.
> 
> Another serious problem is fixed -
> when the scrollBar is visible it was impossible to scroll it with the mouseWheel with the single turn of the wheel.
> It got scrolled only if you rotated the wheel fast enough.
> 
> With this fix I set thewheelRotation property
> 
> to 1 if 0 < preciseWheelRotation < 1
> and to -1 if -1 < preciseWheelRotation < 0
> 
> as expected by the Swing components

Looks reasonable.

Regards,
Mike Swingler
Apple Inc.


More information about the macosx-port-dev mailing list