Request for review: 7124363: [macosx] ClassCastException: CFileDialog cannot be cast to LWWindowPeer

Sergey Bylokhov sergey.bylokhov at oracle.com
Tue Feb 14 09:03:11 PST 2012


14.02.2012 21:44, Alexander Zuev пишет:
> On 2/14/12 19:37, Sergey Bylokhov wrote:
>> 14.02.2012 21:05, Alexander Zuev wrote:
>>> Hello,
>>>
>>> please review my fix for bug
>>> 7124363: [macosx] ClassCastException: CFileDialog cannot be cast to 
>>> LWWindowPeer
>>>
>>> Bug description: http://bugs.sun.com/view_bug.do?bug_id=7124363
>>>
>>> Webrev for proposed change:
>>> http://cr.openjdk.java.net/~kizune/7124363/webrev.00/
>> Why we cannot change blocker type to WindowPeer or moreover 
>> ComponentPeer?
> Because mechanics like
> -- 
> LWWindowPeer blocker = this.blocker;
> if (blocker == null) {
> return null;
> }
> while (blocker.blocker != null) {
> blocker = blocker.blocker;
> }
> return blocker;
Well, ok. We have really strange class hierarchy here. But it is another 
issue.


> -- 
> Will stop working.
>
> With best regards,
> Alexander Zuev


-- 
Best regards, Sergey.



More information about the macosx-port-dev mailing list