Request for review: 7144063: [macosx] Swing JMenu mnemonic doesn't work; hint misleading; cross symbol typed

Alexander Zuev alexander.zuev at oracle.com
Thu Feb 16 03:53:33 PST 2012


Mike,

On 2/15/12 22:38, Mike Swingler wrote:
> On Feb 15, 2012, at 5:27 AM, Alexander Zuev wrote:
>
>> Scott,
>>
>> On 2/14/12 21:08, Scott Kovatch wrote:
>>> Okay, that's good to know. :-)
>>>
>>> Looking at the code again, I think this was for the case when you started a composition like option-e then 'e', but cancelled it by hitting backspace after typing the accent.
>>   Tried that too - after my fix it works exactly like the native application does (like hitting backspace after Opt-e removes only accent symbol and letting us continue composition as if we were not typed it). The only difference is that native applications highlight the diacritical symbols if they will be a part of the composed glyph and Java doesn't. Functionally i have not found any difference.
>>
>> With best regards,
>> Alexa
> The fix looks fine to me, as long as all the complex text input methods still work as expected. Have you tried double-clicking on Chinese characters from the character palette (accessible from the input method menu after enabling it from the "Language&  Text" pref pane)?
Yep - tried it too. Actually i tried even most difficult to correctly 
implement input methods with dynamically changing representation like 
Hangul or Tibetan. All i tried works exactly as it does in native 
TextEdit application, even trackpad handwriting works as expected.
> As Scott says, the original bug he was fixing was a problem inputting Cherokee - Nation back in the 1.4.2 timeframe. It's possible that we were working around a bug in AppKit that has since been addressed.
>
> Cheers,
> Mike Swingler
> Apple Inc.
>
>>> Sorry for being so vague, but I'm just trying to recall the corner cases this code had to handle. I would try it myself but I'm bogged down with other Web Start/applet changes.
>>>
>>> -- Scott K.
>>>
>>> On Feb 14, 2012, at 10:55 AM, Alexander Zuev wrote:
>>>
>>>> ᎣᏏᏲ Scott,
>>>>
>>>> i found quite opposite - i were unable to enter all the Cherokee symbols without my fix - some of them just not typed - and i'm able to type in all the Cherokee - Nation/Cherokee - QWERTY glyphs exactly as i do in the native application (TextEdit for example).
>>>>
>>>> With best regards,
>>>> Alex
>>>>
>>>> On 2/14/12 19:24, Scott Kovatch wrote:
>>>>> Alexander,
>>>>>
>>>>> I recall writing that code originally a very long time ago, so my memory is hazy.  Maybe Mike can do a 'cvs blame' on the old Apple codebase for the original reason I added that check.
>>>>>
>>>>> I seem to recall it was for handling some of the less common input methods like Bulgarian or Cherokee - Nation that can trigger multiple characters on a single keystroke.
>>>>>
>>>>> This is not to say your change is wrong, but it would be good to check the test case for why I added that check in the first place.
>>>>>
>>>>> -- Scott
>>>>>
>>>>> On Feb 14, 2012, at 7:50 AM, Alexander Zuev wrote:
>>>>>
>>>>>> Hello,
>>>>>>
>>>>>>   please review my fix for bug 7144063: [macosx] Swing JMenu mnemonic doesn't work; hint misleading; cross symbol typed
>>>>>>
>>>>>>   Bug description: http://bugs.sun.com/view_bug.do?bug_id=7144063
>>>>>>
>>>>>>   Webrev for proposed change: http://cr.openjdk.java.net/~kizune/7144063/webrev.00/
>>>>>>
>>>>>>   The idea of the fix is to call the java handler for creation of InputMethod events
>>>>>> for all the complex symbols instead of just for symbols with length of 3 bytes or more.
>>>>>>
>>>>>> With best regards,
>>>>>> Alexander Zuev



More information about the macosx-port-dev mailing list