Review request for 7128699: Make jdk and jre installation directories consistent on Mac OS X

Mike Swingler swingler at apple.com
Thu Feb 23 13:54:03 PST 2012


On Feb 21, 2012, at 10:18 PM, Scott Kovatch wrote:

> Hello,
> 
> Please review the following fix:
> 
> http://cr.openjdk.java.net/~skovatch/7128699/webrev.00/
> 
> The bug description is here:
> 
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7128699
> 
> The name of the created JDK and JRE bundle isn't including the JDK_UPDATE_VERSION. Use JDK_VERSION instead of THIS_JDK_VERSION so it gets picked up. Also, prefix the bundle with 'jdk' or 'ire' as needed to match other platforms. We maintain the bundle extension so it is recognized as a bundle on Mac OS X, but if filename extensions are turned off in the finder you can't tell a JDK from a JRE.

If this hasn't been reviewed already by someone at Oracle, this looks like a good change, and will facilitate the ability to install these bundles side-by-side.

Is THIS_JDK_VERSION used anywhere else? Could it be removed at the definition point?

Regards,
Mike Swingler
Apple Inc.



More information about the macosx-port-dev mailing list