RFR: 7113349 JDK8 port to macosx

[Kumar Srinivasan]

Hi David,

>
> One other general nit (because it made it much harder to see real 
> changes!): there is no need to add comments to every "else" and 
> "endif" in the build files. When they are long sections sure, but not 
> for one or two lines. That makes it harder to read things in my 
> opinion. (Ref: jdk/make/common/Program.gmk in particular) Plus this 
> was done inconsistently anyway (ref: jdk/make/common/Release.gmk)
>
> A few specific comments:
>
> make/common/Release.gmk:
>
> This:
>
>  975 # The launcher source files we need for src.zip
>  976 FILES_launcher = $(wildcard $(SHARE_SRC)/bin/*) \
>  977                  $(wildcard $(PLATFORM_SRC)/bin/java_md*)
>
> is picking up a couple of extra files compared to the original file 
> list: defines.h, emessages.h, main.c
This is correct, it should be picking up these extra files, earlier it 
wasn't, because the src.zip was
never adjusted to account for the new files introduced during a launcher 
refactor effort.

Kumar

>
> ---
>
> make/common/Rules.gmk
>
> Can we fix the ToDos in here? Either do them or delete them.
>
> ---
>
> /jdk/make/com/sun/nio/Makefile
>
>  35 ifneq ($(PLATFORM), macosx)
>   36 include $(BUILDDIR)/common/Subdirs.gmk
>   37 SUBDIRS = sctp
>   38 endif
>   39
>   40
>   41 all build clean clobber::
>   42         $(SUBDIRS-loop)
>
> Don't we need the include of Subdirs.gmk to get the definition of 
> SUBDIRS-loop?
>
> Is sctp an optional JDK component? Or is it provided some other way on 
> OSX?
>
>
> ---
>
> java/lang/Thread.java:
>
>       private native void resume0();
>       private native void interrupt0();
> +     private native void setNativeName(String name);
>
> I don't see the change in setName to call setNativeName ???
>
> ---
>
> David
> ----------------
>
>
> On 28/02/2012 7:07 AM, Michael McMahon wrote:
>> This is an updated webrev for the Mac OS X changes after comments so 
>> far:
>>
>> http://cr.openjdk.java.net/~michaelm/7113349/jdk8/webrev.3/
>>
>> The main changes from the original webrev are:
>>
>> - jprt configuration for macosx
>> - problem list updates
>> - removal of dud source files brought in from 7u-dev by mistake
>> - langtools test updates
>> - synchronized with TL now as opposed to master
>> - removal of fix for 7087956, which wasn't part of mac os work
>>
>> Comments welcome.
>>
>> Thanks,
>> Michael.
>>
>> On 22/02/12 21:50, Michael McMahon wrote:
>>> This is the webrev for the Mac OS changes for JDK8. It is pretty much
>>> a straight merge of the current jdk7u-dev changes. It builds and
>>> passes most
>>> JCK and regression tests with only a small number of failures.
>>>
>>> http://cr.openjdk.java.net/~michaelm/7113349/jdk8/webrev.1/
>>>
>>> There are three separate webrevs at the link above for the three 
>>> separate
>>> repositories affected (the top-level, corba and jdk). Obviously most
>>> of the changes
>>> are in the jdk webrev. Comments welcome!
>>>
>>> Thanks,
>>> Michael.
>>