[7u6] Please review my fix for 7171163: [macosx] Shortcomings in the design of the secondary native event loop made JavaFX DnD deadlock

steve.x.northover at oracle.com steve.x.northover at oracle.com
Wed May 23 11:26:27 PDT 2012


ToolkitThreadBlockedHandler seems to be shared code and it follows the 
enter / exit naming that is wrong.  It seems that a lot of changes will 
be needed in shared code so I'm not sure the renaming is worth it.

You could add update the comments to indicate how this is used and save 
the renaming for another day.

Steve

On 23/05/2012 2:11 PM, Alexander Zuev wrote:
> Steve,
>
>   you are absolutely right - this native method is used only by our 
> implementation of the DnD so
> i may just rename it and the only reason i have not done it is to 
> minimize the scope of the change.
> So if you think renaming the method is required i will gladly do it.
>
> With best regards,
> Alex
>
> On 5/23/12 21:21, steve.x.northover at oracle.com wrote:
>> The implementation matches how these methods are used by drag and 
>> drop but the naming makes no sense.  Who else calls these methods?  
>> I'm assuming nobody (or that they are all called with the same 
>> implementation in mind).
>>
>> startNativeNestedEventLoop is really "read and dispatch an event 
>> without blocking".
>>
>> Steve
>>
>> On 23/05/2012 12:51 PM, Alexander Zuev wrote:
>>> Hello,
>>>
>>>   please review my fix for the
>>> 7171163: [macosx] Shortcomings in the design of the secondary native 
>>> event loop made JavaFX DnD deadlock
>>>
>>>   Bug can be found at 
>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171163
>>>
>>>   Webrev can be found at: 
>>> http://cr.openjdk.java.net/~kizune/7171163/webrev.00/
>>>
>>> With best regards,
>>> Alexander Zuev
>


More information about the macosx-port-dev mailing list