[7u6] Review request for 7159381: [macosx] Dock Icon defaults to Generic Java Application Category

Scott Kovatch scott.kovatch at oracle.com
Thu May 24 06:39:19 PDT 2012


Looks good to me. Ripping out code for a fix is a good thing.

-- Scott

On May 24, 2012, at 5:23 PM, Leonid Romanov wrote:

> Hi,
> Please review a fix for 7159381: [macosx] Dock Icon defaults to Generic Java Application Category. The problem here is that we ignore the fact that for the bundled app its icon might be specified via Info.plist file. In this case OS X sets the icon for us, so we don't have to do anything. 
> 
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7159381
> Webrev:  http://cr.openjdk.java.net/~leonidr/7159381/webrev.00/
> 
> Thanks,
> Leonid.
> 



More information about the macosx-port-dev mailing list