[7u6] request for review: 7146550: [macosx] DnD test failure in createCompatibleWritableRaster()

Artem Ananiev artem.ananiev at oracle.com
Fri May 25 06:18:20 PDT 2012


Hi, Andrew,

I didn't participate in the fix review for JDK8, so could you explain 
the purpose of that createFromImageImmediately() method in CImage, 
please? Why having createFromImage(), which always waits until the image 
is ready, and additional checks for w > 0 and h > 0 is not enough?

Thanks,

Artem

On 5/25/2012 2:23 PM, Andrew Brygin wrote:
> Hello,
>
> could you please review a backport of the fix for 7146550 to 7u6?
>
> The fix is almost the same as for jdk8, it just adds helper method
> imageToArray to CImage class. This method was introduced in jdk8 as
> a part of the fix for 7148275 ([macosx] setIconImages() not working
> correctly (distorted icon when minimized)). Note that 7148275 was
> fixed in 7u4 and 7u6 in a different manner, there seems to be no
> need for complete backport of the jdk8 revision of the fix for 7148275.
>
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7146550
> Jdk8 changeset: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a2d12ca36eb3
> Webrev: http://cr.openjdk.java.net/~bae/7146550/7u6/webrev.00/
>
> Thanks,
> Andrew


More information about the macosx-port-dev mailing list