From Andreas.Sterbenz at Sun.COM Mon Jul 2 19:18:40 2007 From: Andreas.Sterbenz at Sun.COM (Andreas Sterbenz) Date: Mon, 02 Jul 2007 19:18:40 -0700 Subject: [modules-dev] URLs in emails Message-ID: <4689B200.8030000@sun.com> Hi, quick explanation to avoid confusion: for the time being, you may see URLs in mails from @sun.com folks on this list that only work within Sun's internal network. We expect that to change before long as the openjdk.java.net infrastructure is built out enabling us to make all relevant content publicly available. Please bear with us in the meantime. We think that making incomplete content available is better than not making the content available at all. Again, I expect that much of this to be resolved fairly soon. Let me know if you have any comments. Andreas. From andreas.sterbenz at sun.com Tue Jul 3 16:06:33 2007 From: andreas.sterbenz at sun.com (andreas.sterbenz at sun.com) Date: Tue, 3 Jul 2007 16:06:33 -0700 (PDT) Subject: [modules-dev] Open Bugs/RFEs in java/module Message-ID: <200707032306.l63N6Xfk018809@shimmer.sfbay.sun.com> An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/modules-dev/attachments/20070703/4c592f60/attachment.html From stanleyh at jmodule.SFBay.Sun.COM Tue Jul 3 22:00:09 2007 From: stanleyh at jmodule.SFBay.Sun.COM (Stanley Ho) Date: Tue, 3 Jul 2007 22:00:09 -0700 (PDT) Subject: [modules-dev] Code Manager notification (putback-to) Message-ID: <200707040500.WAA19894@jmodule.SFBay.Sun.COM> A non-text attachment was scrubbed... Name: not available Type: text Size: 3792 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/modules-dev/attachments/20070703/7e8926c6/attachment.ksh From jprtadm at jprt-web.SFBay.Sun.COM Tue Jul 3 22:37:16 2007 From: jprtadm at jprt-web.SFBay.Sun.COM (JPRT Administrator) Date: Tue, 3 Jul 2007 22:37:16 -0700 (PDT) Subject: [modules-dev] JPRT: job notification - success with job 2007-07-04-045615.daemon.ws Message-ID: <200707040537.l645bG3M006576@jprt-web.SFBay.Sun.COM> JPRT: job notification - success with job 2007-07-04-045615.daemon.ws JPRT Job ID: 2007-07-04-045615.daemon.ws JPRT System Used: sfbay JPRT Version Used: 08 June 2007 - Name Your Poison Day Job URL: http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-04-045615.daemon.ws User: daemon Email: modules-dev at openjdk.java.net Release: jdk1.7.0 Job Source: Source Tree: /net/shimmer.sfbay/export/home/jsr277/ws/{make,src} File List: {.} Command Line: jprt submit -stree ../ws -ot '.*linux_i586.*product.*' -noquickabort -email modules-dev at openjdk.java.net -rtests '*-*-c2-java/module' -rtests '*-*-c2-sun/module' Job submitted at: Wed-04:56:16-GMT Total time in queue: 41m 00s Job started at: Wed-05:19:32-GMT Job finished at: Wed-05:37:16-GMT Job run time: 17m 44s Job state: success Job flags: Bundles: USE: jprt install 2007-07-04-045615.daemon.ws HINT: Use 'jprt rerun -comment -retest 2007-07-04-045615.daemon.ws' to rerun the tests for this job (you can also add tests with 'jprt rerun'). NOTE: Zip files containing exe or dll files on windows have had problems with execute permissions. You may need to 'chmod a+x' the windows exe and dll files. User Comments: null Build (Release:jdk1.7.0 Boot: Import:): linux_i586_2.4.9-product success(12m 02s elapsed) Tests: linux_i586-product-c2-jvm98 success(01m 57s elapsed) linux_i586-product-c2-java/module success(02m 30s elapsed) linux_i586-product-c2-sun/module success( 58s elapsed) For announcements on downtime and availability join the alias 'jprt-announce at sun.com'. You can see the latest announcements at http://archives.central/tm/browse?jprt-announce. For suspected system problems, send mail to 'jprt-admin at sun.com'. The jprt how to document is available at http://javaweb.sfbay/jdk/jprt/dist/javadoc/jprt/doc-files/how-to.html. From forax at univ-mlv.fr Wed Jul 4 01:19:50 2007 From: forax at univ-mlv.fr (=?ISO-8859-1?Q?R=E9mi_Forax?=) Date: Wed, 04 Jul 2007 10:19:50 +0200 Subject: [modules-dev] Open Bugs/RFEs in java/module In-Reply-To: <200707032306.l63N6Xfk018809@shimmer.sfbay.sun.com> References: <200707032306.l63N6Xfk018809@shimmer.sfbay.sun.com> Message-ID: <468B5826.7030409@univ-mlv.fr> andreas.sterbenz at sun.com a ?crit : > > > Open Bugs/RFEs in java/module > > 1 3 fip david.bris 6559087 (repo) URLRepository.list() > 2 3 fip david.bris 6559092 (repo) Repository.getSystemRepository() must never be null > 3 3 fip david.bris 6559117 (repo) initial version of repository management tool > 4 3 fip david.bris 6574852 (repo) "Cannot access JAM file" error if no trailing / in URL > 5 3 fip david.bris 6574851 (repo) NPE in URLRepository for non-existant repository_metadata.xml file > 6 3 dis andreas.st 6558938 (cl) support for embedded JAR files > 7 3 dis andreas.st 6559122 (repo) update bootstrap modules with superpackage support > 8 3 dis andreas.st 6559121 update implementation and tests for superpackage support > 9 3 dis andreas.st 6559097 (cl) set the system classloader to the module classloader > 10 3 dis andreas.st 6558941 (cl) support for embedded native libraries > 11 3 dis andreas.st 6559124 (modsys) implement releaseModule() and disableModuleDefinition() > 12 3 dis andreas.st 6573885 (modinit) Incorrect recursion check in module initialization > 13 3 dis david.bris 6559067 (repo) implement LocalRepository.shutdown() and reload() > 14 3 dis david.bris 6559072 (repo) construct LocalRepository from a File > 15 3 dis david.bris 6560271 (repo) Support for embedded JAR files > 16 3 dis david.bris 6559086 (repo) URLRepository.shutdown() and reload() > 17 3 dis david.bris 6576774 (repo) URLRepository.list() does not provide information on modules not matching platform, arch > 18 3 dis david.bris 6571510 (repo) Throw error if a JAM file contains a JAM file > 19 3 dis david.bris 6560273 (repo) Support for embedded native libraries > 20 3 dis david.bris 6560934 (repo) Compare MODULE.METADATA downloaded initially with that in module archive > 21 3 dis david.bris 6560281 (repo) automatically construct default repository instances per configuration file > 22 3 dis stanley.ho 6559098 default import override policy implementation > 23 4 fip david.bris R6571501 (repo) Combine HttpUrlRepositoryTest and URLRepositoryTest > 24 4 acc david.bris 6563535 (repo) URLRepository.install() should allow file: protocol to install a module > 25 4 acc david.bris 6574242 (repo) LocalRepository should remove files during uninstall() > 26 4 dis andreas.st 6558952 (cl) implement getPackage() > 27 4 dis andreas.st 6564879 (modsys) implement deep validation > 28 4 dis andreas.st 6558953 (cl) assign correct ProtectionDomain > 29 4 dis andreas.st 6558956 extension repository that exposes modules in the extension classloader > 30 4 dis david.bris 6566022 (repo) support .jam.pack.gz files in LocalRepository > 31 4 dis david.bris 6566724 Add constants for oft-used strings such as MODULE.METADATA > 32 5 dis - 6559161 handle invalid VersionConstraint at runtime > i can fix my first module bug :), 6559086 seems to be a dup of 6559067. R?mi From jprtadm at jprt-web.SFBay.Sun.COM Wed Jul 4 05:46:19 2007 From: jprtadm at jprt-web.SFBay.Sun.COM (JPRT Administrator) Date: Wed, 4 Jul 2007 05:46:19 -0700 (PDT) Subject: [modules-dev] JPRT: job notification - success with job 2007-07-04-111304.as130790.ws Message-ID: <200707041246.l64CkJqs006797@jprt-web.SFBay.Sun.COM> JPRT: job notification - success with job 2007-07-04-111304.as130790.ws JPRT Job ID: 2007-07-04-111304.as130790.ws JPRT System Used: sfbay JPRT Version Used: 08 June 2007 - Name Your Poison Day Job URL: http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-04-111304.as130790.ws User: as130790 Email: modules-dev at openjdk.java.net Release: jdk1.7.0 Job Source: Source Tree: /net/shimmer.sfbay/export/home/jsr277/ws/{make,src} File List: {.} Command Line: jprt submit -stree ../ws -ot '.*product.*' -noquickabort -email modules-dev at openjdk.java.net -rtests '*-*-c2-java/module' -rtests '*-*-c2-sun/module' Job submitted at: Wed-11:13:05-GMT Total time in queue: 1h 33m 13s Job started at: Wed-11:33:29-GMT Job finished at: Wed-12:46:18-GMT Job run time: 1h 12m 49s Job state: success Job flags: Bundles: USE: jprt install 2007-07-04-111304.as130790.ws HINT: Use 'jprt rerun -comment -retest 2007-07-04-111304.as130790.ws' to rerun the tests for this job (you can also add tests with 'jprt rerun'). NOTE: Zip files containing exe or dll files on windows have had problems with execute permissions. You may need to 'chmod a+x' the windows exe and dll files. User Comments: null Build (Release:jdk1.7.0 Boot: Import:): solaris_sparc_5.8-product success(24m 38s elapsed) solaris_sparcv9_5.8-product success(25m 50s elapsed) solaris_i586_5.8-product success(48m 00s elapsed) solaris_x64_5.10-product success(10m 08s elapsed) linux_i586_2.4.9-product success(13m 13s elapsed) linux_x64_2.4.19-product success(13m 45s elapsed) windows_i586_5-product success(35m 45s elapsed) windows_x64_5.2-product success(44m 33s elapsed) Tests: solaris_sparc-product-c2-jvm98 success(02m 30s elapsed) NOTE: Used solaris_sparc_5.10 for above target. solaris_sparcv9-product-c2-jvm98 success(02m 49s elapsed) NOTE: Used solaris_sparc_5.10 for above target. solaris_i586-product-c2-jvm98 success(03m 17s elapsed) linux_i586-product-c2-jvm98 success(01m 44s elapsed) windows_i586-product-c2-jvm98 success(02m 48s elapsed) solaris_x64-product-c2-jvm98 success(01m 55s elapsed) linux_x64-product-c2-jvm98 success(01m 41s elapsed) windows_x64-product-c2-jvm98 success(01m 57s elapsed) solaris_sparc-product-c2-java/module success(04m 00s elapsed) solaris_sparcv9-product-c2-java/module success(04m 12s elapsed) NOTE: Used solaris_sparc_5.10 for above target. solaris_i586-product-c2-java/module success(10m 08s elapsed) linux_i586-product-c2-java/module success(02m 13s elapsed) windows_i586-product-c2-java/module success(05m 52s elapsed) solaris_x64-product-c2-java/module success(01m 46s elapsed) linux_x64-product-c2-java/module success(01m 36s elapsed) windows_x64-product-c2-java/module success(04m 34s elapsed) solaris_sparc-product-c2-sun/module success( 26s elapsed) NOTE: Used solaris_sparc_5.10 for above target. solaris_sparcv9-product-c2-sun/module success( 28s elapsed) NOTE: Used solaris_sparc_5.10 for above target. solaris_i586-product-c2-sun/module success(07m 39s elapsed) linux_i586-product-c2-sun/module success( 46s elapsed) windows_i586-product-c2-sun/module success(03m 00s elapsed) solaris_x64-product-c2-sun/module success( 16s elapsed) linux_x64-product-c2-sun/module success( 16s elapsed) windows_x64-product-c2-sun/module success(02m 35s elapsed) For announcements on downtime and availability join the alias 'jprt-announce at sun.com'. You can see the latest announcements at http://archives.central/tm/browse?jprt-announce. For suspected system problems, send mail to 'jprt-admin at sun.com'. The jprt how to document is available at http://javaweb.sfbay/jdk/jprt/dist/javadoc/jprt/doc-files/how-to.html. From mcconnell at dpml.net Wed Jul 4 06:06:15 2007 From: mcconnell at dpml.net (Stephen McConnell) Date: Wed, 4 Jul 2007 22:36:15 +0930 Subject: [modules-dev] Module Javadocs ... Message-ID: <000901c7be3c$1b149f40$0301a8c0@julia> As a part of reviewing the modules sources I put together some javadocs to help me get a better picture of things. I've posted these to the following URL. http://api.dpml.net/openjdk/module/20070627/ The javadocs are based on a compilation of the source files referenced on the Modules/Getting Started page with links back to SE6 javadocs for the generic content. Cheers, Steve. -------------------------- Stephen J. McConnell mailto:mcconnell at dpml.net http://www.dpml.net From andreas.sterbenz at sun.com Wed Jul 4 06:00:40 2007 From: andreas.sterbenz at sun.com (andreas.sterbenz at sun.com) Date: Wed, 4 Jul 2007 06:00:40 -0700 (PDT) Subject: [modules-dev] Open Bugs/RFEs in java/module Message-ID: <200707041300.l64D0eCQ010434@shimmer.sfbay.sun.com> An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/modules-dev/attachments/20070704/f8e9334e/attachment.html From David.Bristor at Sun.COM Wed Jul 4 09:32:16 2007 From: David.Bristor at Sun.COM (Dave Bristor) Date: Wed, 04 Jul 2007 09:32:16 -0700 Subject: [modules-dev] Open Bugs/RFEs in java/module In-Reply-To: <468B5826.7030409@univ-mlv.fr> References: <200707032306.l63N6Xfk018809@shimmer.sfbay.sun.com> <468B5826.7030409@univ-mlv.fr> Message-ID: <468BCB90.1070600@sun.com> They're similar, but not the same: LocalRepository v. URLRepository. At least one difference is in the disposition of temporary files related to modules that have been installed into the repository. URLRepository downloads MODULE.METADATA files which need to be cleaned up at shutdown(). In general we've been keeping separate bugs for the separate repository implementations. Thanks, Dave R?mi Forax wrote: > andreas.sterbenz at sun.com a ?crit : > >> >> Open Bugs/RFEs in java/module >> >>1 3 fip david.bris 6559087 (repo) URLRepository.list() >>2 3 fip david.bris 6559092 (repo) Repository.getSystemRepository() must never be null >>3 3 fip david.bris 6559117 (repo) initial version of repository management tool >>4 3 fip david.bris 6574852 (repo) "Cannot access JAM file" error if no trailing / in URL >>5 3 fip david.bris 6574851 (repo) NPE in URLRepository for non-existant repository_metadata.xml file >>6 3 dis andreas.st 6558938 (cl) support for embedded JAR files >>7 3 dis andreas.st 6559122 (repo) update bootstrap modules with superpackage support >>8 3 dis andreas.st 6559121 update implementation and tests for superpackage support >>9 3 dis andreas.st 6559097 (cl) set the system classloader to the module classloader >>10 3 dis andreas.st 6558941 (cl) support for embedded native libraries >>11 3 dis andreas.st 6559124 (modsys) implement releaseModule() and disableModuleDefinition() >>12 3 dis andreas.st 6573885 (modinit) Incorrect recursion check in module initialization >>13 3 dis david.bris 6559067 (repo) implement LocalRepository.shutdown() and reload() >>14 3 dis david.bris 6559072 (repo) construct LocalRepository from a File >>15 3 dis david.bris 6560271 (repo) Support for embedded JAR files >>16 3 dis david.bris 6559086 (repo) URLRepository.shutdown() and reload() >>17 3 dis david.bris 6576774 (repo) URLRepository.list() does not provide information on modules not matching platform, arch >>18 3 dis david.bris 6571510 (repo) Throw error if a JAM file contains a JAM file >>19 3 dis david.bris 6560273 (repo) Support for embedded native libraries >>20 3 dis david.bris 6560934 (repo) Compare MODULE.METADATA downloaded initially with that in module archive >>21 3 dis david.bris 6560281 (repo) automatically construct default repository instances per configuration file >>22 3 dis stanley.ho 6559098 default import override policy implementation >>23 4 fip david.bris R6571501 (repo) Combine HttpUrlRepositoryTest and URLRepositoryTest >>24 4 acc david.bris 6563535 (repo) URLRepository.install() should allow file: protocol to install a module >>25 4 acc david.bris 6574242 (repo) LocalRepository should remove files during uninstall() >>26 4 dis andreas.st 6558952 (cl) implement getPackage() >>27 4 dis andreas.st 6564879 (modsys) implement deep validation >>28 4 dis andreas.st 6558953 (cl) assign correct ProtectionDomain >>29 4 dis andreas.st 6558956 extension repository that exposes modules in the extension classloader >>30 4 dis david.bris 6566022 (repo) support .jam.pack.gz files in LocalRepository >>31 4 dis david.bris 6566724 Add constants for oft-used strings such as MODULE.METADATA >>32 5 dis - 6559161 handle invalid VersionConstraint at runtime >> > > i can fix my first module bug :), > 6559086 seems to be a dup of 6559067. > > R?mi > _______________________________________________ > modules-dev mailing list > modules-dev at openjdk.java.net > http://mail.openjdk.java.net/mailman/listinfo/modules-dev From David.Bristor at Sun.COM Wed Jul 4 09:45:33 2007 From: David.Bristor at Sun.COM (Dave Bristor) Date: Wed, 04 Jul 2007 09:45:33 -0700 Subject: [modules-dev] Module Javadocs ... In-Reply-To: <000901c7be3c$1b149f40$0301a8c0@julia> References: <000901c7be3c$1b149f40$0301a8c0@julia> Message-ID: <468BCEAD.70003@sun.com> Thanks Steve! FWIW, the modules NetBeans project can generate javadoc. Really it's just an ant target in make/netbeans/modules: "ant javadoc". I notice a couple discrepancies between the 2 sets of javadoc. The modules project doesn't have any changes in javax.lang.model *directly*, only in the element, type, and util subpackages. No changes in sun.reflect nor sun.tools.util that I can find. And in java.util, there are new classes Service.java and ServiceProvider.java, though there has been discussion on the EG regarding services and I'm not sure if these'll be retained. Thanks, Dave Stephen McConnell wrote: > As a part of reviewing the modules sources I put together some javadocs to > help me get a better picture of things. > > I've posted these to the following URL. > > http://api.dpml.net/openjdk/module/20070627/ > > The javadocs are based on a compilation of the source files referenced on > the Modules/Getting Started page with links back to SE6 javadocs for the > generic content. > > Cheers, Steve. > > -------------------------- > Stephen J. McConnell > mailto:mcconnell at dpml.net > http://www.dpml.net > > _______________________________________________ > modules-dev mailing list > modules-dev at openjdk.java.net > http://mail.openjdk.java.net/mailman/listinfo/modules-dev From David.Bristor at Sun.COM Wed Jul 4 12:57:21 2007 From: David.Bristor at Sun.COM (Dave Bristor) Date: Wed, 04 Jul 2007 12:57:21 -0700 Subject: [modules-dev] Thoughts on initial repository tool Message-ID: <468BFBA1.2080400@sun.com> Hi folks, Here are some notes, on an initial repository tool "jrepo". Usage: jrepo Common flags: -v: verbose - yields more output -p: parent - follow parent chain (see below) -r repositoryLocation: repository - location is filesystem path or URL to repository to be used Subcommands & associated args: * list [-v] [-p] [-r repositoryLocation] Lists the names & versions of modules in a repository. With -v, also gives platform, architecture, pathname, and last modified time (if available). With -p, includes parent repositories. With -r, uses the given repository; else the system repository. Listed modules are displayed in the same order that Repository.find() would find them (i.e. bootstrap-repository-first). * find [-v] [-p] [-r repositoryLocation] moduleName [moduleVersion] query (synonym for find) Results are similar to "list", but include repository name and module info as in "list". Options similar to "list". Exits non-zero if no match found in any repository. Repository search order is same as Repository.find() *but* results do not take into account current platform-arch. Open issue: probably should allow versionConstraint instead of a simple version, as well as other query args. * install [-v] [-f] JAMFile repositoryLocation JAMFile Installs the named JAMfile into the named repository. -f forces installation even if another module with same characteristics (name, version, platform, architecture) is already installed. With -v, issues warnings if any dependent modules are not accessible (this might not be in jrepo v0.1). * uninstall [-v] repositoryLocation moduleName [moduleVersion] \ [modulePlatform-moduleArch] Uninstalls the identified module from the named repository. Fails if information given identifies more than one module. The remaining subcommands won't (necessarily) appear in the initial tool; they need more thought: dependencies [-v] [-r repositoryLocation] moduleName [moduleVersion] \ [modulePlatform-moduleArch] Lists all the modules on which the identified module depends. Fails if information given identifies more than one module. contents [-v] [-r repositoryLocation] moduleName [moduleVersion] \ [modulePlatform-moduleArch] Lists the contents of the identified module (e.g. similar to "ls -lR" or "jar tf"). get [-v] [-r repositoryLocation] moduleName [moduleVersion] \ [modulePlatform-moduleArch] Creates a JAM file from the identified module. check [-v] [-r repositoryLocation] moduleName [moduleVersion] \ [modulePlatform-moduleArch] Runs shallow (or deep?) validationon the given module. Notes: * If repositoryPath is not given, jrepo will use the currently configured repositories. (Repository configuration is not yet implemented, but when it is...see bug 6560281.) * Users should not have to type the entire subcommand, just enough characters to distinguish it from other subcommands. * Needs more thought: a module can be defined in more than one repository; "list -p" will identify these situations. Should "contents -p" be allowed, and if so, what should be its behavior in this situation? Show the contents of each module, or stop at the first? * Question: are there other module attributes/annotations/characteristics that should be considered in identifying the module? This applies to install, uninstall, dependencies, etc. * install can give warnings if dependencies are not satisfied * repositoryPath does not identify the *type* of the repository: the initial tool will treat it as a file system path or URL and use a Local or URLRepository as appropriate. In the fullness of time, we probably need some way to allow users to specify the kind of repository, e.g. a "-class clazz" or "-type serviceType" argument. Feedback welcome, Dave From Andreas.Sterbenz at Sun.COM Wed Jul 4 13:15:20 2007 From: Andreas.Sterbenz at Sun.COM (Andreas Sterbenz) Date: Wed, 04 Jul 2007 13:15:20 -0700 Subject: [modules-dev] Module Javadocs ... In-Reply-To: <468BCEAD.70003@sun.com> References: <000901c7be3c$1b149f40$0301a8c0@julia> <468BCEAD.70003@sun.com> Message-ID: <468BFFD8.9010000@sun.com> Dave Bristor wrote: > > I notice a couple discrepancies between the 2 sets of javadoc. The modules > project doesn't have any changes in javax.lang.model *directly*, only in the > element, type, and util subpackages. No changes in sun.reflect nor > sun.tools.util that I can find. And in java.util, there are new classes Steve, if you are seeing differences between the Modules source and OpenJDK b14 in packages such as sun.reflect, then that must be because the Modules source is not based exactly on b14. It is based on state of the Sun internal repository at some point between b14 and b15, and some other team must have made changes to sun.reflect unrelated to the Modules project. Of course, these issues will go away once all the sources are in Mercurial repositories on OpenJDK so that updates are visible immediately. In the meantime, attached is a list of all the source files touched by the Modules project so far. Andreas. -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: files_src.txt Url: http://mail.openjdk.java.net/pipermail/modules-dev/attachments/20070704/16a9dea1/attachment.txt From andreas.sterbenz at sun.com Thu Jul 5 06:00:31 2007 From: andreas.sterbenz at sun.com (andreas.sterbenz at sun.com) Date: Thu, 5 Jul 2007 06:00:31 -0700 (PDT) Subject: [modules-dev] Open Bugs/RFEs in java/module Message-ID: <200707051300.l65D0Vri006318@shimmer.sfbay.sun.com> An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/modules-dev/attachments/20070705/461d48d3/attachment.html From as130790 at shimmer.sfbay.sun.com Thu Jul 5 23:36:02 2007 From: as130790 at shimmer.sfbay.sun.com (Andreas Sterbenz) Date: Thu, 5 Jul 2007 23:36:02 -0700 (PDT) Subject: [modules-dev] Code Manager notification (putback-to) Message-ID: <200707060636.l666a2YH004260@shimmer.sfbay.sun.com> Event: putback-to Parent workspace: /net/shimmer.sfbay/export/home/jsr277/ws (shimmer:/net/shimmer.sfbay/export/home/jsr277/ws) Child workspace: /net/shimmer.sfbay/export/home/as130790/277-merge/ws (shimmer:/net/shimmer.sfbay/export/home/as130790/277-merge/ws) User: as130790 Comment: Sync with TL Files: update: make/com/sun/org/apache/regexp/Makefile update: make/com/sun/org/apache/xalan/internal/xsltc/Makefile update: make/common/Release.gmk update: make/common/shared/Defs-windows.gmk update: make/common/shared/Sanity.gmk update: make/javax/sound/Makefile update: make/javax/sound/mapfile-vers update: make/javax/sound/jsoundds/Makefile update: make/mkdemo/Makefile update: src/closed/share/classes/com/sun/media/sound/Platform.java update: src/closed/share/doc/build/README-RE.html update: src/closed/share/doc/build/README-internal.html update: src/closed/share/native/com/sun/media/sound/Platform.c update: src/share/classes/com/sun/beans/ObjectHandler.java update: src/share/classes/com/sun/java/swing/plaf/gtk/GTKEngine.java update: src/share/classes/com/sun/java/swing/plaf/gtk/GTKIconFactory.java update: src/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java update: src/share/classes/com/sun/java/swing/plaf/gtk/GTKPainter.java update: src/share/classes/com/sun/java/swing/plaf/motif/MotifFileChooserUI.java update: src/share/classes/com/sun/java/swing/plaf/motif/MotifLookAndFeel.java update: src/share/classes/com/sun/java/swing/plaf/motif/resources/motif.properties update: src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_de.properties update: src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_es.properties update: src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_fr.properties update: src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_it.properties update: src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_ja.properties update: src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_ko.properties update: src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_sv.properties update: src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_zh_CN.properties update: src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_zh_TW.properties update: src/share/classes/com/sun/java/swing/plaf/windows/WindowsClassicLookAndFeel.java update: src/share/classes/com/sun/java/swing/plaf/windows/WindowsFileChooserUI.java update: src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java update: src/share/classes/com/sun/java/swing/plaf/windows/resources/windows.properties update: src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_de.properties update: src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_es.properties update: src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_fr.properties update: src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_it.properties update: src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_ja.properties update: src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_ko.properties update: src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_sv.properties update: src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_zh_CN.properties update: src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_zh_TW.properties update: src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Copy.java update: src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Number.java update: src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Parser.java update: src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/SyntaxTreeNode.java update: src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/AnyNodeCounter.java update: src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/KeyIndex.java update: src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/MultipleNodeCounter.java update: src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/NodeCounter.java update: src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/SingleNodeCounter.java update: src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerImpl.java update: src/share/classes/com/sun/org/apache/xerces/internal/dom/ElementImpl.java update: src/share/classes/com/sun/org/apache/xml/internal/serializer/ToHTMLStream.java update: src/share/classes/com/sun/rowset/CachedRowSetImpl.java update: src/share/classes/com/sun/rowset/FilteredRowSetImpl.java update: src/share/classes/com/sun/rowset/JdbcRowSetImpl.java update: src/share/classes/com/sun/rowset/JoinRowSetImpl.java update: src/share/classes/com/sun/rowset/RowSetResourceBundle.properties update: src/share/classes/com/sun/rowset/WebRowSetImpl.java update: src/share/classes/com/sun/rowset/internal/CachedRowSetReader.java update: src/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java update: src/share/classes/com/sun/rowset/internal/InsertRow.java update: src/share/classes/com/sun/rowset/internal/SyncResolverImpl.java update: src/share/classes/com/sun/rowset/internal/WebRowSetXmlReader.java update: src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java update: src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java update: src/share/classes/com/sun/rowset/providers/RIOptimisticProvider.java update: src/share/classes/com/sun/rowset/providers/RIXMLProvider.java update: src/share/classes/com/sun/security/auth/login/ConfigFile.java update: src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal.properties update: src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_de.properties update: src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_es.properties update: src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_fr.properties update: src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_it.properties update: src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_ja.properties update: src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_ko.properties update: src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_sv.properties update: src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_zh_CN.properties update: src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_zh_TW.properties update: src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth.properties update: src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_de.properties update: src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_es.properties update: src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_fr.properties update: src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_it.properties update: src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_ja.properties update: src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_ko.properties update: src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_sv.properties update: src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_zh_CN.properties update: src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_zh_TW.properties update: src/share/classes/com/sun/tools/attach/spi/AttachProvider.java update: src/share/classes/com/sun/tools/jdi/ThreadReferenceImpl.java update: src/share/classes/com/sun/tools/jdi/VirtualMachineManagerImpl.java update: src/share/classes/java/awt/AWTEvent.java update: src/share/classes/java/awt/Canvas.java update: src/share/classes/java/awt/Component.java update: src/share/classes/java/awt/Dialog.java update: src/share/classes/java/awt/EventQueue.java update: src/share/classes/java/awt/GradientPaintContext.java update: src/share/classes/java/awt/GraphicsConfigTemplate.java update: src/share/classes/java/awt/GraphicsEnvironment.java update: src/share/classes/java/awt/MediaTracker.java update: src/share/classes/java/awt/Paint.java update: src/share/classes/java/awt/PaintContext.java update: src/share/classes/java/awt/Panel.java update: src/share/classes/java/awt/SentEvent.java update: src/share/classes/java/awt/SequencedEvent.java update: src/share/classes/java/awt/SystemColor.java update: src/share/classes/java/awt/TexturePaint.java update: src/share/classes/java/awt/Window.java update: src/share/classes/java/awt/dnd/DnDEventMulticaster.java update: src/share/classes/java/awt/dnd/DragSourceContext.java update: src/share/classes/java/awt/dnd/DropTarget.java update: src/share/classes/java/awt/dnd/DropTargetEvent.java update: src/share/classes/java/awt/dnd/DropTargetListener.java update: src/share/classes/java/awt/dnd/peer/DragSourceContextPeer.java update: src/share/classes/java/awt/dnd/peer/DropTargetContextPeer.java update: src/share/classes/java/awt/event/AWTEventListenerProxy.java update: src/share/classes/java/awt/event/AdjustmentEvent.java update: src/share/classes/java/awt/event/ComponentEvent.java update: src/share/classes/java/awt/event/ContainerEvent.java update: src/share/classes/java/awt/event/FocusEvent.java update: src/share/classes/java/awt/event/InputEvent.java update: src/share/classes/java/awt/event/InputMethodEvent.java update: src/share/classes/java/awt/event/ItemEvent.java update: src/share/classes/java/awt/event/MouseEvent.java update: src/share/classes/java/awt/event/PaintEvent.java update: src/share/classes/java/awt/event/TextEvent.java update: src/share/classes/java/awt/event/WindowEvent.java update: src/share/classes/java/awt/peer/ButtonPeer.java update: src/share/classes/java/awt/peer/CanvasPeer.java update: src/share/classes/java/awt/peer/ChoicePeer.java update: src/share/classes/java/awt/peer/ComponentPeer.java update: src/share/classes/java/awt/peer/FileDialogPeer.java update: src/share/classes/java/awt/peer/LabelPeer.java update: src/share/classes/java/awt/peer/PanelPeer.java update: src/share/classes/java/awt/peer/ScrollPanePeer.java update: src/share/classes/java/awt/peer/SystemTrayPeer.java update: src/share/classes/java/awt/peer/TextComponentPeer.java update: src/share/classes/java/awt/peer/TrayIconPeer.java update: src/share/classes/java/awt/peer/WindowPeer.java update: src/share/classes/java/beans/BeanDescriptor.java update: src/share/classes/java/beans/EventSetDescriptor.java update: src/share/classes/java/beans/FeatureDescriptor.java update: src/share/classes/java/beans/IndexedPropertyDescriptor.java update: src/share/classes/java/beans/Introspector.java update: src/share/classes/java/beans/MetaData.java update: src/share/classes/java/beans/MethodDescriptor.java update: src/share/classes/java/beans/PropertyDescriptor.java update: src/share/classes/java/beans/XMLEncoder.java update: src/share/classes/java/lang/ThreadGroup.java update: src/share/classes/java/lang/reflect/Constructor.java update: src/share/classes/java/lang/reflect/Method.java update: src/share/classes/java/math/BigDecimal.java update: src/share/classes/java/math/MathContext.java update: src/share/classes/java/net/MulticastSocket.java update: src/share/classes/java/security/BasicPermission.java update: src/share/classes/java/sql/DriverManager.java update: src/share/classes/java/util/concurrent/ThreadPoolExecutor.java update: src/share/classes/java/util/logging/Logger.java update: src/share/classes/javax/security/auth/Subject.java update: src/share/classes/javax/sound/midi/Synthesizer.java update: src/share/classes/javax/sql/rowset/serial/SerialClob.java update: src/share/classes/javax/swing/JFileChooser.java update: src/share/classes/javax/swing/JPopupMenu.java update: src/share/classes/javax/swing/JTabbedPane.java update: src/share/classes/javax/swing/RepaintManager.java update: src/share/classes/javax/swing/ToolTipManager.java update: src/share/classes/javax/swing/UIManager.java update: src/share/classes/javax/swing/border/LineBorder.java update: src/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java update: src/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java update: src/share/classes/javax/swing/plaf/basic/BasicListUI.java update: src/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java update: src/share/classes/javax/swing/plaf/basic/BasicMenuItemUI.java update: src/share/classes/javax/swing/plaf/basic/BasicPopupMenuUI.java update: src/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java update: src/share/classes/javax/swing/plaf/metal/MetalFileChooserUI.java update: src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java update: src/share/classes/javax/swing/plaf/synth/SynthSliderUI.java update: src/share/classes/javax/swing/plaf/synth/SynthSpinnerUI.java update: src/share/classes/javax/swing/plaf/synth/doc-files/componentProperties.html update: src/share/classes/javax/swing/text/DefaultHighlighter.java update: src/share/classes/javax/swing/text/WrappedPlainView.java update: src/share/classes/javax/swing/text/html/parser/Parser.java update: src/share/classes/javax/xml/datatype/FactoryFinder.java update: src/share/classes/javax/xml/parsers/FactoryFinder.java update: src/share/classes/javax/xml/parsers/SAXParser.java update: src/share/classes/javax/xml/stream/FactoryFinder.java update: src/share/classes/javax/xml/transform/FactoryFinder.java update: src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignature.java update: src/share/classes/org/w3c/dom/TypeInfo.java update: src/share/classes/sun/awt/GlobalCursorManager.java update: src/share/classes/sun/awt/HorizBagLayout.java update: src/share/classes/sun/awt/ModalityEvent.java update: src/share/classes/sun/awt/PlatformFont.java update: src/share/classes/sun/awt/RepaintArea.java update: src/share/classes/sun/awt/ScrollPaneWheelScroller.java update: src/share/classes/sun/awt/SunDisplayChanger.java update: src/share/classes/sun/awt/SunToolkit.java update: src/share/classes/sun/awt/WindowClosingSupport.java update: src/share/classes/sun/awt/dnd/SunDragSourceContextPeer.java update: src/share/classes/sun/awt/dnd/SunDropTargetContextPeer.java update: src/share/classes/sun/awt/im/InputMethodManager.java update: src/share/classes/sun/beans/editors/FontEditor.java update: src/share/classes/sun/misc/PerformanceLogger.java update: src/share/classes/sun/security/tools/JarSigner.java update: src/share/classes/sun/swing/FilePane.java update: src/share/classes/sun/swing/SwingUtilities2.java update: src/share/classes/sun/swing/WindowsPlacesBar.java update: src/share/classes/sun/swing/plaf/synth/SynthFileChooserUIImpl.java update: src/solaris/classes/sun/awt/X11/XAWTLookAndFeel.java update: src/solaris/classes/sun/awt/X11/XCanvasPeer.java update: src/solaris/classes/sun/awt/X11/XCheckboxMenuItemPeer.java update: src/solaris/classes/sun/awt/X11/XCheckboxPeer.java update: src/solaris/classes/sun/awt/X11/XChoicePeer.java update: src/solaris/classes/sun/awt/X11/XClipboard.java update: src/solaris/classes/sun/awt/X11/XCustomCursor.java update: src/solaris/classes/sun/awt/X11/XDecoratedPeer.java update: src/solaris/classes/sun/awt/X11/XDragAndDropProtocols.java update: src/solaris/classes/sun/awt/X11/XDropTargetEventProcessor.java update: src/solaris/classes/sun/awt/X11/XEmbedClientHelper.java update: src/solaris/classes/sun/awt/X11/XEmbeddedFrame.java update: src/solaris/classes/sun/awt/X11/XFileDialogPeer.java update: src/solaris/classes/sun/awt/X11/XFocusProxyWindow.java update: src/solaris/classes/sun/awt/X11/XHorizontalScrollbar.java update: src/solaris/classes/sun/awt/X11/XIconInfo.java update: src/solaris/classes/sun/awt/X11/XMSelection.java update: src/solaris/classes/sun/awt/X11/XMenuItemPeer.java update: src/solaris/classes/sun/awt/X11/XMenuPeer.java update: src/solaris/classes/sun/awt/X11/XPanelPeer.java update: src/solaris/classes/sun/awt/X11/XRobotPeer.java update: src/solaris/classes/sun/awt/X11/XScrollbar.java update: src/solaris/classes/sun/awt/X11/XSystemTrayPeer.java update: src/solaris/classes/sun/awt/X11/XToolkit.java update: src/solaris/classes/sun/awt/X11/XVerticalScrollbar.java update: src/solaris/classes/sun/awt/X11/XWINProtocol.java update: src/solaris/classes/sun/awt/X11/XWarningWindow.java update: src/solaris/classes/sun/awt/X11/XWindow.java update: src/solaris/classes/sun/awt/X11/XWindowPeer.java update: src/solaris/classes/sun/awt/X11/generator/WrapperGenerator.java update: src/solaris/native/java/net/Inet6AddressImpl.c update: src/solaris/native/java/net/NetworkInterface.c update: src/solaris/native/java/net/PlainDatagramSocketImpl.c update: src/solaris/native/java/net/net_util_md.c update: src/solaris/native/java/net/net_util_md.h update: src/solaris/native/sun/awt/gtk2_interface.c update: src/windows/classes/sun/awt/shell/Win32ShellFolder2.java update: src/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java update: src/windows/classes/sun/awt/windows/WCanvasPeer.java update: src/windows/classes/sun/awt/windows/WChoicePeer.java update: src/windows/classes/sun/awt/windows/WClipboard.java update: src/windows/classes/sun/awt/windows/WComponentPeer.java update: src/windows/classes/sun/awt/windows/WDefaultFontCharset.java update: src/windows/classes/sun/awt/windows/WDragSourceContextPeer.java update: src/windows/classes/sun/awt/windows/WDropTargetContextPeer.java update: src/windows/classes/sun/awt/windows/WEmbeddedFrame.java update: src/windows/classes/sun/awt/windows/WEmbeddedFramePeer.java update: src/windows/classes/sun/awt/windows/WFileDialogPeer.java update: src/windows/classes/sun/awt/windows/WFontPeer.java update: src/windows/classes/sun/awt/windows/WInputMethod.java update: src/windows/classes/sun/awt/windows/WInputMethodDescriptor.java update: src/windows/classes/sun/awt/windows/WMenuItemPeer.java update: src/windows/classes/sun/awt/windows/WObjectPeer.java update: src/windows/classes/sun/awt/windows/WPageDialog.java update: src/windows/classes/sun/awt/windows/WPageDialogPeer.java update: src/windows/classes/sun/awt/windows/WPanelPeer.java update: src/windows/classes/sun/awt/windows/WPathGraphics.java update: src/windows/classes/sun/awt/windows/WPrintDialogPeer.java update: src/windows/classes/sun/awt/windows/WTrayIconPeer.java update: src/windows/classes/sun/awt/windows/WWindowPeer.java update: src/windows/native/sun/windows/awt_Canvas.cpp update: src/windows/native/sun/windows/awt_Canvas.h update: src/windows/native/sun/windows/awt_Component.cpp update: src/windows/native/sun/windows/awt_Dialog.cpp update: src/windows/native/sun/windows/awt_Dialog.h update: src/windows/native/sun/windows/awt_FileDialog.cpp update: src/windows/native/sun/windows/awt_FileDialog.h update: src/windows/native/sun/windows/awt_Frame.cpp update: src/windows/native/sun/windows/awt_Frame.h update: src/windows/native/sun/windows/awt_PrintDialog.cpp update: src/windows/native/sun/windows/awt_PrintJob.cpp update: src/windows/native/sun/windows/awt_Toolkit.cpp update: src/windows/native/sun/windows/awt_Window.cpp update: src/windows/native/sun/windows/awt_Window.h update: test/closed/java/awt/Focus/ActualFocusedWindowRetaining/ActualFocusedWindowBlockingTest/ActualFocusedWindowBlockingTest.java update: test/closed/java/awt/Focus/ChildWindowFocusTest/ChildWindowFocusTest.java update: test/closed/java/beans/PropertyEditor/TestEditorForFontClass.java update: test/closed/java/beans/PropertyEditor/TestEditorForFontClassValue.java update: test/closed/javax/sound/sampled/Controls/ReverbControl/SimpleMidiPlayer.java update: test/closed/javax/sound/sampled/Recording/RecordingHangWinXP.java update: test/closed/javax/swing/JPopupMenu/6492266/bug6492266.java update: test/com/sun/jdi/InvokeHangTest.java update: test/com/sun/jdi/ShellScaffold.sh update: test/sun/management/jmxremote/bootstrap/Utils.java rename from: src/share/classes/com/sun/org/apache/regexp/internal/REDemo.java to: deleted_files/src/share/classes/com/sun/org/apache/regexp/internal/REDemo.java rename from: src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/AttributeList.java to: deleted_files/src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/AttributeList.java rename from: src/share/demo/nbproject/jfc/Java2D/build.properties to: src/closed/share/demo/nbproject/jfc/Java2D/build.properties rename from: src/share/demo/nbproject/jfc/Java2D/build.xml to: src/closed/share/demo/nbproject/jfc/Java2D/build.xml rename from: src/share/demo/nbproject/jfc/Java2D/nbproject/file-targets.xml to: src/closed/share/demo/nbproject/jfc/Java2D/nbproject/file-targets.xml rename from: src/share/demo/nbproject/jfc/Java2D/nbproject/jdk.xml to: src/closed/share/demo/nbproject/jfc/Java2D/nbproject/jdk.xml rename from: src/share/demo/nbproject/jfc/Java2D/nbproject/netbeans-targets.xml to: src/closed/share/demo/nbproject/jfc/Java2D/nbproject/netbeans-targets.xml rename from: src/share/demo/nbproject/jfc/Java2D/nbproject/project.xml to: src/closed/share/demo/nbproject/jfc/Java2D/nbproject/project.xml rename from: src/share/demo/nbproject/jfc/Stylepad/build.properties to: src/closed/share/demo/nbproject/jfc/Stylepad/build.properties rename from: src/share/demo/nbproject/jfc/Stylepad/build.xml to: src/closed/share/demo/nbproject/jfc/Stylepad/build.xml rename from: src/share/demo/nbproject/jfc/Stylepad/nbproject/file-targets.xml to: src/closed/share/demo/nbproject/jfc/Stylepad/nbproject/file-targets.xml rename from: src/share/demo/nbproject/jfc/Stylepad/nbproject/jdk.xml to: src/closed/share/demo/nbproject/jfc/Stylepad/nbproject/jdk.xml rename from: src/share/demo/nbproject/jfc/Stylepad/nbproject/netbeans-targets.xml to: src/closed/share/demo/nbproject/jfc/Stylepad/nbproject/netbeans-targets.xml rename from: src/share/demo/nbproject/jfc/Stylepad/nbproject/project.xml to: src/closed/share/demo/nbproject/jfc/Stylepad/nbproject/project.xml rename from: src/share/demo/nbproject/jfc/SwingSet2/build.properties to: src/closed/share/demo/nbproject/jfc/SwingSet2/build.properties rename from: src/share/demo/nbproject/jfc/SwingSet2/build.xml to: src/closed/share/demo/nbproject/jfc/SwingSet2/build.xml rename from: src/share/demo/nbproject/jfc/SwingSet2/nbproject/file-targets.xml to: src/closed/share/demo/nbproject/jfc/SwingSet2/nbproject/file-targets.xml rename from: src/share/demo/nbproject/jfc/SwingSet2/nbproject/jdk.xml to: src/closed/share/demo/nbproject/jfc/SwingSet2/nbproject/jdk.xml rename from: src/share/demo/nbproject/jfc/SwingSet2/nbproject/netbeans-targets.xml to: src/closed/share/demo/nbproject/jfc/SwingSet2/nbproject/netbeans-targets.xml rename from: src/share/demo/nbproject/jfc/SwingSet2/nbproject/project.xml to: src/closed/share/demo/nbproject/jfc/SwingSet2/nbproject/project.xml create: src/share/classes/com/sun/beans/TypeResolver.java create: src/share/classes/com/sun/beans/WildcardTypeImpl.java create: src/share/classes/sun/awt/OSInfo.java create: test/closed/java/awt/Modal/CallPublicFromAnotherAppContext/CallPublicFromAnotherAppContext.java update: test/java/awt/Multiscreen/WPanelPeerPerf/WPanelPeerPerf.java rename from: test/closed/java/awt/Multiscreen/WPanelPeerPerf/WPanelPeerPerf.java to: test/java/awt/Multiscreen/WPanelPeerPerf/WPanelPeerPerf.java update: test/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.html rename from: test/closed/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.html to: test/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.html update: test/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.java rename from: test/closed/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.java to: test/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.java create: test/closed/java/beans/Introspector/TestPropertyType.java create: test/closed/java/beans/Introspector/TestReturnType.java create: test/closed/java/beans/Introspector/TestTypeResolver.java create: test/closed/java/beans/XMLEncoder/TestObjectWithNestedTarget.java create: test/closed/java/beans/XMLEncoder/TestObjectWithNestedTarget_SM.java create: test/closed/java/beans/XMLEncoder/TestPrimitiveArray.java create: test/closed/java/beans/XMLEncoder/TestPrimitiveArray_SM.java create: test/closed/java/beans/XMLEncoder/javax_swing_JLayeredPane.java create: test/closed/javax/swing/JComboBox/6559152/bug6559152.java create: test/closed/javax/swing/JFileChooser/4776197/bug4776197.java create: test/closed/javax/swing/JFileChooser/4926884/bug4926884.html create: test/closed/javax/swing/JFileChooser/4926884/bug4926884.java create: test/closed/javax/swing/JFileChooser/6515169/bug6515169.html create: test/closed/javax/swing/JFileChooser/6515169/bug6515169.java create: test/closed/javax/swing/JPopupMenu/6515446/bug6515446.java create: test/closed/javax/swing/JPopupMenu/6544309/bug6544309.java create: test/closed/javax/swing/JTabbedPane/6495408/bug6495408.java create: test/closed/javax/swing/ToolTipManager/6337516/bug6337516.java create: test/closed/javax/swing/border/LineBorder/4252164/TestLineBorder.html create: test/closed/javax/swing/border/LineBorder/4252164/TestLineBorder.java create: test/closed/javax/swing/plaf/windows/WindowsClassicGetName/WindowsClassicGetName.java create: test/closed/javax/swing/text/DefaultHighlighter/6340106/bug6340106.java create: test/closed/javax/swing/text/WrappedPlainView/6491856/bug6491856.java create: test/closed/javax/swing/text/html/parser/Parser/6527568/bug6527568.java create: test/closed/javax/xml/crypto/dsig/InvalidSignature.java create: test/closed/javax/xml/crypto/dsig/data/invalid-signature.xml create: test/closed/sun/awt/OSInfoTest.java create: test/java/awt/FileDialog/FileDialogReturnTest/FileDialogReturnTest.html create: test/java/awt/FileDialog/FileDialogReturnTest/FileDialogReturnTest.java create: test/java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest.html create: test/java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest.java create: test/java/awt/Focus/TranserFocusToWindow/TranserFocusToWindow.java create: test/java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java create: test/java/net/MulticastSocket/NoLoopbackPackets.java create: test/java/net/MulticastSocket/SetOutgoingIf.java create: test/java/net/ipv6tests/BadIPv6Addresses.java create: test/java/security/BasicPermission/ExitVMEquals.java create: test/java/security/BasicPermission/MixedBasicPermissions.java create: test/java/util/concurrent/ThreadPoolExecutor/SelfInterrupt.java create: test/sun/security/tools/jarsigner/oldsig.sh create: test/sun/security/tools/jarsigner/oldsig/A.class create: test/sun/security/tools/jarsigner/oldsig/A.jar Examined files: 38460 Contents Summary: 46 create 299 update 38115 no action (unchanged) Names Summary: 23 renamed 20 update parent's name history From jprtadm at jprt-web.SFBay.Sun.COM Fri Jul 6 00:21:25 2007 From: jprtadm at jprt-web.SFBay.Sun.COM (JPRT Administrator) Date: Fri, 6 Jul 2007 00:21:25 -0700 (PDT) Subject: [modules-dev] JPRT: job notification - success with job 2007-07-06-063605.daemon.ws Message-ID: <200707060721.l667LPEW008959@jprt-web.SFBay.Sun.COM> JPRT: job notification - success with job 2007-07-06-063605.daemon.ws JPRT Job ID: 2007-07-06-063605.daemon.ws JPRT System Used: sfbay JPRT Version Used: 08 June 2007 - Name Your Poison Day Job URL: http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-06-063605.daemon.ws User: daemon Email: modules-dev at openjdk.java.net Release: jdk1.7.0 Job Source: Source Tree: /net/shimmer.sfbay/export/home/jsr277/ws/{make,src} File List: {.} Command Line: jprt submit -stree ../ws -ot '.*linux_i586.*product.*' -noquickabort -email modules-dev at openjdk.java.net -rtests '*-*-c2-java/module' -rtests '*-*-c2-sun/module' Job submitted at: Fri-06:36:06-GMT Total time in queue: 45m 18s Job started at: Fri-07:05:15-GMT Job finished at: Fri-07:21:24-GMT Job run time: 16m 09s Job state: success Job flags: Bundles: USE: jprt install 2007-07-06-063605.daemon.ws HINT: Use 'jprt rerun -comment -retest 2007-07-06-063605.daemon.ws' to rerun the tests for this job (you can also add tests with 'jprt rerun'). NOTE: Zip files containing exe or dll files on windows have had problems with execute permissions. You may need to 'chmod a+x' the windows exe and dll files. User Comments: null Build (Release:jdk1.7.0 Boot: Import:): linux_i586_2.4.9-product success(11m 23s elapsed) Tests: linux_i586-product-c2-jvm98 success(01m 54s elapsed) linux_i586-product-c2-java/module success(02m 31s elapsed) linux_i586-product-c2-sun/module success(01m 05s elapsed) For announcements on downtime and availability join the alias 'jprt-announce at sun.com'. You can see the latest announcements at http://archives.central/tm/browse?jprt-announce. For suspected system problems, send mail to 'jprt-admin at sun.com'. The jprt how to document is available at http://javaweb.sfbay/jdk/jprt/dist/javadoc/jprt/doc-files/how-to.html. From jprtadm at jprt-web.SFBay.Sun.COM Fri Jul 6 05:54:42 2007 From: jprtadm at jprt-web.SFBay.Sun.COM (JPRT Administrator) Date: Fri, 6 Jul 2007 05:54:42 -0700 (PDT) Subject: [modules-dev] JPRT: job notification - success with job 2007-07-06-111308.as130790.ws Message-ID: <200707061254.l66Csg4d009143@jprt-web.SFBay.Sun.COM> JPRT: job notification - success with job 2007-07-06-111308.as130790.ws JPRT Job ID: 2007-07-06-111308.as130790.ws JPRT System Used: sfbay JPRT Version Used: 08 June 2007 - Name Your Poison Day Job URL: http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-06-111308.as130790.ws User: as130790 Email: modules-dev at openjdk.java.net Release: jdk1.7.0 Job Source: Source Tree: /net/shimmer.sfbay/export/home/jsr277/ws/{make,src} File List: {.} Command Line: jprt submit -stree ../ws -ot '.*product.*' -noquickabort -email modules-dev at openjdk.java.net -rtests '*-*-c2-java/module' -rtests '*-*-c2-sun/module' Job submitted at: Fri-11:13:10-GMT Total time in queue: 1h 41m 32s Job started at: Fri-11:40:51-GMT Job finished at: Fri-12:54:42-GMT Job run time: 1h 13m 51s Job state: success Job flags: Bundles: USE: jprt install 2007-07-06-111308.as130790.ws HINT: Use 'jprt rerun -comment -retest 2007-07-06-111308.as130790.ws' to rerun the tests for this job (you can also add tests with 'jprt rerun'). NOTE: Zip files containing exe or dll files on windows have had problems with execute permissions. You may need to 'chmod a+x' the windows exe and dll files. User Comments: null Build (Release:jdk1.7.0 Boot: Import:): solaris_sparc_5.8-product success(24m 47s elapsed) solaris_sparcv9_5.8-product success(25m 51s elapsed) solaris_i586_5.8-product success(48m 33s elapsed) solaris_x64_5.10-product success(09m 53s elapsed) linux_i586_2.4.9-product success(11m 49s elapsed) linux_x64_2.4.19-product success(13m 32s elapsed) windows_i586_5-product success(35m 40s elapsed) windows_x64_5.2-product success(44m 22s elapsed) Tests: solaris_sparc-product-c2-jvm98 success(02m 32s elapsed) NOTE: Used solaris_sparc_5.10 for above target. solaris_sparcv9-product-c2-jvm98 success(02m 47s elapsed) NOTE: Used solaris_sparc_5.10 for above target. solaris_i586-product-c2-jvm98 success(03m 12s elapsed) linux_i586-product-c2-jvm98 success(01m 56s elapsed) windows_i586-product-c2-jvm98 success(02m 50s elapsed) solaris_x64-product-c2-jvm98 success(01m 55s elapsed) linux_x64-product-c2-jvm98 success(01m 33s elapsed) windows_x64-product-c2-jvm98 success(01m 57s elapsed) solaris_sparc-product-c2-java/module success(04m 02s elapsed) solaris_sparcv9-product-c2-java/module success(04m 09s elapsed) NOTE: Used solaris_sparc_5.10 for above target. solaris_i586-product-c2-java/module success(10m 05s elapsed) linux_i586-product-c2-java/module success(02m 20s elapsed) windows_i586-product-c2-java/module success(05m 18s elapsed) solaris_x64-product-c2-java/module success(01m 45s elapsed) linux_x64-product-c2-java/module success(01m 40s elapsed) windows_x64-product-c2-java/module success(04m 32s elapsed) solaris_sparc-product-c2-sun/module success( 25s elapsed) NOTE: Used solaris_sparc_5.10 for above target. solaris_sparcv9-product-c2-sun/module success( 27s elapsed) NOTE: Used solaris_sparc_5.10 for above target. solaris_i586-product-c2-sun/module success(07m 35s elapsed) linux_i586-product-c2-sun/module success( 59s elapsed) windows_i586-product-c2-sun/module success(03m 03s elapsed) solaris_x64-product-c2-sun/module success( 15s elapsed) linux_x64-product-c2-sun/module success( 21s elapsed) windows_x64-product-c2-sun/module success(02m 32s elapsed) For announcements on downtime and availability join the alias 'jprt-announce at sun.com'. You can see the latest announcements at http://archives.central/tm/browse?jprt-announce. For suspected system problems, send mail to 'jprt-admin at sun.com'. The jprt how to document is available at http://javaweb.sfbay/jdk/jprt/dist/javadoc/jprt/doc-files/how-to.html. From andreas.sterbenz at sun.com Fri Jul 6 06:00:11 2007 From: andreas.sterbenz at sun.com (andreas.sterbenz at sun.com) Date: Fri, 6 Jul 2007 06:00:11 -0700 (PDT) Subject: [modules-dev] Open Bugs/RFEs in java/module Message-ID: <200707061300.l66D0B68006090@shimmer.sfbay.sun.com> An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/modules-dev/attachments/20070706/253744b0/attachment.html From andreas.sterbenz at sun.com Mon Jul 9 06:00:10 2007 From: andreas.sterbenz at sun.com (andreas.sterbenz at sun.com) Date: Mon, 9 Jul 2007 06:00:10 -0700 (PDT) Subject: [modules-dev] Open Bugs/RFEs in java/module Message-ID: <200707091300.l69D0AlW022839@shimmer.sfbay.sun.com> An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/modules-dev/attachments/20070709/e4ac2b12/attachment.html From andreas.sterbenz at sun.com Tue Jul 10 06:19:21 2007 From: andreas.sterbenz at sun.com (andreas.sterbenz at sun.com) Date: Tue, 10 Jul 2007 06:19:21 -0700 (PDT) Subject: [modules-dev] Open Bugs/RFEs in java/module Message-ID: <200707101319.l6ADJLHS010018@shimmer.sfbay.sun.com> An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/modules-dev/attachments/20070710/cc641212/attachment.html From db13166 at pasilla.SFBay.Sun.COM Tue Jul 10 15:08:24 2007 From: db13166 at pasilla.SFBay.Sun.COM (David Bristor) Date: Tue, 10 Jul 2007 15:08:24 -0700 (PDT) Subject: [modules-dev] Code Manager notification (putback-to) Message-ID: <200707102208.l6AM8OUJ023811@pasilla.SFBay.Sun.COM> Event: putback-to Parent workspace: /net/shimmer.sfbay/export/home/jsr277/ws (shimmer.sfbay:/export/home/jsr277/ws) Child workspace: /data/ws/db-jam (pasilla:/data/ws/db-jam) User: db13166 Comment: 6559087 (repo) URLRepository.list() [andreas.sterbenz] 6571501 (repo) Combine HttpUrlRepositoryTest and URLRepositoryTest [andreas.sterbenz] Files: update: src/share/classes/sun/module/repository/ExpandedJamRepository.java update: src/share/classes/sun/module/repository/URLRepository.java update: test/java/module/basic/BasicLauncherTests.java update: test/java/module/basic/HttpRepositoryTest.java update: test/java/module/repository/URLRepositoryTest.java update: test/java/module/repository/URLRepoBuilder.java create: src/share/classes/sun/module/repository/RepositoryContents.java rename from: test/java/module/repository/HttpURLRepositoryTest.java to: deleted_files/test/java/module/repository/HttpURLRepositoryTest.java create: test/java/module/repository/URLRepositoryServer.java Examined files: 9 Contents Summary: 2 create 6 update 1 no action (unchanged) Names Summary: 1 renamed 3 update parent's name history 2 update children's name history From jprtadm at jprt-web.SFBay.Sun.COM Tue Jul 10 15:31:17 2007 From: jprtadm at jprt-web.SFBay.Sun.COM (JPRT Administrator) Date: Tue, 10 Jul 2007 15:31:17 -0700 (PDT) Subject: [modules-dev] JPRT: job notification - success with job 2007-07-10-221113.daemon.ws Message-ID: <200707102231.l6AMVHqW023436@jprt-web.SFBay.Sun.COM> JPRT: job notification - success with job 2007-07-10-221113.daemon.ws JPRT Job ID: 2007-07-10-221113.daemon.ws JPRT System Used: sfbay JPRT Version Used: 08 June 2007 - Name Your Poison Day Job URL: http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-10-221113.daemon.ws User: daemon Email: modules-dev at openjdk.java.net Release: jdk1.7.0 Job Source: Source Tree: /net/shimmer.sfbay/export/home/jsr277/ws/{make,src} File List: {.} Command Line: jprt submit -stree ../ws -ot '.*linux_i586.*product.*' -noquickabort -email modules-dev at openjdk.java.net -rtests '*-*-c2-java/module' -rtests '*-*-c2-sun/module' Job submitted at: Tue-22:11:13-GMT Total time in queue: 20m 04s Job started at: Tue-22:15:34-GMT Job finished at: Tue-22:31:17-GMT Job run time: 15m 43s Job state: success Job flags: Bundles: USE: jprt install 2007-07-10-221113.daemon.ws HINT: Use 'jprt rerun -comment -retest 2007-07-10-221113.daemon.ws' to rerun the tests for this job (you can also add tests with 'jprt rerun'). NOTE: Zip files containing exe or dll files on windows have had problems with execute permissions. You may need to 'chmod a+x' the windows exe and dll files. User Comments: null Build (Release:jdk1.7.0 Boot: Import:): linux_i586_2.4.9-product success(11m 36s elapsed) Tests: linux_i586-product-c2-jvm98 success(01m 52s elapsed) linux_i586-product-c2-java/module success(02m 32s elapsed) linux_i586-product-c2-sun/module success(01m 01s elapsed) For announcements on downtime and availability join the alias 'jprt-announce at sun.com'. You can see the latest announcements at http://archives.central/tm/browse?jprt-announce. For suspected system problems, send mail to 'jprt-admin at sun.com'. The jprt how to document is available at http://javaweb.sfbay/jdk/jprt/dist/javadoc/jprt/doc-files/how-to.html. From db13166 at pasilla.SFBay.Sun.COM Tue Jul 10 15:54:36 2007 From: db13166 at pasilla.SFBay.Sun.COM (David Bristor) Date: Tue, 10 Jul 2007 15:54:36 -0700 (PDT) Subject: [modules-dev] Code Manager notification (putback-to) Message-ID: <200707102254.l6AMsagF010679@pasilla.SFBay.Sun.COM> Event: putback-to Parent workspace: /net/shimmer.sfbay/export/home/jsr277/ws (shimmer.sfbay:/export/home/jsr277/ws) Child workspace: /data/ws/db-repo (pasilla:/data/ws/db-repo) User: db13166 Comment: 6574851 (repo) NPE in URLRepository for non-existant repository_metadata.xml file [andreas.sterbenz] 6574852 (repo) "Cannot access JAM file" error if no trailing / in URL [andreas.sterbenz] Files: update: src/share/classes/sun/module/repository/ModuleInfoXMLReader.java update: src/share/classes/sun/module/repository/URLRepository.java update: src/share/classes/sun/module/repository/URLModuleDefinitionContent.java update: src/share/classes/sun/module/JamUtils.java update: src/share/classes/sun/module/config/VisibilityPolicyFile.java update: src/share/classes/sun/module/tools/Jam.java create: test/java/module/repository/Test6574851.java create: test/java/module/repository/Test6574852.java Examined files: 8 Contents Summary: 2 create 6 update Names Summary: 2 update parent's name history 2 update children's name history From jprtadm at jprt-web.SFBay.Sun.COM Tue Jul 10 16:15:44 2007 From: jprtadm at jprt-web.SFBay.Sun.COM (JPRT Administrator) Date: Tue, 10 Jul 2007 16:15:44 -0700 (PDT) Subject: [modules-dev] JPRT: job notification - FAILED with job 2007-07-10-225725.daemon.ws Message-ID: <200707102315.l6ANFi08023455@jprt-web.SFBay.Sun.COM> JPRT: job notification - FAILED with job 2007-07-10-225725.daemon.ws Failure reason: Test target failure: linux_i586-product-c2-java/module JPRT Job ID: 2007-07-10-225725.daemon.ws JPRT System Used: sfbay JPRT Version Used: 08 June 2007 - Name Your Poison Day Job URL: http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-10-225725.daemon.ws User: daemon Email: modules-dev at openjdk.java.net Release: jdk1.7.0 Job Source: Source Tree: /net/shimmer.sfbay/export/home/jsr277/ws/{make,src} File List: {.} Command Line: jprt submit -stree ../ws -ot '.*linux_i586.*product.*' -noquickabort -email modules-dev at openjdk.java.net -rtests '*-*-c2-java/module' -rtests '*-*-c2-sun/module' Job submitted at: Tue-22:57:25-GMT Total time in queue: 18m 18s Job started at: Tue-23:00:20-GMT Job finished at: Tue-23:15:43-GMT Job run time: 15m 23s Job state: FAILED Job fail/kill comment: Test target failure: linux_i586-product-c2-java/module Job flags: Bundles: USE: jprt install 2007-07-10-225725.daemon.ws HINT: Use 'jprt rerun -comment 2007-07-10-225725.daemon.ws' to rerun this job if you suspect bogus results. User Comments: null Build (Release:jdk1.7.0 Boot: Import:): linux_i586_2.4.9-product success(11m 24s elapsed) Tests: linux_i586-product-c2-jvm98 success(02m 04s elapsed) linux_i586-product-c2-java/module FAILED(02m 26s elapsed) linux_i586-product-c2-sun/module success( 55s elapsed) ------------------------------------------------------------------------------ linux_i586-product-c2-java/module (details from log file) /net/jprt-web.sfbay/jprt/archive/2007/07/2007-07-10-225725.daemon.ws/logs/linux_i586-product-c2-java_module-test.log http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-10-225725.daemon.ws//logs/linux_i586-product-c2-java_module-test.log Test results: passed: 12; failed: 2 Report written to /tmp/jprt/temp/P1/T/225725.daemon/source/test/JTREG_OUTPUT_linux_i686/java/module/JTreport/report.html Results written to /tmp/jprt/temp/P1/T/225725.daemon/source/test/JTREG_OUTPUT_linux_i686/java/module/JTwork Error: Some tests failed or other problems occurred. --------------------------------------------------- Extracting passed and failed counts from jtreg output Test results: passed: 12; failed: 2 ERROR: Failed pattern but no failed count in results --------------------------------------------------- Summary: java/module/basic/BasicLauncherTests.java Passed. Execution successful java/module/config/DefaultImportOverridePolicy/DefaultImportOverridePolicyTest.java Passed. Compilation successful java/module/config/DefaultVisibilityPolicy/DefaultVisibilityPolicyTest.java Passed. Compilation successful java/module/config/ImportOverridePolicyFile/ImportOverridePolicyFileTest.java Passed. Compilation successful java/module/config/VisibilityPolicyFile/VisibilityPolicyFileTest.java Passed. Compilation successful java/module/modinit/RunMTest.java Passed. Execution successful java/module/query/QueryTest.java Passed. Execution successful java/module/repository/LocalRepositoryTest.java Passed. Execution successful java/module/repository/Test6574851.java Failed. Compilation failed java/module/repository/Test6574852.java Failed. Compilation failed java/module/repository/URLRepositoryTest.java Passed. Execution successful java/module/repository/VisibilityPolicyTest.java Passed. Execution successful java/module/version/VersionConstraintTest.java Passed. Execution successful java/module/version/VersionTest.java Passed. Execution successful --------------------------------------------------- JTREG TOTAL: passed=0 failed=1 zip -q -r /opt/jprt/temp/P1/T/225725.daemon/bundles/linux_i586-product-c2-java_module.zip JTREG_OUTPUT_linux_i686 JTREG FAILED make: *** [tests] Error 1 ########################################################### # # Finished: Tue Jul 10 16:14:53 PDT 2007 # # Disk Space: # Filesystem 1k-blocks Used Available Use% Mounted on # /dev/sda2 66357620 13547040 49439744 22% / # # returned exit code 2 # ########################################################### ------------------------------------------------------------------------------ For announcements on downtime and availability join the alias 'jprt-announce at sun.com'. You can see the latest announcements at http://archives.central/tm/browse?jprt-announce. For suspected system problems, send mail to 'jprt-admin at sun.com'. The jprt how to document is available at http://javaweb.sfbay/jdk/jprt/dist/javadoc/jprt/doc-files/how-to.html. From db13166 at pasilla.SFBay.Sun.COM Tue Jul 10 16:46:46 2007 From: db13166 at pasilla.SFBay.Sun.COM (David Bristor) Date: Tue, 10 Jul 2007 16:46:46 -0700 (PDT) Subject: [modules-dev] Code Manager notification (putback-to) Message-ID: <200707102346.l6ANkkcS020095@pasilla.SFBay.Sun.COM> Event: putback-to Parent workspace: /net/shimmer.sfbay/export/home/jsr277/ws (shimmer.sfbay:/export/home/jsr277/ws) Child workspace: /data/ws/db-repo (pasilla:/data/ws/db-repo) User: db13166 Comment: Add forgotten compiler flags Files: update: test/java/module/repository/Test6574851.java update: test/java/module/repository/Test6574852.java Examined files: 11 Contents Summary: 2 update 9 no action (unchanged) From jprtadm at jprt-web.SFBay.Sun.COM Tue Jul 10 17:07:58 2007 From: jprtadm at jprt-web.SFBay.Sun.COM (JPRT Administrator) Date: Tue, 10 Jul 2007 17:07:58 -0700 (PDT) Subject: [modules-dev] JPRT: job notification - success with job 2007-07-10-234934.daemon.ws Message-ID: <200707110007.l6B07w7q023477@jprt-web.SFBay.Sun.COM> JPRT: job notification - success with job 2007-07-10-234934.daemon.ws JPRT Job ID: 2007-07-10-234934.daemon.ws JPRT System Used: sfbay JPRT Version Used: 08 June 2007 - Name Your Poison Day Job URL: http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-10-234934.daemon.ws User: daemon Email: modules-dev at openjdk.java.net Release: jdk1.7.0 Job Source: Source Tree: /net/shimmer.sfbay/export/home/jsr277/ws/{make,src} File List: {.} Command Line: jprt submit -stree ../ws -ot '.*linux_i586.*product.*' -noquickabort -email modules-dev at openjdk.java.net -rtests '*-*-c2-java/module' -rtests '*-*-c2-sun/module' Job submitted at: Tue-23:49:35-GMT Total time in queue: 18m 23s Job started at: Tue-23:52:37-GMT Job finished at: Wed-00:07:58-GMT Job run time: 15m 21s Job state: success Job flags: Bundles: USE: jprt install 2007-07-10-234934.daemon.ws HINT: Use 'jprt rerun -comment -retest 2007-07-10-234934.daemon.ws' to rerun the tests for this job (you can also add tests with 'jprt rerun'). NOTE: Zip files containing exe or dll files on windows have had problems with execute permissions. You may need to 'chmod a+x' the windows exe and dll files. User Comments: null Build (Release:jdk1.7.0 Boot: Import:): linux_i586_2.4.9-product success(11m 21s elapsed) Tests: linux_i586-product-c2-jvm98 success(01m 54s elapsed) linux_i586-product-c2-java/module success(02m 31s elapsed) linux_i586-product-c2-sun/module success( 50s elapsed) For announcements on downtime and availability join the alias 'jprt-announce at sun.com'. You can see the latest announcements at http://archives.central/tm/browse?jprt-announce. For suspected system problems, send mail to 'jprt-admin at sun.com'. The jprt how to document is available at http://javaweb.sfbay/jdk/jprt/dist/javadoc/jprt/doc-files/how-to.html. From David.Bristor at Sun.COM Tue Jul 10 17:28:03 2007 From: David.Bristor at Sun.COM (Dave Bristor) Date: Tue, 10 Jul 2007 17:28:03 -0700 Subject: [modules-dev] Review request: 6559092 Message-ID: <46942413.2040002@sun.com> Hi folks, This causes Repository.getSystemRepository to never return null. webrev: http://javaweb.sfbay/java/jdk/ws/libs/rev/6559092/ bugster: http://monaco.sfbay/detail.jsf?cr=6559092 Notice that Repository.getSystemRepository() is not synchronized. It never has been, but while it looks suspicious, I _think_ that the fact that RepositoryConfig.getSystemRepository() *is* synchronized makes this OK. While the changes look somewhat extensive to RepositoryTest, mostly it is a movement of code to the end of the test. Thanks, Dave From jprtadm at jprt-web.SFBay.Sun.COM Wed Jul 11 05:26:47 2007 From: jprtadm at jprt-web.SFBay.Sun.COM (JPRT Administrator) Date: Wed, 11 Jul 2007 05:26:47 -0700 (PDT) Subject: [modules-dev] JPRT: job notification - FAILED with job 2007-07-11-111303.as130790.ws Message-ID: <200707111226.l6BCQlOD023749@jprt-web.SFBay.Sun.COM> JPRT: job notification - FAILED with job 2007-07-11-111303.as130790.ws Failure reason: Test target failure: windows_i586-product-c2-java/module windows_x64-product-c2-java/module JPRT Job ID: 2007-07-11-111303.as130790.ws JPRT System Used: sfbay JPRT Version Used: 08 June 2007 - Name Your Poison Day Job URL: http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-11-111303.as130790.ws User: as130790 Email: modules-dev at openjdk.java.net Release: jdk1.7.0 Job Source: Source Tree: /net/shimmer.sfbay/export/home/jsr277/ws/{make,src} File List: {.} Command Line: jprt submit -stree ../ws -ot '.*product.*' -noquickabort -email modules-dev at openjdk.java.net -rtests '*-*-c2-java/module' -rtests '*-*-c2-sun/module' Job submitted at: Wed-11:13:04-GMT Total time in queue: 1h 13m 42s Job started at: Wed-11:18:45-GMT Job finished at: Wed-12:26:46-GMT Job run time: 1h 08m 01s Job state: FAILED Job fail/kill comment: Test target failure: windows_i586-product-c2-java/module windows_x64-product-c2-java/module Job flags: Bundles: USE: jprt install 2007-07-11-111303.as130790.ws HINT: Use 'jprt rerun -comment 2007-07-11-111303.as130790.ws' to rerun this job if you suspect bogus results. User Comments: null Build (Release:jdk1.7.0 Boot: Import:): solaris_sparc_5.8-product success(24m 45s elapsed) solaris_sparcv9_5.8-product success(25m 56s elapsed) solaris_i586_5.8-product success(48m 15s elapsed) solaris_x64_5.10-product success(09m 55s elapsed) linux_i586_2.4.9-product success(11m 11s elapsed) linux_x64_2.4.19-product success(12m 49s elapsed) windows_i586_5-product success(34m 50s elapsed) windows_x64_5.2-product success(44m 07s elapsed) Tests: solaris_sparc-product-c2-jvm98 success(02m 30s elapsed) NOTE: Used solaris_sparc_5.10 for above target. solaris_sparcv9-product-c2-jvm98 success(02m 50s elapsed) NOTE: Used solaris_sparc_5.10 for above target. solaris_i586-product-c2-jvm98 success(03m 21s elapsed) linux_i586-product-c2-jvm98 success(02m 07s elapsed) windows_i586-product-c2-jvm98 success(02m 44s elapsed) solaris_x64-product-c2-jvm98 success(01m 46s elapsed) linux_x64-product-c2-jvm98 success(01m 39s elapsed) windows_x64-product-c2-jvm98 success(01m 56s elapsed) solaris_sparc-product-c2-java/module success(03m 59s elapsed) solaris_sparcv9-product-c2-java/module success(04m 11s elapsed) NOTE: Used solaris_sparc_5.10 for above target. solaris_i586-product-c2-java/module success(10m 27s elapsed) linux_i586-product-c2-java/module success(02m 32s elapsed) windows_i586-product-c2-java/module FAILED(05m 34s elapsed) solaris_x64-product-c2-java/module success(01m 47s elapsed) linux_x64-product-c2-java/module success(01m 38s elapsed) windows_x64-product-c2-java/module FAILED(04m 41s elapsed) solaris_sparc-product-c2-sun/module success( 26s elapsed) NOTE: Used solaris_sparc_5.10 for above target. solaris_sparcv9-product-c2-sun/module success( 28s elapsed) NOTE: Used solaris_sparc_5.10 for above target. solaris_i586-product-c2-sun/module success(08m 10s elapsed) linux_i586-product-c2-sun/module success( 59s elapsed) windows_i586-product-c2-sun/module success(02m 56s elapsed) solaris_x64-product-c2-sun/module success( 14s elapsed) linux_x64-product-c2-sun/module success( 18s elapsed) windows_x64-product-c2-sun/module success(02m 35s elapsed) ------------------------------------------------------------------------------ windows_i586-product-c2-java/module (details from log file) /net/jprt-web.sfbay/jprt/archive/2007/07/2007-07-11-111303.as130790.ws/logs/windows_i586-product-c2-java_module-test.log http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-11-111303.as130790.ws//logs/windows_i586-product-c2-java_module-test.log -------------------------------------------------- Test results: passed: 13; failed: 1 Report written to C:\jprt\temp\P1\T\111303.as130790\source\test\JTREG_OUTPUT_windows_i586\java\module\JTreport\report.html Results written to C:\jprt\temp\P1\T\111303.as130790\source\test\JTREG_OUTPUT_windows_i586\java\module\JTwork Error: Some tests failed or other problems occurred. --------------------------------------------------- Extracting passed and failed counts from jtreg output Test results: passed: 13; failed: 1 ERROR: Failed pattern but no failed count in results --------------------------------------------------- Summary: java/module/basic/BasicLauncherTests.java Passed. Execution successful java/module/config/DefaultImportOverridePolicy/DefaultImportOverridePolicyTest.java Passed. Compilation successful java/module/config/DefaultVisibilityPolicy/DefaultVisibilityPolicyTest.java Passed. Compilation successful java/module/config/ImportOverridePolicyFile/ImportOverridePolicyFileTest.java Passed. Compilation successful java/module/config/VisibilityPolicyFile/VisibilityPolicyFileTest.java Passed. Compilation successful java/module/modinit/RunMTest.java Passed. Execution successful java/module/query/QueryTest.java Passed. Execution successful java/module/repository/LocalRepositoryTest.java Passed. Execution successful java/module/repository/Test6574851.java Passed. Compilation successful java/module/repository/Test6574852.java Passed. Compilation successful java/module/repository/URLRepositoryTest.java Failed. Execution failed: `main' threw exception: java.lang.AssertionError: Some tests failed java/module/repository/VisibilityPolicyTest.java Passed. Execution successful java/module/version/VersionConstraintTest.java Passed. Execution successful java/module/version/VersionTest.java Passed. Execution successful --------------------------------------------------- JTREG TOTAL: passed=0 failed=1 zip -q -r C:/jprt/temp/P1/T/111303.as130790/bundles/windows_i586-product-c2-java_module.zip JTREG_OUTPUT_windows_i586 JTREG FAILED C:\jprt\slashjava\devtools\win32\bin\gnumake.exe: *** [tests] Error 1 ########################################################### # # Finished: Wed Jul 11 05:09:05 PDT 2007 # # Disk Space: # C:/ (C:/) 14258936/39070048 # # returned exit code 2 # ########################################################### ------------------------------------------------------------------------------ ------------------------------------------------------------------------------ windows_x64-product-c2-java/module (details from log file) /net/jprt-web.sfbay/jprt/archive/2007/07/2007-07-11-111303.as130790.ws/logs/windows_x64-product-c2-java_module-test.log http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-11-111303.as130790.ws//logs/windows_x64-product-c2-java_module-test.log -------------------------------------------------- Test results: passed: 13; failed: 1 Report written to C:\jprt\temp\P1\T\111303.as130790\source\test\JTREG_OUTPUT_windows_x64\java\module\JTreport\report.html Results written to C:\jprt\temp\P1\T\111303.as130790\source\test\JTREG_OUTPUT_windows_x64\java\module\JTwork Error: Some tests failed or other problems occurred. --------------------------------------------------- Extracting passed and failed counts from jtreg output Test results: passed: 13; failed: 1 ERROR: Failed pattern but no failed count in results --------------------------------------------------- Summary: java/module/basic/BasicLauncherTests.java Passed. Execution successful java/module/config/DefaultImportOverridePolicy/DefaultImportOverridePolicyTest.java Passed. Compilation successful java/module/config/DefaultVisibilityPolicy/DefaultVisibilityPolicyTest.java Passed. Compilation successful java/module/config/ImportOverridePolicyFile/ImportOverridePolicyFileTest.java Passed. Compilation successful java/module/config/VisibilityPolicyFile/VisibilityPolicyFileTest.java Passed. Compilation successful java/module/modinit/RunMTest.java Passed. Execution successful java/module/query/QueryTest.java Passed. Execution successful java/module/repository/LocalRepositoryTest.java Passed. Execution successful java/module/repository/Test6574851.java Passed. Compilation successful java/module/repository/Test6574852.java Passed. Compilation successful java/module/repository/URLRepositoryTest.java Failed. Execution failed: `main' threw exception: java.lang.AssertionError: Some tests failed java/module/repository/VisibilityPolicyTest.java Passed. Execution successful java/module/version/VersionConstraintTest.java Passed. Execution successful java/module/version/VersionTest.java Passed. Execution successful --------------------------------------------------- JTREG TOTAL: passed=0 failed=1 zip -q -r C:/jprt/temp/P1/T/111303.as130790/bundles/windows_x64-product-c2-java_module.zip JTREG_OUTPUT_windows_x64 JTREG FAILED C:\jprt\slashjava\devtools\win32\bin\gnumake.exe: *** [tests] Error 1 ########################################################### # # Finished: Wed Jul 11 05:19:13 PDT 2007 # # Disk Space: # C:/ (C:/) 48332928/71577572 # # returned exit code 2 # ########################################################### ------------------------------------------------------------------------------ For announcements on downtime and availability join the alias 'jprt-announce at sun.com'. You can see the latest announcements at http://archives.central/tm/browse?jprt-announce. For suspected system problems, send mail to 'jprt-admin at sun.com'. The jprt how to document is available at http://javaweb.sfbay/jdk/jprt/dist/javadoc/jprt/doc-files/how-to.html. From andreas.sterbenz at sun.com Wed Jul 11 06:00:25 2007 From: andreas.sterbenz at sun.com (andreas.sterbenz at sun.com) Date: Wed, 11 Jul 2007 06:00:25 -0700 (PDT) Subject: [modules-dev] Open Bugs/RFEs in java/module Message-ID: <200707111300.l6BD0PE7028308@shimmer.sfbay.sun.com> An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/modules-dev/attachments/20070711/5f32bb81/attachment.html From forax at univ-mlv.fr Wed Jul 11 06:59:09 2007 From: forax at univ-mlv.fr (=?ISO-8859-1?Q?R=E9mi_Forax?=) Date: Wed, 11 Jul 2007 15:59:09 +0200 Subject: [modules-dev] Review of module source code Message-ID: <4694E22D.5010509@univ-mlv.fr> this mail contains the review of Version related classe, the review of the other classes will follow. i've used the zip published on the openjdk page: modules-7-ea-src-27_jun_2007.zip so sorry if the code has already changed. package java.module: - VersionRange.java VersionRange#compareTo // @Override // javac 5.0 bug, it's not a bug of javac 5.0, @Override spec changes between 5.0 and 6.0 see http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6399361 VersionRange#equals() 1) if (obj == null || !(obj instanceof VersionRange)) return false; 'null instanceof' always return false so the first test is not necessary, if it's for perf reason report a bug. so the code should be: if (!(obj instanceof VersionRange)) return false; 2) if (this == obj) return true; should be done *before* instanceof test - VersionConstraintBuilder constraints and normalizedConstraints should be final and declared as ArrayList (there are private, i.e. not visible) i wonder if Version and VersionRange not have an abstract package visible common super class. - you can use this super class instead of Object in your List. - add abstract methods like getNormalizedLowerBound() that returns the version itself or the versionRange lower bound (see #toVersionConstraint below) or normalizedContains(Version version) that performs an equals or a contains, etc. VersionConstraintBuilder#toVersionConstraint() instanceof test can be grouped: if (o1 instanceof Version) if (o2 instanceof VersionRange) // case 1 else // case 2 else if (o2 instanceof VersionRange) // case 3 else // case 4 - VersionConstraint #equals exhibit the same glitch #toString use a StringBuffer instead of a StringBuilder - Version is not a final class so methods get*Version are overridable. #compareTo() will not work if one getter is overriden, because it compare fields with getters. #equals (see above) #isVersion() and versionPattern can be delocalized in another class to allow lazy creation of the automata (this comment holds if isVersion() is not a method called frequently). static class VersionMatcher { private static final Pattern versionPattern; static { String regex = "(\\d)+(\\.(\\d)+(\\.(\\d)+(\\.(\\d)+)?)?)?(-([\\p{Alnum}-_])+)?"; versionPattern = Pattern.compile(regex); } static boolean isVersion(String source) { return versionPattern.matcher(source).matches(); } } public static boolean isVersion(String source) { return VersionMatcher.isVersion(source); } that all for today, cheers R?mi From Andreas.Sterbenz at Sun.COM Wed Jul 11 14:13:54 2007 From: Andreas.Sterbenz at Sun.COM (Andreas Sterbenz) Date: Wed, 11 Jul 2007 14:13:54 -0700 Subject: [modules-dev] JPRT: job notification - FAILED with job 2007-07-11-111303.as130790.ws In-Reply-To: <200707111226.l6BCQlOD023749@jprt-web.SFBay.Sun.COM> References: <200707111226.l6BCQlOD023749@jprt-web.SFBay.Sun.COM> Message-ID: <46954812.5060903@sun.com> Dave, do you know what is going on here? Andreas. JPRT Administrator wrote: > JPRT: job notification - FAILED with job 2007-07-11-111303.as130790.ws > > Failure reason: Test target failure: windows_i586-product-c2-java/module > windows_x64-product-c2-java/module > > JPRT Job ID: 2007-07-11-111303.as130790.ws > JPRT System Used: sfbay > JPRT Version Used: 08 June 2007 - Name Your Poison Day > Job URL: > http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-11-111303.as130790.ws > User: as130790 > Email: modules-dev at openjdk.java.net > Release: jdk1.7.0 > Job Source: Source Tree: > /net/shimmer.sfbay/export/home/jsr277/ws/{make,src} > File List: {.} > Command Line: jprt submit -stree ../ws -ot '.*product.*' > -noquickabort -email modules-dev at openjdk.java.net -rtests > '*-*-c2-java/module' -rtests '*-*-c2-sun/module' > Job submitted at: Wed-11:13:04-GMT > Total time in queue: 1h 13m 42s > Job started at: Wed-11:18:45-GMT > Job finished at: Wed-12:26:46-GMT > Job run time: 1h 08m 01s > Job state: FAILED > Job fail/kill comment: Test target failure: > windows_i586-product-c2-java/module windows_x64-product-c2-java/module > Job flags: > Bundles: USE: jprt install 2007-07-11-111303.as130790.ws > > HINT: Use 'jprt rerun -comment 2007-07-11-111303.as130790.ws' to rerun > this job if you suspect bogus results. > > User Comments: > null > > Build (Release:jdk1.7.0 Boot: Import:): > solaris_sparc_5.8-product success(24m 45s elapsed) > solaris_sparcv9_5.8-product success(25m 56s elapsed) > solaris_i586_5.8-product success(48m 15s elapsed) > solaris_x64_5.10-product success(09m 55s elapsed) > linux_i586_2.4.9-product success(11m 11s elapsed) > linux_x64_2.4.19-product success(12m 49s elapsed) > windows_i586_5-product success(34m 50s elapsed) > windows_x64_5.2-product success(44m 07s elapsed) > > Tests: > solaris_sparc-product-c2-jvm98 success(02m 30s elapsed) > NOTE: Used solaris_sparc_5.10 for above target. > solaris_sparcv9-product-c2-jvm98 success(02m 50s elapsed) > NOTE: Used solaris_sparc_5.10 for above target. > solaris_i586-product-c2-jvm98 success(03m 21s elapsed) > linux_i586-product-c2-jvm98 success(02m 07s elapsed) > windows_i586-product-c2-jvm98 success(02m 44s elapsed) > solaris_x64-product-c2-jvm98 success(01m 46s elapsed) > linux_x64-product-c2-jvm98 success(01m 39s elapsed) > windows_x64-product-c2-jvm98 success(01m 56s elapsed) > solaris_sparc-product-c2-java/module success(03m 59s elapsed) > solaris_sparcv9-product-c2-java/module success(04m 11s elapsed) > NOTE: Used solaris_sparc_5.10 for above target. > solaris_i586-product-c2-java/module success(10m 27s elapsed) > linux_i586-product-c2-java/module success(02m 32s elapsed) > windows_i586-product-c2-java/module FAILED(05m 34s elapsed) > solaris_x64-product-c2-java/module success(01m 47s elapsed) > linux_x64-product-c2-java/module success(01m 38s elapsed) > windows_x64-product-c2-java/module FAILED(04m 41s elapsed) > solaris_sparc-product-c2-sun/module success( 26s elapsed) > NOTE: Used solaris_sparc_5.10 for above target. > solaris_sparcv9-product-c2-sun/module success( 28s elapsed) > NOTE: Used solaris_sparc_5.10 for above target. > solaris_i586-product-c2-sun/module success(08m 10s elapsed) > linux_i586-product-c2-sun/module success( 59s elapsed) > windows_i586-product-c2-sun/module success(02m 56s elapsed) > solaris_x64-product-c2-sun/module success( 14s elapsed) > linux_x64-product-c2-sun/module success( 18s elapsed) > windows_x64-product-c2-sun/module success(02m 35s elapsed) > > ------------------------------------------------------------------------------ > windows_i586-product-c2-java/module (details from log file) > /net/jprt-web.sfbay/jprt/archive/2007/07/2007-07-11-111303.as130790.ws/logs/windows_i586-product-c2-java_module-test.log > http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-11-111303.as130790.ws//logs/windows_i586-product-c2-java_module-test.log > -------------------------------------------------- > Test results: passed: 13; failed: 1 > Report written to C:\jprt\temp\P1\T\111303.as130790\source\test\JTREG_OUTPUT_windows_i586\java\module\JTreport\report.html > Results written to C:\jprt\temp\P1\T\111303.as130790\source\test\JTREG_OUTPUT_windows_i586\java\module\JTwork > Error: Some tests failed or other problems occurred. > --------------------------------------------------- > Extracting passed and failed counts from jtreg output > Test results: passed: 13; failed: 1 > ERROR: Failed pattern but no failed count in results > --------------------------------------------------- > Summary: > java/module/basic/BasicLauncherTests.java > Passed. Execution successful > java/module/config/DefaultImportOverridePolicy/DefaultImportOverridePolicyTest.java > Passed. Compilation successful > java/module/config/DefaultVisibilityPolicy/DefaultVisibilityPolicyTest.java > Passed. Compilation successful > java/module/config/ImportOverridePolicyFile/ImportOverridePolicyFileTest.java > Passed. Compilation successful > java/module/config/VisibilityPolicyFile/VisibilityPolicyFileTest.java > Passed. Compilation successful > java/module/modinit/RunMTest.java > Passed. Execution successful > java/module/query/QueryTest.java > Passed. Execution successful > java/module/repository/LocalRepositoryTest.java > Passed. Execution successful > java/module/repository/Test6574851.java > Passed. Compilation successful > java/module/repository/Test6574852.java > Passed. Compilation successful > java/module/repository/URLRepositoryTest.java > Failed. Execution failed: `main' threw exception: java.lang.AssertionError: > Some tests failed > java/module/repository/VisibilityPolicyTest.java > Passed. Execution successful > java/module/version/VersionConstraintTest.java > Passed. Execution successful > java/module/version/VersionTest.java > Passed. Execution successful > --------------------------------------------------- > JTREG TOTAL: passed=0 failed=1 > zip -q -r C:/jprt/temp/P1/T/111303.as130790/bundles/windows_i586-product-c2-java_module.zip > JTREG_OUTPUT_windows_i586 > JTREG FAILED > C:\jprt\slashjava\devtools\win32\bin\gnumake.exe: *** [tests] Error 1 > ########################################################### > # > # Finished: Wed Jul 11 05:09:05 PDT 2007 > # > # Disk Space: > # C:/ (C:/) 14258936/39070048 > # > # returned exit code 2 > # > ########################################################### > > ------------------------------------------------------------------------------ > > ------------------------------------------------------------------------------ > windows_x64-product-c2-java/module (details from log file) > /net/jprt-web.sfbay/jprt/archive/2007/07/2007-07-11-111303.as130790.ws/logs/windows_x64-product-c2-java_module-test.log > http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-11-111303.as130790.ws//logs/windows_x64-product-c2-java_module-test.log > -------------------------------------------------- > Test results: passed: 13; failed: 1 > Report written to C:\jprt\temp\P1\T\111303.as130790\source\test\JTREG_OUTPUT_windows_x64\java\module\JTreport\report.html > Results written to C:\jprt\temp\P1\T\111303.as130790\source\test\JTREG_OUTPUT_windows_x64\java\module\JTwork > Error: Some tests failed or other problems occurred. > --------------------------------------------------- > Extracting passed and failed counts from jtreg output > Test results: passed: 13; failed: 1 > ERROR: Failed pattern but no failed count in results > --------------------------------------------------- > Summary: > java/module/basic/BasicLauncherTests.java > Passed. Execution successful > java/module/config/DefaultImportOverridePolicy/DefaultImportOverridePolicyTest.java > Passed. Compilation successful > java/module/config/DefaultVisibilityPolicy/DefaultVisibilityPolicyTest.java > Passed. Compilation successful > java/module/config/ImportOverridePolicyFile/ImportOverridePolicyFileTest.java > Passed. Compilation successful > java/module/config/VisibilityPolicyFile/VisibilityPolicyFileTest.java > Passed. Compilation successful > java/module/modinit/RunMTest.java > Passed. Execution successful > java/module/query/QueryTest.java > Passed. Execution successful > java/module/repository/LocalRepositoryTest.java > Passed. Execution successful > java/module/repository/Test6574851.java > Passed. Compilation successful > java/module/repository/Test6574852.java > Passed. Compilation successful > java/module/repository/URLRepositoryTest.java > Failed. Execution failed: `main' threw exception: java.lang.AssertionError: > Some tests failed > java/module/repository/VisibilityPolicyTest.java > Passed. Execution successful > java/module/version/VersionConstraintTest.java > Passed. Execution successful > java/module/version/VersionTest.java > Passed. Execution successful > --------------------------------------------------- > JTREG TOTAL: passed=0 failed=1 > zip -q -r C:/jprt/temp/P1/T/111303.as130790/bundles/windows_x64-product-c2-java_module.zip > JTREG_OUTPUT_windows_x64 > JTREG FAILED > C:\jprt\slashjava\devtools\win32\bin\gnumake.exe: *** [tests] Error 1 > ########################################################### > # > # Finished: Wed Jul 11 05:19:13 PDT 2007 > # > # Disk Space: > # C:/ (C:/) 48332928/71577572 > # > # returned exit code 2 > # > ########################################################### > > ------------------------------------------------------------------------------ > > > > > For announcements on downtime and availability join the alias > 'jprt-announce at sun.com'. > You can see the latest announcements at > http://archives.central/tm/browse?jprt-announce. > For suspected system problems, send mail to 'jprt-admin at sun.com'. > The jprt how to document is available at > http://javaweb.sfbay/jdk/jprt/dist/javadoc/jprt/doc-files/how-to.html. > > > > _______________________________________________ > modules-dev mailing list > modules-dev at openjdk.java.net > http://mail.openjdk.java.net/mailman/listinfo/modules-dev From David.Bristor at Sun.COM Wed Jul 11 14:39:01 2007 From: David.Bristor at Sun.COM (Dave Bristor) Date: Wed, 11 Jul 2007 14:39:01 -0700 Subject: [modules-dev] JPRT: job notification - FAILED with job 2007-07-11-111303.as130790.ws In-Reply-To: <46954812.5060903@sun.com> References: <200707111226.l6BCQlOD023749@jprt-web.SFBay.Sun.COM> <46954812.5060903@sun.com> Message-ID: <46954DF5.1000900@sun.com> I'm not sure of the root cause; I've added some diagnostic information and went to run it via JPRT, which is down, so I'm waiting for its return. Dave Andreas Sterbenz wrote: > Dave, > > do you know what is going on here? > > Andreas. > > JPRT Administrator wrote: > >>JPRT: job notification - FAILED with job 2007-07-11-111303.as130790.ws >> >>Failure reason: Test target failure: windows_i586-product-c2-java/module >> windows_x64-product-c2-java/module >> >>JPRT Job ID: 2007-07-11-111303.as130790.ws >>JPRT System Used: sfbay >>JPRT Version Used: 08 June 2007 - Name Your Poison Day >>Job URL: >> http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-11-111303.as130790.ws >>User: as130790 >>Email: modules-dev at openjdk.java.net >>Release: jdk1.7.0 >>Job Source: Source Tree: >> /net/shimmer.sfbay/export/home/jsr277/ws/{make,src} >>File List: {.} >>Command Line: jprt submit -stree ../ws -ot '.*product.*' >> -noquickabort -email modules-dev at openjdk.java.net -rtests >> '*-*-c2-java/module' -rtests '*-*-c2-sun/module' >>Job submitted at: Wed-11:13:04-GMT >>Total time in queue: 1h 13m 42s >>Job started at: Wed-11:18:45-GMT >>Job finished at: Wed-12:26:46-GMT >>Job run time: 1h 08m 01s >>Job state: FAILED >>Job fail/kill comment: Test target failure: >> windows_i586-product-c2-java/module windows_x64-product-c2-java/module >>Job flags: >>Bundles: USE: jprt install 2007-07-11-111303.as130790.ws >> >>HINT: Use 'jprt rerun -comment 2007-07-11-111303.as130790.ws' to rerun >>this job if you suspect bogus results. >> >>User Comments: >>null >> >>Build (Release:jdk1.7.0 Boot: Import:): >>solaris_sparc_5.8-product success(24m 45s elapsed) >>solaris_sparcv9_5.8-product success(25m 56s elapsed) >>solaris_i586_5.8-product success(48m 15s elapsed) >>solaris_x64_5.10-product success(09m 55s elapsed) >>linux_i586_2.4.9-product success(11m 11s elapsed) >>linux_x64_2.4.19-product success(12m 49s elapsed) >>windows_i586_5-product success(34m 50s elapsed) >>windows_x64_5.2-product success(44m 07s elapsed) >> >>Tests: >>solaris_sparc-product-c2-jvm98 success(02m 30s elapsed) >>NOTE: Used solaris_sparc_5.10 for above target. >>solaris_sparcv9-product-c2-jvm98 success(02m 50s elapsed) >>NOTE: Used solaris_sparc_5.10 for above target. >>solaris_i586-product-c2-jvm98 success(03m 21s elapsed) >>linux_i586-product-c2-jvm98 success(02m 07s elapsed) >>windows_i586-product-c2-jvm98 success(02m 44s elapsed) >>solaris_x64-product-c2-jvm98 success(01m 46s elapsed) >>linux_x64-product-c2-jvm98 success(01m 39s elapsed) >>windows_x64-product-c2-jvm98 success(01m 56s elapsed) >>solaris_sparc-product-c2-java/module success(03m 59s elapsed) >>solaris_sparcv9-product-c2-java/module success(04m 11s elapsed) >>NOTE: Used solaris_sparc_5.10 for above target. >>solaris_i586-product-c2-java/module success(10m 27s elapsed) >>linux_i586-product-c2-java/module success(02m 32s elapsed) >>windows_i586-product-c2-java/module FAILED(05m 34s elapsed) >>solaris_x64-product-c2-java/module success(01m 47s elapsed) >>linux_x64-product-c2-java/module success(01m 38s elapsed) >>windows_x64-product-c2-java/module FAILED(04m 41s elapsed) >>solaris_sparc-product-c2-sun/module success( 26s elapsed) >>NOTE: Used solaris_sparc_5.10 for above target. >>solaris_sparcv9-product-c2-sun/module success( 28s elapsed) >>NOTE: Used solaris_sparc_5.10 for above target. >>solaris_i586-product-c2-sun/module success(08m 10s elapsed) >>linux_i586-product-c2-sun/module success( 59s elapsed) >>windows_i586-product-c2-sun/module success(02m 56s elapsed) >>solaris_x64-product-c2-sun/module success( 14s elapsed) >>linux_x64-product-c2-sun/module success( 18s elapsed) >>windows_x64-product-c2-sun/module success(02m 35s elapsed) >> >>------------------------------------------------------------------------------ >>windows_i586-product-c2-java/module (details from log file) >>/net/jprt-web.sfbay/jprt/archive/2007/07/2007-07-11-111303.as130790.ws/logs/windows_i586-product-c2-java_module-test.log >>http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-11-111303.as130790.ws//logs/windows_i586-product-c2-java_module-test.log >>-------------------------------------------------- >>Test results: passed: 13; failed: 1 >>Report written to C:\jprt\temp\P1\T\111303.as130790\source\test\JTREG_OUTPUT_windows_i586\java\module\JTreport\report.html >>Results written to C:\jprt\temp\P1\T\111303.as130790\source\test\JTREG_OUTPUT_windows_i586\java\module\JTwork >>Error: Some tests failed or other problems occurred. >>--------------------------------------------------- >>Extracting passed and failed counts from jtreg output >>Test results: passed: 13; failed: 1 >>ERROR: Failed pattern but no failed count in results >>--------------------------------------------------- >>Summary: >>java/module/basic/BasicLauncherTests.java >> Passed. Execution successful >>java/module/config/DefaultImportOverridePolicy/DefaultImportOverridePolicyTest.java >> Passed. Compilation successful >>java/module/config/DefaultVisibilityPolicy/DefaultVisibilityPolicyTest.java >> Passed. Compilation successful >>java/module/config/ImportOverridePolicyFile/ImportOverridePolicyFileTest.java >> Passed. Compilation successful >>java/module/config/VisibilityPolicyFile/VisibilityPolicyFileTest.java >> Passed. Compilation successful >>java/module/modinit/RunMTest.java >> Passed. Execution successful >>java/module/query/QueryTest.java >> Passed. Execution successful >>java/module/repository/LocalRepositoryTest.java >> Passed. Execution successful >>java/module/repository/Test6574851.java >> Passed. Compilation successful >>java/module/repository/Test6574852.java >> Passed. Compilation successful >>java/module/repository/URLRepositoryTest.java >> Failed. Execution failed: `main' threw exception: java.lang.AssertionError: >> Some tests failed >>java/module/repository/VisibilityPolicyTest.java >> Passed. Execution successful >>java/module/version/VersionConstraintTest.java >> Passed. Execution successful >>java/module/version/VersionTest.java >> Passed. Execution successful >>--------------------------------------------------- >>JTREG TOTAL: passed=0 failed=1 >>zip -q -r C:/jprt/temp/P1/T/111303.as130790/bundles/windows_i586-product-c2-java_module.zip >> JTREG_OUTPUT_windows_i586 >>JTREG FAILED >>C:\jprt\slashjava\devtools\win32\bin\gnumake.exe: *** [tests] Error 1 >>########################################################### >># >># Finished: Wed Jul 11 05:09:05 PDT 2007 >># >># Disk Space: >># C:/ (C:/) 14258936/39070048 >># >># returned exit code 2 >># >>########################################################### >> >>------------------------------------------------------------------------------ >> >>------------------------------------------------------------------------------ >>windows_x64-product-c2-java/module (details from log file) >>/net/jprt-web.sfbay/jprt/archive/2007/07/2007-07-11-111303.as130790.ws/logs/windows_x64-product-c2-java_module-test.log >>http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-11-111303.as130790.ws//logs/windows_x64-product-c2-java_module-test.log >>-------------------------------------------------- >>Test results: passed: 13; failed: 1 >>Report written to C:\jprt\temp\P1\T\111303.as130790\source\test\JTREG_OUTPUT_windows_x64\java\module\JTreport\report.html >>Results written to C:\jprt\temp\P1\T\111303.as130790\source\test\JTREG_OUTPUT_windows_x64\java\module\JTwork >>Error: Some tests failed or other problems occurred. >>--------------------------------------------------- >>Extracting passed and failed counts from jtreg output >>Test results: passed: 13; failed: 1 >>ERROR: Failed pattern but no failed count in results >>--------------------------------------------------- >>Summary: >>java/module/basic/BasicLauncherTests.java >> Passed. Execution successful >>java/module/config/DefaultImportOverridePolicy/DefaultImportOverridePolicyTest.java >> Passed. Compilation successful >>java/module/config/DefaultVisibilityPolicy/DefaultVisibilityPolicyTest.java >> Passed. Compilation successful >>java/module/config/ImportOverridePolicyFile/ImportOverridePolicyFileTest.java >> Passed. Compilation successful >>java/module/config/VisibilityPolicyFile/VisibilityPolicyFileTest.java >> Passed. Compilation successful >>java/module/modinit/RunMTest.java >> Passed. Execution successful >>java/module/query/QueryTest.java >> Passed. Execution successful >>java/module/repository/LocalRepositoryTest.java >> Passed. Execution successful >>java/module/repository/Test6574851.java >> Passed. Compilation successful >>java/module/repository/Test6574852.java >> Passed. Compilation successful >>java/module/repository/URLRepositoryTest.java >> Failed. Execution failed: `main' threw exception: java.lang.AssertionError: >> Some tests failed >>java/module/repository/VisibilityPolicyTest.java >> Passed. Execution successful >>java/module/version/VersionConstraintTest.java >> Passed. Execution successful >>java/module/version/VersionTest.java >> Passed. Execution successful >>--------------------------------------------------- >>JTREG TOTAL: passed=0 failed=1 >>zip -q -r C:/jprt/temp/P1/T/111303.as130790/bundles/windows_x64-product-c2-java_module.zip >> JTREG_OUTPUT_windows_x64 >>JTREG FAILED >>C:\jprt\slashjava\devtools\win32\bin\gnumake.exe: *** [tests] Error 1 >>########################################################### >># >># Finished: Wed Jul 11 05:19:13 PDT 2007 >># >># Disk Space: >># C:/ (C:/) 48332928/71577572 >># >># returned exit code 2 >># >>########################################################### >> >>------------------------------------------------------------------------------ >> >> >> >> >>For announcements on downtime and availability join the alias >> 'jprt-announce at sun.com'. >>You can see the latest announcements at >> http://archives.central/tm/browse?jprt-announce. >>For suspected system problems, send mail to 'jprt-admin at sun.com'. >>The jprt how to document is available at >> http://javaweb.sfbay/jdk/jprt/dist/javadoc/jprt/doc-files/how-to.html. >> >> >> >>_______________________________________________ >>modules-dev mailing list >>modules-dev at openjdk.java.net >>http://mail.openjdk.java.net/mailman/listinfo/modules-dev > > > _______________________________________________ > modules-dev mailing list > modules-dev at openjdk.java.net > http://mail.openjdk.java.net/mailman/listinfo/modules-dev From David.Bristor at Sun.COM Wed Jul 11 15:46:16 2007 From: David.Bristor at Sun.COM (Dave Bristor) Date: Wed, 11 Jul 2007 15:46:16 -0700 Subject: [modules-dev] Initial repository management tool Message-ID: <46955DB8.7080408@sun.com> I've created an inital repository management tool. Currently it provides only list and query/find operations. Please have a look at the code: webrev: http://javaweb.sfbay/java/jdk/ws/libs/rev/6559117/ bugster: http://monaco.sfbay/detail.jsf?cr=6559117 I'll certainly need to add some tests. Suggestions on how to test command-line programs are welcome. I'm sort of tempted to cause the command objects to make their results available via an API, for easier inspection by tests; the visual output would be (untested) eye candy. ToolBase.java is lifted from Jam.java; if it seems reasonable then I'd refactor Jam.java to use it. Thanks, Dave From andreas.sterbenz at sun.com Thu Jul 12 06:00:27 2007 From: andreas.sterbenz at sun.com (andreas.sterbenz at sun.com) Date: Thu, 12 Jul 2007 06:00:27 -0700 (PDT) Subject: [modules-dev] Open Bugs/RFEs in java/module Message-ID: <200707121300.l6CD0RE2006389@shimmer.sfbay.sun.com> An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/modules-dev/attachments/20070712/6e44f3d4/attachment.html From Stanley.Ho at Sun.COM Thu Jul 12 14:04:25 2007 From: Stanley.Ho at Sun.COM (Stanley M. Ho) Date: Thu, 12 Jul 2007 14:04:25 -0700 Subject: [modules-dev] Review of module source code In-Reply-To: <4694E22D.5010509@univ-mlv.fr> References: <4694E22D.5010509@univ-mlv.fr> Message-ID: <46969759.9070706@sun.com> Hi Remi, Thanks for the review. Most of your comments are valid, and I will incorporate them into a future putback. R?mi Forax wrote: > > - VersionConstraintBuilder > i wonder if Version and VersionRange not have an abstract package visible > common super class. I have explored this in the past but it does not only result a new super class and but it also makes the code even more complicated. The problem is that there isn't a good logical super class that makes sense with Version and VersionRange. > - Version > is not a final class so methods get*Version are overridable. Version is intended to be subclass-able. > #compareTo() will not work if one getter is overriden, > because it compare fields with getters. Good catch. This is indeed a problem. I will file a bug on this. > #isVersion() and versionPattern can be delocalized in another class > to allow lazy creation of the automata (this comment holds if isVersion() > is not a method called frequently). This method is used by VersionConstraint and is used very frequently. - Stanley From Stanley.Ho at Sun.COM Thu Jul 12 14:25:38 2007 From: Stanley.Ho at Sun.COM (Stanley M. Ho) Date: Thu, 12 Jul 2007 14:25:38 -0700 Subject: [modules-dev] Review request: 6559092 In-Reply-To: <46942413.2040002@sun.com> References: <46942413.2040002@sun.com> Message-ID: <46969C52.2060805@sun.com> Hi Dave, Looks good. Several comments inline: - src/share/classes/sun/module/repository/RepositoryConfig.java I think rather than creating a fake system repository if one doesn't yet exist, it would be better to simply use the bootstrap repository as the default system repository, i.e. private static Repository systemRepository = Repository.getBootstrapRepository(); Then if the module launcher needs to change the system repository later, it could simply reset it, e.g. repository = Modules.newLocalRepository( RepositoryConfig.getSystemRepository(), "application", tmp.getCanonicalFile().toURI().toURL() ); RepositoryConfig.setSystemRepository(repository); - test/java/module/repository/LocalRepositoryTest.java 81 check(systemRepo.getParent() == Repository.getBootstrapRepository()); This check would break as soon as the repository configuration file support is in place, but should be okay for now. - Stanley From David.Bristor at Sun.COM Thu Jul 12 15:04:55 2007 From: David.Bristor at Sun.COM (Dave Bristor) Date: Thu, 12 Jul 2007 15:04:55 -0700 Subject: [modules-dev] Review request: 6559092 In-Reply-To: <46969C52.2060805@sun.com> References: <46942413.2040002@sun.com> <46969C52.2060805@sun.com> Message-ID: <4696A587.6080806@sun.com> Stanley M. Ho wrote: > Hi Dave, > > Looks good. Several comments inline: > > - src/share/classes/sun/module/repository/RepositoryConfig.java > > I think rather than creating a fake system repository if one doesn't yet > exist, it would be better to simply use the bootstrap repository as the > default system repository, i.e. > > private static Repository systemRepository = > Repository.getBootstrapRepository(); > > Then if the module launcher needs to change the system repository later, > it could simply reset it, e.g. > > repository = Modules.newLocalRepository( > RepositoryConfig.getSystemRepository(), > "application", > tmp.getCanonicalFile().toURI().toURL() > ); > RepositoryConfig.setSystemRepository(repository); That would mean that the system repository could be changed at will. The intention of the proposed change was that the system repository could be set at most once. Do we really want to allow that? If so, should we do any checks to be sure that the bootstrap repository is reachable from the argument given to setSystemRepository? Or, we could add some other field to indicate whether setSystemRepository has ever been invoked, and allow it to be invoked at most once/JVM. Comments? > > > - test/java/module/repository/LocalRepositoryTest.java > > 81 check(systemRepo.getParent() == > Repository.getBootstrapRepository()); > > This check would break as soon as the repository configuration file > support is in place, but should be okay for now. Thanks: I'm working on the configuration file support now, and will be sure to make that change! Dave > > - Stanley From Stanley.Ho at Sun.COM Thu Jul 12 15:15:15 2007 From: Stanley.Ho at Sun.COM (Stanley M. Ho) Date: Thu, 12 Jul 2007 15:15:15 -0700 Subject: [modules-dev] Review request: 6559092 In-Reply-To: <4696A587.6080806@sun.com> References: <46942413.2040002@sun.com> <46969C52.2060805@sun.com> <4696A587.6080806@sun.com> Message-ID: <4696A7F3.50309@sun.com> Dave Bristor wrote: > > That would mean that the system repository could be changed at will. > The intention of the proposed change was that the system repository > could be set at most once. Do we really want to allow that? If so, > should we do any checks to be sure that the bootstrap repository is > reachable from the argument given to setSystemRepository? Or, we could > add some other field to indicate whether setSystemRepository has ever > been invoked, and allow it to be invoked at most once/JVM. Comments? The system repository could not and should not be changed externally, and there is no public setSystemRepository API in the Repository class. Internally, the system repository should only be set at most once through the RepositoryConfig.setSystemRepository method. Adding a flag sounds like a reasonable approach. - Stanley From Stanley.Ho at Sun.COM Thu Jul 12 15:44:24 2007 From: Stanley.Ho at Sun.COM (Stanley M. Ho) Date: Thu, 12 Jul 2007 15:44:24 -0700 Subject: [modules-dev] Initial repository management tool In-Reply-To: <46955DB8.7080408@sun.com> References: <46955DB8.7080408@sun.com> Message-ID: <4696AEC8.1050706@sun.com> Hi Dave, Looks like a good start. Several comments inline: - src/share/classes/sun/module/tools/ToolBase.java 35 public class ToolBase { Should be package private. - src/share/classes/sun/module/tools/JRepo.java Remove empty line at #43 and #46. 76 usage = "Usage: jrepo , where cmd is follows one of the patterns below"; Perhaps "command" instead of "cmd". 68 private static final Map commands = new LinkedHashMap(); 75 if (usage == null) { 76 usage = "Usage: jrepo , where cmd is follows one of the patterns below"; 77 new ListCommand(); 78 new FindCommand(); 79 new QueryCommand(); 80 } 167 commands.put(name, this); 168 String u = usage(); 169 if (u != null) { 170 usage += "\n\t" + usage(); 171 } 330 for (Map.Entry entry : commands.entrySet()) { 331 if (entry.getKey().startsWith(args[0])) { 332 cmd = entry.getValue(); 333 break; 334 } 335 } 416 void usageError() { 417 error(usage); 418 } I don't like the idea of having the Command constructor to bring side effect to "usage" and "commands" in the outer class. I think removing these side effects could simply the code and make it more readable, e.g. private state final List commands = new ArrayList(); ... commands.add(new ListCommand()); commands.add(new FindCommand()); commands.add(new QueryCommand()); ... for (Command command : commands) { if (command.getName().startsWith(args[0])) { cmd = entry.getValue(); break; } } ... private void usageError() { StringBuilder builder = new StringBuilder(); builder.append("Usage: jrepo , where command follows one of the patterns below\n"); for (Command command : commands) { builder.append(command.getUsage()); builder.append("\n"); } error(builder.toString()); } 165 abstract class Command { 223 class ListCommand extends Command { 261 class FindCommand extends Command { 303 class QueryCommand extends FindCommand { These classes should be private static if possible. 103 if (repo == null) { 104 err.println("can't access repository " + repositoryLocation); 105 return false; 106 } Is this check really necessary? I would have assumed the method has already returned if there was exception in #95-#100. I'm surprised we have to configure the metadata directory in the repository in #139-#145. I think the URLRepository implementation should do this automatically by default if no metadata directory is specified. 246 List installed = repo.list(); 247 for (ModuleArchiveInfo mai : installed) Should combine into for (ModuleArchiveInfo mai : repo.list()) 308 String usage() { return null; } Should either not override the method, or return usage string specific for "query". The getRepositoryText method looks like something Repository.toString() should provide. If not, at least we could clean it up as: private String getRepositoryText(Repository repo) { URL u = repo.getSourceLocation(); if (u == null) { return "Bootstrap repository"; } else { return "Repository " + u.toExternalForm(); } } That's it for now. - Stanley From David.Bristor at Sun.COM Thu Jul 12 16:51:10 2007 From: David.Bristor at Sun.COM (Dave Bristor) Date: Thu, 12 Jul 2007 16:51:10 -0700 Subject: [modules-dev] Review request: 6559092 In-Reply-To: <4696A7F3.50309@sun.com> References: <46942413.2040002@sun.com> <46969C52.2060805@sun.com> <4696A587.6080806@sun.com> <4696A7F3.50309@sun.com> Message-ID: <4696BE6E.5040008@sun.com> Stanley M. Ho wrote: > > Dave Bristor wrote: > >> >> That would mean that the system repository could be changed at will. >> The intention of the proposed change was that the system repository >> could be set at most once. Do we really want to allow that? If so, >> should we do any checks to be sure that the bootstrap repository is >> reachable from the argument given to setSystemRepository? Or, we >> could add some other field to indicate whether setSystemRepository has >> ever been invoked, and allow it to be invoked at most once/JVM. >> Comments? > > > The system repository could not and should not be changed externally, > and there is no public setSystemRepository API in the Repository class. > Internally, the system repository should only be set at most once > through the RepositoryConfig.setSystemRepository method. Adding a flag > sounds like a reasonable approach. I've combined our approaches: no more fake system repository, and a flag to ensure setSystemRepository succeeds only once. I updated the webrev: http://javaweb.sfbay/java/jdk/ws/libs/rev/6559092/ Thanks, Dave > > - Stanley From Stanley.Ho at Sun.COM Thu Jul 12 17:23:54 2007 From: Stanley.Ho at Sun.COM (Stanley M. Ho) Date: Thu, 12 Jul 2007 17:23:54 -0700 Subject: [modules-dev] Review request: 6559092 In-Reply-To: <4696BE6E.5040008@sun.com> References: <46942413.2040002@sun.com> <46969C52.2060805@sun.com> <4696A587.6080806@sun.com> <4696A7F3.50309@sun.com> <4696BE6E.5040008@sun.com> Message-ID: <4696C61A.2020308@sun.com> Dave Bristor wrote: > I've combined our approaches: no more fake system repository, and a flag to > ensure setSystemRepository succeeds only once. > > I updated the webrev: > http://javaweb.sfbay/java/jdk/ws/libs/rev/6559092/ Looks good. One last thing, I am not sure if you really need RepositoryConfig.getParentForSystemRepository() anymore. You could simply call RepositoryConfig.getSystemRepository() instead and later set the new one back through RepositoryConfig.setSystemRepository(). - Stanley From db13166 at pasilla.SFBay.Sun.COM Thu Jul 12 17:37:55 2007 From: db13166 at pasilla.SFBay.Sun.COM (David Bristor) Date: Thu, 12 Jul 2007 17:37:55 -0700 (PDT) Subject: [modules-dev] Code Manager notification (putback-to) Message-ID: <200707130037.l6D0btRZ018161@pasilla.SFBay.Sun.COM> Event: putback-to Parent workspace: /net/shimmer.sfbay/export/home/jsr277/ws (shimmer.sfbay:/export/home/jsr277/ws) Child workspace: /data/ws/db-repo (pasilla:/data/ws/db-repo) User: db13166 Comment: Fixes a problem presumably caused by putbacks for one of 6559087, 6571501, 6544851, or 6544852 which failed only on Windows in which the directory for downloading modules could not be created. [stanley.ho] Files: update: src/share/classes/sun/module/repository/URLRepository.java update: src/share/classes/sun/module/repository/URLModuleDefinitionContent.java update: src/share/classes/sun/module/JamUtils.java update: test/java/module/repository/URLRepositoryTest.java Examined files: 4 Contents Summary: 4 update From jprtadm at jprt-web.SFBay.Sun.COM Thu Jul 12 22:06:11 2007 From: jprtadm at jprt-web.SFBay.Sun.COM (JPRT Administrator) Date: Thu, 12 Jul 2007 22:06:11 -0700 (PDT) Subject: [modules-dev] JPRT: job notification - success with job 2007-07-13-004045.daemon.ws Message-ID: <200707130506.l6D56BQq012638@jprt-web.SFBay.Sun.COM> JPRT: job notification - success with job 2007-07-13-004045.daemon.ws JPRT Job ID: 2007-07-13-004045.daemon.ws JPRT System Used: sfbay JPRT Version Used: 08 June 2007 - Name Your Poison Day Job URL: http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-13-004045.daemon.ws User: daemon Email: modules-dev at openjdk.java.net Release: jdk1.7.0 Job Source: Source Tree: /net/shimmer.sfbay/export/home/jsr277/ws/{make,src} File List: {.} Command Line: jprt submit -stree ../ws -ot '.*linux_i586.*product.*' -noquickabort -email modules-dev at openjdk.java.net -rtests '*-*-c2-java/module' -rtests '*-*-c2-sun/module' Job submitted at: Fri-00:40:45-GMT Total time in queue: 4h 25m 26s Job started at: Fri-04:52:54-GMT Job finished at: Fri-05:06:11-GMT Job run time: 13m 17s Job state: success Job flags: Bundles: USE: jprt install 2007-07-13-004045.daemon.ws HINT: Use 'jprt rerun -comment -retest 2007-07-13-004045.daemon.ws' to rerun the tests for this job (you can also add tests with 'jprt rerun'). NOTE: Zip files containing exe or dll files on windows have had problems with execute permissions. You may need to 'chmod a+x' the windows exe and dll files. User Comments: null Build (Release:jdk1.7.0 Boot: Import:): linux_i586_2.4.9-product success(09m 30s elapsed) Tests: linux_i586-product-c2-jvm98 success(01m 46s elapsed) linux_i586-product-c2-java/module success(02m 18s elapsed) linux_i586-product-c2-sun/module success( 46s elapsed) For announcements on downtime and availability join the alias 'jprt-announce at sun.com'. You can see the latest announcements at http://archives.central/tm/browse?jprt-announce. For suspected system problems, send mail to 'jprt-admin at sun.com'. The jprt how to document is available at http://javaweb.sfbay/jdk/jprt/dist/javadoc/jprt/doc-files/how-to.html. From jprtadm at jprt-web.SFBay.Sun.COM Fri Jul 13 05:29:39 2007 From: jprtadm at jprt-web.SFBay.Sun.COM (JPRT Administrator) Date: Fri, 13 Jul 2007 05:29:39 -0700 (PDT) Subject: [modules-dev] JPRT: job notification - success with job 2007-07-13-111303.as130790.ws Message-ID: <200707131229.l6DCTdsN012868@jprt-web.SFBay.Sun.COM> JPRT: job notification - success with job 2007-07-13-111303.as130790.ws JPRT Job ID: 2007-07-13-111303.as130790.ws JPRT System Used: sfbay JPRT Version Used: 08 June 2007 - Name Your Poison Day Job URL: http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-13-111303.as130790.ws User: as130790 Email: modules-dev at openjdk.java.net Release: jdk1.7.0 Job Source: Source Tree: /net/shimmer.sfbay/export/home/jsr277/ws/{make,src} File List: {.} Command Line: jprt submit -stree ../ws -ot '.*product.*' -noquickabort -email modules-dev at openjdk.java.net -rtests '*-*-c2-java/module' -rtests '*-*-c2-sun/module' Job submitted at: Fri-11:13:04-GMT Total time in queue: 1h 16m 35s Job started at: Fri-11:19:03-GMT Job finished at: Fri-12:29:39-GMT Job run time: 1h 10m 36s Job state: success Job flags: Bundles: USE: jprt install 2007-07-13-111303.as130790.ws HINT: Use 'jprt rerun -comment -retest 2007-07-13-111303.as130790.ws' to rerun the tests for this job (you can also add tests with 'jprt rerun'). NOTE: Zip files containing exe or dll files on windows have had problems with execute permissions. You may need to 'chmod a+x' the windows exe and dll files. User Comments: null Build (Release:jdk1.7.0 Boot: Import:): solaris_sparc_5.8-product success(24m 48s elapsed) solaris_sparcv9_5.8-product success(25m 56s elapsed) solaris_i586_5.8-product success(53m 46s elapsed) solaris_x64_5.10-product success(09m 59s elapsed) linux_i586_2.4.9-product success(09m 27s elapsed) linux_x64_2.4.19-product success(12m 56s elapsed) windows_i586_5-product success(35m 13s elapsed) windows_x64_5.2-product success(44m 30s elapsed) Tests: solaris_sparc-product-c2-jvm98 success(02m 29s elapsed) NOTE: Used solaris_sparc_5.10 for above target. solaris_sparcv9-product-c2-jvm98 success(02m 49s elapsed) NOTE: Used solaris_sparc_5.10 for above target. solaris_i586-product-c2-jvm98 success(03m 13s elapsed) linux_i586-product-c2-jvm98 success(01m 45s elapsed) windows_i586-product-c2-jvm98 success(02m 49s elapsed) solaris_x64-product-c2-jvm98 success(01m 57s elapsed) linux_x64-product-c2-jvm98 success(01m 40s elapsed) windows_x64-product-c2-jvm98 success(02m 02s elapsed) solaris_sparc-product-c2-java/module success(03m 31s elapsed) NOTE: Used solaris_sparc_5.10 for above target. solaris_sparcv9-product-c2-java/module success(04m 35s elapsed) solaris_i586-product-c2-java/module success(10m 38s elapsed) linux_i586-product-c2-java/module success(02m 39s elapsed) windows_i586-product-c2-java/module success(05m 37s elapsed) solaris_x64-product-c2-java/module success(01m 48s elapsed) linux_x64-product-c2-java/module success(01m 37s elapsed) windows_x64-product-c2-java/module success(04m 30s elapsed) solaris_sparc-product-c2-sun/module success( 27s elapsed) NOTE: Used solaris_sparc_5.10 for above target. solaris_sparcv9-product-c2-sun/module success( 28s elapsed) NOTE: Used solaris_sparc_5.10 for above target. solaris_i586-product-c2-sun/module success(07m 53s elapsed) linux_i586-product-c2-sun/module success( 35s elapsed) windows_i586-product-c2-sun/module success(02m 55s elapsed) solaris_x64-product-c2-sun/module success( 15s elapsed) linux_x64-product-c2-sun/module success( 18s elapsed) windows_x64-product-c2-sun/module success(02m 42s elapsed) For announcements on downtime and availability join the alias 'jprt-announce at sun.com'. You can see the latest announcements at http://archives.central/tm/browse?jprt-announce. For suspected system problems, send mail to 'jprt-admin at sun.com'. The jprt how to document is available at http://javaweb.sfbay/jdk/jprt/dist/javadoc/jprt/doc-files/how-to.html. From andreas.sterbenz at sun.com Fri Jul 13 06:00:37 2007 From: andreas.sterbenz at sun.com (andreas.sterbenz at sun.com) Date: Fri, 13 Jul 2007 06:00:37 -0700 (PDT) Subject: [modules-dev] Open Bugs/RFEs in java/module Message-ID: <200707131300.l6DD0bk5007175@shimmer.sfbay.sun.com> An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/modules-dev/attachments/20070713/b4b8b426/attachment.html From David.Bristor at Sun.COM Fri Jul 13 11:35:18 2007 From: David.Bristor at Sun.COM (Dave Bristor) Date: Fri, 13 Jul 2007 11:35:18 -0700 Subject: [modules-dev] Review request: 6559092 In-Reply-To: <4696C61A.2020308@sun.com> References: <46942413.2040002@sun.com> <46969C52.2060805@sun.com> <4696A587.6080806@sun.com> <4696A7F3.50309@sun.com> <4696BE6E.5040008@sun.com> <4696C61A.2020308@sun.com> Message-ID: <4697C5E6.804@sun.com> Stanley M. Ho wrote: > > Dave Bristor wrote: > >> I've combined our approaches: no more fake system repository, and a >> flag to ensure setSystemRepository succeeds only once. >> >> I updated the webrev: >> http://javaweb.sfbay/java/jdk/ws/libs/rev/6559092/ > > > Looks good. One last thing, I am not sure if you really need > RepositoryConfig.getParentForSystemRepository() anymore. You could > simply call RepositoryConfig.getSystemRepository() instead and later set > the new one back through RepositoryConfig.setSystemRepository(). That seems reasonable. webrev updated: many more files are changed than last time, but the new changes are merely to effect your suggestion. All tests passing. http://javaweb.sfbay/java/jdk/ws/libs/rev/6559092/ Thanks, Dave > > - Stanley From David.Bristor at Sun.COM Fri Jul 13 14:48:23 2007 From: David.Bristor at Sun.COM (Dave Bristor) Date: Fri, 13 Jul 2007 14:48:23 -0700 Subject: [modules-dev] Initial repository management tool In-Reply-To: <4696AEC8.1050706@sun.com> References: <46955DB8.7080408@sun.com> <4696AEC8.1050706@sun.com> Message-ID: <4697F327.6040008@sun.com> Stanley M. Ho wrote: > Hi Dave, > > Looks like a good start. Several comments inline: > > - src/share/classes/sun/module/tools/ToolBase.java > > 35 public class ToolBase { > > Should be package private. Fixed. > > - src/share/classes/sun/module/tools/JRepo.java > > Remove empty line at #43 and #46. Fixed. > > 76 usage = "Usage: jrepo , where cmd is follows one > of the patterns below"; > > Perhaps "command" instead of "cmd". Fixed. > > 68 private static final Map commands = new > LinkedHashMap(); > 75 if (usage == null) { > 76 usage = "Usage: jrepo , where cmd is follows one > of the patterns below"; > 77 new ListCommand(); > 78 new FindCommand(); > 79 new QueryCommand(); > 80 } > 167 commands.put(name, this); > 168 String u = usage(); > 169 if (u != null) { > 170 usage += "\n\t" + usage(); > 171 } > 330 for (Map.Entry entry : commands.entrySet()) { > 331 if (entry.getKey().startsWith(args[0])) { > 332 cmd = entry.getValue(); > 333 break; > 334 } > 335 } > 416 void usageError() { > 417 error(usage); > 418 } > > I don't like the idea of having the Command constructor to bring side > effect to "usage" and "commands" in the outer class. I think removing > these side effects could simply the code and make it more readable, e.g. > > private state final List commands = new ArrayList(); > ... > commands.add(new ListCommand()); > commands.add(new FindCommand()); > commands.add(new QueryCommand()); > ... > for (Command command : commands) { > if (command.getName().startsWith(args[0])) { > cmd = entry.getValue(); > break; > } > } > ... > private void usageError() { > StringBuilder builder = new StringBuilder(); > builder.append("Usage: jrepo , where command follows one of > the patterns below\n"); > for (Command command : commands) { > builder.append(command.getUsage()); > builder.append("\n"); > } > error(builder.toString()); > } I refactored it all slightly differently, but definitely removed the side-effect-ness. > > 165 abstract class Command { > 223 class ListCommand extends Command { > 261 class FindCommand extends Command { > 303 class QueryCommand extends FindCommand { > > These classes should be private static if possible. private: fixed. static: harder: They're making use of usageError, which is inherited from Toolbase...the output methods in ToolBase depend on being initialized with streams during construction. So for now, just private abstract. > 103 if (repo == null) { > 104 err.println("can't access repository " + > repositoryLocation); > 105 return false; > 106 } > > Is this check really necessary? I would have assumed the method has > already returned if there was exception in #95-#100. Fixed. > I'm surprised we have to configure the metadata directory in the > repository in #139-#145. I think the URLRepository implementation should > do this automatically by default if no metadata directory is specified. If not configured, it will do so automatically. But currently, the automatically determined directory is always the same one, and so might result in inadvertent sharing or other bizarre behavior. Probably, the default directories for the repository classes should be based on temporary names. If that seems right to you, I'll file a bug for it and remove the configuration in JRepo. > > 246 List installed = repo.list(); > 247 for (ModuleArchiveInfo mai : installed) > > Should combine into > > for (ModuleArchiveInfo mai : repo.list()) Fixed. > > 308 String usage() { return null; } > > Should either not override the method, or return usage string specific > for "query". Not really: by explicitly returning null, find and query have the same usage String, provided by find. > The getRepositoryText method looks like something Repository.toString() > should provide. If not, at least we could clean it up as: > > private String getRepositoryText(Repository repo) { > URL u = repo.getSourceLocation(); > if (u == null) { > return "Bootstrap repository"; > } else { > return "Repository " + u.toExternalForm(); > } > } I prefer to avoid multiple returns, hence the current approach. Not a big deal here; I can change it if it's important. Also, I propose to move this method as you suggest, but want to keep that separate fromt he current examination of JRepo. One more thing, I renamed "Curser" to "RepositoryVisitor", and changed the method name recurse -> visit. I just couldn't think of the right name at first! Do you have any suggestions for writing tests? I've written a very basic one for now. Perhaps in the fullness of time, SQE can do a much better job. Webrev updated, includes test http://javaweb.sfbay/java/jdk/ws/libs/rev/6559117/ Thanks, Dave > > That's it for now. > > - Stanley > From Andreas.Sterbenz at Sun.COM Fri Jul 13 15:16:32 2007 From: Andreas.Sterbenz at Sun.COM (Andreas Sterbenz) Date: Fri, 13 Jul 2007 15:16:32 -0700 Subject: [modules-dev] Initial repository management tool In-Reply-To: <4697F327.6040008@sun.com> References: <46955DB8.7080408@sun.com> <4696AEC8.1050706@sun.com> <4697F327.6040008@sun.com> Message-ID: <4697F9C0.8050307@sun.com> Dave Bristor wrote: > > Webrev updated, includes test > > http://javaweb.sfbay/java/jdk/ws/libs/rev/6559117/ Looks fine. Some minor comments: . ToolBase should be declared abstract for clarity JRepo: . DEBUG is true in the webrev . the Boolean.getBoolean() code in the comments can fail if there is a security manager . commands and JRepo constructor: it would seem clearer to me if the code to initialize the static 'commands' Map was in a static initializer rather than under a check in the constructor . it seems a little confusing for the Command constructor to have a side effect of registering the class. Maybe there should be a static register method somewhere that takes a Command object? . getRepository(): wouldn't the fix for the XXX be to do the "new URL()", and if that succeeds, construct a URLRepository; if it throws an Exception, use a LocalRepository? If those constructors fail, propagate the exceptions. . getMAIText(): should this really say "platform?" if platform is null, etc? Rather than an empty string, or "generic", or "n/a"? . the distinction between "list" and "find" (and "query") seems rather subtle. Do we need those as separate commands? Or could module name and version merely be optional parameters? . I assume you are updating make/sun/Makefile to build make/sun/jrepo? Andreas. From David.Bristor at Sun.COM Fri Jul 13 17:23:32 2007 From: David.Bristor at Sun.COM (Dave Bristor) Date: Fri, 13 Jul 2007 17:23:32 -0700 Subject: [modules-dev] Initial repository management tool In-Reply-To: <4697F9C0.8050307@sun.com> References: <46955DB8.7080408@sun.com> <4696AEC8.1050706@sun.com> <4697F327.6040008@sun.com> <4697F9C0.8050307@sun.com> Message-ID: <46981784.2020801@sun.com> Andreas Sterbenz wrote: > Dave Bristor wrote: > >> >> Webrev updated, includes test >> >> http://javaweb.sfbay/java/jdk/ws/libs/rev/6559117/ > > > Looks fine. Some minor comments: > > . ToolBase should be declared abstract for clarity Fixed. > > JRepo: > > . DEBUG is true in the webrev Fixed. > . the Boolean.getBoolean() code in the comments can fail if there is a > security manager Hmm, I had the security manager at one point, anyway it's back now: thanks. > . commands and JRepo constructor: it would seem clearer to me if the > code to initialize the static 'commands' Map was in a static initializer > rather than under a check in the constructor Since Command is not static, a "this" is required for their construction, so they can't be done statically. Command is not static because it makes use of ToolBase.usageError, etc. Perhaps it would be better to have "ToolHelper" (name?), and have JRepo create an instance of it. It's not much of a class and is only valuable *if* we convert Jam.java to also use it. What do you think? I'm starting to tend that way... > . it seems a little confusing for the Command constructor to have a > side effect of registering the class. Maybe there should be a static > register method somewhere that takes a Command object? Fixed. > . getRepository(): wouldn't the fix for the XXX be to do the "new > URL()", and if that succeeds, construct a URLRepository; if it throws an > Exception, use a LocalRepository? If those constructors fail, propagate > the exceptions. I think that's what it does now. If "new URL" fails (e.g. MalformedURLException), we'll try a LocalRepository; similarly if Modules.newURLRepository fails. But I did add a check: if repositoryLocation is not a well-formed URL, and it's not an accessible file, throw an I/O exception immediately. > . getMAIText(): should this really say "platform?" if platform is null, > etc? Rather than an empty string, or "generic", or "n/a"? I like "generic" for platform and arch, if for no other reason than I'm used to it in bugster. Do you have a suggestion for time and file? I kind of want to convey what it is that's unknown. I left them as-is for now, but am open to suggestions. Perhaps it would help if there were column headings? > . the distinction between "list" and "find" (and "query") seems rather > subtle. Do we need those as separate commands? Or could module name and > version merely be optional parameters? I used ruby "gems" as a model, as suggested by Stanley and the EG: http://rubygems.org/read/chapter/2#page3 http://docs.rubygems.org/read/book/2 Gem has separate commands for list vs. query. Unix, etc. have directory listing sepate from directory searching. That's the rationale. Conceptually listing and findind seem separate to me (my $0.02). > . I assume you are updating make/sun/Makefile to build make/sun/jrepo? I'd missed that, thanks for noting it. Webrev updated, thanks for the feedback! Dave > > Andreas. From Andreas.Sterbenz at Sun.COM Fri Jul 13 18:05:46 2007 From: Andreas.Sterbenz at Sun.COM (Andreas Sterbenz) Date: Fri, 13 Jul 2007 18:05:46 -0700 Subject: [modules-dev] Initial repository management tool In-Reply-To: <46981784.2020801@sun.com> References: <46955DB8.7080408@sun.com> <4696AEC8.1050706@sun.com> <4697F327.6040008@sun.com> <4697F9C0.8050307@sun.com> <46981784.2020801@sun.com> Message-ID: <4698216A.50206@sun.com> Dave Bristor wrote: > >> . the Boolean.getBoolean() code in the comments can fail if there is >> a security manager > > Hmm, I had the security manager at one point, anyway it's back now: thanks. Right. It would only fail if there is unprivileged code on the stack, i.e. not when started from the command line but potentially in the future when/if we support invocation via something like the JSR 199 Tools API. >> . commands and JRepo constructor: it would seem clearer to me if the >> code to initialize the static 'commands' Map was in a static >> initializer rather than under a check in the constructor > > Since Command is not static, a "this" is required for their > construction, so they can't be done statically. Command is not static > because it makes use of ToolBase.usageError, etc. Perhaps it would be > better to have "ToolHelper" (name?), and have JRepo create an instance > of it. It's not much of a class and is only valuable *if* we convert > Jam.java to also use it. What do you think? I'm starting to tend that > way... I see. I don't have any clever suggestions right now. We can figure that out later. >> . getMAIText(): should this really say "platform?" if platform is >> null, etc? Rather than an empty string, or "generic", or "n/a"? > > I like "generic" for platform and arch, if for no other reason than I'm > used to it in bugster. Do you have a suggestion for time and file? I > kind of want to convey what it is that's unknown. I left them as-is for > now, but am open to suggestions. Perhaps it would help if there were > column headings? For time and file, I can imagine "n/a", "-", or "" (leaving it blank). Column headings would seem useful. >> . the distinction between "list" and "find" (and "query") seems >> rather subtle. Do we need those as separate commands? Or could module >> name and version merely be optional parameters? > > I used ruby "gems" as a model, as suggested by Stanley and the EG: > http://rubygems.org/read/chapter/2#page3 > http://docs.rubygems.org/read/book/2 > Gem has separate commands for list vs. query. Unix, etc. have directory > listing sepate from directory searching. That's the rationale. > Conceptually listing and findind seem separate to me (my $0.02). Well, I use "ls" both to list all files and to list ("find") a particular file: # ls -l # ls -l JRepo.java # ls -l *.java Unix find serves a different purpose. I use it when I need to use its more complex options (-type, -perm, -mtime, etc) or to search for something in a large directory hierarchy. The current JRepo "list" and "find" don't have that those differences and there is no conflict in their options, so I am not sure what the advantage of keeping them separate is. FWIW, "gem list" also supports listing modules with a given name. Andreas. From forax at univ-mlv.fr Sat Jul 14 02:01:37 2007 From: forax at univ-mlv.fr (=?ISO-8859-1?Q?R=E9mi_Forax?=) Date: Sat, 14 Jul 2007 11:01:37 +0200 Subject: [modules-dev] Initial repository management tool In-Reply-To: <4698216A.50206@sun.com> References: <46955DB8.7080408@sun.com> <4696AEC8.1050706@sun.com> <4697F327.6040008@sun.com> <4697F9C0.8050307@sun.com> <46981784.2020801@sun.com> <4698216A.50206@sun.com> Message-ID: <469890F1.2050809@univ-mlv.fr> Andreas Sterbenz a ?crit : > Dave Bristor wrote: > >>> . the Boolean.getBoolean() code in the comments can fail if there is >>> a security manager >>> >> Hmm, I had the security manager at one point, anyway it's back now: thanks. >> > > Right. It would only fail if there is unprivileged code on the stack, i.e. > not when started from the command line but potentially in the future > when/if we support invocation via something like the JSR 199 Tools API. > > >>> . commands and JRepo constructor: it would seem clearer to me if the >>> code to initialize the static 'commands' Map was in a static >>> initializer rather than under a check in the constructor >>> >> Since Command is not static, a "this" is required for their >> construction, so they can't be done statically. Command is not static >> because it makes use of ToolBase.usageError, etc. Perhaps it would be >> better to have "ToolHelper" (name?), and have JRepo create an instance >> of it. It's not much of a class and is only valuable *if* we convert >> Jam.java to also use it. What do you think? I'm starting to tend that >> way... >> > > I see. I don't have any clever suggestions right now. We can figure that > out later. > if commands are static, you could declare Command as an interface and all the commands in an enum that implements this interface and "inject" the ToolHelper (or JRepo) as a parameter of the usage method. interface Command { void usage(ToolHelper helper); } enum JRepoCommand implements Command { public usage(ToolHelper helper) { ... } } ... > Andreas. > > _______________________________________________ > modules-dev mailing list > modules-dev at openjdk.java.net > http://mail.openjdk.java.net/mailman/listinfo/modules-dev > R?mi From andreas.sterbenz at sun.com Mon Jul 16 06:00:26 2007 From: andreas.sterbenz at sun.com (andreas.sterbenz at sun.com) Date: Mon, 16 Jul 2007 06:00:26 -0700 (PDT) Subject: [modules-dev] Open Bugs/RFEs in java/module Message-ID: <200707161300.l6GD0QiY026978@shimmer.sfbay.sun.com> An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/modules-dev/attachments/20070716/58c70f43/attachment.html From andreas.sterbenz at sun.com Tue Jul 17 06:00:11 2007 From: andreas.sterbenz at sun.com (andreas.sterbenz at sun.com) Date: Tue, 17 Jul 2007 06:00:11 -0700 (PDT) Subject: [modules-dev] Open Bugs/RFEs in java/module Message-ID: <200707171300.l6HD0B1W007309@shimmer.sfbay.sun.com> An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/modules-dev/attachments/20070717/aa6d91f1/attachment.html From db13166 at pasilla.SFBay.Sun.COM Tue Jul 17 16:43:45 2007 From: db13166 at pasilla.SFBay.Sun.COM (David Bristor) Date: Tue, 17 Jul 2007 16:43:45 -0700 (PDT) Subject: [modules-dev] Code Manager notification (putback-to) Message-ID: <200707172343.l6HNhjKC004443@pasilla.SFBay.Sun.COM> Event: putback-to Parent workspace: /net/shimmer.sfbay/export/home/jsr277/ws (shimmer.sfbay:/export/home/jsr277/ws) Child workspace: /data/ws/db-jam (pasilla:/data/ws/db-jam) User: db13166 Comment: 6559092 (repo) Repository.getSystemRepository() must never be null [stanley.ho] Files: update: src/share/classes/sun/module/ModuleLauncher.java update: src/share/classes/sun/module/repository/RepositoryConfig.java update: test/java/module/modinit/RunMTest.java update: test/java/module/repository/Test6574851.java update: test/java/module/repository/Test6574852.java update: test/java/module/repository/LocalRepositoryTest.java update: test/java/module/repository/URLRepositoryTest.java update: test/java/module/repository/VisibilityPolicyTest.java update: test/sun/module/repository/RepositoryTest.java Examined files: 9 Contents Summary: 9 update From jprtadm at jprt-web.SFBay.Sun.COM Tue Jul 17 18:28:37 2007 From: jprtadm at jprt-web.SFBay.Sun.COM (JPRT Administrator) Date: Tue, 17 Jul 2007 18:28:37 -0700 (PDT) Subject: [modules-dev] JPRT: job notification - success with job 2007-07-17-234638.daemon.ws Message-ID: <200707180128.l6I1Sb73008400@jprt-web.SFBay.Sun.COM> JPRT: job notification - success with job 2007-07-17-234638.daemon.ws JPRT Job ID: 2007-07-17-234638.daemon.ws JPRT System Used: sfbay JPRT Version Used: 17 July 2007 - Yellow Pig Day Job URL: http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-17-234638.daemon.ws User: daemon Email: modules-dev at openjdk.java.net Release: jdk1.7.0 Job Source: Source Tree: /net/shimmer.sfbay/export/home/jsr277/ws/{make,src} File List: {.} Command Line: jprt submit -stree ../ws -ot '.*linux_i586.*product.*' -noquickabort -email modules-dev at openjdk.java.net -rtests '*-*-c2-java/module' -rtests '*-*-c2-sun/module' Job submitted at: Tue-23:46:38-GMT Total time in queue: 1h 41m 58s Job started at: Wed-01:15:22-GMT Job finished at: Wed-01:28:36-GMT Job run time: 13m 14s Job state: success Job flags: Bundles: USE: jprt install 2007-07-17-234638.daemon.ws HINT: Use 'jprt rerun -comment -retest 2007-07-17-234638.daemon.ws' to rerun the tests for this job (you can also add tests with 'jprt rerun'). NOTE: Zip files containing exe or dll files on windows have had problems with execute permissions. You may need to 'chmod a+x' the windows exe and dll files. User Comments: null Build (Release:jdk1.7.0 Boot: Import:): linux_i586_2.4.9-product success(11m 54s elapsed) For announcements on downtime and availability join the alias 'jprt-announce at sun.com'. You can see the latest announcements at http://archives.central/tm/browse?jprt-announce. For suspected system problems, send mail to 'jprt-admin at sun.com'. The jprt how to document is available at http://javaweb.sfbay/jdk/jprt/dist/javadoc/jprt/doc-files/how-to.html. From jprtadm at jprt-web.SFBay.Sun.COM Wed Jul 18 05:14:02 2007 From: jprtadm at jprt-web.SFBay.Sun.COM (JPRT Administrator) Date: Wed, 18 Jul 2007 05:14:02 -0700 (PDT) Subject: [modules-dev] JPRT: job notification - success with job 2007-07-18-111303.as130790.ws Message-ID: <200707181214.l6ICE26r008801@jprt-web.SFBay.Sun.COM> JPRT: job notification - success with job 2007-07-18-111303.as130790.ws JPRT Job ID: 2007-07-18-111303.as130790.ws JPRT System Used: sfbay JPRT Version Used: 17 July 2007 - Yellow Pig Day Job URL: http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-18-111303.as130790.ws User: as130790 Email: modules-dev at openjdk.java.net Release: jdk1.7.0 Job Source: Source Tree: /net/shimmer.sfbay/export/home/jsr277/ws/{make,src} File List: {.} Command Line: jprt submit -stree ../ws -ot '.*product.*' -noquickabort -email modules-dev at openjdk.java.net -rtests '*-*-c2-java/module' -rtests '*-*-c2-sun/module' Job submitted at: Wed-11:13:03-GMT Total time in queue: 1h 59s Job started at: Wed-11:18:26-GMT Job finished at: Wed-12:14:02-GMT Job run time: 55m 36s Job state: success Job flags: Bundles: USE: jprt install 2007-07-18-111303.as130790.ws HINT: Use 'jprt rerun -comment -retest 2007-07-18-111303.as130790.ws' to rerun the tests for this job (you can also add tests with 'jprt rerun'). NOTE: Zip files containing exe or dll files on windows have had problems with execute permissions. You may need to 'chmod a+x' the windows exe and dll files. User Comments: null Build (Release:jdk1.7.0 Boot: Import:): solaris_sparc_5.8-product success(24m 48s elapsed) solaris_sparcv9_5.8-product success(25m 52s elapsed) solaris_i586_5.8-product success(54m 11s elapsed) solaris_x64_5.10-product success(10m 18s elapsed) linux_i586_2.4.9-product success(11m 39s elapsed) linux_x64_2.4.19-product success(13m 43s elapsed) windows_i586_5-product success(37m 26s elapsed) windows_x64_5.2-product success(44m 21s elapsed) For announcements on downtime and availability join the alias 'jprt-announce at sun.com'. You can see the latest announcements at http://archives.central/tm/browse?jprt-announce. For suspected system problems, send mail to 'jprt-admin at sun.com'. The jprt how to document is available at http://javaweb.sfbay/jdk/jprt/dist/javadoc/jprt/doc-files/how-to.html. From andreas.sterbenz at sun.com Wed Jul 18 06:02:10 2007 From: andreas.sterbenz at sun.com (andreas.sterbenz at sun.com) Date: Wed, 18 Jul 2007 06:02:10 -0700 (PDT) Subject: [modules-dev] Open Bugs/RFEs in java/module Message-ID: <200707181302.l6ID2A6S025060@shimmer.sfbay.sun.com> An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/modules-dev/attachments/20070718/d4c63079/attachment.html From David.Bristor at Sun.COM Wed Jul 18 16:25:17 2007 From: David.Bristor at Sun.COM (Dave Bristor) Date: Wed, 18 Jul 2007 16:25:17 -0700 Subject: [modules-dev] Review request: 6560281 Message-ID: <469EA15D.4000609@sun.com> Hi folks, This change provides the means to have repositories configured & created. bugster: http://monaco.sfbay/detail.jsf?cr=6560281 webrev: http://javaweb.sfbay/java/jdk/ws/libs/rev/6560281/ The bulk of the interesting work is in RepositoryConfig.java. Changes in Modules.java and URLRepository.java are largely to get rid of initialize(Map) and instead do initialization during construction; this is similar to what was done in fixing 6559071 (see http://javaweb.sfbay/java/jdk/ws/libs/rev/6559065%2b6559071%2b6559075). In earlier review discussion (attached) we'd agreed to remove Repository.initialize(Map) when this repository configuration work was done. That had a ripple effect, since Repository.initialize() invoked it. Some classes now have the latter, e.g. BootstrapRepository. The changes include a separate fix proposed by Stanley: in LocalRepository, I removed the code in constructors which caused an IOException to be ignored. RepositoryConfigTest is "reasonable" but there are other interesting cases to test; I've noted a couple in the testcase itself. Should I/we be filing bugs for testcases we'd like to write? Tests passing, javadoc looks good. Thanks, Dave -------------- next part -------------- An embedded message was scrubbed... From: "Stanley M. Ho" Subject: Re: Review request for 6559065, 6559071, 6559075 Date: Thu, 07 Jun 2007 12:05:01 -0700 Size: 2360 Url: http://mail.openjdk.java.net/pipermail/modules-dev/attachments/20070718/4b0f1a0b/attachment.mht From andreas.sterbenz at sun.com Thu Jul 19 06:00:27 2007 From: andreas.sterbenz at sun.com (andreas.sterbenz at sun.com) Date: Thu, 19 Jul 2007 06:00:27 -0700 (PDT) Subject: [modules-dev] Open Bugs/RFEs in java/module Message-ID: <200707191300.l6JD0RgS026381@shimmer.sfbay.sun.com> An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/modules-dev/attachments/20070719/66f76451/attachment.html From Stanley.Ho at Sun.COM Thu Jul 19 12:25:23 2007 From: Stanley.Ho at Sun.COM (Stanley M. Ho) Date: Thu, 19 Jul 2007 12:25:23 -0700 Subject: [modules-dev] Review request: 6560281 In-Reply-To: <469EA15D.4000609@sun.com> References: <469EA15D.4000609@sun.com> Message-ID: <469FBAA3.7060705@sun.com> Hi Dave, Looks good. Several comments inline: - src/share/classes/sun/module/repository/RepositoryConfig.java 87 *
  • user.home/.java/repository/repository.properties
  • 88 *
  • $java.home/lib/repository/repository.properties
  • As we discussed before, because the user-specific configuration would be picked up by different versions of the JRE the user is running, it is unclear to me if merging the settings in these configurations files is really what we want, especially if the settings in these files could be in conflict. If we want to support multiple files, I think it is more reasonable for user to provide a custom repository.properties file that tells the module system to construct additional repositories from the furthest repository created in the JRE's repository.properties file, and set the resulting furthest repository as the system repository. It might also be reasonable for user to specify a specific repository.properties that completely overrides the JRE's repository.properties. You will find similar logic implemented in src/share/classes/sun/module/config/ModuleSystemConfig. For the JRE specific configuration, it should live under {java.home}/lib/module/repository.properties. I suggest you should also have a default repository.properties file checked into the workspace, see src/share/lib/module/*. 100 static { The calls to System.getProperty() should be in doPrivileged() block. Because of the nature of class initialization, this could fail if untrusted code is on the stack. 174 public static Repository configRepositories() throws RuntimeException { Should be private. 177 // XXX Should repeated configRepositories throw exception? 178 // XXX Log subsequent setup attempts. Why would this being called more than once? Should throw exception. 191 // XXX nonexistent/unreadable config file: log message? throw exception? The {java.home}/lib/module/repository.properties file should always exists. If not, exception should be thrown. 231 * If no CLASS is given, then if the SOURCE value is a URL, a 232 * URLRepository will be created; else if the SOURCE is an existing, 233 * readable file, a LocalRepository will be created. The content of the JRE's default repository configuration file will be pretty much the same under all platforms, hence the source location will be in the form of URL. This implies that only URLRepository could be created in our default configuration. While URLRepository has advantages, there are several repositories we definitely need to create using LocalRepository, e.g. the global repository and the user repository. #344 - #353 demonstrates this issue clearly. I think we need a better way to indicate whether it's LocalRepository or URLRepository that we want to create. Perhaps we need to support something like TYPE. 374 // XXX Throw exception, or ignore and presume "user knows best"? Throw exception. - src/share/classes/sun/module/repository/LocalRepository.java 185 public synchronized void initialize(Map config) throws IOException { Should be private. - src/share/classes/sun/module/repository/URLRepository.java 283 public synchronized void initialize(Map config) throws IOException { Should be private. - src/share/classes/java/module/Modules.java The javadoc needs to be updated to describe the exceptions. I will take care of this when I make other API changes later. For the test cases, you might want to check out the tests for the visibility policy and import override policy in test/java/module/config/*. Because the repository.properties file is basically a regular property file, you probably don't really need a lot of tests around the file format. The focus should be to make sure the code handles the repository chain construction properly in various situations, including: 1. Well-formed repository chain 2. Repository that has unknown parent 3. Dangling repository that is not under the main repository chain 4. Multiple furthest repositories That's it for now. - Stanley From as130790 at shimmer.sfbay.sun.com Thu Jul 19 13:07:52 2007 From: as130790 at shimmer.sfbay.sun.com (Andreas Sterbenz) Date: Thu, 19 Jul 2007 13:07:52 -0700 (PDT) Subject: [modules-dev] Code Manager notification (putback-to) Message-ID: <200707192007.l6JK7qro000097@shimmer.sfbay.sun.com> Event: putback-to Parent workspace: /net/shimmer.sfbay/export/home/jsr277/ws (shimmer:/net/shimmer.sfbay/export/home/jsr277/ws) Child workspace: /net/shimmer.sfbay/export/home/as130790/277-merge/ws (shimmer:/net/shimmer.sfbay/export/home/as130790/277-merge/ws) User: as130790 Comment: Sync with TL Files: update: make/com/sun/corba/minclude/com_sun_corba_se_PortableActivationIDL.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_impl_activation.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_impl_corba.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_impl_core.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_impl_dynamicany.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_impl_encoding.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_impl_interceptors.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_impl_io.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_impl_ior.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_impl_legacy.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_impl_logging.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_impl_monitoring.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_impl_naming_cosnaming.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_impl_naming_namingutil.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_impl_naming_pcosnaming.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_impl_oa_poa.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_impl_oa_toa.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_impl_orb.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_impl_orbutil.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_impl_presentation_rmi.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_impl_protocol.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_impl_resolver.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_impl_transport.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_impl_util.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_internal_LegacyFiles.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_pept.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_spi_activation.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_spi_copyobject.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_spi_encoding.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_spi_extension.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_spi_ior.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_spi_legacy_connection.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_spi_legacy_interceptor.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_spi_logging.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_spi_monitoring.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_spi_oa.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_spi_orb.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_spi_orbutil.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_spi_presentation_rmi.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_spi_protocol.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_spi_resolver.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_spi_servicecontext.jmk update: make/com/sun/corba/minclude/com_sun_corba_se_spi_transport.jmk update: make/com/sun/corba/minclude/com_sun_tools_corba_se_idl_toJavaPortable.jmk update: make/com/sun/corba/minclude/ioser_io.jmk update: make/com/sun/corba/minclude/javax_activity.jmk update: make/com/sun/corba/minclude/javax_rmi.jmk update: make/com/sun/corba/minclude/javax_rmi_CORBA.jmk update: make/com/sun/corba/minclude/javax_transaction.jmk update: make/com/sun/corba/minclude/org_omg_CORBA.jmk update: make/com/sun/corba/minclude/org_omg_CORBAX.jmk update: make/com/sun/corba/minclude/org_omg_CORBA_2_3.jmk update: make/com/sun/corba/minclude/org_omg_CosNaming.jmk update: make/com/sun/corba/minclude/org_omg_DynamicAny.jmk update: make/com/sun/corba/minclude/org_omg_IOP.jmk update: make/com/sun/corba/minclude/org_omg_Messaging.jmk update: make/com/sun/corba/minclude/org_omg_PortableInterceptor.jmk update: make/com/sun/corba/minclude/org_omg_PortableServer.jmk update: make/com/sun/corba/minclude/org_omg_SendingContext.jmk update: make/com/sun/corba/minclude/sun_corba.jmk update: make/com/sun/corba/se/connection/FILES_java.gmk update: make/com/sun/corba/se/interceptor/FILES_java.gmk update: make/com/sun/corba/se/rmi/rmic/SUN_RMI_RMIC_IIOP_java.gmk update: make/com/sun/corba/se/rmi/rmic/SUN_RMI_RMIC_java.gmk update: make/com/sun/java/pack/FILES_cpp.gmk update: make/com/sun/java/pack/Makefile update: make/com/sun/security/auth/FILES_java.gmk update: make/com/sun/security/auth/module/FILES_c_solaris.gmk update: make/com/sun/security/auth/module/FILES_c_unix.gmk update: make/com/sun/security/auth/module/FILES_c_windows.gmk update: make/com/sun/security/auth/module/FILES_export_solaris.gmk update: make/com/sun/security/auth/module/FILES_export_unix.gmk update: make/com/sun/security/auth/module/FILES_export_windows.gmk update: make/com/sun/security/auth/module/FILES_java.gmk update: make/com/sun/sql/FILES_java.gmk update: make/com/sun/tools/attach/FILES_java.gmk update: make/common/Defs.gmk update: make/common/Release.gmk update: make/common/Rules.gmk update: make/java/fdlibm/FILES_c.gmk update: make/java/hpi/hpi_common.gmk update: make/java/hpi/native/Makefile update: make/java/hpi/windows/Makefile update: make/java/java/FILES_c.gmk update: make/java/java/FILES_java.gmk update: make/java/java/Makefile update: make/java/java_crw_demo/Makefile update: make/java/java_hprof_demo/Makefile update: make/java/jli/Makefile update: make/java/management/Makefile update: make/java/net/FILES_c.gmk update: make/java/net/Makefile update: make/java/npt/Makefile update: make/java/sun_nio/FILES_java.gmk update: make/java/text/FILES_java.gmk update: make/java/util/FILES_java.gmk update: make/java/util/FILES_properties.gmk update: make/java/zip/FILES_c.gmk update: make/java/zip/FILES_java.gmk update: make/javax/sound/FILES_c.gmk update: make/javax/sound/SoundDefs.gmk update: make/javax/sound/jsoundalsa/Makefile update: make/javax/sound/jsoundds/Makefile update: make/jpda/back/Makefile update: make/jpda/transport/shmem/Makefile update: make/jpda/transport/socket/Makefile update: make/mkdemo/jfc/CodePointIM/FILES.gmk update: make/mkdemo/jfc/Font2DTest/FILES.gmk update: make/mkdemo/jfc/Java2D/FILES.gmk update: make/mkdemo/jvmti/Demo.gmk update: make/mkdemo/jvmti/gctest/Makefile update: make/mkdemo/jvmti/heapTracker/Makefile update: make/mkdemo/jvmti/heapViewer/Makefile update: make/mkdemo/jvmti/minst/Makefile update: make/mkdemo/jvmti/mtrace/Makefile update: make/mkdemo/jvmti/versionCheck/Makefile update: make/mkdemo/jvmti/waiters/Makefile update: make/mkdemo/sound/FILES.gmk update: make/org/ietf/jgss/FILES_java.gmk update: make/org/omg/CORBAX_java.gmk update: make/org/omg/idl/FILES_java.gmk update: make/sun/awt/FILES_c_unix.gmk update: make/sun/awt/FILES_c_windows.gmk update: make/sun/awt/Makefile update: make/sun/awt/mawt.gmk update: make/sun/cmm/kcms/FILES_c_unix.gmk update: make/sun/cmm/kcms/FILES_c_windows.gmk update: make/sun/cmm/lcms/FILES_c_unix.gmk update: make/sun/cmm/lcms/FILES_c_windows.gmk update: make/sun/corba/org/omg/FILES_java.gmk update: make/sun/dcpr/FILES_c.gmk update: make/sun/font/FILES_c.gmk update: make/sun/font/t2k/FILES_c.gmk update: make/sun/javac/javac/FILES_java.gmk update: make/sun/javac/recompile/library/Makefile update: make/sun/jawt/Makefile update: make/sun/jconsole/FILES.gmk update: make/sun/jpeg/FILES_c.gmk update: make/sun/net/FILES_java.gmk update: make/sun/nio/FILES_java.gmk update: make/sun/rmi/cgi/Makefile update: make/sun/rmi/oldtools/FILES_java.gmk update: make/sun/rmi/rmi/Makefile update: make/sun/rmi/rmic/FILES.gmk update: make/sun/security/jgss/wrapper/FILES_c.gmk update: make/sun/security/krb5/FILES_c_windows.gmk update: make/sun/security/mscapi/FILES_cpp.gmk update: make/sun/security/pkcs11/FILES_c.gmk update: make/sun/security/pkcs11/Makefile update: make/sun/security/smartcardio/FILES_c.gmk update: make/sun/splashscreen/FILES_c.gmk update: make/sun/splashscreen/Makefile update: make/sun/text/FILES_java.gmk update: make/sun/text/FILES_properties.gmk update: make/sun/xawt/FILES_c_unix.gmk update: make/sun/xawt/Makefile update: make/sun/xjc/FILES.gmk update: make/tools/GenerateCurrencyData/GenerateCurrencyData.java update: make/tools/reorder/JarReorder.java update: src/share/back/ThreadReferenceImpl.c update: src/share/back/util.c update: src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java update: src/share/classes/com/sun/tools/javac/resources/compiler.properties update: src/share/classes/java/io/ObjectInputStream.java update: src/share/classes/java/lang/Integer.java update: src/share/classes/java/lang/Long.java update: src/share/classes/java/lang/Process.java update: src/share/classes/java/lang/Thread.java update: src/share/classes/java/security/SecureRandom.java update: src/share/classes/java/text/StringCharacterIterator.java update: src/share/classes/java/util/AbstractList.java update: src/share/classes/java/util/Arrays.java update: src/share/classes/java/util/BitSet.java update: src/share/classes/java/util/Collections.java update: src/share/classes/java/util/Currency.java update: src/share/classes/java/util/CurrencyData.properties update: src/share/classes/java/util/Formatter.java update: src/share/classes/java/util/List.java update: src/share/classes/java/util/ResourceBundle.java update: src/share/classes/java/util/WeakHashMap.java update: src/share/classes/java/util/concurrent/CopyOnWriteArrayList.java update: src/share/classes/java/util/concurrent/atomic/AtomicLong.java update: src/share/classes/java/util/concurrent/locks/ReentrantReadWriteLock.java update: src/share/classes/java/util/spi/CurrencyNameProvider.java update: src/share/classes/javax/management/modelmbean/ModelMBeanAttributeInfo.java update: src/share/classes/javax/management/modelmbean/ModelMBeanConstructorInfo.java update: src/share/classes/javax/management/modelmbean/ModelMBeanInfo.java update: src/share/classes/javax/management/modelmbean/ModelMBeanInfoSupport.java update: src/share/classes/javax/management/modelmbean/ModelMBeanNotificationInfo.java update: src/share/classes/javax/management/modelmbean/ModelMBeanOperationInfo.java update: src/share/classes/sun/jvmstat/monitor/MonitoredVmUtil.java update: src/share/classes/sun/net/www/protocol/http/NegotiatorImpl.java update: src/share/classes/sun/security/jca/ProviderConfig.java update: src/share/classes/sun/security/jca/Providers.java update: src/share/classes/sun/security/jgss/krb5/InitialToken.java update: src/share/classes/sun/security/jgss/krb5/Krb5Context.java update: src/share/classes/sun/security/jgss/spnego/SpNegoContext.java update: src/share/classes/sun/security/krb5/Credentials.java update: src/share/classes/sun/security/krb5/KrbCred.java update: src/share/classes/sun/security/krb5/KrbTgsReq.java update: src/share/classes/sun/security/krb5/internal/CredentialsUtil.java update: src/share/classes/sun/security/provider/SeedGenerator.java update: src/share/classes/sun/security/util/ManifestEntryVerifier.java update: src/share/classes/sun/tools/attach/HotSpotAttachProvider.java update: src/share/classes/sun/util/LocaleServiceProviderPool.java update: src/share/classes/sun/util/resources/CurrencyNames.properties update: src/share/classes/sun/util/resources/CurrencyNames_zh_CN.properties update: src/share/classes/sun/util/resources/CurrencyNames_zh_TW.properties update: src/share/classes/sun/util/resources/LocaleData.java update: src/share/javavm/export/jvm.h update: src/share/native/com/sun/java/util/jar/pack/jni.cpp update: src/share/native/common/jni_util.h update: src/solaris/classes/java/lang/ProcessImpl.java update: src/solaris/classes/sun/tools/attach/LinuxAttachProvider.java update: src/solaris/classes/sun/tools/attach/SolarisAttachProvider.java update: src/windows/classes/sun/tools/attach/WindowsAttachProvider.java update: src/windows/native/sun/tools/attach/WindowsVirtualMachine.c update: test/closed/java/lang/Byte/Decode.java update: test/closed/java/lang/Integer/Decode.java update: test/closed/java/lang/Integer/ParsingTest.java update: test/closed/java/lang/Long/Decode.java update: test/closed/java/lang/Long/ParsingTest.java update: test/closed/java/lang/Short/Decode.java update: test/closed/javax/management/security/ClassInstantiationTest.java update: test/java/lang/ProcessBuilder/Basic.java update: test/java/util/Collection/MOAT.java update: test/java/util/Currency/CheckDataVersion.java update: test/java/util/Currency/CurrencyTest.java update: test/java/util/Currency/ValidateISO4217.java update: test/java/util/Currency/tablea1.txt update: test/java/util/Formatter/Basic-X.java update: test/java/util/Formatter/Basic.java update: test/java/util/Formatter/BasicBigDecimal.java update: test/java/util/Formatter/BasicBigInteger.java update: test/java/util/Formatter/BasicBoolean.java update: test/java/util/Formatter/BasicBooleanObject.java update: test/java/util/Formatter/BasicByte.java update: test/java/util/Formatter/BasicByteObject.java update: test/java/util/Formatter/BasicChar.java update: test/java/util/Formatter/BasicCharObject.java update: test/java/util/Formatter/BasicDouble.java update: test/java/util/Formatter/BasicDoubleObject.java update: test/java/util/Formatter/BasicFloat.java update: test/java/util/Formatter/BasicFloatObject.java update: test/java/util/Formatter/BasicInt.java update: test/java/util/Formatter/BasicIntObject.java update: test/java/util/Formatter/BasicLong.java update: test/java/util/Formatter/BasicLongObject.java update: test/java/util/Formatter/BasicShort.java update: test/java/util/Formatter/BasicShortObject.java update: test/java/util/Formatter/genBasic.sh update: test/java/util/PluggableLocale/CurrencyNameProviderTest.java update: test/java/util/PluggableLocale/barprovider.jar update: test/java/util/PluggableLocale/fooprovider.jar update: test/java/util/PluggableLocale/providersrc/CurrencyNameProviderImpl.java update: test/javax/management/descriptor/MBeanInfoInteropTest.java update: test/tools/javac/4846262/Test.sh update: test/tools/javac/6302184/T6302184.sh update: test/tools/javac/ClassPathTest/ClassPathTest.sh update: test/tools/javac/ExtDirs/ExtDirs.sh update: test/tools/javac/ExtendsAccess/ExtendsAccess.sh update: test/tools/javac/FloatingPointChanges/BadConstructorModifiers.sh update: test/tools/javac/Paths/Class-Path.sh update: test/tools/javac/Paths/Diagnostics.sh update: test/tools/javac/Paths/Help.sh update: test/tools/javac/Paths/MineField.sh update: test/tools/javac/Paths/Util.sh update: test/tools/javac/Paths/wcMineField.sh update: test/tools/javac/ProtectedInnerClass/ProtectedInnerClass.sh update: test/tools/javac/QualifiedAccess/QualifiedAccess_1.sh update: test/tools/javac/QualifiedAccess/QualifiedAccess_2.sh update: test/tools/javac/QualifiedAccess/QualifiedAccess_3.sh update: test/tools/javac/CyclicInheritance.sh update: test/tools/javac/InnerNamedConstant_2.sh update: test/tools/javac/LocalClasses_2.sh update: test/tools/javac/MissingInclude.sh update: test/tools/javac/NameCollision.sh update: test/tools/javac/NestedInnerClassNames.sh update: test/tools/javac/NonStaticFieldExpr1.sh update: test/tools/javac/NonStaticFieldExpr2.sh update: test/tools/javac/NonStaticFieldExpr3.sh update: test/tools/javac/SynchronizedClass.sh update: test/tools/javac/apt.sh update: test/tools/javac/versionOpt.sh update: test/tools/javac/T5090006/compiler.sh update: test/tools/javac/code/ArrayClone.sh update: test/tools/javac/constDebug/ConstDebug.sh update: test/tools/javac/depDocComment/DeprecatedDocComment.sh update: test/tools/javac/fatalErrors/NoJavaLang.sh update: test/tools/javac/innerClassFile/Driver.sh update: test/tools/javac/javazip/Test.sh update: test/tools/javac/links/links.sh update: test/tools/javac/newlines/Newlines.sh update: test/tools/javac/stackmap/T4955930.sh update: test/tools/javac/unicode/SupplementaryJavaID6.sh update: test/tools/javac/versions/check.sh rename from: test/java/util/Formatter/BasicDate.java to: deleted_files/test/java/util/Formatter/BasicDate.java update: src/share/classes/sun/security/provider/SunEntries.java rename from: src/share/classes/sun/security/provider/Sun.java to: src/share/classes/sun/security/provider/SunEntries.java create: src/share/classes/sun/security/provider/Sun.java create: src/share/classes/sun/security/provider/VerificationProvider.java update: src/share/classes/sun/security/rsa/SunRsaSignEntries.java rename from: src/share/classes/sun/security/rsa/SunRsaSign.java to: src/share/classes/sun/security/rsa/SunRsaSignEntries.java create: src/share/classes/sun/security/rsa/SunRsaSign.java create: src/share/classes/sun/util/resources/CurrencyNames_de.properties create: src/share/classes/sun/util/resources/CurrencyNames_es.properties create: src/share/classes/sun/util/resources/CurrencyNames_fr.properties create: src/share/classes/sun/util/resources/CurrencyNames_it.properties create: src/share/classes/sun/util/resources/CurrencyNames_ja.properties create: src/share/classes/sun/util/resources/CurrencyNames_ko.properties create: src/share/classes/sun/util/resources/CurrencyNames_sv.properties update: src/share/classes/sun/util/resources/CurrencyNames_zh_HK.java rename from: src/share/classes/sun/util/resources/CurrencyNames_zh_HK.properties to: src/share/classes/sun/util/resources/CurrencyNames_zh_HK.java update: src/share/classes/sun/util/resources/CurrencyNames_zh_SG.java rename from: src/share/classes/sun/util/resources/CurrencyNames_zh_SG.properties to: src/share/classes/sun/util/resources/CurrencyNames_zh_SG.java create: test/java/io/Serializable/NPEProvoker/NPEProvoker.java create: test/java/util/BitSet/ImportExport.java create: test/java/util/Currency/PropertiesTest.java create: test/java/util/Currency/PropertiesTest.sh create: test/java/util/Currency/currency.properties update: test/java/util/Formatter/BasicDateTime.java rename from: test/java/util/Formatter/BasicCalendar.java to: test/java/util/Formatter/BasicDateTime.java create: test/java/util/ResourceBundle/Bug6572242.java create: test/java/util/ResourceBundle/bug6572242.properties create: test/java/util/WeakHashMap/GCDuringIteration.java create: test/javax/management/modelmbean/DefaultDescriptorFieldTest.java Examined files: 38483 Contents Summary: 19 create 301 update 38163 no action (unchanged) Names Summary: 6 renamed 1 update parent's name history From jprtadm at jprt-web.SFBay.Sun.COM Thu Jul 19 14:04:58 2007 From: jprtadm at jprt-web.SFBay.Sun.COM (JPRT Administrator) Date: Thu, 19 Jul 2007 14:04:58 -0700 (PDT) Subject: [modules-dev] JPRT: job notification - FAILED with job 2007-07-19-200756.daemon.ws Message-ID: <200707192104.l6JL4wli009727@jprt-web.SFBay.Sun.COM> JPRT: job notification - FAILED with job 2007-07-19-200756.daemon.ws Failure reason: Build target failure: linux_i586_2.4.9-product JPRT Job ID: 2007-07-19-200756.daemon.ws JPRT System Used: sfbay JPRT Version Used: 17 July 2007 - Yellow Pig Day Job URL: http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-19-200756.daemon.ws User: daemon Email: modules-dev at openjdk.java.net Release: jdk1.7.0 Job Source: Source Tree: /net/shimmer.sfbay/export/home/jsr277/ws/{make,src} File List: {.} Command Line: jprt submit -stree ../ws -ot '.*linux_i586.*product.*' -noquickabort -email modules-dev at openjdk.java.net -rtests '*-*-c2-java/module' -rtests '*-*-c2-sun/module' Job submitted at: Thu-20:07:56-GMT Total time in queue: 57m 02s Job started at: Thu-21:03:00-GMT Job finished at: Thu-21:04:58-GMT Job run time: 01m 58s Job state: FAILED Job fail/kill comment: Build target failure: linux_i586_2.4.9-product Job flags: Bundles: USE: jprt install 2007-07-19-200756.daemon.ws HINT: Use 'jprt rerun -comment 2007-07-19-200756.daemon.ws' to rerun this job if you suspect bogus results. User Comments: null Build (Release:jdk1.7.0 Boot: Import:): linux_i586_2.4.9-product FAILED(01m 04s elapsed) ------------------------------------------------------------------------------ linux_i586_2.4.9-product (details from log file) /net/jprt-web.sfbay/jprt/archive/2007/07/2007-07-19-200756.daemon.ws/logs/linux_i586_2.4.9-product-build.log http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-19-200756.daemon.ws//logs/linux_i586_2.4.9-product-build.log ../../../src/share/classes/java/lang/reflect/Constructor.java ../../../src/share/classes/java/lang/reflect/InvocationTargetException.java ../../../src/share/classes/java/lang/reflect/Array.java ../../../src/share/classes/java/lang/reflect/Proxy.java ../../../src/share/classes/sun/misc/VMSupport.java ../../../src/share/classes/sun/reflect/ConstantPool.java ../../../src/share/classes/sun/reflect/NativeConstructorAccessorImpl.java ../../../src/share/classes/sun/reflect/NativeMethodAccessorImpl.java ../../../src/share/classes/sun/reflect/Reflection.java # Running javac: /opt/jprt/products/P1/jdk1.6.0/bin/javac -J-XX:ThreadStackSize=768 -J-client -J-Xmx896m -J-Xms128m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -target 5 -classpath ../../../build/linux-i586/classes -bootclasspath ../../../build/linux-i586/lib/jce.jar -sourcepath ../../../build/linux-i586/gensrc:../../../src/solaris/classes:../../../src/share/classes:../../../src/closed/solaris/classes:../../../src/closed/share/classes -d ../../../build/linux-i586/classes -encoding ascii -source 1.5 @../../../build/linux-i586/tmp/java/java.lang/java/.classes.list javac: file not found: ../../../build/linux-i586/gensrc/java/util/CurrencyData.java Usage: javac use -help for a list of possible options make[2]: *** [.compile.classlist] Error 2 make[2]: Leaving directory `/tmp/jprt/temp/P1/B/200756.daemon/source/make/java/java' make[1]: *** [all] Error 1 make: *** [all] Error 1make[1]: Leaving directory `/tmp/jprt/temp/P1/B/200756.daemon/source/make/java' ########################################################### # # Finished: Thu Jul 19 14:04:32 PDT 2007 # # Disk Space: # Filesystem 1k-blocks Used Available Use% Mounted on # /dev/sda2 66357620 12981056 50005728 21% / # # Stats for ccache: # cache directory /opt/jprt/ccache_data//usr/bin # cache hit 94 # cache miss 0 # called for link 3 # no input file 51 # files in cache 14591 # cache size 872.0 Mbytes # max cache size 976.6 Mbytes # # returned exit code 2 # ########################################################### ------------------------------------------------------------------------------ For announcements on downtime and availability join the alias 'jprt-announce at sun.com'. You can see the latest announcements at http://archives.central/tm/browse?jprt-announce. For suspected system problems, send mail to 'jprt-admin at sun.com'. The jprt how to document is available at http://javaweb.sfbay/jdk/jprt/dist/javadoc/jprt/doc-files/how-to.html. From as130790 at splendor.SFBay.Sun.COM Thu Jul 19 15:05:32 2007 From: as130790 at splendor.SFBay.Sun.COM (Andreas Sterbenz) Date: Thu, 19 Jul 2007 15:05:32 -0700 (PDT) Subject: [modules-dev] Code Manager notification (putback-to) Message-ID: <200707192205.l6JM5WeD002708@splendor.SFBay.Sun.COM> Event: putback-to Parent workspace: /net/shimmer.sfbay/export/home/jsr277/ws (shimmer.sfbay:/export/home/jsr277/ws) Child workspace: /net/splendor.sfbay/export/scratch/andreas/277 (splendor:/net/splendor.sfbay/export/scratch/andreas/277) User: as130790 Comment: Sync with TL (fix mismerge) Files: update: make/java/java/FILES_java.gmk Examined files: 12 Contents Summary: 1 update 11 no action (unchanged) From jprtadm at jprt-web.SFBay.Sun.COM Thu Jul 19 15:19:51 2007 From: jprtadm at jprt-web.SFBay.Sun.COM (JPRT Administrator) Date: Thu, 19 Jul 2007 15:19:51 -0700 (PDT) Subject: [modules-dev] JPRT: job notification - success with job 2007-07-19-220534.daemon.ws Message-ID: <200707192219.l6JMJpae009746@jprt-web.SFBay.Sun.COM> JPRT: job notification - success with job 2007-07-19-220534.daemon.ws JPRT Job ID: 2007-07-19-220534.daemon.ws JPRT System Used: sfbay JPRT Version Used: 17 July 2007 - Yellow Pig Day Job URL: http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-19-220534.daemon.ws User: daemon Email: modules-dev at openjdk.java.net Release: jdk1.7.0 Job Source: Source Tree: /net/shimmer.sfbay/export/home/jsr277/ws/{make,src} File List: {.} Command Line: jprt submit -stree ../ws -ot '.*linux_i586.*product.*' -noquickabort -email modules-dev at openjdk.java.net -rtests '*-*-c2-java/module' -rtests '*-*-c2-sun/module' Job submitted at: Thu-22:05:34-GMT Total time in queue: 14m 16s Job started at: Thu-22:07:34-GMT Job finished at: Thu-22:19:50-GMT Job run time: 12m 16s Job state: success Job flags: Bundles: USE: jprt install 2007-07-19-220534.daemon.ws HINT: Use 'jprt rerun -comment -retest 2007-07-19-220534.daemon.ws' to rerun the tests for this job (you can also add tests with 'jprt rerun'). NOTE: Zip files containing exe or dll files on windows have had problems with execute permissions. You may need to 'chmod a+x' the windows exe and dll files. User Comments: null Build (Release:jdk1.7.0 Boot: Import:): linux_i586_2.4.9-product success(11m 16s elapsed) For announcements on downtime and availability join the alias 'jprt-announce at sun.com'. You can see the latest announcements at http://archives.central/tm/browse?jprt-announce. For suspected system problems, send mail to 'jprt-admin at sun.com'. The jprt how to document is available at http://javaweb.sfbay/jdk/jprt/dist/javadoc/jprt/doc-files/how-to.html. From David.Bristor at Sun.COM Thu Jul 19 15:51:13 2007 From: David.Bristor at Sun.COM (Dave Bristor) Date: Thu, 19 Jul 2007 15:51:13 -0700 Subject: [modules-dev] Initial repository management tool In-Reply-To: <4698216A.50206@sun.com> References: <46955DB8.7080408@sun.com> <4696AEC8.1050706@sun.com> <4697F327.6040008@sun.com> <4697F9C0.8050307@sun.com> <46981784.2020801@sun.com> <4698216A.50206@sun.com> Message-ID: <469FEAE1.4070101@sun.com> Andreas Sterbenz wrote: > Dave Bristor wrote: > >>> . getMAIText(): should this really say "platform?" if platform is >>> null, etc? Rather than an empty string, or "generic", or "n/a"? >> >> >> I like "generic" for platform and arch, if for no other reason than >> I'm used to it in bugster. Do you have a suggestion for time and >> file? I kind of want to convey what it is that's unknown. I left >> them as-is for now, but am open to suggestions. Perhaps it would help >> if there were column headings? > > > For time and file, I can imagine "n/a", "-", or "" (leaving it blank). > Column headings would seem useful. I added column headings, used n/a when appropriate, and shortened the width of the output. >>> . the distinction between "list" and "find" (and "query") seems >>> rather subtle. Do we need those as separate commands? Or could module >>> name and version merely be optional parameters? >> >> >> I used ruby "gems" as a model, as suggested by Stanley and the EG: >> http://rubygems.org/read/chapter/2#page3 >> http://docs.rubygems.org/read/book/2 >> Gem has separate commands for list vs. query. Unix, etc. have >> directory listing sepate from directory searching. That's the >> rationale. Conceptually listing and findind seem separate to me (my >> $0.02). > > > Well, I use "ls" both to list all files and to list ("find") a > particular file: > > # ls -l > # ls -l JRepo.java > # ls -l *.java > > Unix find serves a different purpose. I use it when I need to use its > more complex options (-type, -perm, -mtime, etc) or to search for > something in a large directory hierarchy. > > The current JRepo "list" and "find" don't have that those differences > and there is no conflict in their options, so I am not sure what the > advantage of keeping them separate is. FWIW, "gem list" also supports > listing modules with a given name. I tried it your way, and am convinced. So currently the only command is "list", which takes an optional module name; as with gem, the name arg is the beginning of the name and all matches will be printed: % /data/ws/db-jam/build/solaris-i586/bin/jrepo list -p -v -r http://openjdk.java.net/projects/modules/samplerepo java Bootstrap repository Name Version Platform Arch Modified Filename java.se 1.7 generic generic n/a n/a java.classpath 1.7 generic generic n/a n/a In other news: by popular request, Command is now a static class; ListCommand is not because it depends on state in JRepo itself (e.g. moduleName). As I add more commands (install will hopefully be next) I hope to make ListCommand and others be static. Tests passing and webrev updated: http://javaweb.sfbay/java/jdk/ws/libs/rev/6559117/ Thanks, Dave > > Andreas. > From Andreas.Sterbenz at Sun.COM Thu Jul 19 17:06:16 2007 From: Andreas.Sterbenz at Sun.COM (Andreas Sterbenz) Date: Thu, 19 Jul 2007 17:06:16 -0700 Subject: [modules-dev] Initial repository management tool In-Reply-To: <469FEAE1.4070101@sun.com> References: <46955DB8.7080408@sun.com> <4696AEC8.1050706@sun.com> <4697F327.6040008@sun.com> <4697F9C0.8050307@sun.com> <46981784.2020801@sun.com> <4698216A.50206@sun.com> <469FEAE1.4070101@sun.com> Message-ID: <469FFC78.4090401@sun.com> Dave Bristor wrote: > > Tests passing and webrev updated: > http://javaweb.sfbay/java/jdk/ws/libs/rev/6559117/ Looks fine. Andreas. From David.Bristor at Sun.COM Thu Jul 19 18:52:10 2007 From: David.Bristor at Sun.COM (Dave Bristor) Date: Thu, 19 Jul 2007 18:52:10 -0700 Subject: [modules-dev] Review request: 6560281 In-Reply-To: <469FBAA3.7060705@sun.com> References: <469EA15D.4000609@sun.com> <469FBAA3.7060705@sun.com> Message-ID: <46A0154A.6030203@sun.com> Stanley M. Ho wrote: > Hi Dave, > > Looks good. Several comments inline: > > - src/share/classes/sun/module/repository/RepositoryConfig.java > > 87 *
  • user.home/.java/repository/repository.properties
  • > 88 *
  • $java.home/lib/repository/repository.properties
  • > > As we discussed before, because the user-specific configuration would be > picked up by different versions of the JRE the user is running, it is > unclear to me if merging the settings in these configurations files is > really what we want, especially if the settings in these files could be > in conflict. > > If we want to support multiple files, I think it is more reasonable for > user to provide a custom repository.properties file that tells the > module system to construct additional repositories from the furthest > repository created in the JRE's repository.properties file, and set the > resulting furthest repository as the system repository. > > It might also be reasonable for user to specify a specific > repository.properties that completely overrides the JRE's > repository.properties. You will find similar logic implemented in > src/share/classes/sun/module/config/ModuleSystemConfig. > > For the JRE specific configuration, it should live under > {java.home}/lib/module/repository.properties. I suggest you should also > have a default repository.properties file checked into the workspace, > see src/share/lib/module/*. We discussed this in my office, so just to summarize the changes I've made: repository.properties is now loaded as a single file; there is no merging of them as was previously done. The location of the file is specified in ModuleSystemConfig. The default location can be overridden, but only if another property is set to true; this is also controlled by ModuleSystemConfig. I updated src/share/lib/module/module.properties with two new properties. > 100 static { > > The calls to System.getProperty() should be in doPrivileged() block. > Because of the nature of class initialization, this could fail if > untrusted code is on the stack. This got removed as part of the above work. > 174 public static Repository configRepositories() throws > RuntimeException { > > Should be private. Fixed. > 177 // XXX Should repeated configRepositories throw exception? > 178 // XXX Log subsequent setup attempts. > > Why would this being called more than once? Should throw exception. Fixed to throw IllegalStateException. > > 191 // XXX nonexistent/unreadable config file: > log message? throw exception? > > The {java.home}/lib/module/repository.properties file should always > exists. If not, exception should be thrown. What if it's a user-specified file? For now it throws a RuntimeException in either case. > 231 * If no CLASS is given, then if the SOURCE value is a URL, a > 232 * URLRepository will be created; else if the SOURCE is an > existing, > 233 * readable file, a LocalRepository will be created. > > The content of the JRE's default repository configuration file will be > pretty much the same under all platforms, hence the source location will > be in the form of URL. This implies that only URLRepository could be Why must the source location be a URL? In repository.properties it given as a file. > created in our default configuration. While URLRepository has > advantages, there are several repositories we definitely need to create > using LocalRepository, e.g. the global repository and the user > repository. #344 - #353 demonstrates this issue clearly. I think we need > a better way to indicate whether it's LocalRepository or URLRepository > that we want to create. Perhaps we need to support something like TYPE. CLASS could be sun.module.repository.LocalRepository. Or, we could check the URL: if it's a file: URL, create a LocalRepository. > > 374 // XXX Throw exception, or ignore and presume "user > knows best"? > > Throw exception. Fixed. > > - src/share/classes/sun/module/repository/LocalRepository.java > > 185 public synchronized void initialize(Map > config) throws IOException { > > Should be private. Fixed. > - src/share/classes/sun/module/repository/URLRepository.java > > 283 public synchronized void initialize(Map config) > throws IOException { > > Should be private. Fixed. > - src/share/classes/java/module/Modules.java > > The javadoc needs to be updated to describe the exceptions. I will take > care of this when I make other API changes later. Thanks, I left them alone. > For the test cases, you might want to check out the tests for the > visibility policy and import override policy in > test/java/module/config/*. Because the repository.properties file is > basically a regular property file, you probably don't really need a lot > of tests around the file format. The focus should be to make sure the > code handles the repository chain construction properly in various > situations, including: > > 1. Well-formed repository chain Already there. > 2. Repository that has unknown parent Already there. > 3. Dangling repository that is not under the main repository chain Added. > 4. Multiple furthest repositories I'll work on that one. For the moment I've made substantial enough changes in other regards that I wanted to send this re-review out despite not having those yet. In the process of running tests, I found a failure, fixed it, but wonder about a couple things. Take a look at the changes to ModuleLauncher. It seems odd to me that we don't have a method Query.version(Version). Is that intentional? Second, repository.install returns a ModuleArchiveInfo, but we need a ModuleDefinition, so we find() it. Would it make sense for a method ModuleDefinition Repository.get(ModuleArchiveInfo) based on the identity of the ModuleArchiveInfo? Kumar, can you explain the logic behind this, in ModuleLauncher? // Get the first one not a bootstrap! mind you. for (ModuleDefinition md : mlist) { if (md.getRepository() != repository.getParent()) { definition = md; break; } With the RepositoryConfig changes in place, definition was getting set to java.se; probably because there are more repositories configured. Webrev updated: http://javaweb.sfbay/java/jdk/ws/libs/rev/6560281/ Thanks, Dave > > That's it for now. > > - Stanley > _______________________________________________ > modules-dev mailing list > modules-dev at openjdk.java.net > http://mail.openjdk.java.net/mailman/listinfo/modules-dev From Stanley.Ho at Sun.COM Thu Jul 19 20:03:30 2007 From: Stanley.Ho at Sun.COM (Stanley M. Ho) Date: Thu, 19 Jul 2007 20:03:30 -0700 Subject: [modules-dev] Review request: 6560281 In-Reply-To: <46A0154A.6030203@sun.com> References: <469EA15D.4000609@sun.com> <469FBAA3.7060705@sun.com> <46A0154A.6030203@sun.com> Message-ID: <46A02602.40003@sun.com> Hi Dave, Dave Bristor wrote: > Why must the source location be a URL? In repository.properties it > given as a file. Source location could be either a URL or file path. However, the repository.properties in the shipping JRE will be the same for all platforms. Because file path is platform specific, the default source locations come with the repository.properties in the JRE would be in the form of URL. > CLASS could be sun.module.repository.LocalRepository. > > Or, we could check the URL: if it's a file: URL, create a LocalRepository. This would exclude the case where you want to use URLRepository with a file URL. In fact, this is what we might end up using for the extension repository. > In the process of running tests, I found a failure, fixed it, but wonder > about a couple things. Take a look at the changes to ModuleLauncher. > It seems odd to me that we don't have a method Query.version(Version). > Is that intentional? Yes. Try Query.version(Version.toVersionConstraint()). > Second, repository.install returns a ModuleArchiveInfo, but we need a > ModuleDefinition, so we find() it. Would it make sense for a method > ModuleDefinition Repository.get(ModuleArchiveInfo) > based on the identity of the ModuleArchiveInfo? No. Installing a jam file does not mean you could always use its ModuleDefinition at runtime, e.g. the ModuleDefinition might be shadowed by another ModuleDefinition with the same name and version in a parent repository. Try Repository.find(mainfo.getName(), mainfo.getVersion()). - Stanley From jprtadm at jprt-web.SFBay.Sun.COM Fri Jul 20 05:23:33 2007 From: jprtadm at jprt-web.SFBay.Sun.COM (JPRT Administrator) Date: Fri, 20 Jul 2007 05:23:33 -0700 (PDT) Subject: [modules-dev] JPRT: job notification - success with job 2007-07-20-111305.as130790.ws Message-ID: <200707201223.l6KCNX03009988@jprt-web.SFBay.Sun.COM> JPRT: job notification - success with job 2007-07-20-111305.as130790.ws JPRT Job ID: 2007-07-20-111305.as130790.ws JPRT System Used: sfbay JPRT Version Used: 17 July 2007 - Yellow Pig Day Job URL: http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-20-111305.as130790.ws User: as130790 Email: modules-dev at openjdk.java.net Release: jdk1.7.0 Job Source: Source Tree: /net/shimmer.sfbay/export/home/jsr277/ws/{make,src} File List: {.} Command Line: jprt submit -stree ../ws -ot '.*product.*' -noquickabort -email modules-dev at openjdk.java.net -rtests '*-*-c2-java/module' -rtests '*-*-c2-sun/module' Job submitted at: Fri-11:13:05-GMT Total time in queue: 1h 10m 28s Job started at: Fri-11:24:11-GMT Job finished at: Fri-12:23:33-GMT Job run time: 59m 22s Job state: success Job flags: Bundles: USE: jprt install 2007-07-20-111305.as130790.ws HINT: Use 'jprt rerun -comment -retest 2007-07-20-111305.as130790.ws' to rerun the tests for this job (you can also add tests with 'jprt rerun'). NOTE: Zip files containing exe or dll files on windows have had problems with execute permissions. You may need to 'chmod a+x' the windows exe and dll files. User Comments: null Build (Release:jdk1.7.0 Boot: Import:): solaris_sparc_5.8-product success(24m 52s elapsed) solaris_sparcv9_5.8-product success(25m 46s elapsed) solaris_i586_5.8-product success(53m 13s elapsed) solaris_x64_5.10-product success(10m 02s elapsed) linux_i586_2.4.9-product success(11m 20s elapsed) linux_x64_2.4.19-product success(12m 59s elapsed) windows_i586_5-product success(36m 26s elapsed) windows_x64_5.2-product success(43m 17s elapsed) For announcements on downtime and availability join the alias 'jprt-announce at sun.com'. You can see the latest announcements at http://archives.central/tm/browse?jprt-announce. For suspected system problems, send mail to 'jprt-admin at sun.com'. The jprt how to document is available at http://javaweb.sfbay/jdk/jprt/dist/javadoc/jprt/doc-files/how-to.html. From andreas.sterbenz at sun.com Fri Jul 20 06:00:26 2007 From: andreas.sterbenz at sun.com (andreas.sterbenz at sun.com) Date: Fri, 20 Jul 2007 06:00:26 -0700 (PDT) Subject: [modules-dev] Open Bugs/RFEs in java/module Message-ID: <200707201300.l6KD0QP3004125@shimmer.sfbay.sun.com> An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/modules-dev/attachments/20070720/ba0066d0/attachment.html From David.Bristor at Sun.COM Fri Jul 20 12:05:13 2007 From: David.Bristor at Sun.COM (Dave Bristor) Date: Fri, 20 Jul 2007 12:05:13 -0700 Subject: [modules-dev] Review request: 6560281 In-Reply-To: <46A02602.40003@sun.com> References: <469EA15D.4000609@sun.com> <469FBAA3.7060705@sun.com> <46A0154A.6030203@sun.com> <46A02602.40003@sun.com> Message-ID: <46A10769.5050700@sun.com> Stanley M. Ho wrote: > Hi Dave, > > Dave Bristor wrote: > >>Why must the source location be a URL? In repository.properties it >>given as a file. > > > Source location could be either a URL or file path. However, the > repository.properties in the shipping JRE will be the same for all > platforms. Because file path is platform specific, the default source > locations come with the repository.properties in the JRE would be in the > form of URL. Ahhh...makes sense. Fixed. >>CLASS could be sun.module.repository.LocalRepository. >> >>Or, we could check the URL: if it's a file: URL, create a LocalRepository. > > > This would exclude the case where you want to use URLRepository with a > file URL. In fact, this is what we might end up using for the extension > repository. I've got it working by implementing support for the CLASS attribute. Take a look at repository.properties, and notice in RepositoryConfig.createRepositories() that there's now support for CLASS. (As an aside, I think it should be possible to make better use of generics in the CLASS-supporting code, but my attempts thus far failed. Any pointers would be appreciated.) As per our discussion today, the entry for extension repository in repository.properties is perhaps incorrect, and we may need multiple such repositories: do you have suggestions to make now, or shall we defer this part of the decision? >>In the process of running tests, I found a failure, fixed it, but wonder >>about a couple things. Take a look at the changes to ModuleLauncher. >>It seems odd to me that we don't have a method Query.version(Version). >>Is that intentional? > > > Yes. Try Query.version(Version.toVersionConstraint()). Fixed. >>Second, repository.install returns a ModuleArchiveInfo, but we need a >>ModuleDefinition, so we find() it. Would it make sense for a method >> ModuleDefinition Repository.get(ModuleArchiveInfo) >>based on the identity of the ModuleArchiveInfo? > > > No. Installing a jam file does not mean you could always use its > ModuleDefinition at runtime, e.g. the ModuleDefinition might be shadowed > by another ModuleDefinition with the same name and version in a parent > repository. Try Repository.find(mainfo.getName(), mainfo.getVersion()). OK: I'd used what you suggest; I was just hoping to avoid the cost of find(). webrev updated with all tests passing (I added a couple more since last review): http://javaweb.sfbay/java/jdk/ws/libs/rev/6560281/ Thanks, Dave > > - Stanley > _______________________________________________ > modules-dev mailing list > modules-dev at openjdk.java.net > http://mail.openjdk.java.net/mailman/listinfo/modules-dev From db13166 at pasilla.SFBay.Sun.COM Fri Jul 20 12:28:55 2007 From: db13166 at pasilla.SFBay.Sun.COM (David Bristor) Date: Fri, 20 Jul 2007 12:28:55 -0700 (PDT) Subject: [modules-dev] Code Manager notification (putback-to) Message-ID: <200707201928.l6KJStFY012397@pasilla.SFBay.Sun.COM> Event: putback-to Parent workspace: /net/shimmer.sfbay/export/home/jsr277/ws (shimmer.sfbay:/export/home/jsr277/ws) Child workspace: /data/ws/db-jam (pasilla:/data/ws/db-jam) User: db13166 Comment: 6559117 (repo) initial version of repository management tool [andreas.sterbenz] Files: update: make/sun/Makefile update: src/share/classes/sun/module/bootstrap/BootstrapRepository.java create: make/sun/jrepo/Makefile create: src/share/classes/sun/module/tools/Messenger.java create: src/share/classes/sun/module/tools/JRepo.java create: test/sun/module/tools/JRepoTest.java Examined files: 6 Contents Summary: 4 create 2 update Names Summary: 4 update parent's name history 4 update children's name history From jprtadm at jprt-web.SFBay.Sun.COM Fri Jul 20 12:50:23 2007 From: jprtadm at jprt-web.SFBay.Sun.COM (JPRT Administrator) Date: Fri, 20 Jul 2007 12:50:23 -0700 (PDT) Subject: [modules-dev] JPRT: job notification - success with job 2007-07-20-193148.daemon.ws Message-ID: <200707201950.l6KJoNYN010062@jprt-web.SFBay.Sun.COM> JPRT: job notification - success with job 2007-07-20-193148.daemon.ws JPRT Job ID: 2007-07-20-193148.daemon.ws JPRT System Used: sfbay JPRT Version Used: 17 July 2007 - Yellow Pig Day Job URL: http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-20-193148.daemon.ws User: daemon Email: modules-dev at openjdk.java.net Release: jdk1.7.0 Job Source: Source Tree: /net/shimmer.sfbay/export/home/jsr277/ws/{make,src} File List: {.} Command Line: jprt submit -stree ../ws -ot '.*linux_i586.*product.*' -noquickabort -email modules-dev at openjdk.java.net -rtests '*-*-c2-java/module' -rtests '*-*-c2-sun/module' Job submitted at: Fri-19:31:49-GMT Total time in queue: 18m 33s Job started at: Fri-19:38:01-GMT Job finished at: Fri-19:50:22-GMT Job run time: 12m 21s Job state: success Job flags: Bundles: USE: jprt install 2007-07-20-193148.daemon.ws HINT: Use 'jprt rerun -comment -retest 2007-07-20-193148.daemon.ws' to rerun the tests for this job (you can also add tests with 'jprt rerun'). NOTE: Zip files containing exe or dll files on windows have had problems with execute permissions. You may need to 'chmod a+x' the windows exe and dll files. User Comments: null Build (Release:jdk1.7.0 Boot: Import:): linux_i586_2.4.9-product success(11m 22s elapsed) For announcements on downtime and availability join the alias 'jprt-announce at sun.com'. You can see the latest announcements at http://archives.central/tm/browse?jprt-announce. For suspected system problems, send mail to 'jprt-admin at sun.com'. The jprt how to document is available at http://javaweb.sfbay/jdk/jprt/dist/javadoc/jprt/doc-files/how-to.html. From jprtadm at jprt-web.SFBay.Sun.COM Sat Jul 21 05:17:31 2007 From: jprtadm at jprt-web.SFBay.Sun.COM (JPRT Administrator) Date: Sat, 21 Jul 2007 05:17:31 -0700 (PDT) Subject: [modules-dev] JPRT: job notification - success with job 2007-07-21-111304.as130790.ws Message-ID: <200707211217.l6LCHVCC010347@jprt-web.SFBay.Sun.COM> JPRT: job notification - success with job 2007-07-21-111304.as130790.ws JPRT Job ID: 2007-07-21-111304.as130790.ws JPRT System Used: sfbay JPRT Version Used: 17 July 2007 - Yellow Pig Day Job URL: http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-21-111304.as130790.ws User: as130790 Email: modules-dev at openjdk.java.net Release: jdk1.7.0 Job Source: Source Tree: /net/shimmer.sfbay/export/home/jsr277/ws/{make,src} File List: {.} Command Line: jprt submit -stree ../ws -ot '.*product.*' -noquickabort -email modules-dev at openjdk.java.net -rtests '*-*-c2-java/module' -rtests '*-*-c2-sun/module' Job submitted at: Sat-11:13:04-GMT Total time in queue: 1h 04m 27s Job started at: Sat-11:18:57-GMT Job finished at: Sat-12:17:31-GMT Job run time: 58m 34s Job state: success Job flags: Bundles: USE: jprt install 2007-07-21-111304.as130790.ws HINT: Use 'jprt rerun -comment -retest 2007-07-21-111304.as130790.ws' to rerun the tests for this job (you can also add tests with 'jprt rerun'). NOTE: Zip files containing exe or dll files on windows have had problems with execute permissions. You may need to 'chmod a+x' the windows exe and dll files. User Comments: null Build (Release:jdk1.7.0 Boot: Import:): solaris_sparc_5.8-product success(24m 52s elapsed) solaris_sparcv9_5.8-product success(25m 51s elapsed) solaris_i586_5.8-product success(52m 22s elapsed) solaris_x64_5.10-product success(09m 56s elapsed) linux_i586_2.4.9-product success(11m 13s elapsed) linux_x64_2.4.19-product success(13m 04s elapsed) windows_i586_5-product success(36m 23s elapsed) windows_x64_5.2-product success(43m 16s elapsed) For announcements on downtime and availability join the alias 'jprt-announce at sun.com'. You can see the latest announcements at http://archives.central/tm/browse?jprt-announce. For suspected system problems, send mail to 'jprt-admin at sun.com'. The jprt how to document is available at http://javaweb.sfbay/jdk/jprt/dist/javadoc/jprt/doc-files/how-to.html. From andreas.sterbenz at sun.com Mon Jul 23 06:01:45 2007 From: andreas.sterbenz at sun.com (andreas.sterbenz at sun.com) Date: Mon, 23 Jul 2007 06:01:45 -0700 (PDT) Subject: [modules-dev] Open Bugs/RFEs in java/module Message-ID: <200707231301.l6ND1jWS015318@shimmer.sfbay.sun.com> An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/modules-dev/attachments/20070723/6eb290e6/attachment.html From andreas.sterbenz at sun.com Tue Jul 24 06:00:11 2007 From: andreas.sterbenz at sun.com (andreas.sterbenz at sun.com) Date: Tue, 24 Jul 2007 06:00:11 -0700 (PDT) Subject: [modules-dev] Open Bugs/RFEs in java/module Message-ID: <200707241300.l6OD0Bmk020419@shimmer.sfbay.sun.com> An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/modules-dev/attachments/20070724/c1b8424a/attachment.html From Kumar.Srinivasan at Sun.COM Tue Jul 24 11:46:02 2007 From: Kumar.Srinivasan at Sun.COM (Kumar Srinivasan) Date: Tue, 24 Jul 2007 11:46:02 -0700 Subject: [modules-dev] Review please for launcher bugs Message-ID: <46A648EA.9020604@Sun.COM> Hi, I need a review of these fixes asap. http://javaweb.sfbay/~ksrini/webrevs/j2se-tools/jsr277-6/ [The webrev contains the CRs]. Built and tested on Solaris and Windows all the regresssion tests in test/java/module pass. Thanks -- Kumar Srinivasan Sun Microsystems, Java Software. 408-276-7586 From David.Bristor at Sun.COM Tue Jul 24 14:52:48 2007 From: David.Bristor at Sun.COM (Dave Bristor) Date: Tue, 24 Jul 2007 14:52:48 -0700 Subject: [modules-dev] Issue re location of extension & user repositories Message-ID: <46A674B0.7040203@sun.com> Hi folks, In yesterday's meeting we decided that the default configuration should support a set of repositories like this: bootstrap ^ | jre extension ^ | system extension ^ | global ^ | user ^ | system We agreed on the location of the extension repositories: jre extension ${java.home}/lib/module/ext system extension ???/lib/module/ext If we base the location of the latter on what is standard for system extensions, we have a slight problem, in that the location varies across platforms: %SystemRoot%\Sun\Java\lib\ext [Microsoft Windows] /usr/java/packages/lib/ext [Linux] /usr/jdk/packages/lib/ext [Solaris OS] (From http://java.sun.com/javase/6/docs/technotes/guides/extensions/spec.html) We have a similar situation with the user repository: on my solaris box the logical place would be $HOME/.java (linux too, presumably) but on Windows it is %SystemRoot%\$USER\Application Data\Sun\Java. The current mechanism of configuring repositories allows for at most specifying the class of repository to be used in a particular case. One solution is to use a set of locations that have more in common than the above. Another is to introduce a factory into the configuration, which can choose the location. For that case, I propose we allow for a FACTORY attribute, e.g. systemextension.FACTORY=sun.module.repository.ExtensionRepositoryFactory Such a factory class would be required to have a no-arg constructor, and a factory method Repository createRepository(Map) At system startup, when FACTORY is specified, we'll create an instance and invoke createRepository on it, passing all properties given in the config file ror that repository. It would be an error for the config file to specify both FACTORY and CLASS properties for a given repository. In the particular cases of system extension and user repositories, there would be no need to specify their locations in the config file, as the factory would determine the location. I think this work can be done as an add-on to the work done thus far...I'd rather not have this delay the work-to-date (any more review feedback?) but either way is fine. Thanks, Dave From Stanley.Ho at Sun.COM Tue Jul 24 15:39:04 2007 From: Stanley.Ho at Sun.COM (Stanley M. Ho) Date: Tue, 24 Jul 2007 15:39:04 -0700 Subject: [modules-dev] Review request: 6560281 In-Reply-To: <46A10769.5050700@sun.com> References: <469EA15D.4000609@sun.com> <469FBAA3.7060705@sun.com> <46A0154A.6030203@sun.com> <46A02602.40003@sun.com> <46A10769.5050700@sun.com> Message-ID: <46A67F88.7000104@sun.com> Hi Dave, Looks good. A few comments inline: - src/share/lib/module/repository.properties 32 extension.PARENT=BOOTSTRAP 33 extension.SOURCE=file:${java.home}/lib/module/ext 34 extension.CLASS=sun.module.repository.LocalRepository 35 36 user.PARENT=extension 37 user.SOURCE=file:${user.home}/.java/module 38 user.CLASS=sun.module.repository.LocalRepository The upper case attribute looks a bit funny. Perhaps lower case? CLASS should be classname instead - this is the convention was also used in module.properties. - src/share/lib/module/module.properties 99 # -Drepository.properties.file=somefile. The system property (not the property in the module.properties file) should be "java.module.repository.properties.file". See "java.module.import.override.policy.file" and "Djava.module.visibility.policy.file". - src/share/classes/sun/module/repository/RepositoryConfig.java Upper case issue described above. 151 File f = new File(replacePropertyNamesWithValues(location)); 237 String repoValue = replacePropertyNamesWithValues( 370 private static String replacePropertyNamesWithValues(String s) { You could simply use sun.security.util.PropertyExpander rather than writing your own replacePropertyNamesWithValues(). This is what I used for expanding the property names in other files. See src/share/classessun/module/config/DefaultPolicy.java 153 BufferedInputStream is = new BufferedInputStream( 154 new FileInputStream(f)); Should have finally block to close the stream afterwards. 206 public static Repository configRepositories(Properties configProps) { Should be private. - Stanley From Stanley.Ho at Sun.COM Tue Jul 24 15:52:37 2007 From: Stanley.Ho at Sun.COM (Stanley M. Ho) Date: Tue, 24 Jul 2007 15:52:37 -0700 Subject: [modules-dev] Review please for launcher bugs In-Reply-To: <46A648EA.9020604@Sun.COM> References: <46A648EA.9020604@Sun.COM> Message-ID: <46A682B5.4010204@sun.com> Hi Kumar, Looks good. Several comments inline: - src/share/classes/sun/module/ModuleLauncher.java 188 String fname = new File(jamFileName).getName(); 189 String moduleName = fname.substring(0, fname.lastIndexOf('.')); 190 List ilist = repository.list(); 191 for (ModuleArchiveInfo i : ilist) { 192 if (i.getFileName().endsWith(fname + JamUtils.EXPANDED_EXT)) { 193 definition = getModuleDefinition(repository, i.getName()); This looks a bit funny. ModuleArchiveInfo.getFileName() should retain the original filename of the jam, not the internal cooked filename. Perhaps Dave could clarify. 238 repository.initialize(); Assuming Dave will putback his changes soon, and we won't need to call initialize() manually anymore. - Stanley Kumar Srinivasan wrote: > Hi, > > I need a review of these fixes asap. > http://javaweb.sfbay/~ksrini/webrevs/j2se-tools/jsr277-6/ > [The webrev contains the CRs]. > > Built and tested on Solaris and Windows all the regresssion > tests in test/java/module pass. > > Thanks > From Stanley.Ho at Sun.COM Tue Jul 24 16:05:36 2007 From: Stanley.Ho at Sun.COM (Stanley M. Ho) Date: Tue, 24 Jul 2007 16:05:36 -0700 Subject: [modules-dev] Issue re location of extension & user repositories In-Reply-To: <46A674B0.7040203@sun.com> References: <46A674B0.7040203@sun.com> Message-ID: <46A685C0.903@sun.com> Hi Dave, Dave Bristor wrote: > If we base the location of the latter on what is standard for system > extensions, we have a slight problem, in that the location varies across > platforms: > %SystemRoot%\Sun\Java\lib\ext [Microsoft Windows] > /usr/java/packages/lib/ext [Linux] > /usr/jdk/packages/lib/ext [Solaris OS] > > (From http://java.sun.com/javase/6/docs/technotes/guides/extensions/spec.html) > > We have a similar situation with the user repository: on my solaris box the > logical place would be $HOME/.java (linux too, presumably) but on Windows it > is %SystemRoot%\$USER\Application Data\Sun\Java. > > The current mechanism of configuring repositories allows for at most > specifying the class of repository to be used in a particular case. One > solution is to use a set of locations that have more in common than the above. > Another is to introduce a factory into the configuration, which can choose > the location. The repository locations will definitely be somewhat different on each platform. Another alternative is to introduce new standard system properties into SE, e.g. "repository.user.home" and "repository.system.home". We could define their defaults on the SE supported platforms, and make use of them directly in the configuration. - Stanley From David.Bristor at Sun.COM Tue Jul 24 17:21:42 2007 From: David.Bristor at Sun.COM (Dave Bristor) Date: Tue, 24 Jul 2007 17:21:42 -0700 Subject: [modules-dev] Review request: 6560281 In-Reply-To: <46A67F88.7000104@sun.com> References: <469EA15D.4000609@sun.com> <469FBAA3.7060705@sun.com> <46A0154A.6030203@sun.com> <46A02602.40003@sun.com> <46A10769.5050700@sun.com> <46A67F88.7000104@sun.com> Message-ID: <46A69796.5050308@sun.com> Stanley M. Ho wrote: > Hi Dave, > > Looks good. A few comments inline: > > - src/share/lib/module/repository.properties > > 32 extension.PARENT=BOOTSTRAP > 33 extension.SOURCE=file:${java.home}/lib/module/ext > 34 extension.CLASS=sun.module.repository.LocalRepository > 35 > 36 user.PARENT=extension > 37 user.SOURCE=file:${user.home}/.java/module > 38 user.CLASS=sun.module.repository.LocalRepository > > The upper case attribute looks a bit funny. Perhaps lower case? CLASS > should be classname instead - this is the convention was also used in > module.properties. They are uppercase so that they stand out: the intent is that they be treated as reserved words, and that other respository implementation specific properties can be in lower case. Perhaps make them lower case and/or use a case-insensitive comparison? Related: the default jre extension repository directory is ${java.home}/lib/module/ext Do you know into which Makefile I should cause that directory to be created? I've modified LocalRepository to create the sourceLocation if it does not exist (which will presumably suffice for the user repository). > - src/share/lib/module/module.properties > > 99 # -Drepository.properties.file=somefile. > > The system property (not the property in the module.properties file) > should be "java.module.repository.properties.file". See > "java.module.import.override.policy.file" and > "Djava.module.visibility.policy.file". Fixed. In line with your suggestion of "classname" above, shouldn't these all be "filename"? > - src/share/classes/sun/module/repository/RepositoryConfig.java > > Upper case issue described above. > > 151 File f = new > File(replacePropertyNamesWithValues(location)); > 237 String repoValue = replacePropertyNamesWithValues( > 370 private static String replacePropertyNamesWithValues(String s) { > > You could simply use sun.security.util.PropertyExpander rather than > writing your own replacePropertyNamesWithValues(). This is what I used > for expanding the property names in other files. See > src/share/classessun/module/config/DefaultPolicy.java Thanks, I didn't know about PropertyExpander: fixed. Well, maybe not: if you give PropertyExpander.expand this string: ${user.home/foo/bar it doesn't throw an exception, which doesn't seem reasonable (IMHO). At your suggestion, the code currently uses PropertyExpander, but I disabled the test which checked for the condition above. Please let me know if I should restore the code I had before. > 153 BufferedInputStream is = new BufferedInputStream( > 154 new FileInputStream(f)); > > Should have finally block to close the stream afterwards. Fixed. > 206 public static Repository configRepositories(Properties > configProps) { > > Should be private. It's public so that it can be accessed from RepositoryConfigTest. webrev updated! Thanks, Dave > > - Stanley From David.Bristor at Sun.COM Tue Jul 24 17:24:27 2007 From: David.Bristor at Sun.COM (Dave Bristor) Date: Tue, 24 Jul 2007 17:24:27 -0700 Subject: [modules-dev] Review request: 6563535, URLRepository.install Message-ID: <46A6983B.9020303@sun.com> Hi folks, This one allows URLRepository.install() to succeed on URLRepositories created with a file: URL. The review is ever-so-slightly preliminary; I've tested on solaris-x86 but want to test on Windows also and will do so tomorrow. bugster: http://monaco.sfbay/detail.jsf?cr=6563535 webrev: http://javaweb.sfbay/java/jdk/ws/libs/rev/6563535/ URLRepositoryTest is changed to verify that install() yields exceptions as expected. URLRepoBuilder is changed so that it can build a single JAM, which is used by URLRepoInstallTest; most of the changes are code movement. URLRepository is changed for implementation of install() and uninstall(). Note also that, when a repository is initialized, if it is file-based and repository-metadata.xml does not exist, it gets created. URLRepoInstallTest verifies that install works. It is a very basic test; there are several error conditions that would be hard to check and so that's not done now. Thanks, Dave From Andreas.Sterbenz at Sun.COM Tue Jul 24 17:42:23 2007 From: Andreas.Sterbenz at Sun.COM (Andreas Sterbenz) Date: Tue, 24 Jul 2007 17:42:23 -0700 Subject: [modules-dev] Review please for launcher bugs In-Reply-To: <46A682B5.4010204@sun.com> References: <46A648EA.9020604@Sun.COM> <46A682B5.4010204@sun.com> Message-ID: <46A69C6F.8010407@sun.com> Stanley M. Ho wrote: > > This looks a bit funny. ModuleArchiveInfo.getFileName() should retain > the original filename of the jam, not the internal cooked filename. > Perhaps Dave could clarify. I suspect that is due to the use of ExpandedJamRepository in the LocalRepository implementation. That should be changed eventually. Maybe Dave will do that as part of the unpacking and temp file changes suggested in 6578414. Andreas. From Andreas.Sterbenz at Sun.COM Tue Jul 24 17:47:46 2007 From: Andreas.Sterbenz at Sun.COM (Andreas Sterbenz) Date: Tue, 24 Jul 2007 17:47:46 -0700 Subject: [modules-dev] Review please for launcher bugs In-Reply-To: <46A648EA.9020604@Sun.COM> References: <46A648EA.9020604@Sun.COM> Message-ID: <46A69DB2.7050805@sun.com> Kumar Srinivasan wrote: > > I need a review of these fixes asap. > http://javaweb.sfbay/~ksrini/webrevs/j2se-tools/jsr277-6/ > [The webrev contains the CRs]. Looks fine. One minor comment: . there should be a check for "definition == null" in getModuleDefinitionFromJam() that throws an appropriate exception if we don't find the module. It could be null if the JAM file is corrupt. Andreas. From Stanley.Ho at Sun.COM Tue Jul 24 18:24:50 2007 From: Stanley.Ho at Sun.COM (Stanley M. Ho) Date: Tue, 24 Jul 2007 18:24:50 -0700 Subject: [modules-dev] Review request: 6560281 In-Reply-To: <46A69796.5050308@sun.com> References: <469EA15D.4000609@sun.com> <469FBAA3.7060705@sun.com> <46A0154A.6030203@sun.com> <46A02602.40003@sun.com> <46A10769.5050700@sun.com> <46A67F88.7000104@sun.com> <46A69796.5050308@sun.com> Message-ID: <46A6A662.1090108@sun.com> Hi Dave, Dave Bristor wrote: > They are uppercase so that they stand out: the intent is that they be > treated as reserved words, and that other respository implementation > specific properties can be in lower case. Perhaps make them lower case > and/or use a case-insensitive comparison? Sounds reasonable. > Related: the default jre extension repository directory is > ${java.home}/lib/module/ext > Do you know into which Makefile I should cause that directory to be > created? I've modified LocalRepository to create the sourceLocation if Try make/java/module/Makefile. > it does not exist (which will presumably suffice for the user repository). If the location doesn't exist, I think it's better to ignore it. It would be annoying if the user just mistypes the repository path in the launcher and then finds the directory being created as a side effect. > Fixed. In line with your suggestion of "classname" above, shouldn't > these all be "filename"? Apparently no. "file" has been the convention used in other configurations in the JDK. > Thanks, I didn't know about PropertyExpander: fixed. Well, maybe not: > if you give PropertyExpander.expand this string: > ${user.home/foo/bar > it doesn't throw an exception, which doesn't seem reasonable (IMHO). At > your suggestion, the code currently uses PropertyExpander, but I > disabled the test which checked for the condition above. Please let me > know if I should restore the code I had before. Let's use PropertyExpander for now. If it turns out we need better error handling, then we will migrate all the usages of PropertyExpander into something better. - Stanley From andreas.sterbenz at sun.com Wed Jul 25 06:00:30 2007 From: andreas.sterbenz at sun.com (andreas.sterbenz at sun.com) Date: Wed, 25 Jul 2007 06:00:30 -0700 (PDT) Subject: [modules-dev] Open Bugs/RFEs in java/module Message-ID: <200707251300.l6PD0UEV025494@shimmer.sfbay.sun.com> An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/modules-dev/attachments/20070725/78159211/attachment.html From David.Bristor at Sun.COM Wed Jul 25 10:50:04 2007 From: David.Bristor at Sun.COM (Dave Bristor) Date: Wed, 25 Jul 2007 10:50:04 -0700 Subject: [modules-dev] Review please for launcher bugs In-Reply-To: <46A682B5.4010204@sun.com> References: <46A648EA.9020604@Sun.COM> <46A682B5.4010204@sun.com> Message-ID: <46A78D4C.8070908@sun.com> Stanley M. Ho wrote: > Hi Kumar, > > Looks good. Several comments inline: > > - src/share/classes/sun/module/ModuleLauncher.java > > 188 String fname = new File(jamFileName).getName(); > 189 String moduleName = fname.substring(0, > fname.lastIndexOf('.')); > 190 List ilist = repository.list(); > 191 for (ModuleArchiveInfo i : ilist) { > 192 if (i.getFileName().endsWith(fname + > JamUtils.EXPANDED_EXT)) { > 193 definition = getModuleDefinition(repository, > i.getName()); > > This looks a bit funny. ModuleArchiveInfo.getFileName() should retain > the original filename of the jam, not the internal cooked filename. > Perhaps Dave could clarify. When a ModuleArchiveInfo is created, we don't have an "original filename", we have a URL. ExpandedJamRepository creates the ModuleArchiveInfo from new File(url.getFile()).getAbsolutePath() I don't recall why it particularly does that, probably should be getCanonicalPath() if anything. The URLRepository doesn't have an "original filename" at all; currently it provides just the module name: this should be fixed to refer to the downloaded JAM but that's difficult at best: When the ModuleArchiveInfo is created, the repository has not yet downloaded the JAM. Dave > > 238 repository.initialize(); > > Assuming Dave will putback his changes soon, and we won't need to call > initialize() manually anymore. > > - Stanley > > > Kumar Srinivasan wrote: >> Hi, >> >> I need a review of these fixes asap. >> http://javaweb.sfbay/~ksrini/webrevs/j2se-tools/jsr277-6/ >> [The webrev contains the CRs]. >> >> Built and tested on Solaris and Windows all the regresssion >> tests in test/java/module pass. >> >> Thanks >> > _______________________________________________ > modules-dev mailing list > modules-dev at openjdk.java.net > http://mail.openjdk.java.net/mailman/listinfo/modules-dev From David.Bristor at Sun.COM Wed Jul 25 11:14:33 2007 From: David.Bristor at Sun.COM (Dave Bristor) Date: Wed, 25 Jul 2007 11:14:33 -0700 Subject: [modules-dev] Review please for launcher bugs In-Reply-To: <46A648EA.9020604@Sun.COM> References: <46A648EA.9020604@Sun.COM> Message-ID: <46A79309.4080702@sun.com> Mostly fine, a few questions and minor/typo kinds of things. Dave - src/share/classes/sun/module/ModuleLauncher.java 147 private static Repository repository = null; Please put this and all other field declarations at the top of the file, not in the middle. 188 String fname = new File(jamFileName).getName(); 189 String moduleName = fname.substring(0, fname.lastIndexOf('.')); 190 List ilist = repository.list(); 191 for (ModuleArchiveInfo i : ilist) { 192 if (i.getFileName().endsWith(fname + JamUtils.EXPANDED_EXT)) { 193 definition = getModuleDefinition(repository, i.getName()); 194 break; 195 } 196 } I remain somewhat bewildered by this: could you explain? Also, line 188 could be String fname = baseDir.getName(); though perhaps baseDir should be renamed jamFile (since it's not a base directory). 207 if (!jamFileName.endsWith(".jam") && !jamFileName.endsWith(".jar")) { 208 throw new IllegalArgumentException("jam filename must have a .jam or .jar extension"); Shouldn't .jam.pack.gz also be allowed? Or is that just not-yet-implemented? (I know it's not fully supported elsewhere...) 231 throw new Exception("Repository not found at " + repFile.toString()); Should this also be IllegalArgumentException? - test/java/module/basic/BasicLauncherTests.java 260 static String expRepository; 261 static String jamRepository; 262 static String urlRepository ; Extra space in line 262 and please put fields at beginning of file. Several other places, why the change from expRepository to urlRepository? I might have thought an addition would be appropriate; was removal of expRepository intentional? Kumar Srinivasan wrote: > Hi, > > I need a review of these fixes asap. > http://javaweb.sfbay/~ksrini/webrevs/j2se-tools/jsr277-6/ > [The webrev contains the CRs]. > > Built and tested on Solaris and Windows all the regresssion > tests in test/java/module pass. > > Thanks > From Stanley.Ho at Sun.COM Wed Jul 25 11:31:08 2007 From: Stanley.Ho at Sun.COM (Stanley M. Ho) Date: Wed, 25 Jul 2007 11:31:08 -0700 Subject: [modules-dev] Review please for launcher bugs In-Reply-To: <46A78D4C.8070908@sun.com> References: <46A648EA.9020604@Sun.COM> <46A682B5.4010204@sun.com> <46A78D4C.8070908@sun.com> Message-ID: <46A796EC.3090403@sun.com> Hi Dave, Dave Bristor wrote: > When a ModuleArchiveInfo is created, we don't have an "original > filename", we have a URL. ExpandedJamRepository creates the > ModuleArchiveInfo from > new File(url.getFile()).getAbsolutePath() > I don't recall why it particularly does that, probably should be > getCanonicalPath() if anything. I think what is unclear is that Kumar's fix checks if the filename returned from ModuleArchiveInfo ends with JamUtils.EXPANDED_EXT, and this kinda implies that the repository implementation is returning an internal cached jam filename in this case. > The URLRepository doesn't have an "original filename" at all; currently > it provides just the module name: this should be fixed to refer to the > downloaded JAM but that's difficult at best: When the ModuleArchiveInfo > is created, the repository has not yet downloaded the JAM. The URLRepository does know about the filename, otherwise it won't be able to figure out how to download the file later. However, the concern is valid that the file might not yet been downloaded when list() is called, so null should be returned in this case. - Stanley From David.Bristor at Sun.COM Wed Jul 25 11:59:43 2007 From: David.Bristor at Sun.COM (Dave Bristor) Date: Wed, 25 Jul 2007 11:59:43 -0700 Subject: [modules-dev] Review request: 6560281 In-Reply-To: <46A6A662.1090108@sun.com> References: <469EA15D.4000609@sun.com> <469FBAA3.7060705@sun.com> <46A0154A.6030203@sun.com> <46A02602.40003@sun.com> <46A10769.5050700@sun.com> <46A67F88.7000104@sun.com> <46A69796.5050308@sun.com> <46A6A662.1090108@sun.com> Message-ID: <46A79D9F.40106@sun.com> Stanley M. Ho wrote: > Hi Dave, > > Dave Bristor wrote: >> They are uppercase so that they stand out: the intent is that they be >> treated as reserved words, and that other respository implementation >> specific properties can be in lower case. Perhaps make them lower >> case and/or use a case-insensitive comparison? > > Sounds reasonable. I made them lower case, and they *must* be specified that way: at times, they are used as keys in maps, which don't support case-insensitivity. > >> Related: the default jre extension repository directory is >> ${java.home}/lib/module/ext >> Do you know into which Makefile I should cause that directory to be >> created? I've modified LocalRepository to create the sourceLocation if > > Try make/java/module/Makefile. I updated that to create the directory. >> it does not exist (which will presumably suffice for the user >> repository). > > If the location doesn't exist, I think it's better to ignore it. It > would be annoying if the user just mistypes the repository path in the > launcher and then finds the directory being created as a side effect. This presents a conundrum: As we agreed Monday, the standard repository.properties has user.source=file:${user.home}/.java/module and that does not exist, then the JVM will exit. Something needs to create that directory first. So along with your mention in earlier email (attached) about having system properties to define the locations of repositories, we still need something to create them. One option, for now, is to comment out the user repository entry in repository.properties, and uncomment it once we know how its directory will be created. For now, this is what's at the updated webrev. What do you think? > >> Fixed. In line with your suggestion of "classname" above, shouldn't >> these all be "filename"? > > Apparently no. "file" has been the convention used in other > configurations in the JDK. Thanks for checking. >> Thanks, I didn't know about PropertyExpander: fixed. Well, maybe not: >> if you give PropertyExpander.expand this string: >> ${user.home/foo/bar >> it doesn't throw an exception, which doesn't seem reasonable (IMHO). >> At your suggestion, the code currently uses PropertyExpander, but I >> disabled the test which checked for the condition above. Please let >> me know if I should restore the code I had before. > > Let's use PropertyExpander for now. If it turns out we need better error > handling, then we will migrate all the usages of PropertyExpander into > something better. Agreed; PropertyExpander it is. webrev updated: http://javaweb.sfbay/java/jdk/ws/libs/rev/6560281/ Thanks, Dave > > - Stanley -------------- next part -------------- An embedded message was scrubbed... From: "Stanley M. Ho" Subject: Re: [modules-dev] Issue re location of extension & user repositories Date: Tue, 24 Jul 2007 16:05:36 -0700 Size: 6704 Url: http://mail.openjdk.java.net/pipermail/modules-dev/attachments/20070725/6b89e401/attachment.mht From Stanley.Ho at Sun.COM Wed Jul 25 12:12:27 2007 From: Stanley.Ho at Sun.COM (Stanley M. Ho) Date: Wed, 25 Jul 2007 12:12:27 -0700 Subject: [modules-dev] Review request: 6560281 In-Reply-To: <46A79D9F.40106@sun.com> References: <469EA15D.4000609@sun.com> <469FBAA3.7060705@sun.com> <46A0154A.6030203@sun.com> <46A02602.40003@sun.com> <46A10769.5050700@sun.com> <46A67F88.7000104@sun.com> <46A69796.5050308@sun.com> <46A6A662.1090108@sun.com> <46A79D9F.40106@sun.com> Message-ID: <46A7A09B.3050302@sun.com> Hi Dave, Dave Bristor wrote: >> If the location doesn't exist, I think it's better to ignore it. It >> would be annoying if the user just mistypes the repository path in the >> launcher and then finds the directory being created as a side effect. > > This presents a conundrum: As we agreed Monday, the standard > repository.properties has > user.source=file:${user.home}/.java/module > and that does not exist, then the JVM will exit. Something needs to > create that directory first. So along with your mention in earlier > email (attached) about having system properties to define the locations > of repositories, we still need something to create them. > > One option, for now, is to comment out the user repository entry in > repository.properties, and uncomment it once we know how its directory > will be created. For now, this is what's at the updated webrev. What > do you think? I think there are repositories (e.g. extension repository) that must exist as a prerequisite for the module system to run, but there are also repositories (e.g. this user level repository) that are optional. Like other user specific files or directories under {user.home}, we should neither expect this user level repository will always exist nor it be created by us. If we can't address this in this putback, let's comment out the entry for now. - Stanley From David.Bristor at Sun.COM Wed Jul 25 16:12:41 2007 From: David.Bristor at Sun.COM (Dave Bristor) Date: Wed, 25 Jul 2007 16:12:41 -0700 Subject: [modules-dev] Review request: 6560281 In-Reply-To: <46A7A09B.3050302@sun.com> References: <469EA15D.4000609@sun.com> <469FBAA3.7060705@sun.com> <46A0154A.6030203@sun.com> <46A02602.40003@sun.com> <46A10769.5050700@sun.com> <46A67F88.7000104@sun.com> <46A69796.5050308@sun.com> <46A6A662.1090108@sun.com> <46A79D9F.40106@sun.com> <46A7A09B.3050302@sun.com> Message-ID: <46A7D8E9.1010908@sun.com> I just did a putback for the repository configuration code, with a couple more changes, to JRepo and JRepoTest. The entry for the user repository is commented out for now. Thanks for all the careful review! Dave Stanley M. Ho wrote: > Hi Dave, > > Dave Bristor wrote: >>> If the location doesn't exist, I think it's better to ignore it. It >>> would be annoying if the user just mistypes the repository path in >>> the launcher and then finds the directory being created as a side >>> effect. >> >> This presents a conundrum: As we agreed Monday, the standard >> repository.properties has >> user.source=file:${user.home}/.java/module >> and that does not exist, then the JVM will exit. Something needs to >> create that directory first. So along with your mention in earlier >> email (attached) about having system properties to define the >> locations of repositories, we still need something to create them. >> >> One option, for now, is to comment out the user repository entry in >> repository.properties, and uncomment it once we know how its directory >> will be created. For now, this is what's at the updated webrev. What >> do you think? > > I think there are repositories (e.g. extension repository) that must > exist as a prerequisite for the module system to run, but there are also > repositories (e.g. this user level repository) that are optional. Like > other user specific files or directories under {user.home}, we should > neither expect this user level repository will always exist nor it be > created by us. If we can't address this in this putback, let's comment > out the entry for now. > > - Stanley From db13166 at pasilla.SFBay.Sun.COM Wed Jul 25 16:06:42 2007 From: db13166 at pasilla.SFBay.Sun.COM (David Bristor) Date: Wed, 25 Jul 2007 16:06:42 -0700 (PDT) Subject: [modules-dev] Code Manager notification (putback-to) Message-ID: <200707252306.l6PN6gJV010551@pasilla.SFBay.Sun.COM> Event: putback-to Parent workspace: /net/shimmer.sfbay/export/home/jsr277/ws (shimmer.sfbay:/export/home/jsr277/ws) Child workspace: /data/ws/db-repo (pasilla:/data/ws/db-repo) User: db13166 Comment: 6560281 (repo) automatically construct default repository instances per configuration file [stanley.ho] Files: update: make/java/module/Makefile update: src/share/classes/java/module/Modules.java update: src/share/classes/java/module/Repository.java update: src/share/classes/sun/module/ModuleLauncher.java update: src/share/classes/sun/module/bootstrap/BootstrapRepository.java update: src/share/classes/sun/module/config/ModuleSystemConfig.java update: src/share/classes/sun/module/repository/RepositoryConfig.java update: src/share/classes/sun/module/repository/LocalRepository.java update: src/share/classes/sun/module/repository/URLRepository.java update: src/share/classes/sun/module/repository/ExpandedJamRepository.java update: src/share/classes/sun/module/tools/JRepo.java update: src/share/lib/module/module.properties update: test/java/module/repository/LocalRepositoryTest.java update: test/java/module/repository/URLRepositoryTest.java update: test/sun/module/repository/RepositoryTest.java update: test/sun/module/repository/ExpandedJamRepositoryTest.java update: test/sun/module/tools/JRepoTest.java create: src/share/lib/module/repository.properties create: test/sun/module/repository/RepositoryConfigTest.java Examined files: 19 Contents Summary: 2 create 17 update From jprtadm at jprt-web.SFBay.Sun.COM Wed Jul 25 18:45:27 2007 From: jprtadm at jprt-web.SFBay.Sun.COM (JPRT Administrator) Date: Wed, 25 Jul 2007 18:45:27 -0700 (PDT) Subject: [modules-dev] JPRT: job notification - success with job 2007-07-25-230715.daemon.ws Message-ID: <200707260145.l6Q1jRhP021233@jprt-web.SFBay.Sun.COM> JPRT: job notification - success with job 2007-07-25-230715.daemon.ws JPRT Job ID: 2007-07-25-230715.daemon.ws JPRT System Used: sfbay JPRT Version Used: 17 July 2007 - Yellow Pig Day Job URL: http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-25-230715.daemon.ws User: daemon Email: modules-dev at openjdk.java.net Release: jdk1.7.0 Job Source: Source Tree: /net/shimmer.sfbay/export/home/jsr277/ws/{make,src} File List: {.} Command Line: jprt submit -stree ../ws -ot '.*linux_i586.*product.*' -noquickabort -email modules-dev at openjdk.java.net -rtests '*-*-c2-java/module' -rtests '*-*-c2-sun/module' Job submitted at: Wed-23:07:11-GMT Total time in queue: 2h 38m 16s Job started at: Thu-01:30:59-GMT Job finished at: Thu-01:45:27-GMT Job run time: 14m 28s Job state: success Job flags: Bundles: USE: jprt install 2007-07-25-230715.daemon.ws HINT: Use 'jprt rerun -comment -retest 2007-07-25-230715.daemon.ws' to rerun the tests for this job (you can also add tests with 'jprt rerun'). NOTE: Zip files containing exe or dll files on windows have had problems with execute permissions. You may need to 'chmod a+x' the windows exe and dll files. User Comments: null Build (Release:jdk1.7.0 Boot: Import:): linux_i586_2.4.9-product success(13m 20s elapsed) For announcements on downtime and availability join the alias 'jprt-announce at sun.com'. You can see the latest announcements at http://archives.central/tm/browse?jprt-announce. For suspected system problems, send mail to 'jprt-admin at sun.com'. The jprt how to document is available at http://javaweb.sfbay/jdk/jprt/dist/javadoc/jprt/doc-files/how-to.html. From jprtadm at jprt-web.SFBay.Sun.COM Thu Jul 26 05:17:01 2007 From: jprtadm at jprt-web.SFBay.Sun.COM (JPRT Administrator) Date: Thu, 26 Jul 2007 05:17:01 -0700 (PDT) Subject: [modules-dev] JPRT: job notification - success with job 2007-07-26-111311.as130790.ws Message-ID: <200707261217.l6QCH1Fr021479@jprt-web.SFBay.Sun.COM> JPRT: job notification - success with job 2007-07-26-111311.as130790.ws JPRT Job ID: 2007-07-26-111311.as130790.ws JPRT System Used: sfbay JPRT Version Used: 17 July 2007 - Yellow Pig Day Job URL: http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-26-111311.as130790.ws User: as130790 Email: modules-dev at openjdk.java.net Release: jdk1.7.0 Job Source: Source Tree: /net/shimmer.sfbay/export/home/jsr277/ws/{make,src} File List: {.} Command Line: jprt submit -stree ../ws -ot '.*product.*' -noquickabort -email modules-dev at openjdk.java.net -rtests '*-*-c2-java/module' -rtests '*-*-c2-sun/module' Job submitted at: Thu-11:13:07-GMT Total time in queue: 1h 03m 54s Job started at: Thu-11:18:23-GMT Job finished at: Thu-12:17:01-GMT Job run time: 58m 38s Job state: success Job flags: Bundles: USE: jprt install 2007-07-26-111311.as130790.ws HINT: Use 'jprt rerun -comment -retest 2007-07-26-111311.as130790.ws' to rerun the tests for this job (you can also add tests with 'jprt rerun'). NOTE: Zip files containing exe or dll files on windows have had problems with execute permissions. You may need to 'chmod a+x' the windows exe and dll files. User Comments: null Build (Release:jdk1.7.0 Boot: Import:): solaris_sparc_5.8-product success(24m 50s elapsed) solaris_sparcv9_5.8-product success(25m 54s elapsed) solaris_i586_5.8-product success(52m 23s elapsed) solaris_x64_5.10-product success(09m 57s elapsed) linux_i586_2.4.9-product success(11m 06s elapsed) linux_x64_2.4.19-product success(12m 56s elapsed) windows_i586_5-product success(36m 17s elapsed) windows_x64_5.2-product success(43m 30s elapsed) For announcements on downtime and availability join the alias 'jprt-announce at sun.com'. You can see the latest announcements at http://archives.central/tm/browse?jprt-announce. For suspected system problems, send mail to 'jprt-admin at sun.com'. The jprt how to document is available at http://javaweb.sfbay/jdk/jprt/dist/javadoc/jprt/doc-files/how-to.html. From andreas.sterbenz at sun.com Thu Jul 26 06:00:30 2007 From: andreas.sterbenz at sun.com (andreas.sterbenz at sun.com) Date: Thu, 26 Jul 2007 06:00:30 -0700 (PDT) Subject: [modules-dev] Open Bugs/RFEs in java/module Message-ID: <200707261300.l6QD0Uh9014198@shimmer.sfbay.sun.com> An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/modules-dev/attachments/20070726/5484a085/attachment.html From David.Bristor at Sun.COM Thu Jul 26 17:42:49 2007 From: David.Bristor at Sun.COM (Dave Bristor) Date: Thu, 26 Jul 2007 17:42:49 -0700 Subject: [modules-dev] Review of 6560934, comparing MODULE.METADATA Message-ID: <46A93F89.5020307@sun.com> This change causes the URLRepository to compare MODULE.METADATA downloaded when the repository was initialized to that downloaded when the JAM is downloaded. bugster: http://monaco.sfbay/detail.jsf?cr=6560934 webrev: http://javaweb.sfbay/java/jdk/ws/libs/rev/6560934/ Kumar, I suspect you in particular will have some helpful review: some time ago you carped about my overly simplistic copyFile implementation. Well, here we need to compare two files, and perhaps again the implementation could be improved by use of NIO classes. Suggestions are greatly appreciated. Thanks, Dave From andreas.sterbenz at sun.com Fri Jul 27 06:00:31 2007 From: andreas.sterbenz at sun.com (andreas.sterbenz at sun.com) Date: Fri, 27 Jul 2007 06:00:31 -0700 (PDT) Subject: [modules-dev] Open Bugs/RFEs in java/module Message-ID: <200707271300.l6RD0Vfh028848@shimmer.sfbay.sun.com> An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/modules-dev/attachments/20070727/26a935fc/attachment.html From hejlp at seznam.cz Sun Jul 29 12:03:28 2007 From: hejlp at seznam.cz (Petr Sickboy Hejl) Date: Sun, 29 Jul 2007 21:03:28 +0200 Subject: [modules-dev] newbie version control question & ExpandedJamDefinitionContent Message-ID: <46ACE480.5070009@seznam.cz> Hello everybody, I've just registered. I tested early access code and I've got two question (I didn't find answer in mailing list archive). 1) Is there any public source code version control for modules project? 2) I think that ExpandedJamDefinitionContent contains bug - according to specification, legacy jar files should be placed in MODULE-INF/lib, however current implementation (that published snapshot) expects them just in lib (tested). Similar bug for native libraries. Best regards Petr Hejl From Andreas.Sterbenz at Sun.COM Mon Jul 30 00:36:48 2007 From: Andreas.Sterbenz at Sun.COM (Andreas Sterbenz) Date: Mon, 30 Jul 2007 00:36:48 -0700 Subject: [modules-dev] newbie version control question & ExpandedJamDefinitionContent In-Reply-To: <46ACE480.5070009@seznam.cz> References: <46ACE480.5070009@seznam.cz> Message-ID: <46AD9510.7080204@sun.com> Petr Sickboy Hejl wrote: > Hello everybody, > I've just registered. I tested early access code and I've got two > question (I didn't find answer in mailing list archive). Welcome! > 1) Is there any public source code version control for modules project? Not yet. For now you have to download the complete ZIP file from the download site [1]. It will be updated every 2 weeks at the same time new JDK 7 bits are posted. The next update should happen Thursday or Friday this week. We hope to have some initial Mercurial support on OpenJDK soon so that updates become available immediately and can be pulled incrementally. [1] http://download.java.net/openjdk/jdk7/ [2] http://www.selenic.com/mercurial/wiki/ > 2) I think that ExpandedJamDefinitionContent contains bug - according to > specification, legacy jar files should be placed in MODULE-INF/lib, > however current implementation (that published snapshot) expects them > just in lib (tested). Similar bug for native libraries. Embedded JAR files and native libraries do not work properly yet. There are open bugs for that in the class loader and the repository, see the daily bug emails. We hope to get to that before too long, watch this list for updates. Andreas. From jprtadm at jprt-web.SFBay.Sun.COM Mon Jul 30 01:30:02 2007 From: jprtadm at jprt-web.SFBay.Sun.COM (JPRT Administrator) Date: Mon, 30 Jul 2007 01:30:02 -0700 (PDT) Subject: [modules-dev] JPRT: job notification - FAILED with job 2007-07-30-074413.daemon.ws Message-ID: <200707300830.l6U8U2KW000882@jprt-web.SFBay.Sun.COM> JPRT: job notification - FAILED with job 2007-07-30-074413.daemon.ws Failure reason: Test target failure: linux_i586-product-c2-sun/module JPRT Job ID: 2007-07-30-074413.daemon.ws JPRT System Used: sfbay JPRT Version Used: 29 July 2007 - National Lasagna Day Job URL: http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-30-074413.daemon.ws User: daemon Email: modules-dev at openjdk.java.net Release: jdk1.7.0 Job Source: Source Tree: /net/shimmer.sfbay/export/home/jsr277/ws/{make,src} File List: {.} Command Line: jprt submit -stree ../ws -ot '.*linux_i586.*product.*' -noquickabort -email modules-dev at openjdk.java.net -rtests '*-*-c2-java/module' -rtests '*-*-c2-sun/module' Job submitted at: Mon-07:44:08-GMT Total time in queue: 45m 54s Job started at: Mon-08:13:11-GMT Job finished at: Mon-08:30:02-GMT Job run time: 16m 51s Job state: FAILED Job fail/kill comment: Test target failure: linux_i586-product-c2-sun/module Job flags: Bundles: USE: jprt install 2007-07-30-074413.daemon.ws HINT: Use 'jprt rerun -comment 2007-07-30-074413.daemon.ws' to rerun this job if you suspect bogus results. User Comments: null Build (Release:jdk1.7.0 Boot: Import:): linux_i586_2.4-product success(13m 07s elapsed) Tests: linux_i586-product-c2-jvm98 success(01m 45s elapsed) linux_i586-product-c2-java/module success(02m 23s elapsed) linux_i586-product-c2-sun/module FAILED( 54s elapsed) ------------------------------------------------------------------------------ linux_i586-product-c2-sun/module (details from log file) /net/jprt-web.sfbay/jprt/archive/2007/07/2007-07-30-074413.daemon.ws/logs/linux_i586-product-c2-sun_module-test.log http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-30-074413.daemon.ws//logs/linux_i586-product-c2-sun_module-test.log /tmp/jprt/temp/P1/T/074413.daemon/source/test/sun/module/tools/JRepoTest.java:42: cannot find symbol symbol : class JRepo location: class JRepoTest JRepo jr = new JRepo(new PrintStream(bout), new PrintStream(berr)); ^ 3 errors TEST RESULT: Failed. Compilation failed -------------------------------------------------- Test results: passed: 3; failed: 2 Report written to /tmp/jprt/temp/P1/T/074413.daemon/source/test/JTREG_OUTPUT_linux_i686/sun/module/JTreport/report.html Results written to /tmp/jprt/temp/P1/T/074413.daemon/source/test/JTREG_OUTPUT_linux_i686/sun/module/JTwork Error: Some tests failed or other problems occurred. --------------------------------------------------- Extracting passed and failed counts from jtreg output Test results: passed: 3; failed: 2 ERROR: Failed pattern but no failed count in results --------------------------------------------------- Summary: sun/module/repository/ExpandedJamRepositoryTest.java Passed. Execution successful sun/module/repository/ModuleInfoXMLReaderTest.java Passed. Execution successful sun/module/repository/RepositoryConfigTest.java Failed. Compilation failed sun/module/repository/RepositoryTest.java Passed. Execution successful sun/module/tools/JRepoTest.java Failed. Compilation failed --------------------------------------------------- JTREG TOTAL: passed=0 failed=1 zip -q -r /opt/jprt/temp/P1/T/074413.daemon/bundles/linux_i586-product-c2-sun_module.zip JTREG_OUTPUT_linux_i686 JTREG FAILED make: *** [tests] Error 1 ########################################################### # # Finished: Mon Jul 30 01:29:33 PDT 2007 # # Disk Space: # Filesystem 1k-blocks Used Available Use% Mounted on # /dev/sda2 66357620 12855320 50131464 21% / # # returned exit code 2 # ########################################################### ------------------------------------------------------------------------------ For announcements on downtime and availability join the alias 'jprt-announce at sun.com'. You can see the latest announcements at http://archives.central/tm/browse?jprt-announce. For suspected system problems, send mail to 'jprt-admin at sun.com'. The jprt how to document is available at http://javaweb.sfbay/jdk/jprt/dist/javadoc/jprt/doc-files/how-to.html. From jprtadm at jprt-web.SFBay.Sun.COM Mon Jul 30 05:28:50 2007 From: jprtadm at jprt-web.SFBay.Sun.COM (JPRT Administrator) Date: Mon, 30 Jul 2007 05:28:50 -0700 (PDT) Subject: [modules-dev] JPRT: job notification - FAILED with job 2007-07-30-111310.as130790.ws Message-ID: <200707301228.l6UCSohm001050@jprt-web.SFBay.Sun.COM> JPRT: job notification - FAILED with job 2007-07-30-111310.as130790.ws Failure reason: Test target failure: windows_i586-product-c2-java/module windows_x64-product-c2-java/module solaris_sparc-product-c2-sun/module solaris_sparcv9-product-c2-sun/module solaris_i586-product-c2-sun/module solaris_x64-product-c2-sun/module linux_i586-product-c2-sun/module linux_x64-product-c2-sun/module windows_i586-product-c2-sun/module windows_x64-product-c2-sun/module JPRT Job ID: 2007-07-30-111310.as130790.ws JPRT System Used: sfbay JPRT Version Used: 29 July 2007 - National Lasagna Day Job URL: http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-30-111310.as130790.ws User: as130790 Email: modules-dev at openjdk.java.net Release: jdk1.7.0 Job Source: Source Tree: /net/shimmer.sfbay/export/home/jsr277/ws/{make,src} File List: {.} Command Line: jprt submit -stree ../ws -ot '.*product.*' -noquickabort -email modules-dev at openjdk.java.net -rtests '*-*-c2-java/module' -rtests '*-*-c2-sun/module' Job submitted at: Mon-11:13:04-GMT Total time in queue: 1h 15m 45s Job started at: Mon-11:18:34-GMT Job finished at: Mon-12:28:49-GMT Job run time: 1h 10m 15s Job state: FAILED Job fail/kill comment: Test target failure: windows_i586-product-c2-java/module windows_x64-product-c2-java/module solaris_sparc-product-c2-sun/module solaris_sparcv9-product-c2-sun/module solaris_i586-product-c2-sun/module solaris_x64-product-c2-sun/module linux_i586-product-c2-sun/module linux_x64-product-c2-sun/module windows_i586-product-c2-sun/module windows_x64-product-c2-sun/module Job flags: Bundles: USE: jprt install 2007-07-30-111310.as130790.ws HINT: Use 'jprt rerun -comment 2007-07-30-111310.as130790.ws' to rerun this job if you suspect bogus results. User Comments: null Build (Release:jdk1.7.0 Boot: Import:): solaris_sparc_5.8-product success(27m 32s elapsed) solaris_sparcv9_5.8-product success(28m 45s elapsed) solaris_i586_5.8-product success(54m 08s elapsed) solaris_x64_5.10-product success(10m 58s elapsed) linux_i586_2.4-product success(11m 19s elapsed) linux_x64_2.4-product success(14m 37s elapsed) windows_i586_5-product success(37m 51s elapsed) windows_x64_5.2-product success(43m 33s elapsed) Tests: solaris_sparc-product-c2-jvm98 success(03m 20s elapsed) solaris_sparcv9-product-c2-jvm98 success(02m 50s elapsed) NOTE: Used solaris_sparc_5.10 for above target. solaris_i586-product-c2-jvm98 success(02m 55s elapsed) solaris_x64-product-c2-jvm98 success(02m 03s elapsed) linux_i586-product-c2-jvm98 success(02m 21s elapsed) linux_x64-product-c2-jvm98 success(01m 40s elapsed) windows_i586-product-c2-jvm98 success(03m 10s elapsed) windows_x64-product-c2-jvm98 success(01m 53s elapsed) solaris_sparc-product-c2-java/module success(03m 29s elapsed) NOTE: Used solaris_sparc_5.10 for above target. solaris_sparcv9-product-c2-java/module success(04m 11s elapsed) NOTE: Used solaris_sparc_5.10 for above target. solaris_i586-product-c2-java/module success(09m 45s elapsed) solaris_x64-product-c2-java/module success(01m 47s elapsed) linux_i586-product-c2-java/module success(02m 32s elapsed) linux_x64-product-c2-java/module success(01m 35s elapsed) windows_i586-product-c2-java/module FAILED(05m 22s elapsed) windows_x64-product-c2-java/module FAILED(03m 29s elapsed) solaris_sparc-product-c2-sun/module FAILED( 30s elapsed) NOTE: Used solaris_sparc_5.10 for above target. solaris_sparcv9-product-c2-sun/module FAILED( 31s elapsed) NOTE: Used solaris_sparc_5.10 for above target. solaris_i586-product-c2-sun/module FAILED(08m 23s elapsed) solaris_x64-product-c2-sun/module FAILED( 15s elapsed) linux_i586-product-c2-sun/module FAILED( 41s elapsed) linux_x64-product-c2-sun/module FAILED( 19s elapsed) windows_i586-product-c2-sun/module FAILED(03m 15s elapsed) windows_x64-product-c2-sun/module FAILED(02m 47s elapsed) ------------------------------------------------------------------------------ windows_i586-product-c2-java/module (details from log file) /net/jprt-web.sfbay/jprt/archive/2007/07/2007-07-30-111310.as130790.ws/logs/windows_i586-product-c2-java_module-test.log http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-30-111310.as130790.ws//logs/windows_i586-product-c2-java_module-test.log -------------------------------------------------- Test results: passed: 9; failed: 5 Report written to C:\jprt\temp\P1\T\111310.as130790\source\test\JTREG_OUTPUT_windows_i586\java\module\JTreport\report.html Results written to C:\jprt\temp\P1\T\111310.as130790\source\test\JTREG_OUTPUT_windows_i586\java\module\JTwork Error: Some tests failed or other problems occurred. --------------------------------------------------- Extracting passed and failed counts from jtreg output Test results: passed: 9; failed: 5 ERROR: Failed pattern but no failed count in results --------------------------------------------------- Summary: java/module/basic/BasicLauncherTests.java Failed. Execution failed: `main' threw exception: java.lang.AssertionError: Some tests failed java/module/config/DefaultImportOverridePolicy/DefaultImportOverridePolicyTest.java Passed. Compilation successful java/module/config/DefaultVisibilityPolicy/DefaultVisibilityPolicyTest.java Passed. Compilation successful java/module/config/ImportOverridePolicyFile/ImportOverridePolicyFileTest.java Passed. Compilation successful java/module/config/VisibilityPolicyFile/VisibilityPolicyFileTest.java Passed. Compilation successful java/module/modinit/RunMTest.java Failed. Execution failed: `main' threw exception: java.lang.IllegalArgumentException: Cannot create repository for 'extension': null java/module/query/QueryTest.java Passed. Execution successful java/module/repository/LocalRepositoryTest.java Failed. Execution failed: `main' threw exception: java.lang.AssertionError: Some tests failed java/module/repository/Test6574851.java Passed. Compilation successful java/module/repository/Test6574852.java Passed. Compilation successful java/module/repository/URLRepositoryTest.java Failed. Execution failed: `main' threw exception: java.lang.AssertionError: Some tests failed java/module/repository/VisibilityPolicyTest.java Failed. Execution failed: `main' threw exception: java.lang.AssertionError: Some tests failed java/module/version/VersionConstraintTest.java Passed. Execution successful java/module/version/VersionTest.java Passed. Execution successful --------------------------------------------------- JTREG TOTAL: passed=0 failed=1 zip -q -r C:/jprt/temp/P1/T/111310.as130790/bundles/windows_i586-product-c2-java_module.zip JTREG_OUTPUT_windows_i586 JTREG FAILED C:\jprt\slashjava\devtools\win32\bin\gnumake.exe: *** [tests] Error 1 ########################################################### # # Finished: Mon Jul 30 05:17:35 PDT 2007 # # Disk Space: # C:/ (C:/) 10623548/39070048 # # returned exit code 2 # ########################################################### ------------------------------------------------------------------------------ ------------------------------------------------------------------------------ windows_x64-product-c2-java/module (details from log file) /net/jprt-web.sfbay/jprt/archive/2007/07/2007-07-30-111310.as130790.ws/logs/windows_x64-product-c2-java_module-test.log http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-30-111310.as130790.ws//logs/windows_x64-product-c2-java_module-test.log -------------------------------------------------- Test results: passed: 9; failed: 5 Report written to C:\jprt\temp\P1\T\111310.as130790\source\test\JTREG_OUTPUT_windows_x64\java\module\JTreport\report.html Results written to C:\jprt\temp\P1\T\111310.as130790\source\test\JTREG_OUTPUT_windows_x64\java\module\JTwork Error: Some tests failed or other problems occurred. --------------------------------------------------- Extracting passed and failed counts from jtreg output Test results: passed: 9; failed: 5 ERROR: Failed pattern but no failed count in results --------------------------------------------------- Summary: java/module/basic/BasicLauncherTests.java Failed. Execution failed: `main' threw exception: java.lang.AssertionError: Some tests failed java/module/config/DefaultImportOverridePolicy/DefaultImportOverridePolicyTest.java Passed. Compilation successful java/module/config/DefaultVisibilityPolicy/DefaultVisibilityPolicyTest.java Passed. Compilation successful java/module/config/ImportOverridePolicyFile/ImportOverridePolicyFileTest.java Passed. Compilation successful java/module/config/VisibilityPolicyFile/VisibilityPolicyFileTest.java Passed. Compilation successful java/module/modinit/RunMTest.java Failed. Execution failed: `main' threw exception: java.lang.IllegalArgumentException: Cannot create repository for 'extension': null java/module/query/QueryTest.java Passed. Execution successful java/module/repository/LocalRepositoryTest.java Failed. Execution failed: `main' threw exception: java.lang.AssertionError: Some tests failed java/module/repository/Test6574851.java Passed. Compilation successful java/module/repository/Test6574852.java Passed. Compilation successful java/module/repository/URLRepositoryTest.java Failed. Execution failed: `main' threw exception: java.lang.AssertionError: Some tests failed java/module/repository/VisibilityPolicyTest.java Failed. Execution failed: `main' threw exception: java.lang.AssertionError: Some tests failed java/module/version/VersionConstraintTest.java Passed. Execution successful java/module/version/VersionTest.java Passed. Execution successful --------------------------------------------------- JTREG TOTAL: passed=0 failed=1 zip -q -r C:/jprt/temp/P1/T/111310.as130790/bundles/windows_x64-product-c2-java_module.zip JTREG_OUTPUT_windows_x64 JTREG FAILED C:\jprt\slashjava\devtools\win32\bin\gnumake.exe: *** [tests] Error 1 ########################################################### # # Finished: Mon Jul 30 05:15:10 PDT 2007 # # Disk Space: # C:/ (C:/) 47158184/71577572 # # returned exit code 2 # ########################################################### ------------------------------------------------------------------------------ ------------------------------------------------------------------------------ solaris_sparc-product-c2-sun/module (details from log file) /net/jprt-web.sfbay/jprt/archive/2007/07/2007-07-30-111310.as130790.ws/logs/solaris_sparc-product-c2-sun_module-test.log http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-30-111310.as130790.ws//logs/solaris_sparc-product-c2-sun_module-test.log /tmp/jprt/temp/P1/T/111310.as130790/source/test/sun/module/tools/JRepoTest.java:42: cannot find symbol symbol : class JRepo location: class JRepoTest JRepo jr = new JRepo(new PrintStream(bout), new PrintStream(berr)); ^ 3 errors TEST RESULT: Failed. Compilation failed -------------------------------------------------- Test results: passed: 3; failed: 2 Report written to /tmp/jprt/temp/P1/T/111310.as130790/source/test/JTREG_OUTPUT_solaris_sparc/sun/module/JTreport/report.html Results written to /tmp/jprt/temp/P1/T/111310.as130790/source/test/JTREG_OUTPUT_solaris_sparc/sun/module/JTwork Error: Some tests failed or other problems occurred. --------------------------------------------------- Extracting passed and failed counts from jtreg output Test results: passed: 3; failed: 2 ERROR: Failed pattern but no failed count in results --------------------------------------------------- Summary: sun/module/repository/ExpandedJamRepositoryTest.java Passed. Execution successful sun/module/repository/ModuleInfoXMLReaderTest.java Passed. Execution successful sun/module/repository/RepositoryConfigTest.java Failed. Compilation failed sun/module/repository/RepositoryTest.java Passed. Execution successful sun/module/tools/JRepoTest.java Failed. Compilation failed --------------------------------------------------- JTREG TOTAL: passed=0 failed=1 zip -q -r /opt/jprt/temp/P1/T/111310.as130790/bundles/solaris_sparc-product-c2-sun_module.zip JTREG_OUTPUT_solaris_sparc JTREG FAILED gmake: *** [tests] Error 1 ########################################################### # # Finished: Mon Jul 30 04:46:59 PDT 2007 # # Disk Space: # Filesystem kbytes used avail capacity Mounted on # swap 25909976 2878896 23031080 12% /tmp # # returned exit code 2 # ########################################################### ------------------------------------------------------------------------------ ------------------------------------------------------------------------------ solaris_sparcv9-product-c2-sun/module (details from log file) /net/jprt-web.sfbay/jprt/archive/2007/07/2007-07-30-111310.as130790.ws/logs/solaris_sparcv9-product-c2-sun_module-test.log http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-30-111310.as130790.ws//logs/solaris_sparcv9-product-c2-sun_module-test.log /tmp/jprt/temp/T2/T/111310.as130790/source/test/sun/module/tools/JRepoTest.java:42: cannot find symbol symbol : class JRepo location: class JRepoTest JRepo jr = new JRepo(new PrintStream(bout), new PrintStream(berr)); ^ 3 errors TEST RESULT: Failed. Compilation failed -------------------------------------------------- Test results: passed: 3; failed: 2 Report written to /tmp/jprt/temp/T2/T/111310.as130790/source/test/JTREG_OUTPUT_solaris_sparc/sun/module/JTreport/report.html Results written to /tmp/jprt/temp/T2/T/111310.as130790/source/test/JTREG_OUTPUT_solaris_sparc/sun/module/JTwork Error: Some tests failed or other problems occurred. --------------------------------------------------- Extracting passed and failed counts from jtreg output Test results: passed: 3; failed: 2 ERROR: Failed pattern but no failed count in results --------------------------------------------------- Summary: sun/module/repository/ExpandedJamRepositoryTest.java Passed. Execution successful sun/module/repository/ModuleInfoXMLReaderTest.java Passed. Execution successful sun/module/repository/RepositoryConfigTest.java Failed. Compilation failed sun/module/repository/RepositoryTest.java Passed. Execution successful sun/module/tools/JRepoTest.java Failed. Compilation failed --------------------------------------------------- JTREG TOTAL: passed=0 failed=1 zip -q -r /opt/jprt/temp/T2/T/111310.as130790/bundles/solaris_sparcv9-product-c2-sun_module.zip JTREG_OUTPUT_solaris_sparc JTREG FAILED gmake: *** [tests] Error 1 ########################################################### # # Finished: Mon Jul 30 04:48:21 PDT 2007 # # Disk Space: # Filesystem kbytes used avail capacity Mounted on # swap 25181504 3297000 21884504 14% /tmp # # returned exit code 2 # ########################################################### ------------------------------------------------------------------------------ ------------------------------------------------------------------------------ solaris_i586-product-c2-sun/module (details from log file) /net/jprt-web.sfbay/jprt/archive/2007/07/2007-07-30-111310.as130790.ws/logs/solaris_i586-product-c2-sun_module-test.log http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-30-111310.as130790.ws//logs/solaris_i586-product-c2-sun_module-test.log /opt/jprt/temp/P1/T/111310.as130790/source/test/sun/module/tools/JRepoTest.java:42: cannot find symbol symbol : class JRepo location: class JRepoTest JRepo jr = new JRepo(new PrintStream(bout), new PrintStream(berr)); ^ 3 errors TEST RESULT: Failed. Compilation failed -------------------------------------------------- Test results: passed: 3; failed: 2 Report written to /opt/jprt/temp/P1/T/111310.as130790/source/test/JTREG_OUTPUT_solaris_i586/sun/module/JTreport/report.html Results written to /opt/jprt/temp/P1/T/111310.as130790/source/test/JTREG_OUTPUT_solaris_i586/sun/module/JTwork Error: Some tests failed or other problems occurred. --------------------------------------------------- Extracting passed and failed counts from jtreg output Test results: passed: 3; failed: 2 ERROR: Failed pattern but no failed count in results --------------------------------------------------- Summary: sun/module/repository/ExpandedJamRepositoryTest.java Passed. Execution successful sun/module/repository/ModuleInfoXMLReaderTest.java Passed. Execution successful sun/module/repository/RepositoryConfigTest.java Failed. Compilation failed sun/module/repository/RepositoryTest.java Passed. Execution successful sun/module/tools/JRepoTest.java Failed. Compilation failed --------------------------------------------------- JTREG TOTAL: passed=0 failed=1 zip -q -r /opt/jprt/temp/P1/T/111310.as130790/bundles/solaris_i586-product-c2-sun_module.zip JTREG_OUTPUT_solaris_i586 JTREG FAILED gmake: *** [tests] Error 1 ########################################################### # # Finished: Mon Jul 30 05:27:08 PDT 2007 # # Disk Space: # Filesystem kbytes used avail capacity Mounted on # /dev/dsk/c1t0d0s0 30862987 9354044 21200314 31% / # # returned exit code 2 # ########################################################### ------------------------------------------------------------------------------ ------------------------------------------------------------------------------ solaris_x64-product-c2-sun/module (details from log file) /net/jprt-web.sfbay/jprt/archive/2007/07/2007-07-30-111310.as130790.ws/logs/solaris_x64-product-c2-sun_module-test.log http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-30-111310.as130790.ws//logs/solaris_x64-product-c2-sun_module-test.log /tmp/jprt/temp/P1/T/111310.as130790/source/test/sun/module/tools/JRepoTest.java:42: cannot find symbol symbol : class JRepo location: class JRepoTest JRepo jr = new JRepo(new PrintStream(bout), new PrintStream(berr)); ^ 3 errors TEST RESULT: Failed. Compilation failed -------------------------------------------------- Test results: passed: 3; failed: 2 Report written to /tmp/jprt/temp/P1/T/111310.as130790/source/test/JTREG_OUTPUT_solaris_i586/sun/module/JTreport/report.html Results written to /tmp/jprt/temp/P1/T/111310.as130790/source/test/JTREG_OUTPUT_solaris_i586/sun/module/JTwork Error: Some tests failed or other problems occurred. --------------------------------------------------- Extracting passed and failed counts from jtreg output Test results: passed: 3; failed: 2 ERROR: Failed pattern but no failed count in results --------------------------------------------------- Summary: sun/module/repository/ExpandedJamRepositoryTest.java Passed. Execution successful sun/module/repository/ModuleInfoXMLReaderTest.java Passed. Execution successful sun/module/repository/RepositoryConfigTest.java Failed. Compilation failed sun/module/repository/RepositoryTest.java Passed. Execution successful sun/module/tools/JRepoTest.java Failed. Compilation failed --------------------------------------------------- JTREG TOTAL: passed=0 failed=1 zip -q -r /opt/jprt/temp/P1/T/111310.as130790/bundles/solaris_x64-product-c2-sun_module.zip JTREG_OUTPUT_solaris_i586 JTREG FAILED gmake: *** [tests] Error 1 ########################################################### # # Finished: Mon Jul 30 05:20:59 PDT 2007 # # Disk Space: # Filesystem kbytes used avail capacity Mounted on # swap 34505688 1009544 33496144 3% /tmp # # returned exit code 2 # ########################################################### ------------------------------------------------------------------------------ ------------------------------------------------------------------------------ linux_i586-product-c2-sun/module (details from log file) /net/jprt-web.sfbay/jprt/archive/2007/07/2007-07-30-111310.as130790.ws/logs/linux_i586-product-c2-sun_module-test.log http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-30-111310.as130790.ws//logs/linux_i586-product-c2-sun_module-test.log /tmp/jprt/temp/P1/T/111310.as130790/source/test/sun/module/tools/JRepoTest.java:42: cannot find symbol symbol : class JRepo location: class JRepoTest JRepo jr = new JRepo(new PrintStream(bout), new PrintStream(berr)); ^ 3 errors TEST RESULT: Failed. Compilation failed -------------------------------------------------- Test results: passed: 3; failed: 2 Report written to /tmp/jprt/temp/P1/T/111310.as130790/source/test/JTREG_OUTPUT_linux_i686/sun/module/JTreport/report.html Results written to /tmp/jprt/temp/P1/T/111310.as130790/source/test/JTREG_OUTPUT_linux_i686/sun/module/JTwork Error: Some tests failed or other problems occurred. --------------------------------------------------- Extracting passed and failed counts from jtreg output Test results: passed: 3; failed: 2 ERROR: Failed pattern but no failed count in results --------------------------------------------------- Summary: sun/module/repository/ExpandedJamRepositoryTest.java Passed. Execution successful sun/module/repository/ModuleInfoXMLReaderTest.java Passed. Execution successful sun/module/repository/RepositoryConfigTest.java Failed. Compilation failed sun/module/repository/RepositoryTest.java Passed. Execution successful sun/module/tools/JRepoTest.java Failed. Compilation failed --------------------------------------------------- JTREG TOTAL: passed=0 failed=1 zip -q -r /opt/jprt/temp/P1/T/111310.as130790/bundles/linux_i586-product-c2-sun_module.zip JTREG_OUTPUT_linux_i686 JTREG FAILED make: *** [tests] Error 1 ########################################################### # # Finished: Mon Jul 30 04:38:42 PDT 2007 # # Disk Space: # Filesystem 1k-blocks Used Available Use% Mounted on # /dev/sda2 66357620 12823444 50163340 21% / # # returned exit code 2 # ########################################################### ------------------------------------------------------------------------------ ------------------------------------------------------------------------------ linux_x64-product-c2-sun/module (details from log file) /net/jprt-web.sfbay/jprt/archive/2007/07/2007-07-30-111310.as130790.ws/logs/linux_x64-product-c2-sun_module-test.log http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-30-111310.as130790.ws//logs/linux_x64-product-c2-sun_module-test.log /tmp/jprt/temp/P1/T/111310.as130790/source/test/sun/module/tools/JRepoTest.java:42: cannot find symbol symbol : class JRepo location: class JRepoTest JRepo jr = new JRepo(new PrintStream(bout), new PrintStream(berr)); ^ 3 errors TEST RESULT: Failed. Compilation failed -------------------------------------------------- Test results: passed: 3; failed: 2 Report written to /tmp/jprt/temp/P1/T/111310.as130790/source/test/JTREG_OUTPUT_linux_x86_64/sun/module/JTreport/report.html Results written to /tmp/jprt/temp/P1/T/111310.as130790/source/test/JTREG_OUTPUT_linux_x86_64/sun/module/JTwork Error: Some tests failed or other problems occurred. --------------------------------------------------- Extracting passed and failed counts from jtreg output Test results: passed: 3; failed: 2 ERROR: Failed pattern but no failed count in results --------------------------------------------------- Summary: sun/module/repository/ExpandedJamRepositoryTest.java Passed. Execution successful sun/module/repository/ModuleInfoXMLReaderTest.java Passed. Execution successful sun/module/repository/RepositoryConfigTest.java Failed. Compilation failed sun/module/repository/RepositoryTest.java Passed. Execution successful sun/module/tools/JRepoTest.java Failed. Compilation failed --------------------------------------------------- JTREG TOTAL: passed=0 failed=1 zip -q -r /opt/jprt/temp/P1/T/111310.as130790/bundles/linux_x64-product-c2-sun_module.zip JTREG_OUTPUT_linux_x86_64 JTREG FAILED make: *** [tests] Error 1 ########################################################### # # Finished: Mon Jul 30 04:40:58 PDT 2007 # # Disk Space: # Filesystem 1K-blocks Used Available Use% Mounted on # /dev/sda2 67470936 11086360 56384576 17% / # # returned exit code 2 # ########################################################### ------------------------------------------------------------------------------ ------------------------------------------------------------------------------ windows_i586-product-c2-sun/module (details from log file) /net/jprt-web.sfbay/jprt/archive/2007/07/2007-07-30-111310.as130790.ws/logs/windows_i586-product-c2-sun_module-test.log http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-30-111310.as130790.ws//logs/windows_i586-product-c2-sun_module-test.log ^ C:\jprt\temp\P1\T\111310.as130790\source\test\sun\module\tools\JRepoTest.java:42: cannot find symbol symbol : class JRepo location: class JRepoTest JRepo jr = new JRepo(new PrintStream(bout), new PrintStream(berr)); ^ 3 errors TEST RESULT: Failed. Compilation failed -------------------------------------------------- Test results: passed: 2; failed: 3 Report written to C:\jprt\temp\P1\T\111310.as130790\source\test\JTREG_OUTPUT_windows_i586\sun\module\JTreport\report.html Results written to C:\jprt\temp\P1\T\111310.as130790\source\test\JTREG_OUTPUT_windows_i586\sun\module\JTwork Error: Some tests failed or other problems occurred. --------------------------------------------------- Extracting passed and failed counts from jtreg output Test results: passed: 2; failed: 3 ERROR: Failed pattern but no failed count in results --------------------------------------------------- Summary: sun/module/repository/ExpandedJamRepositoryTest.java Passed. Execution successful sun/module/repository/ModuleInfoXMLReaderTest.java Passed. Execution successful sun/module/repository/RepositoryConfigTest.java Failed. Compilation failed sun/module/repository/RepositoryTest.java Failed. Execution failed: `main' threw exception: java.lang.AssertionError: Some tests failed sun/module/tools/JRepoTest.java Failed. Compilation failed --------------------------------------------------- JTREG TOTAL: passed=0 failed=1 zip -q -r C:/jprt/temp/P1/T/111310.as130790/bundles/windows_i586-product-c2-sun_module.zip JTREG_OUTPUT_windows_i586 JTREG FAILED C:\jprt\slashjava\devtools\win32\bin\gnumake.exe: *** [tests] Error 1 ########################################################### # # Finished: Mon Jul 30 05:11:41 PDT 2007 # # Disk Space: # C:/ (C:/) 14149936/39070048 # # returned exit code 2 # ########################################################### ------------------------------------------------------------------------------ ------------------------------------------------------------------------------ windows_x64-product-c2-sun/module (details from log file) /net/jprt-web.sfbay/jprt/archive/2007/07/2007-07-30-111310.as130790.ws/logs/windows_x64-product-c2-sun_module-test.log http://javaweb.sfbay/jdk/jprt/archive/2007/07/2007-07-30-111310.as130790.ws//logs/windows_x64-product-c2-sun_module-test.log ^ C:\jprt\temp\P1\T\111310.as130790\source\test\sun\module\tools\JRepoTest.java:42: cannot find symbol symbol : class JRepo location: class JRepoTest JRepo jr = new JRepo(new PrintStream(bout), new PrintStream(berr)); ^ 3 errors TEST RESULT: Failed. Compilation failed -------------------------------------------------- Test results: passed: 2; failed: 3 Report written to C:\jprt\temp\P1\T\111310.as130790\source\test\JTREG_OUTPUT_windows_x64\sun\module\JTreport\report.html Results written to C:\jprt\temp\P1\T\111310.as130790\source\test\JTREG_OUTPUT_windows_x64\sun\module\JTwork Error: Some tests failed or other problems occurred. --------------------------------------------------- Extracting passed and failed counts from jtreg output Test results: passed: 2; failed: 3 ERROR: Failed pattern but no failed count in results --------------------------------------------------- Summary: sun/module/repository/ExpandedJamRepositoryTest.java Passed. Execution successful sun/module/repository/ModuleInfoXMLReaderTest.java Passed. Execution successful sun/module/repository/RepositoryConfigTest.java Failed. Compilation failed sun/module/repository/RepositoryTest.java Failed. Execution failed: `main' threw exception: java.lang.AssertionError: Some tests failed sun/module/tools/JRepoTest.java Failed. Compilation failed --------------------------------------------------- JTREG TOTAL: passed=0 failed=1 zip -q -r C:/jprt/temp/P1/T/111310.as130790/bundles/windows_x64-product-c2-sun_module.zip JTREG_OUTPUT_windows_x64 JTREG FAILED C:\jprt\slashjava\devtools\win32\bin\gnumake.exe: *** [tests] Error 1 ########################################################### # # Finished: Mon Jul 30 05:16:37 PDT 2007 # # Disk Space: # C:/ (C:/) 47456592/71577572 # # returned exit code 2 # ########################################################### ------------------------------------------------------------------------------ For announcements on downtime and availability join the alias 'jprt-announce at sun.com'. You can see the latest announcements at http://archives.central/tm/browse?jprt-announce. For suspected system problems, send mail to 'jprt-admin at sun.com'. The jprt how to document is available at http://javaweb.sfbay/jdk/jprt/dist/javadoc/jprt/doc-files/how-to.html. From andreas.sterbenz at sun.com Mon Jul 30 06:00:30 2007 From: andreas.sterbenz at sun.com (andreas.sterbenz at sun.com) Date: Mon, 30 Jul 2007 06:00:30 -0700 (PDT) Subject: [modules-dev] Open Bugs/RFEs in java/module Message-ID: <200707301300.l6UD0UE5009186@shimmer.sfbay.sun.com> An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/modules-dev/attachments/20070730/4fa80b81/attachment.html From Kumar.Srinivasan at Sun.COM Mon Jul 30 12:37:29 2007 From: Kumar.Srinivasan at Sun.COM (Kumar Srinivasan) Date: Mon, 30 Jul 2007 12:37:29 -0700 Subject: [modules-dev] Review please for launcher bugs In-Reply-To: <46A79309.4080702@sun.com> References: <46A648EA.9020604@Sun.COM> <46A79309.4080702@sun.com> Message-ID: <46AE3DF9.1010409@Sun.COM> Thanks for all the comments, I have consolidated all the comments here. Please see my embedded responses. Thanks Andreas------ > . there should be a check for "definition == null" in > getModuleDefinitionFromJam() that throws an appropriate exception if we > don't find the module. It could be null if the JAM file is corrupt. Yes will add a check and throw an exception. ------------------------------------------------------------------- Stanley---------- > I think what is unclear is that Kumar's fix checks if the filename > returned from ModuleArchiveInfo ends with JamUtils.EXPANDED_EXT, and > this kinda implies that the repository implementation is returning an > internal cached jam filename in this case. Hmm, I will assume the file is blah.jar-expanded for now, Dave can remove the -expanded when he puts the fix into the repository. ------------------------------------------------------------------- Dave Bristor------ > > - src/share/classes/sun/module/ModuleLauncher.java > > 147 private static Repository repository = null; > > Please put this and all other field declarations at the top of the file, not > in the middle. > Ok > 188 String fname = new File(jamFileName).getName(); > 189 String moduleName = fname.substring(0, fname.lastIndexOf('.')); > 190 List ilist = repository.list(); > 191 for (ModuleArchiveInfo i : ilist) { > 192 if (i.getFileName().endsWith(fname + JamUtils.EXPANDED_EXT)) { > 193 definition = getModuleDefinition(repository, i.getName()); > 194 break; > 195 } > 196 } > > I remain somewhat bewildered by this: could you explain? Yes, the directory containing the jam becomes the system repository as the bug 6580159, therefore I create a LocalRepository, once I found that I need to get the moduleDefinition of the given JAM-file. Does that make sense ? > Also, line 188 could be > String fname = baseDir.getName(); > though perhaps baseDir should be renamed jamFile (since it's not a base > directory). > Yowsa, Its somewhat confusing here with the naming, I will clean it up. > 207 if (!jamFileName.endsWith(".jam") && > !jamFileName.endsWith(".jar")) { > 208 throw new IllegalArgumentException("jam filename must > have a .jam or .jar extension"); > > Shouldn't .jam.pack.gz also be allowed? Or is that just not-yet-implemented? > (I know it's not fully supported elsewhere...) > Good question!. Is .jam.pack.gz allowed ? I did not see it in the original specification. http://j2se.sfbay.sun.com/web/bin/view/J2SE/JamsProposedToolsSupport > 231 throw new Exception("Repository not found at " + > repFile.toString()); > > Should this also be IllegalArgumentException? > I was thinking about that. I will change them to IllegalArgumentException. > - test/java/module/basic/BasicLauncherTests.java > > 260 static String expRepository; > 261 static String jamRepository; > 262 static String urlRepository ; > > Extra space in line 262 and please put fields at beginning of file. > Acknowledged. > Several other places, why the change from expRepository to urlRepository? I > might have thought an addition would be appropriate; was removal of > expRepository intentional? > Nothing was removed instead of using expRepository I am using urlRepository to test, also I renamed httpRepository to the more generic one urlRepository. To address CR: 6580122. > Kumar Srinivasan wrote: > >> Hi, >> >> I need a review of these fixes asap. >> http://javaweb.sfbay/~ksrini/webrevs/j2se-tools/jsr277-6/ >> [The webrev contains the CRs]. >> >> Built and tested on Solaris and Windows all the regresssion >> tests in test/java/module pass. >> >> Thanks >> >> > _______________________________________________ > modules-dev mailing list > modules-dev at openjdk.java.net > http://mail.openjdk.java.net/mailman/listinfo/modules-dev > -- Kumar Srinivasan Sun Microsystems, Java Software. 408-276-7586 From David.Bristor at Sun.COM Mon Jul 30 14:40:57 2007 From: David.Bristor at Sun.COM (Dave Bristor) Date: Mon, 30 Jul 2007 14:40:57 -0700 Subject: [modules-dev] Review please for launcher bugs In-Reply-To: <46AE3DF9.1010409@Sun.COM> References: <46A648EA.9020604@Sun.COM> <46A79309.4080702@sun.com> <46AE3DF9.1010409@Sun.COM> Message-ID: <46AE5AE9.4070409@sun.com> Kumar Srinivasan wrote: > Thanks for all the comments, I have consolidated all the comments here. > Please see my embedded responses. > Thanks > > > Andreas------ >> . there should be a check for "definition == null" in >> getModuleDefinitionFromJam() that throws an appropriate exception if >> we don't find the module. It could be null if the JAM file is corrupt. > Yes will add a check and throw an exception. > > ------------------------------------------------------------------- > > Stanley---------- >> I think what is unclear is that Kumar's fix checks if the filename >> returned from ModuleArchiveInfo ends with JamUtils.EXPANDED_EXT, and >> this kinda implies that the repository implementation is returning an >> internal cached jam filename in this case. > Hmm, I will assume the file is blah.jar-expanded for now, Dave can > remove the > -expanded when he puts the fix into the repository. I added a note about this to 6582244. > ------------------------------------------------------------------- > > Dave Bristor------ >> >> - src/share/classes/sun/module/ModuleLauncher.java >> >> 147 private static Repository repository = null; >> >> Please put this and all other field declarations at the top of the >> file, not in the middle. >> > Ok > >> 188 String fname = new File(jamFileName).getName(); >> 189 String moduleName = fname.substring(0, >> fname.lastIndexOf('.')); >> 190 List ilist = repository.list(); >> 191 for (ModuleArchiveInfo i : ilist) { >> 192 if (i.getFileName().endsWith(fname + >> JamUtils.EXPANDED_EXT)) { >> 193 definition = getModuleDefinition(repository, >> i.getName()); >> 194 break; >> 195 } >> 196 } >> >> I remain somewhat bewildered by this: could you explain? > Yes, the directory containing the jam becomes the system repository as > the bug 6580159, > therefore I create a LocalRepository, once I found that I need to get > the moduleDefinition > of the given JAM-file. Does that make sense ? I understand from earlier email what's going on, but using the jamFileName in expectation of it being part of the module name is not a 100% solution, since there's no required correspondence. >> Also, line 188 could be >> String fname = baseDir.getName(); >> though perhaps baseDir should be renamed jamFile (since it's not a >> base directory). >> > Yowsa, Its somewhat confusing here with the naming, I will clean it up. > >> 207 if (!jamFileName.endsWith(".jam") && >> !jamFileName.endsWith(".jar")) { >> 208 throw new IllegalArgumentException("jam filename >> must have a .jam or .jar extension"); >> >> Shouldn't .jam.pack.gz also be allowed? Or is that just >> not-yet-implemented? (I know it's not fully supported elsewhere...) >> > Good question!. Is .jam.pack.gz allowed ? I did not see it in the > original specification. > http://j2se.sfbay.sun.com/web/bin/view/J2SE/JamsProposedToolsSupport What I see on that page is mention of options like "... -jam file ..." and I assumed that a .jam.pack.gz would also be acceptable. Once I implement 6566022, it should be possible to use them in local repositories. >> 231 throw new Exception("Repository not >> found at " + repFile.toString()); >> >> Should this also be IllegalArgumentException? >> > I was thinking about that. I will change them to IllegalArgumentException. >> - test/java/module/basic/BasicLauncherTests.java >> >> 260 static String expRepository; >> 261 static String jamRepository; >> 262 static String urlRepository ; >> >> Extra space in line 262 and please put fields at beginning of file. >> > Acknowledged. > >> Several other places, why the change from expRepository to >> urlRepository? I might have thought an addition would be appropriate; >> was removal of expRepository intentional? >> > Nothing was removed instead of using expRepository I am using urlRepository > to test, also I renamed httpRepository to the more generic one > urlRepository. > To address CR: 6580122. Ah, ok! Thanks, Dave >> Kumar Srinivasan wrote: >> >>> Hi, >>> >>> I need a review of these fixes asap. >>> http://javaweb.sfbay/~ksrini/webrevs/j2se-tools/jsr277-6/ >>> [The webrev contains the CRs]. >>> >>> Built and tested on Solaris and Windows all the regresssion >>> tests in test/java/module pass. >>> >>> Thanks >>> >>> >> _______________________________________________ >> modules-dev mailing list >> modules-dev at openjdk.java.net >> http://mail.openjdk.java.net/mailman/listinfo/modules-dev >> > > From andreas.sterbenz at sun.com Tue Jul 31 06:00:09 2007 From: andreas.sterbenz at sun.com (andreas.sterbenz at sun.com) Date: Tue, 31 Jul 2007 06:00:09 -0700 (PDT) Subject: [modules-dev] Open Bugs/RFEs in java/module Message-ID: <200707311300.l6VD09vP005436@shimmer.sfbay.sun.com> An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/modules-dev/attachments/20070731/48600543/attachment.html From Kumar.Srinivasan at Sun.COM Tue Jul 31 11:37:50 2007 From: Kumar.Srinivasan at Sun.COM (Kumar Srinivasan) Date: Tue, 31 Jul 2007 11:37:50 -0700 Subject: [modules-dev] Review please for launcher bugs In-Reply-To: <46AE5AE9.4070409@sun.com> References: <46A648EA.9020604@Sun.COM> <46A79309.4080702@sun.com> <46AE3DF9.1010409@Sun.COM> <46AE5AE9.4070409@sun.com> Message-ID: <46AF817E.2040108@Sun.COM> Based on all the feedback I have adjusted my previous webrevs, pending putback on Dave's fix for the InvocationTargetEx.: The latest webrev: http://javaweb.sfbay/~ksrini/webrevs/j2se-tools/jsr277-7/ Diff to the first webrev: http://javaweb.sfbay/~ksrini/webrevs/j2se-tools/jsr277-7-vs-6/ The first webrev: http://javaweb.sfbay/~ksrini/webrevs/j2se-tools/jsr277-6/ > Kumar Srinivasan wrote: > >> Thanks for all the comments, I have consolidated all the comments here. >> Please see my embedded responses. >> Thanks >> >> >> Andreas------ >> >>> . there should be a check for "definition == null" in >>> getModuleDefinitionFromJam() that throws an appropriate exception if >>> we don't find the module. It could be null if the JAM file is corrupt. >>> >> Yes will add a check and throw an exception. >> >> ------------------------------------------------------------------- >> >> Stanley---------- >> >>> I think what is unclear is that Kumar's fix checks if the filename >>> returned from ModuleArchiveInfo ends with JamUtils.EXPANDED_EXT, and >>> this kinda implies that the repository implementation is returning an >>> internal cached jam filename in this case. >>> >> Hmm, I will assume the file is blah.jar-expanded for now, Dave can >> remove the >> -expanded when he puts the fix into the repository. >> > > I added a note about this to 6582244. > > >> ------------------------------------------------------------------- >> >> Dave Bristor------ >> >>> - src/share/classes/sun/module/ModuleLauncher.java >>> >>> 147 private static Repository repository = null; >>> >>> Please put this and all other field declarations at the top of the >>> file, not in the middle. >>> >>> >> Ok >> >> >>> 188 String fname = new File(jamFileName).getName(); >>> 189 String moduleName = fname.substring(0, >>> fname.lastIndexOf('.')); >>> 190 List ilist = repository.list(); >>> 191 for (ModuleArchiveInfo i : ilist) { >>> 192 if (i.getFileName().endsWith(fname + >>> JamUtils.EXPANDED_EXT)) { >>> 193 definition = getModuleDefinition(repository, >>> i.getName()); >>> 194 break; >>> 195 } >>> 196 } >>> >>> I remain somewhat bewildered by this: could you explain? >>> >> Yes, the directory containing the jam becomes the system repository as >> the bug 6580159, >> therefore I create a LocalRepository, once I found that I need to get >> the moduleDefinition >> of the given JAM-file. Does that make sense ? >> > > I understand from earlier email what's going on, but using the jamFileName in > expectation of it being part of the module name is not a 100% solution, since > there's no required correspondence. > > >>> Also, line 188 could be >>> String fname = baseDir.getName(); >>> though perhaps baseDir should be renamed jamFile (since it's not a >>> base directory). >>> >>> >> Yowsa, Its somewhat confusing here with the naming, I will clean it up. >> >> >>> 207 if (!jamFileName.endsWith(".jam") && >>> !jamFileName.endsWith(".jar")) { >>> 208 throw new IllegalArgumentException("jam filename >>> must have a .jam or .jar extension"); >>> >>> Shouldn't .jam.pack.gz also be allowed? Or is that just >>> not-yet-implemented? (I know it's not fully supported elsewhere...) >>> >>> >> Good question!. Is .jam.pack.gz allowed ? I did not see it in the >> original specification. >> http://j2se.sfbay.sun.com/web/bin/view/J2SE/JamsProposedToolsSupport >> > > What I see on that page is mention of options like "... -jam file ..." and I > assumed that a .jam.pack.gz would also be acceptable. Once I implement > 6566022, it should be possible to use them in local repositories. > > >>> 231 throw new Exception("Repository not >>> found at " + repFile.toString()); >>> >>> Should this also be IllegalArgumentException? >>> >>> >> I was thinking about that. I will change them to IllegalArgumentException. >> >>> - test/java/module/basic/BasicLauncherTests.java >>> >>> 260 static String expRepository; >>> 261 static String jamRepository; >>> 262 static String urlRepository ; >>> >>> Extra space in line 262 and please put fields at beginning of file. >>> >>> >> Acknowledged. >> >> >>> Several other places, why the change from expRepository to >>> urlRepository? I might have thought an addition would be appropriate; >>> was removal of expRepository intentional? >>> >>> >> Nothing was removed instead of using expRepository I am using urlRepository >> to test, also I renamed httpRepository to the more generic one >> urlRepository. >> To address CR: 6580122. >> > > Ah, ok! > > Thanks, > Dave > > >>> Kumar Srinivasan wrote: >>> >>> >>>> Hi, >>>> >>>> I need a review of these fixes asap. >>>> http://javaweb.sfbay/~ksrini/webrevs/j2se-tools/jsr277-6/ >>>> [The webrev contains the CRs]. >>>> >>>> Built and tested on Solaris and Windows all the regresssion >>>> tests in test/java/module pass. >>>> >>>> Thanks >>>> >>>> >>>> >>> _______________________________________________ >>> modules-dev mailing list >>> modules-dev at openjdk.java.net >>> http://mail.openjdk.java.net/mailman/listinfo/modules-dev >>> >>> >> > _______________________________________________ > modules-dev mailing list > modules-dev at openjdk.java.net > http://mail.openjdk.java.net/mailman/listinfo/modules-dev > -- Kumar Srinivasan Sun Microsystems, Java Software. 408-276-7586