RFR (XS): 8080286: use path separator setting consistently in Nashorn project properties
Michael Haupt
michael.haupt at oracle.com
Wed May 13 13:53:46 UTC 2015
Hi Hannes,
thanks; done: http://cr.openjdk.java.net/~mhaupt/8080286/webrev.01
Best,
Michael
> Am 13.05.2015 um 15:47 schrieb Hannes Wallnoefer <hannes.wallnoefer at oracle.com>:
>
> I just found another instance of a hard coded ":" in make/build.xml, line 191. It should probably be fixed as well.
>
> Hannes
>
> Am 2015-05-13 um 15:42 schrieb Hannes Wallnoefer:
>> Looks good. I can also sponsor it.
>>
>> Hannes
>>
>> Am 2015-05-13 um 15:33 schrieb Michael Haupt:
>>> Hi,
>>>
>>> please review and sponsor this fix:
>>> Webrev: http://cr.openjdk.java.net/~mhaupt/8080286/webrev.00
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8080286
>>>
>>> A problem with this on Windows is that, at least with a very recent ant version (1.9.4), TestNG classes cannot properly be imported into JavaScript because the class path setting is not recognised. Using a platform-independent abstraction for the path separator in the project properties fixes this.
>>>
>>> Best,
>>>
>>> Michael
--
<http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | HotSpot Compiler Team
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
<http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
More information about the nashorn-dev
mailing list