From Alan.Bateman at oracle.com Thu Dec 1 02:21:48 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 01 Dec 2011 10:21:48 +0000 Subject: InetAddress.getLocalHost() returns APIPA/link-local address in a Windows 2008 SP2 or later version Windows OS with multiple-NICs. In-Reply-To: <4ED6D4CA.7090807@linux.vnet.ibm.com> References: <4ED32F97.4070109@linux.vnet.ibm.com> <4ED3573C.7000607@oracle.com> <4ED43F3E.9070300@linux.vnet.ibm.com> <4ED4AA3A.5010504@oracle.com> <4ED6D4CA.7090807@linux.vnet.ibm.com> Message-ID: <4ED7553C.9080007@oracle.com> On 01/12/2011 01:13, Charles Lee wrote: > > Yes. In the customer scenario, the return value is 169.254.*.*/16 address. Sorry for all the questions but I'm still scratching my head as to how the lookup of the current host's name ends up with a list that includes these addresses. Is it definitely a behavior change in 2008 R2 or is it possible that the customer has configured the hosts file this way? -Alan. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111201/9c02f689/attachment.html From chris.hegarty at oracle.com Thu Dec 1 02:46:04 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Thu, 01 Dec 2011 10:46:04 +0000 Subject: InetAddress.getLocalHost() returns APIPA/link-local address in a Windows 2008 SP2 or later version Windows OS with multiple-NICs. In-Reply-To: <4ED7553C.9080007@oracle.com> References: <4ED32F97.4070109@linux.vnet.ibm.com> <4ED3573C.7000607@oracle.com> <4ED43F3E.9070300@linux.vnet.ibm.com> <4ED4AA3A.5010504@oracle.com> <4ED6D4CA.7090807@linux.vnet.ibm.com> <4ED7553C.9080007@oracle.com> Message-ID: <4ED75AEC.9080706@oracle.com> On 01/12/2011 10:21, Alan Bateman wrote: > On 01/12/2011 01:13, Charles Lee wrote: >> >> Yes. In the customer scenario, the return value is 169.254.*.*/16 address. > Sorry for all the questions but I'm still scratching my head as to how > the lookup of the current host's name ends up with a list that includes > these addresses. Is it definitely a behavior change in 2008 R2 or is it > possible that the customer has configured the hosts file this way? Yes, it would be nice to get the answer to this to understand if this is a change in behavior in the most recent Windows versions, or if it is a configuration issue. I'll run some tests too, to see if I can reproduce the issue. -Chris. > > -Alan. From chris.hegarty at oracle.com Thu Dec 1 05:02:25 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 01 Dec 2011 13:02:25 +0000 Subject: hg: jdk8/tl/jdk: 7116722: Miscellaneous warnings sun.misc ( and related classes ) Message-ID: <20111201130235.EF2FA474E1@hg.openjdk.java.net> Changeset: 3b8186aee592 Author: chegar Date: 2011-12-01 11:09 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b8186aee592 7116722: Miscellaneous warnings sun.misc ( and related classes ) Reviewed-by: alanb, darcy, forax, hawtin, lancea ! src/share/classes/com/sun/net/httpserver/spi/HttpServerProvider.java ! src/share/classes/java/net/InetAddress.java ! src/share/classes/java/util/jar/JarVerifier.java ! src/share/classes/java/util/jar/JavaUtilJarAccessImpl.java ! src/share/classes/javax/script/ScriptEngineManager.java ! src/share/classes/sun/misc/BASE64Decoder.java ! src/share/classes/sun/misc/ExtensionDependency.java ! src/share/classes/sun/misc/JarIndex.java ! src/share/classes/sun/misc/JavaUtilJarAccess.java ! src/share/classes/sun/misc/ProxyGenerator.java ! src/share/classes/sun/misc/Service.java ! src/share/classes/sun/misc/Signal.java ! test/sun/misc/JarIndex/metaInfFilenames/Basic.java From maurizio.cimadamore at oracle.com Thu Dec 1 10:35:55 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 01 Dec 2011 18:35:55 +0000 Subject: hg: jdk8/tl/jdk: 7116954: Misc warnings in java.beans/java.beans.context Message-ID: <20111201183605.0D411474E9@hg.openjdk.java.net> Changeset: 89130611b178 Author: mcimadamore Date: 2011-12-01 18:34 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/89130611b178 7116954: Misc warnings in java.beans/java.beans.context Summary: Remove generic warnings form java.beans and java.beans.context Reviewed-by: alanb, chegar ! src/share/classes/java/beans/BeanDescriptor.java ! src/share/classes/java/beans/Beans.java ! src/share/classes/java/beans/ChangeListenerMap.java ! src/share/classes/java/beans/DefaultPersistenceDelegate.java ! src/share/classes/java/beans/Encoder.java ! src/share/classes/java/beans/EventHandler.java ! src/share/classes/java/beans/EventSetDescriptor.java ! src/share/classes/java/beans/FeatureDescriptor.java ! src/share/classes/java/beans/IndexedPropertyDescriptor.java ! src/share/classes/java/beans/Introspector.java ! src/share/classes/java/beans/MetaData.java ! src/share/classes/java/beans/MethodDescriptor.java ! src/share/classes/java/beans/NameGenerator.java ! src/share/classes/java/beans/PersistenceDelegate.java ! src/share/classes/java/beans/PropertyChangeSupport.java ! src/share/classes/java/beans/PropertyDescriptor.java ! src/share/classes/java/beans/PropertyEditorSupport.java ! src/share/classes/java/beans/ReflectionUtils.java ! src/share/classes/java/beans/SimpleBeanInfo.java ! src/share/classes/java/beans/Statement.java ! src/share/classes/java/beans/VetoableChangeSupport.java ! src/share/classes/java/beans/XMLEncoder.java ! src/share/classes/java/beans/beancontext/BeanContext.java ! src/share/classes/java/beans/beancontext/BeanContextMembershipEvent.java From stuart.marks at oracle.com Thu Dec 1 16:14:10 2011 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Fri, 02 Dec 2011 00:14:10 +0000 Subject: hg: jdk8/tl/jdk: 7116890: additional warnings fixes for java.io Message-ID: <20111202001420.0DAB8474F8@hg.openjdk.java.net> Changeset: 0e3f706741ca Author: smarks Date: 2011-12-01 16:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0e3f706741ca 7116890: additional warnings fixes for java.io Reviewed-by: alanb, smarks Contributed-by: Sebastian Sickelmann ! src/share/classes/java/io/ExpiringCache.java ! src/share/classes/java/io/LineNumberInputStream.java ! src/share/classes/java/io/LineNumberReader.java ! src/share/classes/java/io/ObjectOutputStream.java ! src/share/classes/java/io/RandomAccessFile.java From yuka.kamiya at oracle.com Thu Dec 1 23:10:52 2011 From: yuka.kamiya at oracle.com (yuka.kamiya at oracle.com) Date: Fri, 02 Dec 2011 07:10:52 +0000 Subject: hg: jdk8/tl/jdk: 7056472: Speed up test/java/util/ResourceBundle/Control/ExpirationTest.sh Message-ID: <20111202071112.F40AC47513@hg.openjdk.java.net> Changeset: b03da32c3186 Author: peytoia Date: 2011-12-02 16:09 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b03da32c3186 7056472: Speed up test/java/util/ResourceBundle/Control/ExpirationTest.sh Reviewed-by: okutsu - test/java/util/ResourceBundle/Control/ExpirationTest.java - test/java/util/ResourceBundle/Control/ExpirationTest.sh From littlee at linux.vnet.ibm.com Thu Dec 1 23:42:55 2011 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Fri, 02 Dec 2011 15:42:55 +0800 Subject: InetAddress.getLocalHost() returns APIPA/link-local address in a Windows 2008 SP2 or later version Windows OS with multiple-NICs. In-Reply-To: <4ED7553C.9080007@oracle.com> References: <4ED32F97.4070109@linux.vnet.ibm.com> <4ED3573C.7000607@oracle.com> <4ED43F3E.9070300@linux.vnet.ibm.com> <4ED4AA3A.5010504@oracle.com> <4ED6D4CA.7090807@linux.vnet.ibm.com> <4ED7553C.9080007@oracle.com> Message-ID: <4ED8817F.1020908@linux.vnet.ibm.com> On 12/01/2011 06:21 PM, Alan Bateman wrote: > On 01/12/2011 01:13, Charles Lee wrote: >> >> Yes. In the customer scenario, the return value is 169.254.*.*/16 >> address. > Sorry for all the questions but I'm still scratching my head as to how > the lookup of the current host's name ends up with a list that > includes these addresses. Is it definitely a behavior change in 2008 > R2 or is it possible that the customer has configured the hosts file > this way? > > -Alan. It is definitely a behavior change in 2008 R2. -- Yours Charles -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111202/e67d57a0/attachment.html From littlee at linux.vnet.ibm.com Thu Dec 1 23:45:36 2011 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Fri, 02 Dec 2011 15:45:36 +0800 Subject: InetAddress.getLocalHost() returns APIPA/link-local address in a Windows 2008 SP2 or later version Windows OS with multiple-NICs. In-Reply-To: <4ED75AEC.9080706@oracle.com> References: <4ED32F97.4070109@linux.vnet.ibm.com> <4ED3573C.7000607@oracle.com> <4ED43F3E.9070300@linux.vnet.ibm.com> <4ED4AA3A.5010504@oracle.com> <4ED6D4CA.7090807@linux.vnet.ibm.com> <4ED7553C.9080007@oracle.com> <4ED75AEC.9080706@oracle.com> Message-ID: <4ED88220.9000504@linux.vnet.ibm.com> On 12/01/2011 06:46 PM, Chris Hegarty wrote: > > On 01/12/2011 10:21, Alan Bateman wrote: >> On 01/12/2011 01:13, Charles Lee wrote: >>> >>> Yes. In the customer scenario, the return value is 169.254.*.*/16 >>> address. >> Sorry for all the questions but I'm still scratching my head as to how >> the lookup of the current host's name ends up with a list that includes >> these addresses. Is it definitely a behavior change in 2008 R2 or is it >> possible that the customer has configured the hosts file this way? > > Yes, it would be nice to get the answer to this to understand if this > is a change in behavior in the most recent Windows versions, or if it > is a configuration issue. > > I'll run some tests too, to see if I can reproduce the issue. > > -Chris. > >> >> -Alan. > Hi Chris, The secondary NIC is a usb port, which is related to the rndis. The secondary result seems to appear at the first order in the return array. -- Yours Charles From chris.hegarty at oracle.com Fri Dec 2 05:34:11 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 02 Dec 2011 13:34:11 +0000 Subject: hg: jdk8/tl/jdk: 7116946: JSSecurityManager should use java.util.ServiceLoader to lookup service providers Message-ID: <20111202133429.9FDB84751A@hg.openjdk.java.net> Changeset: f615db07991e Author: chegar Date: 2011-12-02 11:39 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f615db07991e 7116946: JSSecurityManager should use java.util.ServiceLoader to lookup service providers Reviewed-by: prr ! src/share/classes/com/sun/media/sound/JSSecurityManager.java From chris.hegarty at oracle.com Fri Dec 2 08:11:19 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 02 Dec 2011 16:11:19 +0000 Subject: hg: jdk8/tl/jdk: 7116957: javax.script.ScriptEngineManager should use java.util.ServiceLoader to lookup service providers Message-ID: <20111202161129.210C34751E@hg.openjdk.java.net> Changeset: 37f6e294759f Author: chegar Date: 2011-12-02 14:17 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/37f6e294759f 7116957: javax.script.ScriptEngineManager should use java.util.ServiceLoader to lookup service providers Reviewed-by: alanb, lancea ! src/share/classes/com/sun/net/httpserver/spi/HttpServerProvider.java ! src/share/classes/javax/script/ScriptEngineManager.java ! src/share/classes/sun/net/ftp/FtpClientProvider.java From alan.bateman at oracle.com Fri Dec 2 09:48:39 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 02 Dec 2011 17:48:39 +0000 Subject: hg: jdk8/tl/jdk: 7117357: Warnings in sun.instrument, tools and other sun.* classes Message-ID: <20111202174849.7CBD147520@hg.openjdk.java.net> Changeset: 9950e2c9f3b5 Author: alanb Date: 2011-12-02 17:37 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9950e2c9f3b5 7117357: Warnings in sun.instrument, tools and other sun.* classes Reviewed-by: lancea, chegar ! src/share/classes/sun/instrument/InstrumentationImpl.java ! src/share/classes/sun/instrument/TransformerManager.java ! src/share/classes/sun/launcher/LauncherHelper.java ! src/share/classes/sun/management/counter/perf/PerfInstrumentation.java ! src/share/classes/sun/management/jmxremote/ConnectorBootstrap.java ! src/share/classes/sun/net/RegisteredDomain.java ! src/share/classes/sun/net/www/protocol/jar/Handler.java ! src/share/classes/sun/tools/attach/HotSpotAttachProvider.java ! src/share/classes/sun/tools/jinfo/JInfo.java ! src/share/classes/sun/tools/jmap/JMap.java ! src/share/classes/sun/tools/jps/Jps.java ! src/share/classes/sun/tools/jstack/JStack.java ! src/share/classes/sun/tools/serialver/SerialVer.java From naoto.sato at oracle.com Fri Dec 2 16:05:06 2011 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Sat, 03 Dec 2011 00:05:06 +0000 Subject: hg: jdk8/tl/jdk: 7117465: Warning cleanup for IMF classes Message-ID: <20111203000516.221AD47548@hg.openjdk.java.net> Changeset: 42532a097816 Author: naoto Date: 2011-12-02 16:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/42532a097816 7117465: Warning cleanup for IMF classes Reviewed-by: okutsu ! src/share/classes/java/awt/im/InputMethodHighlight.java ! src/share/classes/sun/awt/im/CompositionArea.java ! src/share/classes/sun/awt/im/CompositionAreaHandler.java ! src/share/classes/sun/awt/im/InputContext.java ! src/share/classes/sun/awt/im/InputMethodContext.java ! src/share/classes/sun/awt/im/InputMethodJFrame.java ! src/share/classes/sun/awt/im/InputMethodManager.java ! src/share/classes/sun/awt/im/SimpleInputMethodWindow.java From xueming.shen at oracle.com Fri Dec 2 16:24:22 2011 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Sat, 03 Dec 2011 00:24:22 +0000 Subject: hg: jdk8/tl/jdk: 5035850: (str) String.CASE_INSENSITIVE_ORDER should override readResolve() Message-ID: <20111203002432.0B18C47549@hg.openjdk.java.net> Changeset: 1d7037df65ed Author: sherman Date: 2011-12-02 16:25 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1d7037df65ed 5035850: (str) String.CASE_INSENSITIVE_ORDER should override readResolve() Summary: Fix to ensure singleton property of String.CaseInsensitiveComparator is maintained through de/serialization. Reviewed-by: alanb, forax, smarks, dholmes Contributed-by: darryl.mocek at oracle.com ! src/share/classes/java/lang/String.java + test/java/lang/String/CaseInsensitiveComparator.java From mandy.chung at oracle.com Fri Dec 2 16:29:33 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Sat, 03 Dec 2011 00:29:33 +0000 Subject: hg: jdk8/tl/jdk: 7117585: Eliminate java.lang.instrument, java.lang.management warnings Message-ID: <20111203002943.4A5AC4754A@hg.openjdk.java.net> Changeset: 98502d7a3f98 Author: mchung Date: 2011-12-02 16:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/98502d7a3f98 7117585: Eliminate java.lang.instrument, java.lang.management warnings Reviewed-by: mchung Contributed-by: Jon VanAlten ! src/share/classes/java/lang/instrument/ClassDefinition.java ! src/share/classes/java/lang/management/ManagementFactory.java ! src/share/classes/java/lang/management/PlatformComponent.java From lance.andersen at oracle.com Fri Dec 2 16:34:59 2011 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Sat, 03 Dec 2011 00:34:59 +0000 Subject: hg: jdk8/tl/jdk: 7116445: Miscellaneous warnings in the JDBC/RowSet classes Message-ID: <20111203003509.5C3374754B@hg.openjdk.java.net> Changeset: 3c524deb8431 Author: lancea Date: 2011-12-02 19:33 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c524deb8431 7116445: Miscellaneous warnings in the JDBC/RowSet classes Reviewed-by: smarks, chegar ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/FilteredRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetResourceBundle.java ! src/share/classes/com/sun/rowset/JoinRowSetImpl.java ! src/share/classes/com/sun/rowset/WebRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/CachedRowSetReader.java ! src/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java ! src/share/classes/com/sun/rowset/internal/Row.java ! src/share/classes/com/sun/rowset/internal/SyncResolverImpl.java ! src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java ! src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java ! src/share/classes/java/sql/Date.java ! src/share/classes/java/sql/DriverManager.java ! src/share/classes/java/sql/Time.java ! src/share/classes/java/sql/Timestamp.java ! src/share/classes/javax/sql/StatementEvent.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/RowSetMetaDataImpl.java ! src/share/classes/javax/sql/rowset/RowSetProvider.java ! src/share/classes/javax/sql/rowset/serial/SQLInputImpl.java ! src/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java ! src/share/classes/javax/sql/rowset/serial/SerialArray.java ! src/share/classes/javax/sql/rowset/serial/SerialBlob.java ! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java ! src/share/classes/javax/sql/rowset/serial/SerialRef.java ! src/share/classes/javax/sql/rowset/serial/SerialStruct.java ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java From masayoshi.okutsu at oracle.com Fri Dec 2 18:19:05 2011 From: masayoshi.okutsu at oracle.com (masayoshi.okutsu at oracle.com) Date: Sat, 03 Dec 2011 02:19:05 +0000 Subject: hg: jdk8/tl/jdk: 7117487: Warnings Cleanup: some i18n classes in java.util and sun.util Message-ID: <20111203021915.6E3C04754D@hg.openjdk.java.net> Changeset: f2a5d0001f15 Author: okutsu Date: 2011-12-03 10:58 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f2a5d0001f15 7117487: Warnings Cleanup: some i18n classes in java.util and sun.util Reviewed-by: lancea, naoto ! src/share/classes/java/util/Date.java ! src/share/classes/java/util/GregorianCalendar.java ! src/share/classes/java/util/JapaneseImperialCalendar.java ! src/share/classes/java/util/ResourceBundle.java ! src/share/classes/sun/util/calendar/BaseCalendar.java ! src/share/classes/sun/util/calendar/CalendarSystem.java ! src/share/classes/sun/util/calendar/LocalGregorianCalendar.java ! src/share/classes/sun/util/calendar/ZoneInfo.java ! src/share/classes/sun/util/calendar/ZoneInfoFile.java ! src/share/classes/sun/util/resources/OpenListResourceBundle.java ! src/share/classes/sun/util/resources/TimeZoneNamesBundle.java From weijun.wang at oracle.com Sun Dec 4 18:19:51 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Mon, 05 Dec 2011 02:19:51 +0000 Subject: hg: jdk8/tl/jdk: 7116857: Warnings in javax.security and some sun.misc Message-ID: <20111205022009.5BF384755E@hg.openjdk.java.net> Changeset: 2ae848ea980a Author: weijun Date: 2011-12-05 10:19 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2ae848ea980a 7116857: Warnings in javax.security and some sun.misc Reviewed-by: smarks ! src/share/classes/javax/security/auth/kerberos/ServicePermission.java ! src/share/classes/sun/misc/CEFormatException.java ! src/share/classes/sun/misc/CEStreamExhausted.java ! src/share/classes/sun/misc/ClassLoaderUtil.java ! src/share/classes/sun/misc/CompoundEnumeration.java ! src/share/classes/sun/misc/ExtensionInstallationException.java ! src/share/classes/sun/misc/FloatingDecimal.java ! src/share/classes/sun/misc/FormattedFloatingDecimal.java ! src/share/classes/sun/misc/InvalidJarIndexException.java ! src/share/classes/sun/misc/LRUCache.java ! src/share/classes/sun/misc/Queue.java ! src/share/classes/sun/misc/RequestProcessor.java ! src/share/classes/sun/misc/ServiceConfigurationError.java ! src/share/classes/sun/misc/URLClassPath.java From alan.bateman at oracle.com Mon Dec 5 04:28:02 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 05 Dec 2011 12:28:02 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20111205122831.CED8A47562@hg.openjdk.java.net> Changeset: 053cb321467a Author: alanb Date: 2011-12-05 12:23 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/053cb321467a 7117717: (aio) Tests failing due to implementation bug 7052549 Reviewed-by: weijun, chegar ! test/ProblemList.txt ! test/java/nio/channels/AsynchronousSocketChannel/Basic.java Changeset: da28826c5672 Author: alanb Date: 2011-12-05 12:24 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da28826c5672 Merge From chris.hegarty at oracle.com Mon Dec 5 09:35:42 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 05 Dec 2011 17:35:42 +0000 Subject: hg: jdk8/tl/jdk: 7117360: Warnings in java.util.concurrent.atomic package Message-ID: <20111205173606.A46904758B@hg.openjdk.java.net> Changeset: f352dd3cdff8 Author: dl Date: 2011-12-05 13:58 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f352dd3cdff8 7117360: Warnings in java.util.concurrent.atomic package Reviewed-by: chegar, dholmes ! src/share/classes/java/util/concurrent/atomic/AtomicBoolean.java ! src/share/classes/java/util/concurrent/atomic/AtomicInteger.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicLong.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicReference.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicStampedReference.java From xueming.shen at oracle.com Mon Dec 5 10:51:34 2011 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Mon, 05 Dec 2011 18:51:34 +0000 Subject: hg: jdk8/tl/jdk: 5063455: (fmt) MissingFormatArgumentException.getFormatSpecifier() incorrect return value Message-ID: <20111205185143.E36C24758D@hg.openjdk.java.net> Changeset: 194faa6fdb3c Author: sherman Date: 2011-12-05 10:50 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/194faa6fdb3c 5063455: (fmt) MissingFormatArgumentException.getFormatSpecifier() incorrect return value Summary: updated the incorrect StringBuilder constructor usage Reviewed-by: dholmes, sherman Contributed-by: brandon.passanisi at oracle.com ! src/share/classes/java/util/Formatter.java + test/java/util/MissingFormatArgumentException/GetFormatSpecifier.java From yuka.kamiya at oracle.com Mon Dec 5 15:40:39 2011 From: yuka.kamiya at oracle.com (yuka.kamiya at oracle.com) Date: Mon, 05 Dec 2011 23:40:39 +0000 Subject: hg: jdk8/tl/jdk: 7116914: Miscellaneous warnings (sun.text) Message-ID: <20111205234049.2693647591@hg.openjdk.java.net> Changeset: ca383e32deaf Author: peytoia Date: 2011-12-06 08:39 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ca383e32deaf 7116914: Miscellaneous warnings (sun.text) Reviewed-by: smarks, okutsu ! src/share/classes/sun/text/CompactByteArray.java ! src/share/classes/sun/text/IntHashtable.java ! src/share/classes/sun/text/bidi/BidiBase.java ! src/share/classes/sun/text/normalizer/ICUData.java ! src/share/classes/sun/text/normalizer/NormalizerBase.java ! src/share/classes/sun/text/normalizer/NormalizerImpl.java ! src/share/classes/sun/text/normalizer/SymbolTable.java ! src/share/classes/sun/text/normalizer/UnicodeSet.java ! src/share/classes/sun/text/normalizer/UnicodeSetIterator.java ! src/share/classes/sun/text/normalizer/VersionInfo.java From stuart.marks at oracle.com Mon Dec 5 16:51:00 2011 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Tue, 06 Dec 2011 00:51:00 +0000 Subject: hg: jdk8/tl/jdk: 7116993: fix warnings in java.applet Message-ID: <20111206005114.C208A47592@hg.openjdk.java.net> Changeset: f4fe86bba8a2 Author: smarks Date: 2011-12-05 16:30 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f4fe86bba8a2 7116993: fix warnings in java.applet Reviewed-by: art, smarks Contributed-by: Danesh Dadachanji ! src/share/classes/java/applet/Applet.java From naoto.sato at oracle.com Mon Dec 5 17:09:42 2011 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Tue, 06 Dec 2011 01:09:42 +0000 Subject: hg: jdk8/tl/jdk: 7117469: Warning cleanup for j.u.Currency and j.u.Locale related classes Message-ID: <20111206010951.8BAC347593@hg.openjdk.java.net> Changeset: 85363edbc92f Author: naoto Date: 2011-12-05 17:08 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/85363edbc92f 7117469: Warning cleanup for j.u.Currency and j.u.Locale related classes Reviewed-by: okutsu, smarks ! src/share/classes/java/util/Currency.java ! src/share/classes/sun/util/LocaleServiceProviderPool.java ! src/share/classes/sun/util/resources/LocaleData.java From chris.hegarty at oracle.com Tue Dec 6 09:16:06 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Tue, 06 Dec 2011 17:16:06 +0000 Subject: InetAddress.getLocalHost() returns APIPA/link-local address in a Windows 2008 SP2 or later version Windows OS with multiple-NICs. In-Reply-To: <4ED88220.9000504@linux.vnet.ibm.com> References: <4ED32F97.4070109@linux.vnet.ibm.com> <4ED3573C.7000607@oracle.com> <4ED43F3E.9070300@linux.vnet.ibm.com> <4ED4AA3A.5010504@oracle.com> <4ED6D4CA.7090807@linux.vnet.ibm.com> <4ED7553C.9080007@oracle.com> <4ED75AEC.9080706@oracle.com> <4ED88220.9000504@linux.vnet.ibm.com> Message-ID: <4EDE4DD6.4030102@oracle.com> Charles, I still don't get this issue. getLocalHost first retrieves the local host name of the system, then does a lookup in the configured name service for this name. Is it possible for you to give detailed description of your machine setup/configuration and how you are encountering this issue? What is the actual local system name? Is this name resolvable in the configured name service ( DNS ) ? Thanks, -Chris. On 12/ 2/11 07:45 AM, Charles Lee wrote: > On 12/01/2011 06:46 PM, Chris Hegarty wrote: >> >> On 01/12/2011 10:21, Alan Bateman wrote: >>> On 01/12/2011 01:13, Charles Lee wrote: >>>> >>>> Yes. In the customer scenario, the return value is 169.254.*.*/16 >>>> address. >>> Sorry for all the questions but I'm still scratching my head as to how >>> the lookup of the current host's name ends up with a list that includes >>> these addresses. Is it definitely a behavior change in 2008 R2 or is it >>> possible that the customer has configured the hosts file this way? >> >> Yes, it would be nice to get the answer to this to understand if this >> is a change in behavior in the most recent Windows versions, or if it >> is a configuration issue. >> >> I'll run some tests too, to see if I can reproduce the issue. >> >> -Chris. >> >>> >>> -Alan. >> > > Hi Chris, > > The secondary NIC is a usb port, which is related to the rndis. The > secondary result seems to appear at the first order in the return array. > From stuart.marks at oracle.com Tue Dec 6 10:23:11 2011 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Tue, 06 Dec 2011 18:23:11 +0000 Subject: hg: jdk8/tl/jdk: 7116997: fix warnings in java.util.PropertyPermission Message-ID: <20111206182332.B74AA475A4@hg.openjdk.java.net> Changeset: 77f6d4360f4b Author: smarks Date: 2011-12-06 10:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/77f6d4360f4b 7116997: fix warnings in java.util.PropertyPermission Reviewed-by: smarks Contributed-by: Brandon Passanisi ! src/share/classes/java/util/PropertyPermission.java From littlee at linux.vnet.ibm.com Tue Dec 6 22:58:29 2011 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Wed, 07 Dec 2011 14:58:29 +0800 Subject: InetAddress.getLocalHost() returns APIPA/link-local address in a Windows 2008 SP2 or later version Windows OS with multiple-NICs. In-Reply-To: <4EDE4DD6.4030102@oracle.com> References: <4ED32F97.4070109@linux.vnet.ibm.com> <4ED3573C.7000607@oracle.com> <4ED43F3E.9070300@linux.vnet.ibm.com> <4ED4AA3A.5010504@oracle.com> <4ED6D4CA.7090807@linux.vnet.ibm.com> <4ED7553C.9080007@oracle.com> <4ED75AEC.9080706@oracle.com> <4ED88220.9000504@linux.vnet.ibm.com> <4EDE4DD6.4030102@oracle.com> Message-ID: <4EDF0E95.6010605@linux.vnet.ibm.com> Hi Chris, Sorry I can not give a *detailed* description :-P Have you successfully get an APIPA address? [1] is the link which describe they have get such addresses :-D The behaviour difference was introduced by the some latest patches from the Microsoft. And I am heard recently that they are going to change this behaviour back future O:-) I am thinking that, since APIPA address is available, we may need to filter the return address array in case that the native api *accidentally* change its behaviour. [1] http://lmgtfy.com/?q=getaddrinfo+apipa On 12/07/2011 01:16 AM, Chris Hegarty wrote: > Charles, > > I still don't get this issue. getLocalHost first retrieves the local > host name of the system, then does a lookup in the configured name > service for this name. > > Is it possible for you to give detailed description of your machine > setup/configuration and how you are encountering this issue? What is > the actual local system name? Is this name resolvable in the > configured name service ( DNS ) ? > > Thanks, > -Chris. > > On 12/ 2/11 07:45 AM, Charles Lee wrote: >> On 12/01/2011 06:46 PM, Chris Hegarty wrote: >>> >>> On 01/12/2011 10:21, Alan Bateman wrote: >>>> On 01/12/2011 01:13, Charles Lee wrote: >>>>> >>>>> Yes. In the customer scenario, the return value is 169.254.*.*/16 >>>>> address. >>>> Sorry for all the questions but I'm still scratching my head as to how >>>> the lookup of the current host's name ends up with a list that >>>> includes >>>> these addresses. Is it definitely a behavior change in 2008 R2 or >>>> is it >>>> possible that the customer has configured the hosts file this way? >>> >>> Yes, it would be nice to get the answer to this to understand if this >>> is a change in behavior in the most recent Windows versions, or if it >>> is a configuration issue. >>> >>> I'll run some tests too, to see if I can reproduce the issue. >>> >>> -Chris. >>> >>>> >>>> -Alan. >>> >> >> Hi Chris, >> >> The secondary NIC is a usb port, which is related to the rndis. The >> secondary result seems to appear at the first order in the return array. >> > -- Yours Charles From littlee at linux.vnet.ibm.com Wed Dec 7 00:11:34 2011 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Wed, 07 Dec 2011 16:11:34 +0800 Subject: EHOSTUNREACH should not be considered as an exception when send on a loopback network interface. In-Reply-To: <4E60626C.5030504@linux.vnet.ibm.com> References: <4E60608D.6010207@linux.vnet.ibm.com> <4E60626C.5030504@linux.vnet.ibm.com> Message-ID: <4EDF1FB6.706@linux.vnet.ibm.com> On 09/02/2011 12:58 PM, Charles Lee wrote: > On 09/02/2011 12:50 PM, Charles Lee wrote: >> Hi guys, >> >> In some linuxes, when you bind on a loopback network interface, >> sendto will be fail and errono will be set to EHOSTUNREACH. >> In this situation, EHOSTUNREACH maybe need treat as INVAL: return >> false, not throw an exception. >> >> Patch is attached. >> >> Does anyone interested in this issue? >> >> > Sorry, I attached a wrong diff. Here is the right one. > Hi guys, I'd like to raise this issue again. The patch is on the [1]: When a loopback network interface is bound to sendto and connect, in some linuxes it will throw an EINVAL errno, in other linuxes (AIX, iSeries) it will throw an EHOSTUNREACH errno. The man page of sendto on Aix and solaris is [2][3]. In such situation, EHOSTUNREACH should treat as the same as EINVAL: not throw an exception but return false. Below is the simple test case can test this situation in specific platforms: /public class IsReachableTest { public static void main(String[] args) throws Exception{ InetAddress testHost1 = InetAddress.getByName("openjdk.java.net"); NetworkInterface loopbackNi = null; Enumeration list = NetworkInterface.getNetworkInterfaces(); boolean loopbackFound = false; while (list.hasMoreElements() && !loopbackFound){ loopbackNi = list.nextElement(); if (loopbackNi.isLoopback() && loopbackNi.isUp()) { loopbackFound = true; } } if (!loopbackFound) return; if (testHost1.isReachable(loopbackNi, 64, 1000)) System.out.println(String.format("Fail: external host '%s' is reachable via loopback '%s'!", testHost1, loopbackNi)); } }/ Any thoughts, guys? [1] http://cr.openjdk.java.net/~littlee/OJDK-175/webrev.00/ [2] http://publib.boulder.ibm.com/infocenter/aix/v6r1/index.jsp?topic=%2Fcom.ibm.aix.commtechref%2Fdoc%2Fcommtrf2%2Fsendto.htm [3] http://man-wiki.net/index.php/2:sendto -- Yours Charles -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111207/cbc56d53/attachment.html From Alan.Bateman at oracle.com Wed Dec 7 00:32:20 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 07 Dec 2011 08:32:20 +0000 Subject: InetAddress.getLocalHost() returns APIPA/link-local address in a Windows 2008 SP2 or later version Windows OS with multiple-NICs. In-Reply-To: <4EDF0E95.6010605@linux.vnet.ibm.com> References: <4ED32F97.4070109@linux.vnet.ibm.com> <4ED3573C.7000607@oracle.com> <4ED43F3E.9070300@linux.vnet.ibm.com> <4ED4AA3A.5010504@oracle.com> <4ED6D4CA.7090807@linux.vnet.ibm.com> <4ED7553C.9080007@oracle.com> <4ED75AEC.9080706@oracle.com> <4ED88220.9000504@linux.vnet.ibm.com> <4EDE4DD6.4030102@oracle.com> <4EDF0E95.6010605@linux.vnet.ibm.com> Message-ID: <4EDF2494.20701@oracle.com> On 07/12/2011 06:58, Charles Lee wrote: > Hi Chris, > > Sorry I can not give a *detailed* description :-P Have you > successfully get an APIPA address? [1] is the link which describe they > have get such addresses :-D > The behaviour difference was introduced by the some latest patches > from the Microsoft. And I am heard recently that they are going to > change this behaviour back future O:-) > > I am thinking that, since APIPA address is available, we may need to > filter the return address array in case that the native api > *accidentally* change its behaviour. > > [1] http://lmgtfy.com/?q=getaddrinfo+apipa > There's something fishy here. As this is a server then one would guess that it would be configured with at least one static IP address and for the hostname to resolve to one of those addresses. From the mails it sounds like the hostname is resolving to a list that includes an APIPA address address, which suggests to me a Windows bug or else configuration that causes the APIPA to be automatically registered. Do you have a reference to the patch that is causing this, it would be nice to read the description. Also Microsoft tend to add registry settings to revert behavior changes and maybe there is something for this. As I said in one of the earlier mails, the patch is fine and seems completely benign, it's just that this thread lacks the meat to completely explain why it is needed. -Alan. From Alan.Bateman at oracle.com Wed Dec 7 03:12:35 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 07 Dec 2011 11:12:35 +0000 Subject: EHOSTUNREACH should not be considered as an exception when send on a loopback network interface. In-Reply-To: <4EDF1FB6.706@linux.vnet.ibm.com> References: <4E60608D.6010207@linux.vnet.ibm.com> <4E60626C.5030504@linux.vnet.ibm.com> <4EDF1FB6.706@linux.vnet.ibm.com> Message-ID: <4EDF4A23.8000801@oracle.com> On 07/12/2011 08:11, Charles Lee wrote: > : > > I'd like to raise this issue again. The patch is on the [1]: > > When a loopback network interface is bound to sendto and connect, in > some linuxes it will throw an EINVAL errno, in other linuxes (AIX, > iSeries) it will throw an EHOSTUNREACH errno. The man page of sendto > on Aix and solaris is [2][3]. > In such situation, EHOSTUNREACH should treat as the same as EINVAL: > not throw an exception but return false. > > Below is the simple test case can test this situation in specific > platforms: > > /public class IsReachableTest { > public static void main(String[] args) throws Exception{ > InetAddress testHost1 = InetAddress.getByName("openjdk.java.net"); > NetworkInterface loopbackNi = null; > Enumeration list = > NetworkInterface.getNetworkInterfaces(); > boolean loopbackFound = false; > while (list.hasMoreElements() && !loopbackFound){ > loopbackNi = list.nextElement(); > if (loopbackNi.isLoopback() && loopbackNi.isUp()) { > loopbackFound = true; > } > } > > if (!loopbackFound) > return; > if (testHost1.isReachable(loopbackNi, 64, 1000)) > System.out.println(String.format("Fail: external host '%s' > is reachable via loopback '%s'!", > testHost1, loopbackNi)); > } > }/ > > Any thoughts, guys? APIs that return a boolean to indicate success/failure and can also throw IOException when there is a failure can be awkward as there will be cases where IOException is thrown when false might seem to be more correct. In this case, if sendto can fail with EHOSTUNREACH on Linux then the proposed patch looks okay to me. I'm kinda surprised that EINVAL is returned in some cases, that seems misleading to me. -Alan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111207/c35eec21/attachment.html From chris.hegarty at oracle.com Wed Dec 7 05:39:15 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Wed, 07 Dec 2011 13:39:15 +0000 Subject: EHOSTUNREACH should not be considered as an exception when send on a loopback network interface. In-Reply-To: <4EDF4A23.8000801@oracle.com> References: <4E60608D.6010207@linux.vnet.ibm.com> <4E60626C.5030504@linux.vnet.ibm.com> <4EDF1FB6.706@linux.vnet.ibm.com> <4EDF4A23.8000801@oracle.com> Message-ID: <4EDF6C83.7040706@oracle.com> On 07/12/2011 11:12, Alan Bateman wrote: > On 07/12/2011 08:11, Charles Lee wrote: >> : >> >> I'd like to raise this issue again. The patch is on the [1]: >> >> When a loopback network interface is bound to sendto and connect, in >> some linuxes it will throw an EINVAL errno, in other linuxes (AIX, >> iSeries) it will throw an EHOSTUNREACH errno. The man page of sendto >> on Aix and solaris is [2][3]. >> In such situation, EHOSTUNREACH should treat as the same as EINVAL: >> not throw an exception but return false. >> >> Below is the simple test case can test this situation in specific >> platforms: >> >> /public class IsReachableTest { >> public static void main(String[] args) throws Exception{ >> InetAddress testHost1 = InetAddress.getByName("openjdk.java.net"); >> NetworkInterface loopbackNi = null; >> Enumeration list = >> NetworkInterface.getNetworkInterfaces(); >> boolean loopbackFound = false; >> while (list.hasMoreElements() && !loopbackFound){ >> loopbackNi = list.nextElement(); >> if (loopbackNi.isLoopback() && loopbackNi.isUp()) { >> loopbackFound = true; >> } >> } >> >> if (!loopbackFound) >> return; >> if (testHost1.isReachable(loopbackNi, 64, 1000)) >> System.out.println(String.format("Fail: external host '%s' is >> reachable via loopback '%s'!", >> testHost1, loopbackNi)); >> } >> }/ >> >> Any thoughts, guys? > APIs that return a boolean to indicate success/failure and can also > throw IOException when there is a failure can be awkward as there will > be cases where IOException is thrown when false might seem to be more > correct. In this case, if sendto can fail with EHOSTUNREACH on Linux > then the proposed patch looks okay to me. I'm kinda surprised that > EINVAL is returned in some cases, that seems misleading to me. Ugh, I remember this one. Not pretty, but we found not better alternative, see http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6947677 I filed a new CR for this issue: 7118907: "InetAddress.isReachable() should return false if sendto fails with EHOSTUNREACH" I approved the proposed changes. Trivially can you put a new line in the comment after EHOSTUNREACH. /* * On some Linuxes, when bound to the loopback interface, sendto * will fail and errno will be set to EINVAL or EHOSTUNREACH. * When that happens, don't throw an exception, just return false. */ I assume Neil can push this for you? If not, I can help with the push. -Chris. > > -Alan > > > From stuart.marks at oracle.com Wed Dec 7 13:47:48 2011 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Wed, 07 Dec 2011 21:47:48 +0000 Subject: hg: jdk8/tl/jdk: 7117249: fix warnings in java.util.jar, .logging, .prefs, .zip Message-ID: <20111207214805.430C647632@hg.openjdk.java.net> Changeset: 4f0f9f9c4892 Author: smarks Date: 2011-12-07 12:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4f0f9f9c4892 7117249: fix warnings in java.util.jar, .logging, .prefs, .zip Reviewed-by: alanb, dholmes, forax, sherman, smarks Contributed-by: Prasannaa , Martijn Verburg , Goerge_Albrecht , Graham Allan , Michael Barker ! src/share/classes/java/util/jar/JarFile.java ! src/share/classes/java/util/jar/Manifest.java ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/prefs/Preferences.java ! src/share/classes/java/util/prefs/XmlSupport.java ! src/share/classes/java/util/zip/ZipEntry.java From kumar.x.srinivasan at oracle.com Wed Dec 7 14:35:20 2011 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Wed, 07 Dec 2011 22:35:20 +0000 Subject: hg: jdk8/tl/langtools: 7086015: fix test/tools/javac/parser/netbeans/JavacParserTest.java Message-ID: <20111207223524.462F347633@hg.openjdk.java.net> Changeset: abfa0d8ea803 Author: ksrini Date: 2011-12-07 10:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/abfa0d8ea803 7086015: fix test/tools/javac/parser/netbeans/JavacParserTest.java Reviewed-by: ksrini, jjg Contributed-by: matherey.nunez at oracle.com ! test/tools/javac/parser/netbeans/JavacParserTest.java From littlee at linux.vnet.ibm.com Wed Dec 7 19:16:46 2011 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Thu, 08 Dec 2011 11:16:46 +0800 Subject: EHOSTUNREACH should not be considered as an exception when send on a loopback network interface. In-Reply-To: <4EDF6C83.7040706@oracle.com> References: <4E60608D.6010207@linux.vnet.ibm.com> <4E60626C.5030504@linux.vnet.ibm.com> <4EDF1FB6.706@linux.vnet.ibm.com> <4EDF4A23.8000801@oracle.com> <4EDF6C83.7040706@oracle.com> Message-ID: <4EE02C1E.9090004@linux.vnet.ibm.com> On 12/07/2011 09:39 PM, Chris Hegarty wrote: > > > On 07/12/2011 11:12, Alan Bateman wrote: >> On 07/12/2011 08:11, Charles Lee wrote: >>> : >>> >>> I'd like to raise this issue again. The patch is on the [1]: >>> >>> When a loopback network interface is bound to sendto and connect, in >>> some linuxes it will throw an EINVAL errno, in other linuxes (AIX, >>> iSeries) it will throw an EHOSTUNREACH errno. The man page of sendto >>> on Aix and solaris is [2][3]. >>> In such situation, EHOSTUNREACH should treat as the same as EINVAL: >>> not throw an exception but return false. >>> >>> Below is the simple test case can test this situation in specific >>> platforms: >>> >>> /public class IsReachableTest { >>> public static void main(String[] args) throws Exception{ >>> InetAddress testHost1 = InetAddress.getByName("openjdk.java.net"); >>> NetworkInterface loopbackNi = null; >>> Enumeration list = >>> NetworkInterface.getNetworkInterfaces(); >>> boolean loopbackFound = false; >>> while (list.hasMoreElements() && !loopbackFound){ >>> loopbackNi = list.nextElement(); >>> if (loopbackNi.isLoopback() && loopbackNi.isUp()) { >>> loopbackFound = true; >>> } >>> } >>> >>> if (!loopbackFound) >>> return; >>> if (testHost1.isReachable(loopbackNi, 64, 1000)) >>> System.out.println(String.format("Fail: external host '%s' is >>> reachable via loopback '%s'!", >>> testHost1, loopbackNi)); >>> } >>> }/ >>> >>> Any thoughts, guys? >> APIs that return a boolean to indicate success/failure and can also >> throw IOException when there is a failure can be awkward as there will >> be cases where IOException is thrown when false might seem to be more >> correct. In this case, if sendto can fail with EHOSTUNREACH on Linux >> then the proposed patch looks okay to me. I'm kinda surprised that >> EINVAL is returned in some cases, that seems misleading to me. > > Ugh, I remember this one. Not pretty, but we found not better > alternative, see > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6947677 > > I filed a new CR for this issue: > 7118907: "InetAddress.isReachable() should return false if sendto > fails with EHOSTUNREACH" > > I approved the proposed changes. > > Trivially can you put a new line in the comment after EHOSTUNREACH. > > /* > * On some Linuxes, when bound to the loopback interface, sendto > * will fail and errno will be set to EINVAL or EHOSTUNREACH. > * When that happens, don't throw an exception, just return false. > */ > > I assume Neil can push this for you? If not, I can help with the push. > > -Chris. > >> >> -Alan >> >> >> > Hi Alan, hi Chris, Thank you for reviewing this and creating a bug id for me. I have put a revised webrev at http://cr.openjdk.java.net/~littlee/7118907/webrev.00/ . If it is ok for you guys, maybe Neil can help :-) -- Yours Charles From littlee at linux.vnet.ibm.com Wed Dec 7 20:34:24 2011 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Thu, 08 Dec 2011 12:34:24 +0800 Subject: InetAddress.getLocalHost() returns APIPA/link-local address in a Windows 2008 SP2 or later version Windows OS with multiple-NICs. In-Reply-To: <4EDF2494.20701@oracle.com> References: <4ED32F97.4070109@linux.vnet.ibm.com> <4ED3573C.7000607@oracle.com> <4ED43F3E.9070300@linux.vnet.ibm.com> <4ED4AA3A.5010504@oracle.com> <4ED6D4CA.7090807@linux.vnet.ibm.com> <4ED7553C.9080007@oracle.com> <4ED75AEC.9080706@oracle.com> <4ED88220.9000504@linux.vnet.ibm.com> <4EDE4DD6.4030102@oracle.com> <4EDF0E95.6010605@linux.vnet.ibm.com> <4EDF2494.20701@oracle.com> Message-ID: <4EE03E50.4040406@linux.vnet.ibm.com> Hi Alan, On 12/07/2011 04:32 PM, Alan Bateman wrote: > On 07/12/2011 06:58, Charles Lee wrote: >> Hi Chris, >> >> Sorry I can not give a *detailed* description :-P Have you >> successfully get an APIPA address? [1] is the link which describe >> they have get such addresses :-D >> The behaviour difference was introduced by the some latest patches >> from the Microsoft. And I am heard recently that they are going to >> change this behaviour back future O:-) >> >> I am thinking that, since APIPA address is available, we may need to >> filter the return address array in case that the native api >> *accidentally* change its behaviour. >> >> [1] http://lmgtfy.com/?q=getaddrinfo+apipa >> > There's something fishy here. As this is a server then one would guess > that it would be configured with at least one static IP address and > for the hostname to resolve to one of those addresses. From the mails > it sounds like the hostname is resolving to a list that includes an > APIPA address address, which suggests to me a Windows bug or else > configuration that causes the APIPA to be automatically registered. Do > you have a reference to the patch that is causing this, it would be > nice to read the description. I can not find that from a simple google, but we can find that it is a different behaviour from different version. > Also Microsoft tend to add registry settings to revert behavior > changes and maybe there is something for this. As I said in one of the > earlier mails, the patch is fine and seems completely benign, it's > just that this thread lacks the meat to completely explain why it is > needed. > I understand. > -Alan. > -- Yours Charles From chris.hegarty at oracle.com Thu Dec 8 02:54:44 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Thu, 08 Dec 2011 10:54:44 +0000 Subject: EHOSTUNREACH should not be considered as an exception when send on a loopback network interface. In-Reply-To: <4EE02C1E.9090004@linux.vnet.ibm.com> References: <4E60608D.6010207@linux.vnet.ibm.com> <4E60626C.5030504@linux.vnet.ibm.com> <4EDF1FB6.706@linux.vnet.ibm.com> <4EDF4A23.8000801@oracle.com> <4EDF6C83.7040706@oracle.com> <4EE02C1E.9090004@linux.vnet.ibm.com> Message-ID: <4EE09774.7000601@oracle.com> On 08/12/2011 03:16, Charles Lee wrote: > .... > Hi Alan, hi Chris, > > Thank you for reviewing this and creating a bug id for me. I have put a > revised webrev at http://cr.openjdk.java.net/~littlee/7118907/webrev.00/ > . Looks fine to me. Let me know if you need help with the push. -Chris. > If it is ok for you guys, maybe Neil can help :-) > From stuart.marks at oracle.com Thu Dec 8 15:12:17 2011 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Thu, 08 Dec 2011 23:12:17 +0000 Subject: hg: jdk8/tl/jdk: 7118546: fix warnings in javax.xml.crypto, javax.script Message-ID: <20111208231227.3940447644@hg.openjdk.java.net> Changeset: 9bb7c3b97384 Author: smarks Date: 2011-12-08 14:57 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9bb7c3b97384 7118546: fix warnings in javax.xml.crypto, javax.script Reviewed-by: mullan ! src/share/classes/javax/script/ScriptException.java ! src/share/classes/javax/xml/crypto/NodeSetData.java ! src/share/classes/javax/xml/crypto/dom/DOMCryptoContext.java ! src/share/classes/javax/xml/crypto/dsig/Manifest.java ! src/share/classes/javax/xml/crypto/dsig/Reference.java ! src/share/classes/javax/xml/crypto/dsig/SignatureProperties.java ! src/share/classes/javax/xml/crypto/dsig/SignatureProperty.java ! src/share/classes/javax/xml/crypto/dsig/SignedInfo.java ! src/share/classes/javax/xml/crypto/dsig/TransformService.java ! src/share/classes/javax/xml/crypto/dsig/XMLObject.java ! src/share/classes/javax/xml/crypto/dsig/XMLSignature.java ! src/share/classes/javax/xml/crypto/dsig/XMLSignatureFactory.java ! src/share/classes/javax/xml/crypto/dsig/keyinfo/KeyInfo.java ! src/share/classes/javax/xml/crypto/dsig/keyinfo/KeyInfoFactory.java ! src/share/classes/javax/xml/crypto/dsig/keyinfo/PGPData.java ! src/share/classes/javax/xml/crypto/dsig/keyinfo/RetrievalMethod.java ! src/share/classes/javax/xml/crypto/dsig/keyinfo/X509Data.java ! src/share/classes/javax/xml/crypto/dsig/spec/ExcC14NParameterSpec.java ! src/share/classes/javax/xml/crypto/dsig/spec/XPathFilter2ParameterSpec.java ! src/share/classes/javax/xml/crypto/dsig/spec/XPathFilterParameterSpec.java ! src/share/classes/javax/xml/crypto/dsig/spec/XPathType.java From kumar.x.srinivasan at oracle.com Fri Dec 9 08:58:02 2011 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Fri, 09 Dec 2011 16:58:02 +0000 Subject: hg: jdk8/tl/langtools: 7119032: (javac) increase visibility of JavacParser methods to improve subtyping Message-ID: <20111209165807.240024764F@hg.openjdk.java.net> Changeset: 9350d0498d21 Author: ksrini Date: 2011-12-09 08:40 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9350d0498d21 7119032: (javac) increase visibility of JavacParser methods to improve subtyping Reviewed-by: jjg Contributed-by: jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java From jim.holmlund at sun.com Fri Dec 9 13:03:08 2011 From: jim.holmlund at sun.com (jim.holmlund at sun.com) Date: Fri, 09 Dec 2011 21:03:08 +0000 Subject: hg: jdk8/tl/jdk: 7117053: Fix build warnings in com/sun/tools/jdi/* Message-ID: <20111209210329.8100547653@hg.openjdk.java.net> Changeset: 77d41c0e4ffc Author: jjh Date: 2011-12-09 12:56 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/77d41c0e4ffc 7117053: Fix build warnings in com/sun/tools/jdi/* Summary: Warnings fixed. Also reviewed by serguei.spitsyn at oracle.com, who is not yet an openjdk reviewer Reviewed-by: ksrini ! make/tools/src/build/tools/jdwpgen/ArrayRegionTypeNode.java ! make/tools/src/build/tools/jdwpgen/OutNode.java ! src/share/classes/com/sun/jdi/AbsentInformationException.java ! src/share/classes/com/sun/jdi/ClassNotLoadedException.java ! src/share/classes/com/sun/jdi/ClassNotPreparedException.java ! src/share/classes/com/sun/jdi/IncompatibleThreadStateException.java ! src/share/classes/com/sun/jdi/InconsistentDebugInfoException.java ! src/share/classes/com/sun/jdi/InternalException.java ! src/share/classes/com/sun/jdi/InvalidCodeIndexException.java ! src/share/classes/com/sun/jdi/InvalidLineNumberException.java ! src/share/classes/com/sun/jdi/InvalidStackFrameException.java ! src/share/classes/com/sun/jdi/InvalidTypeException.java ! src/share/classes/com/sun/jdi/InvocationException.java ! src/share/classes/com/sun/jdi/JDIPermission.java ! src/share/classes/com/sun/jdi/NativeMethodException.java ! src/share/classes/com/sun/jdi/ObjectCollectedException.java ! src/share/classes/com/sun/jdi/VMCannotBeModifiedException.java ! src/share/classes/com/sun/jdi/VMDisconnectedException.java ! src/share/classes/com/sun/jdi/VMMismatchException.java ! src/share/classes/com/sun/jdi/VMOutOfMemoryException.java ! src/share/classes/com/sun/jdi/connect/IllegalConnectorArgumentsException.java ! src/share/classes/com/sun/jdi/connect/TransportTimeoutException.java ! src/share/classes/com/sun/jdi/connect/VMStartException.java ! src/share/classes/com/sun/jdi/connect/spi/ClosedConnectionException.java ! src/share/classes/com/sun/jdi/request/DuplicateRequestException.java ! src/share/classes/com/sun/jdi/request/InvalidRequestStateException.java ! src/share/classes/com/sun/tools/jdi/ArrayReferenceImpl.java ! src/share/classes/com/sun/tools/jdi/ArrayTypeImpl.java ! src/share/classes/com/sun/tools/jdi/BooleanValueImpl.java ! src/share/classes/com/sun/tools/jdi/CharValueImpl.java ! src/share/classes/com/sun/tools/jdi/ClassLoaderReferenceImpl.java ! src/share/classes/com/sun/tools/jdi/ClassTypeImpl.java ! src/share/classes/com/sun/tools/jdi/ConcreteMethodImpl.java ! src/share/classes/com/sun/tools/jdi/ConnectorImpl.java ! src/share/classes/com/sun/tools/jdi/DoubleValueImpl.java ! src/share/classes/com/sun/tools/jdi/EventRequestManagerImpl.java ! src/share/classes/com/sun/tools/jdi/EventSetImpl.java ! src/share/classes/com/sun/tools/jdi/FloatValueImpl.java ! src/share/classes/com/sun/tools/jdi/GenericAttachingConnector.java ! src/share/classes/com/sun/tools/jdi/IntegerValueImpl.java ! src/share/classes/com/sun/tools/jdi/InterfaceTypeImpl.java ! src/share/classes/com/sun/tools/jdi/InternalEventHandler.java ! src/share/classes/com/sun/tools/jdi/JDWPException.java - src/share/classes/com/sun/tools/jdi/LinkedHashMap.java ! src/share/classes/com/sun/tools/jdi/LongValueImpl.java ! src/share/classes/com/sun/tools/jdi/MethodImpl.java ! src/share/classes/com/sun/tools/jdi/MirrorImpl.java ! src/share/classes/com/sun/tools/jdi/ObjectReferenceImpl.java ! src/share/classes/com/sun/tools/jdi/ProcessAttachingConnector.java ! src/share/classes/com/sun/tools/jdi/RawCommandLineLauncher.java ! src/share/classes/com/sun/tools/jdi/ReferenceTypeImpl.java ! src/share/classes/com/sun/tools/jdi/ShortValueImpl.java ! src/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java ! src/share/classes/com/sun/tools/jdi/TargetVM.java ! src/share/classes/com/sun/tools/jdi/ThreadAction.java ! src/share/classes/com/sun/tools/jdi/ThreadGroupReferenceImpl.java ! src/share/classes/com/sun/tools/jdi/ThreadReferenceImpl.java ! src/share/classes/com/sun/tools/jdi/VMAction.java ! src/share/classes/com/sun/tools/jdi/VMState.java ! src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java From kumar.x.srinivasan at oracle.com Sun Dec 11 08:44:15 2011 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Sun, 11 Dec 2011 16:44:15 +0000 Subject: hg: jdk8/tl/langtools: 7119487: JavacParserTest.java test fails on Windows platforms Message-ID: <20111211164418.455AE4766C@hg.openjdk.java.net> Changeset: e7d5e1a7cde5 Author: ksrini Date: 2011-12-10 17:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e7d5e1a7cde5 7119487: JavacParserTest.java test fails on Windows platforms Reviewed-by: jjg + test/tools/javac/parser/JavacParserTest.java - test/tools/javac/parser/netbeans/JavacParserTest.java From maurizio.cimadamore at oracle.com Sun Dec 11 09:49:07 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Sun, 11 Dec 2011 17:49:07 +0000 Subject: hg: jdk8/tl/langtools: 7120266: javac fails to compile hotspot code Message-ID: <20111211174909.921EB4766D@hg.openjdk.java.net> Changeset: e55270a7a022 Author: mcimadamore Date: 2011-12-11 17:48 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e55270a7a022 7120266: javac fails to compile hotspot code Summary: Parser changes for method references cause bad intercation with method call syntax Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/T7120266.java ! test/tools/javac/lambda/MethodReferenceParserTest.java From neil.richards at ngmr.net Mon Dec 12 03:45:09 2011 From: neil.richards at ngmr.net (neil.richards at ngmr.net) Date: Mon, 12 Dec 2011 11:45:09 +0000 Subject: hg: jdk8/tl/jdk: 7118907: InetAddress.isReachable() should return false if sendto fails with EHOSTUNREACH Message-ID: <20111212114532.28EFA4766F@hg.openjdk.java.net> Changeset: c508f38245f8 Author: ngmr Date: 2011-12-12 11:41 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c508f38245f8 7118907: InetAddress.isReachable() should return false if sendto fails with EHOSTUNREACH Reviewed-by: alanb, chegar Contributed-by: Charles Lee ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c From neil.richards at ngmr.net Mon Dec 12 03:48:30 2011 From: neil.richards at ngmr.net (Neil Richards) Date: Mon, 12 Dec 2011 11:48:30 +0000 Subject: EHOSTUNREACH should not be considered as an exception when send on a loopback network interface. In-Reply-To: <4EE09774.7000601@oracle.com> References: <4E60608D.6010207@linux.vnet.ibm.com> <4E60626C.5030504@linux.vnet.ibm.com> <4EDF1FB6.706@linux.vnet.ibm.com> <4EDF4A23.8000801@oracle.com> <4EDF6C83.7040706@oracle.com> <4EE02C1E.9090004@linux.vnet.ibm.com> <4EE09774.7000601@oracle.com> Message-ID: <1323690510.20905.5.camel@chalkhill> On Thu, 2011-12-08 at 10:54 +0000, Chris Hegarty wrote: > On 08/12/2011 03:16, Charles Lee wrote: > > .... > > Hi Alan, hi Chris, > > > > Thank you for reviewing this and creating a bug id for me. I have put a > > revised webrev at http://cr.openjdk.java.net/~littlee/7118907/webrev.00/ > > . > > Looks fine to me. > > Let me know if you need help with the push. > > -Chris. > > > If it is ok for you guys, maybe Neil can help :-) > > I've now pushed this change up to jdk8/tl/jdk [1]. Regards, Neil [1] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c508f38245f8 -- Unless stated above: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From chris.hegarty at oracle.com Mon Dec 12 03:55:00 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 12 Dec 2011 11:55:00 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20111212115519.7D5DF47670@hg.openjdk.java.net> Changeset: 3216717f96f5 Author: dl Date: 2011-12-12 10:45 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3216717f96f5 7118066: Warnings in java.util.concurrent package Reviewed-by: chegar, dholmes ! src/share/classes/java/util/concurrent/ArrayBlockingQueue.java ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedDeque.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedQueue.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListMap.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListSet.java ! src/share/classes/java/util/concurrent/CopyOnWriteArrayList.java ! src/share/classes/java/util/concurrent/DelayQueue.java ! src/share/classes/java/util/concurrent/Exchanger.java ! src/share/classes/java/util/concurrent/ForkJoinPool.java ! src/share/classes/java/util/concurrent/ForkJoinTask.java ! src/share/classes/java/util/concurrent/ForkJoinWorkerThread.java ! src/share/classes/java/util/concurrent/LinkedTransferQueue.java ! src/share/classes/java/util/concurrent/Phaser.java ! src/share/classes/java/util/concurrent/PriorityBlockingQueue.java ! src/share/classes/java/util/concurrent/ScheduledThreadPoolExecutor.java ! src/share/classes/java/util/concurrent/SynchronousQueue.java ! test/java/util/Collections/EmptyIterator.java Changeset: d4f9d7e86a92 Author: chegar Date: 2011-12-12 03:54 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d4f9d7e86a92 Merge From kelly.ohair at oracle.com Mon Dec 12 15:29:35 2011 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Mon, 12 Dec 2011 23:29:35 +0000 Subject: hg: jdk8/tl: 7119829: Adjust default jprt testing configuration Message-ID: <20111212232935.6554647677@hg.openjdk.java.net> Changeset: 9acd7374ff8a Author: ohair Date: 2011-12-12 08:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/9acd7374ff8a 7119829: Adjust default jprt testing configuration Reviewed-by: alanb ! make/jprt.properties ! test/Makefile From kelly.ohair at oracle.com Mon Dec 12 15:29:45 2011 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Mon, 12 Dec 2011 23:29:45 +0000 Subject: hg: jdk8/tl/jdk: 7119829: Adjust default jprt testing configuration Message-ID: <20111212233005.ADA4047678@hg.openjdk.java.net> Changeset: 9c0a6185188f Author: ohair Date: 2011-12-12 08:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9c0a6185188f 7119829: Adjust default jprt testing configuration Reviewed-by: alanb ! make/jprt.properties ! test/Makefile From kelly.ohair at oracle.com Mon Dec 12 15:30:15 2011 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Mon, 12 Dec 2011 23:30:15 +0000 Subject: hg: jdk8/tl/jaxp: 2 new changesets Message-ID: <20111212233015.6A66A47679@hg.openjdk.java.net> Changeset: a482d45c93e9 Author: ohair Date: 2011-12-12 08:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/a482d45c93e9 7117110: Remove target 1.5 from jaxp and jaxws repo builds for mac Reviewed-by: alanb ! build.xml Changeset: a49db7c01db7 Author: ohair Date: 2011-12-12 08:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/a49db7c01db7 7119829: Adjust default jprt testing configuration Reviewed-by: alanb ! make/jprt.properties From kelly.ohair at oracle.com Mon Dec 12 15:30:34 2011 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Mon, 12 Dec 2011 23:30:34 +0000 Subject: hg: jdk8/tl/corba: 7119829: Adjust default jprt testing configuration Message-ID: <20111212233035.56B714767A@hg.openjdk.java.net> Changeset: 75529c21094f Author: ohair Date: 2011-12-12 08:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/75529c21094f 7119829: Adjust default jprt testing configuration Reviewed-by: alanb ! make/jprt.properties From kelly.ohair at oracle.com Mon Dec 12 15:30:42 2011 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Mon, 12 Dec 2011 23:30:42 +0000 Subject: hg: jdk8/tl/jaxws: 2 new changesets Message-ID: <20111212233042.C6FCE4767B@hg.openjdk.java.net> Changeset: 6d622b1b4db0 Author: ohair Date: 2011-12-12 08:13 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/6d622b1b4db0 7117110: Remove target 1.5 from jaxp and jaxws repo builds for mac Reviewed-by: alanb ! build.xml Changeset: 6d2030eacdac Author: ohair Date: 2011-12-12 08:13 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/6d2030eacdac 7119829: Adjust default jprt testing configuration Reviewed-by: alanb ! make/jprt.properties From kelly.ohair at oracle.com Mon Dec 12 15:31:28 2011 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Mon, 12 Dec 2011 23:31:28 +0000 Subject: hg: jdk8/tl/langtools: 7119829: Adjust default jprt testing configuration Message-ID: <20111212233132.4EEDB4767C@hg.openjdk.java.net> Changeset: 4822dfe0922b Author: ohair Date: 2011-12-12 08:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4822dfe0922b 7119829: Adjust default jprt testing configuration Reviewed-by: alanb ! make/jprt.properties From littlee at linux.vnet.ibm.com Mon Dec 12 18:08:51 2011 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Tue, 13 Dec 2011 10:08:51 +0800 Subject: EHOSTUNREACH should not be considered as an exception when send on a loopback network interface. In-Reply-To: <1323690510.20905.5.camel@chalkhill> References: <4E60608D.6010207@linux.vnet.ibm.com> <4E60626C.5030504@linux.vnet.ibm.com> <4EDF1FB6.706@linux.vnet.ibm.com> <4EDF4A23.8000801@oracle.com> <4EDF6C83.7040706@oracle.com> <4EE02C1E.9090004@linux.vnet.ibm.com> <4EE09774.7000601@oracle.com> <1323690510.20905.5.camel@chalkhill> Message-ID: <4EE6B3B3.7030808@linux.vnet.ibm.com> On 12/12/2011 07:48 PM, Neil Richards wrote: > On Thu, 2011-12-08 at 10:54 +0000, Chris Hegarty wrote: >> On 08/12/2011 03:16, Charles Lee wrote: >>> .... >>> Hi Alan, hi Chris, >>> >>> Thank you for reviewing this and creating a bug id for me. I have put a >>> revised webrev at http://cr.openjdk.java.net/~littlee/7118907/webrev.00/ >>> . >> Looks fine to me. >> >> Let me know if you need help with the push. >> >> -Chris. >> >>> If it is ok for you guys, maybe Neil can help :-) >>> > I've now pushed this change up to jdk8/tl/jdk [1]. > > Regards, > Neil > > [1] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c508f38245f8 > Thanks Neil. Thanks all for helping review the patch. -- Yours Charles From jonathan.gibbons at oracle.com Tue Dec 13 11:21:56 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 13 Dec 2011 19:21:56 +0000 Subject: hg: jdk8/tl/langtools: 7120736: refactor javac option handling Message-ID: <20111213192201.41ECF4769A@hg.openjdk.java.net> Changeset: 3809292620c9 Author: jjg Date: 2011-12-13 11:21 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3809292620c9 7120736: refactor javac option handling Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/file/Locations.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/Target.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/nio/JavacPathFileManager.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/util/BaseFileManager.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javac/util/Options.java ! test/tools/javac/diags/examples/UnsupportedEncoding.java From jonathan.gibbons at oracle.com Tue Dec 13 14:34:13 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 13 Dec 2011 22:34:13 +0000 Subject: hg: jdk8/tl/langtools: 7121164: renamed files not committed Message-ID: <20111213223417.65FFD4769E@hg.openjdk.java.net> Changeset: 4e4fed1d02f9 Author: jjg Date: 2011-12-13 14:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4e4fed1d02f9 7121164: renamed files not committed Reviewed-by: ksrini - src/share/classes/com/sun/tools/javac/main/JavacOption.java + src/share/classes/com/sun/tools/javac/main/Option.java + src/share/classes/com/sun/tools/javac/main/OptionHelper.java - src/share/classes/com/sun/tools/javac/main/OptionName.java - src/share/classes/com/sun/tools/javac/main/RecognizedOptions.java From naoto.sato at oracle.com Tue Dec 13 15:42:37 2011 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Tue, 13 Dec 2011 23:42:37 +0000 Subject: hg: jdk8/tl/jdk: 4808233: "Locale" not thread-safe Message-ID: <20111213234300.63D54476A1@hg.openjdk.java.net> Changeset: c647ebb3c4f7 Author: naoto Date: 2011-12-13 15:41 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c647ebb3c4f7 4808233: "Locale" not thread-safe Reviewed-by: okutsu ! src/share/classes/java/util/Locale.java From michael.x.mcmahon at oracle.com Wed Dec 14 11:39:51 2011 From: michael.x.mcmahon at oracle.com (Michael McMahon) Date: Wed, 14 Dec 2011 19:39:51 +0000 Subject: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts Message-ID: <4EE8FB87.8000004@oracle.com> Hi, This webrev fixes a bunch of test script issues in networking and core-libs. In most if not all cases, the change relates to recognising the OS that the test is running on. It also fixes an IPv6 issue, which requires Macos versions of a couple of java.net classes. These are the new files at the end of the webrev. The change is to provide a default sin6_scope_id when none is provided by the user. http://cr.openjdk.java.net/~michaelm/7120875/webrev.1/ Thanks, Michael. From Alan.Bateman at oracle.com Wed Dec 14 11:54:10 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 14 Dec 2011 19:54:10 +0000 Subject: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts In-Reply-To: <4EE8FB87.8000004@oracle.com> References: <4EE8FB87.8000004@oracle.com> Message-ID: <4EE8FEE2.2040303@oracle.com> On 14/12/2011 19:39, Michael McMahon wrote: > Hi, > > This webrev fixes a bunch of test script issues in networking and > core-libs. > In most if not all cases, the change relates to recognising the OS > that the test > is running on. > > It also fixes an IPv6 issue, which requires Macos versions of a couple > of java.net > classes. These are the new files at the end of the webrev. The change > is to provide > a default sin6_scope_id when none is provided by the user. > > http://cr.openjdk.java.net/~michaelm/7120875/webrev.1/ > > Thanks, > Michael. Michael - I haven't studied the IPv6 changes yet but I'm concerned that this creates a copy of java.net.MulticastSocket. Would some refactoring allow us to avoid this? In test/sun/net/www/protocol/jar/jarbug/run.sh then maybe it would make sense to combine SunOS, Linux and Darin into the one case. More generally then I guess most of these tests could be changed so that they default to PS=":" FS="/" when not on Windows or cygwin. Did you check the java code for the tests in these areas for any cases where they test based on os.name? -Alan. From kurchi.subhra.hazra at oracle.com Wed Dec 14 12:05:22 2011 From: kurchi.subhra.hazra at oracle.com (Kurchi Hazra) Date: Wed, 14 Dec 2011 12:05:22 -0800 Subject: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts In-Reply-To: <4EE8FEE2.2040303@oracle.com> References: <4EE8FB87.8000004@oracle.com> <4EE8FEE2.2040303@oracle.com> Message-ID: <4EE90182.6050004@oracle.com> On 12/14/2011 11:54 AM, Alan Bateman wrote: > On 14/12/2011 19:39, Michael McMahon wrote: >> Hi, >> >> This webrev fixes a bunch of test script issues in networking and >> core-libs. >> In most if not all cases, the change relates to recognising the OS >> that the test >> is running on. >> >> It also fixes an IPv6 issue, which requires Macos versions of a >> couple of java.net >> classes. These are the new files at the end of the webrev. The change >> is to provide >> a default sin6_scope_id when none is provided by the user. >> >> http://cr.openjdk.java.net/~michaelm/7120875/webrev.1/ >> >> Thanks, >> Michael. > Michael - I haven't studied the IPv6 changes yet but I'm concerned > that this creates a copy of java.net.MulticastSocket. Would some > refactoring allow us to avoid this? > > In test/sun/net/www/protocol/jar/jarbug/run.sh then maybe it would > make sense to combine SunOS, Linux and Darin into the one case. More > generally then I guess most of these tests could be changed so that > they default to PS=":" FS="/" when not on Windows or cygwin. Did you > check the java code for the tests in these areas for any cases where > they test based on os.name? I made that shell script change - I agree that all can be combined into one case but I just stuck to the general format in those files. > > -Alan. > > -- -Kurchi From Alan.Bateman at oracle.com Wed Dec 14 12:15:37 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 14 Dec 2011 20:15:37 +0000 Subject: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts In-Reply-To: <4EE90182.6050004@oracle.com> References: <4EE8FB87.8000004@oracle.com> <4EE8FEE2.2040303@oracle.com> <4EE90182.6050004@oracle.com> Message-ID: <4EE903E9.1020903@oracle.com> On 14/12/2011 20:05, Kurchi Hazra wrote: > > On 12/14/2011 11:54 AM, Alan Bateman wrote: >> : >> >> In test/sun/net/www/protocol/jar/jarbug/run.sh then maybe it would >> make sense to combine SunOS, Linux and Darin into the one case. More >> generally then I guess most of these tests could be changed so that >> they default to PS=":" FS="/" when not on Windows or cygwin. Did you >> check the java code for the tests in these areas for any cases where >> they test based on os.name? > > I made that shell script change - I agree that all can be combined > into one case but I just stuck to the general format in those files. > That's okay, it's just an inconsistency in test/sun/net/www/protocol/jar/jarbug/run.sh. When doing through the tests did you look for tests in these areas that look at os.name? I know we have a few. -Alan From kurchi.subhra.hazra at oracle.com Wed Dec 14 12:27:57 2011 From: kurchi.subhra.hazra at oracle.com (Kurchi Hazra) Date: Wed, 14 Dec 2011 12:27:57 -0800 Subject: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts In-Reply-To: <4EE903E9.1020903@oracle.com> References: <4EE8FB87.8000004@oracle.com> <4EE8FEE2.2040303@oracle.com> <4EE90182.6050004@oracle.com> <4EE903E9.1020903@oracle.com> Message-ID: <4EE906CD.5060608@oracle.com> On 12/14/2011 12:15 PM, Alan Bateman wrote: > On 14/12/2011 20:05, Kurchi Hazra wrote: >> >> On 12/14/2011 11:54 AM, Alan Bateman wrote: >>> : >>> >>> In test/sun/net/www/protocol/jar/jarbug/run.sh then maybe it would >>> make sense to combine SunOS, Linux and Darin into the one case. More >>> generally then I guess most of these tests could be changed so that >>> they default to PS=":" FS="/" when not on Windows or cygwin. Did you >>> check the java code for the tests in these areas for any cases where >>> they test based on os.name? >> >> I made that shell script change - I agree that all can be combined >> into one case but I just stuck to the general format in those files. >> > That's okay, it's just an inconsistency in > test/sun/net/www/protocol/jar/jarbug/run.sh. When doing through the > tests did you look for tests in these areas that look at os.name? I > know we have a few. - I did not look through individual tests, but only the ones that failed - I assumed that they will throw some error message if the platform is not recognized. > > -Alan -- -Kurchi From michael.x.mcmahon at oracle.com Wed Dec 14 12:57:31 2011 From: michael.x.mcmahon at oracle.com (Michael McMahon) Date: Wed, 14 Dec 2011 20:57:31 +0000 Subject: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts In-Reply-To: <4EE8FEE2.2040303@oracle.com> References: <4EE8FB87.8000004@oracle.com> <4EE8FEE2.2040303@oracle.com> Message-ID: <4EE90DBB.6010801@oracle.com> On 14/12/11 19:54, Alan Bateman wrote: > On 14/12/2011 19:39, Michael McMahon wrote: >> Hi, >> >> This webrev fixes a bunch of test script issues in networking and >> core-libs. >> In most if not all cases, the change relates to recognising the OS >> that the test >> is running on. >> >> It also fixes an IPv6 issue, which requires Macos versions of a >> couple of java.net >> classes. These are the new files at the end of the webrev. The change >> is to provide >> a default sin6_scope_id when none is provided by the user. >> >> http://cr.openjdk.java.net/~michaelm/7120875/webrev.1/ >> >> Thanks, >> Michael. > Michael - I haven't studied the IPv6 changes yet but I'm concerned > that this creates a copy of java.net.MulticastSocket. Would some > refactoring allow us to avoid this? > A check for "os.version" in the shared version of MulticastSocket would work. There's only a couple of lines of additional code required. But, then we don't want os specific code in the shared tree either. Don't know if you have other suggestions? This is just to workaround an issue in Macosx where (the Kame ipv6 stack is supposed to take care of default scope_id's but doesn;t seem to be). It's possible this issue may get resolved some time in the future, thus eliminating the need for the code. (I'll check this point with Mike anyway). > In test/sun/net/www/protocol/jar/jarbug/run.sh then maybe it would > make sense to combine SunOS, Linux and Darin into the one case. More > generally then I guess most of these tests could be changed so that > they default to PS=":" FS="/" when not on Windows or cygwin. Did you > check the java code for the tests in these areas for any cases where > they test based on os.name? > I'll let Kurchi deal with this one. - Michael. From Alan.Bateman at oracle.com Wed Dec 14 13:42:18 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 14 Dec 2011 21:42:18 +0000 Subject: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts In-Reply-To: <4EE906CD.5060608@oracle.com> References: <4EE8FB87.8000004@oracle.com> <4EE8FEE2.2040303@oracle.com> <4EE90182.6050004@oracle.com> <4EE903E9.1020903@oracle.com> <4EE906CD.5060608@oracle.com> Message-ID: <4EE9183A.1030905@oracle.com> On 14/12/2011 20:27, Kurchi Hazra wrote: > : > > - I did not look through individual tests, but only the ones that > failed - I assumed that they will throw some error message if the > platform is not recognized. > That's mostly true for the shell tests but there are many pure java tests that look at os.name to determine what to test and I don't think they fail if the platform is not recognized. For example in the networking area then test/java/net/DatagramSocket/SendDatagramToBadAddress.java is one example. All I'm suggest is doing a quick audit of the tests in the area that you are updating to check for java tests that need to be updated. -Alan. From Alan.Bateman at oracle.com Wed Dec 14 13:50:17 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 14 Dec 2011 21:50:17 +0000 Subject: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts In-Reply-To: <4EE90DBB.6010801@oracle.com> References: <4EE8FB87.8000004@oracle.com> <4EE8FEE2.2040303@oracle.com> <4EE90DBB.6010801@oracle.com> Message-ID: <4EE91A19.2000204@oracle.com> On 14/12/2011 20:57, Michael McMahon wrote: > > A check for "os.version" in the shared version of MulticastSocket > would work. There's > only a couple of lines of additional code required. But, then we don't > want os specific code > in the shared tree either. Don't know if you have other suggestions? > This is just to workaround an issue in Macosx > where (the Kame ipv6 stack is supposed to take care of default > scope_id's but doesn;t seem to be). > It's possible this issue may get resolved some time in the future, > thus eliminating the need for the code. > (I'll check this point with Mike anyway). For the short term I don't think there's a problem with having some mac specific code in the shared code while a better solution is worked out. However, we need to make sure all these things are cleaned up before it goes to 7u or 8. -Alan. From jonathan.gibbons at oracle.com Wed Dec 14 16:16:30 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 15 Dec 2011 00:16:30 +0000 Subject: hg: jdk8/tl/langtools: 7111022: javac no long prints last round of processing; ... Message-ID: <20111215001632.91A46476C7@hg.openjdk.java.net> Changeset: 4261dc8af622 Author: jjg Date: 2011-12-14 16:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4261dc8af622 7111022: javac no long prints last round of processing 7121323: Sqe tests using -Xstdout option fail with an invalid flag error message Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! test/tools/javac/4846262/Test.sh + test/tools/javac/processing/options/testPrintProcessorInfo/TestWithXstdout.java ! test/tools/javac/util/T6597678.java From jonathan.gibbons at oracle.com Wed Dec 14 17:52:56 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 15 Dec 2011 01:52:56 +0000 Subject: hg: jdk8/tl/langtools: 7121681: compiler message file broken for javac -fullversion Message-ID: <20111215015258.B181E476C8@hg.openjdk.java.net> Changeset: 281eeedf9755 Author: jjg Date: 2011-12-14 17:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/281eeedf9755 7121681: compiler message file broken for javac -fullversion Reviewed-by: jjh ! src/share/classes/com/sun/tools/javac/main/Option.java From jonathan.gibbons at oracle.com Wed Dec 14 21:54:05 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 15 Dec 2011 05:54:05 +0000 Subject: hg: jdk8/tl/langtools: 7121682: remove obsolete import Message-ID: <20111215055408.47894476CA@hg.openjdk.java.net> Changeset: 42ffceeceeca Author: jjg Date: 2011-12-14 21:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/42ffceeceeca 7121682: remove obsolete import Reviewed-by: jjh ! test/tools/javac/api/T6838467.java From chris.hegarty at oracle.com Thu Dec 15 07:00:10 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Thu, 15 Dec 2011 15:00:10 +0000 Subject: RFR 7095980: Ensure HttpURLConnection (and supporting APIs) don't expose HttpOnly cookies Message-ID: <4EEA0B7A.60404@oracle.com> CR 7095980: Ensure HttpURLConnection (and supporting APIs) don't expose HttpOnly cookies The changes use the internal/private java.net.HttpCookie parsing implementation to filter out HttpOnly cookies from the Set-Cookie and Set-Cookie2 headers returned in the HTTP protocol handler. With this change I believe the HTTP protocol suitably protects HttpOnly cookies. http://cr.openjdk.java.net/~chegar/7095980/webrev.00/webrev/ It reuses the internal java.net.HttpCookie parsing implementation rather than trying to maintain two separate parsing implementations. This is a little ugly since it is private and in the public java.net namespace, but I believe a shared secret is the best approach here. We could have moved the implementation itself into sun.net and just made it public, but I felt it cleaner to leave it as is. Thanks, -Chris. From brandon.passanisi at oracle.com Thu Dec 15 15:14:40 2011 From: brandon.passanisi at oracle.com (Brandon Passanisi) Date: Thu, 15 Dec 2011 15:14:40 -0800 Subject: Review for fix to Bug 7078386 Message-ID: <4EEA7F60.7070808@oracle.com> Hello net-dev. I was wondering if somebody could review the proposed fix for the following bug: Bug URL: http://monaco.sfbay.sun.com/detail.jsf?cr=7078386 Webrev : http://cr.openjdk.java.net/~michaelm/7078386/webrev.1/ The bug is caused by an incorrect format string used in the fscanf call within enumIPv6Interfaces of jdk/src/solaris/native/java/net/NetworkInterface.c, which specifies a two-digit hex number for the network interface index value. It has been shown that network interface index values can be more than 255, thus requiring the need to obtain more than two digits. I eventually searched through the following linux kernel source file: linux-source-2.6.32/net/ipv6/addrconf.c ... and it appears the interface index value is being written and an integer within the function inet6_fill_ifinfo in the following block of code starting on line 3785: if (dev->ifindex != dev->iflink) NLA_PUT_U32(skb, IFLA_LINK, dev->iflink); iflink is defined in linux-source-2.6.32/include/linux/netdevice.h as an int on line 742: /* Interface index. Unique device identifier */ int ifindex; int iflink; Because of this and because an integer is 32 bits, it appears that updating the format string to use %08x for the interface index value seems most correct. I have tested out this fix successfully in the following ways: 1. I ran the IBM-supplied test programs tapadd and Scope to create over 255 address in order to test an interface index value of at least three digits. (These programs will be added to the bug report if not present at this time.) The tapadd program is a C test requiring root access that uses tun/tap to create over 255 interfaces. Scope is a java program that does a NetworkInterface.getByName() on a known interface with an index over 255. 2. I modified the Scope program to additionally test all created interfaces, not just one interface with an index value over 255. (The original Scope test program just checks a single interface.) This is important to show there aren't regressions. 3. I created another test program using a script to run 'ip' commands to create over 255 interfaces. This script runs in a loop using the commands "sudo ip tunnel add..." and "sudo ip -6 addr add..." to add the interfaces. Then, I used the Scope program to verify the created interfaces. I wasn't able to create a script that would create a really huge amount of interfaces because using numbers like 65536 or higher in my script caused my Ubuntu linux to hang. So, I'm not quite sure how to truly test large interface index values like 65536 or more. Thanks. -- Oracle Brandon Passanisi | Principle Member of Technical Staff Green Oracle Oracle is committed to developing practices and products that help protect the environment -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111215/c2873320/attachment.html -------------- next part -------------- A non-text attachment was scrubbed... Name: oracle_sig_logo.gif Type: image/gif Size: 658 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111215/c2873320/oracle_sig_logo.gif -------------- next part -------------- A non-text attachment was scrubbed... Name: green-for-email-sig_0.gif Type: image/gif Size: 356 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111215/c2873320/green-for-email-sig_0.gif From lana.steuck at oracle.com Fri Dec 16 00:11:59 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 16 Dec 2011 08:11:59 +0000 Subject: hg: jdk8/tl: 5 new changesets Message-ID: <20111216081159.DB44347716@hg.openjdk.java.net> Changeset: 4e06ae613e99 Author: katleman Date: 2011-12-01 10:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/4e06ae613e99 Added tag jdk8-b15 for changeset a4f28069d44a ! .hgtags Changeset: 8606f4ab62dc Author: katleman Date: 2011-12-15 12:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/8606f4ab62dc Added tag jdk8-b17 for changeset 4e06ae613e99 ! .hgtags Changeset: d82d3bb3a2e5 Author: katleman Date: 2011-12-15 15:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/d82d3bb3a2e5 Added tag jdk8-b16 for changeset 4e06ae613e99 ! .hgtags Changeset: 7010bd24cdd0 Author: katleman Date: 2011-12-15 15:51 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/7010bd24cdd0 Merge ! .hgtags Changeset: 00d13c40d7a7 Author: lana Date: 2011-12-15 19:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/00d13c40d7a7 Merge From lana.steuck at oracle.com Fri Dec 16 00:12:01 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 16 Dec 2011 08:12:01 +0000 Subject: hg: jdk8/tl/jaxws: 7 new changesets Message-ID: <20111216081202.2C40B47717@hg.openjdk.java.net> Changeset: 76e37e606354 Author: katleman Date: 2011-12-01 10:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/76e37e606354 Added tag jdk8-b15 for changeset c9ab96ff23d5 ! .hgtags Changeset: 23c42f40fd3e Author: katleman Date: 2011-12-06 08:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/23c42f40fd3e 7117162: jdk8/jaxws/Makefile default DROPS_DIR should set to jdk8-drops Reviewed-by: ohair, xdono, mchung ! build.properties ! make/Makefile Changeset: 3d45ab79643d Author: katleman Date: 2011-12-07 13:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/3d45ab79643d Merge Changeset: b38846b9974c Author: katleman Date: 2011-12-15 12:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b38846b9974c Added tag jdk8-b17 for changeset 3d45ab79643d ! .hgtags Changeset: e662b652098c Author: katleman Date: 2011-12-15 15:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/e662b652098c Added tag jdk8-b16 for changeset 3d45ab79643d ! .hgtags Changeset: 54928c8850f5 Author: katleman Date: 2011-12-15 15:54 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/54928c8850f5 Merge ! .hgtags Changeset: b2e4ab8b5fa3 Author: lana Date: 2011-12-15 19:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b2e4ab8b5fa3 Merge From lana.steuck at oracle.com Fri Dec 16 00:12:03 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 16 Dec 2011 08:12:03 +0000 Subject: hg: jdk8/tl/jaxp: 7 new changesets Message-ID: <20111216081203.C4E6E47718@hg.openjdk.java.net> Changeset: 8181f7634e4a Author: katleman Date: 2011-12-01 10:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/8181f7634e4a Added tag jdk8-b15 for changeset 804f666d6d44 ! .hgtags Changeset: e32444f13774 Author: katleman Date: 2011-12-06 08:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/e32444f13774 7117162: jdk8/jaxws/Makefile default DROPS_DIR should set to jdk8-drops Reviewed-by: ohair, xdono, mchung ! build.properties ! make/Makefile Changeset: 09eb517404b0 Author: katleman Date: 2011-12-07 13:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/09eb517404b0 Merge Changeset: db44484a9d6e Author: katleman Date: 2011-12-15 12:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/db44484a9d6e Added tag jdk8-b17 for changeset 09eb517404b0 ! .hgtags Changeset: bc3ed3122933 Author: katleman Date: 2011-12-15 15:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/bc3ed3122933 Added tag jdk8-b16 for changeset 09eb517404b0 ! .hgtags Changeset: ebec6a7e8d4e Author: katleman Date: 2011-12-15 15:54 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/ebec6a7e8d4e Merge ! .hgtags Changeset: f26e2ab2c2c7 Author: lana Date: 2011-12-15 19:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/f26e2ab2c2c7 Merge From lana.steuck at oracle.com Fri Dec 16 00:11:59 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 16 Dec 2011 08:11:59 +0000 Subject: hg: jdk8/tl/corba: 5 new changesets Message-ID: <20111216081205.C2F9347719@hg.openjdk.java.net> Changeset: 82dc033975bb Author: katleman Date: 2011-12-01 10:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/82dc033975bb Added tag jdk8-b15 for changeset 7da69e7175a7 ! .hgtags Changeset: 05f47d29b438 Author: katleman Date: 2011-12-15 12:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/05f47d29b438 Added tag jdk8-b17 for changeset 82dc033975bb ! .hgtags Changeset: 6e51ad8d3707 Author: katleman Date: 2011-12-15 15:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/6e51ad8d3707 Added tag jdk8-b16 for changeset 82dc033975bb ! .hgtags Changeset: 312cf15d1657 Author: katleman Date: 2011-12-15 15:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/312cf15d1657 Merge ! .hgtags Changeset: 0289a94d653b Author: lana Date: 2011-12-15 19:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/0289a94d653b Merge From lana.steuck at oracle.com Fri Dec 16 00:12:00 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 16 Dec 2011 08:12:00 +0000 Subject: hg: jdk8/tl/hotspot: 4 new changesets Message-ID: <20111216081212.B6BDC4771A@hg.openjdk.java.net> Changeset: d1f29d4e0bc6 Author: katleman Date: 2011-12-01 10:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d1f29d4e0bc6 Added tag jdk8-b15 for changeset fde2a39ed7f3 ! .hgtags Changeset: 698a22e99f74 Author: katleman Date: 2011-12-15 12:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/698a22e99f74 Added tag jdk8-b17 for changeset d1f29d4e0bc6 ! .hgtags Changeset: 09f3b8a372b2 Author: katleman Date: 2011-12-15 15:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/09f3b8a372b2 Added tag jdk8-b16 for changeset d1f29d4e0bc6 ! .hgtags Changeset: e46c2339d0fc Author: katleman Date: 2011-12-15 15:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e46c2339d0fc Merge ! .hgtags From lana.steuck at oracle.com Fri Dec 16 00:12:11 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 16 Dec 2011 08:12:11 +0000 Subject: hg: jdk8/tl/langtools: 7 new changesets Message-ID: <20111216081227.C2EAF4771B@hg.openjdk.java.net> Changeset: ec2c0973cc31 Author: katleman Date: 2011-12-01 10:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ec2c0973cc31 Added tag jdk8-b15 for changeset 07599bd780ca ! .hgtags Changeset: 2584f5358cba Author: lana Date: 2011-12-06 20:26 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2584f5358cba Merge Changeset: 1cbe86c11ba6 Author: lana Date: 2011-12-12 10:08 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1cbe86c11ba6 Merge - test/tools/javac/parser/netbeans/JavacParserTest.java Changeset: 55a49c399603 Author: katleman Date: 2011-12-15 12:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/55a49c399603 Added tag jdk8-b17 for changeset 1cbe86c11ba6 ! .hgtags Changeset: 29a512337b79 Author: katleman Date: 2011-12-15 15:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/29a512337b79 Added tag jdk8-b16 for changeset ec2c0973cc31 ! .hgtags Changeset: ab1b1cc78577 Author: katleman Date: 2011-12-15 15:57 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ab1b1cc78577 Merge ! .hgtags - test/tools/javac/parser/netbeans/JavacParserTest.java Changeset: ab2a880cc23b Author: lana Date: 2011-12-15 19:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ab2a880cc23b Merge From lana.steuck at oracle.com Fri Dec 16 00:13:06 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 16 Dec 2011 08:13:06 +0000 Subject: hg: jdk8/tl/jdk: 31 new changesets Message-ID: <20111216081812.A66194771C@hg.openjdk.java.net> Changeset: 929597c6e777 Author: katleman Date: 2011-12-01 10:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/929597c6e777 Added tag jdk8-b15 for changeset 3c248d0e2c48 ! .hgtags Changeset: 23acf34c80b0 Author: neugens Date: 2011-12-03 15:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/23acf34c80b0 7117914: Fix javac warnings in src/share/classes/sun/java2d Summary: Fix some javac warnings in java2d related code for the Warning Cleanup Day. Reviewed-by: prr, flar ! src/share/classes/java/awt/geom/Path2D.java ! src/share/classes/sun/awt/image/BufImgSurfaceData.java ! src/share/classes/sun/java2d/SunGraphics2D.java ! src/share/classes/sun/java2d/SurfaceData.java ! src/share/classes/sun/java2d/SurfaceDataProxy.java ! src/share/classes/sun/java2d/loops/GraphicsPrimitive.java ! src/share/classes/sun/java2d/loops/SurfaceType.java ! src/share/classes/sun/java2d/opengl/OGLBufImgOps.java ! src/share/classes/sun/java2d/opengl/OGLDrawImage.java ! src/share/classes/sun/java2d/opengl/OGLPaints.java ! src/share/classes/sun/java2d/opengl/OGLSurfaceData.java ! src/share/classes/sun/java2d/pipe/AAShapePipe.java ! src/share/classes/sun/java2d/pipe/BufferedPaints.java ! src/share/classes/sun/java2d/pipe/BufferedRenderPipe.java ! src/share/classes/sun/java2d/pipe/DrawImage.java ! src/share/classes/sun/java2d/pipe/GlyphListPipe.java ! src/share/classes/sun/java2d/pipe/LoopPipe.java ! src/share/classes/sun/java2d/pipe/RenderingEngine.java ! src/solaris/classes/sun/java2d/x11/X11Renderer.java ! src/solaris/classes/sun/java2d/x11/X11SurfaceData.java Changeset: 70b40ea06df0 Author: prr Date: 2011-12-03 16:26 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70b40ea06df0 7117199: Fix javac warnings in src/share/classes/java/awt/font Reviewed-by: jgodinez, bae ! src/share/classes/java/awt/font/StyledParagraph.java ! src/share/classes/java/awt/font/TextAttribute.java ! src/share/classes/java/awt/font/TextLayout.java ! src/share/classes/java/awt/font/TextLine.java ! src/share/classes/java/awt/font/TextMeasurer.java Changeset: 4075d524fa46 Author: lana Date: 2011-12-06 16:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4075d524fa46 Merge Changeset: e53a078c2840 Author: anthony Date: 2011-11-09 13:43 +0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e53a078c2840 7045370: Java Statically Determines Display Size on Linux platforms Summary: Listen to ConfigureNotify events on the root window and update the current screen size accordingly Reviewed-by: art, bae ! src/share/classes/java/awt/Component.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11GraphicsDevice.java ! src/solaris/native/sun/awt/awt_GraphicsEnv.c Changeset: 84e473cf4531 Author: rupashka Date: 2011-11-10 14:10 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/84e473cf4531 6938583: Unexpected NullPointerException by InputContext.endComposition() Reviewed-by: rupashka Contributed-by: Charles Lee ! src/share/classes/javax/swing/text/DefaultCaret.java + test/javax/swing/text/DefaultCaret/6938583/bug6938583.java Changeset: 81f1b32f9e24 Author: malenkov Date: 2011-11-10 17:15 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81f1b32f9e24 7057459: Regression: Performance degradation with java.beans.XMLEncoder Reviewed-by: rupashka ! src/share/classes/java/beans/Encoder.java Changeset: e120c78cb45c Author: malenkov Date: 2011-11-10 17:27 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e120c78cb45c 7064279: Introspector.getBeanInfo() should release some resources in timely manner Reviewed-by: art, alexp ! src/share/classes/java/beans/Beans.java ! src/share/classes/java/beans/Introspector.java ! src/share/classes/java/beans/PropertyEditorManager.java + src/share/classes/java/beans/ThreadGroupContext.java ! test/java/beans/Beans/6669869/TestDesignTime.java ! test/java/beans/Beans/6669869/TestGuiAvailable.java ! test/java/beans/Introspector/6380849/TestBeanInfo.java + test/java/beans/Introspector/7064279/Test7064279.java + test/java/beans/Introspector/7064279/test.jar ! test/java/beans/Introspector/Test6660539.java ! test/java/beans/PropertyEditor/6380849/TestPropertyEditor.java Changeset: 8b6a69b2e482 Author: malenkov Date: 2011-11-10 17:32 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8b6a69b2e482 7087876: java/beans/PropertyDescriptor.html#createPropertyEditor() throws RE if editor cannot be created Reviewed-by: rupashka ! src/share/classes/java/beans/PropertyDescriptor.java + test/java/beans/PropertyEditor/Test7087876.java Changeset: b02495c51b9c Author: malenkov Date: 2011-11-10 17:35 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b02495c51b9c 7092744: XMLEncoder fails to encode and breaks backward compatibility Reviewed-by: rupashka ! src/share/classes/com/sun/beans/finder/AbstractFinder.java ! src/share/classes/com/sun/beans/finder/ConstructorFinder.java ! src/share/classes/com/sun/beans/finder/MethodFinder.java + test/java/beans/XMLEncoder/Test7092744.java Changeset: 16327765859c Author: malenkov Date: 2011-11-10 17:37 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/16327765859c 7087429: Constructor of java.beans.PropertyChangeEvent should declare thrown NPE for null source Reviewed-by: rupashka ! src/share/classes/java/beans/PropertyChangeEvent.java + test/java/beans/PropertyChangeSupport/Test7087429.java Changeset: f614bcada2a9 Author: anthony Date: 2011-11-11 15:17 +0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f614bcada2a9 7103610: _NET_WM_PID and WM_CLIENT_MACHINE are not set Summary: Set the properties to all top-level windows Reviewed-by: anthony Contributed-by: Danesh Dadachanji ! make/sun/xawt/mapfile-vers ! src/solaris/classes/sun/awt/X11/XWindowPeer.java ! src/solaris/native/sun/xawt/XToolkit.c Changeset: c0f3f1558a94 Author: rupashka Date: 2011-11-14 14:00 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c0f3f1558a94 7109617: Test was writed for Metal L&F but not set it Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com + test/javax/swing/plaf/metal/MetalLookAndFeel/5073047/bug5073047.java Changeset: a51777c9228a Author: malenkov Date: 2011-11-14 14:38 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a51777c9228a 7110521: Regression test failed: Introspector/TestTypeResolver.java Reviewed-by: rupashka ! test/java/beans/Introspector/TestTypeResolver.java Changeset: 28f768c41a90 Author: serb Date: 2011-11-12 04:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/28f768c41a90 6996291: command line selection of MToolkit by -Dawt.toolkit=sun.awt.motif.MToolkit fails from jdk7 b21 on Reviewed-by: art, dcherepanov, bae, prr ! make/sun/awt/FILES_c_unix.gmk ! make/sun/awt/FILES_export_unix.gmk ! make/sun/awt/mapfile-mawt-vers ! make/sun/awt/mapfile-vers-linux ! make/sun/awt/mawt.gmk - make/sun/motif12/reorder-i586 - make/sun/motif12/reorder-sparc - make/sun/motif12/reorder-sparcv9 ! make/sun/xawt/mapfile-vers ! src/solaris/classes/sun/awt/X11/ListHelper.java ! src/solaris/classes/sun/awt/X11/XEmbedCanvasPeer.java ! src/solaris/classes/sun/awt/X11/XEmbedChildProxyPeer.java - src/solaris/classes/sun/awt/motif/AWTLockAccess.java ! src/solaris/classes/sun/awt/motif/MFontConfiguration.java - src/solaris/classes/sun/awt/motif/MFontPeer.java - src/solaris/classes/sun/awt/motif/MToolkit.java - src/solaris/classes/sun/awt/motif/MToolkitThreadBlockedHandler.java - src/solaris/classes/sun/awt/motif/MWindowAttributes.java - src/solaris/classes/sun/awt/motif/X11FontMetrics.java - src/solaris/native/sun/awt/MouseInfo.c - src/solaris/native/sun/awt/XDrawingArea.c - src/solaris/native/sun/awt/XDrawingArea.h - src/solaris/native/sun/awt/XDrawingAreaP.h ! src/solaris/native/sun/awt/awt.h ! src/solaris/native/sun/awt/awt_AWTEvent.c ! src/solaris/native/sun/awt/awt_Component.h - src/solaris/native/sun/awt/awt_Cursor.h ! src/solaris/native/sun/awt/awt_DrawingSurface.c ! src/solaris/native/sun/awt/awt_Font.c ! src/solaris/native/sun/awt/awt_Font.h ! src/solaris/native/sun/awt/awt_GraphicsEnv.c ! src/solaris/native/sun/awt/awt_InputMethod.c - src/solaris/native/sun/awt/awt_KeyboardFocusManager.h - src/solaris/native/sun/awt/awt_MToolkit.c - src/solaris/native/sun/awt/awt_MToolkit.h - src/solaris/native/sun/awt/awt_MenuItem.h - src/solaris/native/sun/awt/awt_PopupMenu.h ! src/solaris/native/sun/awt/awt_Robot.c - src/solaris/native/sun/awt/awt_TopLevel.h - src/solaris/native/sun/awt/awt_Window.h - src/solaris/native/sun/awt/awt_mgrsel.c - src/solaris/native/sun/awt/awt_mgrsel.h - src/solaris/native/sun/awt/awt_motif.h ! src/solaris/native/sun/awt/awt_p.h ! src/solaris/native/sun/awt/awt_util.c ! src/solaris/native/sun/awt/awt_util.h - src/solaris/native/sun/awt/awt_wm.c - src/solaris/native/sun/awt/awt_wm.h - src/solaris/native/sun/awt/awt_xembed.h - src/solaris/native/sun/awt/awt_xembed_server.c - src/solaris/native/sun/awt/awt_xembed_server.h ! src/solaris/native/sun/awt/canvas.h ! src/solaris/native/sun/awt/multi_font.c ! src/solaris/native/sun/awt/multi_font.h ! src/solaris/native/sun/java2d/opengl/GLXSurfaceData.c ! src/solaris/native/sun/java2d/opengl/GLXSurfaceData.h ! src/solaris/native/sun/java2d/x11/X11SurfaceData.c ! src/solaris/native/sun/xawt/XToolkit.c Changeset: 6a9d735ebd0a Author: bagiras Date: 2011-11-16 15:40 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6a9d735ebd0a 7108598: Pogo Table Games freeze with JDK 7 Reviewed-by: art, ant ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java + test/java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java Changeset: 1df53949945d Author: lana Date: 2011-11-18 15:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1df53949945d Merge Changeset: 90d33a64a404 Author: rupashka Date: 2011-11-21 18:22 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/90d33a64a404 7109085: Test use hotkeys not intended for Mac Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com ! test/javax/swing/regtesthelpers/Util.java + test/javax/swing/text/DefaultEditorKit/4278839/bug4278839.java + test/javax/swing/text/JTextComponent/5074573/bug5074573.java + test/javax/swing/text/html/HTMLEditorKit/5043626/bug5043626.java Changeset: c3c80f96cb83 Author: rupashka Date: 2011-11-25 11:52 +0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c3c80f96cb83 7113337: Swing closed test tries to click in the area reserved for resize by Mac OS X Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com + test/javax/swing/PopupFactory/6276087/NonOpaquePopupMenuTest.java Changeset: 9cbc208dcf08 Author: rupashka Date: 2011-11-29 12:47 +0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9cbc208dcf08 7112925: closed/javax/swing/JTabbedPane/4624207/bug4624207.java fails on MacOS Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com + test/javax/swing/JTabbedPane/4624207/bug4624207.java Changeset: 051beb804b12 Author: rupashka Date: 2011-11-30 16:54 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/051beb804b12 7110440: closed/javax/swing/JScrollBar/4865918/bug4865918.java fails on Aqua L&F Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com + test/javax/swing/JScrollBar/4865918/bug4865918.java Changeset: 7dd4395fe4a5 Author: rupashka Date: 2011-11-30 19:38 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7dd4395fe4a5 7115357: closed/javax/swing/JTable/6263446/bug6263446Table.java fails on MacOS Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com + test/javax/swing/JTable/6263446/bug6263446.java Changeset: 4b416a0180dc Author: lana Date: 2011-11-29 15:57 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4b416a0180dc Merge - test/java/io/FileDescriptor/FileChannelFDTest.java - test/java/io/etc/FileDescriptorSharing.java Changeset: 45eb5a61da07 Author: lana Date: 2011-11-30 12:06 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/45eb5a61da07 Merge Changeset: 79b5c5a8c7e9 Author: serb Date: 2011-12-05 17:11 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/79b5c5a8c7e9 7115400: jdk 8 awt-gate build fails in headless toolkit on solaris. Reviewed-by: prr, art, bae ! make/sun/awt/FILES_c_unix.gmk + src/solaris/native/sun/awt/HeadlessToolkit.c ! src/solaris/native/sun/java2d/x11/X11SurfaceData.h Changeset: 2b1438297561 Author: lana Date: 2011-12-06 16:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2b1438297561 Merge - make/sun/motif12/reorder-i586 - make/sun/motif12/reorder-sparc - make/sun/motif12/reorder-sparcv9 - src/solaris/classes/sun/awt/motif/AWTLockAccess.java - src/solaris/classes/sun/awt/motif/MFontPeer.java - src/solaris/classes/sun/awt/motif/MToolkit.java - src/solaris/classes/sun/awt/motif/MToolkitThreadBlockedHandler.java - src/solaris/classes/sun/awt/motif/MWindowAttributes.java - src/solaris/classes/sun/awt/motif/X11FontMetrics.java - src/solaris/native/sun/awt/MouseInfo.c - src/solaris/native/sun/awt/XDrawingArea.c - src/solaris/native/sun/awt/XDrawingArea.h - src/solaris/native/sun/awt/XDrawingAreaP.h - src/solaris/native/sun/awt/awt_Cursor.h - src/solaris/native/sun/awt/awt_KeyboardFocusManager.h - src/solaris/native/sun/awt/awt_MToolkit.c - src/solaris/native/sun/awt/awt_MToolkit.h - src/solaris/native/sun/awt/awt_MenuItem.h - src/solaris/native/sun/awt/awt_PopupMenu.h - src/solaris/native/sun/awt/awt_TopLevel.h - src/solaris/native/sun/awt/awt_Window.h - src/solaris/native/sun/awt/awt_mgrsel.c - src/solaris/native/sun/awt/awt_mgrsel.h - src/solaris/native/sun/awt/awt_motif.h - src/solaris/native/sun/awt/awt_wm.c - src/solaris/native/sun/awt/awt_wm.h - src/solaris/native/sun/awt/awt_xembed.h - src/solaris/native/sun/awt/awt_xembed_server.c - src/solaris/native/sun/awt/awt_xembed_server.h Changeset: b71d1acfae52 Author: lana Date: 2011-12-06 20:25 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b71d1acfae52 Merge ! src/share/classes/java/beans/Beans.java ! src/share/classes/java/beans/Encoder.java ! src/share/classes/java/beans/Introspector.java ! src/share/classes/java/beans/PropertyDescriptor.java - src/share/native/java/util/zip/zlib-1.2.3/ChangeLog - src/share/native/java/util/zip/zlib-1.2.3/README - src/share/native/java/util/zip/zlib-1.2.3/compress.c - src/share/native/java/util/zip/zlib-1.2.3/crc32.h - src/share/native/java/util/zip/zlib-1.2.3/deflate.c - src/share/native/java/util/zip/zlib-1.2.3/deflate.h - src/share/native/java/util/zip/zlib-1.2.3/gzio.c - src/share/native/java/util/zip/zlib-1.2.3/infback.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.h - src/share/native/java/util/zip/zlib-1.2.3/inffixed.h - src/share/native/java/util/zip/zlib-1.2.3/inflate.c - src/share/native/java/util/zip/zlib-1.2.3/inflate.h - src/share/native/java/util/zip/zlib-1.2.3/inftrees.c - src/share/native/java/util/zip/zlib-1.2.3/inftrees.h - src/share/native/java/util/zip/zlib-1.2.3/patches/ChangeLog_java - src/share/native/java/util/zip/zlib-1.2.3/patches/crc32.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/inflate.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zconf.h.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zlib.h.diff - src/share/native/java/util/zip/zlib-1.2.3/trees.c - src/share/native/java/util/zip/zlib-1.2.3/trees.h - src/share/native/java/util/zip/zlib-1.2.3/uncompr.c - src/share/native/java/util/zip/zlib-1.2.3/zadler32.c - src/share/native/java/util/zip/zlib-1.2.3/zconf.h - src/share/native/java/util/zip/zlib-1.2.3/zcrc32.c - src/share/native/java/util/zip/zlib-1.2.3/zlib.h - src/share/native/java/util/zip/zlib-1.2.3/zutil.c - src/share/native/java/util/zip/zlib-1.2.3/zutil.h - test/java/util/ResourceBundle/Control/ExpirationTest.java - test/java/util/ResourceBundle/Control/ExpirationTest.sh Changeset: cd95291bbbf3 Author: katleman Date: 2011-12-15 12:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd95291bbbf3 Added tag jdk8-b17 for changeset b71d1acfae52 ! .hgtags Changeset: 8f3d916a9164 Author: katleman Date: 2011-12-15 15:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8f3d916a9164 Added tag jdk8-b16 for changeset 929597c6e777 ! .hgtags Changeset: e55ac966ed95 Author: katleman Date: 2011-12-15 15:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e55ac966ed95 Merge ! .hgtags - make/sun/motif12/reorder-i586 - make/sun/motif12/reorder-sparc - make/sun/motif12/reorder-sparcv9 - src/share/native/java/util/zip/zlib-1.2.3/ChangeLog - src/share/native/java/util/zip/zlib-1.2.3/README - src/share/native/java/util/zip/zlib-1.2.3/compress.c - src/share/native/java/util/zip/zlib-1.2.3/crc32.h - src/share/native/java/util/zip/zlib-1.2.3/deflate.c - src/share/native/java/util/zip/zlib-1.2.3/deflate.h - src/share/native/java/util/zip/zlib-1.2.3/gzio.c - src/share/native/java/util/zip/zlib-1.2.3/infback.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.h - src/share/native/java/util/zip/zlib-1.2.3/inffixed.h - src/share/native/java/util/zip/zlib-1.2.3/inflate.c - src/share/native/java/util/zip/zlib-1.2.3/inflate.h - src/share/native/java/util/zip/zlib-1.2.3/inftrees.c - src/share/native/java/util/zip/zlib-1.2.3/inftrees.h - src/share/native/java/util/zip/zlib-1.2.3/patches/ChangeLog_java - src/share/native/java/util/zip/zlib-1.2.3/patches/crc32.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/inflate.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zconf.h.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zlib.h.diff - src/share/native/java/util/zip/zlib-1.2.3/trees.c - src/share/native/java/util/zip/zlib-1.2.3/trees.h - src/share/native/java/util/zip/zlib-1.2.3/uncompr.c - src/share/native/java/util/zip/zlib-1.2.3/zadler32.c - src/share/native/java/util/zip/zlib-1.2.3/zconf.h - src/share/native/java/util/zip/zlib-1.2.3/zcrc32.c - src/share/native/java/util/zip/zlib-1.2.3/zlib.h - src/share/native/java/util/zip/zlib-1.2.3/zutil.c - src/share/native/java/util/zip/zlib-1.2.3/zutil.h - src/solaris/classes/sun/awt/motif/AWTLockAccess.java - src/solaris/classes/sun/awt/motif/MFontPeer.java - src/solaris/classes/sun/awt/motif/MToolkit.java - src/solaris/classes/sun/awt/motif/MToolkitThreadBlockedHandler.java - src/solaris/classes/sun/awt/motif/MWindowAttributes.java - src/solaris/classes/sun/awt/motif/X11FontMetrics.java - src/solaris/native/sun/awt/MouseInfo.c - src/solaris/native/sun/awt/XDrawingArea.c - src/solaris/native/sun/awt/XDrawingArea.h - src/solaris/native/sun/awt/XDrawingAreaP.h - src/solaris/native/sun/awt/awt_Cursor.h - src/solaris/native/sun/awt/awt_KeyboardFocusManager.h - src/solaris/native/sun/awt/awt_MToolkit.c - src/solaris/native/sun/awt/awt_MToolkit.h - src/solaris/native/sun/awt/awt_MenuItem.h - src/solaris/native/sun/awt/awt_PopupMenu.h - src/solaris/native/sun/awt/awt_TopLevel.h - src/solaris/native/sun/awt/awt_Window.h - src/solaris/native/sun/awt/awt_mgrsel.c - src/solaris/native/sun/awt/awt_mgrsel.h - src/solaris/native/sun/awt/awt_motif.h - src/solaris/native/sun/awt/awt_wm.c - src/solaris/native/sun/awt/awt_wm.h - src/solaris/native/sun/awt/awt_xembed.h - src/solaris/native/sun/awt/awt_xembed_server.c - src/solaris/native/sun/awt/awt_xembed_server.h - test/java/util/ResourceBundle/Control/ExpirationTest.java - test/java/util/ResourceBundle/Control/ExpirationTest.sh Changeset: e446c7d24d6c Author: lana Date: 2011-12-15 19:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e446c7d24d6c Merge - make/sun/motif12/reorder-i586 - make/sun/motif12/reorder-sparc - make/sun/motif12/reorder-sparcv9 - src/solaris/classes/sun/awt/motif/AWTLockAccess.java - src/solaris/classes/sun/awt/motif/MFontPeer.java - src/solaris/classes/sun/awt/motif/MToolkit.java - src/solaris/classes/sun/awt/motif/MToolkitThreadBlockedHandler.java - src/solaris/classes/sun/awt/motif/MWindowAttributes.java - src/solaris/classes/sun/awt/motif/X11FontMetrics.java - src/solaris/native/sun/awt/MouseInfo.c - src/solaris/native/sun/awt/XDrawingArea.c - src/solaris/native/sun/awt/XDrawingArea.h - src/solaris/native/sun/awt/XDrawingAreaP.h - src/solaris/native/sun/awt/awt_Cursor.h - src/solaris/native/sun/awt/awt_KeyboardFocusManager.h - src/solaris/native/sun/awt/awt_MToolkit.c - src/solaris/native/sun/awt/awt_MToolkit.h - src/solaris/native/sun/awt/awt_MenuItem.h - src/solaris/native/sun/awt/awt_PopupMenu.h - src/solaris/native/sun/awt/awt_TopLevel.h - src/solaris/native/sun/awt/awt_Window.h - src/solaris/native/sun/awt/awt_mgrsel.c - src/solaris/native/sun/awt/awt_mgrsel.h - src/solaris/native/sun/awt/awt_motif.h - src/solaris/native/sun/awt/awt_wm.c - src/solaris/native/sun/awt/awt_wm.h - src/solaris/native/sun/awt/awt_xembed.h - src/solaris/native/sun/awt/awt_xembed_server.c - src/solaris/native/sun/awt/awt_xembed_server.h From michael.x.mcmahon at oracle.com Fri Dec 16 01:01:13 2011 From: michael.x.mcmahon at oracle.com (Michael McMahon) Date: Fri, 16 Dec 2011 09:01:13 +0000 Subject: Review for fix to Bug 7078386 In-Reply-To: <4EEA7F60.7070808@oracle.com> References: <4EEA7F60.7070808@oracle.com> Message-ID: <4EEB08D9.1020108@oracle.com> Brandon, The fix looks good to me. Thanks for contributing it. - Michael. On 15/12/11 23:14, Brandon Passanisi wrote: > Hello net-dev. I was wondering if somebody could review the proposed > fix for the following bug: > > Bug URL: http://monaco.sfbay.sun.com/detail.jsf?cr=7078386 > Webrev : http://cr.openjdk.java.net/~michaelm/7078386/webrev.1/ > > > The bug is caused by an incorrect format string used in the fscanf > call within enumIPv6Interfaces of > jdk/src/solaris/native/java/net/NetworkInterface.c, which specifies a > two-digit hex number for the network interface index value. It has > been shown that network interface index values can be more than 255, > thus requiring the need to obtain more than two digits. I eventually > searched through the following linux kernel source file: > > linux-source-2.6.32/net/ipv6/addrconf.c > > ... and it appears the interface index value is being written and an > integer within the function inet6_fill_ifinfo in the following block > of code starting on line 3785: > > if (dev->ifindex != dev->iflink) > NLA_PUT_U32(skb, IFLA_LINK, dev->iflink); > > iflink is defined in linux-source-2.6.32/include/linux/netdevice.h as > an int on line 742: > > /* Interface index. Unique device identifier */ > int ifindex; > int iflink; > > Because of this and because an integer is 32 bits, it appears that > updating the format string to use %08x for the interface index value > seems most correct. > > I have tested out this fix successfully in the following ways: > > 1. I ran the IBM-supplied test programs tapadd and Scope to create > over 255 address in order to test an interface index value of at > least three digits. (These programs will be added to the bug > report if not present at this time.) The tapadd program is a C > test requiring root access that uses tun/tap to create over 255 > interfaces. Scope is a java program that does a > NetworkInterface.getByName() on a known interface with an index > over 255. > > 2. I modified the Scope program to additionally test all created > interfaces, not just one interface with an index value over 255. > (The original Scope test program just checks a single interface.) > This is important to show there aren't regressions. > > 3. I created another test program using a script to run 'ip' > commands to create over 255 interfaces. This script runs in a > loop using the commands "sudo ip tunnel add..." and "sudo ip -6 > addr add..." to add the interfaces. Then, I used the Scope > program to verify the created interfaces. > > I wasn't able to create a script that would create a really huge > amount of interfaces because using numbers like 65536 or higher in my > script caused my Ubuntu linux to hang. So, I'm not quite sure how to > truly test large interface index values like 65536 or more. > > Thanks. > -- > Oracle > Brandon Passanisi | Principle Member of Technical Staff > > Green Oracle Oracle is committed to > developing practices and products that help protect the environment -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111216/8e75c974/attachment.html -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: image/gif Size: 658 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111216/8e75c974/attachment.gif -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: image/gif Size: 356 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111216/8e75c974/attachment-0001.gif From michael.x.mcmahon at oracle.com Fri Dec 16 02:36:02 2011 From: michael.x.mcmahon at oracle.com (Michael McMahon) Date: Fri, 16 Dec 2011 10:36:02 +0000 Subject: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts In-Reply-To: <4EE8FB87.8000004@oracle.com> References: <4EE8FB87.8000004@oracle.com> Message-ID: <4EEB1F12.5060502@oracle.com> Updated webrev after Alan's comments. http://cr.openjdk.java.net/~michaelm/7120875/webrev.2/ Thanks, Michael. On 14/12/11 19:39, Michael McMahon wrote: > Hi, > > This webrev fixes a bunch of test script issues in networking and > core-libs. > In most if not all cases, the change relates to recognising the OS > that the test > is running on. > > It also fixes an IPv6 issue, which requires Macos versions of a couple > of java.net > classes. These are the new files at the end of the webrev. The change > is to provide > a default sin6_scope_id when none is provided by the user. > > http://cr.openjdk.java.net/~michaelm/7120875/webrev.1/ > > Thanks, > Michael. From Alan.Bateman at oracle.com Fri Dec 16 02:40:29 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 16 Dec 2011 10:40:29 +0000 Subject: Review for fix to Bug 7078386 In-Reply-To: <4EEA7F60.7070808@oracle.com> References: <4EEA7F60.7070808@oracle.com> Message-ID: <4EEB201D.1030801@oracle.com> On 15/12/2011 23:14, Brandon Passanisi wrote: > Hello net-dev. I was wondering if somebody could review the proposed > fix for the following bug: > > Bug URL: http://monaco.sfbay.sun.com/detail.jsf?cr=7078386 > Webrev : http://cr.openjdk.java.net/~michaelm/7078386/webrev.1/ > > The change looks good to me. -Alan. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111216/59699e4b/attachment.html From chris.hegarty at oracle.com Fri Dec 16 03:00:46 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Fri, 16 Dec 2011 11:00:46 +0000 Subject: Review for fix to Bug 7078386 In-Reply-To: <4EEB201D.1030801@oracle.com> References: <4EEA7F60.7070808@oracle.com> <4EEB201D.1030801@oracle.com> Message-ID: <4EEB24DE.3050604@oracle.com> On 12/16/11 10:40 AM, Alan Bateman wrote: > On 15/12/2011 23:14, Brandon Passanisi wrote: >> Hello net-dev. I was wondering if somebody could review the proposed >> fix for the following bug: >> >> Bug URL: http://monaco.sfbay.sun.com/detail.jsf?cr=7078386 >> Webrev : http://cr.openjdk.java.net/~michaelm/7078386/webrev.1/ >> >> > The change looks good to me. +1. Public link to the bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7078386 -Chris. > > -Alan. From michael.x.mcmahon at oracle.com Fri Dec 16 07:43:19 2011 From: michael.x.mcmahon at oracle.com (Michael McMahon) Date: Fri, 16 Dec 2011 15:43:19 +0000 Subject: RFR 7095980: Ensure HttpURLConnection (and supporting APIs) don't expose HttpOnly cookies In-Reply-To: <4EEA0B7A.60404@oracle.com> References: <4EEA0B7A.60404@oracle.com> Message-ID: <4EEB6717.50002@oracle.com> On 15/12/11 15:00, Chris Hegarty wrote: > CR 7095980: Ensure HttpURLConnection (and supporting APIs) don't > expose HttpOnly cookies > > The changes use the internal/private java.net.HttpCookie parsing > implementation to filter out HttpOnly cookies from the Set-Cookie and > Set-Cookie2 headers returned in the HTTP protocol handler. With this > change I believe the HTTP protocol suitably protects HttpOnly cookies. > > http://cr.openjdk.java.net/~chegar/7095980/webrev.00/webrev/ > > It reuses the internal java.net.HttpCookie parsing implementation > rather than trying to maintain two separate parsing implementations. > This is a little ugly since it is private and in the public java.net > namespace, but I believe a shared secret is the best approach here. We > could have moved the implementation itself into sun.net and just made > it public, but I felt it cleaner to leave it as is. > > Thanks, > -Chris. Looks good to me. - Michael. From kurchi.subhra.hazra at oracle.com Fri Dec 16 10:29:22 2011 From: kurchi.subhra.hazra at oracle.com (Kurchi Hazra) Date: Fri, 16 Dec 2011 10:29:22 -0800 Subject: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts In-Reply-To: <4EEB1F12.5060502@oracle.com> References: <4EE8FB87.8000004@oracle.com> <4EEB1F12.5060502@oracle.com> Message-ID: <4EEB8E02.8030501@oracle.com> The changes in the following files are not required I guess - perhaps they are my bad test/java/net/DatagramSocket/B6411513.java ||test/java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.java - Kurchi* * On 12/16/2011 2:36 AM, Michael McMahon wrote: > Updated webrev after Alan's comments. > > http://cr.openjdk.java.net/~michaelm/7120875/webrev.2/ > > Thanks, > Michael. > > On 14/12/11 19:39, Michael McMahon wrote: >> Hi, >> >> This webrev fixes a bunch of test script issues in networking and >> core-libs. >> In most if not all cases, the change relates to recognising the OS >> that the test >> is running on. >> >> It also fixes an IPv6 issue, which requires Macos versions of a >> couple of java.net >> classes. These are the new files at the end of the webrev. The change >> is to provide >> a default sin6_scope_id when none is provided by the user. >> >> http://cr.openjdk.java.net/~michaelm/7120875/webrev.1/ >> >> Thanks, >> Michael. > -- -Kurchi -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111216/db0b23a9/attachment.html From chris.hegarty at oracle.com Fri Dec 16 11:16:52 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 16 Dec 2011 19:16:52 +0000 Subject: hg: jdk8/tl/jdk: 7095980: Ensure HttpURLConnection (and supporting APIs) don't expose HttpOnly cookies Message-ID: <20111216191703.283FA4773B@hg.openjdk.java.net> Changeset: 33ac7a057b9c Author: chegar Date: 2011-12-16 16:09 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/33ac7a057b9c 7095980: Ensure HttpURLConnection (and supporting APIs) don't expose HttpOnly cookies Reviewed-by: michaelm ! src/share/classes/java/net/HttpCookie.java + src/share/classes/sun/misc/JavaNetHttpCookieAccess.java ! src/share/classes/sun/misc/SharedSecrets.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/sun/net/www/protocol/http/HttpOnly.java From jonathan.gibbons at oracle.com Fri Dec 16 13:50:09 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 16 Dec 2011 21:50:09 +0000 Subject: hg: jdk8/tl/langtools: 7121961: javadoc is missing a resource property Message-ID: <20111216215015.1DB0D4773C@hg.openjdk.java.net> Changeset: 6b773fdeb633 Author: jjg Date: 2011-12-16 13:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6b773fdeb633 7121961: javadoc is missing a resource property Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties From jim.holmlund at sun.com Fri Dec 16 16:42:59 2011 From: jim.holmlund at sun.com (jim.holmlund at sun.com) Date: Sat, 17 Dec 2011 00:42:59 +0000 Subject: hg: jdk8/tl/langtools: 7122342: testPrintProcessorInfo/TestWithXstdout.java failed for JDK8 nightly build at 12/16/2011 Message-ID: <20111217004301.B48AA4774D@hg.openjdk.java.net> Changeset: a7a2720c7897 Author: jjh Date: 2011-12-16 16:41 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a7a2720c7897 7122342: testPrintProcessorInfo/TestWithXstdout.java failed for JDK8 nightly build at 12/16/2011 Summary: Do not pass empty args to javac Reviewed-by: jjg ! test/tools/javac/processing/options/testPrintProcessorInfo/TestWithXstdout.java From stuart.marks at oracle.com Sat Dec 17 08:20:54 2011 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Sat, 17 Dec 2011 16:20:54 +0000 Subject: hg: jdk8/tl/jdk: 7122235: stop the build if javac fails Message-ID: <20111217162116.4EF5C47751@hg.openjdk.java.net> Changeset: abbca81a98a7 Author: smarks Date: 2011-12-17 08:21 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/abbca81a98a7 7122235: stop the build if javac fails Reviewed-by: chegar, dholmes, mcimadamore, ohair ! make/common/Rules.gmk From alan.bateman at oracle.com Sat Dec 17 12:10:05 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sat, 17 Dec 2011 20:10:05 +0000 Subject: hg: jdk8/tl/jdk: 7087549: (fs) Files.newInputStream throws UOE for custom provider options Message-ID: <20111217201024.B8B3547752@hg.openjdk.java.net> Changeset: 528eb0d43e3a Author: alanb Date: 2011-12-17 20:07 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/528eb0d43e3a 7087549: (fs) Files.newInputStream throws UOE for custom provider options Reviewed-by: alanb Contributed-by: brandon.passanisi at oracle.com ! src/share/classes/java/nio/file/spi/FileSystemProvider.java + test/java/nio/file/Files/CustomOptions.java From littlee at linux.vnet.ibm.com Sun Dec 18 19:25:55 2011 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Mon, 19 Dec 2011 11:25:55 +0800 Subject: InetAddress.getLocalHost() returns APIPA/link-local address in a Windows 2008 SP2 or later version Windows OS with multiple-NICs. In-Reply-To: <4EDF2494.20701@oracle.com> References: <4ED32F97.4070109@linux.vnet.ibm.com> <4ED3573C.7000607@oracle.com> <4ED43F3E.9070300@linux.vnet.ibm.com> <4ED4AA3A.5010504@oracle.com> <4ED6D4CA.7090807@linux.vnet.ibm.com> <4ED7553C.9080007@oracle.com> <4ED75AEC.9080706@oracle.com> <4ED88220.9000504@linux.vnet.ibm.com> <4EDE4DD6.4030102@oracle.com> <4EDF0E95.6010605@linux.vnet.ibm.com> <4EDF2494.20701@oracle.com> Message-ID: <4EEEAEC3.109@linux.vnet.ibm.com> On 12/07/2011 04:32 PM, Alan Bateman wrote: > On 07/12/2011 06:58, Charles Lee wrote: >> Hi Chris, >> >> Sorry I can not give a *detailed* description :-P Have you >> successfully get an APIPA address? [1] is the link which describe >> they have get such addresses :-D >> The behaviour difference was introduced by the some latest patches >> from the Microsoft. And I am heard recently that they are going to >> change this behaviour back future O:-) >> >> I am thinking that, since APIPA address is available, we may need to >> filter the return address array in case that the native api >> *accidentally* change its behaviour. >> >> [1] http://lmgtfy.com/?q=getaddrinfo+apipa >> > There's something fishy here. As this is a server then one would guess > that it would be configured with at least one static IP address and > for the hostname to resolve to one of those addresses. From the mails > it sounds like the hostname is resolving to a list that includes an > APIPA address address, which suggests to me a Windows bug or else > configuration that causes the APIPA to be automatically registered. Do > you have a reference to the patch that is causing this, it would be > nice to read the description. Also Microsoft tend to add registry > settings to revert behavior changes and maybe there is something for > this. As I said in one of the earlier mails, the patch is fine and > seems completely benign, it's just that this thread lacks the meat to > completely explain why it is needed. > > -Alan. > Hi Alan, Here is fix of Microsoft: http://support.microsoft.com/kb/2621067 -- Yours Charles From maurizio.cimadamore at oracle.com Mon Dec 19 04:07:58 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Mon, 19 Dec 2011 12:07:58 +0000 Subject: hg: jdk8/tl/langtools: 7120463: Fix method reference parser support in order to avoid ambiguities Message-ID: <20111219120803.7D0E547756@hg.openjdk.java.net> Changeset: 1ae5988e201b Author: mcimadamore Date: 2011-12-19 12:07 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1ae5988e201b 7120463: Fix method reference parser support in order to avoid ambiguities Summary: Add lookahead routine to disambiguate between method reference in method context and binary expression Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! test/tools/javac/lambda/MethodReferenceParserTest.java From Alan.Bateman at oracle.com Mon Dec 19 06:11:28 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 19 Dec 2011 14:11:28 +0000 Subject: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts In-Reply-To: <4EEB1F12.5060502@oracle.com> References: <4EE8FB87.8000004@oracle.com> <4EEB1F12.5060502@oracle.com> Message-ID: <4EEF4610.4010303@oracle.com> On 16/12/2011 10:36, Michael McMahon wrote: > Updated webrev after Alan's comments. > > http://cr.openjdk.java.net/~michaelm/7120875/webrev.2/ This is better but would be nice if we could avoid special casing MacOSX in java.net.MulticastSocket. Given that we may have to choose the default interface on other platforms when what would you think of MulticastSocket checking for default interface on all platforms? (could return null on platforms where it's not required). Same thing for java.net.PlainSocketImpl. The changes to the tests mostly look okay to me. There are a couple of tests where additional debugging messages have been added, I don't know if they are meant to be included, examples: test/java/net/DatagramSocket/B6411513.java java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.java. test/java/net/DatagramSocket/Send12k.java - now the send size is a local then it might be better to name is "size" rather than SEND_SIZE. There are a couple of tests the Darwin case has been combined with the Linux case, examples: test/java/net/URLClassLoader/B5077773.sh test/java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.sh test/java/net/URLConnection/6212146/test.sh No big deal but might be worth combining Linux too as further maintainers might wonder why Linux is separate to SunOS and Darwin. I exchanged a few mails with Kurchi about java tests as I think there are a couple of tests that need to be updated, examples: test/java/net/ipv6tests/Tests.java test/java/net/DatagramSocket/SendDatagramToBadAddress.java test/java/util/zip/ZipFile/ManyZipFiles.java test/java/lang/ProcessBuilder/Basic.java No problem if they are skipped in this round and I was just sending a reminder that java tests may need to be updated too (even if they pass). -Alan. From Alan.Bateman at oracle.com Mon Dec 19 10:53:38 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 19 Dec 2011 18:53:38 +0000 Subject: InetAddress.getLocalHost() returns APIPA/link-local address in a Windows 2008 SP2 or later version Windows OS with multiple-NICs. In-Reply-To: <4EEEAEC3.109@linux.vnet.ibm.com> References: <4ED32F97.4070109@linux.vnet.ibm.com> <4ED3573C.7000607@oracle.com> <4ED43F3E.9070300@linux.vnet.ibm.com> <4ED4AA3A.5010504@oracle.com> <4ED6D4CA.7090807@linux.vnet.ibm.com> <4ED7553C.9080007@oracle.com> <4ED75AEC.9080706@oracle.com> <4ED88220.9000504@linux.vnet.ibm.com> <4EDE4DD6.4030102@oracle.com> <4EDF0E95.6010605@linux.vnet.ibm.com> <4EDF2494.20701@oracle.com> <4EEEAEC3.109@linux.vnet.ibm.com> Message-ID: <4EEF8832.9080607@oracle.com> On 19/12/2011 03:25, Charles Lee wrote: > > Hi Alan, > > Here is fix of Microsoft: > > http://support.microsoft.com/kb/2621067 > Thanks for the link. I guess I'm still surprised that APIPA addresses are returned by getaddrinfo, irrespective of the ordering. -Alan. From xueming.shen at oracle.com Mon Dec 19 14:15:25 2011 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Mon, 19 Dec 2011 22:15:25 +0000 Subject: hg: jdk8/tl/jdk: 6990617: Regular expression doesn't match if unicode character next to a digit. Message-ID: <20111219221551.24C984775E@hg.openjdk.java.net> Changeset: 5b27b978ed42 Author: sherman Date: 2011-12-19 14:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5b27b978ed42 6990617: Regular expression doesn't match if unicode character next to a digit. Summary: updated RemoveQEQuotation() to deal with this case correctly Reviewed-by: sherman Contributed-by: stephen.flores at oracle.com ! src/share/classes/java/util/regex/Pattern.java ! test/java/util/regex/RegExTest.java From masayoshi.okutsu at oracle.com Wed Dec 21 00:14:39 2011 From: masayoshi.okutsu at oracle.com (masayoshi.okutsu at oracle.com) Date: Wed, 21 Dec 2011 08:14:39 +0000 Subject: hg: jdk8/tl/jdk: 7122054: (tz) Windows-only: tzmappings needs update for KB2633952 Message-ID: <20111221081457.59EF647777@hg.openjdk.java.net> Changeset: 1c4fffa22930 Author: okutsu Date: 2011-12-21 17:09 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1c4fffa22930 7122054: (tz) Windows-only: tzmappings needs update for KB2633952 Reviewed-by: peytoia ! src/windows/lib/tzmappings From michael.x.mcmahon at oracle.com Wed Dec 21 02:07:27 2011 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Wed, 21 Dec 2011 10:07:27 +0000 Subject: hg: jdk8/tl/jdk: 7078386: NetworkInterface.getNetworkInterfaces() may return corrupted results on linux Message-ID: <20111221100737.D926447778@hg.openjdk.java.net> Changeset: b1814b3ea6d3 Author: michaelm Date: 2011-12-21 10:06 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b1814b3ea6d3 7078386: NetworkInterface.getNetworkInterfaces() may return corrupted results on linux Reviewed-by: michaelm, alanb, chegar Contributed-by: brandon.passanisi at oracle.com ! src/solaris/native/java/net/NetworkInterface.c From brandon.passanisi at oracle.com Wed Dec 21 12:43:35 2011 From: brandon.passanisi at oracle.com (Brandon Passanisi) Date: Wed, 21 Dec 2011 12:43:35 -0800 Subject: Code Review Request for Bug #7123415 Message-ID: <4EF244F7.7000603@oracle.com> Hello net-dev. I was wondering if somebody could please review the following proposed fix for 7123415: Webrev URL: http://cr.openjdk.java.net/~bpassani/7123415/0/webrev/ The proposed fix is noted within the bug description: In src/solaris/native/java/net/net_util_md.c, there are instances of the network interface index being read in by a "%02x". These instances are on lines 616 and 1110 of net_util_md.c and they appear involve code that obtains the default loopback interface index and default ipv6 interface index. It has been shown by CR 7078386 that the index value can be more than two digits. Therefore, these instances should likely be changed to "%08x" as instructed in CR 7078386. I'm not sure how to come up with a reproducible test case for this as there currently aren't any tests which expose this specific problem. This bug was found as part of the investigation for CR 7078386. A reproducible test case would likely involve somehow setting the default loopback and ipv6 interfaces to a value more than 255, and I'm not sure if this can be done. It is hoped that the approval given for the same type of fix pushed for CR 7078386 will allow the fix here. Thanks. -- Oracle Brandon Passanisi | Principle Member of Technical Staff Green Oracle Oracle is committed to developing practices and products that help protect the environment -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111221/ca3c6769/attachment.html -------------- next part -------------- A non-text attachment was scrubbed... Name: oracle_sig_logo.gif Type: image/gif Size: 658 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111221/ca3c6769/oracle_sig_logo.gif -------------- next part -------------- A non-text attachment was scrubbed... Name: green-for-email-sig_0.gif Type: image/gif Size: 356 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/net-dev/attachments/20111221/ca3c6769/green-for-email-sig_0.gif From valerie.peng at oracle.com Wed Dec 21 14:22:12 2011 From: valerie.peng at oracle.com (valerie.peng at oracle.com) Date: Wed, 21 Dec 2011 22:22:12 +0000 Subject: hg: jdk8/tl/jdk: 6839886: Array overrun in pkcs11 Message-ID: <20111221222230.719CA47780@hg.openjdk.java.net> Changeset: a9dfdc523c2c Author: valeriep Date: 2011-12-21 14:08 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a9dfdc523c2c 6839886: Array overrun in pkcs11 Summary: Fix the wrong value when dealing w/ month and day. Reviewed-by: mullan ! src/share/native/sun/security/pkcs11/wrapper/p11_convert.c From weijun.wang at oracle.com Wed Dec 21 23:37:41 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Thu, 22 Dec 2011 07:37:41 +0000 Subject: hg: jdk8/tl/jdk: 7122169: TcpTimeout fail for various reasons Message-ID: <20111222073803.CAC204778C@hg.openjdk.java.net> Changeset: 11698dedbe79 Author: weijun Date: 2011-12-22 15:35 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11698dedbe79 7122169: TcpTimeout fail for various reasons Reviewed-by: alanb ! test/sun/security/krb5/auto/TcpTimeout.java From alan.bateman at oracle.com Thu Dec 22 02:54:12 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 22 Dec 2011 10:54:12 +0000 Subject: hg: jdk8/tl/jdk: 7076310: (file) AclEntry.Builder setFlags throws IllegalArgumentException if set argument is empty Message-ID: <20111222105450.9D90E4778F@hg.openjdk.java.net> Changeset: 559e07ed1f56 Author: alanb Date: 2011-12-22 10:52 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/559e07ed1f56 7076310: (file) AclEntry.Builder setFlags throws IllegalArgumentException if set argument is empty Reviewed-by: alanb Contributed-by: stephen.flores at oracle.com ! src/share/classes/java/nio/file/attribute/AclEntry.java + test/java/nio/file/attribute/AclEntry/EmptySet.java From michael.x.mcmahon at oracle.com Thu Dec 22 03:46:57 2011 From: michael.x.mcmahon at oracle.com (Michael McMahon) Date: Thu, 22 Dec 2011 11:46:57 +0000 Subject: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts In-Reply-To: <4EEF4610.4010303@oracle.com> References: <4EE8FB87.8000004@oracle.com> <4EEB1F12.5060502@oracle.com> <4EEF4610.4010303@oracle.com> Message-ID: <4EF318B1.1020202@oracle.com> On 19/12/11 14:11, Alan Bateman wrote: > On 16/12/2011 10:36, Michael McMahon wrote: >> Updated webrev after Alan's comments. >> >> http://cr.openjdk.java.net/~michaelm/7120875/webrev.2/ > This is better but would be nice if we could avoid special casing > MacOSX in java.net.MulticastSocket. Given that we may have to choose > the default interface on other platforms when what would you think of > MulticastSocket checking for default interface on all platforms? > (could return null on platforms where it's not required). Same thing > for java.net.PlainSocketImpl. > I've updated this to localize the changes to NetworkInterface (and the new class DefaultInterface). So, there's no change to the socket impl java code The new native code implementation is in net_util_md.c also, but called from Plain*SocketImpl.c > The changes to the tests mostly look okay to me. > > There are a couple of tests where additional debugging messages have > been added, I don't know if they are meant to be included, examples: > test/java/net/DatagramSocket/B6411513.java > java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.java. > > I've removed the debug outputs above. If all the above is ok, I'd like to push this change and address remaining test case issues in another changeset. New webrev @ http://cr.openjdk.java.net/~michaelm/7120875/webrev.4/ Thanks Michael > test/java/net/DatagramSocket/Send12k.java - now the send size is a > local then it might be better to name is "size" rather than SEND_SIZE. > > There are a couple of tests the Darwin case has been combined with the > Linux case, examples: > > test/java/net/URLClassLoader/B5077773.sh > test/java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.sh > > test/java/net/URLConnection/6212146/test.sh > > No big deal but might be worth combining Linux too as further > maintainers might wonder why Linux is separate to SunOS and Darwin. > > I exchanged a few mails with Kurchi about java tests as I think there > are a couple of tests that need to be updated, examples: > > test/java/net/ipv6tests/Tests.java > test/java/net/DatagramSocket/SendDatagramToBadAddress.java > test/java/util/zip/ZipFile/ManyZipFiles.java > test/java/lang/ProcessBuilder/Basic.java > > No problem if they are skipped in this round and I was just sending a > reminder that java tests may need to be updated too (even if they pass). > > -Alan. > > From Alan.Bateman at oracle.com Thu Dec 22 05:34:39 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 22 Dec 2011 13:34:39 +0000 Subject: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts In-Reply-To: <4EF318B1.1020202@oracle.com> References: <4EE8FB87.8000004@oracle.com> <4EEB1F12.5060502@oracle.com> <4EEF4610.4010303@oracle.com> <4EF318B1.1020202@oracle.com> Message-ID: <4EF331EF.5030007@oracle.com> On 22/12/2011 11:46, Michael McMahon wrote: > > I've updated this to localize the changes to NetworkInterface (and the > new class DefaultInterface). > So, there's no change to the socket impl java code > The new native code implementation is in net_util_md.c also, but > called from Plain*SocketImpl.c >> : > I've removed the debug outputs above. If all the above is ok, I'd like > to push this change > and address remaining test case issues in another changeset. > > New webrev @ http://cr.openjdk.java.net/~michaelm/7120875/webrev.4/ > This is much cleaner, thanks for persevering with it. A couple of minor comments: In NetworkInterface.java it looks a bit odd to add the static fields in the middle of the other fields. It would also be nice to add a comment to the package-private getDefault as it is used by several classes (and we likely need to be used by DatagramChannel too once you get to that area). In NetworkInterface.c then I assume the GetStaticFieldID doesn't need ifdef MACOSX around it. It's likely it will get used on other platforms too, Linux in particular. In PlainDatagramSocketImpl.c then I assume some of these changes could be combined with the ifdef __solaris__, I don't have a strong opinion on that. The Solaris and Windows implementations of DefaultInterface import Enumeration and IOException, I assume they are not needed. The Mac version of DefaultInterface is bit untidy. The ifc, if1, if2 variables could be named differently. It looks like it may call isPointToPoint and isLoopback several times which is costly given that each method needs to query the system. I pasted in the static initializer and edited here into a chooseDefaultInterface method that I think is a bit tidier: private final static NetworkInterface defaultInterface = chooseDefaultInterface(); /** * Choose a default interface. This method returns an interface that is * both "up" and supports multicast. This method choses an interface in * order of preference: * 1. neither loopback nor point to point * 2. point to point * 3. loopback * * @return the chosen interface or {@code null} if there isn't a suitable * default */ private static NetworkInterface chooseDefaultInterface() { Enumeration nifs; try { nifs = NetworkInterface.getNetworkInterfaces(); } catch (IOException ignore) { // unable to enumate network interfaces return null; } NetworkInterface ppp = null; NetworkInterface loopback = null; while (nifs.hasMoreElements()) { NetworkInterface ni = nifs.nextElement(); try { if (ni.isUp() && ni.supportsMulticast()) { boolean isLoopback = ni.isLoopback(); boolean isPPP = ni.isPointToPoint(); if (!isLoopback && !isPPP) { // found an interface that is not the loopback or a // point-to-point interface return ni; } if (ppp == null && isPPP) ppp = ni; if (loopback == null && isLoopback) loopback = ni; } } catch (IOException skip) { } } return (ppp != null) ? ppp : loopback; } The updates to the tests look fine to me. -Alan. From michael.x.mcmahon at oracle.com Thu Dec 22 05:46:53 2011 From: michael.x.mcmahon at oracle.com (Michael McMahon) Date: Thu, 22 Dec 2011 13:46:53 +0000 Subject: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts In-Reply-To: <4EF331EF.5030007@oracle.com> References: <4EE8FB87.8000004@oracle.com> <4EEB1F12.5060502@oracle.com> <4EEF4610.4010303@oracle.com> <4EF318B1.1020202@oracle.com> <4EF331EF.5030007@oracle.com> Message-ID: <4EF334CD.9020701@oracle.com> On 22/12/11 13:34, Alan Bateman wrote: > On 22/12/2011 11:46, Michael McMahon wrote: >> >> I've updated this to localize the changes to NetworkInterface (and >> the new class DefaultInterface). >> So, there's no change to the socket impl java code >> The new native code implementation is in net_util_md.c also, but >> called from Plain*SocketImpl.c >>> : >> I've removed the debug outputs above. If all the above is ok, I'd >> like to push this change >> and address remaining test case issues in another changeset. >> >> New webrev @ http://cr.openjdk.java.net/~michaelm/7120875/webrev.4/ >> > This is much cleaner, thanks for persevering with it. A couple of > minor comments: > Thanks Alan. I've no problem with the comments below. I will make the changes and go with that version, unless there are other comments. - Michael > In NetworkInterface.java it looks a bit odd to add the static fields > in the middle of the other fields. It would also be nice to add a > comment to the package-private getDefault as it is used by several > classes (and we likely need to be used by DatagramChannel too once you > get to that area). > > In NetworkInterface.c then I assume the GetStaticFieldID doesn't need > ifdef MACOSX around it. It's likely it will get used on other > platforms too, Linux in particular. > > In PlainDatagramSocketImpl.c then I assume some of these changes could > be combined with the ifdef __solaris__, I don't have a strong opinion > on that. > > The Solaris and Windows implementations of DefaultInterface import > Enumeration and IOException, I assume they are not needed. > > The Mac version of DefaultInterface is bit untidy. The ifc, if1, if2 > variables could be named differently. It looks like it may call > isPointToPoint and isLoopback several times which is costly given that > each method needs to query the system. I pasted in the static > initializer and edited here into a chooseDefaultInterface method that > I think is a bit tidier: > > private final static NetworkInterface defaultInterface = > chooseDefaultInterface(); > > /** > * Choose a default interface. This method returns an interface > that is > * both "up" and supports multicast. This method choses an > interface in > * order of preference: > * 1. neither loopback nor point to point > * 2. point to point > * 3. loopback > * > * @return the chosen interface or {@code null} if there isn't a > suitable > * default > */ > private static NetworkInterface chooseDefaultInterface() { > Enumeration nifs; > > try { > nifs = NetworkInterface.getNetworkInterfaces(); > } catch (IOException ignore) { > // unable to enumate network interfaces > return null; > } > > NetworkInterface ppp = null; > NetworkInterface loopback = null; > > while (nifs.hasMoreElements()) { > NetworkInterface ni = nifs.nextElement(); > try { > if (ni.isUp() && ni.supportsMulticast()) { > boolean isLoopback = ni.isLoopback(); > boolean isPPP = ni.isPointToPoint(); > if (!isLoopback && !isPPP) { > // found an interface that is not the loopback > or a > // point-to-point interface > return ni; > } > if (ppp == null && isPPP) > ppp = ni; > if (loopback == null && isLoopback) > loopback = ni; > } > } catch (IOException skip) { } > } > > return (ppp != null) ? ppp : loopback; > } > > The updates to the tests look fine to me. > > -Alan. > From michael.x.mcmahon at oracle.com Thu Dec 22 08:14:52 2011 From: michael.x.mcmahon at oracle.com (Michael McMahon) Date: Thu, 22 Dec 2011 16:14:52 +0000 Subject: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts In-Reply-To: <4EF334CD.9020701@oracle.com> References: <4EE8FB87.8000004@oracle.com> <4EEB1F12.5060502@oracle.com> <4EEF4610.4010303@oracle.com> <4EF318B1.1020202@oracle.com> <4EF331EF.5030007@oracle.com> <4EF334CD.9020701@oracle.com> Message-ID: <4EF3577C.8000708@oracle.com> On 22/12/11 13:46, Michael McMahon wrote: > On 22/12/11 13:34, Alan Bateman wrote: >> On 22/12/2011 11:46, Michael McMahon wrote: >>> >>> I've updated this to localize the changes to NetworkInterface (and >>> the new class DefaultInterface). >>> So, there's no change to the socket impl java code >>> The new native code implementation is in net_util_md.c also, but >>> called from Plain*SocketImpl.c >>>> : >>> I've removed the debug outputs above. If all the above is ok, I'd >>> like to push this change >>> and address remaining test case issues in another changeset. >>> >>> New webrev @ http://cr.openjdk.java.net/~michaelm/7120875/webrev.4/ >>> >> This is much cleaner, thanks for persevering with it. A couple of >> minor comments: >> > Thanks Alan. I've no problem with the comments below. I will make the > changes > and go with that version, unless there are other comments. > Final webrev hopefully: http://cr.openjdk.java.net/~michaelm/7120875/webrev.5/ Michael From Alan.Bateman at oracle.com Thu Dec 22 08:49:17 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 22 Dec 2011 16:49:17 +0000 Subject: Review request: 7120875 fix macos ipv6 issue and update multiple test scripts In-Reply-To: <4EF3577C.8000708@oracle.com> References: <4EE8FB87.8000004@oracle.com> <4EEB1F12.5060502@oracle.com> <4EEF4610.4010303@oracle.com> <4EF318B1.1020202@oracle.com> <4EF331EF.5030007@oracle.com> <4EF334CD.9020701@oracle.com> <4EF3577C.8000708@oracle.com> Message-ID: <4EF35F8D.8030207@oracle.com> On 22/12/2011 16:14, Michael McMahon wrote: > > Final webrev hopefully: > http://cr.openjdk.java.net/~michaelm/7120875/webrev.5/ I'm happy with this. -Alan From daniel.daugherty at oracle.com Thu Dec 22 18:38:36 2011 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Fri, 23 Dec 2011 02:38:36 +0000 Subject: hg: jdk8/tl/jdk: 7121600: Instrumentation.redefineClasses() leaks class bytes Message-ID: <20111223023853.7AC374779F@hg.openjdk.java.net> Changeset: 3c1ab134db71 Author: dcubed Date: 2011-12-22 18:35 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c1ab134db71 7121600: Instrumentation.redefineClasses() leaks class bytes Summary: Call JNI ReleaseByteArrayElements() on memory returned by JNI GetByteArrayElements(). Also push test for 7122253. Reviewed-by: acorn, poonam ! src/share/instrument/JPLISAgent.c + test/java/lang/instrument/BigClass.java + test/java/lang/instrument/MakeJAR4.sh + test/java/lang/instrument/RedefineBigClass.sh + test/java/lang/instrument/RedefineBigClassAgent.java + test/java/lang/instrument/RedefineBigClassApp.java + test/java/lang/instrument/RetransformBigClass.sh + test/java/lang/instrument/RetransformBigClassAgent.java + test/java/lang/instrument/RetransformBigClassApp.java From jonathan.gibbons at oracle.com Fri Dec 23 14:31:06 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 23 Dec 2011 22:31:06 +0000 Subject: hg: jdk8/tl/langtools: 7124605: typos in javac comments Message-ID: <20111223223110.6FA47477CE@hg.openjdk.java.net> Changeset: 116f68a5e677 Author: jjg Date: 2011-12-23 22:30 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/116f68a5e677 7124605: typos in javac comments Reviewed-by: ksrini ! test/tools/javac/generics/diamond/7046778/DiamondAndInnerClassTest.java ! test/tools/javac/generics/inference/7086601/T7086601b.java ! test/tools/javac/generics/rawOverride/7062745/GenericOverrideTest.java ! test/tools/javac/lambda/LambdaParserTest.java From littlee at linux.vnet.ibm.com Tue Dec 27 22:34:33 2011 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Wed, 28 Dec 2011 14:34:33 +0800 Subject: Give default value of O_NOFOLLOW if it is not defined Message-ID: <4EFAB879.9040208@linux.vnet.ibm.com> Hi net and nio, I would like to propose a fix[1] which give the default value of O_NOFOLLOW if, one some platforms, O_NOFOLLOW is not defined. Would anyone help to review this fix? [1]: http://cr.openjdk.java.net/~littlee/OJDK-226/webrev.00/ -- Yours Charles From chris.hegarty at oracle.com Wed Dec 28 01:38:19 2011 From: chris.hegarty at oracle.com (chris hegarty) Date: Wed, 28 Dec 2011 09:38:19 +0000 Subject: RFR 7125055: ContentHandler.getContent API changed in error Message-ID: <4EFAE38B.5000706@oracle.com> During some of the warning cleanups the method declaration of the public platform API java.net.ContentHandler.getContent(URLConnection, Class[]) was incorrectly changed. This CR proposes to revert this change fix appropriate subclasses, so as not to re-introduce warnings in this area. http://cr.openjdk.java.net/~chegar/7125055/webrev.00/webrev/ -Chris. From lana.steuck at oracle.com Wed Dec 28 11:59:19 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 28 Dec 2011 19:59:19 +0000 Subject: hg: jdk8/tl: 2 new changesets Message-ID: <20111228195919.EEA77477F0@hg.openjdk.java.net> Changeset: e1fc13802e0c Author: cl Date: 2011-12-22 19:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/e1fc13802e0c Added tag jdk8-b18 for changeset 7010bd24cdd0 ! .hgtags Changeset: 237bc29afbfc Author: lana Date: 2011-12-23 16:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/237bc29afbfc Merge From lana.steuck at oracle.com Wed Dec 28 11:59:21 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 28 Dec 2011 19:59:21 +0000 Subject: hg: jdk8/tl/corba: 2 new changesets Message-ID: <20111228195925.38AD7477F1@hg.openjdk.java.net> Changeset: 46bd4a46a5a8 Author: cl Date: 2011-12-22 19:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/46bd4a46a5a8 Added tag jdk8-b18 for changeset 312cf15d1657 ! .hgtags Changeset: e1366c5d84ef Author: lana Date: 2011-12-23 16:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/e1366c5d84ef Merge From lana.steuck at oracle.com Wed Dec 28 11:59:26 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 28 Dec 2011 19:59:26 +0000 Subject: hg: jdk8/tl/jaxp: 2 new changesets Message-ID: <20111228195926.7985F477F2@hg.openjdk.java.net> Changeset: 5fb25931f1c2 Author: cl Date: 2011-12-22 19:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/5fb25931f1c2 Added tag jdk8-b18 for changeset ebec6a7e8d4e ! .hgtags Changeset: dffeb62b1a7f Author: lana Date: 2011-12-23 16:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/dffeb62b1a7f Merge From lana.steuck at oracle.com Wed Dec 28 11:59:31 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 28 Dec 2011 19:59:31 +0000 Subject: hg: jdk8/tl/jaxws: 2 new changesets Message-ID: <20111228195931.27618477F3@hg.openjdk.java.net> Changeset: 72d410c3bab1 Author: cl Date: 2011-12-22 19:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/72d410c3bab1 Added tag jdk8-b18 for changeset 54928c8850f5 ! .hgtags Changeset: b73b733214aa Author: lana Date: 2011-12-23 16:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b73b733214aa Merge From lana.steuck at oracle.com Wed Dec 28 11:59:35 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 28 Dec 2011 19:59:35 +0000 Subject: hg: jdk8/tl/langtools: 3 new changesets Message-ID: <20111228195945.CC371477F4@hg.openjdk.java.net> Changeset: 3c71fcc22b99 Author: cl Date: 2011-12-22 19:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3c71fcc22b99 Added tag jdk8-b18 for changeset ab1b1cc78577 ! .hgtags Changeset: 77b2c066084c Author: lana Date: 2011-12-23 16:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/77b2c066084c Merge - src/share/classes/com/sun/tools/javac/main/JavacOption.java - src/share/classes/com/sun/tools/javac/main/OptionName.java - src/share/classes/com/sun/tools/javac/main/RecognizedOptions.java Changeset: 67512b631961 Author: lana Date: 2011-12-28 10:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/67512b631961 Merge From lana.steuck at oracle.com Wed Dec 28 11:59:56 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 28 Dec 2011 19:59:56 +0000 Subject: hg: jdk8/tl/hotspot: 70 new changesets Message-ID: <20111228200221.83B0B477F5@hg.openjdk.java.net> Changeset: da4182086289 Author: jcoomes Date: 2011-11-18 17:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/da4182086289 7113503: Bump the hs23 build number to 07 Reviewed-by: johnc Contributed-by: alejandro.murillo at oracle.com ! make/hotspot_version Changeset: 36b057451829 Author: dholmes Date: 2011-11-16 20:38 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/36b057451829 7110017: is_headless_jre should be updated to reflect the new location of awt toolkit libraries Reviewed-by: dholmes, dsamersoff Contributed-by: Chris Hegarty ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp Changeset: 002cb3fc8256 Author: coleenp Date: 2011-11-18 17:26 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/002cb3fc8256 Merge Changeset: c17bc65648de Author: brutisso Date: 2011-11-21 08:02 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c17bc65648de 7112308: Fix Visual Studio build for precompiled header Summary: Add the new path to precompiled.hpp in the project make file Reviewed-by: coleenp, dholmes, brutisso Contributed-by: rbackman ! make/windows/makefiles/projectcreator.make Changeset: 1d090cf33da6 Author: coleenp Date: 2011-11-21 10:22 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1d090cf33da6 Merge Changeset: 242b4e0e6f73 Author: phh Date: 2011-11-29 09:21 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/242b4e0e6f73 7116189: Export JVM_SetNativeThreadName from Hotspot Summary: Added JVM_SetNativeThreadName to linker mapfiles on Solaris and Linux. Reviewed-by: dcubed, dholmes Contributed-by: michael.x.mcmahon at oracle.com ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! make/solaris/makefiles/mapfile-vers Changeset: 763f01599ff4 Author: phh Date: 2011-11-29 17:00 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/763f01599ff4 7116481: Commercial features in Hotspot must be gated by a switch Summary: Add -XX:+UnlockCommercialVMOptions to gate use of commercial feature switches in the same way as -XX:UnlockDiagnosticVMOptions gates use of diagnostic feature switches. Reviewed-by: jwilhelm, kamg ! src/share/vm/runtime/globals.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/globals_extension.hpp Changeset: 358eca91be48 Author: phh Date: 2011-11-30 12:48 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/358eca91be48 7116730: Revert 7116481: Commercial features in Hotspot must be gated by a switch Summary: Revert 7116481 to current hsx/hotspot-main Reviewed-by: kamg ! src/share/vm/runtime/globals.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/globals_extension.hpp Changeset: 81a08cd7f6a1 Author: coleenp Date: 2011-12-01 13:42 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/81a08cd7f6a1 Merge Changeset: a88de71c4e3a Author: tonyp Date: 2011-11-18 12:52 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a88de71c4e3a 7097002: G1: remove a lot of unused / redundant code from the G1CollectorPolicy class Summary: Major cleanup of the G1CollectorPolicy class. It removes a lot of unused fields and methods and also consolidates replicated information (mainly various ways of counting the number of CSet regions) into one copy. Reviewed-by: johnc, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: d06a2d7fcd5b Author: brutisso Date: 2011-11-21 07:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d06a2d7fcd5b 7110718: -XX:MarkSweepAlwaysCompactCount=0 crashes the JVM Summary: Interpret MarkSweepAlwaysCompactCount < 1 as never do full compaction Reviewed-by: ysr, tonyp, jmasa, johnc ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweepDecorator.cpp ! src/share/vm/memory/space.hpp Changeset: b5a5f30c483d Author: johnc Date: 2011-11-21 09:24 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b5a5f30c483d 7110173: GCNotifier::pushNotification publishes stale data. Summary: GCNotifier::pushNotification() references GCMemoryManager::_last_gc_stat but is called from GCMemoryManager::gc_end() before GCMemoryManager::_last_gc_stat is set up using the values in GCMemoryManager::_current_gc_stat. As a result the GC notification code accesses unitialized or stale data. Move the notification call after GCMemoryManager::_las_gc_stat is set, but inside the same if-block. Reviewed-by: poonam, dholmes, fparain, mchung ! src/share/vm/services/memoryManager.cpp Changeset: 6071e0581859 Author: johnc Date: 2011-11-18 12:27 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6071e0581859 7111795: G1: Various cleanups identified during walk through of changes for 6484965 Summary: Various cleanups and formatting changes identified during a code walk through of the changes for 6484965 ("G1: piggy-back liveness accounting phase on marking"). Reviewed-by: brutisso, tonyp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp Changeset: 3a298e04d914 Author: tonyp Date: 2011-11-22 04:47 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3a298e04d914 Merge Changeset: bca17e38de00 Author: jmasa Date: 2011-08-09 10:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bca17e38de00 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads Summary: Select number of GC threads dynamically based on heap usage and number of Java threads Reviewed-by: johnc, ysr, jcoomes ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/g1/collectionSetChooser.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.hpp ! src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.cpp ! src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.hpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.hpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.hpp ! src/share/vm/gc_implementation/shared/adaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/shared/adaptiveSizePolicy.hpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/cardTableRS.cpp ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/memory/sharedHeap.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/utilities/workgroup.cpp ! src/share/vm/utilities/workgroup.hpp ! src/share/vm/utilities/yieldingWorkgroup.cpp ! src/share/vm/utilities/yieldingWorkgroup.hpp Changeset: 00dd86e542eb Author: johnc Date: 2011-11-28 09:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/00dd86e542eb 7114303: G1: assert(_g1->mark_in_progress()) failed: shouldn't be here otherwise Summary: Race between the VM thread reading G1CollectedHeap::_mark_in_progress and it being set by the concurrent mark thread when concurrent marking is aborted by a full GC. Have the concurrent mark thread join the SuspendibleThreadSet before changing the marking state. Reviewed-by: tonyp, brutisso ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp Changeset: dc467e8b2c5e Author: johnc Date: 2011-11-17 12:40 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/dc467e8b2c5e 7112743: G1: Reduce overhead of marking closure during evacuation pauses Summary: Parallelize the serial code that was used to mark objects reachable from survivor objects in the collection set. Some minor improvments in the timers used to track the freeing of the collection set along with some tweaks to PrintGCDetails. Reviewed-by: tonyp, brutisso ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.hpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp ! src/share/vm/oops/objArrayOop.hpp Changeset: ea640b5e949a Author: jmasa Date: 2011-11-22 14:18 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ea640b5e949a 7106024: CMS: Removed unused code for precleaning in remark phase Summary: Remove dead code. Reviewed-by: stefank, ysr ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/cardTableModRefBS.hpp Changeset: 7913e93dca52 Author: jmasa Date: 2011-11-22 14:59 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7913e93dca52 7112997: Remove obsolete code ResetObjectsClosure and VerifyUpdateClosure Summary: Remove obsolete code. Reviewed-by: brutisso, ysr, jcoomes ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/gc_implementation/shared/markSweep.inline.hpp Changeset: 1bbf5b6fb7b0 Author: tonyp Date: 2011-12-02 08:52 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1bbf5b6fb7b0 Merge ! src/share/vm/runtime/globals.hpp Changeset: 6de8c9ba5907 Author: jcoomes Date: 2011-12-02 15:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6de8c9ba5907 Merge Changeset: aed8bf036ce2 Author: jcoomes Date: 2011-12-02 15:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/aed8bf036ce2 Added tag hs23-b07 for changeset 6de8c9ba5907 ! .hgtags Changeset: cf4dd13bbcd3 Author: jcoomes Date: 2011-12-02 21:10 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cf4dd13bbcd3 7117536: new hotspot build - hs23-b08 Reviewed-by: johnc ! make/hotspot_version Changeset: cd00eaeebef6 Author: phh Date: 2011-12-05 12:50 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cd00eaeebef6 7117389: Add a framework for vendor-specific command line switch extensions to Hotspot Summary: Add a file, globals_ext.hpp, containing a null interface, to be replaced by a vendor in altsrc as needed. Reviewed-by: coleenp, kamg, dholmes, johnc, jrose ! src/share/vm/runtime/globals.cpp ! src/share/vm/runtime/globals.hpp + src/share/vm/runtime/globals_ext.hpp ! src/share/vm/runtime/globals_extension.hpp Changeset: 8657ec177a14 Author: dcubed Date: 2011-12-05 14:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8657ec177a14 7117748: SA_APPLE_BOOT_JAVA and ALWAYS_PASS_TEST_GAMMA settings should not be required on MacOS X Summary: Replace SA_APPLE_BOOT_JAVA with logic that checks the boot JDK for the location of JDI classes. ALWAYS_PASS_TEST_GAMMA is true by default on Darwin. Reviewed-by: kvn, swingler ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/sa.make Changeset: 41cce03b29a8 Author: dcubed Date: 2011-12-06 05:28 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/41cce03b29a8 Merge Changeset: 03865c41c4f3 Author: vladidan Date: 2011-12-06 16:35 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/03865c41c4f3 Merge ! src/share/vm/runtime/globals.hpp Changeset: 55d777c0860a Author: dcubed Date: 2011-12-07 07:27 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/55d777c0860a 7118648: disable compressed oops by default on MacOS X until 7118647 is fixed Summary: UseCompressedOops is false by default on MacOS X; can still be set manually Reviewed-by: jmelvin, kvn, dholmes ! src/share/vm/runtime/arguments.cpp Changeset: e8fdaf4a66cb Author: kvn Date: 2011-11-10 20:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e8fdaf4a66cb 7110586: C2 generates incorrect results Summary: Exact limit of empty loop calculated incorrectly. Reviewed-by: iveresov, never ! src/share/vm/opto/loopnode.cpp + test/compiler/7110586/Test7110586.java Changeset: 8c57262447d3 Author: kvn Date: 2011-11-14 18:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8c57262447d3 7105605: Use EA info to optimize pointers compare Summary: optimize pointers compare using EA information. Reviewed-by: never, twisti ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/escape.hpp Changeset: 6729bbc1fcd6 Author: twisti Date: 2011-11-16 01:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6729bbc1fcd6 7003454: order constants in constant table by number of references in code Reviewed-by: kvn, never, bdelsart ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/sparc/vm/vtableStubs_sparc.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/adlc/adlparse.cpp ! src/share/vm/adlc/output_c.cpp ! src/share/vm/asm/assembler.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/machnode.cpp ! src/share/vm/opto/matcher.hpp Changeset: 1bd45abaa507 Author: kvn Date: 2011-11-16 09:13 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1bd45abaa507 6890673: Eliminate allocations immediately after EA Summary: Try to eliminate allocations and related locks immediately after escape analysis. Reviewed-by: never ! src/share/vm/opto/block.cpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/macro.hpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp Changeset: 973293defacd Author: iveresov Date: 2011-11-16 19:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/973293defacd 7112085: assert(fr.interpreter_frame_expression_stack_size()==0) failed: only handle empty stacks Summary: Move the inlinee invoke notification callback into inlinee preamble Reviewed-by: kvn, never ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_Instruction.hpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/runtime/simpleThresholdPolicy.cpp ! src/share/vm/runtime/simpleThresholdPolicy.hpp ! test/compiler/6792161/Test6792161.java Changeset: a04a201f0f5a Author: twisti Date: 2011-11-17 04:07 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a04a201f0f5a 7108383: JSR 292: JRuby bench_define_method_methods.rb: assert(slow_jvms != NULL) failed: miss path must not Reviewed-by: kvn, never ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/doCall.cpp Changeset: 59bc0d4d9ea3 Author: never Date: 2011-11-18 10:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/59bc0d4d9ea3 7110489: C1: 64-bit tiered with ForceUnreachable: assert(reachable(src)) failed: Address should be reachable Reviewed-by: kvn, iveresov, twisti ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.hpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp Changeset: 7793051af7d6 Author: twisti Date: 2011-11-21 00:57 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7793051af7d6 7110058: change default for ScavengeRootsInCode to 2 Reviewed-by: kvn, never ! src/share/vm/runtime/globals.hpp Changeset: f03a3c8bd5e5 Author: roland Date: 2011-09-14 09:22 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f03a3c8bd5e5 7077312: Provide a CALL effect for instruct declaration in the ad file Summary: abstracted way to declare that the MachNode has the effect of a call (kills caller save registers, preserves callee save registers) Reviewed-by: twisti, never ! src/share/vm/adlc/adlparse.cpp ! src/share/vm/adlc/adlparse.hpp ! src/share/vm/adlc/archDesc.cpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/adlc/formssel.hpp ! src/share/vm/adlc/output_h.cpp ! src/share/vm/opto/block.hpp ! src/share/vm/opto/idealGraphPrinter.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/machnode.hpp ! src/share/vm/opto/node.hpp Changeset: db2e64ca2d5a Author: roland Date: 2011-11-22 09:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/db2e64ca2d5a 7090968: Allow adlc register class to depend on runtime conditions Summary: allow reg_class definition as a function. Reviewed-by: kvn, never ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/adlc/adlparse.cpp ! src/share/vm/adlc/archDesc.cpp ! src/share/vm/adlc/formsopt.cpp ! src/share/vm/adlc/formsopt.hpp ! src/share/vm/adlc/output_c.cpp ! src/share/vm/opto/matcher.hpp Changeset: cc81b9c09bbb Author: kvn Date: 2011-11-28 15:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cc81b9c09bbb 7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE Summary: Fixed several EA issues with Connection Graph construction. Reviewed-by: never, twisti ! src/share/vm/ci/bcEscapeAnalyzer.cpp ! src/share/vm/ci/bcEscapeAnalyzer.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/escape.hpp Changeset: 97825a4f7369 Author: iveresov Date: 2011-11-30 17:35 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/97825a4f7369 7116795: Tiered: enable by default for server Summary: Enable tiered compilation on server VM by default Reviewed-by: kvn, never ! make/jprt.properties ! src/cpu/sparc/vm/c2_globals_sparc.hpp ! src/cpu/x86/vm/c2_globals_x86.hpp Changeset: f745b2be3737 Author: kvn Date: 2011-12-02 21:37 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f745b2be3737 7117282: assert(base == NULL || t_adr->isa_rawptr() || !phase->type(base) Summary: Delay memory node transformation until the memory is processed. Reviewed-by: iveresov, never ! src/share/vm/opto/memnode.cpp Changeset: 81f7362f7bed Author: kvn Date: 2011-12-08 10:27 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/81f7362f7bed Merge ! make/jprt.properties ! src/share/vm/runtime/globals.hpp Changeset: 4406629aa157 Author: johnc Date: 2011-12-02 12:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4406629aa157 7114095: G1: assert(obj == oopDesc::load_decode_heap_oop(p)) failed: p should still be pointing to obj Summary: As a result of the changes for 4965777, the G1 reference field scanning closure could be applied to the discovered field of a reference object twice. The failing assert is too strong if the result of the first application of the closure is stolen, and the referenced object, evacuated by another worker thread. Reviewed-by: ysr, tonyp ! src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp Changeset: e37aedaedccd Author: tonyp Date: 2011-12-05 12:26 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e37aedaedccd Merge Changeset: f1391adc6681 Author: stefank Date: 2011-11-28 10:19 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f1391adc6681 7112034: Parallel CMS fails to properly mark reference objects Summary: Enabled reference processing when work stealing during concurrent marking Reviewed-by: jmasa, brutisso ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp Changeset: f4414323345f Author: stefank Date: 2011-11-28 14:58 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f4414323345f 7116081: USE_PRECOMPILED_HEADER=0 triggers a single threaded build of the JVM Summary: Changed the conditional to see if the precompiled header has been specified. Also, removed the unused PrecompiledOption. Reviewed-by: dholmes, brutisso ! make/bsd/makefiles/gcc.make ! make/bsd/makefiles/top.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/top.make ! make/solaris/makefiles/gcc.make Changeset: d23d2b18183e Author: tonyp Date: 2011-12-07 12:54 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d23d2b18183e 7118202: G1: eden size unnecessarily drops to a minimum Summary: An integer underflow can cause the RSet lengths to be massively overpredicted which forces the eden size to the minimum. Reviewed-by: brutisso, johnc ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp Changeset: e9b91fd07263 Author: jmasa Date: 2011-12-09 06:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e9b91fd07263 Merge Changeset: 6d7d0790074d Author: jmasa Date: 2011-12-09 19:28 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6d7d0790074d 7119584: UseParallelGC barrier task can be overwritten. Summary: Provoke a GC for a metadata allocation failure. Reviewed-by: johnc, iveresov ! src/share/vm/gc_implementation/parallelScavenge/gcTaskManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.cpp Changeset: 3b688d6ff3d0 Author: fparain Date: 2011-12-14 04:30 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3b688d6ff3d0 7104647: Adding a diagnostic command framework Reviewed-by: phh, dcubed ! src/share/vm/services/attachListener.cpp + src/share/vm/services/diagnosticArgument.cpp + src/share/vm/services/diagnosticArgument.hpp + src/share/vm/services/diagnosticCommand.cpp + src/share/vm/services/diagnosticCommand.hpp + src/share/vm/services/diagnosticFramework.cpp + src/share/vm/services/diagnosticFramework.hpp ! src/share/vm/services/jmm.h ! src/share/vm/services/management.cpp Changeset: 31f6f10e4379 Author: vladidan Date: 2011-12-14 20:06 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/31f6f10e4379 Merge Changeset: a2fef924d8e6 Author: amurillo Date: 2011-12-16 12:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a2fef924d8e6 Merge ! .hgtags Changeset: 61165f53f165 Author: amurillo Date: 2011-12-16 12:37 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/61165f53f165 Added tag hs23-b08 for changeset a2fef924d8e6 ! .hgtags Changeset: 7e075537835d Author: cl Date: 2011-12-22 19:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7e075537835d Added tag jdk8-b18 for changeset 61165f53f165 ! .hgtags Changeset: 434acc838772 Author: amurillo Date: 2011-12-16 12:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/434acc838772 7122001: new hotspot build - hs23-b09 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 3c648b9ad052 Author: stefank Date: 2011-12-14 12:15 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3c648b9ad052 7121373: Clean up CollectedHeap::is_in Summary: Fixed G1CollectedHeap::is_in, added tests, cleaned up comments and made Space::is_in pure virtual. Reviewed-by: brutisso, tonyp, jcoomes ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/memory/generation.hpp ! src/share/vm/memory/space.cpp ! src/share/vm/memory/space.hpp ! src/share/vm/oops/arrayOop.cpp ! src/share/vm/oops/arrayOop.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/utilities/quickSort.cpp ! src/share/vm/utilities/quickSort.hpp Changeset: fd2b426c30db Author: johnc Date: 2011-12-14 17:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fd2b426c30db 7119908: G1: Cache CSet start region for each worker for subsequent reuse Summary: Cache workers' calculated starting heap region, used for parallel iteration over the collcection set, for subsequent reuse. Reviewed-by: tonyp, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp Changeset: 41406797186b Author: tonyp Date: 2011-12-16 02:14 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/41406797186b 7113012: G1: rename not-fully-young GCs as "mixed" Summary: Renamed partially-young GCs as mixed and fully-young GCs as young. Change all external output that includes those terms (GC log and GC ergo log) as well as any comments, fields, methods, etc. The changeset also includes very minor code tidying up (added some curly brackets). Reviewed-by: johnc, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1ErgoVerbose.cpp ! src/share/vm/gc_implementation/g1/g1ErgoVerbose.hpp ! src/share/vm/gc_implementation/g1/g1MonitoringSupport.hpp Changeset: adedfbbf0360 Author: johnc Date: 2011-12-16 11:40 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/adedfbbf0360 7120038: G1: ParallelGCThreads==0 is broken Summary: Running G1 with ParallelGCThreads==0 results in various crashes and asserts. Most of these are caused by unguarded references to the worker threads array or an incorrect number of active workers. Reviewed-by: jmasa, tonyp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: e7dead7e90af Author: johnc Date: 2011-12-19 10:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e7dead7e90af 7117303: VM uses non-monotonic time source and complains that it is non-monotonic Summary: Replaces calls to os::javaTimeMillis(), which does not (and cannot) guarantee monotonicity, in GC code to an equivalent expression that uses os::javaTimeNanos(). os::javaTimeNanos is guaranteed monotonically non-decreasing if the underlying platform provides a monotonic time source. Changes in OS files are to make use of the newly defined constants in globalDefinitions.hpp. Reviewed-by: dholmes, ysr ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/generation.hpp ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 129cd462ae89 Author: jmasa Date: 2011-12-20 12:27 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/129cd462ae89 Merge Changeset: 96ce4c27112f Author: coleenp Date: 2011-12-19 15:34 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/96ce4c27112f 7122939: TraceBytecodes broken with UseCompressedOops Summary: Disable verify_heapbase on sparc if TraceBytecodes because the latter uses r12 as a temp register Reviewed-by: coleenp, phh Contributed-by: Volker Simonis ! src/cpu/x86/vm/assembler_x86.cpp Changeset: 6c995c08526c Author: phh Date: 2011-12-19 15:50 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6c995c08526c 7122880: Extend vendor-specific command interface to include manageable switches Summary: Add Flag::external_ext()/writable_ext(), both return false. Reviewed-by: coleenp, zgu ! src/share/vm/runtime/globals.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/globals_ext.hpp ! src/share/vm/services/management.cpp Changeset: 4502fd5c7698 Author: phh Date: 2011-12-19 21:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4502fd5c7698 Merge Changeset: 11c26bfcf8c7 Author: phh Date: 2011-12-21 15:48 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/11c26bfcf8c7 7091417: recvfrom's 6th input should be of type socklen_t Summary: Revamp class os's socket method formal args to match socket.h, insert casts in appropriate places, and copyin-copyout int*'s that s/b socklen_t*'s in jvm.cpp. Reviewed-by: coleenp, dholmes Contributed-by: erik.gahlin at oracle.com, rickard.backman at oracle.com, nils.loodin at oracle.com, markus.gronlund at oracle.com ! src/os/bsd/vm/jvm_bsd.h ! src/os/bsd/vm/os_bsd.inline.hpp ! src/os/linux/vm/jvm_linux.h ! src/os/linux/vm/os_linux.inline.hpp ! src/os/solaris/vm/jvm_solaris.h ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/os_solaris.inline.hpp ! src/os/windows/vm/jvm_windows.h ! src/os/windows/vm/os_windows.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/utilities/ostream.cpp Changeset: c01e115b095e Author: coleenp Date: 2011-12-21 16:41 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c01e115b095e 7064927: retransformClasses() does not pass in LocalVariableTable of a method Summary: Handle LVT attribute in the class file reconstitutor. Reviewed-by: phh, coleenp Contributed-by: thomaswue ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp ! src/share/vm/prims/jvmtiClassFileReconstituter.hpp Changeset: d532160c55f7 Author: coleenp Date: 2011-12-21 18:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d532160c55f7 Merge Changeset: 4b18532913c7 Author: vladidan Date: 2011-12-22 12:01 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4b18532913c7 Merge ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp Changeset: 4bcf61041217 Author: amurillo Date: 2011-12-23 15:24 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4bcf61041217 Merge Changeset: 9232e0ecbc2c Author: amurillo Date: 2011-12-23 15:24 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9232e0ecbc2c Added tag hs23-b09 for changeset 4bcf61041217 ! .hgtags From lana.steuck at oracle.com Wed Dec 28 12:00:51 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 28 Dec 2011 20:00:51 +0000 Subject: hg: jdk8/tl/jdk: 19 new changesets Message-ID: <20111228200409.CB685477F7@hg.openjdk.java.net> Changeset: 134420afe9c2 Author: ngthomas Date: 2011-11-13 21:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/134420afe9c2 7109885: security baseline for 7u2 or above is not set correctly Reviewed-by: ccheung, igor, ohair ! make/common/shared/Sanity.gmk Changeset: 6f594239e9dc Author: ngthomas Date: 2011-11-15 23:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6f594239e9dc 7112298: remove security baseline sanity check Reviewed-by: ccheung, igor, ohair ! make/common/shared/Sanity.gmk Changeset: fcc7cafa0027 Author: herrick Date: 2011-11-18 06:35 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fcc7cafa0027 Merge - make/sun/rmi/rmi/mapfile-vers - src/share/classes/sun/security/pkcs/EncodingException.java - src/share/classes/sun/security/pkcs/PKCS10.java - src/share/classes/sun/security/pkcs/PKCS10Attribute.java - src/share/classes/sun/security/pkcs/PKCS10Attributes.java - src/share/classes/sun/security/util/BigInt.java - src/share/classes/sun/security/util/PathList.java - src/share/classes/sun/security/x509/CertAndKeyGen.java - src/share/native/sun/rmi/server/MarshalInputStream.c - test/java/net/DatagramSocket/ChangingAddress.java - test/sun/security/util/BigInt/BigIntEqualsHashCode.java Changeset: 526e99f06a59 Author: igor Date: 2011-12-06 16:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/526e99f06a59 Merge - test/java/io/FileDescriptor/FileChannelFDTest.java - test/java/io/etc/FileDescriptorSharing.java Changeset: 334bd51fb3f3 Author: igor Date: 2011-12-19 10:06 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/334bd51fb3f3 Merge - make/sun/motif12/reorder-i586 - make/sun/motif12/reorder-sparc - make/sun/motif12/reorder-sparcv9 - src/share/native/java/util/zip/zlib-1.2.3/ChangeLog - src/share/native/java/util/zip/zlib-1.2.3/README - src/share/native/java/util/zip/zlib-1.2.3/compress.c - src/share/native/java/util/zip/zlib-1.2.3/crc32.h - src/share/native/java/util/zip/zlib-1.2.3/deflate.c - src/share/native/java/util/zip/zlib-1.2.3/deflate.h - src/share/native/java/util/zip/zlib-1.2.3/gzio.c - src/share/native/java/util/zip/zlib-1.2.3/infback.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.h - src/share/native/java/util/zip/zlib-1.2.3/inffixed.h - src/share/native/java/util/zip/zlib-1.2.3/inflate.c - src/share/native/java/util/zip/zlib-1.2.3/inflate.h - src/share/native/java/util/zip/zlib-1.2.3/inftrees.c - src/share/native/java/util/zip/zlib-1.2.3/inftrees.h - src/share/native/java/util/zip/zlib-1.2.3/patches/ChangeLog_java - src/share/native/java/util/zip/zlib-1.2.3/patches/crc32.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/inflate.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zconf.h.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zlib.h.diff - src/share/native/java/util/zip/zlib-1.2.3/trees.c - src/share/native/java/util/zip/zlib-1.2.3/trees.h - src/share/native/java/util/zip/zlib-1.2.3/uncompr.c - src/share/native/java/util/zip/zlib-1.2.3/zadler32.c - src/share/native/java/util/zip/zlib-1.2.3/zconf.h - src/share/native/java/util/zip/zlib-1.2.3/zcrc32.c - src/share/native/java/util/zip/zlib-1.2.3/zlib.h - src/share/native/java/util/zip/zlib-1.2.3/zutil.c - src/share/native/java/util/zip/zlib-1.2.3/zutil.h - src/solaris/classes/sun/awt/motif/AWTLockAccess.java - src/solaris/classes/sun/awt/motif/MFontPeer.java - src/solaris/classes/sun/awt/motif/MToolkit.java - src/solaris/classes/sun/awt/motif/MToolkitThreadBlockedHandler.java - src/solaris/classes/sun/awt/motif/MWindowAttributes.java - src/solaris/classes/sun/awt/motif/X11FontMetrics.java - src/solaris/native/sun/awt/MouseInfo.c - src/solaris/native/sun/awt/XDrawingArea.c - src/solaris/native/sun/awt/XDrawingArea.h - src/solaris/native/sun/awt/XDrawingAreaP.h - src/solaris/native/sun/awt/awt_Cursor.h - src/solaris/native/sun/awt/awt_KeyboardFocusManager.h - src/solaris/native/sun/awt/awt_MToolkit.c - src/solaris/native/sun/awt/awt_MToolkit.h - src/solaris/native/sun/awt/awt_MenuItem.h - src/solaris/native/sun/awt/awt_PopupMenu.h - src/solaris/native/sun/awt/awt_TopLevel.h - src/solaris/native/sun/awt/awt_Window.h - src/solaris/native/sun/awt/awt_mgrsel.c - src/solaris/native/sun/awt/awt_mgrsel.h - src/solaris/native/sun/awt/awt_motif.h - src/solaris/native/sun/awt/awt_wm.c - src/solaris/native/sun/awt/awt_wm.h - src/solaris/native/sun/awt/awt_xembed.h - src/solaris/native/sun/awt/awt_xembed_server.c - src/solaris/native/sun/awt/awt_xembed_server.h - test/java/util/ResourceBundle/Control/ExpirationTest.java - test/java/util/ResourceBundle/Control/ExpirationTest.sh Changeset: c6fab5332075 Author: cl Date: 2011-12-22 19:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c6fab5332075 Added tag jdk8-b18 for changeset 334bd51fb3f3 ! .hgtags Changeset: 7dbc53242c2a Author: art Date: 2011-12-07 17:45 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7dbc53242c2a 7117008: Warnings cleanup day: reduce number of javac warnings in the sun.awt package Reviewed-by: anthony, denis, bagiras ! src/share/classes/sun/awt/AWTAutoShutdown.java ! src/share/classes/sun/awt/AppContext.java ! src/share/classes/sun/awt/CausedFocusEvent.java ! src/share/classes/sun/awt/DebugSettings.java ! src/share/classes/sun/awt/EmbeddedFrame.java ! src/share/classes/sun/awt/EventListenerAggregate.java - src/share/classes/sun/awt/FocusingTextField.java ! src/share/classes/sun/awt/HeadlessToolkit.java - src/share/classes/sun/awt/HorizBagLayout.java ! src/share/classes/sun/awt/KeyboardFocusManagerPeerImpl.java ! src/share/classes/sun/awt/ModalityEvent.java - src/share/classes/sun/awt/OrientableFlowLayout.java ! src/share/classes/sun/awt/PaintEventDispatcher.java ! src/share/classes/sun/awt/PeerEvent.java ! src/share/classes/sun/awt/SunDisplayChanger.java ! src/share/classes/sun/awt/SunGraphicsCallback.java ! src/share/classes/sun/awt/SunToolkit.java ! src/share/classes/sun/awt/UngrabEvent.java - src/share/classes/sun/awt/VariableGridLayout.java - src/share/classes/sun/awt/VerticalBagLayout.java Changeset: 18925904efc2 Author: alexsch Date: 2011-12-12 15:33 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/18925904efc2 7105890: closed/javax/swing/JScrollBar/4708809/bug4708809.java deadlocks on MacOS Reviewed-by: alexp + test/javax/swing/JScrollBar/4708809/bug4708809.java Changeset: 44b26d6a55a6 Author: alexsch Date: 2011-12-13 15:32 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/44b26d6a55a6 7112931: closed/javax/swing/JTabbedPane/6416920/bug6416920.java fails on MacOS Reviewed-by: alexp + test/javax/swing/JTabbedPane/6416920/bug6416920.java Changeset: 70233f5e909c Author: alexsch Date: 2011-12-13 17:30 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70233f5e909c 7120869: javax/swing/JScrollBar/4708809/bug4708809.java fails on Windows Summary: The robot auto-delay is increased to fix the test failing on Windows. Reviewed-by: alexp ! test/javax/swing/JScrollBar/4708809/bug4708809.java Changeset: 032a91abc540 Author: alexsch Date: 2011-12-13 18:38 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/032a91abc540 7116950: Reduce number of warnings in swing Reviewed-by: art ! src/share/classes/com/sun/java/swing/Painter.java ! src/share/classes/java/beans/PropertyDescriptor.java ! src/share/classes/javax/swing/AbstractButton.java ! src/share/classes/javax/swing/ActionMap.java ! src/share/classes/javax/swing/ActionPropertyChangeListener.java ! src/share/classes/javax/swing/AncestorNotifier.java ! src/share/classes/javax/swing/ArrayTable.java ! src/share/classes/javax/swing/Box.java ! src/share/classes/javax/swing/BoxLayout.java ! src/share/classes/javax/swing/ButtonGroup.java ! src/share/classes/javax/swing/ComponentInputMap.java ! src/share/classes/javax/swing/InputMap.java ! src/share/classes/javax/swing/JButton.java ! src/share/classes/javax/swing/JComponent.java ! src/share/classes/javax/swing/JLabel.java ! src/share/classes/javax/swing/JLayeredPane.java ! src/share/classes/javax/swing/JMenu.java ! src/share/classes/javax/swing/JMenuBar.java ! src/share/classes/javax/swing/JMenuItem.java ! src/share/classes/javax/swing/JPopupMenu.java ! src/share/classes/javax/swing/JRootPane.java ! src/share/classes/javax/swing/JSeparator.java ! src/share/classes/javax/swing/JToolTip.java ! src/share/classes/javax/swing/JTree.java ! src/share/classes/javax/swing/JWindow.java ! src/share/classes/javax/swing/MenuSelectionManager.java ! src/share/classes/javax/swing/Popup.java ! src/share/classes/javax/swing/RepaintManager.java ! src/share/classes/javax/swing/Timer.java ! src/share/classes/javax/swing/border/AbstractBorder.java ! src/share/classes/javax/swing/border/CompoundBorder.java ! src/share/classes/javax/swing/border/EmptyBorder.java ! src/share/classes/javax/swing/border/MatteBorder.java ! src/share/classes/javax/swing/border/TitledBorder.java ! src/share/classes/javax/swing/event/AncestorEvent.java ! src/share/classes/javax/swing/event/ChangeEvent.java ! src/share/classes/javax/swing/event/EventListenerList.java ! src/share/classes/javax/swing/event/ListDataEvent.java ! src/share/classes/javax/swing/event/MenuDragMouseEvent.java ! src/share/classes/javax/swing/event/MenuEvent.java ! src/share/classes/javax/swing/event/MenuKeyEvent.java ! src/share/classes/javax/swing/event/PopupMenuEvent.java ! src/share/classes/javax/swing/plaf/ComponentUI.java ! src/share/classes/javax/swing/text/BadLocationException.java ! src/share/classes/javax/swing/tree/DefaultTreeSelectionModel.java Changeset: 282b2ce90afe Author: lana Date: 2011-12-16 12:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/282b2ce90afe Merge ! src/share/classes/java/beans/PropertyDescriptor.java - src/share/native/java/util/zip/zlib-1.2.3/ChangeLog - src/share/native/java/util/zip/zlib-1.2.3/README - src/share/native/java/util/zip/zlib-1.2.3/compress.c - src/share/native/java/util/zip/zlib-1.2.3/crc32.h - src/share/native/java/util/zip/zlib-1.2.3/deflate.c - src/share/native/java/util/zip/zlib-1.2.3/deflate.h - src/share/native/java/util/zip/zlib-1.2.3/gzio.c - src/share/native/java/util/zip/zlib-1.2.3/infback.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.h - src/share/native/java/util/zip/zlib-1.2.3/inffixed.h - src/share/native/java/util/zip/zlib-1.2.3/inflate.c - src/share/native/java/util/zip/zlib-1.2.3/inflate.h - src/share/native/java/util/zip/zlib-1.2.3/inftrees.c - src/share/native/java/util/zip/zlib-1.2.3/inftrees.h - src/share/native/java/util/zip/zlib-1.2.3/patches/ChangeLog_java - src/share/native/java/util/zip/zlib-1.2.3/patches/crc32.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/inflate.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zconf.h.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zlib.h.diff - src/share/native/java/util/zip/zlib-1.2.3/trees.c - src/share/native/java/util/zip/zlib-1.2.3/trees.h - src/share/native/java/util/zip/zlib-1.2.3/uncompr.c - src/share/native/java/util/zip/zlib-1.2.3/zadler32.c - src/share/native/java/util/zip/zlib-1.2.3/zconf.h - src/share/native/java/util/zip/zlib-1.2.3/zcrc32.c - src/share/native/java/util/zip/zlib-1.2.3/zlib.h - src/share/native/java/util/zip/zlib-1.2.3/zutil.c - src/share/native/java/util/zip/zlib-1.2.3/zutil.h - test/java/util/ResourceBundle/Control/ExpirationTest.java - test/java/util/ResourceBundle/Control/ExpirationTest.sh Changeset: 75bd7295c706 Author: bagiras Date: 2011-12-19 15:21 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/75bd7295c706 7117334: Warnings cleanup day: reduce number of javac warnings in the java.awt package Reviewed-by: art, denis, alexsch ! src/share/classes/java/awt/AWTEvent.java ! src/share/classes/java/awt/AWTEventMulticaster.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Font.java ! src/share/classes/java/awt/Toolkit.java ! src/share/classes/java/awt/image/ColorModel.java Changeset: d15f38f08ce9 Author: denis Date: 2011-12-19 16:44 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d15f38f08ce9 7117011: Reduce number of warnings in sun/awt/windows and sun/awt/datatransfer Reviewed-by: art ! src/share/classes/sun/awt/datatransfer/DataTransferer.java ! src/share/classes/sun/awt/dnd/SunDragSourceContextPeer.java ! src/solaris/classes/sun/awt/X11/XClipboard.java ! src/windows/classes/sun/awt/windows/TranslucentWindowPainter.java ! src/windows/classes/sun/awt/windows/WBufferStrategy.java ! src/windows/classes/sun/awt/windows/WChoicePeer.java ! src/windows/classes/sun/awt/windows/WClipboard.java ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/awt/windows/WDataTransferer.java ! src/windows/classes/sun/awt/windows/WDesktopProperties.java ! src/windows/classes/sun/awt/windows/WDialogPeer.java ! src/windows/classes/sun/awt/windows/WEmbeddedFrame.java ! src/windows/classes/sun/awt/windows/WFileDialogPeer.java ! src/windows/classes/sun/awt/windows/WFramePeer.java ! src/windows/classes/sun/awt/windows/WInputMethod.java ! src/windows/classes/sun/awt/windows/WMenuItemPeer.java ! src/windows/classes/sun/awt/windows/WPageDialog.java ! src/windows/classes/sun/awt/windows/WPageDialogPeer.java ! src/windows/classes/sun/awt/windows/WPrintDialog.java ! src/windows/classes/sun/awt/windows/WPrintDialogPeer.java ! src/windows/classes/sun/awt/windows/WToolkit.java ! src/windows/classes/sun/awt/windows/WWindowPeer.java Changeset: cded2429cdbf Author: anthony Date: 2011-12-20 12:48 +0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cded2429cdbf 7122796: SunToolkit constructor should create the EventQueue for the Main AppContext Summary: Always create an EQ for the main AppContext in SunToolkit constructor Reviewed-by: art ! src/share/classes/sun/awt/AppContext.java ! src/share/classes/sun/awt/SunToolkit.java + test/java/awt/EventQueue/MainAppContext/MainAppContext.java Changeset: 94d7051cca13 Author: lana Date: 2011-12-20 15:26 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94d7051cca13 Merge - src/share/classes/sun/awt/FocusingTextField.java - src/share/classes/sun/awt/HorizBagLayout.java - src/share/classes/sun/awt/OrientableFlowLayout.java - src/share/classes/sun/awt/VariableGridLayout.java - src/share/classes/sun/awt/VerticalBagLayout.java Changeset: 570f3d893596 Author: lana Date: 2011-12-20 15:27 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/570f3d893596 Merge - src/share/classes/com/sun/tools/jdi/LinkedHashMap.java Changeset: 6f19ff39cff4 Author: lana Date: 2011-12-23 16:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6f19ff39cff4 Merge - src/share/classes/com/sun/tools/jdi/LinkedHashMap.java - src/share/classes/sun/awt/FocusingTextField.java - src/share/classes/sun/awt/HorizBagLayout.java - src/share/classes/sun/awt/OrientableFlowLayout.java - src/share/classes/sun/awt/VariableGridLayout.java - src/share/classes/sun/awt/VerticalBagLayout.java Changeset: 437255d15e76 Author: lana Date: 2011-12-28 10:51 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/437255d15e76 Merge - src/share/classes/sun/awt/FocusingTextField.java - src/share/classes/sun/awt/HorizBagLayout.java - src/share/classes/sun/awt/OrientableFlowLayout.java - src/share/classes/sun/awt/VariableGridLayout.java - src/share/classes/sun/awt/VerticalBagLayout.java From stuart.marks at oracle.com Thu Dec 29 16:38:45 2011 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Fri, 30 Dec 2011 00:38:45 +0000 Subject: hg: jdk8/tl/jdk: 7122061: add -Xlint:all -Werror to warning-free build steps Message-ID: <20111230003923.B5B754782C@hg.openjdk.java.net> Changeset: 3a7ea63302f8 Author: smarks Date: 2011-12-29 16:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3a7ea63302f8 7122061: add -Xlint:all -Werror to warning-free build steps Reviewed-by: chegar, alanb, dholmes, ohair ! make/com/sun/demo/jvmti/hprof/Makefile ! make/com/sun/java/browser/net/Makefile ! make/com/sun/tools/Makefile ! make/com/sun/tools/attach/Makefile ! make/com/sun/tracing/Makefile ! make/com/sun/tracing/dtrace/Makefile ! make/java/instrument/Makefile ! make/java/rmi/Makefile ! make/java/text/base/Makefile ! make/java/text/bidi/Makefile ! make/java/util/Makefile ! make/javax/accessibility/Makefile ! make/javax/others/Makefile ! make/javax/security/Makefile ! make/jpda/tty/Makefile ! make/sun/launcher/Makefile ! make/sun/serialver/Makefile ! make/sun/text/Makefile ! make/sun/util/Makefile From Alan.Bateman at oracle.com Fri Dec 30 07:38:59 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 30 Dec 2011 15:38:59 +0000 Subject: RFR 7125055: ContentHandler.getContent API changed in error In-Reply-To: <4EFAE38B.5000706@oracle.com> References: <4EFAE38B.5000706@oracle.com> Message-ID: <4EFDDB13.1000409@oracle.com> On 28/12/2011 09:38, chris hegarty wrote: > During some of the warning cleanups the method declaration of the > public platform API java.net.ContentHandler.getContent(URLConnection, > Class[]) was incorrectly changed. This CR proposes to revert this > change fix appropriate subclasses, so as not to re-introduce warnings > in this area. > > http://cr.openjdk.java.net/~chegar/7125055/webrev.00/webrev/ > > -Chris. Looks okay to me, would be good to fix the indentation in these methods while you are there. -Alan. From chris.hegarty at oracle.com Fri Dec 30 10:03:46 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Fri, 30 Dec 2011 18:03:46 +0000 Subject: RFR 7125055: ContentHandler.getContent API changed in error Message-ID: Thanks Alan. My editor was not showing these indentation issues. I will fix them before pushing. -Chris Alan Bateman wrote: >On 28/12/2011 09:38, chris hegarty wrote: >> During some of the warning cleanups the method declaration of the >> public platform API java.net.ContentHandler.getContent(URLConnection, >> Class[]) was incorrectly changed. This CR proposes to revert this >> change fix appropriate subclasses, so as not to re-introduce warnings >> in this area. >> >> http://cr.openjdk.java.net/~chegar/7125055/webrev.00/webrev/ >> >> -Chris. >Looks okay to me, would be good to fix the indentation in these methods >while you are there. > >-Alan. From dmitry.degrave at sun.com Sun Dec 18 10:16:56 2011 From: dmitry.degrave at sun.com (dmitry.degrave at sun.com) Date: Sun, 18 Dec 2011 18:16:56 -0000 Subject: hg: jdk8/tl/corba: 7046238: new InitialContext(); hangs Message-ID: <20111218181649.AD06647753@hg.openjdk.java.net> Changeset: 052dda3b5ce3 Author: dmeetry Date: 2011-12-18 22:12 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/052dda3b5ce3 7046238: new InitialContext(); hangs Summary: Synchronization on a single monitor for contactInfo parameters with identical hashCode() Reviewed-by: robm, skoppar ! src/share/classes/com/sun/corba/se/impl/protocol/CorbaClientRequestDispatcherImpl.java