RFR JDK-8153353: HPACK implementation

Pavel Rappo pavel.rappo at oracle.com
Tue Apr 12 20:10:21 UTC 2016


> On 12 Apr 2016, at 19:47, Chris Hegarty <chris.hegarty at oracle.com> wrote:
> 
>>> On 12 Apr 2016, at 16:56, Roger Riggs <Roger.Riggs at Oracle.com> wrote:
>>> 
>>> Since you have a TestHelper class you could put it there and not duplicate the code in several tests.
>> 
>> Thanks! Done.
>> 
>> http://cr.openjdk.java.net/~prappo/8153353/webrev.00/test/java/net/httpclient/http2/java.httpclient/sun/net/httpclient/hpack/TestHelper.java.html
>> 
>> 32     public static Random newRandom() {
>> 33         long seed = System.currentTimeMillis();
>> 34         System.out.println("new java.util.Random(" + seed + ")");
>> 35         return new Random(seed);
>> 36     }
> 
> There is no support, in the above, for running the test with a given/known seed,
> read from a system property, which is useful for reproducing ( which is the  other
> part that is provided by the test library ).

Done in-place:

http://cr.openjdk.java.net/~prappo/8153353/webrev.00/test/java/net/httpclient/http2/java.httpclient/sun/net/httpclient/hpack/TestHelper.java.html

  32     public static Random newRandom() {
* 33         long seed = Long.getLong("seed", System.currentTimeMillis());
  34         System.out.println("new java.util.Random(" + seed + ")");
  35         return new Random(seed);
  36     }



More information about the net-dev mailing list