RFR: 8151299 Http client SelectorManager overwriting read and write events

[Michael McMahon]

Thanks for the review Chris. The comments all look reasonable.

I agree SelectorAttachment is better being made static.

- Michael

On 09/03/16 10:25, Chris Hegarty wrote:
> Michael,
>
> This is a nasty bug. I agree with the notion of the attachment tracking
> the interest ops. Most of my comments are related to code-style, cleanup,
> and closing of resources by test. Rather than trying to list them I’ve included
> a webrev, generated against your patch. You can just import it, or selectively
> grab parts.
>
> http://cr.openjdk.java.net/~chegar/8151299_comments.00/
>
> Note: I dislike SelectorAttachment being a nested class of a nested class.
> And also that is holds a reference to this. So I changed this in my comments
> webrev.
>
> -Chris.
>
> On 8 Mar 2016, at 11:27, Michael McMahon <michael.x.mcmahon at oracle.com> wrote:
>
>> Could I get the following webrev reviewed please?
>>
>> http://cr.openjdk.java.net/~michaelm/8151299/webrev.1/
>>
>> Thanks,
>> Michael.