From tobiast at google.com Mon Jul 3 22:48:59 2017 From: tobiast at google.com (Tobias Thierer) Date: Mon, 3 Jul 2017 23:48:59 +0100 Subject: HTTP Client incubator API Message-ID: Hi Michael, Chris, net-dev - the attached PDF contains some additional technical feedback on the API for JEP-110 (HTTP/2 client) that is slated for inclusion as an incubator module of OpenJDK 9. Sample and demonstration code accompanying/driving the feedback is available at http://cr.openjdk.java.net/~martin/http-client/ Thanks for taking last year's feedback seriously and for coming to London to discuss parts of this feedback in more detail. We look forward to continuing to work together to set this API up for success. Tobias -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: OpenJDK 9 HTTP Client feedback June 2017.pdf Type: application/pdf Size: 193201 bytes Desc: not available URL: From felix.yang at oracle.com Tue Jul 4 06:23:54 2017 From: felix.yang at oracle.com (Felix Yang) Date: Tue, 4 Jul 2017 14:23:54 +0800 Subject: RFR 8183514/10, Remove intermittent key from httpclient test TimeoutOrdering and ErrorTest Message-ID: Hi there, please review a patch to remove intermittent key from test/java/net/httpclient/TimeoutOrdering.java test/java/net/httpclient/http2/ErrorTest.java. They have been observed to be stable after fixing of related bugs. Bug: https://bugs.openjdk.java.net/browse/JDK-8183514 Patch: diff -r e99004ee6f13 test/java/net/httpclient/TimeoutOrdering.java --- a/test/java/net/httpclient/TimeoutOrdering.java Mon Jul 03 12:54:24 2017 -0700 +++ b/test/java/net/httpclient/TimeoutOrdering.java Mon Jul 03 22:39:14 2017 -0700 @@ -38,7 +38,6 @@ /** * @test - * @key intermittent * @summary Ensures that timeouts of multiple requests are handled in correct order * @run main/othervm TimeoutOrdering */ diff -r e99004ee6f13 test/java/net/httpclient/http2/ErrorTest.java --- a/test/java/net/httpclient/http2/ErrorTest.java Mon Jul 03 12:54:24 2017 -0700 +++ b/test/java/net/httpclient/http2/ErrorTest.java Mon Jul 03 22:39:14 2017 -0700 @@ -25,7 +25,6 @@ * @test * @bug 8157105 * @library /lib/testlibrary server - * @key intermittent * @build jdk.testlibrary.SimpleSSLContext * @modules jdk.incubator.httpclient/jdk.incubator.http.internal.common * jdk.incubator.httpclient/jdk.incubator.http.internal.frame Thanks, Felix From daniel.fuchs at oracle.com Tue Jul 4 15:49:54 2017 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Tue, 4 Jul 2017 16:49:54 +0100 Subject: RFR 8183514/10, Remove intermittent key from httpclient test TimeoutOrdering and ErrorTest In-Reply-To: References: Message-ID: <77447fac-32c5-e361-e5e1-015c6e2356c9@oracle.com> Looks good to me Felix! Thanks, -- daniel On 04/07/2017 07:23, Felix Yang wrote: > Hi there, > > please review a patch to remove intermittent key from > > test/java/net/httpclient/TimeoutOrdering.java > > test/java/net/httpclient/http2/ErrorTest.java. > > They have been observed to be stable after fixing of related bugs. > > Bug: > > https://bugs.openjdk.java.net/browse/JDK-8183514 > > Patch: > > diff -r e99004ee6f13 test/java/net/httpclient/TimeoutOrdering.java > --- a/test/java/net/httpclient/TimeoutOrdering.java Mon Jul 03 > 12:54:24 2017 -0700 > +++ b/test/java/net/httpclient/TimeoutOrdering.java Mon Jul 03 > 22:39:14 2017 -0700 > @@ -38,7 +38,6 @@ > > /** > * @test > - * @key intermittent > * @summary Ensures that timeouts of multiple requests are handled in > correct order > * @run main/othervm TimeoutOrdering > */ > diff -r e99004ee6f13 test/java/net/httpclient/http2/ErrorTest.java > --- a/test/java/net/httpclient/http2/ErrorTest.java Mon Jul 03 > 12:54:24 2017 -0700 > +++ b/test/java/net/httpclient/http2/ErrorTest.java Mon Jul 03 > 22:39:14 2017 -0700 > @@ -25,7 +25,6 @@ > * @test > * @bug 8157105 > * @library /lib/testlibrary server > - * @key intermittent > * @build jdk.testlibrary.SimpleSSLContext > * @modules jdk.incubator.httpclient/jdk.incubator.http.internal.common > * jdk.incubator.httpclient/jdk.incubator.http.internal.frame > > Thanks, > > Felix > From chris.hegarty at oracle.com Thu Jul 13 12:44:57 2017 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Thu, 13 Jul 2017 13:44:57 +0100 Subject: HTTP Client incubator API In-Reply-To: References: Message-ID: <6C66D00B-5AFC-4E9A-993E-E9043271DEB5@oracle.com> Hi Tobias, > On 3 Jul 2017, at 23:48, Tobias Thierer wrote: > > Hi Michael, Chris, net-dev - > > the attached PDF contains some additional technical feedback on the API for JEP-110 (HTTP/2 client) that is slated for inclusion as an incubator module of OpenJDK 9. I extracted your comments from the pdf and filed issues in our JIRA to track them. The following JIRA filter can be used to view them: https://bugs.openjdk.java.net/issues/?filter=31878 There should be 9 separate issues. I can update/edit/modify as needed. We can continue discussion, and eventual resolution, either in JIRA comments, on list, etc, but either way these issues are now being tracked. > Sample and demonstration code accompanying/driving the feedback is available at http://cr.openjdk.java.net/~martin/http-client/ I have yet to look at this in detail, but it should be really useful when digging into the technical detail of the issues. I?ll follow up on each issue separately over the next few weeks. Regards, -Chris.