RFR:8194298 Add support for per Socket configuration of TCP keepalive

[Alan Bateman]

On 12/05/2018 10:21, vyom tewari wrote:
> :
>
> Thanks for review, please find the updated 
> webrev(http://cr.openjdk.java.net/~vtewari/8194298/webrev0.4/index.html).
I've skimmed through this webrev.

The spec for the new options mostly look good but all three include "The 
exact semantics of this socket option are socket type and system 
dependent". I assume "socket type" should be dropped from this as these 
are TCP options. Maybe you can borrow text from the TCP_NODELAY option 
where it has the statement "The socket option is specific to 
stream-oriented sockets using the TCP/IP protocol".

The changes to the NetworkChannel implementations look okay. The changes 
to the NIO tests looks okay too but would be good if you could keep the 
formatting consistent with the existing code if you can.

Ivan had good comments so I didn't spent as much time on that code and 
it seems very reviewed.

-Alan.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/net-dev/attachments/20180513/312b89e0/attachment.html>