RFR(XS): 8229912: [TESTBUG] java/net/Socks/SocksIPv6Test fails without IPv6

Alan Bateman Alan.Bateman at oracle.com
Wed Aug 21 10:30:00 UTC 2019



On 21/08/2019 11:09, Nick Gasson wrote:
> Hi,
>
> Thanks Alan and Daniel for the suggestions. I've made these changes here:
>
> http://cr.openjdk.java.net/~ngasson/8229912/webrev.1/
This looks okay to me.

Daniel - if there are other changes to this test then it might be worth 
re-examining the ensureXXX methods. The naming is very strange as they 
return a boolean. Also they print messages to say that the test is 
skipped but it's the caller that will determinate that, not the 
ensureXXX methods.


More information about the net-dev mailing list