RFR[8236105]: Behaviors of DatagramSocket/DatagramChannel::socket send methods are not always consistent

[Daniel Fuchs]

Hi Patrick,

DatagramSocket.java:

  694      *             is not set.

  this line needs to be removed.

Otherwise this looks good to me.
A release note might get requested by the CSR lead.

best regards,

-- daniel

On 13/01/2020 16:30, Patrick Concannon wrote:
> Hi,
> 
> Could someone please review my fix and CSR for issue JDK-8236105 
> 'Behaviors of DatagramSocket/DatagramChannel::socket send methods are 
> not always consistent' ?
> 
> The behaviour of the send methods for DatagramSocket, MulticastSocket, 
> DatagramChannel and DatagramSocketAdaptor are not consistent when given 
> a DatagramPacket with invalid details. This fix adds a check to ensure 
> that the exceptions thrown by the send method of DatagramSocket and 
> MulticastSocket match the exception thrown by DatagramChannel and 
> DatagramSocketAdaptor i.e. IllegalArgumentException
> 
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8236105
> 
> CSR: https://bugs.openjdk.java.net/browse/JDK-8236940
> webrev: http://cr.openjdk.java.net/~pconcannon/8236105/webrevs/webrev.00/
> 
> 
> Kind regards,
> 
> Patrick