RFR: 8267990: Revisit some uses of `synchronized` in the HttpClient API

Chris Hegarty chegar at openjdk.java.net
Mon May 31 16:34:24 UTC 2021

On Mon, 31 May 2021 16:21:29 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

> The Utils.remaining(List<ByteBuffer> list) method assumes that it can and should synchronize on the given list to prevent concurrent modification. In 99% of the cases this assumption is wrong. There's only one such list (the SSLFlowDelegate writeList) that requires this synchronization. 
> Also the `SequentialScheduler.synchronizedScheduler` uses `synchronized`, it could use a Lock instead and this would make it possible to assert that there is no contention (since the logic of the SequentialScheduler is supposed to prevent contention from occurring at this place).

Marked as reviewed by chegar (Reviewer).


PR: https://git.openjdk.java.net/jdk/pull/4275

More information about the net-dev mailing list