JDK 9 RFR of 8176237: (fs) java/nio/file/FileStore/Basic.java should conditionally check FileStores
Chris Hegarty
chris.hegarty at oracle.com
Thu Mar 9 12:30:24 UTC 2017
> On 9 Mar 2017, at 11:46, Alan Bateman <Alan.Bateman at oracle.com> wrote:
>
>
>
> On 07/03/2017 00:28, Brian Burkhalter wrote:
>> Please review a patch for this test issue:
>>
>> Issue: https://bugs.openjdk.java.net/browse/JDK-8176237
>> Patch: http://javaweb.us.oracle.com/~bburkhal/jdk9/review/8176237/webrev.00/
>>
>> Similar to the change previously submitted in the patch for [1], attempt to access the FileStore enumeration only if “df” does not hang (Unix-only). Also move the “df” file system accessibility test code to jdk.testlibrary.FileUtils#areFileSystemsAccessible.
>>
> Looks okay but FileUtils.areFileSystemsAccessible() needs a comment so that future users of this test infrastructure have something to read.
Also, FileUtils already has a field, `isWindows`, that can be used
rather than re-reading the `os.name` system property.
-Chris.
More information about the nio-dev
mailing list