8222774: (ch) Replace uses of stateLock and blockingLock with explicit locks

Alan Bateman Alan.Bateman at oracle.com
Tue Apr 23 20:05:23 UTC 2019


On 23/04/2019 19:30, Brian Burkhalter wrote:
> When the test is run on my machine without the source patch applied it 
> timed out in testConcurrentReadWrite1() but passes with the patch.
>
> The @bug tag lists 4430139 which I suppose is intentional.
>
Right, all of testConcurrentXXX tests will hang with jdk/jdk as the 
adaptors have never supported concurrent operations.

Yes, the @bug line is intensional as the new test covers the JDK-4430139 
(and a lot more) so the specific old test is removed.

Daniel sits nearby and we talked a bit about the loops to deal with 
EINTR/retry. They are changed to while loops to make them a bit easier 
to reader. I see Martin's comment about the 4 cases where timeouts are 
using the 2-arg convert rather than toMillis or toNanos so I've changed 
those too. The update webrev is here:

http://cr.openjdk.java.net/~alanb/8222774/1/webrev/index.html

-Alan


More information about the nio-dev mailing list