RFR: 8264400: (fs) WindowsFileStore equality depends on how the FileStore was constructed [v6]
Alan Bateman
alanb at openjdk.java.net
Sat Apr 10 06:46:24 UTC 2021
On Fri, 9 Apr 2021 22:24:03 GMT, Andrey Turbanov <github.com+741251+turbanoff at openjdk.org> wrote:
>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8264400: Remove vestigial FileSystems.getDefault()
>
> src/java.base/windows/classes/sun/nio/fs/WindowsFileStore.java line 257:
>
>> 255: root.toLowerCase(Locale.ROOT).hashCode() : root.hashCode();
>> 256: }
>> 257: return hashCode;
>
> As I know, to make data race benign, field should be read only once. But there is second read which can still return `0`
You can are right, missed in the final review (as this one went through many iterations).
-------------
PR: https://git.openjdk.java.net/jdk/pull/3279
More information about the nio-dev
mailing list