RFR: 8265226: (dc) API note in DatagramChannel.open should link to StandardProtocolFamily.UNIX [v3]

Michael McMahon michaelm at openjdk.java.net
Mon Apr 19 09:35:09 UTC 2021


> Hi,
> 
> Could I get the following change reviewed please (which may need a CSR)?
> 
> It should have been considered as part of (8262883) which was integrated earlier today.
> Any other comments on that change can be considered here too.
> 
> This is the change:
> 
> 
> diff a/src/java.base/share/classes/java/nio/channels/DatagramChannel.java b/src/java.base/share/classes/java/nio/channels/DatagramChannel.java
> --- a/src/java.base/share/classes/java/nio/channels/DatagramChannel.java
> +++ b/src/java.base/share/classes/java/nio/channels/DatagramChannel.java
> @@ -170,12 +170,11 @@
>       * java.nio.channels.spi.SelectorProvider#openDatagramChannel(ProtocolFamily)
>       * openDatagramChannel} method of the system-wide default {@link
>       * java.nio.channels.spi.SelectorProvider} object.  The channel will not be
>       * connected.
>       *
> -     * @apiNote {@linkplain java.net.UnixDomainSocketAddress Unix domain} sockets
> -     * are not supported by DatagramChannel.
> +     * @apiNote {@link java.net.StandardProtocolFamily#UNIX} is not supported.
>       *
>       * @param   family
>       *          The protocol family
>       *
>       * @return  A new datagram channel
> 
> 
> Thanks,
> 
> Michael.

Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:

  fixed whitespace error

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3494/files
  - new: https://git.openjdk.java.net/jdk/pull/3494/files/6f32b9a5..d6595144

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3494&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3494&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3494.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3494/head:pull/3494

PR: https://git.openjdk.java.net/jdk/pull/3494


More information about the nio-dev mailing list