<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Thanks Brian. Reviewed.<div class=""><br class=""></div><div class="">-Chris.<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 8 Jan 2020, at 18:22, Brian Burkhalter <<a href="mailto:brian.burkhalter@oracle.com" class="">brian.burkhalter@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html; charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><a href="https://bugs.openjdk.java.net/browse/JDK-8236804" class="">https://bugs.openjdk.java.net/browse/JDK-8236804</a> following up on the comments below.<div class=""><br class=""></div><div class="">Diff:</div><div class=""><br class=""></div><div class=""><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgba(255, 255, 255, 0.811765);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">--- a/test/jdk/java/nio/channels/FileChannel/MapWithSecurityManager.java</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgba(255, 255, 255, 0.811765);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">+++ b/test/jdk/java/nio/channels/FileChannel/MapWithSecurityManager.java</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgba(255, 255, 255, 0.811765);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">@@ -24,6 +24,7 @@</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgba(255, 255, 255, 0.811765);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> /* @test</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgba(255, 255, 255, 0.811765);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">  * @bug 8236582</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgba(255, 255, 255, 0.811765);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">  * @summary Tests the map method when running with a security manager</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgba(255, 255, 255, 0.811765);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">+ * @run main/othervm MapWithSecurityManager</span></div><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; background-color: rgba(255, 255, 255, 0.811765);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">  */</span></div><div class=""><span style="font-variant-ligatures: no-common-ligatures" class=""><br class=""></span></div><div class="">Thanks,</div><div class=""><br class=""></div><div class="">Brian</div><div class=""><br class=""><blockquote type="cite" class=""><div class="">On Jan 8, 2020, at 8:44 AM, Brian Burkhalter <<a href="mailto:brian.burkhalter@oracle.com" class="">brian.burkhalter@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;"><div class=""><blockquote type="cite" class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;"><div class="">On Jan 8, 2020, at 4:20 AM, Chris Hegarty <<a href="mailto:chris.hegarty@oracle.com" class="">chris.hegarty@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;"><div class=""><blockquote type="cite" class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;"><div class="">So modified: <span class=""><a href="http://cr.openjdk.java.net/~bpb/8236582/webrev.02/" class="">http://cr.openjdk.java.net/~bpb/8236582/webrev.02/</a></span><span class="">.</span></div></div></div></blockquote></div><br class=""><div class="">The source changes look good.</div><div class=""><br class=""></div><div class=""><div class="">The test should be run in othervm mode, since it depends on triggering</div><div class="">the loading of ExtendedMapMode when a security manager is present -</div><div class="">which is not guaranteed to be the case as the test stands. For example,</div><div class="">the test passes ( without the fix ) when I run it with all the other</div><div class="">tests in test/jdk/java/nio/channels/FileChannel/ and `-conc:1 -agentvm`</div><div class="">- since ExtendedMapMode is loaded from a previous test run in the same</div><div class="">agent.</div><div class=""><br class=""></div><div class="">  * @run main/othervm MapWithSecurityManager</div></div></div></div></blockquote></div><br class=""><div class="">Oops, already pushed before I saw this message. I guess I’ll open another issue to make the change to the test.</div></div></div></blockquote></div><br class=""></div></div></div></blockquote></div><br class=""></div></body></html>