<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Brian,<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 7 Jan 2020, at 19:35, Brian Burkhalter <<a href="mailto:brian.burkhalter@oracle.com" class="">brian.burkhalter@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html; charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">...<br class=""><br class=""><div class="">So modified: <span class=""><a href="http://cr.openjdk.java.net/~bpb/8236582/webrev.02/" class="">http://cr.openjdk.java.net/~bpb/8236582/webrev.02/</a></span><span class="">.</span></div></div></div></blockquote></div><br class=""><div class="">The source changes look good.</div><div class=""><br class=""></div><div class=""><div class="">The test should be run in othervm mode, since it depends on triggering</div><div class="">the loading of ExtendedMapMode when a security manager is present -</div><div class="">which is not guaranteed to be the case as the test stands. For example,</div><div class="">the test passes ( without the fix ) when I run it with all the other</div><div class="">tests in test/jdk/java/nio/channels/FileChannel/ and `-conc:1 -agentvm`</div><div class="">- since ExtendedMapMode is loaded from a previous test run in the same</div><div class="">agent.</div><div class=""><br class=""></div><div class=""> * @run main/othervm MapWithSecurityManager</div><div class=""><br class=""></div></div><div class="">-Chris.</div></body></html>