<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body>
<p><tt>Thank you Lance.</tt></p>
<p><tt>-Jaikiran</tt><br>
</p>
<div class="moz-cite-prefix">On 12/01/20 2:26 am, Lance Andersen
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:5278C64C-9BF1-4616-BA7E-67771FD3AB3D@oracle.com">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
I am happy to sponsor this next week after providing time for
additional review feedback and also sanity check it via Mach5
<div class=""><br class="">
</div>
<div class="">Best</div>
<div class="">Lance<br class="">
<div><br class="">
<blockquote type="cite" class="">
<div class="">On Jan 11, 2020, at 5:24 AM, Jaikiran Pai <<a
href="mailto:jai.forums2013@gmail.com" class=""
moz-do-not-send="true">jai.forums2013@gmail.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class=""><span style="caret-color: rgb(0, 0, 0);
font-family: Helvetica; font-size: 15px; font-style:
normal; font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none; float: none; display: inline
!important;" class="">Hello Alan,</span><br
style="caret-color: rgb(0, 0, 0); font-family:
Helvetica; font-size: 15px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none;" class="">
<br style="caret-color: rgb(0, 0, 0); font-family:
Helvetica; font-size: 15px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none;" class="">
<span style="caret-color: rgb(0, 0, 0); font-family:
Helvetica; font-size: 15px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none; float: none; display: inline
!important;" class="">On 11/01/20 3:37 pm, Alan Bateman
wrote:</span><br style="caret-color: rgb(0, 0, 0);
font-family: Helvetica; font-size: 15px; font-style:
normal; font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none;" class="">
<blockquote type="cite" style="font-family: Helvetica;
font-size: 15px; font-style: normal; font-variant-caps:
normal; font-weight: normal; letter-spacing: normal;
orphans: auto; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal; widows: auto;
word-spacing: 0px; -webkit-text-size-adjust: auto;
-webkit-text-stroke-width: 0px; text-decoration: none;"
class="">On 11/01/2020 09:51, Jaikiran Pai wrote:<br
class="">
<blockquote type="cite" class="">:<br class="">
<br class="">
The commit here fixes that issue by simply clearing
the "inodes" map in<br class="">
the jdk.nio.zipfs.ZipFileSystem.close() method. I have
checked the usage<br class="">
of the "inodes" map and from what I see, it's usage in
various places is<br class="">
guarded by "ensureOpen" checks, which means that once
the ZipFileSystem<br class="">
instance is closed, the contents of these "inodes" map
is no longer<br class="">
relevant and hence clearing it shouldn't cause any
issues.<br class="">
<br class="">
</blockquote>
Clearing the inodes map should be okay for cases where
something is<br class="">
holding a reference to a closed zip file system.
However, you should<br class="">
look at beginWrite/endWrite so that all access to the
map is<br class="">
consistently synchronized.<br class="">
<br class="">
</blockquote>
<span style="caret-color: rgb(0, 0, 0); font-family:
Helvetica; font-size: 15px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none; float: none; display: inline
!important;" class="">Thank you very much for that input
- I hadn't considered the concurrency</span><br
style="caret-color: rgb(0, 0, 0); font-family:
Helvetica; font-size: 15px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none;" class="">
<span style="caret-color: rgb(0, 0, 0); font-family:
Helvetica; font-size: 15px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none; float: none; display: inline
!important;" class="">aspect of it. Based on your input
and after looking at the usage of the</span><br
style="caret-color: rgb(0, 0, 0); font-family:
Helvetica; font-size: 15px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none;" class="">
<span style="caret-color: rgb(0, 0, 0); font-family:
Helvetica; font-size: 15px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none; float: none; display: inline
!important;" class="">"inodes", I have now updated the
patch to use proper locks during the</span><br
style="caret-color: rgb(0, 0, 0); font-family:
Helvetica; font-size: 15px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none;" class="">
<span style="caret-color: rgb(0, 0, 0); font-family:
Helvetica; font-size: 15px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none; float: none; display: inline
!important;" class="">clearing of the inodes. The
updated webrev is available at</span><br
style="caret-color: rgb(0, 0, 0); font-family:
Helvetica; font-size: 15px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none;" class="">
<a
href="https://cr.openjdk.java.net/~jpai/webrev/7143743/2/webrev/"
style="font-family: Helvetica; font-size: 15px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal; widows: auto;
word-spacing: 0px; -webkit-text-size-adjust: auto;
-webkit-text-stroke-width: 0px;" class=""
moz-do-not-send="true">https://cr.openjdk.java.net/~jpai/webrev/7143743/2/webrev/</a><br
style="caret-color: rgb(0, 0, 0); font-family:
Helvetica; font-size: 15px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none;" class="">
<br style="caret-color: rgb(0, 0, 0); font-family:
Helvetica; font-size: 15px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none;" class="">
<span style="caret-color: rgb(0, 0, 0); font-family:
Helvetica; font-size: 15px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none; float: none; display: inline
!important;" class="">-Jaikiran</span></div>
</blockquote>
</div>
<br class="">
<div class="">
<div class=""><span class="Apple-style-span"
style="border-collapse: separate; border-spacing: 0px; "><span
class="Apple-style-span" style="color: rgb(102, 102,
102); font-family: Verdana, Arial, Helvetica,
sans-serif; font-size: small; "><a
href="http://oracle.com/us/design/oracle-email-sig-198324.gif"
class="" moz-do-not-send="true"><span><img
apple-inline="yes"
id="4F74B990-7D45-41AE-9D9E-E2B455FAEF30"
src="cid:part3.F731D3ED.6BCABBC3@gmail.com"
class=""></span></a>
<div style="color: rgb(0, 0, 0); font-family: Helvetica;
font-size: medium; font-style: normal; font-variant:
normal; font-weight: normal; letter-spacing: normal;
line-height: normal; orphans: 2; text-align:
-webkit-auto; text-indent: 0px; text-transform: none;
white-space: normal; widows: 2; word-spacing: 0px;
-webkit-text-size-adjust: auto;
-webkit-text-stroke-width: 0px; " class=""><a
href="http://oracle.com/us/design/oracle-email-sig-198324.gif"
class="" moz-do-not-send="true"><span
class="Apple-style-span" style="border-collapse:
separate; border-spacing: 0px; "><span
class="Apple-style-span" style="color: rgb(102,
102, 102); font-family: Verdana, Arial,
Helvetica, sans-serif; font-size: small; "></span></span></a><a
href="http://oracle.com/us/design/oracle-email-sig-198324.gif" class=""
moz-do-not-send="true"><span
class="Apple-style-span" style="border-collapse:
separate; color: rgb(0, 0, 0); font-family:
Helvetica; border-spacing: 0px;
-webkit-text-decorations-in-effect: none; "><span
class="Apple-style-span" style="color: rgb(102,
102, 102); font-family: Verdana, Arial,
Helvetica, sans-serif; font-size: small; "><span
class="Apple-style-span"
style="border-collapse: separate; color:
rgb(0, 0, 0); font-family: Helvetica;
border-spacing: 0px;
-webkit-text-decorations-in-effect: none; "></span></span></span></a><a
href="http://oracle.com/us/design/oracle-email-sig-198324.gif" class=""
moz-do-not-send="true"><br class="">
</a><span style="color: rgb(102, 102, 102);
font-family: Verdana, Arial, Helvetica, sans-serif;
font-size: small; " class="">Lance Andersen|
Principal Member of Technical Staff |
+1.781.442.2037</span><br style="color: rgb(102,
102, 102); font-family: Verdana, Arial, Helvetica,
sans-serif; font-size: small; " class="">
<font style="font-family: Verdana, Arial, Helvetica,
sans-serif; font-size: small; " class=""
color="#FF0000">Oracle</font><span style="color:
rgb(102, 102, 102); font-family: Verdana, Arial,
Helvetica, sans-serif; font-size: small; " class=""> Java
Engineering </span><br style="color: rgb(102, 102,
102); font-family: Verdana, Arial, Helvetica,
sans-serif; font-size: small; " class="">
<span style="color: rgb(102, 102, 102); font-family:
Verdana, Arial, Helvetica, sans-serif; font-size:
small; " class="">1 Network Drive </span><br
style="color: rgb(102, 102, 102); font-family:
Verdana, Arial, Helvetica, sans-serif; font-size:
small; " class="">
<span style="color: rgb(102, 102, 102); font-family:
Verdana, Arial, Helvetica, sans-serif; font-size:
small; " class="">Burlington, MA 01803</span><br
style="color: rgb(102, 102, 102); font-family:
Verdana, Arial, Helvetica, sans-serif; font-size:
small; " class="">
<a href="mailto:Lance.Andersen@oracle.com"
style="font-family: Verdana, Arial, Helvetica,
sans-serif; font-size: small; " class=""
moz-do-not-send="true">Lance.Andersen@oracle.com</a></div>
<div style="color: rgb(0, 0, 0); font-family: Helvetica;
font-style: normal; font-variant: normal; font-weight:
normal; letter-spacing: normal; line-height: normal;
orphans: 2; text-align: -webkit-auto; text-indent:
0px; text-transform: none; white-space: normal;
widows: 2; word-spacing: 0px;
-webkit-text-size-adjust: auto;
-webkit-text-stroke-width: 0px; " class=""><br
class="">
</div>
<br class="Apple-interchange-newline">
</span></span></div>
</div>
<br class="">
</div>
</blockquote>
</body>
</html>