RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

Ajit Ghaisas aghaisas at openjdk.java.net
Wed Feb 19 11:44:54 UTC 2020


On Sat, 15 Feb 2020 14:54:50 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> thanks, Kevin - that's what I tried, but it refused to accept the second .. so sticking with single comments until I feel like digging into this weirdness.
> 
> Regarding the fix, it seems that you need to eliminate the `rtl` variable you added earlier, and move the test into the listener, like this:
> 
>     new KeyMapping(LEFT, e -> isRtl() ? selectRightCell() : selectLeftCell()),

@kevinrushforth, this new KeyMapping suggestion does not compile.
We need something like - 
`new KeyMapping(LEFT, e -> { if(isRTL()) selectRightCell(); else selectLeftCell();}),`

-------------

PR: https://git.openjdk.java.net/jfx/pull/114


More information about the openjfx-dev mailing list